@sentry/junior-dashboard 0.265.0 → 0.267.0

package/src/client/conversations/transcriptMarkdownLinks.ts

@@ -1,331 +1,11 @@
 export const TRANSCRIPT_ANCHOR_CLASS =
   "font-medium text-dashboard-accent-text underline decoration-dashboard-accent/35 underline-offset-2 transition-colors hover:text-dashboard-text hover:decoration-dashboard-text-solid";
 
-export type TranscriptMarkdownLink = {
-  end: number;
-  href: string;
-  label: string;
-  start: number;
-};
-
-type TextRange = {
-  end: number;
-  start: number;
-};
-
-/** Find safe markdown and bare links that should become transcript anchors. */
-export function findTranscriptMarkdownLinks(
-  text: string,
-): TranscriptMarkdownLink[] {
-  const literalRanges = findLiteralRanges(text);
-  const markdownSyntaxRanges = findMarkdownLinkSyntaxRanges(
-    text,
-    literalRanges,
-  );
-  const markdownLinks = findMarkdownLinks(text, literalRanges);
-  const autolinks = findCommonMarkAutolinks(
-    text,
-    mergeRanges([...literalRanges, ...markdownSyntaxRanges]),
-  );
-  const bareRanges = mergeRanges([
-    ...literalRanges,
-    ...markdownSyntaxRanges,
-    ...autolinks,
-  ]);
-  return [
-    ...markdownLinks,
-    ...autolinks,
-    ...findBareLinks(text, bareRanges),
-  ].sort((left, right) => left.start - right.start || left.end - right.end);
-}
-
-function findMarkdownLinks(
-  text: string,
-  ignoredRanges: TextRange[],
-): TranscriptMarkdownLink[] {
-  const links: TranscriptMarkdownLink[] = [];
-  let cursor = 0;
-  while (cursor < text.length) {
-    const link = findNextMarkdownLink(text, cursor, ignoredRanges);
-    if (!link) break;
-    links.push(link);
-    cursor = link.end;
-  }
-  return links;
-}
-
-function findNextMarkdownLink(
-  text: string,
-  start: number,
-  ignoredRanges: TextRange[],
-): TranscriptMarkdownLink | undefined {
-  for (
-    let linkStart = text.indexOf("[", start);
-    linkStart >= 0;
-    linkStart = text.indexOf("[", linkStart + 1)
-  ) {
-    if (isInRange(linkStart, ignoredRanges) || isEscaped(text, linkStart)) {
-      continue;
-    }
-
-    const labelEnd = text.indexOf("]", linkStart + 1);
-    if (labelEnd < 0) return undefined;
-    if (text[labelEnd + 1] !== "(") continue;
-
-    const label = text.slice(linkStart + 1, labelEnd);
-    if (!isMarkdownLinkLabel(label)) continue;
-
-    const destination = readMarkdownDestination(text, labelEnd + 2);
-    if (!destination) continue;
-
-    const href = safeMarkdownDestinationHref(destination.href);
-    if (!href) continue;
-
-    return {
-      end: destination.end,
-      href,
-      label,
-      start: linkStart,
-    };
-  }
-  return undefined;
-}
-
-function findMarkdownLinkSyntaxRanges(
-  text: string,
-  ignoredRanges: TextRange[],
-): TextRange[] {
-  const ranges: TextRange[] = [];
-  for (
-    let linkStart = text.indexOf("[");
-    linkStart >= 0;
-    linkStart = text.indexOf("[", linkStart + 1)
-  ) {
-    if (isInRange(linkStart, ignoredRanges) || isEscaped(text, linkStart)) {
-      continue;
-    }
-
-    const labelEnd = text.indexOf("]", linkStart + 1);
-    if (labelEnd < 0) continue;
-    if (text[labelEnd + 1] !== "(") continue;
-
-    const label = text.slice(linkStart + 1, labelEnd);
-    if (!isMarkdownLinkLabel(label)) continue;
-
-    const destination = readMarkdownDestination(text, labelEnd + 2);
-    if (!destination) continue;
-
-    ranges.push({ start: linkStart, end: destination.end });
-  }
-  return ranges;
-}
-
-function isMarkdownLinkLabel(label: string): boolean {
-  return Boolean(label) && !label.includes("\n") && !label.includes("[");
-}
-
-function readMarkdownDestination(
-  text: string,
-  start: number,
-): { end: number; href: string } | undefined {
-  let depth = 0;
-  for (let index = start; index < text.length; index += 1) {
-    const char = text[index];
-    if (char === "\\") {
-      index += 1;
-      continue;
-    }
-    if (char === "(") {
-      depth += 1;
-      continue;
-    }
-    if (char !== ")") continue;
-
-    if (depth > 0) {
-      depth -= 1;
-      continue;
-    }
-
-    const href = text.slice(start, index);
-    return href ? { end: index + 1, href } : undefined;
-  }
-  return undefined;
-}
-
-function findCommonMarkAutolinks(
-  text: string,
-  ignoredRanges: TextRange[],
-): TranscriptMarkdownLink[] {
-  const links: TranscriptMarkdownLink[] = [];
-  const pattern = /<(https?:\/\/[^<>\s]+|mailto:[^<>\s]+)>/gi;
-  let match: RegExpExecArray | null;
-
-  while ((match = pattern.exec(text))) {
-    if (isInRange(match.index, ignoredRanges) || isEscaped(text, match.index)) {
-      continue;
-    }
-    const href = safeLinkHref(match[1] ?? "");
-    if (!href) continue;
-    links.push({
-      end: match.index + match[0].length,
-      href,
-      label: href,
-      start: match.index,
-    });
-  }
-  return links;
-}
-
-function findNextBareLink(
-  text: string,
-  start: number,
-  ignoredRanges: TextRange[],
-): TranscriptMarkdownLink | undefined {
-  // Stop at * so emphasis markers stay outside the URL, matching Slack outbound
-  // bare-URL wrapping (`readBareUrl` in packages/junior/src/chat/slack/mrkdwn.ts).
-  const bareUrlPattern = /(https?:\/\/[^\s<>"'*]+|mailto:[^\s<>"'*]+)/gi;
-  bareUrlPattern.lastIndex = start;
-
-  let match: RegExpExecArray | null;
-  while ((match = bareUrlPattern.exec(text))) {
-    if (isInRange(match.index, ignoredRanges)) continue;
-
-    const bareLink = trimBareUrl(match[0]);
-    const href = safeLinkHref(bareLink);
-    if (!href) continue;
-
-    return {
-      end: match.index + bareLink.length,
-      href,
-      label: href,
-      start: match.index,
-    };
-  }
-  return undefined;
-}
-
-function findBareLinks(
-  text: string,
-  ignoredRanges: TextRange[],
-): TranscriptMarkdownLink[] {
-  const links: TranscriptMarkdownLink[] = [];
-  let cursor = 0;
-  while (cursor < text.length) {
-    const link = findNextBareLink(text, cursor, ignoredRanges);
-    if (!link) break;
-    links.push(link);
-    cursor = link.end;
-  }
-  return links;
-}
-
-function findLiteralRanges(text: string): TextRange[] {
-  return [...findInlineCodeRanges(text), ...findEscapedMarkdownLinkRanges(text)]
-    .filter((range) => range.end > range.start)
-    .sort((left, right) => left.start - right.start || left.end - right.end);
-}
-
-function findInlineCodeRanges(text: string): TextRange[] {
-  const ranges: TextRange[] = [];
-  for (let index = 0; index < text.length; index += 1) {
-    if (text[index] !== "`" || isEscaped(text, index)) continue;
-
-    const ticks = countRun(text, index, "`");
-    const closing = findClosingBacktickRun(text, index + ticks, ticks);
-    if (closing < 0) {
-      index += ticks - 1;
-      continue;
-    }
-
-    ranges.push({ start: index, end: closing + ticks });
-    index = closing + ticks - 1;
-  }
-  return ranges;
-}
-
-function findClosingBacktickRun(
-  text: string,
-  start: number,
-  ticks: number,
-): number {
-  for (let index = start; index < text.length; index += 1) {
-    if (text[index] !== "`" || isEscaped(text, index)) continue;
-
-    const run = countRun(text, index, "`");
-    if (run === ticks) return index;
-    index += run - 1;
-  }
-  return -1;
-}
-
-function findEscapedMarkdownLinkRanges(text: string): TextRange[] {
-  const ranges: TextRange[] = [];
-  for (
-    let linkStart = text.indexOf("[");
-    linkStart >= 0;
-    linkStart = text.indexOf("[", linkStart + 1)
-  ) {
-    if (!isEscaped(text, linkStart)) continue;
-
-    const labelEnd = text.indexOf("]", linkStart + 1);
-    if (labelEnd < 0) continue;
-    if (text[labelEnd + 1] !== "(") continue;
-
-    const destination = readMarkdownDestination(text, labelEnd + 2);
-    if (!destination) continue;
-
-    ranges.push({ start: linkStart, end: destination.end });
-  }
-  return ranges;
-}
-
-function isInRange(index: number, ranges: TextRange[]): boolean {
-  for (const range of ranges) {
-    if (index < range.start) return false;
-    if (index >= range.start && index < range.end) return true;
-  }
-  return false;
-}
-
-function isEscaped(text: string, index: number): boolean {
-  let backslashes = 0;
-  for (
-    let cursor = index - 1;
-    cursor >= 0 && text[cursor] === "\\";
-    cursor -= 1
-  ) {
-    backslashes += 1;
-  }
-  return backslashes % 2 === 1;
-}
-
-function countRun(text: string, start: number, char: string): number {
-  let count = 0;
-  for (
-    let index = start;
-    index < text.length && text[index] === char;
-    index += 1
-  ) {
-    count += 1;
-  }
-  return count;
-}
-
-function safeMarkdownDestinationHref(destination: string): string | undefined {
-  const href = readMarkdownHref(destination);
-  return href ? safeLinkHref(href) : undefined;
-}
-
-function readMarkdownHref(destination: string): string | undefined {
-  const trimmed = destination.trim();
-  const match =
-    /^(<[^>\n]+>|[^\s]+)(?:\s+(?:"[^"]*"|'[^']*'|\([^)]*\)))?$/.exec(trimmed);
-  const href = match?.[1];
-  if (!href) return undefined;
-  return href.startsWith("<") && href.endsWith(">") ? href.slice(1, -1) : href;
-}
-
-function safeLinkHref(href: string): string | undefined {
+/**
+ * Keep a transcript link destination only when it is an absolute `http:`,
+ * `https:`, or `mailto:` URL. Return undefined to drop the link.
+ */
+export function safeTranscriptHref(href: string): string | undefined {
   const trimmed = href.trim();
   const hasControlCharacter = [...trimmed].some((character) => {
     const code = character.charCodeAt(0);
@@ -343,45 +23,3 @@ function safeLinkHref(href: string): string | undefined {
     return undefined;
   }
 }
-
-function trimBareUrl(href: string): string {
-  let trimmed = href;
-
-  while (shouldTrimBareUrlSuffix(trimmed)) {
-    trimmed = trimmed.slice(0, -1);
-  }
-
-  return trimmed;
-}
-
-function shouldTrimBareUrlSuffix(href: string): boolean {
-  const last = href.at(-1);
-  if (!last) return false;
-  if (/[.,;:!?]/.test(last)) return true;
-  return last === ")" && closingParensExceedOpening(href);
-}
-
-function closingParensExceedOpening(value: string): boolean {
-  let balance = 0;
-  for (const char of value) {
-    if (char === "(") balance += 1;
-    if (char === ")") balance -= 1;
-  }
-  return balance < 0;
-}
-
-function mergeRanges(ranges: TextRange[]): TextRange[] {
-  const sorted = ranges
-    .filter((range) => range.end > range.start)
-    .sort((left, right) => left.start - right.start || left.end - right.end);
-  const merged: TextRange[] = [];
-  for (const range of sorted) {
-    const previous = merged.at(-1);
-    if (!previous || range.start > previous.end) {
-      merged.push({ ...range });
-      continue;
-    }
-    previous.end = Math.max(previous.end, range.end);
-  }
-  return merged;
-}

package/src/client/conversations/transcriptMentions.tsx

@@ -43,12 +43,17 @@ export function MentionPeopleProvider(props: {
 
 /** Render one line of display text with the people the API resolved for it. */
 export function MentionText(props: {
+  /**
+   * Link people to their page. Set false inside a button, which cannot hold
+   * a link.
+   */
+  links?: boolean;
   mentions: readonly ActorIdentity[];
   text: string;
 }) {
   return (
     <MentionPeopleProvider mentions={props.mentions}>
-      {renderMentionText(props.text, "mention-text")}
+      {renderMentionText(props.text, "mention-text", props.links)}
     </MentionPeopleProvider>
   );
 }
@@ -57,7 +62,11 @@ export function MentionText(props: {
  * Render text with Slack `<@U123>` and `<#C123|name>` tokens as readable
  * mentions. It reads people from the nearest `MentionPeopleProvider`.
  */
-export function renderMentionText(text: string, keyBase: string): ReactNode[] {
+export function renderMentionText(
+  text: string,
+  keyBase: string,
+  links = true,
+): ReactNode[] {
   const nodes: ReactNode[] = [];
   let cursor = 0;
   for (const mention of findMentions(text)) {
@@ -70,7 +79,11 @@ export function renderMentionText(text: string, keyBase: string): ReactNode[] {
       );
     }
     nodes.push(
-      <MentionView key={`${keyBase}-m-${mention.start}`} mention={mention} />,
+      <MentionView
+        key={`${keyBase}-m-${mention.start}`}
+        links={links}
+        mention={mention}
+      />,
     );
     cursor = mention.end;
   }
@@ -95,13 +108,13 @@ function findMentions(text: string): TranscriptMention[] {
   }));
 }
 
-function MentionView(props: { mention: TranscriptMention }) {
+function MentionView(props: { links: boolean; mention: TranscriptMention }) {
   const people = useContext(TranscriptMentionPeople);
   const { id, label, sigil } = props.mention;
   const person = sigil === "@" ? people.get(id) : undefined;
   const name = person?.fullName ?? person?.slackUserName ?? label ?? id;
   const text = <HighlightText text={`${sigil}${name.replace(/^[@#]/, "")}`} />;
-  if (person?.email) {
+  if (props.links && person?.email) {
     return (
       <Link
         // Previews sit in cards that disable pointer events on their text.

package/src/client/conversations/userInputRequest.ts

@@ -0,0 +1,56 @@
+import {
+  userInputRequestSchema,
+  type ConversationReportEvent,
+  type UserInputRequest,
+} from "@sentry/junior/api/schema";
+
+/** Model-facing name of Junior's tool that asks a person for input. */
+const REQUEST_USER_INPUT_TOOL_NAME = "requestUserInput";
+
+/** A request from Junior that still waits for an answer. */
+export type OpenUserInputRequest = UserInputRequest & { toolCallId: string };
+
+/**
+ * Find the latest `requestUserInput` call that no user message answers yet.
+ * Any later user message is the answer, whether it is a submitted form or
+ * typed text.
+ *
+ * Reporting splits one call over events: the assistant event has the input
+ * and status `running`, and the later result event has status `completed`
+ * without the input. Keep the input by tool call id until the result.
+ */
+export function openUserInputRequest(
+  events: readonly ConversationReportEvent[] | undefined,
+): OpenUserInputRequest | undefined {
+  const inputs = new Map<string, unknown>();
+  const completed = new Set<string>();
+  let open: OpenUserInputRequest | undefined;
+  for (const event of events ?? []) {
+    const data = event.data;
+    if (data.type === "message" && data.role === "user") {
+      open = undefined;
+      continue;
+    }
+    if (data.type !== "tool_calls") continue;
+    for (const call of data.calls) {
+      if (call.name !== REQUEST_USER_INPUT_TOOL_NAME) continue;
+      if (call.input !== undefined) inputs.set(call.toolCallId, call.input);
+      if (call.status === "error" && open?.toolCallId === call.toolCallId) {
+        open = undefined;
+      }
+      // Open a request once, when its result first arrives. A repeated
+      // result must not reopen a request that a user message answered.
+      if (call.status !== "completed" || completed.has(call.toolCallId)) {
+        continue;
+      }
+      completed.add(call.toolCallId);
+      const request = userInputRequestSchema.safeParse(
+        inputs.get(call.toolCallId),
+      );
+      if (request.success) {
+        open = { ...request.data, toolCallId: call.toolCallId };
+      }
+    }
+  }
+  return open;
+}

package/src/client/format.ts

@@ -796,9 +796,16 @@ export function workspacePath(workspaceId: string): string {
   return `/system/workspaces/${encodeURIComponent(workspaceId)}`;
 }
 
-/** Build the canonical automation detail route for an automation id. */
-export function automationPath(automationId: string): string {
-  return `/automations/${encodeURIComponent(automationId)}`;
+/** Automation page tabs. Overview is the bare Automation path. */
+export type AutomationTab = "overview" | "runs" | "versions" | "edit";
+
+/** Build the route for one Automation page tab, or its edit mode. */
+export function automationPath(
+  automationId: string,
+  tab: AutomationTab = "overview",
+): string {
+  const base = `/automations/${encodeURIComponent(automationId)}`;
+  return tab === "overview" ? base : `${base}/${tab}`;
 }
 
 function normalizeLanguage(language: string | undefined): BundledLanguage {