@sentry/junior-dashboard 0.256.0 → 0.258.0

package/src/app.ts

@@ -25,11 +25,9 @@ import {
   dashboardProfileUpdateSchema,
 } from "./api/schema";
 import {
-  createDashboardAuth,
   dashboardBearerSession,
   dashboardPersonalBearerToken,
   dashboardSessionIsAuthorized,
-  resolveGoogleHostedDomainHint,
   sanitizeDashboardSession,
   verifiedDashboardSessionEmail,
   type DashboardAuth,
@@ -80,16 +78,14 @@ export interface JuniorDashboardOptions {
   baseURL?: string;
   authPath?: string;
   authRequired?: boolean;
-  allowedGoogleDomains?: string[];
-  allowedEmails?: string[];
-  sessionMaxAgeSeconds?: number;
-  trustedOrigins?: string[];
   auth?: DashboardAuth;
   componentGallery?: boolean;
   mockConversations?: boolean;
 }
 
 interface DashboardRuntimeOptions extends JuniorDashboardOptions {
+  /** The app's `allowedDomains`, from core. Auth requires at least one. */
+  allowedDomains?: string[];
   authenticatedRoutes?: readonly AuthenticatedRoute[];
   /** The queue `createApp()` uses, so web input reaches the same worker. */
   conversationWorkQueue?: ConversationWorkQueue;
@@ -117,37 +113,6 @@ function normalizeValues(values: string[] | undefined): string[] {
   ];
 }
 
-/** Read dashboard list env vars as comma-separated strings or JSON arrays. */
-function readEnvList(name: string): string[] | undefined {
-  const value = process.env[name];
-  if (!value?.trim()) {
-    return undefined;
-  }
-
-  if (value.trim().startsWith("[")) {
-    let parsed: unknown;
-    try {
-      parsed = JSON.parse(value);
-    } catch (error) {
-      throw new Error(`${name} must be a JSON string array`, {
-        cause: error,
-      });
-    }
-    if (
-      !Array.isArray(parsed) ||
-      parsed.some((item) => typeof item !== "string")
-    ) {
-      throw new Error(`${name} must be a JSON string array`);
-    }
-    return parsed;
-  }
-
-  return value
-    .split(",")
-    .map((item) => item.trim())
-    .filter(Boolean);
-}
-
 /** Read dashboard boolean env vars; only explicit true/false values apply. */
 function readEnvFlag(name: string): boolean | undefined {
   const value = process.env[name]?.trim();
@@ -164,13 +129,6 @@ function resolveDashboardOptions(
     ...options,
     authRequired:
       options.authRequired ?? readEnvFlag("JUNIOR_DASHBOARD_AUTH_REQUIRED"),
-    allowedGoogleDomains:
-      options.allowedGoogleDomains ??
-      readEnvList("JUNIOR_DASHBOARD_GOOGLE_DOMAINS"),
-    allowedEmails:
-      options.allowedEmails ?? readEnvList("JUNIOR_DASHBOARD_ALLOWED_EMAILS"),
-    trustedOrigins:
-      options.trustedOrigins ?? readEnvList("JUNIOR_DASHBOARD_TRUSTED_ORIGINS"),
     componentGallery:
       options.componentGallery ??
       readEnvFlag("JUNIOR_DASHBOARD_COMPONENT_GALLERY"),
@@ -410,8 +368,7 @@ export function createDashboardApp(
     options.authPath ?? DEFAULT_AUTH_PATH,
     DEFAULT_AUTH_PATH,
   );
-  const allowedDomains = normalizeValues(options.allowedGoogleDomains);
-  const allowedEmails = normalizeValues(options.allowedEmails);
+  const allowedDomains = normalizeValues(options.allowedDomains);
   const agentName = options.agentName?.trim() || "Junior";
 
   const authRequired = options.authRequired !== false;
@@ -421,27 +378,15 @@ export function createDashboardApp(
     canonicalBaseURL = resolveDashboardBaseURL({ baseURL: configuredBaseURL });
   }
 
-  if (
-    authRequired &&
-    allowedDomains.length === 0 &&
-    allowedEmails.length === 0
-  ) {
-    throw new Error(
-      "Junior dashboard auth requires allowedGoogleDomains or allowedEmails",
-    );
+  if (authRequired && allowedDomains.length === 0) {
+    throw new Error("Junior dashboard auth requires allowedDomains");
   }
 
-  const auth = authRequired
-    ? (options.auth ??
-      createDashboardAuth({
-        agentName,
-        authPath,
-        baseURL: options.baseURL,
-        trustedOrigins: options.trustedOrigins ?? [],
-        googleHostedDomain: resolveGoogleHostedDomainHint(allowedDomains),
-        sessionMaxAgeSeconds: options.sessionMaxAgeSeconds,
-      }))
-    : undefined;
+  // Core owns the Google sign-in session.
+  const auth = options.auth;
+  if (authRequired && !auth) {
+    throw new Error("Junior dashboard auth requires the core sign-in session");
+  }
   const app = new Hono<{ Variables: Variables }>();
   const authenticatedRoutes = options.authenticatedRoutes ?? [];
   app.use("*", async (c, next) => {
@@ -456,14 +401,11 @@ export function createDashboardApp(
       authenticatedRoutes,
       componentGallery: options.componentGallery,
     });
-    if (!auth) {
+    if (!authRequired || !auth) {
       return Response.redirect(returnUrl, 302);
     }
     const session = await auth.getSession(c.req.raw);
-    if (
-      session &&
-      dashboardSessionIsAuthorized(session, allowedDomains, allowedEmails)
-    ) {
+    if (session && dashboardSessionIsAuthorized(session, allowedDomains)) {
       return Response.redirect(returnUrl, 302);
     }
     return auth.signInWithGoogle(c.req.raw, returnUrl);
@@ -552,7 +494,7 @@ export function createDashboardApp(
         componentGallery: options.componentGallery,
       });
     }
-    if (!dashboardSessionIsAuthorized(session, allowedDomains, allowedEmails)) {
+    if (!dashboardSessionIsAuthorized(session, allowedDomains)) {
       return forbidden(c.req.raw, agentName);
     }
     const sanitizedSession = sanitizeDashboardSession(session);
@@ -575,6 +517,7 @@ export function createDashboardApp(
       c.set("viewer", viewer);
     }
     await next();
+    return undefined;
   };
 
   app.use("*", requireAuth);
@@ -633,8 +576,7 @@ export function createDashboardApp(
   );
   app.get("/api/config", () => {
     return jsonResponse(dashboardConfigSchema, {
-      allowedEmailCount: allowedEmails.length,
-      allowedGoogleDomainCount: allowedDomains.length,
+      allowedDomainCount: allowedDomains.length,
       authRequired,
       authPath,
       basePath,

package/src/auth.ts

@@ -1,25 +1,10 @@
-import { betterAuth } from "better-auth/minimal";
 import { dashboardSessionSchema } from "./api/schema";
 import type { DashboardSession } from "./api/schema";
-import { resolveDashboardBaseURL } from "./url";
-
-const DEFAULT_SESSION_MAX_AGE_SECONDS = 60 * 60 * 8;
 
 export type DashboardUser = DashboardSession["user"];
 export type { DashboardSession };
 
-export interface DashboardAuthConfig {
-  agentName?: string;
-  baseURL?: string;
-  authPath: string;
-  trustedOrigins: string[];
-  secret?: string;
-  googleClientId?: string;
-  googleClientSecret?: string;
-  googleHostedDomain?: string;
-  sessionMaxAgeSeconds?: number;
-}
-
+/** Google sign-in session that core owns. */
 export interface DashboardAuth {
   handler(request: Request): Promise<Response>;
   getSession(request: Request): Promise<DashboardSession | null>;
@@ -40,19 +25,22 @@ export function dashboardBearerSession(email: string): DashboardSession {
   return { user: { email, emailVerified: true } };
 }
 
-/** Check the dashboard allowlist against one verified session. */
+/**
+ * Check the allowed domains against one verified session. Core accepts a
+ * Google sign-in only for a Workspace account on an allowed domain. This
+ * check also applies a changed list to existing sessions and personal tokens.
+ */
 export function dashboardSessionIsAuthorized(
   session: DashboardSession,
   allowedDomains: string[],
-  allowedEmails: string[],
 ): boolean {
   const email = session.user.email.toLowerCase();
   const separator = email.lastIndexOf("@");
   const domain = separator > 0 ? email.slice(separator + 1) : undefined;
   return Boolean(
     session.user.emailVerified &&
-    (allowedEmails.includes(email) ||
-      (domain !== undefined && allowedDomains.includes(domain))),
+    domain !== undefined &&
+    allowedDomains.includes(domain),
   );
 }
 
@@ -78,114 +66,3 @@ export function sanitizeDashboardSession(
     },
   });
 }
-
-function required(value: string | undefined, name: string): string {
-  if (!value?.trim()) {
-    throw new Error(`${name} is required for Junior dashboard auth`);
-  }
-  return value.trim();
-}
-
-function firstHostedDomain(domains: string[]): string | undefined {
-  return domains.length === 1 ? domains[0] : undefined;
-}
-
-/** Create the Better Auth bridge used by dashboard browser routes. */
-export function createDashboardAuth(
-  config: DashboardAuthConfig,
-): DashboardAuth {
-  const secret = required(
-    config.secret ??
-      process.env.BETTER_AUTH_SECRET ??
-      process.env.JUNIOR_SECRET,
-    "JUNIOR_SECRET or BETTER_AUTH_SECRET",
-  );
-  const baseURL = resolveDashboardBaseURL({ baseURL: config.baseURL });
-  const googleClientId = required(
-    config.googleClientId ?? process.env.GOOGLE_CLIENT_ID,
-    "GOOGLE_CLIENT_ID",
-  );
-  const googleClientSecret = required(
-    config.googleClientSecret ?? process.env.GOOGLE_CLIENT_SECRET,
-    "GOOGLE_CLIENT_SECRET",
-  );
-
-  const auth = betterAuth({
-    appName: `${config.agentName?.trim() || "Junior"} Dashboard`,
-    baseURL,
-    basePath: config.authPath,
-    secret,
-    trustedOrigins: config.trustedOrigins,
-    socialProviders: {
-      google: {
-        clientId: googleClientId,
-        clientSecret: googleClientSecret,
-        hd: config.googleHostedDomain,
-        prompt: "select_account",
-        mapProfileToUser(profile) {
-          return {
-            email: profile.email,
-            emailVerified: profile.email_verified,
-            image: profile.picture,
-            name: profile.name,
-          };
-        },
-      },
-    },
-    account: {
-      storeStateStrategy: "cookie",
-      storeAccountCookie: false,
-      updateAccountOnSignIn: false,
-    },
-    session: {
-      expiresIn: config.sessionMaxAgeSeconds ?? DEFAULT_SESSION_MAX_AGE_SECONDS,
-      disableSessionRefresh: true,
-      cookieCache: {
-        enabled: true,
-        strategy: "jwe",
-        maxAge: config.sessionMaxAgeSeconds ?? DEFAULT_SESSION_MAX_AGE_SECONDS,
-        refreshCache: false,
-      },
-    },
-  });
-
-  return {
-    handler(request) {
-      return auth.handler(request);
-    },
-    async getSession(request) {
-      const session = await auth.api.getSession({ headers: request.headers });
-      if (!session) {
-        return null;
-      }
-      return sanitizeDashboardSession(session as DashboardSession);
-    },
-    async signInWithGoogle(request, callbackURL) {
-      const result = await auth.api.signInSocial({
-        body: {
-          provider: "google",
-          callbackURL,
-        },
-        headers: request.headers,
-        returnHeaders: true,
-      });
-
-      if (!("url" in result.response) || !result.response.url) {
-        throw new Error("Google sign-in did not return a redirect URL");
-      }
-
-      result.headers.set("location", result.response.url);
-      return new Response(null, {
-        status: 302,
-        headers: result.headers,
-      });
-    },
-  };
-}
-
-/** Resolve a Google hosted-domain login hint when it is unambiguous. */
-export function resolveGoogleHostedDomainHint(
-  domains: string[],
-): string | undefined {
-  return firstHostedDomain(domains.map((domain) => domain.toLowerCase()));
-}

package/src/authenticated-routes.ts

@@ -19,8 +19,7 @@ export function isAuthPath(
   const requestSegments = segments(pathname);
   return routes.some((route) => {
     const routeSegments = segments(route.path);
-    for (let index = 0; index < routeSegments.length; index += 1) {
-      const pattern = routeSegments[index];
+    for (const [index, pattern] of routeSegments.entries()) {
       if (pattern === "*") return true;
       const value = requestSegments[index];
       if (!value || (pattern !== value && !pattern.startsWith(":"))) {

package/src/client/components/SearchInput.tsx

@@ -1,5 +1,5 @@
 import type { Ref } from "react";
-import { Search } from "lucide-react";
+import { Search, X } from "lucide-react";
 
 import { cn } from "../styles";
 
@@ -30,7 +30,7 @@ export function SearchInput(props: {
       <input
         aria-label={props.label}
         className={cn(
-          "w-full rounded-md border border-dashboard-border font-sans text-sm text-dashboard-text outline-none transition-colors placeholder:text-dashboard-text-muted/70 hover:border-dashboard-border-emphasis focus:border-dashboard-focus",
+          "w-full rounded-md border border-dashboard-border font-sans text-sm text-dashboard-text outline-none transition-colors placeholder:text-dashboard-text-muted/70 hover:border-dashboard-border-emphasis focus:border-dashboard-focus [&::-webkit-search-cancel-button]:appearance-none",
           searchInputClass[size],
         )}
         onChange={(event) => props.onChange(event.currentTarget.value)}
@@ -39,6 +39,23 @@ export function SearchInput(props: {
         type="search"
         value={props.value}
       />
+      {props.value ? (
+        <button
+          aria-label="Clear search"
+          className={cn(
+            "absolute top-1/2 grid size-6 -translate-y-1/2 cursor-pointer place-items-center rounded-md text-dashboard-text-muted transition-colors hover:bg-dashboard-fill-strong hover:text-dashboard-text focus-visible:outline-2 focus-visible:outline-offset-1 focus-visible:outline-dashboard-focus",
+            clearButtonClass[size],
+          )}
+          onClick={(event) => {
+            props.onChange("");
+            // The button unmounts once the value is empty, so keep focus in the search box.
+            event.currentTarget.parentElement?.querySelector("input")?.focus();
+          }}
+          type="button"
+        >
+          <X aria-hidden="true" size={14} strokeWidth={2.5} />
+        </button>
+      ) : null}
     </div>
   );
 }
@@ -48,9 +65,14 @@ const searchIconClass: Record<SearchInputSize, string> = {
   default: "left-3",
 };
 
+const clearButtonClass: Record<SearchInputSize, string> = {
+  compact: "right-1.5",
+  default: "right-2",
+};
+
 const searchInputClass: Record<SearchInputSize, string> = {
   compact:
-    "h-9 bg-dashboard-overlay-soft pr-3 pl-8 focus:ring-1 focus:ring-dashboard-focus/25",
+    "h-9 bg-dashboard-overlay-soft pr-8 pl-8 focus:ring-1 focus:ring-dashboard-focus/25",
   default:
-    "h-10 bg-dashboard-overlay-soft pr-3 pl-9 focus:ring-1 focus:ring-dashboard-focus/25",
+    "h-10 bg-dashboard-overlay-soft pr-9 pl-9 focus:ring-1 focus:ring-dashboard-focus/25",
 };

package/src/client/conversations/ConversationTranscript.tsx

@@ -43,6 +43,7 @@ import { transcriptEmptyClass } from "./transcriptStyles";
 import { entryMatchesSearch, useTranscriptSearch } from "./transcriptSearch";
 import { TranscriptRow, TranscriptRows } from "./TranscriptRows";
 import { TranscriptTimestampProvider } from "./TranscriptTimestamp";
+import { TranscriptMentionPeopleProvider } from "./transcriptMentions";
 
 type TranscriptEntry = ReturnType<typeof groupTranscriptMessages>[number];
 type TranscriptContextEntry = Extract<TranscriptEntry, { kind: "context" }>;
@@ -85,14 +86,16 @@ export const ConversationTranscriptView = memo(
 
     return (
       <TranscriptTimestampProvider>
-        <section className="min-w-0 pt-1">
-          <SegmentEvents
-            onOpenSubagentTranscript={props.onOpenSubagentTranscript}
-            conversation={props.conversation}
-            messages={messages}
-            responding={props.responding}
-          />
-        </section>
+        <TranscriptMentionPeopleProvider messages={messages}>
+          <section className="min-w-0 pt-1">
+            <SegmentEvents
+              onOpenSubagentTranscript={props.onOpenSubagentTranscript}
+              conversation={props.conversation}
+              messages={messages}
+              responding={props.responding}
+            />
+          </section>
+        </TranscriptMentionPeopleProvider>
       </TranscriptTimestampProvider>
     );
   },

package/src/client/conversations/TranscriptActivityGroup.tsx

@@ -101,9 +101,10 @@ export function activityGroupSummary(
     (entry) => entry.kind === "attachments_delivered",
   ).length;
   const eventCount = entries.filter((entry) => entry.kind === "message").length;
+  const [onlyHandoff] = handoffs;
   const handoffSummary =
-    handoffs.length === 1
-      ? `model handoff to ${handoffs[0].modelId} (${handoffs[0].modelProfile})`
+    handoffs.length === 1 && onlyHandoff
+      ? `model handoff to ${onlyHandoff.modelId} (${onlyHandoff.modelProfile})`
       : handoffs.length > 1
         ? countLabel(handoffs.length, "model handoff", "model handoffs")
         : undefined;

package/src/client/conversations/TranscriptEventView.tsx

@@ -1,5 +1,6 @@
 import { ChevronRight } from "lucide-react";
 
+import { renderMentionText } from "./transcriptMentions";
 import { messageRawText } from "./transcriptRenderModel";
 import { HighlightText } from "./transcriptSearch";
 import { RedactedMarker } from "./TranscriptRedacted";
@@ -16,7 +17,7 @@ export function TranscriptEventView(props: { message: TranscriptViewMessage }) {
   const heading = (
     <span className="flex min-h-6 min-w-0 flex-wrap items-center gap-x-2 gap-y-1">
       <span className="min-w-0 break-words font-display text-sm font-semibold leading-6 text-dashboard-text">
-        <HighlightText text={summary} />
+        {renderMentionText(summary, "event-summary")}
       </span>
       {props.message.eventType ? (
         <span className="break-all rounded-md border border-dashboard-border px-1.5 py-0.5 font-mono text-2xs leading-none text-dashboard-text-muted">

package/src/client/conversations/TranscriptMarkdown.tsx

@@ -5,13 +5,14 @@ import {
   findTranscriptMarkdownLinks,
   TRANSCRIPT_ANCHOR_CLASS,
 } from "./transcriptMarkdownLinks";
+import { renderMentionText } from "./transcriptMentions";
 import { HighlightText, useTranscriptSearch } from "./transcriptSearch";
 
 type TableAlignment = "left" | "center" | "right" | null;
 
 type MarkdownBlock =
   | { type: "heading"; level: 1 | 2 | 3 | 4 | 5 | 6; text: string }
-  | { type: "list"; ordered: boolean; items: string[] }
+  | { type: "list"; ordered: boolean; items: string[]; start?: number }
   | {
       type: "table";
       alignments: TableAlignment[];
@@ -33,11 +34,11 @@ export function TranscriptMarkdown(props: {
       className={cn(
         "min-w-0 break-words text-dashboard-text [overflow-wrap:anywhere]",
         props.compact
-          ? "font-sans text-base leading-7"
+          ? "font-sans text-base leading-relaxed"
           : "font-sans text-sm leading-6 md:leading-7",
       )}
     >
-      <div className="grid min-w-0 gap-2">
+      <div className={cn("grid min-w-0", props.compact ? "gap-3" : "gap-2")}>
         {blocks.map((block, index) => (
           <MarkdownBlockView block={block} key={index} />
         ))}
@@ -50,7 +51,7 @@ function MarkdownBlockView(props: { block: MarkdownBlock }) {
   switch (props.block.type) {
     case "heading": {
       const className = cn(
-        "m-0 min-w-0 font-semibold tracking-[-0.01em] text-dashboard-text",
+        "m-0 min-w-0 font-semibold tracking-[-0.01em] text-dashboard-text [&:not(:first-child)]:mt-1 [&+*]:-mt-1",
         props.block.level <= 2 ? "text-[1.05em]" : "text-[1em]",
       );
       const content = renderInlineMarkdown(props.block.text);
@@ -74,9 +75,10 @@ function MarkdownBlockView(props: { block: MarkdownBlock }) {
       return (
         <ListTag
           className={cn(
-            "m-0 grid min-w-0 list-outside gap-1 pl-5 text-dashboard-text",
+            "m-0 grid min-w-0 list-outside gap-1.5 pl-6 text-dashboard-text marker:text-dashboard-text-muted",
             props.block.ordered ? "list-decimal" : "list-disc",
           )}
+          start={props.block.start}
         >
           {props.block.items.map((item, index) => (
             <li className="min-w-0 pl-1" key={index}>
@@ -122,6 +124,7 @@ function parseMarkdownProseBlocks(text: string): MarkdownBlock[] {
       const ordered = isOrderedListItem(line);
       const unordered = isUnorderedListItem(line);
       if (ordered || unordered) {
+        const start = ordered ? Number(/\d+/.exec(line)?.[0]) : undefined;
         const items: string[] = [];
         while (
           index < lines.length &&
@@ -131,13 +134,18 @@ function parseMarkdownProseBlocks(text: string): MarkdownBlock[] {
         ) {
           items.push(
             (lines[index] ?? "").replace(
-              ordered ? /^\s*\d+\.\s+/ : /^\s*[-*+]\s+/,
+              ordered ? ORDERED_LIST_MARKER : UNORDERED_LIST_MARKER,
               "",
             ),
           );
           index += 1;
         }
-        blocks.push({ items, ordered, type: "list" });
+        blocks.push({
+          items,
+          ordered,
+          start: start === 1 ? undefined : start,
+          type: "list",
+        });
         continue;
       }
 
@@ -323,6 +331,11 @@ function splitTableRow(line: string): string[] {
 }
 
 function matchHeading(line: string): MarkdownBlock | undefined {
+  // Agents often write a bold-only line as a section label. Give it heading
+  // spacing so the section reads as a group.
+  if (/^\s*(?:\*\*[^*]+\*\*|__[^_]+__):?\s*$/.test(line)) {
+    return { level: 3, text: line.trim(), type: "heading" };
+  }
   const match = /^(#{1,6})\s+(.+)$/.exec(line);
   if (!match) return undefined;
   return {
@@ -332,12 +345,16 @@ function matchHeading(line: string): MarkdownBlock | undefined {
   };
 }
 
+// Slack-style replies use "•" bullets and "1)" numbers; render them as lists.
+const UNORDERED_LIST_MARKER = /^\s*[-*+•◦]\s+(?=\S)/;
+const ORDERED_LIST_MARKER = /^\s*\d+[.)]\s+(?=\S)/;
+
 function isUnorderedListItem(line: string): boolean {
-  return /^\s*[-*+]\s+\S/.test(line);
+  return UNORDERED_LIST_MARKER.test(line);
 }
 
 function isOrderedListItem(line: string): boolean {
-  return /^\s*\d+\.\s+\S/.test(line);
+  return ORDERED_LIST_MARKER.test(line);
 }
 
 function renderInlineMarkdown(text: string): ReactNode[] {
@@ -435,10 +452,10 @@ function renderLinkText(text: string, keyBase: string): ReactNode[] {
   for (const link of links) {
     if (link.start > cursor) {
       nodes.push(
-        <HighlightText
-          key={`${keyBase}-s-${part++}`}
-          text={text.slice(cursor, link.start)}
-        />,
+        ...renderMentionText(
+          text.slice(cursor, link.start),
+          `${keyBase}-s-${part++}`,
+        ),
       );
     }
     nodes.push(
@@ -451,7 +468,7 @@ function renderLinkText(text: string, keyBase: string): ReactNode[] {
 
   if (cursor < text.length) {
     nodes.push(
-      <HighlightText key={`${keyBase}-s-${part}`} text={text.slice(cursor)} />,
+      ...renderMentionText(text.slice(cursor), `${keyBase}-s-${part}`),
     );
   }
   return nodes;

package/src/client/conversations/eventTranscript.ts

@@ -213,6 +213,7 @@ export function transcriptMessagesFromEvents(
         ...(data.actorIdentity
           ? { actorIdentity: data.actorIdentity }
           : undefined),
+        ...(data.mentions ? { mentions: data.mentions } : undefined),
         ...(data.eventType ? { eventType: data.eventType } : undefined),
         eventObjectType: data.eventObjectType,
         ...(data.trustedSummary

package/src/client/conversations/transcriptFailure.ts

@@ -55,8 +55,6 @@ export function transcriptFailureTitle(
     case "agent_run_failed":
       return "Internal error";
   }
-
-  return "Internal error";
 }
 
 /** Short description for one failed turn in the transcript. */
@@ -111,8 +109,6 @@ export function transcriptFailureDescription(
     case "agent_run_failed":
       return `${agentName} hit an internal error during this turn.`;
   }
-
-  return `${agentName} hit an internal error during this turn.`;
 }
 
 /** Search text for one failed turn in the transcript. */

package/src/client/conversations/transcriptMarkdownLinks.ts

@@ -88,6 +88,7 @@ function findNextMarkdownLink(
       start: linkStart,
     };
   }
+  return undefined;
 }
 
 function findMarkdownLinkSyntaxRanges(
@@ -148,6 +149,7 @@ function readMarkdownDestination(
     const href = text.slice(start, index);
     return href ? { end: index + 1, href } : undefined;
   }
+  return undefined;
 }
 
 function findCommonMarkAutolinks(
@@ -199,6 +201,7 @@ function findNextBareLink(
       start: match.index,
     };
   }
+  return undefined;
 }
 
 function findBareLinks(