@sentry/ember 11.0.0-alpha.0 → 11.0.0-alpha.1

package/addon/utils/instrumentEmberGlobals.ts

@@ -15,13 +15,10 @@ type Payload = {
 };
 
 type RenderEntry = {
-  payload: Payload;
   now: number;
 };
 
-interface RenderEntries {
-  [name: string]: RenderEntry;
-}
+export type RenderEntries = WeakMap<Payload, RenderEntry>;
 
 /** This is global, so should only be run once in tests! */
 export function instrumentGlobalsForPerformance(config: {
@@ -127,26 +124,26 @@ function _instrumentEmberRunloop(config: { minimumRunloopQueueDuration?: number
   });
 }
 
-function processComponentRenderBefore(payload: Payload, beforeEntries: RenderEntries): void {
-  const info = {
-    payload,
-    now: timestampInSeconds(),
-  };
-  beforeEntries[payload.object] = info;
+export function _processComponentRenderBefore(payload: Payload, beforeEntries: RenderEntries): void {
+  beforeEntries.set(payload, { now: timestampInSeconds() });
 }
 
-function processComponentRenderAfter(
+export function _processComponentRenderAfter(
   payload: Payload,
   beforeEntries: RenderEntries,
   op: string,
   minComponentDuration: number,
 ): void {
-  const begin = beforeEntries[payload.object];
+  const begin = beforeEntries.get(payload);
 
   if (!begin) {
     return;
   }
 
+  // A WeakMap entry cannot outlive its payload, but delete promptly anyway
+  // so a long-lived payload doesn't keep the entry around between renders.
+  beforeEntries.delete(payload);
+
   const now = timestampInSeconds();
   const componentRenderDuration = now - begin.now;
 
@@ -174,27 +171,27 @@ function _instrumentComponents(config: {
 
   const minComponentDuration = minimumComponentRenderDuration ?? 2;
 
-  const beforeEntries = {} as RenderEntries;
-  const beforeComponentDefinitionEntries = {} as RenderEntries;
+  const beforeEntries: RenderEntries = new WeakMap();
+  const beforeComponentDefinitionEntries: RenderEntries = new WeakMap();
 
   function _subscribeToRenderEvents(): void {
     subscribe('render.component', {
       before(_name: string, _timestamp: number, payload: Payload) {
-        processComponentRenderBefore(payload, beforeEntries);
+        _processComponentRenderBefore(payload, beforeEntries);
       },
 
       after(_name: string, _timestamp: number, payload: Payload, _beganIndex: number) {
-        processComponentRenderAfter(payload, beforeEntries, BROWSER_UI_RENDER_SPAN_OP, minComponentDuration);
+        _processComponentRenderAfter(payload, beforeEntries, BROWSER_UI_RENDER_SPAN_OP, minComponentDuration);
       },
     });
     if (enableComponentDefinitions) {
       subscribe('render.getComponentDefinition', {
         before(_name: string, _timestamp: number, payload: Payload) {
-          processComponentRenderBefore(payload, beforeComponentDefinitionEntries);
+          _processComponentRenderBefore(payload, beforeComponentDefinitionEntries);
         },
 
         after(_name: string, _timestamp: number, payload: Payload, _beganIndex: number) {
-          processComponentRenderAfter(payload, beforeComponentDefinitionEntries, GENERAL_FUNCTION_SPAN_OP, 0);
+          _processComponentRenderAfter(payload, beforeComponentDefinitionEntries, GENERAL_FUNCTION_SPAN_OP, 0);
         },
       });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/ember",
-  "version": "11.0.0-alpha.0",
+  "version": "11.0.0-alpha.1",
   "description": "Official Sentry SDK for Ember.js",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/ember",
@@ -32,9 +32,9 @@
   "dependencies": {
     "@babel/core": "^7.29.6",
     "@embroider/macros": "^1.16.0",
-    "@sentry/browser": "11.0.0-alpha.0",
-    "@sentry/core": "11.0.0-alpha.0",
-    "@sentry/conventions": "^0.16.0",
+    "@sentry/browser": "11.0.0-alpha.1",
+    "@sentry/core": "11.0.0-alpha.1",
+    "@sentry/conventions": "^0.19.0",
     "ember-auto-import": "^2.7.2",
     "ember-cli-babel": "^8.2.0",
     "ember-cli-htmlbars": "^6.1.1",

package/utils/instrumentEmberGlobals.d.ts

@@ -1,3 +1,12 @@
+type Payload = {
+    containerKey: string;
+    initialRender: true;
+    object: string;
+};
+type RenderEntry = {
+    now: number;
+};
+export type RenderEntries = WeakMap<Payload, RenderEntry>;
 /** This is global, so should only be run once in tests! */
 export declare function instrumentGlobalsForPerformance(config: {
     disableRunloopPerformance?: boolean;
@@ -7,3 +16,6 @@ export declare function instrumentGlobalsForPerformance(config: {
     enableComponentDefinitions?: boolean;
     disableInitialLoadInstrumentation?: boolean;
 }): void;
+export declare function _processComponentRenderBefore(payload: Payload, beforeEntries: RenderEntries): void;
+export declare function _processComponentRenderAfter(payload: Payload, beforeEntries: RenderEntries, op: string, minComponentDuration: number): void;
+export {};