@sendinel/mcp-server 1.0.70 → 1.0.71

package/build/tools/campaigns.d.ts

@@ -4,11 +4,15 @@ import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
  * row. Includes a warning when the campaign cannot fire yet (#3855).
  */
 export declare function buildCampaignFiresOn(campaign: Record<string, unknown>): string;
+/**
+ * Diagnostic warnings indicating why a campaign's trigger configuration cannot fire (#3852).
+ */
+export declare function buildCampaignTriggerDiagnostics(campaign: Record<string, unknown>): string[];
 export declare function applyCampaignTargetingFields(updates: Record<string, unknown>, input: {
     trigger_event_name?: string | null;
     trigger_tag?: string | null;
     trigger_type?: string | null;
     trigger_config?: Record<string, unknown> | null;
     segment_id?: string | null;
-}, projectId: string): Promise<string | null>;
+}, projectId: string, existingCampaign?: Record<string, unknown> | null): Promise<string | null>;
 export declare function registerCampaignTools(server: McpServer): void;

package/build/tools/campaigns.js

@@ -93,6 +93,37 @@ export function buildCampaignFiresOn(campaign) {
         summary += ` Warning: ${warnings.join('; ')}.`;
     return summary;
 }
+/**
+ * Diagnostic warnings indicating why a campaign's trigger configuration cannot fire (#3852).
+ */
+export function buildCampaignTriggerDiagnostics(campaign) {
+    const config = (campaign.trigger_config && typeof campaign.trigger_config === 'object' ? campaign.trigger_config : {});
+    const events = normalizeTriggerList([...normalizeTriggerList(config.events), campaign.trigger_event_name]);
+    const tags = normalizeTriggerList([...normalizeTriggerList(config.tags), campaign.trigger_tag]);
+    const diagnostics = [];
+    if ((events.length || tags.length) && campaign.type !== 'triggered') {
+        diagnostics.push(`campaign type is "${String(campaign.type)}"; event and tag triggers only start campaigns of type "triggered" (it will never fire)`);
+    }
+    if (campaign.trigger_type === 'date_field') {
+        const field = typeof config.field === 'string' && config.field ? config.field : null;
+        if (!field) {
+            diagnostics.push('trigger_type is "date_field", but no date field is set (it will never fire)');
+        }
+    }
+    else if (campaign.trigger_type === 'contact_event') {
+        const eventType = typeof config.event_type === 'string' && config.event_type ? config.event_type : null;
+        if (!eventType) {
+            diagnostics.push('trigger_type is "contact_event", but no event_type is set (it will never fire)');
+        }
+    }
+    if ((campaign.trigger_type === 'date_field' || campaign.trigger_type === 'contact_event') && (events.length || tags.length) && campaign.type === 'triggered') {
+        diagnostics.push(`trigger_type is "${String(campaign.trigger_type)}" but event/tag triggers are also set; event intake will start it immediately, outside the ${String(campaign.trigger_type)} schedule`);
+    }
+    if (campaign.status !== 'active') {
+        diagnostics.push(`it is ${String(campaign.status)}, so nothing starts until it is active`);
+    }
+    return diagnostics;
+}
 function applyCampaignSendAtField(updates, sendAt, campaignType) {
     if (sendAt === undefined)
         return null;
@@ -108,19 +139,22 @@ function applyCampaignSendAtField(updates, sendAt, campaignType) {
     updates.send_at = parsed.scheduledAt;
     return null;
 }
-export async function applyCampaignTargetingFields(updates, input, projectId) {
+export async function applyCampaignTargetingFields(updates, input, projectId, existingCampaign) {
+    const hasTriggerEvent = input.trigger_event_name !== undefined && input.trigger_event_name !== null && input.trigger_event_name.trim() !== '';
     if (input.trigger_event_name !== undefined)
         updates.trigger_event_name = input.trigger_event_name?.trim() || null;
     if (input.trigger_tag !== undefined)
         updates.trigger_tag = input.trigger_tag?.trim().toLowerCase() || null;
     if (input.trigger_type === null || input.trigger_type === 'manual') {
         // campaigns.trigger_type is NOT NULL DEFAULT 'manual', so "clear" means back to 'manual'.
-        // Also drops a stale date_field config unless the caller sent a new trigger_config (#3855).
+        // Also drops a stale date_field or contact_event config unless the caller sent a new trigger_config (#3855, #3852).
         updates.trigger_type = 'manual';
         if (input.trigger_config === undefined)
             updates.trigger_config = null;
     }
     if (input.trigger_type === 'date_field') {
+        if (hasTriggerEvent)
+            return 'cannot set trigger_event_name on a date_field campaign';
         const config = input.trigger_config ?? {};
         const field = typeof config.field === 'string' ? config.field.trim() : '';
         if (!/^[A-Za-z0-9_.-]{1,80}$/.test(field))
@@ -132,6 +166,23 @@ export async function applyCampaignTargetingFields(updates, input, projectId) {
             recurring: config.recurring !== false,
         };
     }
+    else if (input.trigger_type === 'contact_event') {
+        // trigger_event_name would also make event intake enroll at once, skipping days_after.
+        if (hasTriggerEvent)
+            return 'cannot set trigger_event_name on a contact_event campaign; use trigger_config.event_type';
+        const config = input.trigger_config ?? {};
+        const eventType = typeof config.event_type === 'string' ? config.event_type.trim() : '';
+        const daysAfter = Number(config.days_after ?? 0);
+        if (!eventType)
+            return 'event_type is required';
+        if (!Number.isInteger(daysAfter))
+            return 'days_after must be an integer';
+        updates.trigger_type = 'contact_event';
+        updates.trigger_config = {
+            event_type: eventType,
+            days_after: Math.max(0, Math.min(365, daysAfter)),
+        };
+    }
     else if (input.trigger_config !== undefined) {
         if (input.trigger_config === null) {
             updates.trigger_config = null;
@@ -143,6 +194,14 @@ export async function applyCampaignTargetingFields(updates, input, projectId) {
             updates.trigger_config = config;
         }
     }
+    // If trigger_type was not specified, but caller is setting an event trigger on a campaign
+    // whose current trigger_type is date_field or contact_event, normalize trigger_type to 'manual' (#3852).
+    const setsEventTrigger = hasTriggerEvent || (updates.trigger_config && typeof updates.trigger_config === 'object' && Array.isArray(updates.trigger_config.events) && updates.trigger_config.events.length > 0);
+    if (input.trigger_type === undefined && setsEventTrigger) {
+        if (existingCampaign?.trigger_type === 'date_field' || existingCampaign?.trigger_type === 'contact_event') {
+            updates.trigger_type = 'manual';
+        }
+    }
     if (input.segment_id !== undefined) {
         if (!input.segment_id) {
             updates.segment_id = null;
@@ -3287,7 +3346,7 @@ Return ONLY valid JSON with this exact shape:
             idempotentHint: true,
             openWorldHint: false,
         },
-        description: 'Update a campaign name, site, segment, send time, topic, trigger settings, or send class (broadcast vs product). trigger_type null (or manual) clears a date_field trigger; type switches a draft between sequence and triggered. The response includes fires_on, a plain summary of what the saved campaign fires on. send_at schedules a broadcast send (type=broadcast only) and must be a future ISO 8601 instant; set null to clear a pending schedule. Only provided fields are updated.',
+        description: 'Update a campaign name, site, segment, send time, topic, trigger settings, or send class (broadcast vs product). trigger_type null (or manual) clears a date_field or contact_event trigger; type switches a draft between sequence and triggered. The response includes fires_on, a plain summary of what the saved campaign fires on, and trigger_diagnostics naming any trigger problems. send_at schedules a broadcast send (type=broadcast only) and must be a future ISO 8601 instant; set null to clear a pending schedule. Only provided fields are updated.',
         inputSchema: {
             campaign_id: z.string().uuid(),
             name: z.string().min(1).max(200).optional(),
@@ -3297,7 +3356,7 @@ Return ONLY valid JSON with this exact shape:
             topic: z.string().nullable().optional(),
             trigger_event_name: z.string().nullable().optional(),
             trigger_tag: z.string().nullable().optional(),
-            trigger_type: z.enum(['date_field', 'manual']).nullable().optional().describe("'date_field' fires relative to a contact date field (needs trigger_config.field). null or 'manual' clears a date_field trigger."),
+            trigger_type: z.enum(['date_field', 'manual', 'contact_event']).nullable().optional().describe("'date_field' fires relative to a contact date field (needs trigger_config.field). 'contact_event' fires relative to a contact event (needs trigger_config.event_type and days_after). null or 'manual' clears a date_field or contact_event trigger."),
             trigger_config: z.record(z.string(), z.unknown()).nullable().optional(),
             type: z.enum(['sequence', 'triggered']).optional().describe("Switch a DRAFT campaign between 'sequence' and 'triggered'. Event and tag triggers only start campaigns of type 'triggered'."),
             sends_per_hour: z.number().int().min(1).nullable().optional().describe('Optional hourly send cap for wave sending. Set null to clear.'),
@@ -3309,12 +3368,21 @@ Return ONLY valid JSON with this exact shape:
         let campaignType;
         const loadExisting = () => db()
             .from('campaigns')
-            .select('id, type, status')
+            .select('id, type, status, trigger_type, trigger_config, trigger_event_name, trigger_tag')
             .eq('id', campaign_id)
             .eq('project_id', projectId)
             .maybeSingle();
+        let cachedExisting = null;
+        const getExisting = async () => {
+            if (cachedExisting)
+                return { data: cachedExisting, error: null };
+            const { data, error } = await loadExisting();
+            if (!error && data)
+                cachedExisting = data;
+            return { data, error };
+        };
         if (send_at !== undefined && send_at !== null) {
-            const { data: existing, error: fetchError } = await loadExisting();
+            const { data: existing, error: fetchError } = await getExisting();
             if (fetchError)
                 return j({ error: fetchError.message });
             if (!existing)
@@ -3322,7 +3390,7 @@ Return ONLY valid JSON with this exact shape:
             campaignType = existing.type;
         }
         if (type !== undefined) {
-            const { data: existing, error: fetchError } = await loadExisting();
+            const { data: existing, error: fetchError } = await getExisting();
             if (fetchError)
                 return j({ error: fetchError.message });
             if (!existing)
@@ -3334,6 +3402,16 @@ Return ONLY valid JSON with this exact shape:
                     return j({ error: `a ${existing.type} campaign cannot become ${type}`, code: 'INVALID_FIELD' });
             }
         }
+        const hasTriggerUpdate = trigger_event_name !== undefined || trigger_tag !== undefined || trigger_type !== undefined || trigger_config !== undefined;
+        let existingCampaignForTargeting = null;
+        if (hasTriggerUpdate) {
+            const { data: existing, error: fetchError } = await getExisting();
+            if (fetchError)
+                return j({ error: fetchError.message });
+            if (!existing)
+                return j({ error: 'Campaign not found', code: 'NOT_FOUND' });
+            existingCampaignForTargeting = existing;
+        }
         const updates = { updated_at: new Date().toISOString() };
         if (name !== undefined)
             updates.name = name;
@@ -3352,9 +3430,19 @@ Return ONLY valid JSON with this exact shape:
             updates.send_in_contact_timezone = send_in_contact_timezone;
         if (send_class !== undefined)
             updates.send_class = send_class;
-        const targetingError = await applyCampaignTargetingFields(updates, { trigger_event_name, trigger_tag, trigger_type, trigger_config, segment_id }, projectId);
+        const targetingError = await applyCampaignTargetingFields(updates, { trigger_event_name, trigger_tag, trigger_type, trigger_config, segment_id }, projectId, existingCampaignForTargeting);
         if (targetingError)
             return j({ error: targetingError, code: targetingError === 'Segment not found' ? 'NOT_FOUND' : 'INVALID_FIELD' });
+        // If type was not explicitly changed, but this update sets an event trigger on a draft sequence,
+        // normalize type to 'triggered' so that event intake matches and enrolls it (#3852).
+        if (type === undefined && existingCampaignForTargeting?.type === 'sequence' && existingCampaignForTargeting?.status === 'draft') {
+            const isSettingEvent = (updates.trigger_event_name !== undefined && updates.trigger_event_name !== null)
+                || (updates.trigger_tag !== undefined && updates.trigger_tag !== null)
+                || (updates.trigger_config && typeof updates.trigger_config === 'object' && Array.isArray(updates.trigger_config.events) && updates.trigger_config.events.length > 0);
+            if (isSettingEvent) {
+                updates.type = 'triggered';
+            }
+        }
         const { data, error } = await db()
             .from('campaigns')
             .update(updates)
@@ -3364,7 +3452,15 @@ Return ONLY valid JSON with this exact shape:
             .single();
         if (error)
             return j({ error: error.message });
-        return j({ ...data, fires_on: buildCampaignFiresOn(data) });
+        const diagnostics = buildCampaignTriggerDiagnostics(data);
+        const warning = diagnostics.find((d) => d.includes('never fire')) || (diagnostics.length ? diagnostics[0] : null);
+        return j({
+            ...data,
+            fires_on: buildCampaignFiresOn(data),
+            trigger_diagnostics: diagnostics,
+            warnings: diagnostics,
+            ...(warning ? { warning } : {}),
+        });
     });
     server.registerTool('get_campaign', {
         title: 'Get Campaign',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sendinel/mcp-server",
-  "version": "1.0.70",
+  "version": "1.0.71",
   "description": "AI-controlled email operations control plane for campaigns, contacts, segments, analytics, and multi-provider sending via MCP.",
   "mcpName": "ai.sendinel/mcp-server",
   "type": "module",