@sendinel/mcp-server 1.0.58 → 1.0.60

package/build/tools/advisor.js

@@ -649,9 +649,12 @@ Return ONLY valid JSON (no markdown fences): { "topics": [{ "title": "...", "rat
             .order('check_date', { ascending: false })
             .limit(1);
         const health = (healthRows ?? [])[0];
-        const spfValid = health?.spf_valid ?? false;
-        const dkimValid = health?.dkim_valid ?? false;
-        const dmarcValid = health?.dmarc_valid ?? false;
+        const spfValid = health?.spf_valid ?? null; // null = not checked yet (#3904)
+        const spfFailed = spfValid === false;
+        const dkimValid = health?.dkim_valid ?? null; // null = not checked yet (#3904)
+        const dkimFailed = dkimValid === false;
+        const dmarcValid = health?.dmarc_valid ?? null; // null = not checked yet (#3904)
+        const dmarcFailed = dmarcValid === false;
         const warmupDay = health?.warmup_day ?? null;
         const warmupDailyLimit = health?.warmup_daily_limit ?? null;
         // 3. Fetch recent 7-day email_log stats
@@ -686,9 +689,9 @@ Return ONLY valid JSON (no markdown fences): { "topics": [{ "title": "...", "rat
             issues.push({ type: 'high_complaint', severity: 'critical', detail: `Complaint rate ${complaintRate}% exceeds 0.3% threshold` });
         else if (complaintRate > 0.1)
             issues.push({ type: 'elevated_complaint', severity: 'high', detail: `Complaint rate ${complaintRate}% approaching danger zone` });
-        if (!spfValid || !dkimValid)
-            issues.push({ type: 'dns_invalid', severity: 'high', detail: `Missing DNS: ${!spfValid ? 'SPF' : ''}${!spfValid && !dkimValid ? ' + ' : ''}${!dkimValid ? 'DKIM' : ''}` });
-        if (!dmarcValid)
+        if (spfFailed || dkimFailed)
+            issues.push({ type: 'dns_invalid', severity: 'high', detail: `Missing DNS: ${spfFailed ? 'SPF' : ''}${spfFailed && dkimFailed ? ' + ' : ''}${dkimFailed ? 'DKIM' : ''}` });
+        if (dmarcFailed)
             issues.push({ type: 'no_dmarc', severity: 'medium', detail: 'DMARC record missing or invalid' });
         if (warmupDay != null && warmupDay < 42 && bounceRate > 3) {
             issues.push({ type: 'warmup_risk', severity: 'high', detail: `Domain on warmup day ${warmupDay} with ${bounceRate}% bounce rate — warmup at risk` });
@@ -711,9 +714,9 @@ Return ONLY valid JSON (no markdown fences): { "topics": [{ "title": "...", "rat
             immediate.push('Review recent bounce reasons in suppression log');
         }
         // DNS fixes
-        if (!spfValid)
+        if (spfFailed)
             immediate.push('Add SPF record for sending domain');
-        if (!dkimValid) {
+        if (dkimFailed) {
             const { data: dkimSite } = await db()
                 .from('sites')
                 .select('provider')
@@ -722,7 +725,7 @@ Return ONLY valid JSON (no markdown fences): { "topics": [{ "title": "...", "rat
                 .maybeSingle();
             immediate.push(dkimRemediationText(dkimSite?.provider));
         }
-        if (!dmarcValid)
+        if (dmarcFailed)
             shortTerm.push('Add DMARC record (start with p=none for monitoring)');
         // List hygiene
         if (bounceRate > 2 || complained > 0) {
@@ -738,7 +741,7 @@ Return ONLY valid JSON (no markdown fences): { "topics": [{ "title": "...", "rat
             shortTerm.push('Reduce daily send volume by 50% for at least 48 hours');
         }
         // Re-verification
-        if (!spfValid || !dkimValid) {
+        if (spfFailed || dkimFailed) {
             shortTerm.push('Re-verify domain after DNS changes (use dns-verify API)');
         }
         // Monitoring steps
@@ -753,11 +756,11 @@ Return ONLY valid JSON (no markdown fences): { "topics": [{ "title": "...", "rat
         }
         // 7. Compute health score (0-100)
         let healthScore = 100;
-        if (!spfValid)
+        if (spfFailed)
             healthScore -= 15;
-        if (!dkimValid)
+        if (dkimFailed)
             healthScore -= 15;
-        if (!dmarcValid)
+        if (dmarcFailed)
             healthScore -= 5;
         if (bounceRate > 8)
             healthScore -= 30;
@@ -780,7 +783,7 @@ Return ONLY valid JSON (no markdown fences): { "topics": [{ "title": "...", "rat
             estimatedRecovery = '7-14 days';
         else if (bounceRate > 5 || complaintRate > 0.3)
             estimatedRecovery = '5-7 days';
-        else if (!spfValid || !dkimValid)
+        else if (spfFailed || dkimFailed)
             estimatedRecovery = '2-3 days';
         else if (bounceRate > 2)
             estimatedRecovery = '3-5 days';

package/build/tools/gateway.d.ts

@@ -14,4 +14,9 @@ export declare function matchesToolQuery(entry: {
     group: string;
     description: string;
 }, query: string): boolean;
+/**
+ * Keys in args that the target tool's JSON Schema does not declare. Returns [] when the schema
+ * has no `properties` or allows additional properties, so free-form tools keep working.
+ */
+export declare function findUnknownArgKeys(inputSchema: unknown, args: Record<string, unknown>): string[];
 export declare function registerGatewayTools(server: McpServer, options: GatewayOptions): void;

package/build/tools/gateway.js

@@ -54,6 +54,38 @@ async function buildCatalog(options) {
     });
     return { client, entries, byName: new Map(entries.map((entry) => [entry.name, entry])) };
 }
+/** Top-level keys invoke_tool accepts; anything else is rejected by name. */
+function unknownKeyMessage(keys) {
+    const list = keys.map((k) => `'${k}'`).join(', ');
+    const hinted = keys.some((k) => ARGS_LOOKALIKES.has(k.toLowerCase()));
+    return `Unknown key(s) on invoke_tool: ${list}${hinted ? "; did you mean 'args'?" : ''} Valid keys: name, args (alias: arguments).`;
+}
+const ARGS_LOOKALIKES = new Set(['args', 'argument', 'params', 'input', 'parameters']);
+function declaredProperties(inputSchema) {
+    if (!inputSchema || typeof inputSchema !== 'object')
+        return null;
+    const schema = inputSchema;
+    if (schema.additionalProperties)
+        return null;
+    const props = schema.properties;
+    if (!props || typeof props !== 'object' || Array.isArray(props))
+        return null;
+    return Object.keys(props);
+}
+/**
+ * Keys in args that the target tool's JSON Schema does not declare. Returns [] when the schema
+ * has no `properties` or allows additional properties, so free-form tools keep working.
+ */
+export function findUnknownArgKeys(inputSchema, args) {
+    const declared = declaredProperties(inputSchema);
+    if (!declared)
+        return [];
+    return Object.keys(args).filter((k) => !declared.includes(k));
+}
+function unknownArgsMessage(name, inputSchema, unknown) {
+    const valid = (declaredProperties(inputSchema) ?? []).sort();
+    return `Unknown argument(s) for ${name}: ${unknown.map((k) => `'${k}'`).join(', ')}. Valid arguments: ${valid.length ? valid.join(', ') : '(none)'}. Call describe_tool for the full schema.`;
+}
 export function registerGatewayTools(server, options) {
     let catalogPromise = null;
     const getCatalog = () => (catalogPromise ??= buildCatalog(options));
@@ -95,17 +127,33 @@ export function registerGatewayTools(server, options) {
     });
     server.registerTool('invoke_tool', {
         title: 'Invoke Tool',
-        description: 'Execute one permitted Sendinel MCP tool by name with the same scope and approval enforcement as calling it directly. Use search_tools and describe_tool first.',
+        description: 'Execute one permitted Sendinel MCP tool by name with the same scope and approval enforcement as calling it directly. Pass the target tool arguments under args (alias: arguments). Unknown top-level keys and arguments the target tool does not declare are rejected. Use search_tools and describe_tool first.',
         annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: false, openWorldHint: false },
-        inputSchema: {
+        // Loose object so unknown top-level keys reach the handler (a raw shape would silently strip them).
+        inputSchema: z.looseObject({
             name: z.string().min(1).describe('Tool name to invoke'),
-            args: z.record(z.string(), z.unknown()).optional().default({}).describe('Arguments for the target tool'),
-        },
-    }, async ({ name, args }) => {
+            args: z.record(z.string(), z.unknown()).optional().describe('Arguments for the target tool'),
+            arguments: z.record(z.string(), z.unknown()).optional().describe('Alias for args (the MCP-standard field name). Provide args or arguments, not both.'),
+        }),
+    }, async (input) => {
+        const { name, args, arguments: argumentsAlias, ...rest } = input;
+        const unknownKeys = Object.keys(rest);
+        if (unknownKeys.length > 0) {
+            return notFound(unknownKeyMessage(unknownKeys));
+        }
+        if (args !== undefined && argumentsAlias !== undefined && JSON.stringify(args) !== JSON.stringify(argumentsAlias)) {
+            return notFound("Both 'args' and 'arguments' were provided with different values. Provide either 'args' or 'arguments', not both.");
+        }
+        const effective = args ?? argumentsAlias ?? {};
         const catalog = await getCatalog();
-        if (!catalog.byName.has(name)) {
+        const entry = catalog.byName.get(name);
+        if (!entry) {
             return notFound(`Tool not found or not permitted: ${name}`);
         }
-        return await catalog.client.callTool({ name, arguments: args ?? {} });
+        const unknownArgs = findUnknownArgKeys(entry.inputSchema, effective);
+        if (unknownArgs.length > 0) {
+            return notFound(unknownArgsMessage(name, entry.inputSchema, unknownArgs));
+        }
+        return await catalog.client.callTool({ name, arguments: effective });
     });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sendinel/mcp-server",
-  "version": "1.0.58",
+  "version": "1.0.60",
   "description": "AI-controlled email operations control plane for campaigns, contacts, segments, analytics, and multi-provider sending via MCP.",
   "mcpName": "ai.sendinel/mcp-server",
   "type": "module",