@sendinel/mcp-server 1.0.179 → 1.0.181

package/build/tools/ab-testing.js

@@ -1,8 +1,8 @@
-import { withApproval } from '../lib/action-approvals.js';
+import { markNotExecuted, withApproval } from '../lib/action-approvals.js';
 import { z } from 'zod';
 import { db } from '../db.js';
 import { getProjectId } from '../project.js';
-import { dbToolError } from '../lib/db-error.js';
+import { dbToolError, toolError } from '../lib/db-error.js';
 const txt = (text) => ({ content: [{ type: 'text', text }] });
 const j = (data) => txt(JSON.stringify(data, null, 2));
 export function registerAbTestingTools(server) {
@@ -35,7 +35,7 @@ export function registerAbTestingTools(server) {
             .eq('project_id', projectId)
             .maybeSingle();
         if (campErr || !campaign)
-            return txt('Error: Campaign not found');
+            return toolError({ code: 'not_found', error: 'Error: Campaign not found' });
         // Check variant steps exist
         const { data: steps } = await db()
             .from('campaign_steps')
@@ -44,11 +44,11 @@ export function registerAbTestingTools(server) {
             .eq('step_order', step_order ?? 0);
         const variantLabels = (steps ?? []).map((s) => s.variant_label);
         if (variantLabels.length < 2) {
-            return txt(`Error: Need at least 2 variant steps for step_order ${step_order ?? 0}. Found: [${variantLabels.join(', ')}]. Add more variants via add_campaign_step with variant_label parameter.`);
+            return toolError({ code: 'validation_failed', error: `Error: Need at least 2 variant steps for step_order ${step_order ?? 0}. Found: [${variantLabels.join(', ')}]. Add more variants via add_campaign_step with variant_label parameter.` });
         }
         const emptyVariants = (steps ?? []).filter((step) => !step.subject?.trim() || !(step.body_html?.trim() || step.body_text?.trim()));
         if (emptyVariants.length) {
-            return j({
+            return toolError({
                 error: `Variant(s) [${emptyVariants.map((step) => step.variant_label).join(', ')}] for step_order ${step_order ?? 0} need a non-blank subject and body. Add content with add_campaign_step before creating the test.`,
                 code: 'validation_failed',
             });
@@ -61,7 +61,7 @@ export function registerAbTestingTools(server) {
             .eq('step_order', step_order ?? 0)
             .maybeSingle();
         if (existing)
-            return txt(`Error: A/B test already exists for campaign step ${step_order ?? 0}. Test ID: ${existing.id}`);
+            return toolError({ code: 'conflict', error: `Error: A/B test already exists for campaign step ${step_order ?? 0}. Test ID: ${existing.id}` });
         const { data: test, error: createErr } = await db()
             .from('ab_tests')
             .insert({
@@ -125,7 +125,7 @@ export function registerAbTestingTools(server) {
             idempotentHint: true,
             openWorldHint: false,
         },
-        description: 'Check statistical significance of an A/B test. Uses a two-proportion z-test. Returns per-variant rates, z-score, p-value, and whether the result is significant at the configured confidence level.',
+        description: 'Check statistical significance of an A/B test. Uses a two-proportion z-test. Returns per-variant rates (null when total sends is 0), z-score, p-value, and whether the result is significant at the configured confidence level.',
         inputSchema: {
             test_id: z.string().uuid(),
         },
@@ -138,7 +138,7 @@ export function registerAbTestingTools(server) {
             .eq('project_id', getProjectId())
             .maybeSingle();
         if (!test)
-            return txt('Error: Test not found');
+            return toolError({ code: 'not_found', error: 'Error: Test not found' });
         if (test.status === 'draft') {
             // Auto-start if campaign is active
             const { data: camp } = await db()
@@ -158,7 +158,10 @@ export function registerAbTestingTools(server) {
             .rpc('check_ab_significance', { p_test_id: test_id });
         if (error)
             return txt(`Error: ${dbToolError(error).error}`);
-        return j(data);
+        return j(data && Array.isArray(data.variants) ? {
+            ...data,
+            variants: data.variants.map((variant) => variant.total === 0 ? { ...variant, rate: null } : variant),
+        } : data);
     });
     server.registerTool('promote_ab_winner', {
         title: 'Promote A/B Winner',
@@ -173,9 +176,10 @@ export function registerAbTestingTools(server) {
             approval_id: z.string().uuid().optional().describe('Get this by calling once without it, then have a human approve the returned approve_url. Re-call with only approval_id to run the action.'),
             test_id: z.string().uuid(),
             winner: z.string().optional().describe('Override winner variant label (default: use statistically determined winner)'),
-            confirmed: z.boolean().optional().describe('Set true to execute after previewing'),
+            confirmed: z.boolean().optional().describe('Set true to request approval after previewing'),
         },
-    }, withApproval('promote_ab_winner', async ({ test_id, winner, confirmed }) => {
+    }, async (args) => {
+        const { test_id, winner, confirmed } = args;
         const projectId = getProjectId();
         const { data: test, error: testErr } = await db()
             .from('ab_tests')
@@ -184,13 +188,13 @@ export function registerAbTestingTools(server) {
             .eq('project_id', projectId)
             .maybeSingle();
         if (testErr || !test)
-            return txt('Error: Test not found');
+            return markNotExecuted(toolError({ code: 'not_found', error: 'Error: Test not found' }));
         const winnerLabel = winner ?? test.winner;
         if (!winnerLabel) {
-            return txt('Error: No winner determined yet. Run check_ab_significance first, or specify a winner manually.');
+            return markNotExecuted(toolError({ code: 'conflict', error: 'Error: No winner determined yet. Run check_ab_significance first, or specify a winner manually.' }));
         }
         if (!test.variants.includes(winnerLabel)) {
-            return txt(`Error: "${winnerLabel}" is not a valid variant. Options: ${test.variants.join(', ')}`);
+            return markNotExecuted(toolError({ code: 'validation_failed', error: `Error: "${winnerLabel}" is not a valid variant. Options: ${test.variants.join(', ')}` }));
         }
         const losingVariants = test.variants.filter((v) => v !== winnerLabel);
         // Get step details for preview
@@ -212,31 +216,34 @@ export function registerAbTestingTools(server) {
                     variant: s.variant_label,
                     subject: s.subject,
                 })),
-                message: `Will promote variant "${winnerLabel}" and delete ${loserSteps.length} losing variant(s). Call again with confirmed: true to execute.`,
+                message: `Will promote variant "${winnerLabel}" and delete ${loserSteps.length} losing variant(s). Call promote_ab_winner again with confirmed: true to request approval. After a person approves it, call promote_ab_winner again with only approval_id.`,
             });
         }
-        // Delete losing variant steps
-        for (const loser of loserSteps) {
+        // Validate and preview before requesting or consuming an approval.
+        return withApproval('promote_ab_winner', async () => {
+            // Delete losing variant steps
+            for (const loser of loserSteps) {
+                await db()
+                    .from('campaign_steps')
+                    .delete()
+                    .eq('id', loser.id);
+            }
+            // Mark test completed
             await db()
-                .from('campaign_steps')
-                .delete()
-                .eq('id', loser.id);
-        }
-        // Mark test completed
-        await db()
-            .from('ab_tests')
-            .update({
-            status: 'completed',
-            winner: winnerLabel,
-            decided_at: new Date().toISOString(),
-        })
-            .eq('id', test_id);
-        return j({
-            test_id,
-            status: 'completed',
-            winner: winnerLabel,
-            deleted_variants: losingVariants,
-            message: `A/B test "${test.name}" completed. Variant "${winnerLabel}" promoted, ${loserSteps.length} losing step(s) removed.`,
-        });
-    }));
+                .from('ab_tests')
+                .update({
+                status: 'completed',
+                winner: winnerLabel,
+                decided_at: new Date().toISOString(),
+            })
+                .eq('id', test_id);
+            return j({
+                test_id,
+                status: 'completed',
+                winner: winnerLabel,
+                deleted_variants: losingVariants,
+                message: `A/B test "${test.name}" completed. Variant "${winnerLabel}" promoted, ${loserSteps.length} losing step(s) removed.`,
+            });
+        })(args);
+    });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sendinel/mcp-server",
-  "version": "1.0.179",
+  "version": "1.0.181",
   "description": "AI-controlled email operations control plane for campaigns, contacts, segments, analytics, and multi-provider sending via MCP.",
   "mcpName": "ai.sendinel/mcp-server",
   "type": "module",