@sendinel/mcp-server 1.0.176 → 1.0.177

package/build/tools/templates.js

@@ -1,5 +1,5 @@
 import { withCreatedItems } from '../lib/mcp-created-items.js';
-import { literalIlikePattern } from '@sendinel/domain';
+import { literalIlikePattern, refuseActiveText, findUnresolvedTemplateTags } from '@sendinel/domain';
 import { withApproval } from '../lib/action-approvals.js';
 import { snapshotTemplateVersion, versionHasBodySnapshot } from '@sendinel/domain';
 import { z } from 'zod';
@@ -8,9 +8,20 @@ import { db, requestContext } from '../db.js';
 import { getProjectId } from '../project.js';
 import { recordBrandAssetUsage } from '../lib/brand-asset-usage.js';
 import { deriveTemplateVariables } from '../lib/voice.js';
-import { dbToolError } from '../lib/db-error.js';
+import { dbToolError, toolError } from '../lib/db-error.js';
+import { normalizeTagInput } from '../lib/tags.js';
+// campaign_templates.name is TEXT NOT NULL; enforce the tool's name limit here.
+const templateName = z.string().trim().min(1).max(200);
 const txt = (text) => ({ content: [{ type: 'text', text }] });
 const j = (data) => txt(JSON.stringify(data, null, 2));
+function templateContentError(content) {
+    return refuseActiveText('body_html', content.body_html) ?? refuseActiveText('subject_hint', content.subject_hint);
+}
+function templateWarnings(content) {
+    const tags = new Set([content.body_html, content.subject_hint]
+        .flatMap(value => typeof value === 'string' ? findUnresolvedTemplateTags(value) : []));
+    return [...tags].map(tag => `Unresolved template tag: ${tag}`);
+}
 function stripHtml(value) {
     return value
         .replace(/<style[\s\S]*?<\/style>/gi, ' ')
@@ -39,17 +50,15 @@ function translateMergeTags(body) {
         variables.add('unsubscribe_url');
         return '{{unsubscribe_url}}';
     })
-        .replace(/\*\|FNAME\|\*/g, () => {
-        variables.add('first_name');
-        return '{{first_name}}';
-    })
-        .replace(/\*\|LNAME\|\*/g, () => {
-        variables.add('last_name');
-        return '{{last_name}}';
-    })
-        .replace(/\*\|EMAIL\|\*/g, () => {
-        variables.add('email');
-        return '{{email}}';
+        .replace(/\*\|([^|]*?)\|\*/g, (literal, tag) => {
+        const mapped = { FNAME: 'first_name', LNAME: 'last_name', EMAIL: 'email', UNSUB: 'unsubscribe_url' };
+        const key = mapped[tag.toUpperCase()];
+        if (!key) {
+            unmapped.add(literal);
+            return literal;
+        }
+        variables.add(key);
+        return `{{${key}}}`;
     })
         .replace(/{{\s*customer\.([a-zA-Z0-9_.-]+)(?:\s*\|[^}]*)?\s*}}/g, (_match, token) => {
         const name = `custom.${String(token).replace(/^custom\./, '')}`;
@@ -57,12 +66,8 @@ function translateMergeTags(body) {
         unmapped.add(`customer.${token}`);
         return `{{${name}}}`;
     });
-    const tokenPattern = /{{\s*([a-zA-Z0-9_.-]+)\s*}}/g;
-    let match;
-    while ((match = tokenPattern.exec(translated)) !== null) {
-        if (match[1])
-            variables.add(match[1]);
-    }
+    for (const variable of deriveTemplateVariables({ body_html: translated }))
+        variables.add(variable);
     return { body: translated, variables: Array.from(variables), unmapped: Array.from(unmapped) };
 }
 export function registerTemplateTools(server) {
@@ -77,17 +82,19 @@ export function registerTemplateTools(server) {
         description: 'List email templates for the current project, including reusable system templates.',
         inputSchema: {
             limit: z.number().int().min(1).max(100).default(50).optional(),
+            offset: z.number().int().min(0).default(0).optional(),
             category: z.string().optional(),
             search: z.string().optional(),
         },
-    }, async ({ limit = 50, category, search }) => {
+    }, async ({ limit = 50, offset = 0, category, search }) => {
         const projectId = getProjectId();
         let query = db().from('campaign_templates')
             .select('id, name, category, description, subject_hint, brief_template, body_html, variables, tags, project_id, created_at, updated_at, is_transactional')
             .eq('is_archived', false)
             .or(`project_id.is.null,project_id.eq.${projectId}`)
             .order('created_at', { ascending: false })
-            .limit(limit);
+            .order('id', { ascending: false })
+            .range(offset, offset + limit);
         if (category)
             query = query.eq('category', category);
         if (search)
@@ -95,7 +102,9 @@ export function registerTemplateTools(server) {
         const { data, error } = await query;
         if (error)
             return j(dbToolError(error));
-        return j({ templates: data ?? [], count: data?.length ?? 0, truncated: (data?.length ?? 0) === limit });
+        const templates = (data ?? []).slice(0, limit);
+        const truncated = (data?.length ?? 0) > limit;
+        return j({ templates, count: templates.length, truncated, next_offset: truncated ? offset + limit : null });
     });
     server.registerTool('translate_template', {
         title: 'Translate Template',
@@ -125,11 +134,12 @@ export function registerTemplateTools(server) {
         if (!source)
             return j({ error: 'html or text is required' });
         const translatedBody = translateMergeTags(source);
+        const translatedText = text !== undefined ? translateMergeTags(text) : null;
         const translatedSubject = translateMergeTags(String(subject ?? name ?? 'Imported template'));
         const bodyHtml = html ? translatedBody.body : null;
-        const bodyText = text ? translatedBody.body : stripHtml(translatedBody.body);
-        const variables = Array.from(new Set([...translatedBody.variables, ...translatedSubject.variables]));
-        const unmapped = Array.from(new Set([...translatedBody.unmapped, ...translatedSubject.unmapped]));
+        const bodyText = translatedText?.body ?? stripHtml(translatedBody.body);
+        const variables = Array.from(new Set([...translatedBody.variables, ...(translatedText?.variables ?? []), ...translatedSubject.variables]));
+        const unmapped = Array.from(new Set([...translatedBody.unmapped, ...(translatedText?.unmapped ?? []), ...translatedSubject.unmapped]));
         const translated = {
             provider,
             source_template_id: source_template_id ?? null,
@@ -213,12 +223,14 @@ export function registerTemplateTools(server) {
     }, async ({ id }) => {
         const projectId = getProjectId();
         const { data, error } = await db().from('campaign_templates')
-            .select('id, name, category, description, subject_hint, brief_template, body_html, variables, tags, project_id, created_at, updated_at, is_transactional')
+            .select('id, name, category, description, subject_hint, brief_template, body_html, variables, tags, project_id, created_at, updated_at, is_transactional, is_archived')
             .eq('id', id)
             .or(`project_id.is.null,project_id.eq.${projectId}`)
             .maybeSingle();
         if (error)
             return j(dbToolError(error));
+        if (!data)
+            return toolError({ error: 'Template not found', code: 'not_found' });
         return j({ template: data });
     });
     server.registerTool('create_template', {
@@ -231,7 +243,7 @@ export function registerTemplateTools(server) {
         },
         description: 'Create a new email template. Use create_template_from_brief to AI-generate the content.',
         inputSchema: {
-            name: z.string().min(1),
+            name: templateName,
             brief: z.string().min(1),
             subject_hint: z.string().optional(),
             body_html: z.string().optional(),
@@ -242,18 +254,25 @@ export function registerTemplateTools(server) {
             brand_asset_ids: z.array(z.string().uuid()).optional().describe('Stable brand_media_assets ids explicitly referenced by this template.'),
         },
     }, async ({ name, brief, subject_hint, body_html, category, description, tags, is_transactional, brand_asset_ids }) => {
+        const content = { body_html, subject_hint };
+        const contentError = templateContentError(content);
+        if (contentError)
+            return toolError({ error: contentError, code: 'validation_failed' });
+        const parsedName = templateName.safeParse(name);
+        if (!parsedName.success)
+            return toolError({ error: 'Name must contain 1 to 200 characters after trimming', code: 'validation_failed' });
         const projectId = getProjectId();
         const { data, error } = await withCreatedItems('campaign_templates', db().from('campaign_templates')
             .insert({
             project_id: projectId,
-            name,
+            name: parsedName.data,
             brief_template: brief,
             subject_hint: subject_hint ?? '',
             body_html: body_html ?? null,
             variables: deriveTemplateVariables({ body_html: body_html ?? null, subject_hint: subject_hint ?? '' }),
             category: category ?? 'general',
             description: description ?? '',
-            tags: tags ?? [],
+            tags: normalizeTagInput(tags ?? []).tags,
             is_transactional: is_transactional ?? false,
         })
             .select('id, name, category, description, subject_hint, brief_template, body_html, body_source, body_text, format, variables, tags, created_at')
@@ -284,7 +303,7 @@ export function registerTemplateTools(server) {
             tags: data.tags,
             createdBy: requestContext()?.actorId ?? null,
         }).catch((err) => console.warn('Failed to snapshot template version for MCP create_template:', err));
-        return j({ template: data, ok: true });
+        return j({ template: data, ok: true, warnings: templateWarnings(content) });
     });
     server.registerTool('update_template', {
         title: 'Update Template',
@@ -297,7 +316,7 @@ export function registerTemplateTools(server) {
         description: 'Update an existing email template.',
         inputSchema: {
             id: z.string().uuid(),
-            name: z.string().optional(),
+            name: templateName.optional(),
             brief: z.string().optional(),
             subject_hint: z.string().optional(),
             body_html: z.string().optional(),
@@ -313,13 +332,26 @@ export function registerTemplateTools(server) {
             .select('id, project_id, body_html, subject_hint')
             .eq('id', id)
             .maybeSingle();
-        if (existingErr || !existing)
-            return j({ error: (existingErr ? dbToolError(existingErr).error : undefined) ?? 'Template not found', code: 'NOT_FOUND' });
+        if (existingErr)
+            return toolError(dbToolError(existingErr));
+        if (!existing)
+            return toolError({ error: 'Template not found', code: 'not_found' });
         if (!existing.project_id || existing.project_id !== projectId)
-            return j({ error: 'Cannot edit system templates', code: 'FORBIDDEN' });
+            return toolError({ error: 'Cannot edit system or other-project templates', code: 'forbidden' });
+        const content = {
+            body_html: updates.body_html !== undefined ? updates.body_html : existing.body_html,
+            subject_hint: updates.subject_hint !== undefined ? updates.subject_hint : existing.subject_hint,
+        };
+        const contentError = templateContentError(content);
+        if (contentError)
+            return toolError({ error: contentError, code: 'validation_failed' });
         const row = { updated_at: new Date().toISOString() };
-        if (updates.name !== undefined)
-            row.name = updates.name;
+        if (updates.name !== undefined) {
+            const parsedName = templateName.safeParse(updates.name);
+            if (!parsedName.success)
+                return toolError({ error: 'Name must contain 1 to 200 characters after trimming', code: 'validation_failed' });
+            row.name = parsedName.data;
+        }
         if (updates.brief !== undefined)
             row.brief_template = updates.brief;
         if (updates.subject_hint !== undefined)
@@ -331,13 +363,10 @@ export function registerTemplateTools(server) {
         if (updates.description !== undefined)
             row.description = updates.description;
         if (updates.tags !== undefined)
-            row.tags = updates.tags;
+            row.tags = normalizeTagInput(updates.tags).tags;
         if (updates.is_transactional !== undefined)
             row.is_transactional = updates.is_transactional;
-        row.variables = deriveTemplateVariables({
-            body_html: updates.body_html !== undefined ? updates.body_html : existing.body_html,
-            subject_hint: updates.subject_hint !== undefined ? updates.subject_hint : existing.subject_hint,
-        });
+        row.variables = deriveTemplateVariables(content);
         const { data, error } = await db().from('campaign_templates')
             .update(row)
             .eq('id', id)
@@ -370,7 +399,7 @@ export function registerTemplateTools(server) {
             tags: data.tags,
             createdBy: requestContext()?.actorId ?? null,
         }).catch((err) => console.warn('Failed to snapshot template version for MCP update_template:', err));
-        return j({ template: data, ok: true });
+        return j({ template: data, ok: true, warnings: templateWarnings(content) });
     });
     server.registerTool('delete_template', {
         title: 'Delete Template',
@@ -388,17 +417,19 @@ export function registerTemplateTools(server) {
             .select('id, project_id')
             .eq('id', id)
             .maybeSingle();
-        if (existingErr || !existing)
-            return j({ error: (existingErr ? dbToolError(existingErr).error : undefined) ?? 'Template not found', code: 'NOT_FOUND' });
+        if (existingErr)
+            return toolError(dbToolError(existingErr));
+        if (!existing)
+            return toolError({ error: 'Template not found', code: 'not_found' });
         if (!existing.project_id || existing.project_id !== projectId)
-            return j({ error: 'Cannot delete system templates', code: 'FORBIDDEN' });
+            return toolError({ error: 'Cannot archive system or other-project templates', code: 'forbidden' });
         const { error } = await db().from('campaign_templates')
             .update({ is_archived: true, updated_at: new Date().toISOString() })
             .eq('id', id)
             .eq('project_id', projectId);
         if (error)
             return j(dbToolError(error));
-        return j({ ok: true, deleted: id });
+        return j({ ok: true, deleted: id, archived: true });
     }));
     server.registerTool('restore_template_version', {
         title: 'Restore Template Version',
@@ -419,17 +450,21 @@ export function registerTemplateTools(server) {
             .select('id, project_id, body_html, body_text, subject_hint')
             .eq('id', id)
             .maybeSingle();
-        if (existingErr || !existing)
-            return j({ error: (existingErr ? dbToolError(existingErr).error : undefined) ?? 'Template not found', code: 'NOT_FOUND' });
+        if (existingErr)
+            return toolError(dbToolError(existingErr));
+        if (!existing)
+            return toolError({ error: 'Template not found', code: 'not_found' });
         if (!existing.project_id || existing.project_id !== projectId)
-            return j({ error: 'Cannot restore a system template', code: 'FORBIDDEN' });
+            return toolError({ error: 'Cannot restore system or other-project templates', code: 'forbidden' });
         const { data: version, error: versionErr } = await db().from('template_versions')
             .select('id, version, name, category, description, subject_hint, brief_template, tags, body_html, body_source, body_text, format')
             .eq('id', version_id)
             .eq('template_id', id)
             .maybeSingle();
-        if (versionErr || !version)
-            return j({ error: (versionErr ? dbToolError(versionErr).error : undefined) ?? 'Version not found', code: 'NOT_FOUND' });
+        if (versionErr)
+            return toolError(dbToolError(versionErr));
+        if (!version)
+            return toolError({ error: 'Version not found', code: 'not_found' });
         const bodyRestored = versionHasBodySnapshot(version);
         const row = {
             updated_at: new Date().toISOString(),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sendinel/mcp-server",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "description": "AI-controlled email operations control plane for campaigns, contacts, segments, analytics, and multi-provider sending via MCP.",
   "mcpName": "ai.sendinel/mcp-server",
   "type": "module",