@sendinel/mcp-server 1.0.141 → 1.0.142

package/build/tools/ab-testing.js

@@ -13,7 +13,7 @@ export function registerAbTestingTools(server) {
             idempotentHint: false,
             openWorldHint: false,
         },
-        description: 'Create an A/B test for a campaign step. Requires at least 2 variant steps (add via add_campaign_step with variant_label). Returns the test config for review.',
+        description: 'Create an A/B test for a campaign step. Requires a non-blank subject and body on every variant, and at least 2 variant steps (add via add_campaign_step with variant_label). Returns the test config for review.',
         inputSchema: {
             campaign_id: z.string().uuid(),
             step_order: z.number().int().min(0).optional().default(0).describe('Which step to test (default: 0, the first email)'),
@@ -38,13 +38,20 @@ export function registerAbTestingTools(server) {
         // Check variant steps exist
         const { data: steps } = await db()
             .from('campaign_steps')
-            .select('id, variant_label, subject')
+            .select('id, variant_label, subject, body_html, body_text')
             .eq('campaign_id', campaign_id)
             .eq('step_order', step_order ?? 0);
         const variantLabels = (steps ?? []).map((s) => s.variant_label);
         if (variantLabels.length < 2) {
             return txt(`Error: Need at least 2 variant steps for step_order ${step_order ?? 0}. Found: [${variantLabels.join(', ')}]. Add more variants via add_campaign_step with variant_label parameter.`);
         }
+        const emptyVariants = (steps ?? []).filter((step) => !step.subject?.trim() || !(step.body_html?.trim() || step.body_text?.trim()));
+        if (emptyVariants.length) {
+            return j({
+                error: `Variant(s) [${emptyVariants.map((step) => step.variant_label).join(', ')}] for step_order ${step_order ?? 0} need a non-blank subject and body. Add content with add_campaign_step before creating the test.`,
+                code: 'validation_failed',
+            });
+        }
         // Check no existing test for this step
         const { data: existing } = await db()
             .from('ab_tests')

package/build/tools/campaigns.js

@@ -137,6 +137,9 @@ export function buildCampaignTriggerDiagnostics(campaign, seenEvents) {
     if ((campaign.trigger_type === 'date_field' || campaign.trigger_type === 'contact_event') && (events.length || tags.length) && campaign.type === 'triggered') {
         diagnostics.push(`trigger_type is "${String(campaign.trigger_type)}" but event/tag triggers are also set; event intake will start it immediately, outside the ${String(campaign.trigger_type)} schedule`);
     }
+    if (campaign.type === 'triggered' && campaignTriggerKind(campaign) === 'manual' && !campaign.segment_id) {
+        diagnostics.push('campaign type is "triggered" but no trigger is set (it will never fire)');
+    }
     if (campaign.status !== 'active') {
         diagnostics.push(`it is ${String(campaign.status)}, so nothing starts until it is active`);
     }
@@ -855,7 +858,7 @@ export function registerCampaignTools(server) {
             .single();
         if (error)
             return { content: [{ type: 'text', text: `Error: ${error.message}` }] };
-        return { content: [{ type: 'text', text: JSON.stringify({ ...data, requires_approval_description: ACTIVATION_APPROVAL_DESCRIPTION }, null, 2) }] };
+        return { content: [{ type: 'text', text: JSON.stringify({ ...data, requires_approval_description: ACTIVATION_APPROVAL_DESCRIPTION, fires_on: buildCampaignFiresOn(data), trigger_diagnostics: buildCampaignTriggerDiagnostics(data) }, null, 2) }] };
     });
     const propertyConditions = z.array(z.union([
         z.object({ key: z.string(), op: z.enum(['eq', 'neq']), value: z.string() }).strict(),
@@ -869,7 +872,7 @@ export function registerCampaignTools(server) {
             idempotentHint: false,
             openWorldHint: false,
         },
-        description: 'Add an email step to a campaign. For A/B testing, add multiple steps with the same step_order but different variant_label values.',
+        description: 'Add an email step to a campaign. Requires a non-blank subject and body_html, body_text, or blocks that render to content. For A/B testing, add multiple steps with the same step_order but different variant_label values.',
         inputSchema: {
             campaign_id: z.string().uuid(),
             step_order: z.number().int().min(0).describe('Position in sequence (0 = first)'),
@@ -892,6 +895,16 @@ export function registerCampaignTools(server) {
             const properties = validateStepPropertyRules({ skip_if_property, send_only_if_property });
             if (!properties.ok)
                 return j({ error: properties.error, code: "INVALID_INPUT" });
+            const normalizedBlocks = blocks ? normalizeComposerBlocks(blocks) : undefined;
+            const htmlFromBlocks = normalizedBlocks?.length ? blocksToHtml(normalizedBlocks) : undefined;
+            if (!subject.trim())
+                return j({ error: 'A step needs a non-blank subject.', code: 'validation_failed' });
+            const hasBody = body_html?.trim() || body_text?.trim()
+                || htmlFromBlocks?.replace(/<[^>]*>/g, '').trim()
+                || normalizedBlocks?.some((block) => block.type === 'image' && block.url);
+            if (!hasBody) {
+                return j({ error: 'A step needs body_html or body_text (or blocks that render to content).', code: 'validation_failed' });
+            }
             const { data: campaign, error: campaignError } = await db()
                 .schema('email')
                 .from('campaigns')
@@ -911,8 +924,6 @@ export function registerCampaignTools(server) {
                 renderVars.survey_link = surveyLink;
             }
             const renderedSubject = survey_id ? renderTemplateVars(subject, renderVars) : subject;
-            const normalizedBlocks = blocks ? normalizeComposerBlocks(blocks) : undefined;
-            const htmlFromBlocks = normalizedBlocks?.length ? blocksToHtml(normalizedBlocks) : undefined;
             const renderedHtml = body_html !== undefined && survey_id ? renderTemplateVars(body_html, renderVars) : body_html ?? htmlFromBlocks;
             const renderedText = body_text !== undefined && survey_id ? renderTemplateVars(body_text, renderVars) : body_text;
             const { data, error } = await db()
@@ -975,12 +986,15 @@ export function registerCampaignTools(server) {
             // Placeholder text and links to the sending domain never go out (#3853).
             const { data: campRow, error: campErr } = await db()
                 .from('campaigns')
-                .select('id, name, site_id, trigger_event_name')
+                .select('id, name, site_id, type, trigger_type, trigger_event_name, trigger_tag, trigger_config, segment_id')
                 .eq('id', campaign_id)
                 .eq('project_id', getProjectId())
                 .maybeSingle();
             if (campErr)
                 return j({ error: `Could not check the campaign: ${campErr.message}`, code: 'CAMPAIGN_LOOKUP_FAILED' });
+            if (campRow?.type === 'triggered' && campaignTriggerKind(campRow) === 'manual' && !campRow.segment_id) {
+                return j({ error: 'This triggered campaign has no trigger. Set an event, tag, date, contact event, or segment before activating it.', code: 'validation_failed' });
+            }
             let contentWarnings = [];
             if (campRow) {
                 const { data: contentSteps, error: contentErr } = await db()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sendinel/mcp-server",
-  "version": "1.0.141",
+  "version": "1.0.142",
   "description": "AI-controlled email operations control plane for campaigns, contacts, segments, analytics, and multi-provider sending via MCP.",
   "mcpName": "ai.sendinel/mcp-server",
   "type": "module",