@sendinel/mcp-server 1.0.130 → 1.0.132

package/build/lib/action-approvals.js

@@ -11,7 +11,7 @@ import { createHash } from 'node:crypto';
 import { approvalSetupSummary, buildApprovalPreview, isHumanApprovalChannel, triggerChangeSummary, decodeHtmlEntities, stripHtmlComments } from '@sendinel/domain';
 import { requestContext } from '../db.js';
 import { getProjectId } from '../project.js';
-import { captureApprovalSnapshot, withoutApprovalSnapshot } from './approval-snapshot.js';
+import { captureApprovalSnapshot, withoutApprovalSnapshot, withoutApprovalDisplay } from './approval-snapshot.js';
 import { fireWebhookEvent } from './webhook-events.js';
 import { offerApprovalApp } from './approval-app.js';
 import { elicitApproval } from './approval-elicitation.js';
@@ -161,6 +161,9 @@ function launchSummary(p, d) {
 }
 /** Build a human-readable summary of the action for the approval screen */
 export function buildApprovalSummary(action, params, display = {}) {
+    if (params.__approval_snapshot?.display?.target_name) {
+        return buildApprovalPreview({ action, params }).plain_summary;
+    }
     const setup = approvalSetupSummary(action, params);
     if (setup)
         return setup;
@@ -425,7 +428,7 @@ export async function checkApproval(approvalId, options = {}) {
     if (data.params?.__approval_snapshot) {
         try {
             const current = await captureSnapshot(data.action, withoutApprovalSnapshot(data.params));
-            if (!approvalParamsEqual(current, data.params.__approval_snapshot)) {
+            if (!approvalParamsEqual(withoutApprovalDisplay(current), withoutApprovalDisplay(data.params.__approval_snapshot))) {
                 return { approved: false, status: 'target_changed_after_approval' };
             }
         }

package/build/lib/approval-snapshot.d.ts

@@ -1,4 +1,11 @@
 type Params = Record<string, any>;
+/** Optional display facts only. Failures must never prevent requesting or using an approval. */
+export declare function captureApprovalDisplay(action: string, params: Params, projectId: string): Promise<{
+    target_name: string;
+    target_detail?: string | undefined;
+} | undefined>;
+/** Exclude only optional display facts from revalidation, never from the payload hash. */
+export declare function withoutApprovalDisplay(snapshot: Params): Params;
 /** Server-owned display facts, saved inside the hash-bound params. Never supplied by a tool. */
 export declare function captureApprovalSnapshot(action: string, params: Params, projectId: string): Promise<Params>;
 export declare function withoutApprovalSnapshot(params: unknown): Record<string, unknown>;

package/build/lib/approval-snapshot.js

@@ -1,12 +1,141 @@
 import { isTesterRequest } from './tester-policy.js';
 import { captureTesterRequestSnapshot } from './tester-request-snapshot.js';
-import { readAllRows, chunkIds, scopeSegmentRulesToSite } from '@sendinel/domain';
+import { readAllRows, chunkIds, scopeSegmentRulesToSite, approvalDisplayFact, parseLinkedInCommentUrl } from '@sendinel/domain';
 import { callSendinelV1 } from './v1-client.js';
-import { db } from '../db.js';
+import { adminDb, db } from '../db.js';
 import { resolveSendAudience, resolveSegmentContactIds } from './send-audience.js';
 const TARGET_ACTIONS = new Set(['send_broadcast', 'broadcast_to_segment', 'launch_campaign', 'activate_campaigns',
     'update_campaign_status', 'set_campaign_trigger', 'create_campaign_with_content', 'enroll_segment',
     'send_transactional', 'send_awaiting_reply', 'send_test_email', 'send_newsletter_issue', 'schedule_newsletter_issue']);
+// Columns and scope paths verified against the SQL migrations; never select credentials.
+const DISPLAY_TARGETS = {
+    delete_segment: ['segments', 'segment_id', 'name'],
+    delete_template: ['campaign_templates', 'id', 'name'],
+    delete_signature: ['signature_blocks', 'id', 'name'],
+    delete_campaign: ['campaigns', 'campaign_id', 'name'],
+    delete_content_block: ['content_blocks', 'block_id', 'name'],
+    delete_custom_field: ['custom_field_definitions', 'id', 'label', true],
+    delete_landing_page: ['landing_pages', 'page_id', 'title'],
+    delete_list: ['contact_lists', 'list_id', 'name'],
+    delete_social_post: ['social_posts', 'post_id', 'title', true],
+    delete_subscriber_view: ['subscriber_list_views', 'view_id', 'name'],
+};
+const MEMBER_ACTIONS = new Set(['remove_team_member', 'set_team_member_role', 'set_member_project_access']);
+/** Optional display facts only. Failures must never prevent requesting or using an approval. */
+export async function captureApprovalDisplay(action, params, projectId) {
+    try {
+        if (!DISPLAY_TARGETS[action] && !MEMBER_ACTIONS.has(action) && ![
+            'revoke_api_key', 'revoke_invitation', 'rotate_custom_webhook_secret',
+            'delete_webhook_subscription', 'update_webhook_subscription',
+            'delete_campaign_step', 'update_campaign_step', 'reply_to_comment',
+        ].includes(action))
+            return undefined;
+        const source = db();
+        const client = typeof source.schema === 'function' ? source.schema('email') : source;
+        const read = async (query) => {
+            const { data, error } = await query.maybeSingle();
+            return error ? null : data;
+        };
+        const fact = (value, max = 45) => {
+            const text = approvalDisplayFact(value);
+            return text.length > max ? `${text.slice(0, max - 1)}…` : text;
+        };
+        const facts = (name, detail) => {
+            const target_name = fact(name);
+            const target_detail = fact(detail, 25);
+            return target_name ? { target_name, ...(target_detail ? { target_detail } : {}) } : undefined;
+        };
+        // Org rows have no project_id: derive their scope from the current project first.
+        const projectOrg = async () => {
+            const project = await read(client.from('projects').select('org_id').eq('id', projectId));
+            return typeof project?.org_id === 'string' && (!params.org_id || params.org_id === project.org_id)
+                ? project.org_id : null;
+        };
+        const target = DISPLAY_TARGETS[action];
+        if (target) {
+            const [table, param, column, orgScoped] = target;
+            if (typeof params[param] !== 'string')
+                return undefined;
+            let query = client.from(table).select(column).eq('id', params[param]).eq('project_id', projectId);
+            if (orgScoped) {
+                const orgId = await projectOrg();
+                if (!orgId)
+                    return undefined;
+                query = query.eq('org_id', orgId);
+            }
+            return facts((await read(query))?.[column]);
+        }
+        if (action === 'revoke_api_key') {
+            const key = await read(client.from('api_keys').select('id, name')
+                .eq('id', params.key_id).eq('project_id', projectId));
+            // The UUID suffix is public identity, never key material, a secret or a hash.
+            return key ? facts(key.name, `…${String(key.id).slice(-4)}`) : undefined;
+        }
+        if (MEMBER_ACTIONS.has(action) || action === 'revoke_invitation') {
+            const orgId = await projectOrg();
+            if (!orgId)
+                return undefined;
+            if (action === 'revoke_invitation') {
+                return facts((await read(client.from('org_invitations').select('email')
+                    .eq('id', params.invitation_id).eq('org_id', orgId)))?.email);
+            }
+            const member = await read(client.from('org_members').select('user_id')
+                .eq('user_id', params.user_id).eq('org_id', orgId));
+            if (!member)
+                return undefined;
+            // Only read Auth after proving this user belongs to the project's organization.
+            const { data, error } = await adminDb().auth.admin.getUserById(member.user_id);
+            return error ? undefined : facts(data?.user?.email);
+        }
+        if (action === 'delete_campaign_step' || action === 'update_campaign_step') {
+            // Steps inherit project scope from their campaign; inner join scopes the read itself.
+            const step = await read(client.from('campaign_steps')
+                .select('step_order, subject, campaign:campaigns!inner(name)')
+                .eq('id', params.step_id).eq('campaign.project_id', projectId));
+            if (!step)
+                return undefined;
+            const name = fact(step.campaign?.name, 25);
+            const number = Number.isInteger(step.step_order) && step.step_order >= 0 ? `email ${step.step_order + 1}` : 'email';
+            return facts(name ? `${name}: ${number}` : '', step.subject);
+        }
+        if (action === 'reply_to_comment') {
+            const { postUrn, commentUrn } = parseLinkedInCommentUrl(params.comment_url_or_urn);
+            const orgId = await projectOrg();
+            if (!orgId)
+                return undefined;
+            // Upload Post stores its returned id verbatim: it may be a full URN, a
+            // share-link URN or a bare comment id. The thread/project/org still bind it.
+            const commentIds = [...new Set([commentUrn, commentUrn.replace('(urn:li:', '('),
+                    commentUrn.match(/,(\d+)\)$/)?.[1]].filter((id) => typeof id === 'string'))];
+            const comment = await read(client.from('social_engagements').select('sender_name, body')
+                .eq('project_id', projectId).eq('org_id', orgId).eq('platform', 'linkedin')
+                .eq('external_thread_id', postUrn).in('external_message_id', commentIds));
+            return comment ? facts([fact(comment.sender_name, 18), fact(comment.body, 40)].filter(Boolean).join(': ')) : undefined;
+        }
+        if (action === 'rotate_custom_webhook_secret') {
+            const orgId = await projectOrg();
+            if (!orgId)
+                return undefined;
+            return facts((await read(client.from('platform_connections').select('display_name')
+                .eq('id', params.connection_id).eq('project_id', projectId).eq('org_id', orgId)
+                .eq('platform', 'custom')))?.display_name);
+        }
+        const webhook = await read(client.from('webhook_subscriptions').select('description, url')
+            .eq('id', params.subscription_id).eq('project_id', projectId));
+        if (!webhook)
+            return undefined;
+        return facts(fact(webhook.description) || new URL(webhook.url).hostname);
+    }
+    catch {
+        // Optional names cannot change approval eligibility or target validation.
+        return undefined;
+    }
+}
+/** Exclude only optional display facts from revalidation, never from the payload hash. */
+export function withoutApprovalDisplay(snapshot) {
+    const { display: _display, ...rest } = snapshot;
+    return rest;
+}
 /** Server-owned display facts, saved inside the hash-bound params. Never supplied by a tool. */
 export async function captureApprovalSnapshot(action, params, projectId) {
     if (action === 'invite_team_member') {
@@ -17,10 +146,12 @@ export async function captureApprovalSnapshot(action, params, projectId) {
         }
         return { version: 1, invitation: preview, recipient_count: 1 };
     }
+    const display = await captureApprovalDisplay(action, params, projectId);
+    const withDisplay = (value) => display ? { ...value, display } : value;
     const setup = isTesterRequest(action) ? await captureTesterRequestSnapshot(action, params, projectId) : null;
     const snapshot = { version: 1, campaigns: [], steps: [], sites: [], recipient_count: null };
     if (!TARGET_ACTIONS.has(action))
-        return setup ?? snapshot;
+        return withDisplay(setup ?? snapshot);
     const source = db();
     const client = typeof source.schema === 'function' ? source.schema('email') : source;
     const body = params.payload ?? params;
@@ -110,7 +241,7 @@ export async function captureApprovalSnapshot(action, params, projectId) {
     }
     snapshot.campaigns.sort((a, b) => String(a.id).localeCompare(String(b.id)));
     snapshot.steps.sort((a, b) => String(a.id).localeCompare(String(b.id)));
-    return setup ? { ...snapshot, ...setup, recipient_count: snapshot.recipient_count, audience_snapshot: snapshot } : snapshot;
+    return withDisplay(setup ? { ...snapshot, ...setup, recipient_count: snapshot.recipient_count, audience_snapshot: snapshot } : snapshot);
 }
 export function withoutApprovalSnapshot(params) {
     const { __approval_snapshot: _snapshot, ...rest } = (params ?? {});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sendinel/mcp-server",
-  "version": "1.0.130",
+  "version": "1.0.132",
   "description": "AI-controlled email operations control plane for campaigns, contacts, segments, analytics, and multi-provider sending via MCP.",
   "mcpName": "ai.sendinel/mcp-server",
   "type": "module",