@semiont/react-ui 0.5.27 → 0.5.29

package/src/components/modals/ResourceGenerateModal.tsx

@@ -1,21 +1,17 @@
 'use client';
 
-import { useState, useEffect, useCallback } from 'react';
-import type { CollaboratorEntry } from '@semiont/core';
+import { useState, useEffect, useCallback, useRef } from 'react';
+import type { CollaboratorEntry, GatheredContext } from '@semiont/core';
+import type { ResourceGatherOptions } from '@semiont/sdk';
 import { Dialog, DialogPanel, DialogTitle, Transition, TransitionChild } from '@headlessui/react';
-import { useResourceGather } from '../../hooks/useResourceGather';
 import { ConfigureGatherStep, type ResourceGatherConfig } from './ConfigureGatherStep';
+import { DiscardPrompt } from './DiscardPrompt';
 import { GatherContextStep } from './GatherContextStep';
-import { ConfigureGenerationStep, type GenerationConfig, type GenerationDraft } from './ConfigureGenerationStep';
+import { ConfigureGenerationStep, freshGenerationDraft, type GenerationConfig, type GenerationDraft } from './ConfigureGenerationStep';
 
 export interface ResourceGenerateModalTranslations {
-  // Step titles + nav
-  gatherTitle: string;
-  reviewTitle: string;
-  configureTitle: string;
-  next: string;
-  back: string;
-  cancel: string;
+  /** The ONE modal title — names the flow, not a step. */
+  title: string;
   // ConfigureGatherStep
   gatherIntro: string;
   includeContent: string;
@@ -23,16 +19,28 @@ export interface ResourceGenerateModalTranslations {
   gatherDepth: string;
   gatherMaxResources: string;
   gatherButton: string;
-  excludeLabel: string;
+  /** Labels the recall chips: every type included until deselected. */
+  recallLabel: string;
+  /** Affordance on the post-gather receipt row (title/tooltip). */
+  editGather: string;
   // GatherContextStep display
   loadingContext: string;
   failedContext: string;
   sourceContextLabel: string;
   connectionsLabel: string;
   citedByLabel: string;
+  graphPaneTitle: string;
+  graphEmpty: string;
+  resourceLinkLabel: string;
+  corpusPaneTitle: string;
+  corpusEmpty: string;
+  excludedReceipt: string;
+  machineRead: string;
+  score: string;
   // ConfigureGenerationStep
   resourceTitle: string;
   resourceTitlePlaceholder: string;
+  saveLocation: string;
   additionalInstructions: string;
   additionalInstructionsPlaceholder: string;
   language: string;
@@ -43,7 +51,13 @@ export interface ResourceGenerateModalTranslations {
   maxLength: string;
   maxLengthHelp: string;
   maxLengthCeiling: string;
+  outputFormat: string;
+  formatExtensionMismatch: string;
   generate: string;
+  // DiscardPrompt (GATHER-AT-THE-TOP P1)
+  discardDraftPrompt: string;
+  discardDraft: string;
+  keepEditing: string;
 }
 
 export interface ResourceGenerateModalProps {
@@ -57,8 +71,9 @@ export interface ResourceGenerateModalProps {
   onClose: () => void;
   resourceId: string;
   defaultTitle: string;
+  /** Folder of the source resource, so the artifact lands beside it (D11). */
+  defaultFolder?: string;
   locale: string;
-  gatherDefaults?: Partial<ResourceGatherConfig>;
   /**
    * Entity types offered in the exclusion picker. Owner-supplied so the
    * modal cannot present a failed load as an empty vocabulary.
@@ -70,70 +85,161 @@ export interface ResourceGenerateModalProps {
    * annotation wizard delegates generation to its parent.
    */
   onGenerateSubmit: (resourceId: string, config: GenerationConfig) => void;
+  /**
+   * Resource-gather state, verbatim from the SDK's gather unit slots
+   * (`gather.resourceContext$` / `resourceLoading$` / `resourceError$`) — the
+   * page reads the observables and threads them here, the same shape the
+   * reference wizard has always had (FLOW-LIFECYCLE-CONVERGENCE D3/A6). The
+   * modal renders this state; it never owns it.
+   */
+  gatherContext: GatheredContext | null;
+  gatherLoading: boolean;
+  gatherError: Error | null;
+  /**
+   * Run the gather — the page wires `gather.gatherResource(resourceId, …)`.
+   * No resourceId in the payload: the owner already holds it. `gatherResource`
+   * clears its slots at start, so no reset threading is needed.
+   */
+  onGather: (options: ResourceGatherOptions) => void;
   translations: ResourceGenerateModalTranslations;
 }
 
-type Step = 'configure-gather' | 'review' | 'configure-generation';
-
 /**
- * Resource-generate flow (GENERATE-FROM-BUTTON): configure gather options →
- * `gather.resource` → review the gathered `GatheredContext` → configure
- * generation → emit. Reuses the kind-aware `GatherContextStep` for the review.
+ * Resource-generate flow (GENERATE-FROM-BUTTON, folded by GATHER-AT-THE-TOP):
+ * one composite stack in a single scroll pane — the gather controls at the
+ * top, the gathered `GatheredContext` below them once gather fires, and the
+ * generation params beneath the evidence once context arrives. Re-gathering
+ * is scroll-up → tweak → Gather; `gatherResource` clears its slots at start,
+ * so the evidence refreshes in place. [gather zone] → [evidence] → [act
+ * zone]: the same grammar the resolve wizard expresses, whose gather zone
+ * happens to be automatic and whose act zone has a strategy choice.
  */
 export function ResourceGenerateModal({
   isOpen,
   onClose,
   resourceId,
   defaultTitle,
+  defaultFolder,
   locale,
-  gatherDefaults,
   entityTypeOptions = [],
   onGenerateSubmit,
+  gatherContext,
+  gatherLoading,
+  gatherError,
+  onGather,
   translations: t,
   generationAgent,
 }: ResourceGenerateModalProps) {
   // Same draft ownership as the wizard (WIZARD-NAVIGATION D3): the step is
   // controlled, so stepping back through this modal keeps what was typed.
-  const [generationDraft, setGenerationDraft] = useState<GenerationDraft>({
-    title: defaultTitle, storagePath: '', prompt: '', language: locale,
-    temperature: 0.7, maxTokensText: '500',
-  });
+  const freshDraft = (): GenerationDraft => freshGenerationDraft(defaultTitle, locale);
+  const [generationDraft, setGenerationDraft] = useState<GenerationDraft>(freshDraft);
 
-  const [step, setStep] = useState<Step>('configure-gather');
-  const { context, loading, error, gather, reset } = useResourceGather();
+  // "Has THIS run gathered yet?" — the page's gather slots survive across
+  // opens, so a context prop can be stale at open time. Nothing renders below
+  // the controls until the user fires a gather in this run.
+  const [gatherFired, setGatherFired] = useState(false);
+  // The fired snapshot feeds the receipt: what THIS gather actually asked
+  // for, exclusions included — not the form's live state, which the user can
+  // edit without re-firing.
+  const [lastGather, setLastGather] = useState<(ResourceGatherConfig & { excludeEntityTypes: string[] }) | null>(null);
+  const [editingGather, setEditingGather] = useState(false);
+  const [showDiscardPrompt, setShowDiscardPrompt] = useState(false);
   // Supplied by the owner, which already tracks the list with its failure
   // state. Fetching it here could only model (value | not-yet), so a failed
   // load would render an empty exclusion picker as though the KB had no
   // entity types. See .plans/PANEL-FAILURE-STATES.md
   const [excludeEntityTypes, setExcludeEntityTypes] = useState<string[]>([]);
 
-  // Reset to the first step whenever the modal (re)opens.
+  // Reset to the first step ON OPENING — and re-seed the draft, because
+  // `defaultTitle` is the source resource's name and loads asynchronously: the
+  // useState initializer ran at mount, which for the real page was before the
+  // name existed (GFR A4). Guarded to the false→true transition so a name
+  // arriving mid-flow cannot clobber what the user has typed.
+  const wasOpen = useRef(false);
+  // The dirty baseline is what was SEEDED, not the live prop: defaultTitle
+  // can move while the modal is open (the source resource's name loads
+  // asynchronously), and an untouched draft must not read as dirty because
+  // the baseline moved under it.
+  const seededTitle = useRef(defaultTitle);
   useEffect(() => {
-    if (isOpen) {
-      setStep('configure-gather');
+    if (isOpen && !wasOpen.current) {
+      setGatherFired(false);
+      setLastGather(null);
+      setEditingGather(false);
       setExcludeEntityTypes([]);
-      reset();
+      setGenerationDraft(freshDraft());
+      setShowDiscardPrompt(false);
+      seededTitle.current = defaultTitle;
     }
-  }, [isOpen, reset]);
+    wasOpen.current = isOpen;
+    // freshDraft reads defaultTitle/locale at call time; the effect keys on the
+    // OPENING, not on their drift while open.
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [isOpen]);
 
   const handleGather = useCallback((config: ResourceGatherConfig) => {
-    setStep('review');
-    void gather(resourceId, {
+    setGatherFired(true);
+    setLastGather({ ...config, excludeEntityTypes });
+    setEditingGather(false);
+    onGather({
       ...config,
       ...(excludeEntityTypes.length ? { excludeEntityTypes } : {}),
     });
-  }, [gather, resourceId, excludeEntityTypes]);
+  }, [onGather, excludeEntityTypes]);
 
   const handleGenerate = useCallback((config: GenerationConfig) => {
     onGenerateSubmit(resourceId, config);
     onClose();
   }, [onGenerateSubmit, resourceId, onClose]);
 
-  const stepTitle = step === 'configure-gather' ? t.gatherTitle : step === 'review' ? t.reviewTitle : t.configureTitle;
+  // D4/D5 (GATHER-AT-THE-TOP P1): typed text must not die with a dismissed
+  // modal. Toggles, depth, and exclusion picks are cheap to redo and never
+  // nag. Generate's completion path above bypasses this — the guard protects
+  // dismissal, not completion.
+  const draftDirty =
+    generationDraft.title !== seededTitle.current ||
+    generationDraft.storagePath.trim() !== '' ||
+    generationDraft.prompt.trim() !== '';
+  const handleDismiss = useCallback(() => {
+    if (draftDirty) {
+      setShowDiscardPrompt(true);
+      return;
+    }
+    onClose();
+  }, [draftDirty, onClose]);
+
+  // The whole stack is ONE scroll pane; when the params zone appears (context
+  // arrival — including each re-gather), enter at the BOTTOM so the
+  // parameters show in full, the evidence and controls tucked up under the
+  // modal top. jsdom has no layout (scrollHeight 0) — no-op in tests.
+  const stepScrollRef = useRef<HTMLDivElement>(null);
+  useEffect(() => {
+    const el = stepScrollRef.current;
+    if (el && gatherContext) el.scrollTop = el.scrollHeight;
+  }, [gatherContext]);
+
+  // The evidence zone: what the generation will be grounded in stays in view
+  // above the form.
+  const displayTranslations = {
+    loadingContext: t.loadingContext,
+    failedContext: t.failedContext,
+    sourceContextLabel: t.sourceContextLabel,
+    connectionsLabel: t.connectionsLabel,
+    citedByLabel: t.citedByLabel,
+    graphPaneTitle: t.graphPaneTitle,
+    graphEmpty: t.graphEmpty,
+    resourceLinkLabel: t.resourceLinkLabel,
+    corpusPaneTitle: t.corpusPaneTitle,
+    corpusEmpty: t.corpusEmpty,
+    excludedReceipt: t.excludedReceipt,
+    machineRead: t.machineRead,
+    score: t.score,
+  };
 
   return (
     <Transition appear show={isOpen}>
-      <Dialog as="div" className="semiont-search-modal" onClose={onClose}>
+      <Dialog as="div" className="semiont-search-modal" onClose={handleDismiss}>
         <TransitionChild
           enter="ease-out duration-200"
           enterFrom="opacity-0"
@@ -155,21 +261,53 @@ export function ResourceGenerateModal({
               leaveFrom="opacity-100 scale-100"
               leaveTo="opacity-0 scale-95"
             >
-              <DialogPanel className="semiont-search-modal__panel semiont-search-modal__panel--with-border semiont-search-modal__panel--gather">
+              <DialogPanel className="semiont-search-modal__panel semiont-search-modal__panel--with-border semiont-search-modal__panel--gather semiont-search-modal__panel--wide">
                 <div className="semiont-search-modal__header">
-                  <DialogTitle className="semiont-search-modal__title">{stepTitle}</DialogTitle>
-                  <button onClick={onClose} className="semiont-search-modal__close-button" aria-label="Close">
+                  <DialogTitle className="semiont-search-modal__title">{t.title}</DialogTitle>
+                  <button onClick={handleDismiss} className="semiont-search-modal__close-button" aria-label="Close">
                     ✕
                   </button>
                 </div>
 
-                {step === 'configure-gather' && (
+                {showDiscardPrompt && (
+                  <DiscardPrompt
+                    prompt={t.discardDraftPrompt}
+                    discardLabel={t.discardDraft}
+                    keepLabel={t.keepEditing}
+                    onDiscard={() => { setShowDiscardPrompt(false); onClose(); }}
+                    onKeepEditing={() => setShowDiscardPrompt(false)}
+                  />
+                )}
+
+                <div className="semiont-wizard__step-scroll" ref={stepScrollRef}>
+                  {/* Once fired, the spent controls fold into a receipt of
+                      what THIS gather asked for — the evidence leads the
+                      pane, the parameters stay visible and revisable. The
+                      form below is HIDDEN, not unmounted, so its values
+                      survive for the expand path. */}
+                  {gatherFired && !editingGather && lastGather && (
+                    <button
+                      type="button"
+                      className="semiont-gather-receipt"
+                      title={t.editGather}
+                      onClick={() => setEditingGather(true)}
+                    >
+                      {[
+                        `${t.gatherDepth} ${lastGather.depth}`,
+                        `${t.gatherMaxResources} ${lastGather.maxResources}`,
+                        ...(lastGather.includeContent ? [t.includeContent] : []),
+                        ...(lastGather.includeSummary ? [t.includeSummary] : []),
+                        ...(lastGather.excludeEntityTypes.length
+                          ? [t.excludedReceipt.replace('{{types}}', lastGather.excludeEntityTypes.join(', '))]
+                          : []),
+                      ].join(' · ')}
+                      <span aria-hidden="true"> ✎</span>
+                    </button>
+                  )}
+                  <div hidden={gatherFired && !editingGather}>
                   <ConfigureGatherStep
-                    defaults={gatherDefaults}
                     onGather={handleGather}
-                    onCancel={onClose}
                     translations={{
-                      cancel: t.cancel,
                       intro: t.gatherIntro,
                       includeContent: t.includeContent,
                       includeSummary: t.includeSummary,
@@ -180,17 +318,21 @@ export function ResourceGenerateModal({
                   >
                     {entityTypeOptions.length > 0 && (
                       <div className="semiont-form__field semiont-form__entity-types">
-                        <label className="semiont-form__label">{t.excludeLabel}</label>
-                        <div className="semiont-form__entity-type-buttons">
+                        <label className="semiont-form__label">{t.recallLabel}</label>
+                        {/* Recall chips — the exclude wire, inverted for the
+                            UI: every type is IN the recall until crossed off,
+                            so the state is still the exclude list and a chip
+                            is included when absent from it. */}
+                        <div className="semiont-form__recall-chips">
                           {entityTypeOptions.map((et) => {
-                            const isSelected = excludeEntityTypes.includes(et);
+                            const isIncluded = !excludeEntityTypes.includes(et);
                             return (
                               <button
                                 key={et}
                                 type="button"
-                                className="semiont-form__entity-type-button"
-                                data-selected={isSelected}
-                                aria-pressed={isSelected}
+                                className="semiont-form__recall-chip"
+                                data-included={isIncluded}
+                                aria-pressed={isIncluded}
                                 onClick={() => setExcludeEntityTypes(prev => prev.includes(et) ? prev.filter(x => x !== et) : [...prev, et])}
                               >
                                 {et}
@@ -201,75 +343,46 @@ export function ResourceGenerateModal({
                       </div>
                     )}
                   </ConfigureGatherStep>
-                )}
+                  </div>
 
-                {step === 'review' && (
-                  <>
+                  {gatherFired && (
                     <GatherContextStep
-                      context={context}
-                      contextLoading={loading}
-                      contextError={error}
+                      context={gatherContext}
+                      contextLoading={gatherLoading}
+                      contextError={gatherError}
+                      translations={displayTranslations}
+                    />
+                  )}
+
+                  {gatherFired && gatherContext && (
+                    <ConfigureGenerationStep
+                      {...(generationAgent ? { generationAgent } : {})}
+                      context={gatherContext}
+                      config={generationDraft}
+                      onConfigChange={setGenerationDraft}
+                      defaultFolder={defaultFolder}
+                      onGenerate={handleGenerate}
                       translations={{
-                        title: '',
-                        loadingContext: t.loadingContext,
-                        failedContext: t.failedContext,
-                        search: '',
-                        generate: '',
-                        compose: '',
-                        resolutionStrategyLabel: '',
-                        sourceContextLabel: t.sourceContextLabel,
-                        connectionsLabel: t.connectionsLabel,
-                        citedByLabel: t.citedByLabel,
-                        userHintLabel: '',
-                        userHintPlaceholder: '',
+                        resourceTitle: t.resourceTitle,
+                        resourceTitlePlaceholder: t.resourceTitlePlaceholder,
+                        saveLocation: t.saveLocation,
+                        additionalInstructions: t.additionalInstructions,
+                        additionalInstructionsPlaceholder: t.additionalInstructionsPlaceholder,
+                        language: t.language,
+                        languageHelp: t.languageHelp,
+                        creativity: t.creativity,
+                        creativityFocused: t.creativityFocused,
+                        creativityCreative: t.creativityCreative,
+                        maxLength: t.maxLength,
+                        maxLengthHelp: t.maxLengthHelp,
+                        maxLengthCeiling: t.maxLengthCeiling,
+                        outputFormat: t.outputFormat,
+                        formatExtensionMismatch: t.formatExtensionMismatch,
+                        generate: t.generate,
                       }}
                     />
-                    <div className="semiont-modal__actions" style={{ paddingTop: '0.5rem' }}>
-                      <button
-                        type="button"
-                        onClick={() => setStep('configure-gather')}
-                        className="semiont-button--secondary semiont-button--flex"
-                      >
-                        ◀ {t.back}
-                      </button>
-                      <button
-                        type="button"
-                        onClick={() => setStep('configure-generation')}
-                        disabled={!context}
-                        className="semiont-button--primary semiont-button--flex"
-                      >
-                        {t.next} ▶
-                      </button>
-                    </div>
-                  </>
-                )}
-
-                {step === 'configure-generation' && context && (
-                  <ConfigureGenerationStep
-                    {...(generationAgent ? { generationAgent } : {})}
-                    context={context}
-                    config={generationDraft}
-                    onConfigChange={setGenerationDraft}
-                    onBack={() => setStep('review')}
-                    onGenerate={handleGenerate}
-                    translations={{
-                      resourceTitle: t.resourceTitle,
-                      resourceTitlePlaceholder: t.resourceTitlePlaceholder,
-                      additionalInstructions: t.additionalInstructions,
-                      additionalInstructionsPlaceholder: t.additionalInstructionsPlaceholder,
-                      language: t.language,
-                      languageHelp: t.languageHelp,
-                      creativity: t.creativity,
-                      creativityFocused: t.creativityFocused,
-                      creativityCreative: t.creativityCreative,
-                      maxLength: t.maxLength,
-                      maxLengthHelp: t.maxLengthHelp,
-                      maxLengthCeiling: t.maxLengthCeiling,
-                      back: t.back,
-                      generate: t.generate,
-                    }}
-                  />
-                )}
+                  )}
+                </div>
               </DialogPanel>
             </TransitionChild>
           </div>