@semiont/react-ui 0.5.22 → 0.5.24

package/src/components/settings/__tests__/SettingsPanel.test.tsx

@@ -3,6 +3,7 @@ import { screen, fireEvent } from '@testing-library/react';
 import { renderWithProviders } from '../../../test-utils';
 import '@testing-library/jest-dom';
 import { SettingsPanel } from '../SettingsPanel';
+import { useLineNumbers } from '../../../contexts/LineNumbersContext';
 
 // Mock LiveRegion
 vi.mock('../../LiveRegion', () => ({
@@ -27,7 +28,6 @@ vi.mock('@semiont/core', async () => {
 
 describe('SettingsPanel', () => {
   const defaultProps = {
-    showLineNumbers: true,
     theme: 'light' as const,
     locale: 'en',
     hoverDelayMs: 150,
@@ -35,6 +35,7 @@ describe('SettingsPanel', () => {
 
   beforeEach(() => {
     vi.clearAllMocks();
+    localStorage.clear();
   });
 
   it('renders settings title', () => {
@@ -49,13 +50,14 @@ describe('SettingsPanel', () => {
     });
 
     it('shows toggle as checked when line numbers enabled', () => {
-      renderWithProviders(<SettingsPanel {...defaultProps} showLineNumbers={true} />);
+      localStorage.setItem('showLineNumbers', 'true');
+      renderWithProviders(<SettingsPanel {...defaultProps} />);
       const toggle = screen.getByRole('switch');
       expect(toggle).toHaveAttribute('aria-checked', 'true');
     });
 
     it('shows toggle as unchecked when line numbers disabled', () => {
-      renderWithProviders(<SettingsPanel {...defaultProps} showLineNumbers={false} />);
+      renderWithProviders(<SettingsPanel {...defaultProps} />);
       const toggle = screen.getByRole('switch');
       expect(toggle).toHaveAttribute('aria-checked', 'false');
     });
@@ -72,6 +74,29 @@ describe('SettingsPanel', () => {
       expect(handler).toHaveBeenCalled();
       sub.unsubscribe();
     });
+
+    it('renders the SHARED line-numbers state — a toggle applied elsewhere flips the switch', () => {
+      // The e2e chain is: switch click → bus emit → ToolbarPanels applies
+      // toggleLineNumbers → the switch must flip. The apply step happens in
+      // a DIFFERENT component, so the switch can only flip if all
+      // useLineNumbers consumers share one value. A prop-fed switch over a
+      // per-caller useState is how e2e 13:77/:134/:189 went red.
+      // See .plans/bugs/line-numbers-toggle-desynced-by-hoist.md
+      function OtherConsumer() {
+        const { toggleLineNumbers } = useLineNumbers();
+        return <button data-testid="other-consumer" onClick={toggleLineNumbers} />;
+      }
+      renderWithProviders(
+        <>
+          <OtherConsumer />
+          <SettingsPanel {...defaultProps} />
+        </>
+      );
+
+      expect(screen.getByRole('switch')).toHaveAttribute('aria-checked', 'false');
+      fireEvent.click(screen.getByTestId('other-consumer'));
+      expect(screen.getByRole('switch')).toHaveAttribute('aria-checked', 'true');
+    });
   });
 
   describe('theme selection', () => {

package/src/features/admin-devops/__tests__/AdminDevOpsPage.test.tsx

@@ -34,7 +34,6 @@ const createMockProps = (overrides?: Partial<AdminDevOpsPageProps>): AdminDevOps
     },
   ],
   theme: 'light',
-  showLineNumbers: false,
   activePanel: null,
   translations: {
     title: 'DevOps',
@@ -289,13 +288,13 @@ describe('AdminDevOpsPage', () => {
       );
     });
 
-    it('passes showLineNumbers to toolbar panels', () => {
+    it('does not thread showLineNumbers to toolbar panels — the setting is context-backed', () => {
       const ToolbarPanels = vi.fn(() => <div data-testid="toolbar-panels" />);
-      const props = createMockProps({ showLineNumbers: true, ToolbarPanels });
+      const props = createMockProps({ToolbarPanels });
       render(<AdminDevOpsPage {...props} />);
 
       expect(ToolbarPanels).toHaveBeenCalledWith(
-        expect.objectContaining({ showLineNumbers: true }),
+        expect.not.objectContaining({ showLineNumbers: expect.anything() }),
         undefined,
       );
     });
@@ -384,13 +383,6 @@ describe('AdminDevOpsPage', () => {
       expect(screen.getByText('DevOps')).toBeInTheDocument();
     });
 
-    it('renders with line numbers enabled', () => {
-      const props = createMockProps({ showLineNumbers: true });
-      render(<AdminDevOpsPage {...props} />);
-
-      expect(screen.getByText('DevOps')).toBeInTheDocument();
-    });
-
     it('handles all callbacks being defined', () => {
       const props = createMockProps();
       render(<AdminDevOpsPage {...props} />);

package/src/features/admin-devops/components/AdminDevOpsPage.tsx

@@ -23,7 +23,6 @@ export interface AdminDevOpsPageProps {
 
   // UI state
   theme: 'light' | 'dark' | 'system';
-  showLineNumbers: boolean;
   activePanel: string | null;
 
   // Translations
@@ -46,7 +45,6 @@ export interface AdminDevOpsPageProps {
 export function AdminDevOpsPage({
   suggestedFeatures,
   theme,
-  showLineNumbers,
   activePanel,
   translations: t,
   StatusDisplay,
@@ -132,7 +130,6 @@ export function AdminDevOpsPage({
         <ToolbarPanels
           activePanel={activePanel}
           theme={theme}
-          showLineNumbers={showLineNumbers}
         />
 
         <Toolbar

package/src/features/admin-exchange/__tests__/AdminExchangePage.test.tsx

@@ -18,7 +18,6 @@ const createProps = (overrides?: Partial<AdminExchangePageProps>): AdminExchange
   isImporting: false,
   importPhase: null,
   theme: 'light',
-  showLineNumbers: false,
   activePanel: null,
   translations: {
     title: 'Backup & Restore',

package/src/features/admin-exchange/components/AdminExchangePage.tsx

@@ -38,7 +38,6 @@ export interface AdminExchangePageProps {
 
   // UI state
   theme: 'light' | 'dark' | 'system';
-  showLineNumbers: boolean;
   activePanel: string | null;
 
   // Translations
@@ -62,7 +61,6 @@ export function AdminExchangePage({
   importMessage,
   importResult,
   theme,
-  showLineNumbers,
   activePanel,
   translations: t,
   ToolbarPanels,
@@ -108,7 +106,6 @@ export function AdminExchangePage({
         <ToolbarPanels
           activePanel={activePanel}
           theme={theme}
-          showLineNumbers={showLineNumbers}
         />
         <Toolbar
           context="simple"

package/src/features/admin-exchange/state/__tests__/exchange-state-unit.test.ts

@@ -2,7 +2,7 @@ import { describe, it, expect, vi } from 'vitest';
 import { firstValueFrom, of, throwError } from 'rxjs';
 import type { ShellStateUnit } from '../../../../state/shell-state-unit';
 import { createExchangeStateUnit } from '../exchange-state-unit';
-import { assertStateUnitAxioms, disposeProbe } from '@semiont/core/testing';
+import { assertStateUnitAxioms, disposeProbe } from '@semiont/core/testing/axioms';
 
 function mockBrowse(): ShellStateUnit {
   return { dispose: vi.fn() } as unknown as ShellStateUnit;

package/src/features/admin-security/__tests__/AdminSecurityPage.test.tsx

@@ -21,7 +21,6 @@ const createMockProps = (overrides?: Partial<AdminSecurityPageProps>): AdminSecu
   allowedDomains: ['example.com'],
   isLoading: false,
   theme: 'light',
-  showLineNumbers: false,
   activePanel: null,
   translations: {
     title: 'Security Settings',
@@ -347,12 +346,5 @@ describe('AdminSecurityPage', () => {
 
       expect(screen.getByText('Security Settings')).toBeInTheDocument();
     });
-
-    it('renders with line numbers enabled', () => {
-      const props = createMockProps({ showLineNumbers: true });
-      render(<AdminSecurityPage {...props} />);
-
-      expect(screen.getByText('Security Settings')).toBeInTheDocument();
-    });
   });
 });

package/src/features/admin-security/components/AdminSecurityPage.tsx

@@ -26,7 +26,6 @@ export interface AdminSecurityPageProps {
 
   // UI state
   theme: 'light' | 'dark' | 'system';
-  showLineNumbers: boolean;
   activePanel: string | null;
 
   // Translations
@@ -60,7 +59,6 @@ export function AdminSecurityPage({
   allowedDomains,
   isLoading,
   theme,
-  showLineNumbers,
   activePanel,
   translations: t,
   ToolbarPanels,
@@ -176,7 +174,6 @@ export function AdminSecurityPage({
         <ToolbarPanels
           activePanel={activePanel}
           theme={theme}
-          showLineNumbers={showLineNumbers}
         />
 
         <Toolbar

package/src/features/admin-security/state/__tests__/admin-security-state-unit.test.ts

@@ -1,10 +1,11 @@
 import { describe, it, expect, vi } from 'vitest';
+import { sessionOf } from '../../../../__tests__/test-client';
 import { firstValueFrom } from 'rxjs';
 import { filter } from 'rxjs/operators';
 import type { SemiontClient } from '@semiont/sdk';
 import type { ShellStateUnit } from '../../../../state/shell-state-unit';
 import { createAdminSecurityStateUnit } from '../admin-security-state-unit';
-import { assertStateUnitAxioms, disposeProbe } from '@semiont/core/testing';
+import { assertStateUnitAxioms, disposeProbe } from '@semiont/core/testing/axioms';
 
 function mockBrowse(): ShellStateUnit {
   return { dispose: vi.fn() } as unknown as ShellStateUnit;
@@ -20,7 +21,7 @@ describe('createAdminSecurityStateUnit', () => {
       providers: [{ name: 'google' }],
       allowedDomains: ['example.com'],
     });
-    const stateUnit = createAdminSecurityStateUnit(mockClient(getOAuthConfig), mockBrowse());
+    const stateUnit = createAdminSecurityStateUnit(sessionOf(mockClient(getOAuthConfig)), mockBrowse());
 
     const providers = await firstValueFrom(stateUnit.providers$.pipe(filter((p) => p.length > 0)));
     expect(providers).toEqual([{ name: 'google' }]);
@@ -32,8 +33,8 @@ describe('createAdminSecurityStateUnit', () => {
   });
 
   it('starts loading, resolves to false', async () => {
-    const stateUnit = createAdminSecurityStateUnit(
-      mockClient(vi.fn().mockResolvedValue({ providers: [], allowedDomains: [] })),
+    const stateUnit = createAdminSecurityStateUnit(sessionOf(
+      mockClient(vi.fn().mockResolvedValue({ providers: [], allowedDomains: [] }))),
       mockBrowse(),
     );
 
@@ -42,8 +43,8 @@ describe('createAdminSecurityStateUnit', () => {
   });
 
   it('sets loading false on error', async () => {
-    const stateUnit = createAdminSecurityStateUnit(
-      mockClient(vi.fn().mockRejectedValue(new Error('fail'))),
+    const stateUnit = createAdminSecurityStateUnit(sessionOf(
+      mockClient(vi.fn().mockRejectedValue(new Error('fail')))),
       mockBrowse(),
     );
 
@@ -52,8 +53,8 @@ describe('createAdminSecurityStateUnit', () => {
   });
 
   it('defaults to empty arrays when response has no providers/domains', async () => {
-    const stateUnit = createAdminSecurityStateUnit(
-      mockClient(vi.fn().mockResolvedValue({})),
+    const stateUnit = createAdminSecurityStateUnit(sessionOf(
+      mockClient(vi.fn().mockResolvedValue({}))),
       mockBrowse(),
     );
 
@@ -74,7 +75,7 @@ describe('AdminSecurityStateUnit — StateUnit axioms', () => {
       setup: () => {
         const browse = disposeProbe();
         const client = mockClient(vi.fn().mockResolvedValue({ providers: [], allowedDomains: [] }));
-        return { unit: createAdminSecurityStateUnit(client, browse as unknown as ShellStateUnit), passedIn: [browse] };
+        return { unit: createAdminSecurityStateUnit(sessionOf(client), browse as unknown as ShellStateUnit), passedIn: [browse] };
       },
       surfaces: (u) => [u.providers$, u.allowedDomains$, u.isLoading$],
     });

package/src/features/admin-security/state/admin-security-state-unit.ts

@@ -2,7 +2,7 @@ import { BehaviorSubject, type Observable } from 'rxjs';
 import { createDisposer } from '@semiont/sdk';
 import type { StateUnit } from '@semiont/core';
 import type { ShellStateUnit } from '../../../state/shell-state-unit';
-import type { SemiontClient } from '@semiont/sdk';
+import type { SemiontSession } from '@semiont/sdk';
 
 export interface AdminSecurityStateUnit extends StateUnit {
   browse: ShellStateUnit;
@@ -12,9 +12,10 @@ export interface AdminSecurityStateUnit extends StateUnit {
 }
 
 export function createAdminSecurityStateUnit(
-  client: SemiontClient,
+  session: SemiontSession,
   browse: ShellStateUnit,
 ): AdminSecurityStateUnit {
+  const { client } = session;
   const disposer = createDisposer();
   // `browse` (ShellStateUnit) is a *passed-in* dependency owned by the caller
   // (`useShellStateUnit`), not this unit — do NOT add it to the disposer (it's the

package/src/features/admin-users/__tests__/AdminUsersPage.test.tsx

@@ -78,7 +78,6 @@ const createMockProps = (overrides?: Partial<AdminUsersPageProps>): AdminUsersPa
   onAddUser: vi.fn(),
   onExportUsers: vi.fn(),
   theme: 'light',
-  showLineNumbers: false,
   activePanel: null,
   translations: createMockTranslations(),
   ToolbarPanels: ({ children }: any) => <div data-testid="toolbar-panels">{children}</div>,

package/src/features/admin-users/components/AdminUsersPage.tsx

@@ -152,7 +152,6 @@ export interface AdminUsersPageProps {
 
   // UI state
   theme: 'light' | 'dark' | 'system';
-  showLineNumbers: boolean;
   activePanel: string | null;
 
   // Translations
@@ -213,7 +212,6 @@ export function AdminUsersPage({
   onAddUser,
   onExportUsers,
   theme,
-  showLineNumbers,
   activePanel,
   translations: t,
   ToolbarPanels,
@@ -453,7 +451,6 @@ export function AdminUsersPage({
         <ToolbarPanels
           activePanel={activePanel}
           theme={theme}
-          showLineNumbers={showLineNumbers}
         />
 
         <Toolbar

package/src/features/admin-users/state/__tests__/admin-users-state-unit.test.ts

@@ -1,10 +1,11 @@
 import { describe, it, expect, vi } from 'vitest';
+import { sessionOf } from '../../../../__tests__/test-client';
 import { firstValueFrom } from 'rxjs';
 import { filter } from 'rxjs/operators';
 import type { SemiontClient } from '@semiont/sdk';
 import type { ShellStateUnit } from '../../../../state/shell-state-unit';
 import { createAdminUsersStateUnit } from '../admin-users-state-unit';
-import { assertStateUnitAxioms, disposeProbe } from '@semiont/core/testing';
+import { assertStateUnitAxioms, disposeProbe } from '@semiont/core/testing/axioms';
 
 function mockBrowse(): ShellStateUnit {
   return { dispose: vi.fn() } as unknown as ShellStateUnit;
@@ -28,7 +29,7 @@ describe('createAdminUsersStateUnit', () => {
   it('fetches users and stats on creation', async () => {
     const listUsers = vi.fn().mockResolvedValue({ users: [{ id: 'u1' }] });
     const getUserStats = vi.fn().mockResolvedValue({ stats: { total: 1 } });
-    const stateUnit = createAdminUsersStateUnit(mockClient({ listUsers, getUserStats }), mockBrowse());
+    const stateUnit = createAdminUsersStateUnit(sessionOf(mockClient({ listUsers, getUserStats })), mockBrowse());
 
     const users = await firstValueFrom(stateUnit.users$.pipe(filter((u) => u.length > 0)));
     expect(users).toEqual([{ id: 'u1' }]);
@@ -40,7 +41,7 @@ describe('createAdminUsersStateUnit', () => {
   });
 
   it('starts with loading true, resolves to false', async () => {
-    const stateUnit = createAdminUsersStateUnit(mockClient(), mockBrowse());
+    const stateUnit = createAdminUsersStateUnit(sessionOf(mockClient()), mockBrowse());
 
     await firstValueFrom(stateUnit.usersLoading$.pipe(filter((l) => !l)));
     await firstValueFrom(stateUnit.statsLoading$.pipe(filter((l) => !l)));
@@ -51,7 +52,7 @@ describe('createAdminUsersStateUnit', () => {
   it('sets loading false on fetch error', async () => {
     const listUsers = vi.fn().mockRejectedValue(new Error('fail'));
     const getUserStats = vi.fn().mockRejectedValue(new Error('fail'));
-    const stateUnit = createAdminUsersStateUnit(mockClient({ listUsers, getUserStats }), mockBrowse());
+    const stateUnit = createAdminUsersStateUnit(sessionOf(mockClient({ listUsers, getUserStats })), mockBrowse());
 
     await firstValueFrom(stateUnit.usersLoading$.pipe(filter((l) => !l)));
     await firstValueFrom(stateUnit.statsLoading$.pipe(filter((l) => !l)));
@@ -63,7 +64,7 @@ describe('createAdminUsersStateUnit', () => {
     const listUsers = vi.fn().mockResolvedValue({ users: [] });
     const getUserStats = vi.fn().mockResolvedValue({ stats: null });
     const updateUser = vi.fn().mockResolvedValue(undefined);
-    const stateUnit = createAdminUsersStateUnit(mockClient({ listUsers, getUserStats, updateUser }), mockBrowse());
+    const stateUnit = createAdminUsersStateUnit(sessionOf(mockClient({ listUsers, getUserStats, updateUser })), mockBrowse());
 
     await firstValueFrom(stateUnit.usersLoading$.pipe(filter((l) => !l)));
     listUsers.mockClear();
@@ -85,7 +86,7 @@ describe('AdminUsersStateUnit — StateUnit axioms', () => {
     assertStateUnitAxioms({
       setup: () => {
         const browse = disposeProbe();
-        return { unit: createAdminUsersStateUnit(mockClient(), browse as unknown as ShellStateUnit), passedIn: [browse] };
+        return { unit: createAdminUsersStateUnit(sessionOf(mockClient()), browse as unknown as ShellStateUnit), passedIn: [browse] };
       },
       surfaces: (u) => [u.users$, u.stats$, u.usersLoading$, u.statsLoading$],
     });

package/src/features/admin-users/state/admin-users-state-unit.ts

@@ -3,7 +3,7 @@ import { userDID } from '@semiont/core';
 import { createDisposer } from '@semiont/sdk';
 import type { StateUnit } from '@semiont/core';
 import type { ShellStateUnit } from '../../../state/shell-state-unit';
-import type { SemiontClient } from '@semiont/sdk';
+import type { SemiontSession } from '@semiont/sdk';
 
 export interface AdminUsersStateUnit extends StateUnit {
   browse: ShellStateUnit;
@@ -15,9 +15,10 @@ export interface AdminUsersStateUnit extends StateUnit {
 }
 
 export function createAdminUsersStateUnit(
-  client: SemiontClient,
+  session: SemiontSession,
   browse: ShellStateUnit,
 ): AdminUsersStateUnit {
+  const { client } = session;
   const disposer = createDisposer();
   // `browse` (ShellStateUnit) is a *passed-in* dependency owned by the caller
   // (`useShellStateUnit`), not this unit — do NOT add it to the disposer (it's the

package/src/features/auth-welcome/state/__tests__/welcome-state-unit.test.ts

@@ -1,26 +1,37 @@
-import { describe, it, expect, vi } from 'vitest';
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { firstValueFrom } from 'rxjs';
 import { filter } from 'rxjs/operators';
-import type { SemiontClient } from '@semiont/sdk';
+import type { SemiontSession } from '@semiont/sdk';
+import { AuthNamespace } from '@semiont/sdk';
+import { createTestSession, stubBackend } from '@semiont/sdk/testing';
 import { createWelcomeStateUnit } from '../welcome-state-unit';
-import { assertStateUnitAxioms } from '@semiont/core/testing';
-
-function mockClient(overrides: {
-  getMe?: ReturnType<typeof vi.fn>;
-  acceptTerms?: ReturnType<typeof vi.fn>;
-} = {}): SemiontClient {
-  return {
-    auth: {
-      me: overrides.getMe ?? vi.fn().mockResolvedValue({ termsAcceptedAt: undefined }),
-      acceptTerms: overrides.acceptTerms ?? vi.fn().mockResolvedValue(undefined),
-    },
-  } as unknown as SemiontClient;
+import { assertStateUnitAxioms } from '@semiont/core/testing/axioms';
+
+// Real session over the scriptable transport (SESSION-TYPED-FACTORIES pilot);
+// auth behavior scripted by prototype spies, the AuthShell precedent — the
+// previous `as unknown as SemiontClient` hand-mock was the M1 disease.
+let getMe: ReturnType<typeof vi.spyOn>;
+let acceptTermsSpy: ReturnType<typeof vi.spyOn>;
+
+beforeEach(() => {
+  getMe = vi.spyOn(AuthNamespace.prototype, 'me');
+  getMe.mockResolvedValue({ termsAcceptedAt: undefined } as never);
+  acceptTermsSpy = vi.spyOn(AuthNamespace.prototype, 'acceptTerms');
+  acceptTermsSpy.mockResolvedValue(undefined as never);
+});
+
+afterEach(() => {
+  vi.restoreAllMocks();
+});
+
+function makeSession(): SemiontSession {
+  return createTestSession({ backend: stubBackend() }).session;
 }
 
 describe('createWelcomeStateUnit', () => {
   it('fetches user data on creation', async () => {
-    const getMe = vi.fn().mockResolvedValue({ termsAcceptedAt: '2026-01-01' });
-    const stateUnit = createWelcomeStateUnit(mockClient({ getMe }));
+    getMe.mockResolvedValue({ termsAcceptedAt: '2026-01-01' } as never);
+    const stateUnit = createWelcomeStateUnit(makeSession());
 
     const data = await firstValueFrom(stateUnit.userData$.pipe(filter((d) => d !== null)));
     expect(data).toEqual({ termsAcceptedAt: '2026-01-01' });
@@ -29,8 +40,8 @@ describe('createWelcomeStateUnit', () => {
   });
 
   it('initializes with null userData and not processing', async () => {
-    const getMe = vi.fn().mockReturnValue(new Promise(() => {}));
-    const stateUnit = createWelcomeStateUnit(mockClient({ getMe }));
+    getMe.mockReturnValue(new Promise(() => {}) as never);
+    const stateUnit = createWelcomeStateUnit(makeSession());
 
     const data = await firstValueFrom(stateUnit.userData$);
     const processing = await firstValueFrom(stateUnit.isProcessing$);
@@ -41,14 +52,13 @@ describe('createWelcomeStateUnit', () => {
   });
 
   it('acceptTerms sets isProcessing and updates userData', async () => {
-    const acceptTerms = vi.fn().mockResolvedValue(undefined);
-    const stateUnit = createWelcomeStateUnit(mockClient({ acceptTerms }));
+    const stateUnit = createWelcomeStateUnit(makeSession());
 
     await firstValueFrom(stateUnit.userData$.pipe(filter((d) => d !== null)));
 
     await stateUnit.acceptTerms();
 
-    expect(acceptTerms).toHaveBeenCalledOnce();
+    expect(acceptTermsSpy).toHaveBeenCalledOnce();
 
     const data = await firstValueFrom(stateUnit.userData$);
     expect(data?.termsAcceptedAt).toBeDefined();
@@ -60,8 +70,8 @@ describe('createWelcomeStateUnit', () => {
   });
 
   it('acceptTerms resets isProcessing on error', async () => {
-    const acceptTerms = vi.fn().mockRejectedValue(new Error('fail'));
-    const stateUnit = createWelcomeStateUnit(mockClient({ acceptTerms }));
+    acceptTermsSpy.mockRejectedValue(new Error('fail') as never);
+    const stateUnit = createWelcomeStateUnit(makeSession());
 
     await firstValueFrom(stateUnit.userData$.pipe(filter((d) => d !== null)));
 
@@ -74,8 +84,8 @@ describe('createWelcomeStateUnit', () => {
   });
 
   it('handles getMe failure gracefully', async () => {
-    const getMe = vi.fn().mockRejectedValue(new Error('unauthorized'));
-    const stateUnit = createWelcomeStateUnit(mockClient({ getMe }));
+    getMe.mockRejectedValue(new Error('unauthorized') as never);
+    const stateUnit = createWelcomeStateUnit(makeSession());
 
     await vi.waitFor(() => expect(getMe).toHaveBeenCalled());
 
@@ -89,7 +99,7 @@ describe('createWelcomeStateUnit', () => {
 describe('WelcomeStateUnit — StateUnit axioms', () => {
   it('satisfies the StateUnit axioms', () => {
     assertStateUnitAxioms({
-      setup: () => createWelcomeStateUnit(mockClient()),
+      setup: () => createWelcomeStateUnit(makeSession()),
       surfaces: (u) => [u.userData$, u.isProcessing$],
       invocations: (u) => [() => u.acceptTerms()],
     });

package/src/features/auth-welcome/state/welcome-state-unit.ts

@@ -1,7 +1,7 @@
 import { BehaviorSubject, type Observable } from 'rxjs';
 import { createDisposer } from '@semiont/sdk';
 import type { StateUnit } from '@semiont/core';
-import type { SemiontClient } from '@semiont/sdk';
+import type { SemiontSession } from '@semiont/sdk';
 
 export interface WelcomeStateUnit extends StateUnit {
   userData$: Observable<{ termsAcceptedAt?: string } | null>;
@@ -9,9 +9,14 @@ export interface WelcomeStateUnit extends StateUnit {
   acceptTerms(): Promise<void>;
 }
 
+// Session-typed (SESSION-TYPED-FACTORIES.md D1): the parameter is the
+// lifetime this unit must not outlive. This page crashed in production when
+// the unit was constructed with `undefined` during session activation —
+// `useSessionStateUnit` + this signature make that unrepresentable.
 export function createWelcomeStateUnit(
-  client: SemiontClient,
+  session: SemiontSession,
 ): WelcomeStateUnit {
+  const { client } = session;
   const disposer = createDisposer();
 
   const userData$ = new BehaviorSubject<{ termsAcceptedAt?: string } | null>(null);

package/src/features/moderate-entity-tags/__tests__/EntityTagsPage.test.tsx

@@ -19,7 +19,6 @@ const createMockProps = (overrides?: Partial<EntityTagsPageProps>): EntityTagsPa
   onAddTag: vi.fn(),
   isAddingTag: false,
   theme: 'light',
-  showLineNumbers: false,
   activePanel: null,
   translations: {
     pageTitle: 'Entity Tags',
@@ -344,7 +343,6 @@ describe('EntityTagsPage', () => {
         error: 'Error',
         isAddingTag: true,
         theme: 'dark',
-        showLineNumbers: true,
         activePanel: 'settings',
       });
       render(<EntityTagsPage {...props} />);

package/src/features/moderate-entity-tags/components/EntityTagsPage.tsx

@@ -28,7 +28,6 @@ export interface EntityTagsPageProps {
 
   // UI state
   theme: 'light' | 'dark' | 'system';
-  showLineNumbers: boolean;
   activePanel: string | null;
 
   // Translations
@@ -55,7 +54,6 @@ export function EntityTagsPage({
   onAddTag,
   isAddingTag,
   theme,
-  showLineNumbers,
   activePanel,
   translations: t,
   ToolbarPanels,
@@ -150,7 +148,6 @@ export function EntityTagsPage({
         <ToolbarPanels
           activePanel={activePanel}
           theme={theme}
-          showLineNumbers={showLineNumbers}
         />
 
         <Toolbar