@semaphore-protocol/identity 4.0.0-beta.2 → 4.0.0-beta.4

package/dist/types/identity.d.ts

@@ -8,6 +8,8 @@ import type { BigNumberish } from "@zk-kit/utils";
  * and {@link https://www.poseidon-hash.info | Poseidon} for signatures.
  * In addition, the commitment, i.e. the hash of the public key, is used to represent
  * Semaphore identities in groups, adding an additional layer of privacy and security.
+ * The private key of the identity is stored as a hexadecimal string or text.
+ * The other attributes are stored as stringified bigint.
  */
 export default class Identity {
     private _privateKey;
@@ -15,10 +17,11 @@ export default class Identity {
     private _publicKey;
     private _commitment;
     /**
-     * Initializes the class attributes based on a given private key.
-     * If the private key is not passed as a parameter, a random key is generated.
-     * The constructor calculates the secret scalar and public key from the private key,
-     * and computes a commitment of the public key using a hash function (Poseidon).
+     * Initializes the class attributes based on a given private key, which must be a hexadecimal string or a text.
+     * Hexadecimal strings must not start with '0x' or '0X'.
+     * If the private key is not passed as a parameter, a random hexadecimal key will be generated.
+     * The EdDSAPoseidon class is used to generate the secret scalar and the public key.
+     * Additionally, the constructor computes a commitment of the public key using a hash function (Poseidon).
      *
      * @example
      * // Generates an identity.
@@ -27,29 +30,29 @@ export default class Identity {
      * // Generates an identity with a random private key.
      * const { privateKey, publicKey, commitment } = new Identity()
      *
-     * @param privateKey The private key used to derive the public key.
+     * @param privateKey The private key used to derive the public key (hexadecimal or string).
      */
-    constructor(privateKey?: BigNumberish);
+    constructor(privateKey?: string);
     /**
      * Returns the private key.
-     * @returns The private key as a {@link https://zkkit.pse.dev/types/_zk_kit_utils.BigNumberish.html | BigNumberish}.
+     * @returns The private key as a string (hexadecimal or text).
      */
-    get privateKey(): BigNumberish;
+    get privateKey(): string;
     /**
      * Returns the secret scalar.
      * @returns The secret scalar as a string.
      */
-    get secretScalar(): string;
+    get secretScalar(): bigint;
     /**
      * Returns the public key as a Baby Jubjub {@link https://zkkit.pse.dev/types/_zk_kit_baby_jubjub.Point.html | Point}.
      * @returns The public key as a point.
      */
-    get publicKey(): Point<string>;
+    get publicKey(): Point<bigint>;
     /**
      * Returns the commitment hash of the public key.
      * @returns The commitment as a string.
      */
-    get commitment(): string;
+    get commitment(): bigint;
     /**
      * Generates a signature for a given message using the private key.
      * This method demonstrates how to sign a message and could be used
@@ -62,7 +65,7 @@ export default class Identity {
      * @param message The message to be signed.
      * @returns A {@link https://zkkit.pse.dev/types/_zk_kit_eddsa_poseidon.Signature.html | Signature} object containing the signature components.
      */
-    signMessage(message: BigNumberish): Signature<string>;
+    signMessage(message: BigNumberish): Signature<bigint>;
     /**
      * Verifies a signature against a given message and public key.
      * This static method allows for the verification of signatures without needing

package/package.json

@@ -1,21 +1,15 @@
 {
   "name": "@semaphore-protocol/identity",
-  "version": "4.0.0-beta.2",
+  "version": "4.0.0-beta.4",
   "description": "A library to create Semaphore identities.",
   "type": "module",
   "license": "MIT",
-  "main": "dist/index.browser.js",
+  "main": "dist/index.js",
   "types": "dist/types/index.d.ts",
   "exports": {
-    ".": {
-      "types": "./dist/types/index.d.ts",
-      "node": {
-        "require": "./dist/index.node.cjs",
-        "default": "./dist/index.node.js"
-      },
-      "browser": "./dist/index.browser.js",
-      "default": "./dist/index.browser.js"
-    }
+    "types": "./dist/types/index.d.ts",
+    "require": "./dist/index.cjs",
+    "default": "./dist/index.js"
   },
   "files": [
     "dist/",
@@ -29,9 +23,7 @@
     "url": "https://github.com/semaphore-protocol/semaphore.git/issues"
   },
   "scripts": {
-    "build": "rimraf dist && yarn build:browser && yarn build:node",
-    "build:browser": "rollup -c rollup.browser.config.ts --configPlugin typescript",
-    "build:node": "rollup -c rollup.node.config.ts --configPlugin typescript",
+    "build": "rimraf dist && rollup -c rollup.config.ts --configPlugin typescript",
     "prepublishOnly": "yarn build"
   },
   "publishConfig": {
@@ -41,13 +33,15 @@
     "@rollup/plugin-alias": "^5.1.0",
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-node-resolve": "^15.2.3",
-    "rollup-plugin-cleanup": "^3.2.1",
-    "rollup-plugin-typescript2": "^0.36.0"
+    "@rollup/plugin-typescript": "^11.1.6",
+    "rimraf": "^5.0.5",
+    "rollup": "^4.12.0",
+    "rollup-plugin-cleanup": "^3.2.1"
   },
   "dependencies": {
-    "@zk-kit/baby-jubjub": "0.2.0",
-    "@zk-kit/eddsa-poseidon": "0.6.0",
-    "@zk-kit/utils": "0.3.0",
+    "@zk-kit/baby-jubjub": "0.3.0",
+    "@zk-kit/eddsa-poseidon": "0.10.0",
+    "@zk-kit/utils": "0.8.1",
     "poseidon-lite": "0.2.0"
   }
 }

package/src/identity.ts

@@ -1,8 +1,10 @@
 import type { Point } from "@zk-kit/baby-jubjub"
-import { Signature, derivePublicKey, deriveSecretScalar, signMessage, verifySignature } from "@zk-kit/eddsa-poseidon"
+import { EdDSAPoseidon, Signature, signMessage, verifySignature } from "@zk-kit/eddsa-poseidon"
 import type { BigNumberish } from "@zk-kit/utils"
+import { bufferToHexadecimal, hexadecimalToBuffer } from "@zk-kit/utils/conversions"
+import { requireString } from "@zk-kit/utils/error-handlers"
+import { isHexadecimal } from "@zk-kit/utils/type-checks"
 import { poseidon2 } from "poseidon-lite/poseidon2"
-import { randomNumber } from "./random-number.node"
 
 /**
  * The Semaphore identity is essentially an {@link https://www.rfc-editor.org/rfc/rfc8032 | EdDSA}
@@ -11,23 +13,26 @@ import { randomNumber } from "./random-number.node"
  * and {@link https://www.poseidon-hash.info | Poseidon} for signatures.
  * In addition, the commitment, i.e. the hash of the public key, is used to represent
  * Semaphore identities in groups, adding an additional layer of privacy and security.
+ * The private key of the identity is stored as a hexadecimal string or text.
+ * The other attributes are stored as stringified bigint.
  */
 export default class Identity {
     // The EdDSA private key, passed as a parameter or generated randomly.
-    private _privateKey: BigNumberish
+    private _privateKey: string
     // The secret scalar derived from the private key.
     // It is used in circuits to derive the public key.
-    private _secretScalar: string
+    private _secretScalar: bigint
     // The EdDSA public key, derived from the private key.
-    private _publicKey: Point<string>
+    private _publicKey: Point<bigint>
     // The identity commitment used as a public value in Semaphore groups.
-    private _commitment: string
+    private _commitment: bigint
 
     /**
-     * Initializes the class attributes based on a given private key.
-     * If the private key is not passed as a parameter, a random key is generated.
-     * The constructor calculates the secret scalar and public key from the private key,
-     * and computes a commitment of the public key using a hash function (Poseidon).
+     * Initializes the class attributes based on a given private key, which must be a hexadecimal string or a text.
+     * Hexadecimal strings must not start with '0x' or '0X'.
+     * If the private key is not passed as a parameter, a random hexadecimal key will be generated.
+     * The EdDSAPoseidon class is used to generate the secret scalar and the public key.
+     * Additionally, the constructor computes a commitment of the public key using a hash function (Poseidon).
      *
      * @example
      * // Generates an identity.
@@ -36,20 +41,37 @@ export default class Identity {
      * // Generates an identity with a random private key.
      * const { privateKey, publicKey, commitment } = new Identity()
      *
-     * @param privateKey The private key used to derive the public key.
+     * @param privateKey The private key used to derive the public key (hexadecimal or string).
      */
-    constructor(privateKey: BigNumberish = randomNumber().toString()) {
-        this._privateKey = privateKey
-        this._secretScalar = deriveSecretScalar(privateKey)
-        this._publicKey = derivePublicKey(privateKey)
-        this._commitment = poseidon2(this._publicKey).toString()
+    constructor(privateKey?: string) {
+        let eddsa: EdDSAPoseidon
+
+        if (privateKey) {
+            requireString(privateKey, "privateKey")
+
+            this._privateKey = privateKey
+
+            if (isHexadecimal(privateKey, false)) {
+                eddsa = new EdDSAPoseidon(hexadecimalToBuffer(privateKey))
+            } else {
+                eddsa = new EdDSAPoseidon(privateKey)
+            }
+        } else {
+            eddsa = new EdDSAPoseidon()
+
+            this._privateKey = bufferToHexadecimal(eddsa.privateKey as any)
+        }
+
+        this._secretScalar = eddsa.secretScalar
+        this._publicKey = eddsa.publicKey
+        this._commitment = poseidon2(this._publicKey)
     }
 
     /**
      * Returns the private key.
-     * @returns The private key as a {@link https://zkkit.pse.dev/types/_zk_kit_utils.BigNumberish.html | BigNumberish}.
+     * @returns The private key as a string (hexadecimal or text).
      */
-    public get privateKey(): BigNumberish {
+    public get privateKey(): string {
         return this._privateKey
     }
 
@@ -57,7 +79,7 @@ export default class Identity {
      * Returns the secret scalar.
      * @returns The secret scalar as a string.
      */
-    public get secretScalar(): string {
+    public get secretScalar(): bigint {
         return this._secretScalar
     }
 
@@ -65,7 +87,7 @@ export default class Identity {
      * Returns the public key as a Baby Jubjub {@link https://zkkit.pse.dev/types/_zk_kit_baby_jubjub.Point.html | Point}.
      * @returns The public key as a point.
      */
-    public get publicKey(): Point<string> {
+    public get publicKey(): Point<bigint> {
         return this._publicKey
     }
 
@@ -73,7 +95,7 @@ export default class Identity {
      * Returns the commitment hash of the public key.
      * @returns The commitment as a string.
      */
-    public get commitment(): string {
+    public get commitment(): bigint {
         return this._commitment
     }
 
@@ -89,7 +111,7 @@ export default class Identity {
      * @param message The message to be signed.
      * @returns A {@link https://zkkit.pse.dev/types/_zk_kit_eddsa_poseidon.Signature.html | Signature} object containing the signature components.
      */
-    public signMessage(message: BigNumberish): Signature<string> {
+    public signMessage(message: BigNumberish): Signature<bigint> {
         return signMessage(this.privateKey, message)
     }