@semantic-release/github 9.2.0 → 9.2.2

package/lib/definitions/errors.js

@@ -170,7 +170,7 @@ export function EGHNOPERMISSION({ owner, repo }) {
       "README.md#github-authentication",
     )}) configured in the \`GH_TOKEN\` or \`GITHUB_TOKEN\` environment variable must allows to push to the repository ${owner}/${repo}.
 
-Please make sure the GitHub user associated with the token is an [owner](https://help.github.com/articles/permission-levels-for-a-user-account-repository/#owner-access-on-a-repository-owned-by-a-user-account) or a [collaborator](https://help.github.com/articles/permission-levels-for-a-user-account-repository/#collaborator-access-on-a-repository-owned-by-a-user-account) if the reposotory belong to a user account or has [write permissions](https://help.github.com/articles/managing-team-access-to-an-organization-repository) if the repository [belongs to an organization](https://help.github.com/articles/repository-permission-levels-for-an-organization).`,
+Please make sure the GitHub user associated with the token is an [owner](https://help.github.com/articles/permission-levels-for-a-user-account-repository/#owner-access-on-a-repository-owned-by-a-user-account) or a [collaborator](https://help.github.com/articles/permission-levels-for-a-user-account-repository/#collaborator-access-on-a-repository-owned-by-a-user-account) if the repository belong to a user account or has [write permissions](https://help.github.com/articles/managing-team-access-to-an-organization-repository) if the repository [belongs to an organization](https://help.github.com/articles/repository-permission-levels-for-an-organization).`,
   };
 }
 

package/lib/publish.js

@@ -54,11 +54,6 @@ export default async function publish(pluginConfig, context, { Octokit }) {
 
   debug("release object: %O", release);
 
-  // If discussionCategoryName is not undefined or false
-  if (discussionCategoryName) {
-    release.discussion_category_name = discussionCategoryName;
-  }
-
   const draftReleaseOptions = { ...release, draft: true };
 
   // When there are no assets, we publish a release directly.
@@ -76,12 +71,22 @@ export default async function publish(pluginConfig, context, { Octokit }) {
       return { url, name: RELEASE_NAME, id: releaseId };
     }
 
+    // add discussion_category_name if discussionCategoryName is not undefined or false
+    if (discussionCategoryName) {
+      release.discussion_category_name = discussionCategoryName;
+    }
+
     const {
-      data: { html_url: url, id: releaseId },
+      data: { html_url: url, id: releaseId, discussion_url },
     } = await octokit.request("POST /repos/{owner}/{repo}/releases", release);
 
     logger.log("Published GitHub release: %s", url);
-    return { url, name: RELEASE_NAME, id: releaseId };
+
+    if (discussionCategoryName) {
+      logger.log("Created GitHub release discussion: %s", discussion_url);
+    }
+
+    return { url, name: RELEASE_NAME, id: releaseId, discussion_url };
   }
 
   // We'll create a draft release, append the assets to it, and then publish it.
@@ -152,18 +157,30 @@ export default async function publish(pluginConfig, context, { Octokit }) {
     return { url: draftUrl, name: RELEASE_NAME, id: releaseId };
   }
 
+  const patchRelease = {
+    owner,
+    repo,
+    release_id: releaseId,
+    draft: false,
+  };
+
+  // add discussion_category_name if discussionCategoryName is not undefined or false
+  if (discussionCategoryName) {
+    patchRelease.discussion_category_name = discussionCategoryName;
+  }
+
   const {
-    data: { html_url: url },
+    data: { html_url: url, discussion_url },
   } = await octokit.request(
     "PATCH /repos/{owner}/{repo}/releases/{release_id}",
-    {
-      owner,
-      repo,
-      release_id: releaseId,
-      draft: false,
-    },
+    patchRelease,
   );
 
   logger.log("Published GitHub release: %s", url);
-  return { url, name: RELEASE_NAME, id: releaseId };
+
+  if (discussionCategoryName) {
+    logger.log("Created GitHub release discussion: %s", discussion_url);
+  }
+
+  return { url, name: RELEASE_NAME, id: releaseId, discussion_url };
 }

package/package.json

@@ -1,12 +1,13 @@
 {
   "name": "@semantic-release/github",
   "description": "semantic-release plugin to publish a GitHub release and comment on released Pull Requests/Issues",
-  "version": "9.2.0",
+  "version": "9.2.2",
   "type": "module",
   "author": "Pierre Vanduynslager (https://twitter.com/@pvdlg_)",
   "ava": {
     "files": [
-      "test/**/*.test.js"
+      "test/**/*.test.js",
+      "!test/integration.test.js"
     ],
     "nodeArguments": [
       "--no-warnings"
@@ -17,7 +18,8 @@
   },
   "contributors": [
     "Stephan Bönnemann <stephan@boennemann.me> (http://boennemann.me)",
-    "Gregor Martynus (https://twitter.com/gr2m)"
+    "Gregor Martynus (https://twitter.com/gr2m)",
+    "Matt Travi <npm@travi.org> (https://matt.travi.org/)"
   ],
   "dependencies": {
     "@octokit/core": "^5.0.0",
@@ -41,10 +43,15 @@
     "ava": "5.3.1",
     "c8": "8.0.1",
     "cpy": "10.1.0",
+    "cz-conventional-changelog": "3.3.0",
     "fetch-mock": "npm:@gr2m/fetch-mock@9.11.0-pull-request-644.1",
+    "lockfile-lint": "4.12.1",
+    "ls-engines": "0.9.0",
+    "npm-run-all2": "6.1.1",
     "prettier": "3.0.3",
-    "semantic-release": "22.0.5",
-    "sinon": "16.0.0",
+    "publint": "0.2.5",
+    "semantic-release": "22.0.7",
+    "sinon": "17.0.1",
     "tempy": "3.1.0"
   },
   "engines": {
@@ -80,6 +87,19 @@
     ],
     "all": true
   },
+  "config": {
+    "commitizen": {
+      "path": "./node_modules/cz-conventional-changelog"
+    }
+  },
+  "lockfile-lint": {
+    "path": "package-lock.json",
+    "type": "npm",
+    "validate-https": true,
+    "allowed-hosts": [
+      "npm"
+    ]
+  },
   "peerDependencies": {
     "semantic-release": ">=20.1.0"
   },
@@ -93,10 +113,14 @@
   },
   "scripts": {
     "codecov": "codecov -f coverage/coverage-final.json",
-    "lint": "prettier --check \"{lib,test}/**/*.{js,json,ts}\" \"*.{js,md,json}\" \".github/**/*.yml\"",
-    "lint:fix": "prettier --write \"{lib,test}/**/*.{js,json,ts}\" \"*.{js,md,json}\" \".github/**/*.yml\"",
-    "semantic-release": "semantic-release",
-    "test": "c8 ava -v"
+    "lint:prettier": "prettier --check \"{lib,test}/**/*.{js,json,ts}\" \"*.{js,md,json}\" \".github/**/*.yml\"",
+    "lint:prettier:fix": "prettier --write \"{lib,test}/**/*.{js,json,ts}\" \"*.{js,md,json}\" \".github/**/*.yml\"",
+    "lint:lockfile": "lockfile-lint",
+    "lint:engines": "ls-engines",
+    "lint:publish": "publint --strict",
+    "test": "npm-run-all --print-label --parallel lint:* --parallel test:*",
+    "test:unit": "c8 ava --verbose",
+    "test:integration": "ava --verbose test/integration.test.js"
   },
   "renovate": {
     "extends": [