@semantic-release/github 7.1.2 → 7.2.0

package/README.md

@@ -3,9 +3,7 @@
 [**semantic-release**](https://github.com/semantic-release/semantic-release) plugin to publish a
 [GitHub release](https://help.github.com/articles/about-releases) and comment on released Pull Requests/Issues.
 
-[![Travis](https://img.shields.io/travis/semantic-release/github.svg)](https://travis-ci.org/semantic-release/github)
-[![Codecov](https://img.shields.io/codecov/c/github/semantic-release/github.svg)](https://codecov.io/gh/semantic-release/github)
-[![Greenkeeper badge](https://badges.greenkeeper.io/semantic-release/github.svg)](https://greenkeeper.io/)
+[![Build Status](https://github.com/semantic-release/github/workflows/Test/badge.svg)](https://github.com/semantic-release/github/actions?query=workflow%3ATest+branch%3Amaster)
 
 [![npm latest version](https://img.shields.io/npm/v/@semantic-release/github/latest.svg)](https://www.npmjs.com/package/@semantic-release/github)
 [![npm next version](https://img.shields.io/npm/v/@semantic-release/github/next.svg)](https://www.npmjs.com/package/@semantic-release/github)

package/lib/glob-assets.js

@@ -1,5 +1,4 @@
 const path = require('path');
-const {basename} = require('path');
 const {isPlainObject, castArray, uniqWith, uniq} = require('lodash');
 const dirGlob = require('dir-glob');
 const globby = require('globby');
@@ -40,7 +39,7 @@ module.exports = async ({cwd}, assets) =>
                 // - `path` of the matched file
                 // - `name` based on the actual file name (to avoid assets with duplicate `name`)
                 // - other properties of the original asset definition
-                return globbed.map((file) => ({...asset, path: file, name: basename(file)}));
+                return globbed.map((file) => ({...asset, path: file, name: path.basename(file)}));
               }
 
               // If asset is an Object, output an Object definition with:

package/lib/parse-github-url.js

@@ -5,7 +5,7 @@ module.exports = (repositoryUrl) => {
       new URL(match ? `ssh://${auth ? `${auth}@` : ''}${host}/${path}` : repositoryUrl).pathname
     );
     return {owner, repo};
-  } catch (_) {
+  } catch {
     return {};
   }
 };

package/lib/publish.js

@@ -1,4 +1,4 @@
-const {basename, extname, resolve} = require('path');
+const path = require('path');
 const {stat, readFile} = require('fs-extra');
 const {isPlainObject, template} = require('lodash');
 const mime = require('mime');
@@ -21,7 +21,15 @@ module.exports = async (pluginConfig, context) => {
   const {githubToken, githubUrl, githubApiPathPrefix, proxy, assets} = resolveConfig(pluginConfig, context);
   const {owner, repo} = parseGithubUrl(repositoryUrl);
   const github = getClient({githubToken, githubUrl, githubApiPathPrefix, proxy});
-  const release = {owner, repo, tag_name: gitTag, name, body: notes, prerelease: isPrerelease(branch)};
+  const release = {
+    owner,
+    repo,
+    tag_name: gitTag,
+    target_commitish: branch.name,
+    name,
+    body: notes,
+    prerelease: isPrerelease(branch),
+  };
 
   debug('release object: %O', release);
 
@@ -53,8 +61,8 @@ module.exports = async (pluginConfig, context) => {
       let file;
 
       try {
-        file = await stat(resolve(cwd, filePath));
-      } catch (_) {
+        file = await stat(path.resolve(cwd, filePath));
+      } catch {
         logger.error('The asset %s cannot be read, and will be ignored.', filePath);
         return;
       }
@@ -64,13 +72,13 @@ module.exports = async (pluginConfig, context) => {
         return;
       }
 
-      const fileName = template(asset.name || basename(filePath))(context);
+      const fileName = template(asset.name || path.basename(filePath))(context);
       const upload = {
         url: uploadUrl,
-        data: await readFile(resolve(cwd, filePath)),
+        data: await readFile(path.resolve(cwd, filePath)),
         name: fileName,
         headers: {
-          'content-type': mime.getType(extname(fileName)) || 'text/plain',
+          'content-type': mime.getType(path.extname(fileName)) || 'text/plain',
           'content-length': file.size,
         },
       };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@semantic-release/github",
   "description": "semantic-release plugin to publish a GitHub release and comment on released Pull Requests/Issues",
-  "version": "7.1.2",
+  "version": "7.2.0",
   "author": "Pierre Vanduynslager (https://twitter.com/@pvdlg_)",
   "ava": {
     "files": [
@@ -37,15 +37,15 @@
     "ava": "3.13.0",
     "clear-module": "4.1.1",
     "codecov": "3.8.1",
-    "nock": "12.0.3",
+    "nock": "13.0.5",
     "nyc": "15.1.0",
     "proxy": "1.0.2",
     "proxyquire": "2.1.3",
-    "semantic-release": "17.2.2",
+    "semantic-release": "17.2.3",
     "server-destroy": "1.0.1",
     "sinon": "9.2.1",
-    "tempy": "0.5.0",
-    "xo": "0.30.0"
+    "tempy": "1.0.0",
+    "xo": "0.34.2"
   },
   "engines": {
     "node": ">=10.18"
@@ -99,7 +99,8 @@
     "lint": "xo",
     "pretest": "npm run lint",
     "semantic-release": "semantic-release",
-    "test": "nyc ava -v"
+    "test": "nyc ava -v",
+    "test:ci": "nyc ava -v"
   },
   "xo": {
     "prettier": true,
@@ -111,7 +112,8 @@
           "properties": "never"
         }
       ],
-      "unicorn/string-content": "off"
+      "unicorn/string-content": "off",
+      "unicorn/no-reduce": "off"
     }
   },
   "renovate": {