@semantic-release/github 12.0.0-beta.1 → 12.0.0-beta.3

package/README.md

@@ -3,7 +3,7 @@
 [**semantic-release**](https://github.com/semantic-release/semantic-release) plugin to publish a
 [GitHub release](https://help.github.com/articles/about-releases) and comment on released Pull Requests/Issues.
 
-[![Build Status](https://github.com/semantic-release/github/workflows/Test/badge.svg)](https://github.com/semantic-release/github/actions?query=workflow%3ATest+branch%3Amaster)
+[![Build Status](https://github.com/semantic-release/github/actions/workflows/test.yml/badge.svg)](https://github.com/semantic-release/github/actions/workflows/test.yml?query=branch%3Amaster)
 
 [![npm latest version](https://img.shields.io/npm/v/@semantic-release/github/latest.svg)](https://www.npmjs.com/package/@semantic-release/github)
 [![npm next version](https://img.shields.io/npm/v/@semantic-release/github/next.svg)](https://www.npmjs.com/package/@semantic-release/github)

package/lib/find-sr-issues.js

@@ -1,7 +1,7 @@
 import { uniqBy } from "lodash-es";
 import { ISSUE_ID, RELEASE_FAIL_LABEL } from "./definitions/constants.js";
 
-export default async (octokit, logger, title, labels, owner, repo) => {
+export default async (octokit, logger, labels, owner, repo) => {
   let issues = [];
 
   const {
@@ -18,25 +18,6 @@ export default async (octokit, logger, title, labels, owner, repo) => {
 
   issues.push(...issueNodes);
 
-  /**
-   * BACKWARD COMPATIBILITY: Fallback to the search API if the issue was not found in the GraphQL response.
-   * This fallback will be removed in a future release
-   */
-  if (issueNodes.length === 0) {
-    try {
-      const {
-        data: { items: backwardIssues },
-      } = await octokit.request("GET /search/issues", {
-        q: `in:title+repo:${owner}/${repo}+type:issue+state:open+${title}`,
-      });
-      issues.push(...backwardIssues);
-    } catch (error) {
-      logger.log(
-        "An error occured fetching issue via fallback (with GH SearchAPI)",
-      );
-    }
-  }
-
   const uniqueSRIssues = uniqBy(
     issues.filter((issue) => issue.body && issue.body.includes(ISSUE_ID)),
     "number",
@@ -46,7 +27,7 @@ export default async (octokit, logger, title, labels, owner, repo) => {
 };
 
 /**
- * GraphQL Query to et the semantic-release issues for a repository.
+ * GraphQL Query to get the semantic-release issues for a repository.
  */
 const loadGetSRIssuesQuery = `#graphql
   query getSRIssues($owner: String!, $repo: String!, $filter: IssueFilters) {

package/lib/glob-assets.js

@@ -2,7 +2,7 @@ import { basename, resolve } from "node:path";
 
 import { isPlainObject, castArray, uniqWith, uniq } from "lodash-es";
 import dirGlob from "dir-glob";
-import { globby } from "globby";
+import { glob as tinyglobby } from "tinyglobby";
 import debugFactory from "debug";
 
 const debug = debugFactory("semantic-release:github");
@@ -27,7 +27,7 @@ export default async function globAssets({ cwd }, assets) {
             return [];
           }
 
-          const globbed = await globby(glob, {
+          const globbed = await tinyglobby(glob, {
             cwd,
             expandDirectories: false, // TODO Temporary workaround for https://github.com/mrmlnc/fast-glob/issues/47
             dot: true,

package/lib/publish.js

@@ -107,10 +107,11 @@ export default async function publish(pluginConfig, context, { Octokit }) {
   await Promise.all(
     globbedAssets.map(async (asset) => {
       const filePath = isPlainObject(asset) ? asset.path : asset;
+      const resolved = resolve(cwd, filePath);
       let file;
 
       try {
-        file = await stat(resolve(cwd, filePath));
+        file = await stat(resolved);
       } catch {
         logger.error(
           "The asset %s cannot be read, and will be ignored.",
@@ -122,7 +123,7 @@ export default async function publish(pluginConfig, context, { Octokit }) {
       if (!file || !file.isFile()) {
         logger.error(
           "The asset %s is not a file, and will be ignored.",
-          filePath,
+          resolved,
         );
         return;
       }
@@ -131,7 +132,7 @@ export default async function publish(pluginConfig, context, { Octokit }) {
       const upload = {
         method: "POST",
         url: uploadUrl,
-        data: await readFile(resolve(cwd, filePath)),
+        data: await readFile(resolved),
         name: fileName,
         headers: {
           "content-type": mime.getType(extname(fileName)) || "text/plain",

package/lib/success.js

@@ -265,15 +265,13 @@ export default async function success(pluginConfig, context, { Octokit }) {
 
   if (failComment === false || failTitle === false) {
     logger.log("Skip closing issue.");
-  } else {
-    const srIssues = await findSRIssues(
-      octokit,
-      logger,
-      failTitle,
-      labels,
-      owner,
-      repo,
+    logger.warn(
+      `DEPRECATION: 'false' for 'failComment' or 'failTitle' is deprecated and will be removed in a future major version. Use 'failCommentCondition' instead.`,
     );
+  } else if (failCommentCondition === false) {
+    logger.log("Skip closing issue.");
+  } else {
+    const srIssues = await findSRIssues(octokit, logger, labels, owner, repo);
 
     debug("found semantic-release issues: %O", srIssues);
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@semantic-release/github",
   "description": "semantic-release plugin to publish a GitHub release and comment on released Pull Requests/Issues",
-  "version": "12.0.0-beta.1",
+  "version": "12.0.0-beta.3",
   "type": "module",
   "author": "Pierre Vanduynslager (https://twitter.com/@pvdlg_)",
   "ava": {
@@ -30,27 +30,27 @@
     "aggregate-error": "^5.0.0",
     "debug": "^4.3.4",
     "dir-glob": "^3.0.1",
-    "globby": "^14.0.0",
     "http-proxy-agent": "^7.0.0",
     "https-proxy-agent": "^7.0.0",
     "issue-parser": "^7.0.0",
     "lodash-es": "^4.17.21",
     "mime": "^4.0.0",
     "p-filter": "^4.0.0",
+    "tinyglobby": "^0.2.14",
     "url-join": "^5.0.0"
   },
   "devDependencies": {
-    "ava": "6.4.0",
+    "ava": "6.4.1",
     "c8": "10.1.3",
-    "cpy": "11.1.0",
+    "cpy": "12.0.1",
     "cz-conventional-changelog": "3.3.0",
     "fetch-mock": "npm:@gr2m/fetch-mock@9.11.0-pull-request-644.1",
     "lockfile-lint": "4.14.1",
     "ls-engines": "0.9.3",
     "npm-run-all2": "8.0.4",
     "prettier": "3.6.2",
-    "publint": "0.3.12",
-    "semantic-release": "24.2.6",
+    "publint": "0.3.14",
+    "semantic-release": "24.2.9",
     "sinon": "21.0.0",
     "tempy": "3.1.0"
   },