@sema-agent/core 2.0.1 → 2.2.0

package/dist/core/runner/prepare-task.js

@@ -12,12 +12,16 @@ import { materializeMcpTools } from "../mcp.js";
 import { Type } from "typebox";
 import { brainToRuntime } from "../runtime.js";
 import { StoredSession, isSessionConflict, hasSessionFork } from "../session.js";
-import { createAgentTranscriptTool, createSendMessageTool, createSubagentWorktreeHelper, forkGovernanceDenial, AGENT_TRANSCRIPT_TOOL_NAME, SEND_MESSAGE_TOOL_NAME, SubagentRetainLedger } from "../../agents/subagent.js";
+import { createSubagentWorktreeHelper, forkGovernanceDenial } from "../../agents/subagent.js";
+import { createAgentTranscriptTool, AGENT_TRANSCRIPT_TOOL_NAME } from "../../agents/agent-transcript-tool.js";
+import { createSendMessageTool, SEND_MESSAGE_TOOL_NAME } from "../../agents/send-message-tool.js";
+import { SubagentRetainLedger } from "../../agents/retain-ledger.js";
 import { combinePolicies, createTranscriptIntegrityPolicy, createUnverifiableDeletePolicy, resolveAsk, toolPolicyNameSets } from "../tool-policy.js";
 import { ActiveSkillScope, createActiveSkillScopePolicy } from "./active-skill-scope.js";
 import { computeCallCap, createCallCapRef, softExecDeadlineMs, toolCutDeadlineMs, WALLTIME_STALL_CONNECT_MS, WALLTIME_STALL_FIRST_TOKEN_MS, WALLTIME_STALL_IDLE_MS } from "./call-cap.js";
 import { createCutKillRegistry } from "./cut-kill.js";
-import { CHANGED_FILES_MTIME_EPS_MS, renderAgentListingDelta } from "./turn-attachments.js";
+import { CHANGED_FILES_MTIME_EPS_MS, fenceMcpServerInstructions, renderAgentListingDelta } from "./turn-attachments.js";
+import { inlineUntrusted } from "../untrusted-text.js";
 import { emitTrace } from "../trace.js";
 import { createSessionRulePolicy } from "./session-rule-policy.js";
 import { cloneObserverInput, formatHookFeedback, runToolGate } from "../hooks.js";
@@ -27,7 +31,7 @@ import { reservedCollisions, reservedFor } from "../../brain/request-params.js";
 import { defineTool } from "../tools.js";
 import { canonicalToolName } from "../tool-name-aliases.js";
 import { pathToUri } from "../lsp-protocol.js";
-import { DEFAULT_TOOL_RESULT_THRESHOLD_CHARS, firstPartyOffloadPolicy, InMemoryToolResultStore, RunnerSharedToolResultStore, ScopedToolResultStore, isVolatileOffloadStore, OFFLOAD_TOOL_NAME, createReadToolResultTool, withToolResultOffload, } from "../tool-result-store.js";
+import { DEFAULT_TOOL_RESULT_THRESHOLD_CHARS, buildToolResultRef, firstPartyOffloadPolicy, InMemoryToolResultStore, RunnerSharedToolResultStore, ScopedToolResultStore, isVolatileOffloadStore, OFFLOAD_TOOL_NAME, createReadToolResultTool, withToolResultOffload, } from "../tool-result-store.js";
 import { OUTPUT_TOOL_NAME, REPORT_FINDINGS_TOOL_NAME, SKILL_CONTENT_MAX_CHARS, SKILL_TOOL_NAME, createOutputTool, createReportBlockedTool, createReportFindingsTool, createSkillTool, normalizeSkills } from "./synthetic-tools.js";
 import { compileOutputSchema } from "./strict-output-schema.js";
 import { TOOL_SEARCH_NAME, buildDeferredRegistry, classifyDeferred, extractDiscoveredToolNames, createPlaceholderTool, createToolSearchTool, } from "./tool-disclosure.js";
@@ -89,6 +93,9 @@ export function resolveModelPromptTraits(model, spec, internals) {
         fableMitigations: isFableFamilyModelId(model.id),
     };
 }
+function isDelegatedNonForkChild(internals) {
+    return internals?.isDelegatedChild === true && internals?.insideFork !== true;
+}
 export function batchContextAt(messages, currentId) {
     let batch = [];
     for (const m of messages) {
@@ -738,6 +745,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
             model: harnessRef.current?.getModel(),
             thinkingLevel: harnessRef.current?.getThinkingLevel(),
             principal: spec.principal,
+            oneShot: spec.oneShot,
             clientContext: spec.clientContext,
             excludeTools: toolFaceSnapshot.exclude,
             deferTools: toolFaceSnapshot.defer,
@@ -1160,6 +1168,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                 taskRegistry: defaultTaskRegistry,
                 taskOwner: hostTaskId,
                 taskScope,
+                oneShot: spec.oneShot,
                 ...(sessionId !== undefined ? { sessionId } : {}),
                 ...(internals?.onTaskNotification !== undefined ? { taskNotification: internals.onTaskNotification } : {}),
                 ...(internals?.detachHub !== undefined ? { detachHub: internals.detachHub } : {}),
@@ -1208,7 +1217,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
         if (backgroundTaskToolsActive || workflowToolsActive) {
             toolEffects.set("TaskOutput", "read");
             toolEffects.set("TaskStop", "write");
-            tools.push(firstPartyOffload(createTaskOutputTool({ registry: defaultTaskRegistry, owner: hostTaskId, scope: taskScope, sessionId, workflowStore: deps.workflowRunStore, agentStore: deps.backgroundAgentStore, notificationWired: internals?.onTaskNotification !== undefined, ...(callCapRef ? { deadlineMs: () => toolCutDeadlineMs(callCapRef, Date.now()) } : {}) })), firstPartyOffload(createTaskStopTool({ registry: defaultTaskRegistry, owner: hostTaskId, scope: taskScope, sessionId, workflowStore: deps.workflowRunStore, agentStore: deps.backgroundAgentStore })));
+            tools.push(firstPartyOffload(createTaskOutputTool({ registry: defaultTaskRegistry, owner: hostTaskId, scope: taskScope, sessionId, workflowStore: deps.workflowRunStore, agentStore: deps.backgroundAgentStore, notificationWired: internals?.onTaskNotification !== undefined, oneShot: spec.oneShot, ...(callCapRef ? { deadlineMs: () => toolCutDeadlineMs(callCapRef, Date.now()) } : {}) })), firstPartyOffload(createTaskStopTool({ registry: defaultTaskRegistry, owner: hostTaskId, scope: taskScope, sessionId, workflowStore: deps.workflowRunStore, agentStore: deps.backgroundAgentStore })));
             if (runnerSelf && !(spec.tools ?? []).some((t) => t.name === SEND_MESSAGE_TOOL_NAME)) {
                 const delegationForRevive = (spec.tools ?? []).find((t) => t.agentListing !== undefined);
                 const reviveSpawn = delegationForRevive !== undefined && deps.backgroundAgentStore !== undefined && deps.mailboxStore !== undefined
@@ -1362,8 +1371,16 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                     .catch(() => undefined);
             }
             : undefined;
-        const { memoryEngineSession, memoryBlock: memoryBlockFromEngine } = await prepareMemory({ spec, deps, sessionId, taskRootPath, memoryWriteGateRef });
+        const { memoryEngineSession, memoryBlock: memoryBlockFromEngine, seedFiles: memorySeedFiles } = await prepareMemory({ spec, deps, sessionId, taskRootPath, memoryWriteGateRef });
         let memoryBlock = memoryBlockFromEngine;
+        if (memorySeedFiles?.length && seedContextFiles) {
+            try {
+                await seedContextFiles(memorySeedFiles);
+            }
+            catch (err) {
+                deps.onError?.(err instanceof Error ? err : new Error(String(err)), { phase: "config", sessionId });
+            }
+        }
         let instructionSources;
         if (deps.loadProjectMemory) {
             let projectMemoryPhase = spec.sessionId ? "resume" : "fresh";
@@ -1393,7 +1410,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                 loaded = await Promise.resolve(deps.loadProjectMemory({
                     cwd: taskRootPath,
                     handsEnabled,
-                    isSubagent: internals?.parentTaskId !== undefined,
+                    isSubagent: isDelegatedNonForkChild(internals),
                     ...(internals?.agentName ? { agentName: internals.agentName } : {}),
                     sessionId,
                     phase: projectMemoryPhase,
@@ -1420,6 +1437,10 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                 memoryBlock = memoryBlock ? `${memoryBlock}\n\n${projectBlock}` : projectBlock;
             }
         }
+        const declaredSkillRank = new Map();
+        for (const s of spec.skills ?? [])
+            if (!declaredSkillRank.has(s.name))
+                declaredSkillRank.set(s.name, declaredSkillRank.size);
         const skillSpecs = normalizeSkills(spec.skills ?? []).filter((s) => {
             if (s.content.length <= SKILL_CONTENT_MAX_CHARS)
                 return true;
@@ -1445,6 +1466,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                     name: s.name,
                     description: s.description,
                     ...(s.files !== undefined ? { files: s.files.map((f) => ({ path: f.path })) } : {}),
+                    ...(declaredSkillRank.get(s.name) !== undefined ? { declaredRank: declaredSkillRank.get(s.name) } : {}),
                 })),
                 seedAnnounced: resume !== undefined || spec.sessionId !== undefined,
             }
@@ -1473,12 +1495,12 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
             awarenessEnabled: thinking !== undefined && ULTRA_REASONING_TIERS.has(thinking),
             worktreeIsolated: internals?.isolation === "worktree" && ownedEnv !== undefined,
             withinTaskCompactionEnabled: (spec.compaction?.enabled ?? true) && (spec.compaction?.withinTask ?? true),
-            isSubagent: internals?.isDelegatedChild === true && internals?.insideFork !== true,
+            isSubagent: isDelegatedNonForkChild(internals),
         };
         const userSystemPrompt = spec.systemPrompt ?? resolvedRole.systemPrompt ?? internals?.defaultSystemPrompt;
         const userAppendSystemPrompt = spec.appendSystemPrompt;
         const mcpInstructionsBlock = mcp.serverInstructions.length
-            ? `# MCP Server Instructions\n${mcp.serverInstructions.map((s) => `## ${s.server}\n${s.text}`).join("\n\n")}`
+            ? `# MCP Server Instructions\n${mcp.serverInstructions.map((s) => fenceMcpServerInstructions(s.server, s.text)).join("\n\n")}`
             : undefined;
         const userTz = spec.clientContext?.timeZone;
         const tzValid = userTz !== undefined && isValidTimeZone(userTz);
@@ -1760,7 +1782,13 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
         }
         const turnSnapshotRef = {};
         let harnessTools = tools;
+        const failedMcpServers = mcp.statuses
+            .filter((s) => s.status === "failed")
+            .map((s) => ({ name: inlineUntrusted(s.name, 160), ...(s.error !== undefined ? { error: inlineUntrusted(s.error, 240) } : {}) }));
         let toolsDeltaRef;
+        if (deferred.size > 0 || failedMcpServers.length > 0) {
+            toolsDeltaRef = { pending: [], pendingRemoved: [], pendingReadded: [], pendingFailed: failedMcpServers };
+        }
         const listingRideRef = {};
         if (deferred.size > 0) {
             if (deferred.has(TOOL_SEARCH_NAME) || tools.some((t) => t.name === TOOL_SEARCH_NAME)) {
@@ -1787,7 +1815,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                 return list;
             };
             const announcedTools = new Set(activeTools);
-            toolsDeltaRef = { pending: [] };
+            const withdrawnTools = new Set();
             const deltaRef = toolsDeltaRef;
             const rematerialize = async (active) => {
                 const list = buildToolList(active);
@@ -1795,10 +1823,23 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                 if (fpRef.current)
                     fpRef.current.tools = toolsToFingerprintInputs(list);
                 turnSnapshotRef.current?.refreshTools(toolsToFingerprintInputs(list));
+                const live = new Set(list.map((t) => t.name));
+                for (const n of [...announcedTools]) {
+                    if (!live.has(n)) {
+                        announcedTools.delete(n);
+                        withdrawnTools.add(n);
+                        deltaRef.pendingRemoved.push(n);
+                    }
+                }
                 for (const n of active) {
+                    if (!live.has(n))
+                        continue;
                     if (!announcedTools.has(n)) {
                         announcedTools.add(n);
-                        deltaRef.pending.push(n);
+                        if (withdrawnTools.delete(n))
+                            deltaRef.pendingReadded.push(n);
+                        else
+                            deltaRef.pending.push(n);
                     }
                 }
             };
@@ -2351,7 +2392,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
             : foldedPolicy;
         const hooks = spec.hooks ?? deps.hooks;
         const onAsk = spec.onAsk ?? deps.onAsk;
-        const handWriteTools = handsEnabled
+        const handWriteTools = handsEnabled && spec.handsReadOnly !== true
             ? Object.keys(HAND_TOOL_EFFECTS).filter((name) => {
                 const eff = HAND_TOOL_EFFECTS[name];
                 return eff === "write" || eff === "idempotent";
@@ -3035,7 +3076,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
                     ? {
                         offload: {
                             persist: (toolCallId, fullText) => {
-                                const ref = `tr_${sessionId}_${toolCallId}`;
+                                const ref = buildToolResultRef(sessionId, toolCallId);
                                 void offloadStore.put(ref, fullText);
                                 return ref;
                             },
@@ -3136,15 +3177,29 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
         const onCompactionApplied = handsEnabled && readFileStateForCheckpoint
             ? (attachedComplete, preserveReadState) => applyCompactionToReadFileState(readFileStateForCheckpoint, attachedComplete, preserveReadState)
             : undefined;
+        const changedFilesReadDenied = denyNarrowingPolicy === undefined
+            ? undefined
+            : async (path) => {
+                try {
+                    const d = await denyNarrowingPolicy.check({ toolName: "Read", args: { file_path: path }, toolCallId: "changed-files-visibility-probe" }, abortController.signal);
+                    return d.action === "deny";
+                }
+                catch {
+                    return false;
+                }
+            };
         const detectExternalChanges = handsEnabled && readFileStateForCheckpoint
             ? async (maxFiles) => {
                 const candidates = [...readFileStateForCheckpoint.entries()]
                     .filter(([, e]) => e.lastReadAt !== undefined)
+                    .filter(([, e]) => e.truncated !== true)
                     .sort((a, b) => (b[1].lastReadAt ?? 0) - (a[1].lastReadAt ?? 0))
                     .slice(0, Math.max(0, maxFiles));
                 const changed = [];
                 const evicted = [];
                 for (const [path, entry] of candidates) {
+                    if (changedFilesReadDenied !== undefined && (await changedFilesReadDenied(path)))
+                        continue;
                     try {
                         const info = await executionEnv.fileInfo(path, abortController.signal);
                         if (!info.ok) {
@@ -3218,7 +3273,7 @@ export async function prepareTask(spec, deps, sessions, resume, internals, runne
             : undefined;
         overheadState.promptChars = systemPrompt.length;
         const preparedHolder = {};
-        const buildPrepared = () => ({ harness, session, sessionId, taskRootPath, model, thinking, compModel, mcp: mcp, blockedRef, outputRef, abortController, conflictRef, blockedToolCalls, nestedStats, cwdRef: handsCwdRef, ...(worktreeSessionRef !== undefined ? { worktreeSessionRef } : {}), ...(workspaceStateSettle !== undefined ? { workspaceStateSettle } : {}), denyNarrowingPolicy, ...(basePolicyForResumeEdit !== undefined ? { basePolicyForResumeEdit } : {}), releaseSignal, cacheBreakDetector, cacheFingerprint, promptManifest, epochDeclaredSections, activeTools, ownedEnv, suspendRef, reviewRef, reviewRequestRef, suspendLoopRef, suspendForResource, ...(callCapRef ? { callCapRef } : {}), ...(cutKills ? { cutKills } : {}), ...(callCapRef ? { callIssuedAtRef } : {}), suspendForReview, resourceLedger: priorLedger, liveSpendRef, humanReviewRef, now, tools, toolEffects, promptOverheadTokens, readTaskFile, recentlyReadFiles, normalizeAttachmentPath, isDedupStubResult, ...(onCompactionApplied ? { onCompactionApplied } : {}), compactionReuseRef, trimPressureRef, ...(memoryEngineSession ? { memoryEngineSession } : {}), ...(subagentRetain ? { subagentRetain } : {}), ...(lspDiagnostics && nudgeLspOnEdit ? { lspDiagnostics: { registry: lspDiagnostics, nudge: nudgeLspOnEdit } } : {}), planModeRef, ...(dateChange ? { dateChange } : {}), ...(instructionSources ? { instructionSources } : {}), ...(detectExternalChanges ? { detectExternalChanges } : {}), ...(toolsDeltaRef ? { toolsDeltaRef } : {}), ...(agentListing ? { agentListing } : {}), ...(skillsListing ? { skillsListing } : {}), announcedListingsRef, listBackgroundTasks, ...(turnSnapshotRef.current !== undefined ? { turnSnapshot: turnSnapshotRef.current } : {}), ...(centerCompactionCandidate !== undefined ? { centerCompactionCandidate } : {}) });
+        const buildPrepared = () => ({ harness, session, sessionId, taskRootPath, model, thinking, compModel, mcp: mcp, blockedRef, outputRef, abortController, conflictRef, blockedToolCalls, nestedStats, cwdRef: handsCwdRef, ...(worktreeSessionRef !== undefined ? { worktreeSessionRef } : {}), ...(workspaceStateSettle !== undefined ? { workspaceStateSettle } : {}), denyNarrowingPolicy, ...(basePolicyForResumeEdit !== undefined ? { basePolicyForResumeEdit } : {}), releaseSignal, cacheBreakDetector, cacheFingerprint, promptManifest, epochDeclaredSections, activeTools, ...(deferred.size > 0 ? { deferredToolNames: deferred } : {}), ownedEnv, suspendRef, reviewRef, reviewRequestRef, suspendLoopRef, suspendForResource, ...(callCapRef ? { callCapRef } : {}), ...(cutKills ? { cutKills } : {}), ...(callCapRef ? { callIssuedAtRef } : {}), suspendForReview, resourceLedger: priorLedger, liveSpendRef, humanReviewRef, now, tools, toolEffects, promptOverheadTokens, readTaskFile, recentlyReadFiles, normalizeAttachmentPath, isDedupStubResult, ...(onCompactionApplied ? { onCompactionApplied } : {}), compactionReuseRef, trimPressureRef, ...(memoryEngineSession ? { memoryEngineSession } : {}), ...(subagentRetain ? { subagentRetain } : {}), ...(lspDiagnostics && nudgeLspOnEdit ? { lspDiagnostics: { registry: lspDiagnostics, nudge: nudgeLspOnEdit } } : {}), planModeRef, ...(dateChange ? { dateChange } : {}), ...(instructionSources ? { instructionSources } : {}), ...(detectExternalChanges ? { detectExternalChanges } : {}), ...(toolsDeltaRef ? { toolsDeltaRef } : {}), ...(agentListing ? { agentListing } : {}), ...(skillsListing ? { skillsListing } : {}), announcedListingsRef, listBackgroundTasks, ...(turnSnapshotRef.current !== undefined ? { turnSnapshot: turnSnapshotRef.current } : {}), ...(centerCompactionCandidate !== undefined ? { centerCompactionCandidate } : {}) });
         const prepared = buildPrepared();
         preparedHolder.current = prepared;
         return prepared;