@selvajs/cli 4.7.4-beta.1 → 4.8.0-beta.11

package/src/commands/migrate.js

@@ -1,48 +1,43 @@
-// Migrate deployment to current layout: rewrite package.json (drop legacy
-// provider packages), remove stale selva.config.js, update ecosystem.config.cjs.
+// Migrates a deployment to the current layout: rewrites package.json (drops legacy
+// provider packages), removes stale selva.config.js, updates ecosystem.config.cjs.
 // Idempotent; mirrors update's lifecycle (stop/mutate/start with rollback on failure).
 
-import {
-	existsSync,
-	readFileSync,
-	writeFileSync,
-	copyFileSync,
-	rmSync
-} from 'node:fs';
+import { existsSync, readFileSync, writeFileSync, copyFileSync, rmSync, renameSync } from 'node:fs';
 import { join } from 'node:path';
-import { spawnSync, execSync } from 'node:child_process';
+import { execSync } from 'node:child_process';
 import * as p from '@clack/prompts';
 import pc from 'picocolors';
 import { requireDeploymentDir, resolveDeploymentDir } from '../paths.js';
-
-const APP_NAME = 'selva-compute';
-
-// Packages we own. Everything in this set is rewritten wholesale by migrate;
-// anything outside it (operator's own deps) gets dropped, which is the
-// explicit design choice — operators with custom deps should fork the
-// template rather than hand-patch the deployment package.json.
-const SELVA_DEPS = new Set([
-	'@selvajs/cli',
-	'@selvajs/selva',
-	'@selvajs/runtime', // legacy — removed during migrate
-	'@selvajs/platform', // legacy — bundled into @selvajs/selva
-	'@selvajs/local-provider', // legacy — bundled into @selvajs/selva
-	'@selvajs/supabase-provider', // legacy — bundled into @selvajs/selva
-	'@selvajs/header-auth-provider', // legacy — bundled into @selvajs/selva
-	'@selvajs/create' // legacy CLI — removed during migrate
-]);
-
-const CANONICAL_SCRIPTS = {
-	start: 'selva start',
-	stop: 'selva stop',
-	restart: 'selva restart',
-	logs: 'selva logs',
-	doctor: 'selva doctor',
-	update: 'selva update'
-};
-
-export async function runMigrate() {
-	const dir = resolveDeploymentDir();
+import { renameEnvKeys, RENAMED_ENV_VARS } from '../env.js';
+import {
+	buildDeploymentPackageJson,
+	CANONICAL_FIELDS,
+	DEPENDENCIES,
+	LEGACY_DEPENDENCIES,
+	OVERRIDES
+} from '../deployment-package.js';
+import { APP_NAME, runPm2 } from './pm2.js';
+
+// Where migrate parks the old node_modules while npm installs the new one.
+// Left behind only if the process is killed mid-migration; `selva doctor`
+// flags a surviving stash as an interrupted migration.
+export const NODE_MODULES_STASH = 'node_modules.selva-migrate-bak';
+
+// `deps` are seams for tests: the rollback path destroys and restores a real
+// dependency tree, so it has to run against a real directory — but not against
+// a real npm or pm2 daemon.
+export async function runMigrate(
+	_argv,
+	{
+		dir: injectedDir,
+		// --prefer-online: npm can otherwise resolve a cached packument that
+		// predates the release being migrated to.
+		install = (cwd) => execSync('npm install --prefer-online', { cwd, stdio: 'pipe' }),
+		confirm = (message) => p.confirm({ message, initialValue: true }),
+		pm2 = runPm2
+	} = {}
+) {
+	const dir = injectedDir ?? resolveDeploymentDir();
 	requireDeploymentDir(dir);
 
 	p.intro(pc.bgCyan(pc.black(' selva migrate ')));
@@ -57,8 +52,6 @@ export async function runMigrate() {
 	const target = buildTargetPackageJson(before);
 	const pkgDiff = diffPackageJson(before, target);
 
-	// Side-files: selva.config.js (now unused) and ecosystem.config.cjs
-	// (must point at @selvajs/selva, not @selvajs/runtime).
 	const configPath = join(dir, 'selva.config.js');
 	const hasStaleConfig = existsSync(configPath);
 
@@ -66,9 +59,31 @@ export async function runMigrate() {
 	const ecoHasStaleRuntime =
 		existsSync(ecoPath) && readFileSync(ecoPath, 'utf8').includes('@selvajs/runtime');
 
+	// The server drops its read-old-name shim after one minor version, so
+	// rewriting now is what keeps a tuned value tuned instead of silently
+	// reverting to defaults later.
+	const envPath = join(dir, '.env');
+	const envBefore = existsSync(envPath) ? readFileSync(envPath, 'utf8') : null;
+	const envRename = envBefore
+		? renameEnvKeys(envBefore, RENAMED_ENV_VARS)
+		: { text: '', changes: [] };
+
 	const sideFileChanges = [];
-	if (hasStaleConfig) sideFileChanges.push(`${pc.red('-')} selva.config.js ${pc.dim('(no longer needed; providers are env-driven)')}`);
-	if (ecoHasStaleRuntime) sideFileChanges.push(`${pc.yellow('~')} ecosystem.config.cjs ${pc.dim('(rewrite: @selvajs/runtime → @selvajs/selva)')}`);
+	if (hasStaleConfig)
+		sideFileChanges.push(
+			`${pc.red('-')} selva.config.js ${pc.dim('(no longer needed; providers are env-driven)')}`
+		);
+	if (ecoHasStaleRuntime)
+		sideFileChanges.push(
+			`${pc.yellow('~')} ecosystem.config.cjs ${pc.dim('(rewrite: @selvajs/runtime → @selvajs/selva)')}`
+		);
+	for (const [oldName, newName, action] of envRename.changes) {
+		sideFileChanges.push(
+			action === 'dropped'
+				? `${pc.red('-')} .env ${pc.dim(`${oldName} (deprecated; ${newName} is already set)`)}`
+				: `${pc.yellow('~')} .env ${pc.dim(`${oldName} → ${newName}`)}`
+		);
+	}
 
 	if (pkgDiff.length === 0 && sideFileChanges.length === 0) {
 		p.outro(pc.green('Already on the current layout — nothing to migrate.'));
@@ -79,22 +94,25 @@ export async function runMigrate() {
 	for (const line of pkgDiff) console.log('  ' + line);
 	for (const line of sideFileChanges) console.log('  ' + line);
 
-	const confirmed = await p.confirm({
-		message: 'Apply these changes, reinstall, and restart?',
-		initialValue: true
-	});
+	const confirmed = await confirm('Apply these changes, reinstall, and restart?');
 	if (p.isCancel(confirmed) || !confirmed) {
 		p.cancel('Cancelled.');
 		return;
 	}
 
-	// Stop pm2 before npm rewrites (SvelteKit lazy-loads chunks; see update command).
-	const stopStatus = runPm2(dir, ['stop', APP_NAME], { inherit: false });
-	if (stopStatus !== 0) {
-		p.log.warn('pm2 stop did not succeed — selva-compute may not be running. Continuing.');
+	// Stop pm2 before npm rewrites — SvelteKit lazy-loads chunks, so a rewrite
+	// under a running server serves a broken page (same reason `update` stops first).
+	// A legacy deployment may predate the local-pm2 layout, so a missing binary
+	// isn't fatal here: there's nothing running for us to stop.
+	try {
+		const stopStatus = pm2(dir, ['stop', APP_NAME], { inherit: false });
+		if (stopStatus !== 0) {
+			p.log.warn('pm2 stop did not succeed — selva-compute may not be running. Continuing.');
+		}
+	} catch {
+		p.log.warn('No deployment-local pm2 to stop — continuing.');
 	}
 
-	// Back up for rollback on npm-install failure.
 	const bakPath = pkgPath + '.bak';
 	copyFileSync(pkgPath, bakPath);
 	writeFileSync(pkgPath, JSON.stringify(target, null, 2) + '\n', 'utf8');
@@ -106,7 +124,7 @@ export async function runMigrate() {
 
 	if (ecoHasStaleRuntime) {
 		copyFileSync(ecoPath, ecoPath + '.bak');
-		// Rewrite @selvajs/runtime → @selvajs/selva only (preserve customizations).
+		// Text substitution, not regeneration, so any operator customizations to the file survive.
 		const ecoContent = readFileSync(ecoPath, 'utf8').replace(
 			/@selvajs\/runtime/g,
 			'@selvajs/selva'
@@ -114,22 +132,33 @@ export async function runMigrate() {
 		writeFileSync(ecoPath, ecoContent, 'utf8');
 	}
 
-	// Clean install required (major version changes break legacy lockfile).
-	rmSync(join(dir, 'node_modules'), { recursive: true, force: true });
-	rmSync(join(dir, 'package-lock.json'), { force: true });
+	if (envRename.changes.length > 0) {
+		copyFileSync(envPath, envPath + '.bak');
+		writeFileSync(envPath, envRename.text, 'utf8');
+	}
+
+	// A legacy lockfile pins the old package set across a major bump, so this needs
+	// a clean install. But node_modules is also where pm2 lives, and rollback has to
+	// restart the app — deleting it outright would leave a failed migration with no
+	// way back up. Rename instead: atomic, keeps .bin symlinks intact, restorable
+	// until the install succeeds.
+	const nodeModules = join(dir, 'node_modules');
+	const nodeModulesBak = join(dir, NODE_MODULES_STASH);
+	const lockPath = join(dir, 'package-lock.json');
+
+	rmSync(nodeModulesBak, { recursive: true, force: true });
+	if (existsSync(nodeModules)) renameSync(nodeModules, nodeModulesBak);
+	const lockBak = existsSync(lockPath) ? readFileSync(lockPath, 'utf8') : null;
+	rmSync(lockPath, { force: true });
 
 	const s = p.spinner();
 	s.start('Installing new dependencies (this can take a minute)');
 	try {
-		// --prefer-online to bypass the stale-packument trap documented in
-		// docs/Hotfix-CLI-Runtime.md.
-		execSync('npm install --prefer-online', {
-			cwd: dir,
-			stdio: 'pipe'
-		});
+		install(dir);
 		s.stop('Dependencies installed');
+		rmSync(nodeModulesBak, { recursive: true, force: true });
 	} catch (err) {
-		s.stop(pc.red('npm install failed — rolling back package.json'));
+		s.stop(pc.red('npm install failed — rolling back'));
 		copyFileSync(bakPath, pkgPath);
 		if (hasStaleConfig && existsSync(configPath + '.bak')) {
 			copyFileSync(configPath + '.bak', configPath);
@@ -137,16 +166,46 @@ export async function runMigrate() {
 		if (ecoHasStaleRuntime && existsSync(ecoPath + '.bak')) {
 			copyFileSync(ecoPath + '.bak', ecoPath);
 		}
-		// Try to bring the process back up (best-effort; at least package.json is consistent).
-		runPm2(dir, ['start', APP_NAME, '--update-env'], { inherit: false });
+		if (envRename.changes.length > 0 && existsSync(envPath + '.bak')) {
+			copyFileSync(envPath + '.bak', envPath);
+		}
+
+		// A half-installed node_modules from the failed attempt is worse than the old
+		// one, so clear it before restoring the stash.
+		rmSync(nodeModules, { recursive: true, force: true });
+		if (existsSync(nodeModulesBak)) renameSync(nodeModulesBak, nodeModules);
+		if (lockBak !== null) writeFileSync(lockPath, lockBak, 'utf8');
+
+		restartAfterRollback(dir, pm2);
 		p.outro(pc.red(`Migration aborted: ${err.message ?? err}`));
 		process.exit(1);
 	}
 
-	const status = runPm2(dir, ['start', APP_NAME, '--update-env'], { inherit: false });
+	// Migration itself already succeeded at this point, so a failed pm2 start is reported
+	// but doesn't exit non-zero or trigger rollback — the on-disk state is fine, only the
+	// running process isn't. Contrast restartAfterRollback, which does exit 1: that path
+	// runs after a rollback, where a failed restart leaves nothing serving traffic at all.
+	let status;
+	try {
+		status = pm2(dir, ['start', APP_NAME, '--update-env'], { inherit: false });
+	} catch (err) {
+		status = 1;
+		p.log.error(`Could not invoke pm2: ${err instanceof Error ? err.message : err}`);
+	}
+	// A pin change means the just-installed pm2 CLI and the still-running
+	// daemon are now different versions. That's the repairable skew direction
+	// (daemon older), but it stays skewed until the operator acts — say so
+	// here, once, instead of letting doctor nag forever. Deliberately NOT
+	// automated: `pm2 update` recycles the daemon, and doing that unattended
+	// inside a migration converts a mid-flight failure into an outage (see
+	// plans/fixes/host-prerequisites-and-pm2-audit.md).
+	const pm2Notice = buildPm2UpgradeNotice(before.dependencies?.pm2, target.dependencies.pm2);
+	if (pm2Notice) p.log.warn(pm2Notice);
+
 	const backupHints = ['package.json.bak'];
 	if (hasStaleConfig) backupHints.push('selva.config.js.bak');
 	if (ecoHasStaleRuntime) backupHints.push('ecosystem.config.cjs.bak');
+	if (envRename.changes.length > 0) backupHints.push('.env.bak');
 
 	if (status === 0) {
 		p.outro(
@@ -161,23 +220,34 @@ export async function runMigrate() {
 	}
 }
 
-// Build target package.json with canonical dependencies (wholesale replace).
-// Drops non-canonical @selvajs/* and operator's own deps (by design).
-function buildTargetPackageJson(current) {
-	const deps = {
-		'@selvajs/cli': 'latest',
-		'@selvajs/selva': 'latest',
-		pm2: '^5.4.0'
-	};
+// Never throws: the migration is already aborting, and an exception here would
+// replace the rollback's diagnosis with a stack trace. A failure to restart is
+// the operator's problem to act on, so it gets logged, not swallowed.
+function restartAfterRollback(dir, pm2 = runPm2) {
+	try {
+		const status = pm2(dir, ['start', APP_NAME, '--update-env'], { inherit: false });
+		if (status === 0) {
+			p.log.success(`Rolled back and restarted ${APP_NAME}.`);
+			return;
+		}
+		p.log.error(
+			`Rolled back, but \`pm2 start\` exited ${status}. The app may be down — ` +
+				`check \`pm2 logs ${APP_NAME}\` and start it with \`selva start\`.`
+		);
+	} catch (err) {
+		p.log.error(
+			`Rolled back, but pm2 could not be invoked (${err instanceof Error ? err.message : err}). ` +
+				`The app is likely down — run \`npm install\` then \`selva start\`.`
+		);
+	}
+}
 
-	return {
+function buildTargetPackageJson(current) {
+	return buildDeploymentPackageJson({
 		name: current.name ?? 'selva-deployment',
 		version: current.version ?? '0.1.0',
-		private: true,
-		type: 'module',
-		scripts: { ...CANONICAL_SCRIPTS },
-		dependencies: deps
-	};
+		engines: current.engines
+	});
 }
 
 // Format package.json diff for confirmation prompt (concise, not full diff).
@@ -196,6 +266,19 @@ function diffPackageJson(before, after) {
 		else if (a !== b) lines.push(`${pc.yellow('~')} ${name} ${pc.dim(a + ' → ' + b)}`);
 	}
 
+	// Without this section, an overrides-only change reads as "already on the
+	// current layout" and the security shim never reaches existing deployments.
+	const beforeOverrides = before.overrides ?? {};
+	const afterOverrides = after.overrides ?? {};
+	const allOverrides = new Set([...Object.keys(beforeOverrides), ...Object.keys(afterOverrides)]);
+	for (const name of [...allOverrides].sort()) {
+		const a = beforeOverrides[name];
+		const b = afterOverrides[name];
+		if (a && !b) lines.push(`${pc.red('-')} overrides.${name} ${pc.dim(a)}`);
+		else if (!a && b) lines.push(`${pc.green('+')} overrides.${name} ${pc.dim(b)}`);
+		else if (a !== b) lines.push(`${pc.yellow('~')} overrides.${name} ${pc.dim(a + ' → ' + b)}`);
+	}
+
 	const beforeScripts = before.scripts ?? {};
 	const afterScripts = after.scripts ?? {};
 	const allScripts = new Set([...Object.keys(beforeScripts), ...Object.keys(afterScripts)]);
@@ -209,38 +292,53 @@ function diffPackageJson(before, after) {
 		}
 	}
 
+	// Anything outside the canonical set is discarded by the rewrite — show it here
+	// too, or the operator confirms a change (e.g. losing devDependencies) they
+	// never saw.
+	for (const key of Object.keys(before).sort()) {
+		if (CANONICAL_FIELDS.has(key)) continue;
+		lines.push(`${pc.red('-')} ${key} ${pc.dim(summarize(before[key]))}`);
+	}
+
 	return lines;
 }
 
-// Local pm2 runner (avoid circular dep; duplication is small).
-function runPm2(dir, args, { inherit = true } = {}) {
-	const local = join(dir, 'node_modules', '.bin', process.platform === 'win32' ? 'pm2.cmd' : 'pm2');
-	const bin = existsSync(local) ? local : 'pm2';
-	const result = spawnSync(bin, args, {
-		cwd: dir,
-		stdio: inherit ? 'inherit' : 'pipe',
-		shell: process.platform === 'win32'
-	});
-	if (result.error) return 1;
-	return result.status ?? 0;
+// One-line preview of a dropped field, enough to recognise what is being lost.
+function summarize(value) {
+	if (value === null || typeof value !== 'object') return String(value);
+	const keys = Object.keys(value);
+	if (Array.isArray(value)) return `[${keys.length} item${keys.length === 1 ? '' : 's'}]`;
+	return keys.length ? `{${keys.join(', ')}}` : '{}';
 }
 
 // Exported for `selva doctor` to check layout drift without duplication.
 export function detectDrift(pkgJson, dir) {
 	const deps = pkgJson?.dependencies ?? {};
 	const reasons = [];
-	if (deps['@selvajs/runtime']) reasons.push('@selvajs/runtime is the old runtime package');
-	if (deps['@selvajs/create']) reasons.push('@selvajs/create is the old CLI package');
-	if (deps['@selvajs/platform']) reasons.push('@selvajs/platform is now bundled into @selvajs/selva');
-	if (deps['@selvajs/local-provider'])
-		reasons.push('@selvajs/local-provider is now bundled into @selvajs/selva');
-	if (deps['@selvajs/supabase-provider'])
-		reasons.push('@selvajs/supabase-provider is now bundled into @selvajs/selva');
-	if (deps['@selvajs/header-auth-provider'])
-		reasons.push('@selvajs/header-auth-provider is now bundled into @selvajs/selva');
-	if (!deps['@selvajs/selva']) reasons.push('@selvajs/selva is missing');
-	if (!deps['@selvajs/cli']) reasons.push('@selvajs/cli is missing');
-	if (!deps['pm2']) reasons.push('pm2 is not in dependencies');
+
+	for (const [name, why] of Object.entries(LEGACY_DEPENDENCIES)) {
+		if (deps[name]) reasons.push(`${name} is ${why}`);
+	}
+	for (const name of Object.keys(DEPENDENCIES)) {
+		if (!deps[name]) reasons.push(`${name} is missing`);
+	}
+
+	// pm2 is the one dependency pinned exactly, so a version difference is drift
+	// rather than an operator preference. Presence alone was checked above and
+	// isn't enough: a deployment scaffolded against an older CLI keeps its old
+	// pm2 forever, which is how the pin reached a two-major gap unnoticed.
+	if (deps.pm2 && deps.pm2 !== DEPENDENCIES.pm2) {
+		reasons.push(`pm2 is pinned to ${deps.pm2} (current scaffold pins ${DEPENDENCIES.pm2})`);
+	}
+
+	// Overrides are security shims for vulnerable transitive deps — a
+	// deployment without them installs the vulnerable version on its next
+	// `npm install`, silently.
+	for (const [name, version] of Object.entries(OVERRIDES)) {
+		if (pkgJson?.overrides?.[name] !== version) {
+			reasons.push(`overrides.${name} is missing or outdated (security shim, expects ${version})`);
+		}
+	}
 
 	if (dir) {
 		const configPath = join(dir, 'selva.config.js');
@@ -251,10 +349,32 @@ export function detectDrift(pkgJson, dir) {
 		if (existsSync(ecoPath) && readFileSync(ecoPath, 'utf8').includes('@selvajs/runtime')) {
 			reasons.push('ecosystem.config.cjs still references @selvajs/runtime');
 		}
+		const envPath = join(dir, '.env');
+		if (existsSync(envPath)) {
+			const { changes } = renameEnvKeys(readFileSync(envPath, 'utf8'), RENAMED_ENV_VARS);
+			for (const [oldName, newName] of changes) {
+				reasons.push(`.env still uses ${oldName} (renamed to ${newName})`);
+			}
+		}
 	}
 
 	return reasons;
 }
 
-// Re-exported for tests to verify without running migrate.
-export { buildTargetPackageJson, SELVA_DEPS };
+// Null when the pin didn't change. Exported for its test — the wording is the
+// operator's only pointer to finish the upgrade.
+export function buildPm2UpgradeNotice(beforeVersion, afterVersion) {
+	if (!beforeVersion || beforeVersion === afterVersion) return null;
+	return [
+		`pm2 was upgraded ${beforeVersion} → ${afterVersion}, but the running pm2 daemon is`,
+		`still the old version. Finish the upgrade (brief restart of managed processes):`,
+		``,
+		`  npx pm2 update`,
+		`  npx pm2 save`,
+		``,
+		`If doctor reports a pm2 outside this deployment (global or apt install), follow`,
+		`the full procedure in the docs instead: self-hosting → deployment → prerequisites.`
+	].join('\n');
+}
+
+export { buildTargetPackageJson, diffPackageJson };

package/src/commands/pm2.js

@@ -1,6 +1,6 @@
-// Thin wrappers around PM2 commands: always pass --update-env (ignore edits),
-// resolve to deployment-local pm2 (avoid daemon version skew with global install),
-// and resync daemon before state changes.
+// Thin wrappers around PM2 commands: resolve to the deployment-local pm2, resync
+// the daemon before state changes, and pass --update-env on restart so edits to
+// .env actually take effect.
 
 import { existsSync, readFileSync } from 'node:fs';
 import { join } from 'node:path';
@@ -9,10 +9,9 @@ import * as p from '@clack/prompts';
 import pc from 'picocolors';
 import { requireDeploymentDir, resolveDeploymentDir } from '../paths.js';
 
-const APP_NAME = 'selva-compute';
+export const APP_NAME = 'selva-compute';
 
-// Resolve to deployment-local pm2 (no global fallback; prevents version skew).
-function pm2Bin(dir) {
+export function pm2Bin(dir) {
 	const local = join(dir, 'node_modules', '.bin', process.platform === 'win32' ? 'pm2.cmd' : 'pm2');
 	if (!existsSync(local)) {
 		throw new Error(
@@ -25,7 +24,32 @@ function pm2Bin(dir) {
 	return local;
 }
 
-// Check for daemon/CLI version mismatch; run `pm2 update` if stale.
+// Parses the two versions pm2 prints alongside its out-of-date warning:
+//   In memory PM2 version: 6.0.14
+//   Local PM2 version: 5.4.3
+// Returns nulls when the shape doesn't match, so callers fall back to resyncing.
+export function parsePm2Skew(output) {
+	// eslint-disable-next-line no-control-regex -- pm2 colourises via chalk on a TTY
+	const clean = output.replace(/\[[0-9;]*m/g, '');
+	const daemon = /In memory PM2 version:\s*v?(\d+\.\d+\.\d+)/i.exec(clean);
+	const local = /Local PM2 version:\s*v?(\d+\.\d+\.\d+)/i.exec(clean);
+	return { daemon: daemon?.[1] ?? null, local: local?.[1] ?? null };
+}
+
+// True when the running daemon is newer than the deployment-local pm2 — i.e. a
+// foreign global pm2 owns it. `pm2 update` can't fix that direction: it would
+// downgrade the daemon and hand it a dump from a newer version, dropping the
+// process table so selva-compute never gets re-registered.
+export function daemonOutranksCli(daemon, local) {
+	if (!daemon || !local) return false;
+	const [a, b] = [daemon.split('.').map(Number), local.split('.').map(Number)];
+	for (let i = 0; i < 3; i++) {
+		if (a[i] > b[i]) return true;
+		if (a[i] < b[i]) return false;
+	}
+	return false;
+}
+
 function ensurePm2InSync(dir) {
 	const bin = pm2Bin(dir);
 	const probe = spawnSync(bin, ['ping'], {
@@ -36,6 +60,16 @@ function ensurePm2InSync(dir) {
 	const output = (probe.stdout ?? '') + (probe.stderr ?? '');
 	if (!/out-of-date/i.test(output)) return;
 
+	const { daemon, local } = parsePm2Skew(output);
+	if (daemonOutranksCli(daemon, local)) {
+		throw new Error(
+			`The running PM2 daemon (v${daemon}) is NEWER than this deployment's pm2 (v${local}), ` +
+				`so a global pm2 owns it. Running \`pm2 update\` would downgrade the daemon and drop ` +
+				`its process table, leaving ${APP_NAME} unregistered. Resolve the conflict first: ` +
+				`\`which -a pm2\`, \`pm2 -v\`, \`pm2 ping\`.`
+		);
+	}
+
 	p.log.warn(
 		'PM2 in-memory daemon is a different version than the deployment-local pm2 — ' +
 			'running `pm2 update` to resync (this briefly restarts managed processes).'
@@ -53,8 +87,10 @@ function ensurePm2InSync(dir) {
 	}
 }
 
-function runPm2(dir, args, { inherit = true } = {}) {
-	const bin = pm2Bin(dir);
+// `bin` lets a caller pass an already-resolved pm2 path instead of resolving
+// fresh from `dir` — needed when node_modules won't exist at call time (e.g.
+// `selva migrate` wipes it mid-flight and passes the binary it stashed first).
+export function runPm2(dir, args, { inherit = true, bin = pm2Bin(dir) } = {}) {
 	const result = spawnSync(bin, args, {
 		cwd: dir,
 		stdio: inherit ? 'inherit' : 'pipe',