@selesai/code 0.9.11 → 0.9.13

package/dist/extensions/pi-subagents/test/unit/workflow-receipt.test.ts

@@ -0,0 +1,113 @@
+import assert from "node:assert/strict";
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import { afterEach, describe, it } from "node:test";
+import { buildWorkflowReceipt, readWorkflowReceipt, resolveWorkflowReceiptResume, workflowReceiptPath, writeWorkflowReceipt } from "../../src/workflows/workflow-receipt.ts";
+import type { WorkflowScriptChildResult } from "../../src/workflows/scripted-workflow.ts";
+
+const roots: string[] = [];
+
+afterEach(() => {
+	for (const root of roots.splice(0)) fs.rmSync(root, { recursive: true, force: true });
+});
+
+function tempRoot(): string {
+	const root = fs.mkdtempSync(path.join(os.tmpdir(), "pi-workflow-receipt-"));
+	roots.push(root);
+	return root;
+}
+
+function child(key: string, overrides: Partial<WorkflowScriptChildResult> = {}): WorkflowScriptChildResult {
+	return {
+		key,
+		ok: true,
+		agent: "reviewer",
+		runId: `run-${key}`,
+		output: "x".repeat(100_000),
+		structuredOutput: { report: "x".repeat(100_000) },
+		artifactPaths: [`/tmp/${key}.md`],
+		requestedContext: "fresh",
+		resolvedContext: "fresh",
+		outputReference: `/tmp/${key}.md`,
+		resumability: { state: "resumable" },
+		continuation: { runIds: [`run-${key}`] },
+		...overrides,
+	};
+}
+
+describe("workflow receipts", () => {
+	it("builds one metadata-only entry per workflow child", () => {
+		const children = Array.from({ length: 1_000 }, (_, index) => child(`child-${index}`));
+		const receipt = buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "complete", children, createdAt: 10 });
+
+		assert.equal(Object.keys(receipt.entries).length, children.length);
+		assert.deepEqual(receipt.entries["child-0"], {
+			key: "child-0",
+			agent: "reviewer",
+			requestedContext: "fresh",
+			resolvedContext: "fresh",
+			latestRunId: "run-child-0",
+			resumability: { state: "resumable" },
+			outputReference: "/tmp/child-0.md",
+			continuation: { runIds: ["run-child-0"] },
+		});
+		const serialized = JSON.stringify(receipt);
+		assert.doesNotMatch(serialized, /structuredOutput|artifactPaths|"output"/);
+		assert.ok(serialized.length < 400_000, `receipt metadata unexpectedly large: ${serialized.length}`);
+	});
+
+	it("writes and resolves one exact terminal receipt", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-1");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		const receipt = buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "complete", children: [child("advisor")] });
+		assert.equal(writeWorkflowReceipt(asyncDir, receipt), workflowReceiptPath(asyncRoot, "workflow-1"));
+		assert.deepEqual(readWorkflowReceipt(asyncRoot, "workflow-1"), receipt);
+		let validations = 0;
+		const runId = resolveWorkflowReceiptResume({
+			reference: { workflowRunId: "workflow-1", key: "advisor", latest: true },
+			asyncDirRoot: asyncRoot,
+			assertResumable(value) {
+				validations += 1;
+				assert.equal(value, "run-advisor");
+			},
+		});
+		assert.equal(runId, "run-advisor");
+		assert.equal(validations, 1);
+	});
+
+	it("fails closed for missing, non-resumable, and stale receipt references", () => {
+		const asyncRoot = tempRoot();
+		assert.throws(
+			() => resolveWorkflowReceiptResume({ reference: { workflowRunId: "missing", key: "advisor", latest: true }, asyncDirRoot: asyncRoot }),
+			/not found/,
+		);
+
+		const asyncDir = path.join(asyncRoot, "workflow-1");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		writeWorkflowReceipt(asyncDir, buildWorkflowReceipt({
+			workflowRunId: "workflow-1",
+			state: "failed",
+			children: [child("advisor", { resumability: { state: "not-resumable", reason: "session removed" } })],
+		}));
+		assert.throws(
+			() => resolveWorkflowReceiptResume({ reference: { workflowRunId: "workflow-1", key: "missing", latest: true }, asyncDirRoot: asyncRoot }),
+			/no child key 'missing'/,
+		);
+		assert.throws(
+			() => resolveWorkflowReceiptResume({ reference: { workflowRunId: "workflow-1", key: "advisor", latest: true }, asyncDirRoot: asyncRoot }),
+			/not resumable: session removed/,
+		);
+
+		const receiptPath = workflowReceiptPath(asyncRoot, "workflow-1");
+		const stale = JSON.parse(fs.readFileSync(receiptPath, "utf-8")) as Record<string, unknown>;
+		((stale.entries as Record<string, Record<string, unknown>>).advisor!).latestRunId = "other-run";
+		fs.writeFileSync(receiptPath, JSON.stringify(stale));
+		assert.throws(() => readWorkflowReceipt(asyncRoot, "workflow-1"), /stale: latestRunId/);
+		assert.throws(
+			() => resolveWorkflowReceiptResume({ reference: { workflowRunId: "workflow-1", key: "advisor", latest: false } as never, asyncDirRoot: asyncRoot }),
+			/requires latest: true/,
+		);
+	});
+});

package/dist/extensions/pi-subagents/test/unit/worktree.test.ts

@@ -125,9 +125,9 @@ describe("worktree", () => {
 		}
 	});
 
-	it("rejects worktree base directories inside Selesai extensions", () => {
-		const repoDir = createRepo("selesai-worktree-extension-dir-");
-		const tempHome = fs.mkdtempSync(path.join(os.tmpdir(), "selesai-worktree-home-"));
+	it("rejects worktree base directories inside Pi extensions", () => {
+		const repoDir = createRepo("pi-worktree-extension-dir-");
+		const tempHome = fs.mkdtempSync(path.join(os.tmpdir(), "pi-worktree-home-"));
 		const previousAgentDir = process.env.SELESAI_CODING_AGENT_DIR;
 		const previousHome = process.env.HOME;
 		const previousUserProfile = process.env.USERPROFILE;
@@ -156,9 +156,9 @@ describe("worktree", () => {
 		}
 	});
 
-	it("rejects symlinked worktree base directories inside Selesai extensions", () => {
-		const repoDir = createRepo("selesai-worktree-extension-symlink-");
-		const tempHome = fs.mkdtempSync(path.join(os.tmpdir(), "selesai-worktree-home-"));
+	it("rejects symlinked worktree base directories inside Pi extensions", () => {
+		const repoDir = createRepo("pi-worktree-extension-symlink-");
+		const tempHome = fs.mkdtempSync(path.join(os.tmpdir(), "pi-worktree-home-"));
 		const previousAgentDir = process.env.SELESAI_CODING_AGENT_DIR;
 		const previousHome = process.env.HOME;
 		const previousUserProfile = process.env.USERPROFILE;

package/dist/extensions/ponytail/index.js

@@ -3,9 +3,10 @@ import { createRequire } from "node:module";
 const require = createRequire(import.meta.url);
 const {
   DEFAULT_MODE,
+  RUNTIME_MODES,
   getDefaultMode,
+  getQuietStartup,
   normalizeMode,
-  normalizeConfigMode,
   normalizePersistedMode,
   isDeactivationCommand,
   writeDefaultMode,
@@ -14,11 +15,12 @@ const { getPonytailInstructions, filterSkillBodyForMode } = require("./ponytail-
 
 export { filterSkillBodyForMode };
 export const readDefaultMode = getDefaultMode;
+export const readQuietStartup = getQuietStartup;
+
+const RUNTIME_MODE_LIST = RUNTIME_MODES.join("|");
+const PONYTAIL_COMMAND_DESCRIPTION = `Set mode: ${RUNTIME_MODE_LIST}. Commands: status, default <mode>`;
 
 export function resolveSessionMode(entries, fallbackMode = DEFAULT_MODE) {
-  // Unreachable: normalizePersistedMode always returns a valid mode or null,
-  // and the caller passes a valid default.
-  /* v8 ignore next 1 */
   const fallback = normalizePersistedMode(fallbackMode) || DEFAULT_MODE;
   if (!Array.isArray(entries)) return fallback;
 
@@ -46,7 +48,8 @@ export function parsePonytailCommand(text, defaultMode = DEFAULT_MODE) {
   if (primary === "status") return { type: "status" };
 
   if (primary === "default") {
-    const mode = normalizeConfigMode(secondary);
+    // ponytail: a default must be a runtime level; review is session-only (#377).
+    const mode = normalizeMode(secondary);
     return mode ? { type: "set-default", mode } : { type: "invalid", reason: "invalid-default-mode" };
   }
 
@@ -59,12 +62,8 @@ export { writeDefaultMode };
 export default function ponytailExtension(pi) {
   let currentMode = DEFAULT_MODE;
   let configuredDefaultMode = getDefaultMode();
-
   const setMode = (mode, ctx) => {
     const normalized = normalizePersistedMode(mode);
-    // Unreachable: setMode is only called with validated modes from the
-    // command handler and the deactivation input handler.
-    /* v8 ignore next 1 */
     if (!normalized) return;
 
     currentMode = normalized;
@@ -74,8 +73,6 @@ export default function ponytailExtension(pi) {
 
   const sendAlias = (skillName, args, ctx) => {
     const normalized = String(args || "").trim();
-    // Unreachable: the alias command handlers always pass empty args.
-    /* v8 ignore next 1 */
     const message = normalized ? `${skillName} ${normalized}` : skillName;
 
     if (ctx?.isIdle?.() === false) {
@@ -88,7 +85,7 @@ export default function ponytailExtension(pi) {
   };
 
   pi.registerCommand("ponytail", {
-    description: "Set or report Ponytail mode",
+    description: PONYTAIL_COMMAND_DESCRIPTION,
     handler: async (args, ctx) => {
       const parsed = parsePonytailCommand(args, configuredDefaultMode);
 
@@ -98,16 +95,17 @@ export default function ponytailExtension(pi) {
       }
 
       if (parsed.type === "set-default") {
-        const written = writeDefaultMode(parsed.mode);
-        // Unreachable: parsePonytailCommand only returns set-default for
-        // valid config modes, so writeDefaultMode always succeeds.
-        /* v8 ignore next 1 */
-        if (written) {
-          configuredDefaultMode = getDefaultMode();
-          const message = configuredDefaultMode === written
-            ? `Default Ponytail mode set to ${written}.`
-            : `Saved default ${written}, but env override keeps default at ${configuredDefaultMode}.`;
-          ctx?.ui?.notify?.(message, "info");
+        try {
+          const written = writeDefaultMode(parsed.mode);
+          if (written) {
+            configuredDefaultMode = getDefaultMode();
+            const message = configuredDefaultMode === written
+              ? `Default Ponytail mode set to ${written}.`
+              : `Saved default ${written}, but env override keeps default at ${configuredDefaultMode}.`;
+            ctx?.ui?.notify?.(message, "info");
+          }
+        } catch (e) {
+          ctx?.ui?.notify?.(`Failed to save default mode: ${e.message}`, "error");
         }
         return;
       }
@@ -159,12 +157,20 @@ export default function ponytailExtension(pi) {
     const entries = ctx?.sessionManager?.getBranch?.() || ctx?.sessionManager?.getEntries?.() || [];
     configuredDefaultMode = getDefaultMode();
     currentMode = resolveSessionMode(entries, configuredDefaultMode);
-    ctx?.ui?.setStatus?.("ponytail", undefined);
-    ctx?.ui?.notify?.(`Ponytail loaded: ${currentMode}`, "info");
+    if (!getQuietStartup()) {
+      ctx?.ui?.notify?.(`Ponytail loaded: ${currentMode}`, "info");
+    }
   });
 
+
   pi.on("before_agent_start", async (event) => {
     if (!currentMode || currentMode === "off") return;
-    return { systemPrompt: `${event.systemPrompt}\n\n${getPonytailInstructions(currentMode, { compact: true })}` };
+    // Guard a null/undefined event or a missing systemPrompt: don't crash, and
+    // don't prepend the literal string "undefined" to the prompt (#439, #440).
+    const base = event?.systemPrompt ? `${event.systemPrompt}\n\n` : "";
+    // ponytail: full keeps the detailed skill; alternate modes use the compact
+    // ruleset to avoid repeating the same system prompt on every request.
+    const compact = currentMode !== "full";
+    return { systemPrompt: `${base}${getPonytailInstructions(currentMode, { compact })}` };
   });
 }

package/dist/extensions/ponytail/ponytail-config.cjs

@@ -57,8 +57,6 @@ function getConfigDir() {
   }
   if (process.platform === 'win32') {
     return path.join(
-      // Unreachable: APPDATA is always set on Windows.
-      /* v8 ignore next 1 */
       process.env.APPDATA || path.join(os.homedir(), 'AppData', 'Roaming'),
       'ponytail'
     );
@@ -78,15 +76,19 @@ function getClaudeDir() {
 function getDefaultMode() {
   // 1. Environment variable (highest priority)
   const envMode = process.env.PONYTAIL_DEFAULT_MODE;
-  if (envMode && VALID_MODES.includes(envMode.toLowerCase())) {
+  // ponytail: a default must be a runtime level (off/lite/full/ultra); review is
+  // a session-only mode, never a valid default (#377). Validate against
+  // RUNTIME_MODES so a stray env var or config can't make review the default.
+  if (envMode && RUNTIME_MODES.includes(envMode.toLowerCase())) {
     return envMode.toLowerCase();
   }
 
   // 2. Config file
   try {
     const configPath = getConfigPath();
-    const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    if (config.defaultMode && VALID_MODES.includes(config.defaultMode.toLowerCase())) {
+    // Strip UTF-8 BOM (common on Windows-saved files) so JSON.parse doesn't choke
+    const config = JSON.parse(fs.readFileSync(configPath, 'utf8').replace(/^\uFEFF/, ''));
+    if (config.defaultMode && RUNTIME_MODES.includes(config.defaultMode.toLowerCase())) {
       return config.defaultMode.toLowerCase();
     }
   } catch (e) {
@@ -97,13 +99,37 @@ function getDefaultMode() {
   return DEFAULT_MODE;
 }
 
+// Silence the pi "Ponytail loaded" startup toast while keeping ponytail active.
+// PONYTAIL_QUIET_STARTUP=1 (or any truthy value; 0/false/empty mean "show it")
+// takes precedence, else config.quietStartup === true.
+function getQuietStartup() {
+  const env = process.env.PONYTAIL_QUIET_STARTUP;
+  if (env !== undefined) {
+    const v = env.trim().toLowerCase();
+    return v !== '' && v !== '0' && v !== 'false' && v !== 'no';
+  }
+  try {
+    const config = JSON.parse(fs.readFileSync(getConfigPath(), 'utf8').replace(/^\uFEFF/, ''));
+    return config.quietStartup === true;
+  } catch (_) {
+    return false;
+  }
+}
+
 function writeDefaultMode(mode) {
-  const normalized = normalizeConfigMode(mode);
+  // ponytail: only a runtime level can be a default; review is session-only (#377).
+  const normalized = normalizeMode(mode);
   if (!normalized) return null;
 
   const configPath = getConfigPath();
   fs.mkdirSync(path.dirname(configPath), { recursive: true });
-  fs.writeFileSync(configPath, JSON.stringify({ defaultMode: normalized }, null, 2), 'utf8');
+  let config = {};
+  try {
+    config = JSON.parse(fs.readFileSync(configPath, 'utf8').replace(/^\uFEFF/, ''));
+    if (!config || typeof config !== 'object' || Array.isArray(config)) config = {};
+  } catch (_) {}
+  config.defaultMode = normalized;
+  fs.writeFileSync(configPath, JSON.stringify(config, null, 2), 'utf8');
   return normalized;
 }
 
@@ -115,6 +141,7 @@ module.exports = {
   getConfigDir,
   getConfigPath,
   getClaudeDir,
+  getQuietStartup,
   isShellSafe,
   normalizeMode,
   normalizeConfigMode,

package/dist/extensions/ponytail/ponytail-instructions.cjs

@@ -6,17 +6,14 @@ const path = require('path');
 const { DEFAULT_MODE, normalizeMode, normalizePersistedMode } = require('./ponytail-config.cjs');
 
 const INDEPENDENT_MODES = new Set(['review']);
-const SKILL_PATH = path.join(__dirname, '..', '..', 'skills', 'ponytail', 'SKILL.md');
 const COMPACT_MODE_RULES = {
   lite: 'Build the ask; name a lazier alternative.',
   full: 'Enforce ladder; shortest diff.',
   ultra: 'YAGNI first; delete; challenge the rest.',
 };
+const SKILL_PATH = path.join(__dirname, '..', '..', 'skills', 'ponytail', 'SKILL.md');
 
 function filterSkillBodyForMode(body, mode) {
-  // Unreachable: normalizeMode returns a valid mode or null, and the caller
-  // passes a valid mode.
-  /* v8 ignore next 1 */
   const effectiveMode = normalizeMode(mode) || DEFAULT_MODE;
   const withoutFrontmatter = String(body || '').replace(/^---[\s\S]*?---\s*/, '');
 
@@ -33,7 +30,11 @@ function filterSkillBodyForMode(body, mode) {
         if (labelMode) return labelMode === effectiveMode;
       }
 
-      const exampleLabel = line.match(/^-\s*([^:]+):\s*/);
+      // Require a quoted value: every worked example is `- lite: "..."`. Without
+      // this, an ordinary rule bullet that happens to start with a mode word
+      // (e.g. "- Full: ...") is silently dropped in every other mode — it looks
+      // like a worked example but is really prose meant to survive verbatim.
+      const exampleLabel = line.match(/^-\s*([^:]+):\s*"/);
       if (exampleLabel) {
         const labelMode = normalizeMode(exampleLabel[1].trim());
         if (labelMode) return labelMode === effectiveMode;
@@ -65,7 +66,7 @@ function getFallbackInstructions(mode) {
     'Deletion over addition. Boring over clever. Fewest files possible. ' +
     'Ship the lazy version and question the complex request in the same response — never stall. ' +
     'Between two same-size stdlib options, pick the one correct on edge cases. ' +
-    'Mark intentional simplifications with a `ponytail:` comment — a shortcut with a known ceiling names the ceiling and the upgrade path in the comment.\n\n' +
+    'Mark deliberate simplifications that cut a real corner with a known ceiling, using a `ponytail:` comment that names the ceiling and upgrade path.\n\n' +
     '## Output\n\n' +
     'Code first. Then at most three short lines: what was skipped, when to add it. ' +
     'If the explanation is longer than the code, delete the explanation. ' +
@@ -93,9 +94,6 @@ function getPonytailInstructions(mode, options) {
     return 'PONYTAIL MODE ACTIVE — level: ' + configuredMode + '. Behavior defined by /ponytail-' + configuredMode + ' skill.';
   }
 
-  // Unreachable: normalizePersistedMode above already falls back to
-  // DEFAULT_MODE, so normalizeMode always returns a valid mode here.
-  /* v8 ignore next 1 */
   const effectiveMode = normalizeMode(configuredMode) || DEFAULT_MODE;
   if (options?.compact === true) return getCompactInstructions(effectiveMode);
 

package/dist/extensions/ponytail/test/extension.test.js

@@ -74,7 +74,6 @@ describe("ponytail extension", () => {
 
 		const result = await events.get("before_agent_start")({ systemPrompt: "BASE" }, ctx);
 		expect(result.systemPrompt).toMatch(/^BASE\n\nPONYTAIL ULTRA:/);
-		expect(result.systemPrompt.length - "BASE\n\n".length).toBeLessThanOrEqual(450);
 	}));
 
 	it("session_start restores latest persisted mode", async () => withTempConfig(async () => {
@@ -160,17 +159,17 @@ describe("ponytail extension", () => {
 		expect(result.systemPrompt).toMatch(/PONYTAIL ULTRA:/);
 	}));
 
-	it("session_start clears the legacy status without rendering a replacement", async () => withTempConfig(async () => {
-		const { commands, events } = createPiHarness();
+	it("never writes a Ponytail statusline", async () => withTempConfig(async () => {
+		const { events } = createPiHarness();
 		const statusWrites = [];
 		const ctx = createCommandContext({
 			ui: { notify() {}, setStatus: (key, text) => statusWrites.push({ key, text }) },
 		});
 
-		await events.get("session_start")({ reason: "resume" }, ctx);
-		await commands.get("ponytail").handler("ultra", ctx);
-
-		expect(statusWrites).toEqual([{ key: "ponytail", text: undefined }]);
+		await events.get("session_start")({ reason: "startup" }, ctx);
+		expect(events.has("agent_start")).toBe(false);
+		expect(events.has("agent_end")).toBe(false);
+		expect(statusWrites).toEqual([]);
 	}));
 
 	it("/ponytail status reports current and default modes", async () => withTempConfig(async () => {
@@ -262,7 +261,7 @@ describe("ponytail extension", () => {
 
 		await events.get("session_start")({ reason: "resume" }, ctx);
 		const result = await events.get("before_agent_start")({ systemPrompt: "BASE" }, ctx);
-		expect(result.systemPrompt).toMatch(/PONYTAIL FULL:/);
+		expect(result.systemPrompt).toMatch(/PONYTAIL MODE ACTIVE — level: full/);
 	}));
 
 	it("input handler tolerates missing text", async () => withTempConfig(async () => {

package/dist/extensions/ponytail/test/helpers.test.js

@@ -113,7 +113,7 @@ describe("ponytail helpers", () => {
   });
 
   it("filterSkillBodyForMode keeps only requested intensity examples and rows", () => {
-    const body = `---\nname: ponytail\n---\n| **lite** | keep lite |\n| **full** | keep full |\n| **ultra** | keep ultra |\n- lite: Lite example\n- full: Full example\n- ultra: Ultra example\nOther line`;
+    const body = `---\nname: ponytail\n---\n| **lite** | keep lite |\n| **full** | keep full |\n| **ultra** | keep ultra |\n- lite: \"Lite example\"\n- full: \"Full example\"\n- ultra: \"Ultra example\"\nOther line`;
 
     const filtered = filterSkillBodyForMode(body, "ultra");