@selesai/code 0.9.11 → 0.9.12

package/dist/extensions/pi-subagents/src/tui/render.ts

@@ -3,6 +3,7 @@
  */
 
 import * as path from "node:path";
+import { createHash } from "node:crypto";
 import type { AgentToolResult } from "@earendil-works/pi-agent-core";
 import { getMarkdownTheme, keyText, type ExtensionContext } from "@selesai/code";
 import { Container, Markdown, Spacer, Text, visibleWidth, type Component } from "@earendil-works/pi-tui";
@@ -17,7 +18,7 @@ import {
 	type WorkflowNodeStatus,
 	type MainWindowRendererConfig,
 	MAX_WIDGET_JOBS,
-	POLL_INTERVAL_MS,
+	WIDGET_ANIMATION_INTERVAL_MS,
 	WIDGET_KEY,
 } from "../shared/types.ts";
 import { sanitizeDisplayText, truncateDisplayText } from "../shared/display-text.ts";
@@ -535,7 +536,76 @@ function compactCurrentActivity(progress: AgentProgress): string {
 	return formatCurrentToolLine(progress, getTermWidth() - 4, false, snapshotNow) ?? buildLiveStatusLine(progress, snapshotNow) ?? "thinking…";
 }
 
-export function widgetRenderKey(job: AsyncJobState): string {
+function textDigest(text: string): string {
+	return createHash("sha256").update(text).digest("hex").slice(0, 16);
+}
+
+function displayTextRenderKey(text: string): unknown[] {
+	const normalized = sanitizeDisplayText(text);
+	return [normalized.length, textDigest(normalized)];
+}
+
+function expandedStepActivityRenderKey(step: AsyncJobStep): unknown[] {
+	return [
+		step.recentTools?.slice(-3).map((tool) => [tool.tool, displayTextRenderKey(tool.args), tool.endMs]),
+		compactRecentOutputLines(step.recentOutput).map(displayTextRenderKey),
+	];
+}
+
+function widgetStepRenderKey(step: AsyncJobStep, index: number, expanded = false): unknown[] {
+	return [
+		step.index ?? index,
+		step.agent,
+		step.workflowKey,
+		step.phase,
+		step.label,
+		step.status,
+		step.activityState,
+		step.lastActivityAt,
+		step.currentTool,
+		step.currentToolArgs,
+		step.currentToolStartedAt,
+		step.currentPath,
+		step.turnCount,
+		step.toolCount,
+		step.startedAt,
+		step.endedAt,
+		step.durationMs,
+		step.tokens?.total,
+		step.model,
+		step.thinking,
+		step.context,
+		step.error,
+		expanded ? expandedStepActivityRenderKey(step) : undefined,
+		nestedRenderKey(step.children, expanded),
+	];
+}
+
+function nestedRenderKey(children: NestedRunSummary[] | undefined, expanded = false): unknown[] {
+	return (children ?? []).map((child) => [
+		child.id,
+		child.state,
+		child.agent,
+		child.model,
+		child.thinking,
+		child.activityState,
+		child.lastActivityAt,
+		child.currentTool,
+		child.currentToolStartedAt,
+		child.currentPath,
+		child.turnCount,
+		child.toolCount,
+		child.startedAt,
+		child.endedAt,
+		child.lastUpdate,
+		child.error,
+		child.totalTokens?.total,
+		child.steps?.map((step, index) => widgetStepRenderKey({ ...step, agent: step.agent, status: step.status }, index, expanded)),
+		nestedRenderKey(child.children, expanded),
+	]);
+}
+
+export function widgetRenderKey(job: AsyncJobState, expanded = false): string {
 	return JSON.stringify({
 		asyncDir: job.asyncDir,
 		status: job.status,
@@ -551,8 +621,8 @@ export function widgetRenderKey(job: AsyncJobState): string {
 		currentStep: job.currentStep,
 		chainStepCount: job.chainStepCount,
 		parallelGroups: job.parallelGroups,
-		steps: job.steps,
-		nestedChildren: job.nestedChildren,
+		steps: job.steps?.map((step, index) => widgetStepRenderKey(step, index, expanded)),
+		nestedChildren: nestedRenderKey(job.nestedChildren, expanded),
 		stepsTotal: job.stepsTotal,
 		runningSteps: job.runningSteps,
 		completedSteps: job.completedSteps,
@@ -1510,7 +1580,7 @@ function buildWidgetComponent(jobs: AsyncJobState[], expanded: boolean): (_tui:
 		const container = new Container();
 		container.render = (renderWidth: number): string[] => {
 			const width = Math.max(0, renderWidth - 2);
-			const frame = Math.floor(Date.now() / POLL_INTERVAL_MS);
+			const frame = Math.floor(Date.now() / WIDGET_ANIMATION_INTERVAL_MS);
 			const buildLines = (): string[] => expanded
 				? buildWidgetLines(jobs, theme, width, true, frame)
 				: jobs.length === 1
@@ -1676,8 +1746,9 @@ function workflowRowStateLabel(row: WorkflowChatProgressRow, theme: Theme): stri
 }
 
 function workflowOverallState(rows: WorkflowChatProgressRow[], hasTerminalValue: boolean, isError?: boolean): "running" | "complete" | "failed" | "paused" {
-	if (isError || rows.some((row) => row.state === "failed")) return "failed";
+	if (rows.some((row) => row.state === "failed")) return "failed";
 	if (rows.some((row) => row.state === "detached")) return "paused";
+	if (isError) return "failed";
 	if ((rows.length > 0 && rows.every((row) => row.state === "complete")) || hasTerminalValue) return "complete";
 	return "running";
 }
@@ -1878,7 +1949,7 @@ export function renderSubagentResult(
 	const layout = resolveMainWindowRenderLayout(rendererConfig);
 	const compact = (component: Component): Component => capCompactMainWindowResult(component, layout, theme, !options.expanded);
 	const d = result.details;
-	if (d?.mode === "workflow" && d.chatProgress?.mode === "live-card" && !result.isError && d.workflow?.value === undefined) {
+	if (d?.mode === "workflow" && d.chatProgress?.mode === "live-card" && d.workflow?.value === undefined && (!result.isError || (d.workflow?.trace.length ?? 0) > 0)) {
 		return compact(renderWorkflowChatProgress(d, result, theme, options.expanded ? resolveMainWindowRenderLayout() : layout, frame));
 	}
 	if (!d || !d.results.length) {

package/dist/extensions/pi-subagents/src/watchdog/change-signature.ts

@@ -38,7 +38,7 @@ export interface WatchdogRepoChangeSignature {
 }
 
 function git(cwd: string, args: string[]): string | undefined {
-	const result = spawnSync("git", ["-C", cwd, ...args], { encoding: "utf-8", maxBuffer: 10 * 1024 * 1024 });
+	const result = spawnSync("git", ["-C", cwd, ...args], { encoding: "utf-8", maxBuffer: 10 * 1024 * 1024, windowsHide: true });
 	if (result.status !== 0) return undefined;
 	return result.stdout;
 }

package/dist/extensions/pi-subagents/src/watchdog/lsp-diagnostics.ts

@@ -444,6 +444,7 @@ async function collectWithTypeScriptLanguageServer(input: {
 }): Promise<WatchdogLspResult> {
 	const started = Date.now();
 	const child = spawn(input.command.command, input.command.args, {
+		windowsHide: true,
 		cwd: input.root,
 		stdio: "pipe",
 		env: { ...process.env, NO_COLOR: "1" },

package/dist/extensions/pi-subagents/src/watchdog/permission-arbiter.ts

@@ -45,7 +45,11 @@ export function createWatchdogPermissionArbiter(options: WatchdogPermissionArbit
 		const createdAt = Date.now();
 		const auditBase = { type: "permission.request", createdAt, toolName: request.toolName, preview, matchedRule: "ask", decisionSource: "watchdog" };
 		appendPermissionAudit(request.auditPath, auditBase);
+		let completed = false;
 		const finish = (approved: boolean, reason: string, decision: string): WatchdogPermissionResult => {
+			const concise = conciseReason(reason);
+			if (completed) return { approved, reason: concise, source: "watchdog" };
+			completed = true;
 			appendPermissionAudit(request.auditPath, {
 				type: "permission.decision",
 				createdAt: Date.now(),
@@ -54,9 +58,9 @@ export function createWatchdogPermissionArbiter(options: WatchdogPermissionArbit
 				decision,
 				approved,
 				decisionSource: "watchdog",
-				reason: conciseReason(reason),
+				reason: concise,
 			});
-			return { approved, reason: conciseReason(reason), source: "watchdog" };
+			return { approved, reason: concise, source: "watchdog" };
 		};
 
 		let childConfig;
@@ -84,61 +88,65 @@ export function createWatchdogPermissionArbiter(options: WatchdogPermissionArbit
 
 		let timeout: ReturnType<typeof setTimeout> | undefined;
 		let agent: Agent | undefined;
+		let abort: (() => void) | undefined;
 		try {
-			const config = childResolvedConfig(childConfig);
-			const selection = await resolveWatchdogReviewModel(request.ctx, config);
-			const auth = selection.auth;
-			const registeredProvider = (request.ctx.modelRegistry as {
-				getRegisteredProviderConfig?: (provider: string) => { api?: string; streamSimple?: StreamFn } | undefined;
-			}).getRegisteredProviderConfig?.(selection.model.provider);
-			const baseStreamFn = options.streamFn ?? (registeredProvider?.streamSimple && registeredProvider.api === selection.model.api
-				? registeredProvider.streamSimple
-				: streamSimple);
-			const streamFn: StreamFn = (model, context, streamOptions) => baseStreamFn(model, context, {
-				...streamOptions,
-				...(auth.apiKey ? { apiKey: auth.apiKey } : {}),
-				env: auth.env || streamOptions?.env ? { ...(auth.env ?? {}), ...(streamOptions?.env ?? {}) } : undefined,
-				headers: { ...(streamOptions?.headers ?? {}), ...(auth.headers ?? {}) },
-			});
-			agent = new Agent({
-				initialState: {
-					systemPrompt: [
-						"You are the pi-subagents watchdog permission arbiter.",
-						"Decide only whether this exact non-bash child tool call should proceed.",
-						"Call watchdog_permission_decision exactly once with approve or deny and a concise reason.",
-						"Deny when uncertain. Do not produce freeform advice or ask the parent orchestrator.",
-					].join("\n"),
-					model: selection.model,
-					thinkingLevel: selection.thinkingLevel,
-					tools: [tool],
-				},
-				convertToLlm,
-				...agentStreamOptions(streamFn),
-				getApiKey: (providerName) => providerName === selection.model.provider ? auth.apiKey : undefined,
-				beforeToolCall: async ({ toolCall }) => toolCall.name === tool.name ? undefined : { block: true, reason: `Permission arbiter tool '${toolCall.name}' is not allowed.` },
-				toolExecution: "sequential",
-			});
-			const abort = () => agent?.abort();
-			request.signal?.addEventListener("abort", abort, { once: true });
-			request.ctx.signal?.addEventListener("abort", abort, { once: true });
-			try {
-				const prompt = `Tool: ${request.toolName}\nRedacted arguments: ${preview}`;
-				await Promise.race([
-					agent.prompt(prompt),
-					new Promise<never>((_, reject) => { timeout = setTimeout(() => { agent?.abort(); reject(new Error("Watchdog permission decision timed out.")); }, childConfig.agentEndTimeoutMs); }),
-				]);
-			} finally {
-				request.signal?.removeEventListener("abort", abort);
-				request.ctx.signal?.removeEventListener("abort", abort);
-			}
-			if (!decision) return finish(false, "Watchdog permission arbiter returned no decision.", "malformed");
-			const approved = decision.decision === "approve";
-			return finish(approved, decision.reason, decision.decision);
+			const run = async (): Promise<WatchdogPermissionResult> => {
+				const config = childResolvedConfig(childConfig);
+				const selection = await resolveWatchdogReviewModel(request.ctx, config);
+				const auth = selection.auth;
+				const registeredProvider = (request.ctx.modelRegistry as {
+					getRegisteredProviderConfig?: (provider: string) => { api?: string; streamSimple?: StreamFn } | undefined;
+				}).getRegisteredProviderConfig?.(selection.model.provider);
+				const baseStreamFn = options.streamFn ?? (registeredProvider?.streamSimple && registeredProvider.api === selection.model.api
+					? registeredProvider.streamSimple
+					: streamSimple);
+				const streamFn: StreamFn = (model, context, streamOptions) => baseStreamFn(model, context, {
+					...streamOptions,
+					...(auth.apiKey ? { apiKey: auth.apiKey } : {}),
+					env: auth.env || streamOptions?.env ? { ...(auth.env ?? {}), ...(streamOptions?.env ?? {}) } : undefined,
+					headers: { ...(streamOptions?.headers ?? {}), ...(auth.headers ?? {}) },
+				});
+				agent = new Agent({
+					initialState: {
+						systemPrompt: [
+							"You are the pi-subagents watchdog permission arbiter.",
+							"Decide only whether this exact non-bash child tool call should proceed.",
+							"Call watchdog_permission_decision exactly once with approve or deny and a concise reason.",
+							"Deny when uncertain. Do not produce freeform advice or ask the parent orchestrator.",
+						].join("\n"),
+						model: selection.model,
+						thinkingLevel: selection.thinkingLevel,
+						tools: [tool],
+					},
+					convertToLlm,
+					...agentStreamOptions(streamFn),
+					getApiKey: (providerName) => providerName === selection.model.provider ? auth.apiKey : undefined,
+					beforeToolCall: async ({ toolCall }) => toolCall.name === tool.name ? undefined : { block: true, reason: `Permission arbiter tool '${toolCall.name}' is not allowed.` },
+					toolExecution: "sequential",
+				});
+				await agent.prompt(`Tool: ${request.toolName}\nRedacted arguments: ${preview}`);
+				if (!decision) return finish(false, "Watchdog permission arbiter returned no decision.", "malformed");
+				const approved = decision.decision === "approve";
+				return finish(approved, decision.reason, decision.decision);
+			};
+			return await Promise.race([
+				run(),
+				new Promise<WatchdogPermissionResult>((resolve) => { timeout = setTimeout(() => { agent?.abort(); resolve(finish(false, "Watchdog permission decision timed out.", "timeout")); }, childConfig.agentEndTimeoutMs); }),
+				new Promise<WatchdogPermissionResult>((resolve) => {
+					abort = () => { agent?.abort(); resolve(finish(false, "Watchdog permission decision was cancelled.", "cancelled")); };
+					request.signal?.addEventListener("abort", abort, { once: true });
+					request.ctx.signal?.addEventListener("abort", abort, { once: true });
+				}),
+			]);
 		} catch (error) {
 			const reason = error instanceof Error ? error.message : String(error);
 			return finish(false, `Watchdog permission arbiter failed closed: ${reason}`, reason.includes("timed out") ? "timeout" : "error");
 		} finally {
 			if (timeout) clearTimeout(timeout);
+			if (abort) {
+				request.signal?.removeEventListener("abort", abort);
+				request.ctx.signal?.removeEventListener("abort", abort);
+			}
 		}
 	};
 }

package/dist/extensions/pi-subagents/src/watchdog/register-main.ts

@@ -141,7 +141,13 @@ export function buildWatchdogStatus(snapshot: ReturnType<MainWatchdogRuntime["ge
 		"Sources:",
 		...snapshot.sources.map(sourceLine),
 		"",
-		"Model configuration is managed through Selesai settings.",
+		"Model commands:",
+		"- /subagents-watchdog recommend-model",
+		"- /subagents-watchdog model recommended",
+		"- /subagents-watchdog model <provider/model[:thinking]>",
+		"- /subagents-watchdog model inherit",
+		"- /subagents-watchdog session model recommended",
+		"Agent action: subagent({ action: \"watchdog.configure\", model: \"recommended\", scope: \"session\" })",
 	);
 	return lines.join("\n");
 }
@@ -365,7 +371,7 @@ async function handleWatchdogCommand(
 		pi.sendMessage(createWatchdogWarningMessage(details, { display: true, details }));
 		return;
 	}
-	ctx.ui.notify(`Usage: /subagents-watchdog [status|on|off|session on|session off|check|test concern <text>|test blocker <text>]`, "error");
+	ctx.ui.notify(`Usage: /subagents-watchdog [status|on|off|session on|session off|recommend-model|model recommended|model <provider/model[:thinking]>|model inherit|thinking ${THINKING_LEVELS.join("|")}|thinking inherit|session model recommended|check|test concern <text>|test blocker <text>]`, "error");
 }
 
 export function registerMainWatchdog(pi: ExtensionAPI, options: RegisterMainWatchdogOptions = {}): MainWatchdogRuntime {

package/dist/extensions/pi-subagents/src/watchdog/tool-actions.ts

@@ -114,6 +114,7 @@ export function handleWatchdogToolAction(action: string, params: WatchdogToolPar
 			if (!runtime) return result("Subagent watchdog runtime is unavailable.", true);
 			return result(buildWatchdogStatus(runtime.getSnapshot(ctx.cwd), ctx));
 		}
+		if (action === "watchdog.recommend-model") return result(buildRecommendationText(ctx));
 		if (action === "watchdog.check") return result(buildCheckText(runtime, ctx));
 		if (action !== "watchdog.configure") return result(`Unknown watchdog action: ${action}`, true);
 
@@ -150,5 +151,5 @@ export function handleWatchdogToolAction(action: string, params: WatchdogToolPar
 	}
 }
 
-export const WATCHDOG_TOOL_ACTIONS = ["watchdog.status", "watchdog.check"] as const;
+export const WATCHDOG_TOOL_ACTIONS = ["watchdog.status", "watchdog.check", "watchdog.configure", "watchdog.recommend-model"] as const;
 export const WATCHDOG_THINKING_VALUES = ["inherit", ...THINKING_LEVELS] as const;

package/dist/extensions/pi-subagents/src/workflows/chat-progress.ts

@@ -3,7 +3,7 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 import type { Details } from "../shared/types.ts";
 
-export const WORKFLOW_CHAT_PROGRESS_MODES = ["auto", "off", "terminal", "milestones", "live-card"] as const;
+export const WORKFLOW_CHAT_PROGRESS_MODES = ["auto", "off", "live-card"] as const;
 export type WorkflowChatProgressMode = typeof WORKFLOW_CHAT_PROGRESS_MODES[number];
 export type ResolvedWorkflowChatProgressMode = Exclude<WorkflowChatProgressMode, "auto">;
 
@@ -26,7 +26,7 @@ interface ResolveWorkflowChatProgressInput {
 }
 
 function git(cwd: string, args: string[]): string | undefined {
-	const result = spawnSync("git", ["-C", cwd, ...args], { encoding: "utf-8" });
+	const result = spawnSync("git", ["-C", cwd, ...args], { encoding: "utf-8", windowsHide: true });
 	if (result.status !== 0) return undefined;
 	const output = result.stdout.trim();
 	return output || undefined;
@@ -86,11 +86,11 @@ export function resolveWorkflowChatProgress(input: ResolveWorkflowChatProgressIn
 
 	const requestedMode = requested.mode ?? "auto";
 	let mode: ResolvedWorkflowChatProgressMode;
-	if (requestedMode === "auto") mode = sameRepo ? (input.background ? "milestones" : "live-card") : "terminal";
+	if (requestedMode === "auto") mode = sameRepo && !input.background ? "live-card" : "off";
 	else mode = requestedMode;
 
 	if (mode === "live-card" && !sameRepo) return { error: "chatProgress: 'live-card' is only available for workflowScript runs in the same Git repository." };
-	if (mode === "live-card" && input.background) return { error: "chatProgress: 'live-card' requires a watched foreground workflow; pass async:false." };
+	if (mode === "live-card" && input.background) return { error: "chatProgress: 'live-card' is unavailable for async workflowScript. Async workflows have no inline live card; omit chatProgress or use auto/off. Use async:false only when the parent must block." };
 	return { projection: { mode, repoRelation, ...(repoLabel ? { repoLabel } : {}) } };
 }