@selesai/code 0.8.5 → 0.8.7

package/dist/extensions/pi-subagents/test/unit/workflow-auto-relaunch.test.ts

@@ -0,0 +1,45 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+import {
+	DEFAULT_MAX_WORKFLOW_AUTO_RELAUNCHES,
+	resolveAutoRelaunchDecision,
+	resolveMaxWorkflowAutoRelaunches,
+} from "../../src/workflows/workflow-auto-relaunch.ts";
+
+describe("workflow auto-relaunch policy", () => {
+	it("relaunches on a budget result while under the cap", () => {
+		const decision = resolveAutoRelaunchDecision({ result: "budget", rounds: 3 }, 2, 12);
+		assert.deepEqual(decision, { relaunch: true, capped: false });
+	});
+
+	it("does not relaunch a clean result", () => {
+		const decision = resolveAutoRelaunchDecision({ result: "clean", rounds: 3 }, 0, 12);
+		assert.deepEqual(decision, { relaunch: false, capped: false });
+	});
+
+	it("does not relaunch non-workflow values", () => {
+		for (const value of [undefined, null, 5, "budget", ["budget"], { result: "failed" }]) {
+			const decision = resolveAutoRelaunchDecision(value, 0, 12);
+			assert.deepEqual(decision, { relaunch: false, capped: false });
+		}
+	});
+
+	it("marks the cap as reached when the relaunch count equals the cap", () => {
+		const decision = resolveAutoRelaunchDecision({ result: "budget" }, 12, 12);
+		assert.deepEqual(decision, { relaunch: false, capped: true });
+	});
+
+	it("relaunches indefinitely when the cap is unlimited", () => {
+		const decision = resolveAutoRelaunchDecision({ result: "budget" }, 50, undefined);
+		assert.deepEqual(decision, { relaunch: true, capped: false });
+	});
+
+	it("resolves the configured cap with a safe default and 0 as unlimited", () => {
+		assert.equal(resolveMaxWorkflowAutoRelaunches(undefined), DEFAULT_MAX_WORKFLOW_AUTO_RELAUNCHES);
+		assert.equal(resolveMaxWorkflowAutoRelaunches(5), 5);
+		assert.equal(resolveMaxWorkflowAutoRelaunches(0), undefined);
+		assert.equal(resolveMaxWorkflowAutoRelaunches(-3), DEFAULT_MAX_WORKFLOW_AUTO_RELAUNCHES);
+		assert.equal(resolveMaxWorkflowAutoRelaunches("12"), DEFAULT_MAX_WORKFLOW_AUTO_RELAUNCHES);
+		assert.equal(resolveMaxWorkflowAutoRelaunches(2.5), DEFAULT_MAX_WORKFLOW_AUTO_RELAUNCHES);
+	});
+});

package/dist/extensions/pi-subagents/test/unit/workflow-chat-progress.test.ts

@@ -4,7 +4,7 @@ import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
 import { describe, it } from "node:test";
-import { isSameGitRepository, resolveWorkflowChatProgress } from "../../src/workflows/chat-progress.ts";
+import { buildWorkflowChatProgressRows, isSameGitRepository, resolveWorkflowChatProgress } from "../../src/workflows/chat-progress.ts";
 import { renderSubagentResult } from "../../src/tui/render.ts";
 import { bindMissionWorkflowChildAsyncLaunch, createSubagentExecutor, foregroundResultIntercomStatus, missionWorkflowChildStatus, runMissionWorkflowChild, shouldSuppressRoutineResultIntercom } from "../../src/runs/foreground/subagent-executor.ts";
 import { readMissionBinding } from "../../src/missions/lifecycle.ts";
@@ -202,6 +202,38 @@ describe("workflow chat progress rendering", () => {
 		}
 	});
 
+	it("warns once when a workflow child outlives its mission record", async () => {
+		const root = fs.mkdtempSync(path.join(os.tmpdir(), "pi-workflow-missing-mission-"));
+		const originalWarn = console.warn;
+		const warnings: string[] = [];
+		try {
+			const location = {
+				projectRoot: root,
+				missionDir: path.join(root, ".pi/subagents", "missions"),
+				globalIndexDir: path.join(root, ".pi/subagents", "mission-index"),
+				writeGlobalIndex: false,
+			};
+			const mission = createMission(location, { title: "Workflow", objective: "Track child" });
+			fs.rmSync(path.join(location.missionDir, `${mission.id}.json`));
+			console.warn = (...args: unknown[]) => warnings.push(args.map(String).join(" "));
+
+			for (const key of ["first", "second"]) {
+				await assert.rejects(
+					() => runMissionWorkflowChild({ missionId: mission.id, location, autoCreated: false }, "wf-missing-mission", key, "Prep", async () => {
+						throw new Error("child failed");
+					}),
+					/child failed/,
+				);
+			}
+
+			assert.equal(warnings.length, 1);
+			assert.match(warnings[0] ?? "", new RegExp(`Mission '${mission.id}' is no longer in the mission store`));
+		} finally {
+			console.warn = originalWarn;
+			fs.rmSync(root, { recursive: true, force: true });
+		}
+	});
+
 	it("renders stable rows keyed by workflow trace entries", () => {
 		const text = componentText(renderSubagentResult({
 			content: [{ type: "text", text: "Workflow running." }],
@@ -215,6 +247,7 @@ describe("workflow chat progress rendering", () => {
 						{ operation: "run", key: "scout", state: "completed", runId: "run-scout", phase: "Validation", label: "Found renderer seam", durationMs: 12 },
 						{ operation: "run", key: "tests", state: "started", phase: "Validation", label: "focused integration suite" },
 						{ operation: "run", key: "review", state: "failed", phase: "Validation", label: "fresh-context UX review", error: "needs fixes" },
+						{ operation: "run", key: "stale", state: "stopped", phase: "Validation", label: "superseded exact-head review", error: "Workflow stopped by user." },
 					],
 					emits: [],
 					console: [],
@@ -228,6 +261,66 @@ describe("workflow chat progress rendering", () => {
 		assert.match(text, /complete\s+scout Found renderer seam/);
 		assert.match(text, /running\s+tests focused integration suite/);
 		assert.match(text, /failed\s+review fresh-context UX review .* needs fixes/);
+		assert.match(text, /stopped\s+stale superseded exact-head review .* Workflow stopped by user/);
+	});
+
+	it("renders detached workflow trace rows as paused attention", () => {
+		const trace: NonNullable<Details["workflow"]>["trace"] = [{
+			operation: "run",
+			key: "detaches",
+			state: "detached",
+			phase: "Decision",
+			label: "supervisor handoff",
+			error: "Detached for intercom coordination. Reply to the supervisor request first.",
+		}];
+		const rows = buildWorkflowChatProgressRows(trace);
+		assert.equal(rows[0]?.state, "detached");
+
+		const text = componentText(renderSubagentResult({
+			content: [{ type: "text", text: "Workflow paused." }],
+			details: {
+				mode: "workflow",
+				runId: "wf_detached",
+				results: [],
+				chatProgress: { mode: "live-card", repoRelation: "same", repoLabel: "pi-subagents" },
+				workflow: { trace, emits: [], console: [] },
+			},
+		}, { expanded: false }, theme as any));
+
+		assert.match(text, /workflow wf_detached .* same repo .* paused/);
+		assert.match(text, /Phase  Decision/);
+		assert.match(text, /detached\s+detaches supervisor handoff .* Detached for intercom coordination/);
+		assert.doesNotMatch(text, /running\s+detaches/);
+		assert.doesNotMatch(text, /failed\s+detaches/);
+	});
+
+	it("applies main-window density settings to collapsed workflow live cards", () => {
+		const trace = Array.from({ length: 10 }, (_, index) => ({
+			operation: "run" as const,
+			key: `step-${index}`,
+			state: "started" as const,
+			label: `review ${index}`,
+		}));
+		const result = {
+			content: [{ type: "text" as const, text: "Workflow running." }],
+			details: {
+				mode: "workflow" as const,
+				runId: "wf_density",
+				results: [],
+				chatProgress: { mode: "live-card" as const, repoRelation: "same" as const, repoLabel: "pi-subagents" },
+				workflow: { trace, emits: [], console: [] },
+			},
+		};
+
+		const compact = renderSubagentResult(result, { expanded: false }, theme as any, undefined, { horizontalSpacing: 0, compactResultMaxLines: 3 }).render(120);
+		assert.equal(compact.length, 3);
+		assert.match(compact[1]!, /^Repo   pi-subagents\s*$/);
+		assert.match(compact[2]!, /rows hidden/);
+
+		const expanded = renderSubagentResult(result, { expanded: true }, theme as any, undefined, { horizontalSpacing: 0, compactResultMaxLines: 3 }).render(120);
+		assert.ok(expanded.length > 3);
+		assert.match(expanded[1]!, /^  Repo   pi-subagents\s*$/);
+		assert.doesNotMatch(expanded.join("\n"), /rows hidden · .* expands/);
 	});
 
 	it("bounds workflow live-card rows and keeps old failed children visible", () => {

package/dist/extensions/pi-subagents/test/unit/workflow-launch-params.test.ts

@@ -39,6 +39,26 @@ describe("workflow launch params", () => {
 		);
 	});
 
+	it("keeps a bridge override scoped to the target workflow child", () => {
+		assert.deepEqual(
+			prepareWorkflowLaunchParams(
+				{},
+				{ agent: "worker", task: "Run", intercomBridge: { mode: "off" } },
+				"workflow-run",
+				"isolated",
+			),
+			{
+				agent: "worker",
+				task: "Run",
+				intercomBridge: { mode: "off" },
+				async: false,
+				workflowParentRunId: "workflow-run",
+				workflowKey: "isolated",
+			},
+		);
+		assert.equal(prepareWorkflowLaunchParams({}, { agent: "worker", task: "Run" }, "workflow-run", "sibling").intercomBridge, undefined);
+	});
+
 	it("places workflow child gates inside managed worktree tasks", () => {
 		assert.deepEqual(
 			prepareWorkflowLaunchParams(
@@ -61,6 +81,25 @@ describe("workflow launch params", () => {
 		);
 	});
 
+	it("preserves a bridge override for retained workflow children", () => {
+		assert.deepEqual(
+			prepareWorkflowLaunchParams(
+				{},
+				{ resume: "retained-run", task: "Continue", intercomBridge: { mode: "off" } },
+				"workflow-run",
+				"continue",
+			),
+			{
+				action: "resume",
+				id: "retained-run",
+				message: "Continue",
+				workflowParentRunId: "workflow-run",
+				workflowKey: "continue",
+				intercomBridge: { mode: "off" },
+			},
+		);
+	});
+
 	it("rejects gate defaults on retained resume items", () => {
 		assert.throws(
 			() => prepareWorkflowLaunchParams(
@@ -82,7 +121,7 @@ describe("workflow launch params", () => {
 		);
 	});
 
-	it("preserves execution limits when routing retained resume items", () => {
+	it("preserves execution limits and fan-out identity when routing retained resume items", () => {
 		assert.deepEqual(
 			prepareWorkflowLaunchParams(
 				{ turnBudget: { maxTurns: 8 }, toolBudget: { hard: 12, block: ["read"] } },
@@ -95,7 +134,7 @@ describe("workflow launch params", () => {
 				},
 				"workflow-run",
 				"continue",
-				{ missionDetached: true },
+				{ missionDetached: true, runFanoutBudget: { version: 1, rootRunId: "root-run", directory: "/tmp/fanout", limit: 64, parentPath: "parent" } },
 			),
 			{
 				action: "resume",
@@ -103,6 +142,7 @@ describe("workflow launch params", () => {
 				message: "Continue carefully",
 				workflowParentRunId: "workflow-run",
 				workflowKey: "continue",
+				runFanoutBudget: { version: 1, rootRunId: "root-run", directory: "/tmp/fanout", limit: 64, parentPath: "parent/workflow[continue]" },
 				mission: false,
 				timeoutMs: 5_000,
 				turnBudget: { maxTurns: 3, graceTurns: 1 },

package/dist/extensions/ponytail/index.js

@@ -16,6 +16,9 @@ export { filterSkillBodyForMode };
 export const readDefaultMode = getDefaultMode;
 
 export function resolveSessionMode(entries, fallbackMode = DEFAULT_MODE) {
+  // Unreachable: normalizePersistedMode always returns a valid mode or null,
+  // and the caller passes a valid default.
+  /* v8 ignore next 1 */
   const fallback = normalizePersistedMode(fallbackMode) || DEFAULT_MODE;
   if (!Array.isArray(entries)) return fallback;
 
@@ -59,6 +62,9 @@ export default function ponytailExtension(pi) {
 
   const setMode = (mode, ctx) => {
     const normalized = normalizePersistedMode(mode);
+    // Unreachable: setMode is only called with validated modes from the
+    // command handler and the deactivation input handler.
+    /* v8 ignore next 1 */
     if (!normalized) return;
 
     currentMode = normalized;
@@ -68,6 +74,8 @@ export default function ponytailExtension(pi) {
 
   const sendAlias = (skillName, args, ctx) => {
     const normalized = String(args || "").trim();
+    // Unreachable: the alias command handlers always pass empty args.
+    /* v8 ignore next 1 */
     const message = normalized ? `${skillName} ${normalized}` : skillName;
 
     if (ctx?.isIdle?.() === false) {
@@ -91,6 +99,9 @@ export default function ponytailExtension(pi) {
 
       if (parsed.type === "set-default") {
         const written = writeDefaultMode(parsed.mode);
+        // Unreachable: parsePonytailCommand only returns set-default for
+        // valid config modes, so writeDefaultMode always succeeds.
+        /* v8 ignore next 1 */
         if (written) {
           configuredDefaultMode = getDefaultMode();
           const message = configuredDefaultMode === written

package/dist/extensions/ponytail/ponytail-config.cjs

@@ -57,6 +57,8 @@ function getConfigDir() {
   }
   if (process.platform === 'win32') {
     return path.join(
+      // Unreachable: APPDATA is always set on Windows.
+      /* v8 ignore next 1 */
       process.env.APPDATA || path.join(os.homedir(), 'AppData', 'Roaming'),
       'ponytail'
     );

package/dist/extensions/ponytail/ponytail-instructions.cjs

@@ -14,6 +14,9 @@ const COMPACT_MODE_RULES = {
 };
 
 function filterSkillBodyForMode(body, mode) {
+  // Unreachable: normalizeMode returns a valid mode or null, and the caller
+  // passes a valid mode.
+  /* v8 ignore next 1 */
   const effectiveMode = normalizeMode(mode) || DEFAULT_MODE;
   const withoutFrontmatter = String(body || '').replace(/^---[\s\S]*?---\s*/, '');
 
@@ -90,6 +93,9 @@ function getPonytailInstructions(mode, options) {
     return 'PONYTAIL MODE ACTIVE — level: ' + configuredMode + '. Behavior defined by /ponytail-' + configuredMode + ' skill.';
   }
 
+  // Unreachable: normalizePersistedMode above already falls back to
+  // DEFAULT_MODE, so normalizeMode always returns a valid mode here.
+  /* v8 ignore next 1 */
   const effectiveMode = normalizeMode(configuredMode) || DEFAULT_MODE;
   if (options?.compact === true) return getCompactInstructions(effectiveMode);