@selesai/code 0.6.2 → 0.7.0

package/dist/extensions/pi-subagents/test/unit/chain-root-attachment.test.ts

@@ -39,12 +39,12 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "complete",
 			startedAt: 1,
-			steps: [{ agent: "worker", status: "complete", sessionFile }],
+			steps: [{ agent: "builder", status: "complete", sessionFile }],
 		});
 		writeJson(importedRoot.resultPath, {
 			state: "complete",
 			success: true,
-			results: [{ agent: "worker", output: "root output", success: true, sessionFile }],
+			results: [{ agent: "builder", output: "root output", success: true, sessionFile }],
 		});
 
 		const result = await waitForImportedAsyncRoot(importedRoot, { pollIntervalMs: 1 });
@@ -55,7 +55,7 @@ describe("async chain root attachment", () => {
 			exitCode: result.exitCode,
 			sessionFile: result.sessionFile,
 		}, {
-			agent: "worker",
+			agent: "builder",
 			output: "root output",
 			exitCode: 0,
 			sessionFile,
@@ -69,7 +69,7 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "running",
 			startedAt: 1,
-			steps: [{ agent: "worker", status: "running" }],
+			steps: [{ agent: "builder", status: "running" }],
 		});
 
 		const waiting = waitForImportedAsyncRoot(importedRoot, { pollIntervalMs: 5 });
@@ -77,7 +77,7 @@ describe("async chain root attachment", () => {
 			writeJson(importedRoot.resultPath, {
 				state: "complete",
 				success: true,
-				results: [{ agent: "worker", output: "late root output", success: true }],
+				results: [{ agent: "builder", output: "late root output", success: true }],
 			});
 		}, 20);
 
@@ -95,13 +95,13 @@ describe("async chain root attachment", () => {
 			state: "failed",
 			startedAt: 1,
 			error: "root failed",
-			steps: [{ agent: "worker", status: "failed", error: "root failed" }],
+			steps: [{ agent: "builder", status: "failed", error: "root failed" }],
 		});
 		writeJson(importedRoot.resultPath, {
 			state: "failed",
 			success: false,
 			summary: "root failed",
-			results: [{ agent: "worker", output: "root failed", error: "root failed", success: false }],
+			results: [{ agent: "builder", output: "root failed", error: "root failed", success: false }],
 		});
 
 		const result = await waitForImportedAsyncRoot(importedRoot, { pollIntervalMs: 1 });
@@ -118,7 +118,7 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "complete",
 			startedAt: 1,
-			steps: [{ agent: "worker", status: "complete" }],
+			steps: [{ agent: "builder", status: "complete" }],
 		});
 
 		const result = await waitForImportedAsyncRoot(importedRoot, {
@@ -137,7 +137,7 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "running",
 			startedAt: 1,
-			steps: [{ agent: "worker", status: "running" }],
+			steps: [{ agent: "builder", status: "running" }],
 		});
 		let timedOut = false;
 		const waiting = waitForImportedAsyncRoot(importedRoot, {

package/dist/extensions/pi-subagents/test/unit/chain-serializer.test.ts

@@ -7,7 +7,7 @@ name: review-chain
 description: Review chain
 ---
 
-## reviewer
+## commentator
 output: report.md
 outputMode: file-only
 
@@ -28,7 +28,7 @@ name: review-chain
 description: Review chain
 ---
 
-## reviewer
+## commentator
 phase: Review
 label: correctness pass
 as: correctnessFindings
@@ -54,7 +54,7 @@ name: review-chain
 description: Review chain
 ---
 
-## reviewer
+## commentator
 toolBudget: {"soft":3,"hard":5,"block":["read","grep"]}
 
 Review the diff
@@ -71,12 +71,12 @@ name: review-chain
 description: Review chain
 ---
 
-## reviewer
+## commentator
 toolBudget: {"soft":6,"hard":5}
 
 Review the diff
 `, "project", "/tmp/review-chain.md"),
-			/toolBudget for step 'reviewer'\.soft must be <= toolBudget for step 'reviewer'\.hard/,
+			/toolBudget for step 'commentator'\.soft must be <= toolBudget for step 'commentator'\.hard/,
 		);
 	});
 
@@ -87,7 +87,7 @@ name: review-chain
 description: Review chain
 ---
 
-## reviewer
+## commentator
 outputSchema: {"type":"object"}
 
 Review the diff
@@ -102,10 +102,10 @@ Review the diff
 				name: "bad-dynamic-review",
 				description: "Bad dynamic targets",
 				chain: [
-					{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+					{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
 					{
 						expand: { from: { output: "targets", path: "/items" }, maxItems: 4 },
-						parallel: [{ agent: "reviewer", task: "Review" }],
+						parallel: [{ agent: "commentator", task: "Review" }],
 						collect: { as: "reviews" },
 					},
 				],
@@ -124,10 +124,10 @@ Review the diff
 			package: "code-analysis",
 			description: "Review dynamic targets",
 			chain: [
-				{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+				{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
 				{
 					expand: { from: { output: "targets", path: "/items" }, item: "target", key: "/path", maxItems: 4 },
-					parallel: { agent: "reviewer", task: "Review {target.path}", outputSchema: { type: "object" } },
+					parallel: { agent: "commentator", task: "Review {target.path}", outputSchema: { type: "object" } },
 					collect: { as: "reviews" },
 				},
 			],
@@ -146,10 +146,10 @@ Review the diff
 			name: "dynamic-review",
 			description: "Review dynamic targets",
 			chain: [
-				{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" }, toolBudget: { hard: 4 } },
+				{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" }, toolBudget: { hard: 4 } },
 				{
 					expand: { from: { output: "targets", path: "/items" }, item: "target", key: "/path", maxItems: 4 },
-					parallel: { agent: "reviewer", task: "Review {target.path}", outputSchema: { type: "object" }, toolBudget: { soft: 3, hard: 5 } },
+					parallel: { agent: "commentator", task: "Review {target.path}", outputSchema: { type: "object" }, toolBudget: { soft: 3, hard: 5 } },
 					collect: { as: "reviews" },
 				},
 			],
@@ -164,7 +164,7 @@ Review the diff
 			() => parseJsonChain(JSON.stringify({
 				name: "bad-tool-budget",
 				description: "Bad tool budget",
-				chain: [{ agent: "worker", toolBudget: { hard: 0 } }],
+				chain: [{ agent: "builder", toolBudget: { hard: 0 } }],
 			}), "project", "/tmp/bad-tool-budget.chain.json"),
 			/step 1 toolBudget\.hard must be an integer >= 1/,
 		);
@@ -173,8 +173,8 @@ Review the diff
 				name: "bad-dynamic-tool-budget",
 				description: "Bad dynamic tool budget",
 				chain: [
-					{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
-					{ expand: { from: { output: "targets", path: "/items" }, maxItems: 4 }, parallel: { agent: "worker", toolBudget: { hard: 3, block: [] } }, collect: { as: "reviews" } },
+					{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+					{ expand: { from: { output: "targets", path: "/items" }, maxItems: 4 }, parallel: { agent: "builder", toolBudget: { hard: 3, block: [] } }, collect: { as: "reviews" } },
 				],
 			}), "project", "/tmp/bad-dynamic-tool-budget.chain.json"),
 			/step 2 dynamic template toolBudget\.block must contain at least one tool name/,
@@ -186,10 +186,10 @@ Review the diff
 			name: "dynamic-review",
 			description: "Review dynamic targets",
 			chain: [
-				{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+				{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
 				{
 					expand: { from: { output: "targets", path: "/items" }, item: "target", key: "/path", maxItems: 4 },
-					parallel: { agent: "reviewer", task: "Review {target.path}", outputSchema: { type: "object" } },
+					parallel: { agent: "commentator", task: "Review {target.path}", outputSchema: { type: "object" } },
 					collect: { as: "reviews" },
 				},
 			],
@@ -206,10 +206,10 @@ Review the diff
 			name: "accepted-chain",
 			description: "Chain with acceptance gates",
 			chain: [
-				{ agent: "worker", task: "Fix bug", acceptance: { level: "checked", evidence: ["changed-files", "commands-run"] } },
+				{ agent: "builder", task: "Fix bug", acceptance: { level: "checked", evidence: ["changed-files", "commands-run"] } },
 				{
 					parallel: [
-						{ agent: "reviewer", task: "Review", acceptance: "attested" },
+						{ agent: "commentator", task: "Review", acceptance: "attested" },
 					],
 				},
 			],
@@ -221,7 +221,7 @@ Review the diff
 			() => parseJsonChain(JSON.stringify({
 				name: "bad-acceptance",
 				description: "Bad acceptance",
-				chain: [{ agent: "worker", acceptance: { level: "none" } }],
+				chain: [{ agent: "builder", acceptance: { level: "none" } }],
 			}), "project", "/tmp/bad-acceptance.chain.json"),
 			/step 1 acceptance\.reason is required/,
 		);

package/dist/extensions/pi-subagents/test/unit/child-protocol.test.ts

@@ -6,6 +6,7 @@ import {
 	createBoundedLineReader,
 	formatProtocolOutputLimit,
 	MAX_CHILD_PENDING_LINE_BYTES,
+	PI_AGGREGATE_EVENT_PROJECTOR,
 	projectChildLifecycle,
 	type ProtocolOutputLimit,
 } from "../../src/runs/shared/child-protocol.ts";
@@ -43,6 +44,104 @@ describe("bounded child protocol reader", () => {
 		assert.equal(lines[0]?.length, imageSizedLine.length);
 	});
 
+	it("projects an oversized turn_end aggregate and resumes at the next record", () => {
+		const lines: string[] = [];
+		const reader = createBoundedLineReader({
+			maxPendingLineBytes: 64,
+			oversizedLineProjector: PI_AGGREGATE_EVENT_PROJECTOR,
+			onLine: (line) => lines.push(line),
+			onLimit: () => assert.fail("redundant aggregate must not fail"),
+		});
+		const aggregate = JSON.stringify({ type: "turn_end", toolResults: ["x".repeat(256)] });
+		const settled = JSON.stringify({ type: "agent_settled" });
+		const bytes = Buffer.from(`${aggregate}\n${settled}\n`);
+		for (let offset = 0; offset < bytes.length; offset += 37) reader.push(bytes.subarray(offset, offset + 37));
+		reader.end();
+		assert.deepEqual(lines, ['{"type":"turn_end"}', settled]);
+		assert.equal(reader.exceeded(), false);
+	});
+
+	it("projects oversized agent_end aggregates without losing retry lifecycle metadata", () => {
+		for (const willRetry of [true, false]) {
+			const lines: string[] = [];
+			const reader = createBoundedLineReader({
+				maxPendingLineBytes: 64,
+				oversizedLineProjector: PI_AGGREGATE_EVENT_PROJECTOR,
+				onLine: (line) => lines.push(line),
+				onLimit: () => assert.fail("valid agent_end aggregate must not fail"),
+			});
+			reader.push(`${JSON.stringify({ type: "agent_end", messages: ["x".repeat(256)], willRetry })}\n`);
+			reader.end();
+			assert.deepEqual(lines.map((line) => JSON.parse(line)), [{ type: "agent_end", willRetry }]);
+		}
+	});
+
+	it("fails closed when an oversized agent_end aggregate lacks lifecycle metadata", () => {
+		let failure: ProtocolOutputLimit | undefined;
+		const reader = createBoundedLineReader({
+			maxPendingLineBytes: 64,
+			oversizedLineProjector: PI_AGGREGATE_EVENT_PROJECTOR,
+			onLine: () => assert.fail("malformed aggregate must not emit"),
+			onLimit: (limit) => { failure = limit; },
+		});
+		reader.push(`${JSON.stringify({ type: "agent_end", messages: ["x".repeat(256)] })}\n`);
+		reader.end();
+		assert.equal(reader.exceeded(), true);
+		assert.equal(failure?.code, "protocol_output_limit");
+	});
+
+	it("fails closed for malformed or truncated oversized turn_end aggregates", () => {
+		for (const aggregate of [
+			`{"type":"turn_end","toolResults":["${"x".repeat(256)}"`,
+			`{"type":"turn_end","toolResults":[${"x".repeat(256)}]}`,
+		]) {
+			let failure: ProtocolOutputLimit | undefined;
+			const reader = createBoundedLineReader({
+				maxPendingLineBytes: 64,
+				oversizedLineProjector: PI_AGGREGATE_EVENT_PROJECTOR,
+				onLine: () => assert.fail("invalid turn_end must not emit"),
+				onLimit: (limit) => { failure = limit; },
+			});
+			reader.push(aggregate);
+			reader.end();
+			assert.equal(reader.exceeded(), true);
+			assert.equal(failure?.code, "protocol_output_limit");
+		}
+	});
+
+	it("fails closed when malformed agent_end content carries an apparent willRetry tail", () => {
+		let failure: ProtocolOutputLimit | undefined;
+		const reader = createBoundedLineReader({
+			maxPendingLineBytes: 64,
+			oversizedLineProjector: PI_AGGREGATE_EVENT_PROJECTOR,
+			onLine: () => assert.fail("invalid agent_end must not emit"),
+			onLimit: (limit) => { failure = limit; },
+		});
+		reader.push(`{"type":"agent_end","messages":[${"x".repeat(256)}],"willRetry":true}\n`);
+		reader.end();
+		assert.equal(reader.exceeded(), true);
+		assert.equal(failure?.code, "protocol_output_limit");
+	});
+
+	it("uses only trustworthy top-level lifecycle fields in syntactically valid JSON", () => {
+		for (const aggregate of [
+			JSON.stringify({ type: "agent_end", messages: [{ willRetry: true, data: "x".repeat(256) }] }),
+			`{"type":"agent_end","messages":["${"x".repeat(256)}"],"willRetry":"false"}`,
+			`{"type":"turn_end","toolResults":["${"x".repeat(256)}"],"t\\u0079pe":"other"}`,
+			`{"type":"turn_end","toolResults":["${"x".repeat(256)}",]}`,
+		]) {
+			const reader = createBoundedLineReader({
+				maxPendingLineBytes: 64,
+				oversizedLineProjector: PI_AGGREGATE_EVENT_PROJECTOR,
+				onLine: () => assert.fail("untrustworthy lifecycle metadata must not emit"),
+				onLimit: () => {},
+			});
+			reader.push(`${aggregate}\n`);
+			reader.end();
+			assert.equal(reader.exceeded(), true);
+		}
+	});
+
 	it("stops buffering an oversized line and returns bounded diagnostics", () => {
 		let failure: ProtocolOutputLimit | undefined;
 		const reader = createBoundedLineReader({ maxPendingLineBytes: 8, onLine: () => assert.fail("oversized line must not emit"), onLimit: (limit) => { failure = limit; } });

package/dist/extensions/pi-subagents/test/unit/child-transcript.test.ts

@@ -21,7 +21,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-1",
-			agent: "worker",
+			agent: "builder",
 			childIndex: 0,
 			cwd: "/repo",
 		});
@@ -35,7 +35,7 @@ describe("createChildTranscriptWriter", () => {
 		assert.equal(record.recordType, "message");
 		assert.equal(record.source, "foreground");
 		assert.equal(record.runId, "run-1");
-		assert.equal(record.agent, "worker");
+		assert.equal(record.agent, "builder");
 		assert.equal(record.childIndex, 0);
 		assert.equal(record.cwd, "/repo");
 		assert.equal(record.sourceEventType, "initial_prompt");
@@ -52,7 +52,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "async",
 			runId: "run-2",
-			agent: "reviewer",
+			agent: "commentator",
 			cwd: "/repo",
 		});
 		writer.writeInitialUserMessage("review it");
@@ -68,7 +68,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "async",
 			runId: "run-3",
-			agent: "worker",
+			agent: "builder",
 			childIndex: 1,
 			cwd: "/repo",
 		});
@@ -119,7 +119,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-4",
-			agent: "worker",
+			agent: "builder",
 			cwd: "/repo",
 		});
 		writer.writeChildEvent({ type: "tool_execution_start", toolCallId: "call-1", toolName: "bash", args: { command: "ls" } });
@@ -152,7 +152,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-bounded",
-			agent: "worker",
+			agent: "builder",
 			cwd: "/repo",
 		});
 		writer.writeChildEvent({ type: "tool_execution_start", toolCallId: "large", toolName: "bash", args: { command: "🧪".repeat(10_000) } });
@@ -178,7 +178,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "async",
 			runId: "run-5",
-			agent: "worker",
+			agent: "builder",
 			cwd: "/repo",
 		});
 		writer.writeStdoutLine("first line");
@@ -202,7 +202,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-6",
-			agent: "worker",
+			agent: "builder",
 			cwd: "/repo",
 			maxBytes: 900,
 		});
@@ -254,7 +254,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-7",
-			agent: "worker",
+			agent: "builder",
 			cwd: "/repo",
 		});
 		writer.writeInitialUserMessage("should not be written");

package/dist/extensions/pi-subagents/test/unit/compaction-resume.test.ts

@@ -0,0 +1,41 @@
+import assert from "node:assert/strict";
+import { execFileSync } from "node:child_process";
+import { fileURLToPath } from "node:url";
+import path from "node:path";
+import { describe, it } from "node:test";
+
+const projectRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..", "..");
+
+describe("async compaction resume", () => {
+	it("continues an interactive parent after compaction while async work is active", () => {
+		const script = String.raw`
+			import os from "node:os";
+			import path from "node:path";
+			import registerSubagentExtension from "./index.ts";
+			const handlers = new Map();
+			const events = { listeners: new Map(), on(name, handler) { this.listeners.set(name, handler); return () => this.listeners.delete(name); }, emit(name, payload) { this.listeners.get(name)?.(payload); } };
+			const sent = [];
+			const pi = new Proxy({
+				events,
+				on(name, handler) { handlers.set(name, handler); },
+				registerTool() {}, registerCommand() {}, registerShortcut() {}, registerMessageRenderer() {},
+				sendMessage(message, options) { sent.push({ message, options }); }, getSessionName() { return undefined; },
+			}, { get(target, prop) { return prop in target ? target[prop] : () => undefined; } });
+			const ctx = { cwd: process.cwd(), hasUI: true, ui: { setWidget() {}, requestRender() {}, theme: { fg(_name, text) { return text; }, bg(_name, text) { return text; }, bold(text) { return text; } } }, sessionManager: { getSessionId() { return "compact-session"; }, getSessionFile() { return null; }, getEntries() { return []; } }, modelRegistry: { getAvailable() { return []; } } };
+			registerSubagentExtension(pi);
+			handlers.get("session_start")({}, ctx);
+			sent.length = 0;
+			events.emit("subagent:async-started", { id: "running", pid: 1, sessionId: "compact-session", mode: "single", agent: "builder", asyncDir: path.join(os.tmpdir(), "pi-compaction-test-running") });
+			handlers.get("session_compact")();
+			if (sent.length !== 1 || sent[0].options?.triggerTurn !== true || sent[0].message?.customType !== "subagent-compaction-resume") throw new Error(JSON.stringify(sent));
+			sent.length = 0;
+			events.emit("subagent:async-complete", { id: "running", sessionId: "compact-session", agent: "builder", success: true, summary: "done" });
+			handlers.get("session_compact")();
+			if (sent.some((entry) => entry.message?.customType === "subagent-compaction-resume")) throw new Error("resumed without active work");
+		`;
+		const env = { ...process.env };
+		delete env.SELESAI_SUBAGENT_CHILD;
+		execFileSync(process.execPath, ["--experimental-strip-types", "--import", "./test/support/register-loader.mjs", "--input-type=module", "--eval", script], { cwd: projectRoot, env, stdio: "pipe" });
+		assert.ok(true);
+	});
+});

package/dist/extensions/pi-subagents/test/unit/completion-dedupe.test.ts

@@ -11,8 +11,8 @@ describe("buildCompletionKey", () => {
 	});
 
 	it("builds deterministic fallback key when id is missing", () => {
-		const first = buildCompletionKey({ agent: "reviewer", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
-		const second = buildCompletionKey({ agent: "reviewer", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
+		const first = buildCompletionKey({ agent: "commentator", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
+		const second = buildCompletionKey({ agent: "commentator", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
 		assert.equal(first, second);
 	});
 });

package/dist/extensions/pi-subagents/test/unit/completion-guard.test.ts

@@ -56,7 +56,7 @@ test("declared read-only builtin tools suppress implementation-word false positi
 test("read-only issue drafting tasks do not trigger on suggested fix wording", () => {
 	const task = "Draft GitHub issue for pi-subagents bug from current conversation. Include title, environment/context, reproduction steps, actual/expected, logs excerpt, suspected cause, suggested fix. Terse but complete. No tools needed.";
 	const result = evaluateCompletionMutationGuard({
-		agent: "delegate",
+		agent: "explorer",
 		task,
 		messages: [assistantText("Title: completionGuard false positive\n\nSuggested fix: model read-only intent.")],
 		tools: ["read", "grep", "find", "ls", "bash", "edit", "write", "contact_supervisor"],
@@ -144,7 +144,7 @@ test("review-only, research, and framework output instructions do not expect mut
 });
 
 test("builder implementation verbs win over investigative wording and scoped prohibitions", () => {
-	assert.equal(expectsImplementationMutation("builder", "Investigate why the worker did not edit files and fix it"), true);
+	assert.equal(expectsImplementationMutation("builder", "Investigate why the builder did not edit files and fix it"), true);
 	assert.equal(expectsImplementationMutation("builder", "Do not modify tests; implement the fix"), true);
 	assert.equal(expectsImplementationMutation("builder", "Do not modify tests — implement the fix"), true);
 	assert.equal(expectsImplementationMutation("builder", "Research the current code path and patch the bug"), true);
@@ -158,9 +158,9 @@ test("builder implementation verbs win over investigative wording and scoped pro
 	assert.equal(expectsImplementationMutation("builder", "Implement the fix and return findings."), true);
 });
 
-test("non-worker implementation tasks still expect mutation", () => {
-	assert.equal(expectsImplementationMutation("delegate", "Fix the bug where no edits were made"), true);
-	assert.equal(expectsImplementationMutation("delegate", "Apply the suggested fix to src/runs/shared/completion-guard.ts"), true);
+test("non-builder implementation tasks still expect mutation", () => {
+	assert.equal(expectsImplementationMutation("explorer", "Fix the bug where no edits were made"), true);
+	assert.equal(expectsImplementationMutation("explorer", "Apply the suggested fix to src/runs/shared/completion-guard.ts"), true);
 	assert.equal(expectsImplementationMutation("builder", "Draft a GitHub issue, then implement the fix"), true);
 });
 
@@ -193,6 +193,36 @@ test("obvious mutating bash commands count as mutation attempts", () => {
 	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: "patch -p0 < fix.patch" })]), true);
 });
 
+test("git publication commands count as mutation attempts", () => {
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: "git add src/file.ts" })]), true);
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: "git commit -m 'fix: finish change'" })]), true);
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: "git push origin HEAD" })]), true);
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: "git -C /tmp/project add src/file.ts" })]), true);
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: 'git -C "/tmp/project with space" add src/file.ts' })]), true);
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: 'git -C "$WORKTREE" commit -m fix' })]), true);
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: "git --paginate push" })]), true);
+	assert.equal(hasMutationToolCall([assistantToolCall("bash", { command: "git diff --check && git add src/file.ts && git commit -m fix && git push" })]), true);
+});
+
+test("read-only and quoted git commands do not count as mutation attempts", () => {
+	for (const command of [
+		"git status --short",
+		"git diff --check",
+		"git log -1 --oneline",
+		"git show --stat HEAD",
+		"git ls-remote origin main",
+		"git --help add",
+		"git --version add",
+		"git -h commit",
+		"gh pr view 749",
+		"echo 'git add src/file.ts'",
+		'printf "git commit -m fix"',
+		"echo 'then git push origin HEAD'",
+	]) {
+		assert.equal(hasMutationToolCall([assistantToolCall("bash", { command })]), false, command);
+	}
+});
+
 test("implementation task with mutation attempts does not trigger", () => {
 	const result = evaluateCompletionMutationGuard({
 		agent: "builder",

package/dist/extensions/pi-subagents/test/unit/config-dir-runtime.test.ts

@@ -4,6 +4,7 @@ import os from "node:os";
 import path from "node:path";
 import { afterEach, beforeEach, describe, it } from "node:test";
 import { fileURLToPath } from "node:url";
+import { resolveAsyncByDefault } from "../../src/extension/config.ts";
 import { getConfigDirName, SELESAI_CODING_AGENT_PACKAGE_ROOT_ENV, resolveConfigDirName, resolveWatchPath } from "../../src/shared/utils.ts";
 
 const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../..");
@@ -88,6 +89,12 @@ describe("config directory resolution", () => {
 		}
 	});
 
+	it("resolves async launches as the default unless explicitly disabled", () => {
+		assert.equal(resolveAsyncByDefault({}), true);
+		assert.equal(resolveAsyncByDefault({ asyncByDefault: true }), true);
+		assert.equal(resolveAsyncByDefault({ asyncByDefault: false }), false);
+	});
+
 	it("canonicalizes watcher paths and preserves the original path when native realpath fails", () => {
 		assert.equal(resolveWatchPath("C:\\SHORT~1\\watch", () => "C:\\Long Path\\watch"), "C:\\Long Path\\watch");
 		assert.equal(resolveWatchPath("C:\\SHORT~1\\watch", () => { throw new Error("missing"); }), "C:\\SHORT~1\\watch");