@selesai/code 0.5.28 → 0.6.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +24 -0
- package/README.md +1 -1
- package/dist/cli/args.d.ts.map +1 -1
- package/dist/cli/args.js +9 -1
- package/dist/cli/args.js.map +1 -1
- package/dist/cli/config-selector.d.ts.map +1 -1
- package/dist/cli/config-selector.js +1 -1
- package/dist/cli/config-selector.js.map +1 -1
- package/dist/cli/credential-print.d.ts +23 -0
- package/dist/cli/credential-print.d.ts.map +1 -0
- package/dist/cli/credential-print.js +117 -0
- package/dist/cli/credential-print.js.map +1 -0
- package/dist/cli/startup-ui.d.ts.map +1 -1
- package/dist/cli/startup-ui.js +1 -1
- package/dist/cli/startup-ui.js.map +1 -1
- package/dist/core/agent-session-runtime.d.ts.map +1 -1
- package/dist/core/agent-session-runtime.js +3 -0
- package/dist/core/agent-session-runtime.js.map +1 -1
- package/dist/core/agent-session.d.ts +12 -1
- package/dist/core/agent-session.d.ts.map +1 -1
- package/dist/core/agent-session.js +20 -14
- package/dist/core/agent-session.js.map +1 -1
- package/dist/core/compaction/compaction.d.ts.map +1 -1
- package/dist/core/compaction/compaction.js +11 -3
- package/dist/core/compaction/compaction.js.map +1 -1
- package/dist/core/extensions/runner.d.ts +1 -0
- package/dist/core/extensions/runner.d.ts.map +1 -1
- package/dist/core/extensions/runner.js +11 -0
- package/dist/core/extensions/runner.js.map +1 -1
- package/dist/core/extensions/types.d.ts +14 -1
- package/dist/core/extensions/types.d.ts.map +1 -1
- package/dist/core/extensions/types.js.map +1 -1
- package/dist/core/footer-data-provider.d.ts +10 -0
- package/dist/core/footer-data-provider.d.ts.map +1 -1
- package/dist/core/footer-data-provider.js +1 -1
- package/dist/core/footer-data-provider.js.map +1 -1
- package/dist/core/llama/provider.d.ts.map +1 -1
- package/dist/core/llama/provider.js +8 -3
- package/dist/core/llama/provider.js.map +1 -1
- package/dist/core/model-config.d.ts +30 -0
- package/dist/core/model-config.d.ts.map +1 -1
- package/dist/core/model-config.js +6 -0
- package/dist/core/model-config.js.map +1 -1
- package/dist/core/model-registry.d.ts.map +1 -1
- package/dist/core/model-registry.js +2 -2
- package/dist/core/model-registry.js.map +1 -1
- package/dist/core/model-resolver.d.ts +1 -0
- package/dist/core/model-resolver.d.ts.map +1 -1
- package/dist/core/model-resolver.js +20 -3
- package/dist/core/model-resolver.js.map +1 -1
- package/dist/core/model-runtime.d.ts +2 -0
- package/dist/core/model-runtime.d.ts.map +1 -1
- package/dist/core/model-runtime.js +5 -4
- package/dist/core/model-runtime.js.map +1 -1
- package/dist/core/package-manager.d.ts.map +1 -1
- package/dist/core/package-manager.js +13 -6
- package/dist/core/package-manager.js.map +1 -1
- package/dist/core/remote-catalog-provider.d.ts +1 -1
- package/dist/core/remote-catalog-provider.d.ts.map +1 -1
- package/dist/core/remote-catalog-provider.js +24 -11
- package/dist/core/remote-catalog-provider.js.map +1 -1
- package/dist/core/resource-loader.d.ts +15 -0
- package/dist/core/resource-loader.d.ts.map +1 -1
- package/dist/core/resource-loader.js +66 -9
- package/dist/core/resource-loader.js.map +1 -1
- package/dist/core/settings-manager.d.ts +1 -1
- package/dist/core/settings-manager.d.ts.map +1 -1
- package/dist/core/settings-manager.js.map +1 -1
- package/dist/core/system-prompt.d.ts.map +1 -1
- package/dist/core/system-prompt.js +19 -1
- package/dist/core/system-prompt.js.map +1 -1
- package/dist/core/system-prompt.test.d.ts +2 -0
- package/dist/core/system-prompt.test.d.ts.map +1 -0
- package/dist/core/system-prompt.test.js +89 -0
- package/dist/core/system-prompt.test.js.map +1 -0
- package/dist/core/tools/bash.d.ts +2 -0
- package/dist/core/tools/bash.d.ts.map +1 -1
- package/dist/core/tools/bash.js +34 -5
- package/dist/core/tools/bash.js.map +1 -1
- package/dist/core/tools/tool-definition-wrapper.d.ts.map +1 -1
- package/dist/core/tools/tool-definition-wrapper.js +3 -1
- package/dist/core/tools/tool-definition-wrapper.js.map +1 -1
- package/dist/defaults/models.json +13 -45
- package/dist/defaults/settings.json +1 -2
- package/dist/extensions/copy-turn.test.ts +131 -0
- package/dist/extensions/copy-turn.ts +6 -1
- package/dist/extensions/package.json +0 -1
- package/dist/extensions/pi-intercom/CHANGELOG.md +249 -0
- package/dist/extensions/pi-intercom/README.md +102 -39
- package/dist/extensions/pi-intercom/broker/broker.ts +1233 -36
- package/dist/extensions/pi-intercom/broker/client.test.ts +83 -0
- package/dist/extensions/pi-intercom/broker/client.ts +315 -12
- package/dist/extensions/pi-intercom/broker/extension-state.ts +186 -0
- package/dist/extensions/pi-intercom/broker/extension.test.ts +387 -0
- package/dist/extensions/pi-intercom/broker/framing.test.ts +114 -0
- package/dist/extensions/pi-intercom/broker/framing.ts +82 -24
- package/dist/extensions/pi-intercom/broker/paths.test.ts +153 -0
- package/dist/extensions/pi-intercom/broker/paths.ts +117 -8
- package/dist/extensions/pi-intercom/broker/runtime-claim.test.ts +34 -0
- package/dist/extensions/pi-intercom/broker/runtime-claim.ts +21 -0
- package/dist/extensions/pi-intercom/broker/spawn.test.ts +160 -23
- package/dist/extensions/pi-intercom/broker/spawn.ts +113 -27
- package/dist/extensions/pi-intercom/config.test.ts +93 -0
- package/dist/extensions/pi-intercom/config.ts +55 -6
- package/dist/extensions/pi-intercom/cwd.test.ts +40 -0
- package/dist/extensions/pi-intercom/cwd.ts +31 -0
- package/dist/extensions/pi-intercom/extension-api.ts +44 -0
- package/dist/extensions/pi-intercom/format-context.test.ts +31 -0
- package/dist/extensions/pi-intercom/format-context.ts +32 -0
- package/dist/extensions/pi-intercom/index.ts +742 -145
- package/dist/extensions/pi-intercom/intercom.integration.test.ts +2646 -0
- package/dist/extensions/pi-intercom/package.json +15 -5
- package/dist/extensions/pi-intercom/reply-tracker.test.ts +134 -0
- package/dist/extensions/pi-intercom/reply-tracker.ts +31 -13
- package/dist/extensions/pi-intercom/skills/pi-intercom/SKILL.md +13 -11
- package/dist/extensions/pi-intercom/test/inline-message.test.ts +184 -0
- package/dist/extensions/pi-intercom/test/overlay-width.test.ts +66 -0
- package/dist/extensions/pi-intercom/types.ts +94 -4
- package/dist/extensions/pi-intercom/ui/compose.ts +8 -4
- package/dist/extensions/pi-intercom/ui/inline-message.ts +61 -25
- package/dist/extensions/pi-intercom/ui/session-list.ts +7 -3
- package/dist/extensions/pi-subagents/CHANGELOG.md +88 -0
- package/dist/extensions/pi-subagents/LICENSE +21 -0
- package/dist/extensions/pi-subagents/README.md +158 -69
- package/dist/extensions/pi-subagents/agents/architect.md +5 -4
- package/dist/extensions/pi-subagents/agents/builder.md +6 -4
- package/dist/extensions/pi-subagents/agents/commentator.md +3 -2
- package/dist/extensions/pi-subagents/agents/explorer.md +3 -2
- package/dist/extensions/pi-subagents/agents/recapper.md +3 -2
- package/dist/extensions/pi-subagents/agents/researcher.md +4 -3
- package/dist/extensions/pi-subagents/package-lock.json +2 -2
- package/dist/extensions/pi-subagents/package.json +3 -3
- package/dist/extensions/pi-subagents/prompts/review-loop.md +1 -1
- package/dist/extensions/pi-subagents/skills/pi-subagents/SKILL.md +22 -988
- package/dist/extensions/pi-subagents/skills/pi-subagents/references/constraints-and-recipes.md +257 -0
- package/dist/extensions/pi-subagents/skills/pi-subagents/references/execution-controls.md +431 -0
- package/dist/extensions/pi-subagents/skills/pi-subagents/references/management-authoring-rpc.md +144 -0
- package/dist/extensions/pi-subagents/skills/pi-subagents/references/prompting-and-roles.md +281 -0
- package/dist/extensions/pi-subagents/src/agents/agent-management.ts +125 -37
- package/dist/extensions/pi-subagents/src/agents/agent-serializer.ts +4 -0
- package/dist/extensions/pi-subagents/src/agents/agents.ts +118 -9
- package/dist/extensions/pi-subagents/src/agents/skills.ts +14 -12
- package/dist/extensions/pi-subagents/src/agents/task-aware-routing.ts +125 -0
- package/dist/extensions/pi-subagents/src/api/delegation.ts +3 -0
- package/dist/extensions/pi-subagents/src/api/preflight.ts +17 -13
- package/dist/extensions/pi-subagents/src/extension/chain-validation.ts +17 -1
- package/dist/extensions/pi-subagents/src/extension/index.ts +22 -8
- package/dist/extensions/pi-subagents/src/extension/rpc.ts +248 -6
- package/dist/extensions/pi-subagents/src/extension/schemas.ts +33 -8
- package/dist/extensions/pi-subagents/src/extension/tool-description.ts +32 -14
- package/dist/extensions/pi-subagents/src/intercom/intercom-bridge.ts +9 -4
- package/dist/extensions/pi-subagents/src/intercom/result-intercom.ts +33 -4
- package/dist/extensions/pi-subagents/src/runs/background/async-execution.ts +86 -21
- package/dist/extensions/pi-subagents/src/runs/background/async-job-tracker.ts +24 -13
- package/dist/extensions/pi-subagents/src/runs/background/async-resume.ts +7 -5
- package/dist/extensions/pi-subagents/src/runs/background/async-status.ts +18 -2
- package/dist/extensions/pi-subagents/src/runs/background/chain-append.ts +48 -5
- package/dist/extensions/pi-subagents/src/runs/background/control-channel.ts +68 -1
- package/dist/extensions/pi-subagents/src/runs/background/notify.ts +56 -5
- package/dist/extensions/pi-subagents/src/runs/background/result-watcher.ts +92 -11
- package/dist/extensions/pi-subagents/src/runs/background/run-status.ts +29 -3
- package/dist/extensions/pi-subagents/src/runs/background/subagent-runner.ts +388 -29
- package/dist/extensions/pi-subagents/src/runs/foreground/async-stop-action.ts +65 -0
- package/dist/extensions/pi-subagents/src/runs/foreground/chain-clarify.ts +3 -3
- package/dist/extensions/pi-subagents/src/runs/foreground/chain-execution.ts +214 -60
- package/dist/extensions/pi-subagents/src/runs/foreground/execution.ts +546 -252
- package/dist/extensions/pi-subagents/src/runs/foreground/foreground-control.ts +42 -0
- package/dist/extensions/pi-subagents/src/runs/foreground/subagent-executor.ts +553 -154
- package/dist/extensions/pi-subagents/src/runs/shared/acceptance.ts +19 -13
- package/dist/extensions/pi-subagents/src/runs/shared/capability-ceiling.ts +51 -19
- package/dist/extensions/pi-subagents/src/runs/shared/chain-outputs.ts +3 -1
- package/dist/extensions/pi-subagents/src/runs/shared/dynamic-fanout.ts +1 -1
- package/dist/extensions/pi-subagents/src/runs/shared/mcp-direct-tool-allowlist.ts +44 -11
- package/dist/extensions/pi-subagents/src/runs/shared/model-fallback.ts +8 -0
- package/dist/extensions/pi-subagents/src/runs/shared/nested-events.ts +97 -20
- package/dist/extensions/pi-subagents/src/runs/shared/parallel-utils.ts +43 -12
- package/dist/extensions/pi-subagents/src/runs/shared/pi-args.ts +52 -4
- package/dist/extensions/pi-subagents/src/runs/shared/process-signal.ts +19 -0
- package/dist/extensions/pi-subagents/src/runs/shared/run-history.ts +45 -9
- package/dist/extensions/pi-subagents/src/runs/shared/runtime-acknowledged-extensions.ts +71 -0
- package/dist/extensions/pi-subagents/src/runs/shared/single-output.ts +63 -9
- package/dist/extensions/pi-subagents/src/runs/shared/subagent-prompt-runtime.ts +31 -1
- package/dist/extensions/pi-subagents/src/runs/shared/subagent-startup-retry.ts +101 -0
- package/dist/extensions/pi-subagents/src/runs/shared/task-intent.ts +22 -1
- package/dist/extensions/pi-subagents/src/runs/shared/usage-budget.ts +65 -0
- package/dist/extensions/pi-subagents/src/runs/shared/workflow-graph.ts +26 -1
- package/dist/extensions/pi-subagents/src/shared/settings.ts +17 -1
- package/dist/extensions/pi-subagents/src/shared/types.ts +196 -12
- package/dist/extensions/pi-subagents/src/shared/utils.ts +102 -5
- package/dist/extensions/pi-subagents/src/slash/delegation-adapters.ts +10 -1
- package/dist/extensions/pi-subagents/src/slash/slash-commands.ts +46 -4
- package/dist/extensions/pi-subagents/src/slash/slash-live-state.ts +5 -3
- package/dist/extensions/pi-subagents/src/tui/fleet-status.ts +87 -24
- package/dist/extensions/pi-subagents/src/tui/fleet.ts +182 -9
- package/dist/extensions/pi-subagents/src/tui/render.ts +55 -34
- package/dist/extensions/pi-subagents/src/watchdog/register-main.ts +14 -7
- package/dist/extensions/pi-subagents/src/watchdog/review.ts +5 -4
- package/dist/extensions/pi-subagents/src/watchdog/runtime.ts +170 -17
- package/dist/extensions/pi-subagents/src/watchdog/scope.ts +62 -0
- package/dist/extensions/pi-subagents/src/watchdog/settings.ts +41 -1
- package/dist/extensions/pi-subagents/src/watchdog/types.ts +10 -0
- package/dist/extensions/pi-subagents/test/e2e/real-session-subagent.test.ts +113 -8
- package/dist/extensions/pi-subagents/test/integration/async-execution.test.ts +419 -47
- package/dist/extensions/pi-subagents/test/integration/async-job-tracker.test.ts +84 -0
- package/dist/extensions/pi-subagents/test/integration/async-status.test.ts +4 -2
- package/dist/extensions/pi-subagents/test/integration/chain-clarify.test.ts +51 -2
- package/dist/extensions/pi-subagents/test/integration/chain-execution.test.ts +62 -22
- package/dist/extensions/pi-subagents/test/integration/detect-error.test.ts +48 -0
- package/dist/extensions/pi-subagents/test/integration/fork-context-execution.test.ts +8 -6
- package/dist/extensions/pi-subagents/test/integration/intercom-result-delivery.test.ts +231 -19
- package/dist/extensions/pi-subagents/test/integration/parallel-execution.test.ts +48 -7
- package/dist/extensions/pi-subagents/test/integration/render-fork-badge.test.ts +44 -0
- package/dist/extensions/pi-subagents/test/integration/result-watcher.test.ts +199 -17
- package/dist/extensions/pi-subagents/test/integration/single-execution.test.ts +898 -16
- package/dist/extensions/pi-subagents/test/integration/slash-commands.test.ts +112 -23
- package/dist/extensions/pi-subagents/test/support/mock-pi-script.mjs +17 -5
- package/dist/extensions/pi-subagents/test/support/mock-pi.ts +2 -0
- package/dist/extensions/pi-subagents/test/support/real-session-runner.ts +18 -2
- package/dist/extensions/pi-subagents/test/support/register-loader.mjs +3 -3
- package/dist/extensions/pi-subagents/test/unit/acceptance.test.ts +3 -1
- package/dist/extensions/pi-subagents/test/unit/agent-disabled.test.ts +1 -1
- package/dist/extensions/pi-subagents/test/unit/agent-frontmatter.test.ts +198 -6
- package/dist/extensions/pi-subagents/test/unit/agent-management.test.ts +161 -1
- package/dist/extensions/pi-subagents/test/unit/agent-overrides.test.ts +47 -2
- package/dist/extensions/pi-subagents/test/unit/async-recovery-descriptor.test.ts +60 -0
- package/dist/extensions/pi-subagents/test/unit/async-resume.test.ts +8 -0
- package/dist/extensions/pi-subagents/test/unit/builtin-agent-documentation.test.ts +63 -0
- package/dist/extensions/pi-subagents/test/unit/capability-ceiling-agent-allowlist.test.ts +136 -0
- package/dist/extensions/pi-subagents/test/unit/capability-ceiling.test.ts +1 -1
- package/dist/extensions/pi-subagents/test/unit/chain-append.test.ts +6 -0
- package/dist/extensions/pi-subagents/test/unit/chain-validation.test.ts +1 -1
- package/dist/extensions/pi-subagents/test/unit/completion-guard.test.ts +48 -48
- package/dist/extensions/pi-subagents/test/unit/config-dir-runtime.test.ts +23 -0
- package/dist/extensions/pi-subagents/test/unit/control-channel.test.ts +27 -0
- package/dist/extensions/pi-subagents/test/unit/delegation-api.test.ts +28 -2
- package/dist/extensions/pi-subagents/test/unit/dynamic-fanout.test.ts +1 -0
- package/dist/extensions/pi-subagents/test/unit/fleet-status.test.ts +176 -8
- package/dist/extensions/pi-subagents/test/unit/fleet.test.ts +164 -5
- package/dist/extensions/pi-subagents/test/unit/foreground-control.test.ts +41 -1
- package/dist/extensions/pi-subagents/test/unit/index-child-registration.test.ts +17 -12
- package/dist/extensions/pi-subagents/test/unit/intercom-bridge.test.ts +18 -2
- package/dist/extensions/pi-subagents/test/unit/nested-control.test.ts +20 -1
- package/dist/extensions/pi-subagents/test/unit/nested-events.test.ts +30 -2
- package/dist/extensions/pi-subagents/test/unit/notify.test.ts +39 -2
- package/dist/extensions/pi-subagents/test/unit/parallel-utils.test.ts +22 -0
- package/dist/extensions/pi-subagents/test/unit/pi-args.test.ts +103 -0
- package/dist/extensions/pi-subagents/test/unit/pi-coding-agent-dir.test.ts +18 -0
- package/dist/extensions/pi-subagents/test/unit/preflight.test.ts +48 -0
- package/dist/extensions/pi-subagents/test/unit/render-helpers.test.ts +13 -1
- package/dist/extensions/pi-subagents/test/unit/result-intercom.test.ts +29 -4
- package/dist/extensions/pi-subagents/test/unit/rpc.test.ts +223 -4
- package/dist/extensions/pi-subagents/test/unit/run-status.test.ts +30 -0
- package/dist/extensions/pi-subagents/test/unit/runtime-acknowledged-extensions.test.ts +52 -0
- package/dist/extensions/pi-subagents/test/unit/schemas.test.ts +46 -2
- package/dist/extensions/pi-subagents/test/unit/single-output.test.ts +91 -1
- package/dist/extensions/pi-subagents/test/unit/skills-fallback.test.ts +1 -1
- package/dist/extensions/pi-subagents/test/unit/steering-action.test.ts +1 -1
- package/dist/extensions/pi-subagents/test/unit/streamed-progress-bounds.test.ts +78 -0
- package/dist/extensions/pi-subagents/test/unit/subagent-prompt-runtime.test.ts +41 -0
- package/dist/extensions/pi-subagents/test/unit/subagent-startup-retry.test.ts +77 -0
- package/dist/extensions/pi-subagents/test/unit/task-aware-routing.test.ts +213 -0
- package/dist/extensions/pi-subagents/test/unit/task-intent.test.ts +26 -1
- package/dist/extensions/pi-subagents/test/unit/tool-description.test.ts +61 -10
- package/dist/extensions/pi-subagents/test/unit/total-cost.test.ts +1 -0
- package/dist/extensions/pi-subagents/test/unit/watchdog-runtime.test.ts +210 -1
- package/dist/extensions/pi-subagents/test/unit/watchdog-scope.test.ts +33 -0
- package/dist/extensions/pi-subagents/test/unit/watchdog-settings.test.ts +32 -0
- package/dist/extensions/pi-subagents/test/unit/writer-budget-guidance.test.ts +1 -1
- package/dist/main.d.ts.map +1 -1
- package/dist/main.js +43 -0
- package/dist/main.js.map +1 -1
- package/dist/modes/interactive/components/custom-message.d.ts +3 -1
- package/dist/modes/interactive/components/custom-message.d.ts.map +1 -1
- package/dist/modes/interactive/components/custom-message.js +10 -2
- package/dist/modes/interactive/components/custom-message.js.map +1 -1
- package/dist/modes/interactive/components/extension-editor.d.ts +1 -2
- package/dist/modes/interactive/components/extension-editor.d.ts.map +1 -1
- package/dist/modes/interactive/components/extension-editor.js +16 -46
- package/dist/modes/interactive/components/extension-editor.js.map +1 -1
- package/dist/modes/interactive/components/model-selector.d.ts.map +1 -1
- package/dist/modes/interactive/components/model-selector.js +4 -1
- package/dist/modes/interactive/components/model-selector.js.map +1 -1
- package/dist/modes/interactive/components/scoped-models-selector.d.ts.map +1 -1
- package/dist/modes/interactive/components/scoped-models-selector.js +22 -13
- package/dist/modes/interactive/components/scoped-models-selector.js.map +1 -1
- package/dist/modes/interactive/external-editor.d.ts +12 -0
- package/dist/modes/interactive/external-editor.d.ts.map +1 -0
- package/dist/modes/interactive/external-editor.js +37 -0
- package/dist/modes/interactive/external-editor.js.map +1 -0
- package/dist/modes/interactive/interactive-mode.d.ts +1 -1
- package/dist/modes/interactive/interactive-mode.d.ts.map +1 -1
- package/dist/modes/interactive/interactive-mode.js +72 -64
- package/dist/modes/interactive/interactive-mode.js.map +1 -1
- package/dist/modes/rpc/rpc-mode.d.ts.map +1 -1
- package/dist/modes/rpc/rpc-mode.js +14 -0
- package/dist/modes/rpc/rpc-mode.js.map +1 -1
- package/dist/skills/ponytail/SKILL.md +1 -3
- package/dist/utils/clipboard.d.ts.map +1 -1
- package/dist/utils/clipboard.js +19 -8
- package/dist/utils/clipboard.js.map +1 -1
- package/dist/utils/version-check.d.ts.map +1 -1
- package/dist/utils/version-check.js +1 -1
- package/dist/utils/version-check.js.map +1 -1
- package/docs/compaction.md +1 -1
- package/docs/custom-provider.md +14 -5
- package/docs/environment-variables.md +86 -0
- package/docs/extensions.md +15 -5
- package/docs/index.md +1 -0
- package/docs/models.md +9 -2
- package/docs/plans/subagent-delegation/phase-0-correctness.md +265 -0
- package/docs/plans/subagent-delegation/phase-1-behavioral-contract.md +486 -0
- package/docs/plans/subagent-delegation/phase-2-context-controls.md +282 -0
- package/docs/plans/subagent-delegation/phase-3-advisory-routing.md +362 -0
- package/docs/plans/subagent-delegation/phase-4-optional-enforcement.md +381 -0
- package/docs/providers.md +21 -2
- package/docs/rpc.md +23 -6
- package/docs/session-format.md +2 -0
- package/docs/settings.md +1 -1
- package/docs/usage.md +0 -13
- package/examples/extensions/custom-compaction.ts +5 -2
- package/examples/extensions/custom-provider-anthropic/index.ts +9 -3
- package/examples/extensions/custom-provider-anthropic/package-lock.json +2 -2
- package/examples/extensions/custom-provider-anthropic/package.json +1 -1
- package/examples/extensions/custom-provider-gitlab-duo/package.json +1 -1
- package/examples/extensions/gondolin/package-lock.json +2 -2
- package/examples/extensions/gondolin/package.json +1 -1
- package/examples/extensions/handoff.ts +11 -3
- package/examples/extensions/message-renderer.ts +3 -3
- package/examples/extensions/sandbox/package-lock.json +2 -2
- package/examples/extensions/sandbox/package.json +1 -1
- package/examples/extensions/summarize.ts +5 -2
- package/examples/extensions/with-deps/package-lock.json +2 -2
- package/examples/extensions/with-deps/package.json +1 -1
- package/examples/sdk/12-full-control.ts +3 -1
- package/package.json +16 -7
- package/dist/extensions/caveman/caveman-instructions.cjs +0 -11
- package/dist/extensions/caveman/index.js +0 -118
- package/dist/extensions/caveman/package.json +0 -8
- package/dist/extensions/caveman/test/extension.test.js +0 -203
- package/dist/extensions/caveman/test/helpers.test.js +0 -58
- package/dist/skills/caveman/SKILL.md +0 -50
|
@@ -0,0 +1,2646 @@
|
|
|
1
|
+
import test from "node:test";
|
|
2
|
+
import assert from "node:assert/strict";
|
|
3
|
+
import { mkdtempSync, rmSync } from "node:fs";
|
|
4
|
+
import path from "node:path";
|
|
5
|
+
import { tmpdir } from "node:os";
|
|
6
|
+
import { EventEmitter, once } from "node:events";
|
|
7
|
+
import { spawn, type ChildProcess } from "node:child_process";
|
|
8
|
+
import { ReplyTracker } from "./reply-tracker.ts";
|
|
9
|
+
import type { BrokerMessage, Message, SessionInfo } from "./types.ts";
|
|
10
|
+
import { INTERCOM_EXTENSION_REGISTER_EVENT, type IntercomExtensionChannel } from "./extension-api.ts";
|
|
11
|
+
|
|
12
|
+
const repoDir = process.cwd();
|
|
13
|
+
const childEnvKeys = [
|
|
14
|
+
"SELESAI_SUBAGENT_ORCHESTRATOR_TARGET",
|
|
15
|
+
"SELESAI_SUBAGENT_ORCHESTRATOR_SESSION_ID",
|
|
16
|
+
"PI_INTERCOM_SESSION_ID",
|
|
17
|
+
"PI_INTERCOM_NAME_POLL_MS",
|
|
18
|
+
"SELESAI_SUBAGENT_RUN_ID",
|
|
19
|
+
"SELESAI_SUBAGENT_CHILD_AGENT",
|
|
20
|
+
"SELESAI_SUBAGENT_CHILD_INDEX",
|
|
21
|
+
"SELESAI_SUBAGENT_INTERCOM_SESSION_NAME",
|
|
22
|
+
"SELESAI_SUBAGENT_SUPERVISOR_CHANNEL_DIR",
|
|
23
|
+
] as const;
|
|
24
|
+
const sharedHomeDir = mkdtempSync(path.join(tmpdir(), "pi-intercom-home-"));
|
|
25
|
+
const previousHome = process.env.HOME;
|
|
26
|
+
const previousUserProfile = process.env.USERPROFILE;
|
|
27
|
+
const previousAgentDir = process.env.SELESAI_CODING_AGENT_DIR;
|
|
28
|
+
process.env.HOME = sharedHomeDir;
|
|
29
|
+
process.env.USERPROFILE = sharedHomeDir;
|
|
30
|
+
process.env.SELESAI_CODING_AGENT_DIR = sharedHomeDir;
|
|
31
|
+
const { IntercomClient } = await import("./broker/client.ts");
|
|
32
|
+
const { getTsxCliPath } = await import("./broker/spawn.ts");
|
|
33
|
+
process.on("exit", () => {
|
|
34
|
+
if (previousHome === undefined) delete process.env.HOME;
|
|
35
|
+
else process.env.HOME = previousHome;
|
|
36
|
+
if (previousUserProfile === undefined) delete process.env.USERPROFILE;
|
|
37
|
+
else process.env.USERPROFILE = previousUserProfile;
|
|
38
|
+
if (previousAgentDir === undefined) delete process.env.SELESAI_CODING_AGENT_DIR;
|
|
39
|
+
else process.env.SELESAI_CODING_AGENT_DIR = previousAgentDir;
|
|
40
|
+
rmSync(sharedHomeDir, { recursive: true, force: true });
|
|
41
|
+
});
|
|
42
|
+
|
|
43
|
+
async function waitForBrokerReady(broker: ChildProcess): Promise<void> {
|
|
44
|
+
const stdout = broker.stdout;
|
|
45
|
+
if (!stdout) throw new Error("Broker stdout is unavailable");
|
|
46
|
+
|
|
47
|
+
const ready = new Promise<void>((resolve, reject) => {
|
|
48
|
+
const timeout = setTimeout(() => {
|
|
49
|
+
cleanup();
|
|
50
|
+
reject(new Error("Broker startup timed out"));
|
|
51
|
+
}, 10000);
|
|
52
|
+
const onStdout = (chunk: Buffer) => {
|
|
53
|
+
if (chunk.toString().includes("Intercom broker started")) {
|
|
54
|
+
cleanup();
|
|
55
|
+
resolve();
|
|
56
|
+
}
|
|
57
|
+
};
|
|
58
|
+
const onExit = (code: number | null, signal: NodeJS.Signals | null) => {
|
|
59
|
+
cleanup();
|
|
60
|
+
reject(new Error(`Broker exited before startup (code=${code}, signal=${signal})`));
|
|
61
|
+
};
|
|
62
|
+
const cleanup = () => {
|
|
63
|
+
clearTimeout(timeout);
|
|
64
|
+
stdout.off("data", onStdout);
|
|
65
|
+
broker.off("exit", onExit);
|
|
66
|
+
};
|
|
67
|
+
|
|
68
|
+
stdout.on("data", onStdout);
|
|
69
|
+
broker.once("exit", onExit);
|
|
70
|
+
});
|
|
71
|
+
|
|
72
|
+
await ready;
|
|
73
|
+
}
|
|
74
|
+
|
|
75
|
+
async function withChildOrchestratorEnv<T>(metadata: {
|
|
76
|
+
orchestratorTarget?: string;
|
|
77
|
+
orchestratorSessionId?: string;
|
|
78
|
+
inheritedIntercomSessionId?: string;
|
|
79
|
+
namePollMs?: string;
|
|
80
|
+
runId?: string;
|
|
81
|
+
agent?: string;
|
|
82
|
+
index?: string;
|
|
83
|
+
sessionName?: string;
|
|
84
|
+
supervisorChannelDir?: string;
|
|
85
|
+
}, fn: () => T | Promise<T>): Promise<T> {
|
|
86
|
+
const previous = new Map<string, string | undefined>();
|
|
87
|
+
for (const key of childEnvKeys) {
|
|
88
|
+
previous.set(key, process.env[key]);
|
|
89
|
+
delete process.env[key];
|
|
90
|
+
}
|
|
91
|
+
if (metadata.orchestratorTarget !== undefined) process.env.SELESAI_SUBAGENT_ORCHESTRATOR_TARGET = metadata.orchestratorTarget;
|
|
92
|
+
if (metadata.orchestratorSessionId !== undefined) process.env.SELESAI_SUBAGENT_ORCHESTRATOR_SESSION_ID = metadata.orchestratorSessionId;
|
|
93
|
+
if (metadata.inheritedIntercomSessionId !== undefined) process.env.PI_INTERCOM_SESSION_ID = metadata.inheritedIntercomSessionId;
|
|
94
|
+
if (metadata.namePollMs !== undefined) process.env.PI_INTERCOM_NAME_POLL_MS = metadata.namePollMs;
|
|
95
|
+
if (metadata.runId !== undefined) process.env.SELESAI_SUBAGENT_RUN_ID = metadata.runId;
|
|
96
|
+
if (metadata.agent !== undefined) process.env.SELESAI_SUBAGENT_CHILD_AGENT = metadata.agent;
|
|
97
|
+
if (metadata.index !== undefined) process.env.SELESAI_SUBAGENT_CHILD_INDEX = metadata.index;
|
|
98
|
+
if (metadata.sessionName !== undefined) process.env.SELESAI_SUBAGENT_INTERCOM_SESSION_NAME = metadata.sessionName;
|
|
99
|
+
if (metadata.supervisorChannelDir !== undefined) process.env.SELESAI_SUBAGENT_SUPERVISOR_CHANNEL_DIR = metadata.supervisorChannelDir;
|
|
100
|
+
try {
|
|
101
|
+
return await fn();
|
|
102
|
+
} finally {
|
|
103
|
+
for (const key of childEnvKeys) {
|
|
104
|
+
const value = previous.get(key);
|
|
105
|
+
if (value === undefined) delete process.env[key];
|
|
106
|
+
else process.env[key] = value;
|
|
107
|
+
}
|
|
108
|
+
}
|
|
109
|
+
}
|
|
110
|
+
|
|
111
|
+
interface CapturedToolResult {
|
|
112
|
+
content: Array<{ type: string; text: string }>;
|
|
113
|
+
details?: Record<string, unknown>;
|
|
114
|
+
}
|
|
115
|
+
|
|
116
|
+
interface RenderToolResult {
|
|
117
|
+
content: Array<{ type: string; text: string }>;
|
|
118
|
+
details?: Record<string, unknown>;
|
|
119
|
+
}
|
|
120
|
+
|
|
121
|
+
interface RenderedComponent {
|
|
122
|
+
render(width: number): string[];
|
|
123
|
+
}
|
|
124
|
+
|
|
125
|
+
interface RenderTheme {
|
|
126
|
+
fg(name: string, text: string): string;
|
|
127
|
+
bold(text: string): string;
|
|
128
|
+
}
|
|
129
|
+
|
|
130
|
+
interface CapturedTool {
|
|
131
|
+
name: string;
|
|
132
|
+
parameters?: unknown;
|
|
133
|
+
execute: (toolCallId: string, params: Record<string, unknown>, signal: AbortSignal, onUpdate: unknown, ctx: unknown) => Promise<CapturedToolResult>;
|
|
134
|
+
renderCall?: (args: Record<string, unknown>, theme: RenderTheme, context: Record<string, unknown>) => RenderedComponent;
|
|
135
|
+
renderResult?: (result: RenderToolResult, options: { expanded?: boolean; isPartial?: boolean }, theme: RenderTheme, context: Record<string, unknown>) => RenderedComponent;
|
|
136
|
+
}
|
|
137
|
+
|
|
138
|
+
const renderTheme: RenderTheme = {
|
|
139
|
+
fg: (_name, text) => text,
|
|
140
|
+
bold: (text) => text,
|
|
141
|
+
};
|
|
142
|
+
|
|
143
|
+
function renderToText(component: RenderedComponent): string {
|
|
144
|
+
return component.render(120).map((line) => line.trimEnd()).join("\n");
|
|
145
|
+
}
|
|
146
|
+
|
|
147
|
+
function createExtensionHarness(sessionName: string | (() => string) = "child-worker", options: {
|
|
148
|
+
abort?: () => void;
|
|
149
|
+
hasUI?: boolean;
|
|
150
|
+
isIdle?: () => boolean;
|
|
151
|
+
mode?: "tui" | "rpc" | "json" | "print";
|
|
152
|
+
ui?: unknown;
|
|
153
|
+
sessionId?: string | (() => string);
|
|
154
|
+
} = {}) {
|
|
155
|
+
const events = new EventEmitter();
|
|
156
|
+
const lifecycleHandlers = new Map<string, Array<(event: unknown, ctx: unknown) => unknown>>();
|
|
157
|
+
const commands = new Map<string, (args: string, ctx: unknown) => unknown>();
|
|
158
|
+
const tools: CapturedTool[] = [];
|
|
159
|
+
const entries: Array<{ type: string; data: unknown }> = [];
|
|
160
|
+
const sentMessages: Array<{ message: { customType?: string; content?: string; details?: unknown }; options?: { triggerTurn?: boolean; deliverAs?: string } }> = [];
|
|
161
|
+
const pi = {
|
|
162
|
+
getSessionName: () => typeof sessionName === "function" ? sessionName() : sessionName,
|
|
163
|
+
events: {
|
|
164
|
+
on: (channel: string, handler: (payload: unknown) => void) => {
|
|
165
|
+
events.on(channel, handler);
|
|
166
|
+
return () => events.off(channel, handler);
|
|
167
|
+
},
|
|
168
|
+
emit: (channel: string, payload: unknown) => events.emit(channel, payload),
|
|
169
|
+
},
|
|
170
|
+
on: (event: string, handler: (payload: unknown, ctx: unknown) => unknown) => {
|
|
171
|
+
const handlers = lifecycleHandlers.get(event) ?? [];
|
|
172
|
+
handlers.push(handler);
|
|
173
|
+
lifecycleHandlers.set(event, handlers);
|
|
174
|
+
},
|
|
175
|
+
registerMessageRenderer: () => undefined,
|
|
176
|
+
registerTool: (tool: CapturedTool) => {
|
|
177
|
+
tools.push(tool);
|
|
178
|
+
},
|
|
179
|
+
registerCommand: (name: string, command: { handler: (args: string, ctx: unknown) => unknown }) => {
|
|
180
|
+
commands.set(name, command.handler);
|
|
181
|
+
},
|
|
182
|
+
registerShortcut: () => undefined,
|
|
183
|
+
sendMessage: (message: { customType?: string; content?: string; details?: unknown }, options?: { triggerTurn?: boolean; deliverAs?: string }) => {
|
|
184
|
+
sentMessages.push({ message, options });
|
|
185
|
+
},
|
|
186
|
+
appendEntry: (type: string, data: unknown) => entries.push({ type, data }),
|
|
187
|
+
};
|
|
188
|
+
const ctx = {
|
|
189
|
+
cwd: repoDir,
|
|
190
|
+
mode: options.mode ?? (options.hasUI ? "tui" : "print"),
|
|
191
|
+
model: { id: "child-model" },
|
|
192
|
+
sessionManager: { getSessionId: () => typeof options.sessionId === "function" ? options.sessionId() : options.sessionId ?? "session-child-test" },
|
|
193
|
+
isIdle: options.isIdle ?? (() => true),
|
|
194
|
+
hasUI: options.hasUI ?? false,
|
|
195
|
+
abort: options.abort ?? (() => undefined),
|
|
196
|
+
ui: options.ui,
|
|
197
|
+
};
|
|
198
|
+
return {
|
|
199
|
+
pi,
|
|
200
|
+
ctx,
|
|
201
|
+
tools,
|
|
202
|
+
commands,
|
|
203
|
+
entries,
|
|
204
|
+
sentMessages,
|
|
205
|
+
async emitLifecycle(event: string, payload: unknown = {}, eventContext: unknown = ctx) {
|
|
206
|
+
for (const handler of lifecycleHandlers.get(event) ?? []) {
|
|
207
|
+
await handler(payload, eventContext);
|
|
208
|
+
}
|
|
209
|
+
},
|
|
210
|
+
async emitLifecycleResults(event: string, payload: unknown = {}, eventContext: unknown = ctx) {
|
|
211
|
+
const results: unknown[] = [];
|
|
212
|
+
for (const handler of lifecycleHandlers.get(event) ?? []) {
|
|
213
|
+
results.push(await handler(payload, eventContext));
|
|
214
|
+
}
|
|
215
|
+
return results;
|
|
216
|
+
},
|
|
217
|
+
};
|
|
218
|
+
}
|
|
219
|
+
|
|
220
|
+
async function connectRawRegistered(sessionId: string, name: string, sessionOverrides: Record<string, unknown> = {}) {
|
|
221
|
+
const net = await import("node:net");
|
|
222
|
+
const { getBrokerSocketPath } = await import("./broker/paths.ts");
|
|
223
|
+
const { createMessageReader, writeMessage } = await import("./broker/framing.ts");
|
|
224
|
+
const socket = net.connect(getBrokerSocketPath());
|
|
225
|
+
await once(socket, "connect");
|
|
226
|
+
const registered = new Promise<void>((resolve, reject) => {
|
|
227
|
+
const timeout = setTimeout(() => reject(new Error("Raw register timed out")), 2000);
|
|
228
|
+
const reader = createMessageReader((msg) => {
|
|
229
|
+
if (typeof msg === "object" && msg !== null && "type" in msg && msg.type === "registered") {
|
|
230
|
+
clearTimeout(timeout);
|
|
231
|
+
socket.off("data", reader);
|
|
232
|
+
resolve();
|
|
233
|
+
}
|
|
234
|
+
}, reject);
|
|
235
|
+
socket.on("data", reader);
|
|
236
|
+
});
|
|
237
|
+
writeMessage(socket, {
|
|
238
|
+
type: "register",
|
|
239
|
+
sessionId,
|
|
240
|
+
session: {
|
|
241
|
+
name,
|
|
242
|
+
cwd: repoDir,
|
|
243
|
+
model: "test-model",
|
|
244
|
+
pid: process.pid,
|
|
245
|
+
startedAt: Date.now(),
|
|
246
|
+
lastActivity: Date.now(),
|
|
247
|
+
...sessionOverrides,
|
|
248
|
+
},
|
|
249
|
+
});
|
|
250
|
+
await registered;
|
|
251
|
+
return { socket, writeMessage };
|
|
252
|
+
}
|
|
253
|
+
|
|
254
|
+
test("opt-in TCP broker requires endpoint state for health and registration", { concurrency: false }, async () => {
|
|
255
|
+
const net = await import("node:net");
|
|
256
|
+
const { readFileSync } = await import("node:fs");
|
|
257
|
+
const { createMessageReader, writeMessage } = await import("./broker/framing.ts");
|
|
258
|
+
const agentDir = mkdtempSync(path.join(tmpdir(), "pi-intercom-tcp-agent-"));
|
|
259
|
+
const broker = spawn(process.execPath, [
|
|
260
|
+
getTsxCliPath(),
|
|
261
|
+
"-e",
|
|
262
|
+
"Object.defineProperty(process, 'platform', { value: 'win32' }); import('./broker/broker.ts').catch((error) => { console.error(error); process.exit(1); });",
|
|
263
|
+
], {
|
|
264
|
+
cwd: repoDir,
|
|
265
|
+
env: {
|
|
266
|
+
...process.env,
|
|
267
|
+
HOME: agentDir,
|
|
268
|
+
USERPROFILE: agentDir,
|
|
269
|
+
SELESAI_CODING_AGENT_DIR: agentDir,
|
|
270
|
+
PI_INTERCOM_TRANSPORT: "tcp",
|
|
271
|
+
},
|
|
272
|
+
stdio: ["ignore", "pipe", "pipe"],
|
|
273
|
+
});
|
|
274
|
+
|
|
275
|
+
const exchange = async (message: unknown, waitForResponse: boolean): Promise<unknown[]> => {
|
|
276
|
+
const socket = net.connect({ host, port });
|
|
277
|
+
const messages: unknown[] = [];
|
|
278
|
+
return await new Promise((resolve, reject) => {
|
|
279
|
+
let settled = false;
|
|
280
|
+
const finish = () => {
|
|
281
|
+
if (settled) {
|
|
282
|
+
return;
|
|
283
|
+
}
|
|
284
|
+
settled = true;
|
|
285
|
+
clearTimeout(timeout);
|
|
286
|
+
socket.off("data", reader);
|
|
287
|
+
socket.off("close", finish);
|
|
288
|
+
socket.off("error", onSocketError);
|
|
289
|
+
socket.destroy();
|
|
290
|
+
resolve(messages);
|
|
291
|
+
};
|
|
292
|
+
const onSocketError = () => finish();
|
|
293
|
+
const reader = createMessageReader((received) => {
|
|
294
|
+
messages.push(received);
|
|
295
|
+
if (waitForResponse) {
|
|
296
|
+
finish();
|
|
297
|
+
}
|
|
298
|
+
}, reject);
|
|
299
|
+
const timeout = setTimeout(finish, 500);
|
|
300
|
+
socket.once("connect", () => writeMessage(socket, message));
|
|
301
|
+
socket.on("data", reader);
|
|
302
|
+
socket.once("close", finish);
|
|
303
|
+
socket.once("error", onSocketError);
|
|
304
|
+
});
|
|
305
|
+
};
|
|
306
|
+
|
|
307
|
+
let host = "";
|
|
308
|
+
let port = 0;
|
|
309
|
+
let stateId = "";
|
|
310
|
+
try {
|
|
311
|
+
await waitForBrokerReady(broker);
|
|
312
|
+
const endpoint: unknown = JSON.parse(readFileSync(path.join(agentDir, "intercom", "broker.port.json"), "utf-8"));
|
|
313
|
+
if (typeof endpoint !== "object" || endpoint === null || Array.isArray(endpoint)) {
|
|
314
|
+
throw new Error("Invalid TCP endpoint fixture");
|
|
315
|
+
}
|
|
316
|
+
const endpointRecord = endpoint as Record<string, unknown>;
|
|
317
|
+
if (endpointRecord.host !== "127.0.0.1" || typeof endpointRecord.port !== "number" || typeof endpointRecord.stateId !== "string") {
|
|
318
|
+
throw new Error(`Invalid TCP endpoint fixture: ${JSON.stringify(endpointRecord)}`);
|
|
319
|
+
}
|
|
320
|
+
host = endpointRecord.host;
|
|
321
|
+
port = endpointRecord.port;
|
|
322
|
+
stateId = endpointRecord.stateId;
|
|
323
|
+
|
|
324
|
+
assert.deepEqual(await exchange({ type: "health", requestId: "unauthorized-health" }, false), []);
|
|
325
|
+
assert.deepEqual(await exchange({
|
|
326
|
+
type: "register",
|
|
327
|
+
sessionId: "unauthorized-tcp-client",
|
|
328
|
+
session: {
|
|
329
|
+
name: "unauthorized",
|
|
330
|
+
cwd: repoDir,
|
|
331
|
+
model: "test-model",
|
|
332
|
+
pid: process.pid,
|
|
333
|
+
startedAt: Date.now(),
|
|
334
|
+
lastActivity: Date.now(),
|
|
335
|
+
},
|
|
336
|
+
}, false), []);
|
|
337
|
+
|
|
338
|
+
const healthMessages = await exchange({ type: "health", requestId: "authorized-health", stateId }, true);
|
|
339
|
+
assert.deepEqual(healthMessages, [{
|
|
340
|
+
type: "health_ok",
|
|
341
|
+
requestId: "authorized-health",
|
|
342
|
+
protocol: "pi-intercom",
|
|
343
|
+
version: 1,
|
|
344
|
+
}]);
|
|
345
|
+
|
|
346
|
+
const registerMessages = await exchange({
|
|
347
|
+
type: "register",
|
|
348
|
+
sessionId: "authorized-tcp-client",
|
|
349
|
+
stateId,
|
|
350
|
+
session: {
|
|
351
|
+
name: "authorized",
|
|
352
|
+
cwd: repoDir,
|
|
353
|
+
model: "test-model",
|
|
354
|
+
pid: process.pid,
|
|
355
|
+
startedAt: Date.now(),
|
|
356
|
+
lastActivity: Date.now(),
|
|
357
|
+
},
|
|
358
|
+
}, true);
|
|
359
|
+
assert.deepEqual(registerMessages, [{
|
|
360
|
+
type: "registered",
|
|
361
|
+
sessionId: "authorized-tcp-client",
|
|
362
|
+
features: ["extension-bus-v1"],
|
|
363
|
+
}]);
|
|
364
|
+
} finally {
|
|
365
|
+
if (broker.exitCode === null && broker.signalCode === null) {
|
|
366
|
+
broker.kill("SIGTERM");
|
|
367
|
+
await once(broker, "exit").catch(() => undefined);
|
|
368
|
+
}
|
|
369
|
+
rmSync(agentDir, { recursive: true, force: true });
|
|
370
|
+
}
|
|
371
|
+
});
|
|
372
|
+
|
|
373
|
+
async function setupClients() {
|
|
374
|
+
const broker = spawn(process.execPath, [getTsxCliPath(), path.join(repoDir, "broker", "broker.ts")], {
|
|
375
|
+
cwd: repoDir,
|
|
376
|
+
env: { ...process.env, HOME: sharedHomeDir, USERPROFILE: sharedHomeDir },
|
|
377
|
+
stdio: ["ignore", "pipe", "pipe"],
|
|
378
|
+
});
|
|
379
|
+
|
|
380
|
+
try {
|
|
381
|
+
await waitForBrokerReady(broker);
|
|
382
|
+
const planner = new IntercomClient();
|
|
383
|
+
const orchestrator = new IntercomClient();
|
|
384
|
+
|
|
385
|
+
await planner.connect({
|
|
386
|
+
name: "planner",
|
|
387
|
+
cwd: repoDir,
|
|
388
|
+
model: "test-model",
|
|
389
|
+
pid: process.pid,
|
|
390
|
+
startedAt: Date.now(),
|
|
391
|
+
lastActivity: Date.now(),
|
|
392
|
+
});
|
|
393
|
+
await orchestrator.connect({
|
|
394
|
+
name: "orchestrator",
|
|
395
|
+
cwd: repoDir,
|
|
396
|
+
model: "test-model",
|
|
397
|
+
pid: process.pid,
|
|
398
|
+
startedAt: Date.now(),
|
|
399
|
+
lastActivity: Date.now(),
|
|
400
|
+
});
|
|
401
|
+
|
|
402
|
+
return {
|
|
403
|
+
planner,
|
|
404
|
+
orchestrator,
|
|
405
|
+
cleanup: async () => {
|
|
406
|
+
await planner.disconnect().catch(() => undefined);
|
|
407
|
+
await orchestrator.disconnect().catch(() => undefined);
|
|
408
|
+
broker.kill("SIGTERM");
|
|
409
|
+
await once(broker, "exit").catch(() => undefined);
|
|
410
|
+
},
|
|
411
|
+
};
|
|
412
|
+
} catch (error) {
|
|
413
|
+
broker.kill("SIGTERM");
|
|
414
|
+
await once(broker, "exit").catch(() => undefined);
|
|
415
|
+
throw error;
|
|
416
|
+
}
|
|
417
|
+
}
|
|
418
|
+
|
|
419
|
+
function waitForReply(client: InstanceType<typeof IntercomClient>, replyTo: string, timeoutMs = 5000): Promise<{ from: SessionInfo; message: Message; }> {
|
|
420
|
+
return new Promise((resolve, reject) => {
|
|
421
|
+
const timeout = setTimeout(() => {
|
|
422
|
+
client.off("message", handler);
|
|
423
|
+
reject(new Error(`Timed out waiting for reply to ${replyTo}`));
|
|
424
|
+
}, timeoutMs);
|
|
425
|
+
const handler = (from: SessionInfo, message: Message) => {
|
|
426
|
+
if (message.replyTo !== replyTo) {
|
|
427
|
+
return;
|
|
428
|
+
}
|
|
429
|
+
clearTimeout(timeout);
|
|
430
|
+
client.off("message", handler);
|
|
431
|
+
resolve({ from, message });
|
|
432
|
+
};
|
|
433
|
+
client.on("message", handler);
|
|
434
|
+
});
|
|
435
|
+
}
|
|
436
|
+
|
|
437
|
+
async function waitForSessionByName(client: InstanceType<typeof IntercomClient>, name: string): Promise<SessionInfo> {
|
|
438
|
+
const deadline = Date.now() + 2000;
|
|
439
|
+
while (Date.now() < deadline) {
|
|
440
|
+
const session = (await client.listSessions()).find((candidate) => candidate.name === name);
|
|
441
|
+
if (session) {
|
|
442
|
+
return session;
|
|
443
|
+
}
|
|
444
|
+
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
445
|
+
}
|
|
446
|
+
const sessions = await client.listSessions();
|
|
447
|
+
throw new Error(`Timed out waiting for ${name}; saw ${JSON.stringify(sessions.map((session) => session.name))}`);
|
|
448
|
+
}
|
|
449
|
+
|
|
450
|
+
async function waitForSessionStatus(client: InstanceType<typeof IntercomClient>, name: string, status: string): Promise<SessionInfo> {
|
|
451
|
+
const deadline = Date.now() + 2000;
|
|
452
|
+
while (Date.now() < deadline) {
|
|
453
|
+
const session = (await client.listSessions()).find((candidate) => candidate.name === name);
|
|
454
|
+
if (session?.status === status) {
|
|
455
|
+
return session;
|
|
456
|
+
}
|
|
457
|
+
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
458
|
+
}
|
|
459
|
+
const sessions = await client.listSessions();
|
|
460
|
+
throw new Error(`Timed out waiting for ${name} status ${status}; saw ${JSON.stringify(sessions.map((session) => ({ name: session.name, status: session.status })))}`);
|
|
461
|
+
}
|
|
462
|
+
|
|
463
|
+
async function waitForSessionModel(client: InstanceType<typeof IntercomClient>, name: string, model: string): Promise<SessionInfo> {
|
|
464
|
+
const deadline = Date.now() + 2000;
|
|
465
|
+
while (Date.now() < deadline) {
|
|
466
|
+
const session = (await client.listSessions()).find((candidate) => candidate.name === name);
|
|
467
|
+
if (session?.model === model) {
|
|
468
|
+
return session;
|
|
469
|
+
}
|
|
470
|
+
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
471
|
+
}
|
|
472
|
+
const sessions = await client.listSessions();
|
|
473
|
+
throw new Error(`Timed out waiting for ${name} model ${model}; saw ${JSON.stringify(sessions.map((session) => ({ name: session.name, model: session.model })))}`);
|
|
474
|
+
}
|
|
475
|
+
|
|
476
|
+
async function waitForSessionId(client: InstanceType<typeof IntercomClient>, sessionId: string): Promise<SessionInfo> {
|
|
477
|
+
const deadline = Date.now() + 2000;
|
|
478
|
+
while (Date.now() < deadline) {
|
|
479
|
+
const session = (await client.listSessions()).find((candidate) => candidate.id === sessionId);
|
|
480
|
+
if (session) {
|
|
481
|
+
return session;
|
|
482
|
+
}
|
|
483
|
+
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
484
|
+
}
|
|
485
|
+
const sessions = await client.listSessions();
|
|
486
|
+
throw new Error(`Timed out waiting for ${sessionId}; saw ${JSON.stringify(sessions.map((session) => session.id))}`);
|
|
487
|
+
}
|
|
488
|
+
|
|
489
|
+
async function waitForNoSessionId(client: InstanceType<typeof IntercomClient>, sessionId: string): Promise<void> {
|
|
490
|
+
const deadline = Date.now() + 2000;
|
|
491
|
+
while (Date.now() < deadline) {
|
|
492
|
+
if (!(await client.listSessions()).some((candidate) => candidate.id === sessionId)) {
|
|
493
|
+
return;
|
|
494
|
+
}
|
|
495
|
+
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
496
|
+
}
|
|
497
|
+
throw new Error(`Timed out waiting for ${sessionId} to leave`);
|
|
498
|
+
}
|
|
499
|
+
|
|
500
|
+
test("broker accepts caller supplied stable IDs across reconnect", { concurrency: false }, async () => {
|
|
501
|
+
const { planner, cleanup } = await setupClients();
|
|
502
|
+
const worker = new IntercomClient();
|
|
503
|
+
|
|
504
|
+
try {
|
|
505
|
+
await worker.connect({
|
|
506
|
+
name: "stable-worker",
|
|
507
|
+
cwd: repoDir,
|
|
508
|
+
model: "test-model",
|
|
509
|
+
pid: process.pid,
|
|
510
|
+
startedAt: Date.now(),
|
|
511
|
+
lastActivity: Date.now(),
|
|
512
|
+
}, "stable-session-id");
|
|
513
|
+
assert.equal(worker.sessionId, "stable-session-id");
|
|
514
|
+
await waitForSessionId(planner, "stable-session-id");
|
|
515
|
+
await worker.disconnect();
|
|
516
|
+
await waitForNoSessionId(planner, "stable-session-id");
|
|
517
|
+
|
|
518
|
+
const reconnected = new IntercomClient();
|
|
519
|
+
await reconnected.connect({
|
|
520
|
+
name: "stable-worker",
|
|
521
|
+
cwd: repoDir,
|
|
522
|
+
model: "test-model",
|
|
523
|
+
pid: process.pid,
|
|
524
|
+
startedAt: Date.now(),
|
|
525
|
+
lastActivity: Date.now(),
|
|
526
|
+
}, "stable-session-id");
|
|
527
|
+
assert.equal(reconnected.sessionId, "stable-session-id");
|
|
528
|
+
await waitForSessionId(planner, "stable-session-id");
|
|
529
|
+
await reconnected.disconnect();
|
|
530
|
+
} finally {
|
|
531
|
+
await worker.disconnect().catch(() => undefined);
|
|
532
|
+
await cleanup();
|
|
533
|
+
}
|
|
534
|
+
});
|
|
535
|
+
|
|
536
|
+
test("broker owns local trust metadata instead of trusting registration payloads", { concurrency: false }, async () => {
|
|
537
|
+
const { planner, cleanup } = await setupClients();
|
|
538
|
+
const raw = await connectRawRegistered("trust-metadata-worker-id", "trust-metadata-worker", {
|
|
539
|
+
peerUid: 0,
|
|
540
|
+
trustedLocal: false,
|
|
541
|
+
});
|
|
542
|
+
|
|
543
|
+
try {
|
|
544
|
+
const session = await waitForSessionId(planner, "trust-metadata-worker-id");
|
|
545
|
+
assert.equal(session.trustedLocal, process.platform !== "win32");
|
|
546
|
+
assert.equal(session.peerUid, undefined);
|
|
547
|
+
} finally {
|
|
548
|
+
raw.socket.destroy();
|
|
549
|
+
await cleanup();
|
|
550
|
+
}
|
|
551
|
+
});
|
|
552
|
+
|
|
553
|
+
test("broker rejects unknown replyTo values instead of delivering forged replies", { concurrency: false }, async () => {
|
|
554
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
555
|
+
|
|
556
|
+
try {
|
|
557
|
+
const result = await planner.send(orchestrator.sessionId!, {
|
|
558
|
+
text: "This is not a real reply.",
|
|
559
|
+
replyTo: "not-a-pending-ask",
|
|
560
|
+
});
|
|
561
|
+
assert.equal(result.delivered, false);
|
|
562
|
+
assert.match(result.reason ?? "", /pending ask/i);
|
|
563
|
+
} finally {
|
|
564
|
+
await cleanup();
|
|
565
|
+
}
|
|
566
|
+
});
|
|
567
|
+
|
|
568
|
+
test("broker disconnects a connection that exceeds the local rate limit", { concurrency: false }, async () => {
|
|
569
|
+
const { cleanup } = await setupClients();
|
|
570
|
+
const raw = await connectRawRegistered("rate-limit-worker-id", "rate-limit-worker");
|
|
571
|
+
|
|
572
|
+
try {
|
|
573
|
+
raw.socket.on("error", () => undefined);
|
|
574
|
+
const closed = once(raw.socket, "close");
|
|
575
|
+
for (let i = 0; i < 300; i += 1) {
|
|
576
|
+
raw.writeMessage(raw.socket, { type: "list", requestId: `flood-${i}` });
|
|
577
|
+
}
|
|
578
|
+
await closed;
|
|
579
|
+
assert.equal(raw.socket.destroyed, true);
|
|
580
|
+
} finally {
|
|
581
|
+
raw.socket.destroy();
|
|
582
|
+
await cleanup();
|
|
583
|
+
}
|
|
584
|
+
});
|
|
585
|
+
|
|
586
|
+
test("broker idle raw connections cannot block legitimate registration", { concurrency: false }, async () => {
|
|
587
|
+
const net = await import("node:net");
|
|
588
|
+
const { getBrokerSocketPath } = await import("./broker/paths.ts");
|
|
589
|
+
const { cleanup } = await setupClients();
|
|
590
|
+
const sockets: ReturnType<typeof net.connect>[] = [];
|
|
591
|
+
const legitimate = new IntercomClient();
|
|
592
|
+
|
|
593
|
+
try {
|
|
594
|
+
for (let i = 0; i < 140; i += 1) {
|
|
595
|
+
const socket = net.connect(getBrokerSocketPath());
|
|
596
|
+
socket.on("error", () => undefined);
|
|
597
|
+
sockets.push(socket);
|
|
598
|
+
await Promise.race([
|
|
599
|
+
once(socket, "connect").catch(() => undefined),
|
|
600
|
+
once(socket, "close").catch(() => undefined),
|
|
601
|
+
new Promise((resolve) => setTimeout(resolve, 200)),
|
|
602
|
+
]);
|
|
603
|
+
}
|
|
604
|
+
|
|
605
|
+
await legitimate.connect({
|
|
606
|
+
name: "legitimate-after-idle-flood",
|
|
607
|
+
cwd: repoDir,
|
|
608
|
+
model: "test-model",
|
|
609
|
+
pid: process.pid,
|
|
610
|
+
startedAt: Date.now(),
|
|
611
|
+
lastActivity: Date.now(),
|
|
612
|
+
});
|
|
613
|
+
assert.equal(legitimate.isConnected(), true);
|
|
614
|
+
} finally {
|
|
615
|
+
for (const socket of sockets) {
|
|
616
|
+
socket.destroy();
|
|
617
|
+
}
|
|
618
|
+
await legitimate.disconnect().catch(() => undefined);
|
|
619
|
+
await cleanup();
|
|
620
|
+
}
|
|
621
|
+
});
|
|
622
|
+
|
|
623
|
+
test("broker times out sockets that unregister and go idle", { concurrency: false }, async () => {
|
|
624
|
+
const { cleanup } = await setupClients();
|
|
625
|
+
const raws: Array<Awaited<ReturnType<typeof connectRawRegistered>>> = [];
|
|
626
|
+
const legitimate = new IntercomClient();
|
|
627
|
+
|
|
628
|
+
try {
|
|
629
|
+
for (let i = 0; i < 40; i += 1) {
|
|
630
|
+
const raw = await connectRawRegistered(`unregister-idle-${i}`, `unregister-idle-${i}`);
|
|
631
|
+
raw.socket.on("error", () => undefined);
|
|
632
|
+
raw.writeMessage(raw.socket, { type: "unregister" });
|
|
633
|
+
raws.push(raw);
|
|
634
|
+
}
|
|
635
|
+
await new Promise((resolve) => setTimeout(resolve, 1200));
|
|
636
|
+
|
|
637
|
+
await legitimate.connect({
|
|
638
|
+
name: "legitimate-after-unregister-idle-flood",
|
|
639
|
+
cwd: repoDir,
|
|
640
|
+
model: "test-model",
|
|
641
|
+
pid: process.pid,
|
|
642
|
+
startedAt: Date.now(),
|
|
643
|
+
lastActivity: Date.now(),
|
|
644
|
+
});
|
|
645
|
+
assert.equal(legitimate.isConnected(), true);
|
|
646
|
+
} finally {
|
|
647
|
+
for (const raw of raws) {
|
|
648
|
+
raw.socket.destroy();
|
|
649
|
+
}
|
|
650
|
+
await legitimate.disconnect().catch(() => undefined);
|
|
651
|
+
await cleanup();
|
|
652
|
+
}
|
|
653
|
+
});
|
|
654
|
+
|
|
655
|
+
test("broker coalesces no-op presence floods", { concurrency: false }, async () => {
|
|
656
|
+
const { planner, cleanup } = await setupClients();
|
|
657
|
+
const worker = new IntercomClient();
|
|
658
|
+
const updates: SessionInfo[] = [];
|
|
659
|
+
planner.on("presence_update", (session: SessionInfo) => {
|
|
660
|
+
if (session.name === "presence-worker") {
|
|
661
|
+
updates.push(session);
|
|
662
|
+
}
|
|
663
|
+
});
|
|
664
|
+
|
|
665
|
+
try {
|
|
666
|
+
await worker.connect({
|
|
667
|
+
name: "presence-worker",
|
|
668
|
+
cwd: repoDir,
|
|
669
|
+
model: "test-model",
|
|
670
|
+
pid: process.pid,
|
|
671
|
+
startedAt: Date.now(),
|
|
672
|
+
lastActivity: Date.now(),
|
|
673
|
+
});
|
|
674
|
+
worker.updatePresence({ status: "idle" });
|
|
675
|
+
for (let i = 0; i < 20; i += 1) {
|
|
676
|
+
worker.updatePresence({ status: "idle" });
|
|
677
|
+
}
|
|
678
|
+
await new Promise((resolve) => setTimeout(resolve, 150));
|
|
679
|
+
assert.equal(updates.length, 1);
|
|
680
|
+
} finally {
|
|
681
|
+
await worker.disconnect().catch(() => undefined);
|
|
682
|
+
await cleanup();
|
|
683
|
+
}
|
|
684
|
+
});
|
|
685
|
+
|
|
686
|
+
test("old stable-ID socket cannot mutate the replacement session", { concurrency: false }, async () => {
|
|
687
|
+
const { planner, cleanup } = await setupClients();
|
|
688
|
+
const first = await connectRawRegistered("replaceable-session-id", "replaceable-worker-old");
|
|
689
|
+
const replacement = new IntercomClient();
|
|
690
|
+
|
|
691
|
+
try {
|
|
692
|
+
await replacement.connect({
|
|
693
|
+
name: "replaceable-worker-new",
|
|
694
|
+
cwd: repoDir,
|
|
695
|
+
model: "test-model",
|
|
696
|
+
pid: process.pid,
|
|
697
|
+
startedAt: Date.now(),
|
|
698
|
+
lastActivity: Date.now(),
|
|
699
|
+
}, "replaceable-session-id");
|
|
700
|
+
|
|
701
|
+
first.writeMessage(first.socket, { type: "presence", name: "stale-name" });
|
|
702
|
+
first.writeMessage(first.socket, { type: "unregister" });
|
|
703
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
704
|
+
const replacementSession = await waitForSessionId(planner, "replaceable-session-id");
|
|
705
|
+
assert.equal(replacementSession.name, "replaceable-worker-new");
|
|
706
|
+
|
|
707
|
+
const received = once(replacement, "message") as Promise<[SessionInfo, Message]>;
|
|
708
|
+
const sent = await planner.send("replaceable-session-id", { text: "still there" });
|
|
709
|
+
assert.equal(sent.delivered, true);
|
|
710
|
+
const [, message] = await received;
|
|
711
|
+
assert.equal(message.content.text, "still there");
|
|
712
|
+
} finally {
|
|
713
|
+
first.socket.destroy();
|
|
714
|
+
await replacement.disconnect().catch(() => undefined);
|
|
715
|
+
await cleanup();
|
|
716
|
+
}
|
|
717
|
+
});
|
|
718
|
+
|
|
719
|
+
test("stable-ID replacement clears old ask edges and ignores stale cancels", { concurrency: false }, async () => {
|
|
720
|
+
const { orchestrator, cleanup } = await setupClients();
|
|
721
|
+
const first = await connectRawRegistered("replaceable-asker-id", "replaceable-asker-old");
|
|
722
|
+
const replacement = new IntercomClient();
|
|
723
|
+
|
|
724
|
+
try {
|
|
725
|
+
first.writeMessage(first.socket, {
|
|
726
|
+
type: "send",
|
|
727
|
+
to: orchestrator.sessionId,
|
|
728
|
+
message: { id: "old-ask-edge", timestamp: Date.now(), expectsReply: true, content: { text: "Old ask" } },
|
|
729
|
+
});
|
|
730
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
731
|
+
|
|
732
|
+
await replacement.connect({
|
|
733
|
+
name: "replaceable-asker-new",
|
|
734
|
+
cwd: repoDir,
|
|
735
|
+
model: "test-model",
|
|
736
|
+
pid: process.pid,
|
|
737
|
+
startedAt: Date.now(),
|
|
738
|
+
lastActivity: Date.now(),
|
|
739
|
+
}, "replaceable-asker-id");
|
|
740
|
+
|
|
741
|
+
const reverseAfterReplace = await orchestrator.send("replaceable-asker-id", {
|
|
742
|
+
messageId: "reverse-after-replace",
|
|
743
|
+
text: "Can I ask the replacement?",
|
|
744
|
+
expectsReply: true,
|
|
745
|
+
});
|
|
746
|
+
assert.equal(reverseAfterReplace.delivered, true);
|
|
747
|
+
assert.equal((await replacement.send(orchestrator.sessionId!, {
|
|
748
|
+
text: "Replacement answered.",
|
|
749
|
+
replyTo: "reverse-after-replace",
|
|
750
|
+
})).delivered, true);
|
|
751
|
+
|
|
752
|
+
const replacementAsk = await replacement.send(orchestrator.sessionId!, {
|
|
753
|
+
messageId: "replacement-ask-edge",
|
|
754
|
+
text: "Replacement ask",
|
|
755
|
+
expectsReply: true,
|
|
756
|
+
});
|
|
757
|
+
assert.equal(replacementAsk.delivered, true);
|
|
758
|
+
first.writeMessage(first.socket, { type: "cancel_ask", messageId: "replacement-ask-edge" });
|
|
759
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
760
|
+
|
|
761
|
+
const reverseWhileReplacementWaits = await orchestrator.send("replaceable-asker-id", {
|
|
762
|
+
messageId: "reverse-while-replacement-waits",
|
|
763
|
+
text: "Can I ask while replacement waits?",
|
|
764
|
+
expectsReply: true,
|
|
765
|
+
});
|
|
766
|
+
assert.equal(reverseWhileReplacementWaits.delivered, false);
|
|
767
|
+
assert.match(reverseWhileReplacementWaits.reason ?? "", /Mutual ask refused/);
|
|
768
|
+
} finally {
|
|
769
|
+
first.socket.destroy();
|
|
770
|
+
await replacement.disconnect().catch(() => undefined);
|
|
771
|
+
await cleanup();
|
|
772
|
+
}
|
|
773
|
+
});
|
|
774
|
+
|
|
775
|
+
test("broker resolves unique short IDs and rejects ambiguous prefixes", { concurrency: false }, async () => {
|
|
776
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
777
|
+
const first = new IntercomClient();
|
|
778
|
+
const second = new IntercomClient();
|
|
779
|
+
const evilPrefix = new IntercomClient();
|
|
780
|
+
|
|
781
|
+
try {
|
|
782
|
+
await first.connect({ name: "short-id-one", cwd: repoDir, model: "test-model", pid: process.pid, startedAt: Date.now(), lastActivity: Date.now() }, "abcdef12-session");
|
|
783
|
+
await second.connect({ name: "short-id-two", cwd: repoDir, model: "test-model", pid: process.pid, startedAt: Date.now(), lastActivity: Date.now() }, "abcdef99-session");
|
|
784
|
+
await evilPrefix.connect({ name: "evil-prefix", cwd: repoDir, model: "test-model", pid: process.pid, startedAt: Date.now(), lastActivity: Date.now() }, "orchestrator-evil");
|
|
785
|
+
|
|
786
|
+
const received = once(first, "message") as Promise<[SessionInfo, Message]>;
|
|
787
|
+
const unique = await planner.send("abcdef12", { text: "prefix works" });
|
|
788
|
+
assert.equal(unique.delivered, true);
|
|
789
|
+
const [, message] = await received;
|
|
790
|
+
assert.equal(message.content.text, "prefix works");
|
|
791
|
+
|
|
792
|
+
const ambiguous = await planner.send("abcdef", { text: "ambiguous" });
|
|
793
|
+
assert.equal(ambiguous.delivered, false);
|
|
794
|
+
assert.match(ambiguous.reason ?? "", /Multiple sessions/);
|
|
795
|
+
|
|
796
|
+
const exactNameReceived = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
797
|
+
const exactName = await planner.send("orchestrator", { text: "exact name wins" });
|
|
798
|
+
assert.equal(exactName.delivered, true);
|
|
799
|
+
const [, exactNameMessage] = await exactNameReceived;
|
|
800
|
+
assert.equal(exactNameMessage.content.text, "exact name wins");
|
|
801
|
+
} finally {
|
|
802
|
+
await first.disconnect().catch(() => undefined);
|
|
803
|
+
await second.disconnect().catch(() => undefined);
|
|
804
|
+
await evilPrefix.disconnect().catch(() => undefined);
|
|
805
|
+
await cleanup();
|
|
806
|
+
}
|
|
807
|
+
});
|
|
808
|
+
|
|
809
|
+
test("intercom tool prefers exact names over ID prefixes", { concurrency: false }, async () => {
|
|
810
|
+
const { orchestrator, cleanup } = await setupClients();
|
|
811
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
812
|
+
const evilPrefix = new IntercomClient();
|
|
813
|
+
const harness = createExtensionHarness("exact-name-worker");
|
|
814
|
+
|
|
815
|
+
try {
|
|
816
|
+
await evilPrefix.connect({ name: "evil-prefix", cwd: repoDir, model: "test-model", pid: process.pid, startedAt: Date.now(), lastActivity: Date.now() }, "orchestrator-evil");
|
|
817
|
+
piIntercomExtension(harness.pi as never);
|
|
818
|
+
await harness.emitLifecycle("session_start");
|
|
819
|
+
|
|
820
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
821
|
+
const exactNameReceived = Promise.race([
|
|
822
|
+
once(orchestrator, "message") as Promise<[SessionInfo, Message]>,
|
|
823
|
+
new Promise<null>((resolve) => setTimeout(() => resolve(null), 500)),
|
|
824
|
+
]);
|
|
825
|
+
const result = await intercomTool.execute("send-exact-name", { action: "send", to: "orchestrator", message: "exact name wins" }, new AbortController().signal, undefined, harness.ctx);
|
|
826
|
+
assert.notEqual(result.details?.error, true);
|
|
827
|
+
|
|
828
|
+
const received = await exactNameReceived;
|
|
829
|
+
assert.notEqual(received, null);
|
|
830
|
+
assert.equal(received![1].content.text, "exact name wins");
|
|
831
|
+
await harness.emitLifecycle("session_shutdown");
|
|
832
|
+
} finally {
|
|
833
|
+
await evilPrefix.disconnect().catch(() => undefined);
|
|
834
|
+
await cleanup();
|
|
835
|
+
}
|
|
836
|
+
});
|
|
837
|
+
|
|
838
|
+
test("extension can pin a restart-stable intercom session id", { concurrency: false }, async () => {
|
|
839
|
+
const { planner, cleanup } = await setupClients();
|
|
840
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
841
|
+
const previousStableId = process.env.PI_INTERCOM_STABLE_ID;
|
|
842
|
+
const previousPublishedId = process.env.PI_INTERCOM_SESSION_ID;
|
|
843
|
+
process.env.PI_INTERCOM_STABLE_ID = "pinned-worker-session";
|
|
844
|
+
const harness = createExtensionHarness("pinned-worker", { sessionId: "transient-pi-session" });
|
|
845
|
+
|
|
846
|
+
try {
|
|
847
|
+
piIntercomExtension(harness.pi as never);
|
|
848
|
+
await harness.emitLifecycle("session_start");
|
|
849
|
+
const session = await waitForSessionId(planner, "pinned-worker-session");
|
|
850
|
+
assert.equal(session.name, "pinned-worker");
|
|
851
|
+
assert.equal(process.env.PI_INTERCOM_SESSION_ID, "pinned-worker-session");
|
|
852
|
+
await harness.emitLifecycle("session_shutdown");
|
|
853
|
+
} finally {
|
|
854
|
+
if (previousStableId === undefined) delete process.env.PI_INTERCOM_STABLE_ID;
|
|
855
|
+
else process.env.PI_INTERCOM_STABLE_ID = previousStableId;
|
|
856
|
+
if (previousPublishedId === undefined) delete process.env.PI_INTERCOM_SESSION_ID;
|
|
857
|
+
else process.env.PI_INTERCOM_SESSION_ID = previousPublishedId;
|
|
858
|
+
await cleanup();
|
|
859
|
+
}
|
|
860
|
+
});
|
|
861
|
+
|
|
862
|
+
test("intercom-id inserts a stable handoff snippet into the editor", { concurrency: false }, async () => {
|
|
863
|
+
const { cleanup } = await setupClients();
|
|
864
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
865
|
+
let editorText = "Existing note";
|
|
866
|
+
const notifications: string[] = [];
|
|
867
|
+
const harness = createExtensionHarness("handoff-worker", {
|
|
868
|
+
hasUI: true,
|
|
869
|
+
ui: {
|
|
870
|
+
getEditorText: () => editorText,
|
|
871
|
+
setEditorText: (text: string) => { editorText = text; },
|
|
872
|
+
notify: (message: string) => { notifications.push(message); },
|
|
873
|
+
},
|
|
874
|
+
});
|
|
875
|
+
|
|
876
|
+
try {
|
|
877
|
+
piIntercomExtension(harness.pi as never);
|
|
878
|
+
await harness.emitLifecycle("session_start");
|
|
879
|
+
await harness.commands.get("intercom-id")!("", harness.ctx);
|
|
880
|
+
assert.match(editorText, /Existing note\n\nUse pi-intercom: intercom\(\{ action: "send", to: "session-child-test", message: "\.\.\." \}\)/);
|
|
881
|
+
assert.match(notifications.at(-1) ?? "", /Inserted intercom contact target: session-child-test/);
|
|
882
|
+
await harness.emitLifecycle("session_shutdown");
|
|
883
|
+
} finally {
|
|
884
|
+
await cleanup();
|
|
885
|
+
}
|
|
886
|
+
});
|
|
887
|
+
|
|
888
|
+
test("intercom tool points at the short id when names collide", { concurrency: false }, async () => {
|
|
889
|
+
const { cleanup } = await setupClients();
|
|
890
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
891
|
+
const twinA = new IntercomClient();
|
|
892
|
+
const twinB = new IntercomClient();
|
|
893
|
+
const harness = createExtensionHarness("collision-sender");
|
|
894
|
+
|
|
895
|
+
try {
|
|
896
|
+
await twinA.connect({ name: "twin", cwd: repoDir, model: "test-model", pid: process.pid, startedAt: Date.now(), lastActivity: Date.now() }, "aaaa1111-session");
|
|
897
|
+
await twinB.connect({ name: "twin", cwd: repoDir, model: "test-model", pid: process.pid, startedAt: Date.now(), lastActivity: Date.now() }, "bbbb2222-session");
|
|
898
|
+
piIntercomExtension(harness.pi as never);
|
|
899
|
+
await harness.emitLifecycle("session_start");
|
|
900
|
+
|
|
901
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
902
|
+
const result = await intercomTool.execute("send-twin", { action: "send", to: "twin", message: "which one?" }, new AbortController().signal, undefined, harness.ctx);
|
|
903
|
+
|
|
904
|
+
assert.equal(result.details?.error, true);
|
|
905
|
+
const text = result.content.map((part) => (part as { text?: string }).text ?? "").join("");
|
|
906
|
+
assert.match(text, /parentheses/);
|
|
907
|
+
assert.match(text, /aaaa1111/);
|
|
908
|
+
assert.match(text, /bbbb2222/);
|
|
909
|
+
await harness.emitLifecycle("session_shutdown");
|
|
910
|
+
} finally {
|
|
911
|
+
await twinA.disconnect().catch(() => undefined);
|
|
912
|
+
await twinB.disconnect().catch(() => undefined);
|
|
913
|
+
await cleanup();
|
|
914
|
+
}
|
|
915
|
+
});
|
|
916
|
+
|
|
917
|
+
test("extension channels register locally without creating conversation messages", async () => {
|
|
918
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
919
|
+
const harness = createExtensionHarness();
|
|
920
|
+
let channel: IntercomExtensionChannel | undefined;
|
|
921
|
+
const extensionEvents: unknown[] = [];
|
|
922
|
+
|
|
923
|
+
piIntercomExtension(harness.pi as never);
|
|
924
|
+
harness.pi.events.emit(INTERCOM_EXTENSION_REGISTER_EVENT, {
|
|
925
|
+
namespace: "test-extension/v1",
|
|
926
|
+
ownerEligible: true,
|
|
927
|
+
onReady: (value: IntercomExtensionChannel) => { channel = value; },
|
|
928
|
+
onEvent: (event: unknown) => extensionEvents.push(event),
|
|
929
|
+
});
|
|
930
|
+
|
|
931
|
+
assert.equal(channel?.namespace, "test-extension/v1");
|
|
932
|
+
assert.deepEqual(channel?.snapshot(), {
|
|
933
|
+
connected: false,
|
|
934
|
+
supported: false,
|
|
935
|
+
});
|
|
936
|
+
assert.deepEqual(extensionEvents, []);
|
|
937
|
+
assert.deepEqual(harness.sentMessages, []);
|
|
938
|
+
assert.deepEqual(harness.entries, []);
|
|
939
|
+
});
|
|
940
|
+
|
|
941
|
+
test("late extension registration advertises before an onReady publish", { concurrency: false }, async () => {
|
|
942
|
+
const { cleanup } = await setupClients();
|
|
943
|
+
const observer = new IntercomClient();
|
|
944
|
+
const observerMessages: BrokerMessage[] = [];
|
|
945
|
+
const harness = createExtensionHarness("late-extension-worker");
|
|
946
|
+
const extensionEvents: unknown[] = [];
|
|
947
|
+
|
|
948
|
+
try {
|
|
949
|
+
observer.onBrokerMessage((message) => observerMessages.push(message));
|
|
950
|
+
observer.on("error", () => {});
|
|
951
|
+
await observer.connect({
|
|
952
|
+
name: "extension-observer",
|
|
953
|
+
cwd: repoDir,
|
|
954
|
+
model: "test-model",
|
|
955
|
+
pid: process.pid,
|
|
956
|
+
startedAt: Date.now(),
|
|
957
|
+
lastActivity: Date.now(),
|
|
958
|
+
extensions: [{ namespace: "late-extension/v1", ownerEligible: false }],
|
|
959
|
+
});
|
|
960
|
+
|
|
961
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
962
|
+
piIntercomExtension(harness.pi as never);
|
|
963
|
+
await harness.emitLifecycle("session_start");
|
|
964
|
+
await waitForSessionByName(observer, "late-extension-worker");
|
|
965
|
+
|
|
966
|
+
harness.pi.events.emit(INTERCOM_EXTENSION_REGISTER_EVENT, {
|
|
967
|
+
namespace: "late-extension/v1",
|
|
968
|
+
ownerEligible: true,
|
|
969
|
+
onReady: (channel: IntercomExtensionChannel) => {
|
|
970
|
+
channel.publish({ probe: "onReady" }, { audience: "capable" });
|
|
971
|
+
},
|
|
972
|
+
onEvent: (event: unknown) => extensionEvents.push(event),
|
|
973
|
+
});
|
|
974
|
+
|
|
975
|
+
const deadline = Date.now() + 3000;
|
|
976
|
+
while (
|
|
977
|
+
Date.now() < deadline
|
|
978
|
+
&& !observerMessages.some((message) => message.type === "extension_message"
|
|
979
|
+
&& (message.payload as { probe?: string }).probe === "onReady")
|
|
980
|
+
) {
|
|
981
|
+
await new Promise((resolve) => setTimeout(resolve, 10));
|
|
982
|
+
}
|
|
983
|
+
assert.equal(
|
|
984
|
+
observerMessages.some((message) => message.type === "extension_message"
|
|
985
|
+
&& (message.payload as { probe?: string }).probe === "onReady"),
|
|
986
|
+
true,
|
|
987
|
+
);
|
|
988
|
+
assert.equal(
|
|
989
|
+
extensionEvents.some((event) => typeof event === "object" && event !== null
|
|
990
|
+
&& (event as { type?: string }).type === "connection"
|
|
991
|
+
&& (event as { connected?: boolean }).connected === true),
|
|
992
|
+
true,
|
|
993
|
+
);
|
|
994
|
+
assert.deepEqual(harness.sentMessages, []);
|
|
995
|
+
assert.deepEqual(harness.entries, []);
|
|
996
|
+
await harness.emitLifecycle("session_shutdown");
|
|
997
|
+
} finally {
|
|
998
|
+
await observer.disconnect().catch(() => undefined);
|
|
999
|
+
await cleanup();
|
|
1000
|
+
}
|
|
1001
|
+
});
|
|
1002
|
+
|
|
1003
|
+
test("intercom tool renders compact call and result rows", async () => {
|
|
1004
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1005
|
+
const harness = createExtensionHarness();
|
|
1006
|
+
|
|
1007
|
+
piIntercomExtension(harness.pi as never);
|
|
1008
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
1009
|
+
|
|
1010
|
+
assert.ok(intercomTool.renderCall);
|
|
1011
|
+
assert.ok(intercomTool.renderResult);
|
|
1012
|
+
assert.match(renderToText(intercomTool.renderCall({
|
|
1013
|
+
action: "ask",
|
|
1014
|
+
to: "planner",
|
|
1015
|
+
message: "Need a decision before I continue with this implementation.",
|
|
1016
|
+
attachments: [{ type: "snippet", name: "note.ts", content: "const ok = true;" }],
|
|
1017
|
+
}, renderTheme, {})), /intercom ask → planner \(1 attachment\)\n Need a decision/);
|
|
1018
|
+
|
|
1019
|
+
const resultText = renderToText(intercomTool.renderResult({
|
|
1020
|
+
content: [{ type: "text", text: "Message sent to planner" }],
|
|
1021
|
+
details: { delivered: true, messageId: "abcdef123456" },
|
|
1022
|
+
}, { isPartial: false, expanded: false }, renderTheme, { isError: false, expanded: false }));
|
|
1023
|
+
assert.match(resultText, /✓ Message sent to planner \(abcdef12\)/);
|
|
1024
|
+
|
|
1025
|
+
const errorText = renderToText(intercomTool.renderResult({
|
|
1026
|
+
content: [{ type: "text", text: "Missing 'to' or 'message' parameter" }],
|
|
1027
|
+
details: { error: true, reason: "Missing target" },
|
|
1028
|
+
}, { isPartial: false, expanded: true }, renderTheme, { isError: false, expanded: true }));
|
|
1029
|
+
assert.match(errorText, /✗ Missing 'to' or 'message' parameter/);
|
|
1030
|
+
assert.match(errorText, /Reason: Missing target/);
|
|
1031
|
+
});
|
|
1032
|
+
|
|
1033
|
+
test("intercom tool result hook marks failed details as errors", async () => {
|
|
1034
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1035
|
+
const harness = createExtensionHarness();
|
|
1036
|
+
piIntercomExtension(harness.pi as never);
|
|
1037
|
+
|
|
1038
|
+
const errorResults = await harness.emitLifecycleResults("tool_result", {
|
|
1039
|
+
toolName: "intercom",
|
|
1040
|
+
details: { error: true },
|
|
1041
|
+
});
|
|
1042
|
+
assert.deepEqual(errorResults.filter(Boolean), [{ isError: true }]);
|
|
1043
|
+
|
|
1044
|
+
const deliveryResults = await harness.emitLifecycleResults("tool_result", {
|
|
1045
|
+
toolName: "contact_supervisor",
|
|
1046
|
+
details: { delivered: false },
|
|
1047
|
+
});
|
|
1048
|
+
assert.deepEqual(deliveryResults.filter(Boolean), [{ isError: true }]);
|
|
1049
|
+
|
|
1050
|
+
const okResults = await harness.emitLifecycleResults("tool_result", {
|
|
1051
|
+
toolName: "intercom",
|
|
1052
|
+
details: { delivered: true },
|
|
1053
|
+
});
|
|
1054
|
+
assert.deepEqual(okResults.filter(Boolean), []);
|
|
1055
|
+
});
|
|
1056
|
+
|
|
1057
|
+
test("contact supervisor tool renders reason and reply state", async () => {
|
|
1058
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1059
|
+
|
|
1060
|
+
await withChildOrchestratorEnv({
|
|
1061
|
+
orchestratorTarget: "orchestrator",
|
|
1062
|
+
runId: "78f659a3",
|
|
1063
|
+
agent: "worker",
|
|
1064
|
+
index: "0",
|
|
1065
|
+
}, () => {
|
|
1066
|
+
const harness = createExtensionHarness();
|
|
1067
|
+
piIntercomExtension(harness.pi as never);
|
|
1068
|
+
const supervisorTool = harness.tools.find((tool) => tool.name === "contact_supervisor")!;
|
|
1069
|
+
|
|
1070
|
+
assert.ok(supervisorTool.renderCall);
|
|
1071
|
+
assert.ok(supervisorTool.renderResult);
|
|
1072
|
+
assert.match(renderToText(supervisorTool.renderCall({
|
|
1073
|
+
reason: "interview_request",
|
|
1074
|
+
message: "Please answer these before I continue.",
|
|
1075
|
+
interview: { title: "API migration", questions: [] },
|
|
1076
|
+
}, renderTheme, {})), /contact_supervisor interview_request API migration\n Please answer/);
|
|
1077
|
+
|
|
1078
|
+
const warningText = renderToText(supervisorTool.renderResult({
|
|
1079
|
+
content: [{ type: "text", text: "Reply from supervisor:\nUse stable API" }],
|
|
1080
|
+
details: { structuredReplyParseError: "reply JSON must include a responses array" },
|
|
1081
|
+
}, { isPartial: false }, renderTheme, { isError: false }));
|
|
1082
|
+
assert.match(warningText, /⚠ Reply from supervisor:\nUse stable API/);
|
|
1083
|
+
assert.match(warningText, /Structured reply parse issue: reply JSON must include a responses array/);
|
|
1084
|
+
|
|
1085
|
+
const failureText = renderToText(supervisorTool.renderResult({
|
|
1086
|
+
content: [{ type: "text", text: "Invalid reason" }],
|
|
1087
|
+
details: { error: true },
|
|
1088
|
+
}, { isPartial: false }, renderTheme, { isError: false }));
|
|
1089
|
+
assert.match(failureText, /✗ Invalid reason/);
|
|
1090
|
+
});
|
|
1091
|
+
});
|
|
1092
|
+
|
|
1093
|
+
test("sessions publish automatic lifecycle status", { concurrency: false }, async () => {
|
|
1094
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1095
|
+
const { planner, cleanup } = await setupClients();
|
|
1096
|
+
const harness = createExtensionHarness("status-worker", { hasUI: true });
|
|
1097
|
+
|
|
1098
|
+
try {
|
|
1099
|
+
piIntercomExtension(harness.pi as never);
|
|
1100
|
+
await harness.emitLifecycle("session_start");
|
|
1101
|
+
|
|
1102
|
+
await waitForSessionStatus(planner, "status-worker", "idle");
|
|
1103
|
+
|
|
1104
|
+
const freshEventContext = {
|
|
1105
|
+
...harness.ctx,
|
|
1106
|
+
model: { id: "fresh-model" },
|
|
1107
|
+
sessionManager: { getSessionId: () => "session-child-test" },
|
|
1108
|
+
};
|
|
1109
|
+
await harness.emitLifecycle("model_select", { model: { id: "fresh-model" } }, freshEventContext);
|
|
1110
|
+
await waitForSessionModel(planner, "status-worker", "fresh-model");
|
|
1111
|
+
|
|
1112
|
+
await harness.emitLifecycle("agent_start");
|
|
1113
|
+
await waitForSessionStatus(planner, "status-worker", "thinking");
|
|
1114
|
+
|
|
1115
|
+
await harness.emitLifecycle("tool_execution_start", { toolCallId: "tool-1", toolName: "bash" });
|
|
1116
|
+
await waitForSessionStatus(planner, "status-worker", "tool:bash");
|
|
1117
|
+
await harness.emitLifecycle("tool_execution_start", { toolCallId: "tool-2", toolName: "read" });
|
|
1118
|
+
|
|
1119
|
+
await harness.emitLifecycle("tool_execution_end", { toolCallId: "tool-1", toolName: "bash" });
|
|
1120
|
+
await waitForSessionStatus(planner, "status-worker", "tool:read");
|
|
1121
|
+
|
|
1122
|
+
await harness.emitLifecycle("tool_execution_end", { toolCallId: "tool-2", toolName: "read" });
|
|
1123
|
+
await waitForSessionStatus(planner, "status-worker", "thinking");
|
|
1124
|
+
|
|
1125
|
+
await harness.emitLifecycle("agent_end");
|
|
1126
|
+
await waitForSessionStatus(planner, "status-worker", "idle");
|
|
1127
|
+
} finally {
|
|
1128
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1129
|
+
await cleanup();
|
|
1130
|
+
}
|
|
1131
|
+
});
|
|
1132
|
+
|
|
1133
|
+
test("idle name poll propagates /name changes without other activity", { concurrency: false }, async () => {
|
|
1134
|
+
const { planner, cleanup } = await setupClients();
|
|
1135
|
+
let sessionName = "idle-name-before";
|
|
1136
|
+
const harness = createExtensionHarness(() => sessionName, { hasUI: true });
|
|
1137
|
+
|
|
1138
|
+
try {
|
|
1139
|
+
await withChildOrchestratorEnv({ namePollMs: "25" }, async () => {
|
|
1140
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1141
|
+
piIntercomExtension(harness.pi as never);
|
|
1142
|
+
await harness.emitLifecycle("session_start");
|
|
1143
|
+
await waitForSessionByName(planner, "idle-name-before");
|
|
1144
|
+
sessionName = "idle-name-after";
|
|
1145
|
+
await waitForSessionByName(planner, "idle-name-after");
|
|
1146
|
+
});
|
|
1147
|
+
} finally {
|
|
1148
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1149
|
+
await cleanup();
|
|
1150
|
+
}
|
|
1151
|
+
});
|
|
1152
|
+
|
|
1153
|
+
test("session_info_changed publishes Selesai name changes immediately", { concurrency: false }, async () => {
|
|
1154
|
+
const { planner, cleanup } = await setupClients();
|
|
1155
|
+
let sessionName = "event-name-before";
|
|
1156
|
+
const harness = createExtensionHarness(() => sessionName, { hasUI: true });
|
|
1157
|
+
|
|
1158
|
+
try {
|
|
1159
|
+
await withChildOrchestratorEnv({ namePollMs: "60000" }, async () => {
|
|
1160
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1161
|
+
piIntercomExtension(harness.pi as never);
|
|
1162
|
+
await harness.emitLifecycle("session_start");
|
|
1163
|
+
await waitForSessionByName(planner, "event-name-before");
|
|
1164
|
+
sessionName = "event-name-after";
|
|
1165
|
+
await harness.emitLifecycle("session_info_changed", { name: sessionName });
|
|
1166
|
+
await waitForSessionByName(planner, "event-name-after");
|
|
1167
|
+
});
|
|
1168
|
+
} finally {
|
|
1169
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1170
|
+
await cleanup();
|
|
1171
|
+
}
|
|
1172
|
+
});
|
|
1173
|
+
|
|
1174
|
+
test("turn_start re-registers when Selesai replaces the session context", { concurrency: false }, async () => {
|
|
1175
|
+
const { planner, cleanup } = await setupClients();
|
|
1176
|
+
let sessionName = "fork-before";
|
|
1177
|
+
let sessionId = "session-fork-before";
|
|
1178
|
+
const harness = createExtensionHarness(() => sessionName, { hasUI: true, sessionId: () => sessionId });
|
|
1179
|
+
|
|
1180
|
+
try {
|
|
1181
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1182
|
+
piIntercomExtension(harness.pi as never);
|
|
1183
|
+
await harness.emitLifecycle("session_start");
|
|
1184
|
+
await waitForSessionId(planner, "session-fork-before");
|
|
1185
|
+
|
|
1186
|
+
sessionName = "fork-after";
|
|
1187
|
+
sessionId = "session-fork-after";
|
|
1188
|
+
await harness.emitLifecycle("turn_start");
|
|
1189
|
+
const replaced = await waitForSessionId(planner, "session-fork-after");
|
|
1190
|
+
assert.equal(replaced.name, "fork-after");
|
|
1191
|
+
await waitForNoSessionId(planner, "session-fork-before");
|
|
1192
|
+
} finally {
|
|
1193
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1194
|
+
await cleanup();
|
|
1195
|
+
}
|
|
1196
|
+
});
|
|
1197
|
+
|
|
1198
|
+
test("busy interactive sessions idle-gate top-level asks without aborting", { concurrency: false }, async () => {
|
|
1199
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1200
|
+
const { planner, cleanup } = await setupClients();
|
|
1201
|
+
let abortCount = 0;
|
|
1202
|
+
let idle = false;
|
|
1203
|
+
const harness = createExtensionHarness("interactive-worker", {
|
|
1204
|
+
abort: () => { abortCount += 1; },
|
|
1205
|
+
hasUI: true,
|
|
1206
|
+
isIdle: () => idle,
|
|
1207
|
+
});
|
|
1208
|
+
|
|
1209
|
+
try {
|
|
1210
|
+
piIntercomExtension(harness.pi as never);
|
|
1211
|
+
await harness.emitLifecycle("session_start");
|
|
1212
|
+
|
|
1213
|
+
const target = await waitForSessionByName(planner, "interactive-worker");
|
|
1214
|
+
|
|
1215
|
+
const delivered = await planner.send(target.id, {
|
|
1216
|
+
messageId: "interactive-busy-ask",
|
|
1217
|
+
text: "Can you respond after your current turn?",
|
|
1218
|
+
expectsReply: true,
|
|
1219
|
+
});
|
|
1220
|
+
assert.equal(delivered.delivered, true);
|
|
1221
|
+
await new Promise((resolve) => setTimeout(resolve, 250));
|
|
1222
|
+
assert.equal(abortCount, 0);
|
|
1223
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1224
|
+
|
|
1225
|
+
idle = true;
|
|
1226
|
+
await harness.emitLifecycle("agent_end");
|
|
1227
|
+
await new Promise((resolve) => setTimeout(resolve, 20));
|
|
1228
|
+
|
|
1229
|
+
assert.equal(abortCount, 0);
|
|
1230
|
+
assert.equal(harness.sentMessages.length, 1);
|
|
1231
|
+
assert.equal(harness.sentMessages[0]?.message.customType, "intercom_message");
|
|
1232
|
+
assert.equal(harness.sentMessages[0]?.options?.triggerTurn, true);
|
|
1233
|
+
assert.match(harness.sentMessages[0]?.message.content ?? "", /Can you respond after your current turn/);
|
|
1234
|
+
} finally {
|
|
1235
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1236
|
+
await cleanup();
|
|
1237
|
+
}
|
|
1238
|
+
});
|
|
1239
|
+
|
|
1240
|
+
test("duplicate inbound message IDs inject once with visible delivery metadata", { concurrency: false }, async () => {
|
|
1241
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1242
|
+
const { planner, cleanup } = await setupClients();
|
|
1243
|
+
const harness = createExtensionHarness("dedupe-worker", { hasUI: true });
|
|
1244
|
+
|
|
1245
|
+
try {
|
|
1246
|
+
piIntercomExtension(harness.pi as never);
|
|
1247
|
+
await harness.emitLifecycle("session_start");
|
|
1248
|
+
const worker = await waitForSessionByName(planner, "dedupe-worker");
|
|
1249
|
+
const receipts: string[] = [];
|
|
1250
|
+
const unsubscribeReceipts = planner.onMessageReceipt((_from, receipt) => {
|
|
1251
|
+
if (receipt.messageId === "duplicate-inbound") receipts.push(receipt.detail ? `${receipt.status}:${receipt.detail}` : receipt.status);
|
|
1252
|
+
});
|
|
1253
|
+
|
|
1254
|
+
try {
|
|
1255
|
+
assert.equal((await planner.send(worker.id, { messageId: "duplicate-inbound", text: "First copy" })).delivered, true);
|
|
1256
|
+
assert.equal((await planner.send(worker.id, { messageId: "duplicate-inbound", text: "Second copy" })).delivered, true);
|
|
1257
|
+
await new Promise((resolve) => setTimeout(resolve, 100));
|
|
1258
|
+
} finally {
|
|
1259
|
+
unsubscribeReceipts();
|
|
1260
|
+
}
|
|
1261
|
+
|
|
1262
|
+
assert.equal(harness.sentMessages.length, 1);
|
|
1263
|
+
assert.ok(receipts.includes("receiver_received"));
|
|
1264
|
+
assert.ok(receipts.includes("acknowledged:accepted by receiver"));
|
|
1265
|
+
assert.ok(receipts.includes("injected"));
|
|
1266
|
+
assert.ok(receipts.includes("acknowledged:duplicate message id suppressed"));
|
|
1267
|
+
const sent = harness.sentMessages[0]!;
|
|
1268
|
+
assert.match(sent.message.content ?? "", /id duplicate-inbound/);
|
|
1269
|
+
assert.match(sent.message.content ?? "", /seq 1/);
|
|
1270
|
+
assert.match(sent.message.content ?? "", /broker delivered/);
|
|
1271
|
+
assert.match(sent.message.content ?? "", /receiver received/);
|
|
1272
|
+
assert.match(sent.message.content ?? "", /injected/);
|
|
1273
|
+
const details = sent.message.details as { message?: Message };
|
|
1274
|
+
assert.equal(details.message?.id, "duplicate-inbound");
|
|
1275
|
+
assert.equal(details.message?.senderSequence, 1);
|
|
1276
|
+
assert.equal(typeof details.message?.brokerReceivedAt, "number");
|
|
1277
|
+
assert.equal(typeof details.message?.brokerDeliveredAt, "number");
|
|
1278
|
+
assert.equal(typeof details.message?.receiverReceivedAt, "number");
|
|
1279
|
+
assert.equal(typeof details.message?.injectedAt, "number");
|
|
1280
|
+
} finally {
|
|
1281
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1282
|
+
await cleanup();
|
|
1283
|
+
}
|
|
1284
|
+
});
|
|
1285
|
+
|
|
1286
|
+
test("busy interactive sessions keep same-sender queued messages in sequence order", { concurrency: false }, async () => {
|
|
1287
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1288
|
+
const { planner, cleanup } = await setupClients();
|
|
1289
|
+
let idle = false;
|
|
1290
|
+
const harness = createExtensionHarness("sequence-worker", {
|
|
1291
|
+
hasUI: true,
|
|
1292
|
+
isIdle: () => idle,
|
|
1293
|
+
});
|
|
1294
|
+
|
|
1295
|
+
try {
|
|
1296
|
+
piIntercomExtension(harness.pi as never);
|
|
1297
|
+
await harness.emitLifecycle("session_start");
|
|
1298
|
+
const worker = await waitForSessionByName(planner, "sequence-worker");
|
|
1299
|
+
const receipts = new Map<string, string[]>();
|
|
1300
|
+
const unsubscribeReceipts = planner.onMessageReceipt((_from, receipt) => {
|
|
1301
|
+
const statuses = receipts.get(receipt.messageId) ?? [];
|
|
1302
|
+
statuses.push(receipt.status);
|
|
1303
|
+
receipts.set(receipt.messageId, statuses);
|
|
1304
|
+
});
|
|
1305
|
+
|
|
1306
|
+
assert.equal((await planner.send(worker.id, { messageId: "sequence-1", text: "First queued message" })).delivered, true);
|
|
1307
|
+
assert.equal((await planner.send(worker.id, { messageId: "sequence-2", text: "Second queued message" })).delivered, true);
|
|
1308
|
+
await new Promise((resolve) => setTimeout(resolve, 100));
|
|
1309
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1310
|
+
|
|
1311
|
+
idle = true;
|
|
1312
|
+
await harness.emitLifecycle("agent_end");
|
|
1313
|
+
await new Promise((resolve) => setTimeout(resolve, 100));
|
|
1314
|
+
|
|
1315
|
+
assert.equal(harness.sentMessages.length, 2);
|
|
1316
|
+
assert.match(harness.sentMessages[0]?.message.content ?? "", /First queued message/);
|
|
1317
|
+
assert.match(harness.sentMessages[1]?.message.content ?? "", /Second queued message/);
|
|
1318
|
+
assert.equal(harness.sentMessages[0]?.options?.triggerTurn, true);
|
|
1319
|
+
assert.equal(harness.sentMessages[1]?.options?.deliverAs, "followUp");
|
|
1320
|
+
const firstDetails = harness.sentMessages[0]?.message.details as { message?: Message } | undefined;
|
|
1321
|
+
const secondDetails = harness.sentMessages[1]?.message.details as { message?: Message } | undefined;
|
|
1322
|
+
assert.equal(firstDetails?.message?.senderSequence, 1);
|
|
1323
|
+
assert.equal(secondDetails?.message?.senderSequence, 2);
|
|
1324
|
+
assert.deepEqual(receipts.get("sequence-1"), ["receiver_received", "acknowledged", "queued", "injected"]);
|
|
1325
|
+
assert.deepEqual(receipts.get("sequence-2"), ["receiver_received", "acknowledged", "queued", "injected"]);
|
|
1326
|
+
unsubscribeReceipts();
|
|
1327
|
+
} finally {
|
|
1328
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1329
|
+
await cleanup();
|
|
1330
|
+
}
|
|
1331
|
+
});
|
|
1332
|
+
|
|
1333
|
+
test("explicit cancel removes a queued inbound message before injection", { concurrency: false }, async () => {
|
|
1334
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1335
|
+
const { planner, cleanup } = await setupClients();
|
|
1336
|
+
let idle = false;
|
|
1337
|
+
const harness = createExtensionHarness("cancel-worker", {
|
|
1338
|
+
hasUI: true,
|
|
1339
|
+
isIdle: () => idle,
|
|
1340
|
+
});
|
|
1341
|
+
|
|
1342
|
+
try {
|
|
1343
|
+
piIntercomExtension(harness.pi as never);
|
|
1344
|
+
await harness.emitLifecycle("session_start");
|
|
1345
|
+
const worker = await waitForSessionByName(planner, "cancel-worker");
|
|
1346
|
+
const receipts: string[] = [];
|
|
1347
|
+
const unsubscribeReceipts = planner.onMessageReceipt((_from, receipt) => {
|
|
1348
|
+
if (receipt.messageId === "cancel-queued") receipts.push(receipt.status);
|
|
1349
|
+
});
|
|
1350
|
+
|
|
1351
|
+
assert.equal((await planner.send(worker.id, { messageId: "cancel-queued", text: "Cancel this before delivery", expectsReply: true })).delivered, true);
|
|
1352
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
1353
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1354
|
+
assert.equal((await planner.cancelMessage("cancel-queued")).delivered, true);
|
|
1355
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
1356
|
+
|
|
1357
|
+
idle = true;
|
|
1358
|
+
await harness.emitLifecycle("agent_end");
|
|
1359
|
+
await new Promise((resolve) => setTimeout(resolve, 100));
|
|
1360
|
+
|
|
1361
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1362
|
+
assert.deepEqual(receipts, ["receiver_received", "acknowledged", "queued", "cancelled"]);
|
|
1363
|
+
unsubscribeReceipts();
|
|
1364
|
+
} finally {
|
|
1365
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1366
|
+
await cleanup();
|
|
1367
|
+
}
|
|
1368
|
+
});
|
|
1369
|
+
|
|
1370
|
+
test("intercom cancel action requests cancellation for a sent message", { concurrency: false }, async () => {
|
|
1371
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1372
|
+
const { planner, cleanup } = await setupClients();
|
|
1373
|
+
let idle = false;
|
|
1374
|
+
const senderHarness = createExtensionHarness("cancel-sender", { sessionId: "session-cancel-sender" });
|
|
1375
|
+
const receiverHarness = createExtensionHarness("cancel-tool-worker", {
|
|
1376
|
+
hasUI: true,
|
|
1377
|
+
isIdle: () => idle,
|
|
1378
|
+
sessionId: "session-cancel-tool-worker",
|
|
1379
|
+
});
|
|
1380
|
+
|
|
1381
|
+
try {
|
|
1382
|
+
piIntercomExtension(senderHarness.pi as never);
|
|
1383
|
+
piIntercomExtension(receiverHarness.pi as never);
|
|
1384
|
+
await senderHarness.emitLifecycle("session_start");
|
|
1385
|
+
await receiverHarness.emitLifecycle("session_start");
|
|
1386
|
+
await waitForSessionByName(planner, "cancel-tool-worker");
|
|
1387
|
+
const intercomTool = senderHarness.tools.find((tool) => tool.name === "intercom")!;
|
|
1388
|
+
|
|
1389
|
+
const sendResult = await intercomTool.execute("send-before-cancel", { action: "send", to: "cancel-tool-worker", message: "Cancel this through the tool" }, new AbortController().signal, undefined, senderHarness.ctx);
|
|
1390
|
+
const messageId = String(sendResult.details?.messageId);
|
|
1391
|
+
assert.equal(sendResult.details?.delivered, true);
|
|
1392
|
+
assert.notEqual(messageId, "undefined");
|
|
1393
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
1394
|
+
assert.equal(receiverHarness.sentMessages.length, 0);
|
|
1395
|
+
|
|
1396
|
+
const cancelResult = await intercomTool.execute("cancel-message", { action: "cancel", messageId }, new AbortController().signal, undefined, senderHarness.ctx);
|
|
1397
|
+
assert.equal(cancelResult.details?.delivered, true);
|
|
1398
|
+
assert.match(cancelResult.content[0]?.text ?? "", /Cancellation requested/);
|
|
1399
|
+
|
|
1400
|
+
idle = true;
|
|
1401
|
+
await receiverHarness.emitLifecycle("agent_end");
|
|
1402
|
+
await new Promise((resolve) => setTimeout(resolve, 100));
|
|
1403
|
+
assert.equal(receiverHarness.sentMessages.length, 0);
|
|
1404
|
+
} finally {
|
|
1405
|
+
await senderHarness.emitLifecycle("session_shutdown");
|
|
1406
|
+
await receiverHarness.emitLifecycle("session_shutdown");
|
|
1407
|
+
await cleanup();
|
|
1408
|
+
}
|
|
1409
|
+
});
|
|
1410
|
+
|
|
1411
|
+
test("same-sender supersede replaces a queued inbound message", { concurrency: false }, async () => {
|
|
1412
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1413
|
+
const { planner, cleanup } = await setupClients();
|
|
1414
|
+
let idle = false;
|
|
1415
|
+
const harness = createExtensionHarness("supersede-worker", {
|
|
1416
|
+
hasUI: true,
|
|
1417
|
+
isIdle: () => idle,
|
|
1418
|
+
});
|
|
1419
|
+
|
|
1420
|
+
try {
|
|
1421
|
+
piIntercomExtension(harness.pi as never);
|
|
1422
|
+
await harness.emitLifecycle("session_start");
|
|
1423
|
+
const worker = await waitForSessionByName(planner, "supersede-worker");
|
|
1424
|
+
const receipts = new Map<string, string[]>();
|
|
1425
|
+
const unsubscribeReceipts = planner.onMessageReceipt((_from, receipt) => {
|
|
1426
|
+
const statuses = receipts.get(receipt.messageId) ?? [];
|
|
1427
|
+
statuses.push(receipt.status);
|
|
1428
|
+
receipts.set(receipt.messageId, statuses);
|
|
1429
|
+
});
|
|
1430
|
+
|
|
1431
|
+
assert.equal((await planner.send(worker.id, { messageId: "superseded-message", text: "Old queued message", expectsReply: true })).delivered, true);
|
|
1432
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
1433
|
+
const replacement = await planner.send(worker.id, { messageId: "replacement-message", text: "Replacement message", supersedes: "superseded-message" });
|
|
1434
|
+
assert.equal(replacement.delivered, true);
|
|
1435
|
+
|
|
1436
|
+
idle = true;
|
|
1437
|
+
await harness.emitLifecycle("agent_end");
|
|
1438
|
+
await new Promise((resolve) => setTimeout(resolve, 100));
|
|
1439
|
+
|
|
1440
|
+
assert.equal(harness.sentMessages.length, 1);
|
|
1441
|
+
assert.doesNotMatch(harness.sentMessages[0]?.message.content ?? "", /Old queued message/);
|
|
1442
|
+
assert.match(harness.sentMessages[0]?.message.content ?? "", /Replacement message/);
|
|
1443
|
+
const details = harness.sentMessages[0]?.message.details as { message?: Message } | undefined;
|
|
1444
|
+
assert.equal(details?.message?.supersedes, "superseded-message");
|
|
1445
|
+
assert.deepEqual(receipts.get("superseded-message"), ["receiver_received", "acknowledged", "queued", "superseded"]);
|
|
1446
|
+
assert.deepEqual(receipts.get("replacement-message"), ["receiver_received", "acknowledged", "queued", "injected"]);
|
|
1447
|
+
unsubscribeReceipts();
|
|
1448
|
+
} finally {
|
|
1449
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1450
|
+
await cleanup();
|
|
1451
|
+
}
|
|
1452
|
+
});
|
|
1453
|
+
|
|
1454
|
+
test("supersede is scoped to the same sender and receiver", { concurrency: false }, async () => {
|
|
1455
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1456
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
1457
|
+
let idle = false;
|
|
1458
|
+
const firstHarness = createExtensionHarness("supersede-first", {
|
|
1459
|
+
hasUI: true,
|
|
1460
|
+
isIdle: () => idle,
|
|
1461
|
+
});
|
|
1462
|
+
const secondHarness = createExtensionHarness("supersede-second", {
|
|
1463
|
+
hasUI: true,
|
|
1464
|
+
isIdle: () => idle,
|
|
1465
|
+
sessionId: "session-supersede-second",
|
|
1466
|
+
});
|
|
1467
|
+
|
|
1468
|
+
try {
|
|
1469
|
+
piIntercomExtension(firstHarness.pi as never);
|
|
1470
|
+
piIntercomExtension(secondHarness.pi as never);
|
|
1471
|
+
await firstHarness.emitLifecycle("session_start");
|
|
1472
|
+
await secondHarness.emitLifecycle("session_start");
|
|
1473
|
+
const first = await waitForSessionByName(planner, "supersede-first");
|
|
1474
|
+
const second = await waitForSessionByName(planner, "supersede-second");
|
|
1475
|
+
|
|
1476
|
+
assert.equal((await planner.send(first.id, { messageId: "wrong-target-old", text: "Old target" })).delivered, true);
|
|
1477
|
+
const wrongReceiver = await planner.send(second.id, { messageId: "wrong-target-new", text: "Wrong receiver", supersedes: "wrong-target-old" });
|
|
1478
|
+
assert.equal(wrongReceiver.delivered, false);
|
|
1479
|
+
assert.match(wrongReceiver.reason ?? "", /same sender and receiver|previous message/);
|
|
1480
|
+
|
|
1481
|
+
const wrongSender = await orchestrator.send(first.id, { messageId: "wrong-sender-new", text: "Wrong sender", supersedes: "wrong-target-old" });
|
|
1482
|
+
assert.equal(wrongSender.delivered, false);
|
|
1483
|
+
assert.match(wrongSender.reason ?? "", /same sender and receiver|previous message/);
|
|
1484
|
+
} finally {
|
|
1485
|
+
await firstHarness.emitLifecycle("session_shutdown");
|
|
1486
|
+
await secondHarness.emitLifecycle("session_shutdown");
|
|
1487
|
+
await cleanup();
|
|
1488
|
+
}
|
|
1489
|
+
});
|
|
1490
|
+
|
|
1491
|
+
test("replied idle-gated asks are discarded before delivery", { concurrency: false }, async () => {
|
|
1492
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1493
|
+
const { planner, cleanup } = await setupClients();
|
|
1494
|
+
let idle = false;
|
|
1495
|
+
const harness = createExtensionHarness("reply-while-busy-worker", {
|
|
1496
|
+
hasUI: true,
|
|
1497
|
+
isIdle: () => idle,
|
|
1498
|
+
});
|
|
1499
|
+
|
|
1500
|
+
try {
|
|
1501
|
+
piIntercomExtension(harness.pi as never);
|
|
1502
|
+
await harness.emitLifecycle("session_start");
|
|
1503
|
+
const worker = await waitForSessionByName(planner, "reply-while-busy-worker");
|
|
1504
|
+
|
|
1505
|
+
const askId = "reply-while-busy-ask";
|
|
1506
|
+
const replyReceived = waitForReply(planner, askId);
|
|
1507
|
+
assert.equal((await planner.send(worker.id, {
|
|
1508
|
+
messageId: askId,
|
|
1509
|
+
text: "Can you answer before this turn ends?",
|
|
1510
|
+
expectsReply: true,
|
|
1511
|
+
})).delivered, true);
|
|
1512
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
1513
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1514
|
+
|
|
1515
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
1516
|
+
const result = await intercomTool.execute("reply-while-busy", {
|
|
1517
|
+
action: "reply",
|
|
1518
|
+
message: "Answered during the current turn.",
|
|
1519
|
+
replyTo: askId,
|
|
1520
|
+
}, new AbortController().signal, undefined, harness.ctx);
|
|
1521
|
+
assert.equal(result.details?.delivered, true);
|
|
1522
|
+
assert.equal((await replyReceived).message.replyTo, askId);
|
|
1523
|
+
|
|
1524
|
+
idle = true;
|
|
1525
|
+
await harness.emitLifecycle("agent_end");
|
|
1526
|
+
await new Promise((resolve) => setTimeout(resolve, 250));
|
|
1527
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1528
|
+
} finally {
|
|
1529
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1530
|
+
await cleanup();
|
|
1531
|
+
}
|
|
1532
|
+
});
|
|
1533
|
+
|
|
1534
|
+
test("deferred startup connect is cancelled on shutdown", { concurrency: false }, async () => {
|
|
1535
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1536
|
+
const { planner, cleanup } = await setupClients();
|
|
1537
|
+
const harness = createExtensionHarness("shutdown-before-start", { hasUI: true });
|
|
1538
|
+
|
|
1539
|
+
try {
|
|
1540
|
+
piIntercomExtension(harness.pi as never);
|
|
1541
|
+
await harness.emitLifecycle("session_start");
|
|
1542
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1543
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
1544
|
+
|
|
1545
|
+
const sessions = await planner.listSessions();
|
|
1546
|
+
assert.equal(sessions.some((session) => session.name === "shutdown-before-start"), false);
|
|
1547
|
+
} finally {
|
|
1548
|
+
await cleanup();
|
|
1549
|
+
}
|
|
1550
|
+
});
|
|
1551
|
+
|
|
1552
|
+
test("stale overlay work stops after same-session restart", { concurrency: false }, async () => {
|
|
1553
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1554
|
+
const { planner, cleanup } = await setupClients();
|
|
1555
|
+
let customCalls = 0;
|
|
1556
|
+
let resolveFirstCustom: ((value: unknown) => void) | undefined;
|
|
1557
|
+
const ui = {
|
|
1558
|
+
notify: () => undefined,
|
|
1559
|
+
custom: async () => {
|
|
1560
|
+
customCalls += 1;
|
|
1561
|
+
if (customCalls > 1) {
|
|
1562
|
+
return { sent: false };
|
|
1563
|
+
}
|
|
1564
|
+
return new Promise((resolve) => {
|
|
1565
|
+
resolveFirstCustom = resolve;
|
|
1566
|
+
});
|
|
1567
|
+
},
|
|
1568
|
+
};
|
|
1569
|
+
const harness = createExtensionHarness("overlay-worker", { hasUI: true, ui });
|
|
1570
|
+
|
|
1571
|
+
try {
|
|
1572
|
+
piIntercomExtension(harness.pi as never);
|
|
1573
|
+
await harness.emitLifecycle("session_start");
|
|
1574
|
+
await waitForSessionByName(planner, "overlay-worker");
|
|
1575
|
+
|
|
1576
|
+
const overlayPromise = Promise.resolve(harness.commands.get("intercom")!("", harness.ctx));
|
|
1577
|
+
const deadline = Date.now() + 2000;
|
|
1578
|
+
while (!resolveFirstCustom && Date.now() < deadline) {
|
|
1579
|
+
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
1580
|
+
}
|
|
1581
|
+
assert.ok(resolveFirstCustom, "overlay should reach the session picker");
|
|
1582
|
+
|
|
1583
|
+
const plannerSession = await waitForSessionByName(planner, "planner");
|
|
1584
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1585
|
+
await harness.emitLifecycle("session_start");
|
|
1586
|
+
resolveFirstCustom(plannerSession);
|
|
1587
|
+
await overlayPromise;
|
|
1588
|
+
|
|
1589
|
+
assert.equal(customCalls, 1);
|
|
1590
|
+
} finally {
|
|
1591
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1592
|
+
await cleanup();
|
|
1593
|
+
}
|
|
1594
|
+
});
|
|
1595
|
+
|
|
1596
|
+
test("queued inbound messages are discarded after shutdown", { concurrency: false }, async () => {
|
|
1597
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1598
|
+
const { planner, cleanup } = await setupClients();
|
|
1599
|
+
let idle = false;
|
|
1600
|
+
const harness = createExtensionHarness("disposed-worker", {
|
|
1601
|
+
hasUI: true,
|
|
1602
|
+
isIdle: () => idle,
|
|
1603
|
+
});
|
|
1604
|
+
|
|
1605
|
+
try {
|
|
1606
|
+
piIntercomExtension(harness.pi as never);
|
|
1607
|
+
await harness.emitLifecycle("session_start");
|
|
1608
|
+
const target = await waitForSessionByName(planner, "disposed-worker");
|
|
1609
|
+
const receipts: string[] = [];
|
|
1610
|
+
const unsubscribeReceipts = planner.onMessageReceipt((_from, receipt) => {
|
|
1611
|
+
if (receipt.messageId === "disposed-ask") receipts.push(receipt.status);
|
|
1612
|
+
});
|
|
1613
|
+
|
|
1614
|
+
const delivered = await planner.send(target.id, {
|
|
1615
|
+
messageId: "disposed-ask",
|
|
1616
|
+
text: "This should not deliver after shutdown.",
|
|
1617
|
+
expectsReply: true,
|
|
1618
|
+
});
|
|
1619
|
+
assert.equal(delivered.delivered, true);
|
|
1620
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
1621
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1622
|
+
|
|
1623
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1624
|
+
idle = true;
|
|
1625
|
+
await harness.emitLifecycle("agent_end");
|
|
1626
|
+
await new Promise((resolve) => setTimeout(resolve, 250));
|
|
1627
|
+
|
|
1628
|
+
assert.equal(harness.sentMessages.length, 0);
|
|
1629
|
+
assert.deepEqual(receipts, ["receiver_received", "acknowledged", "queued", "expired"]);
|
|
1630
|
+
unsubscribeReceipts();
|
|
1631
|
+
} finally {
|
|
1632
|
+
await cleanup();
|
|
1633
|
+
}
|
|
1634
|
+
});
|
|
1635
|
+
|
|
1636
|
+
test("busy non-interactive sessions auto-reply to top-level asks without aborting", { concurrency: false }, async () => {
|
|
1637
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1638
|
+
const { planner, cleanup } = await setupClients();
|
|
1639
|
+
let abortCount = 0;
|
|
1640
|
+
const harness = createExtensionHarness("pipe-worker", {
|
|
1641
|
+
abort: () => { abortCount += 1; },
|
|
1642
|
+
hasUI: false,
|
|
1643
|
+
isIdle: () => false,
|
|
1644
|
+
});
|
|
1645
|
+
|
|
1646
|
+
try {
|
|
1647
|
+
piIntercomExtension(harness.pi as never);
|
|
1648
|
+
await harness.emitLifecycle("session_start");
|
|
1649
|
+
|
|
1650
|
+
const target = await waitForSessionByName(planner, "pipe-worker");
|
|
1651
|
+
|
|
1652
|
+
const askId = "pipe-mode-ask";
|
|
1653
|
+
const replyPromise = waitForReply(planner, askId, 1000);
|
|
1654
|
+
const delivered = await planner.send(target.id, {
|
|
1655
|
+
messageId: askId,
|
|
1656
|
+
text: "Can you respond while busy?",
|
|
1657
|
+
expectsReply: true,
|
|
1658
|
+
});
|
|
1659
|
+
assert.equal(delivered.delivered, true);
|
|
1660
|
+
|
|
1661
|
+
const reply = await replyPromise;
|
|
1662
|
+
assert.equal(reply.message.replyTo, askId);
|
|
1663
|
+
assert.match(reply.message.content.text, /non-interactive|cannot respond/i);
|
|
1664
|
+
assert.equal(abortCount, 0);
|
|
1665
|
+
|
|
1666
|
+
} finally {
|
|
1667
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1668
|
+
await cleanup();
|
|
1669
|
+
}
|
|
1670
|
+
});
|
|
1671
|
+
|
|
1672
|
+
test("supervisor tool registers only when child metadata is present", async () => {
|
|
1673
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1674
|
+
|
|
1675
|
+
await withChildOrchestratorEnv({}, () => {
|
|
1676
|
+
const harness = createExtensionHarness();
|
|
1677
|
+
piIntercomExtension(harness.pi as never);
|
|
1678
|
+
assert.deepEqual(harness.tools.map((tool) => tool.name), ["intercom"]);
|
|
1679
|
+
});
|
|
1680
|
+
|
|
1681
|
+
await withChildOrchestratorEnv({
|
|
1682
|
+
orchestratorTarget: "orchestrator",
|
|
1683
|
+
runId: "78f659a3",
|
|
1684
|
+
agent: "worker",
|
|
1685
|
+
index: "0",
|
|
1686
|
+
sessionName: "subagent-worker-78f659a3-1",
|
|
1687
|
+
}, () => {
|
|
1688
|
+
const harness = createExtensionHarness();
|
|
1689
|
+
piIntercomExtension(harness.pi as never);
|
|
1690
|
+
assert.deepEqual(harness.tools.map((tool) => tool.name), ["contact_supervisor", "intercom"]);
|
|
1691
|
+
const supervisorTool = harness.tools.find((tool) => tool.name === "contact_supervisor");
|
|
1692
|
+
assert.match(JSON.stringify(supervisorTool?.parameters), /interview_request/);
|
|
1693
|
+
assert.match(JSON.stringify(supervisorTool?.parameters), /questions/);
|
|
1694
|
+
});
|
|
1695
|
+
|
|
1696
|
+
await withChildOrchestratorEnv({
|
|
1697
|
+
orchestratorTarget: "orchestrator",
|
|
1698
|
+
runId: "78f659a3",
|
|
1699
|
+
agent: "worker",
|
|
1700
|
+
index: "0",
|
|
1701
|
+
supervisorChannelDir: path.join(sharedHomeDir, "native-supervisor-channel"),
|
|
1702
|
+
}, () => {
|
|
1703
|
+
const harness = createExtensionHarness();
|
|
1704
|
+
piIntercomExtension(harness.pi as never);
|
|
1705
|
+
assert.deepEqual(harness.tools.map((tool) => tool.name), ["intercom"]);
|
|
1706
|
+
});
|
|
1707
|
+
});
|
|
1708
|
+
|
|
1709
|
+
test("child supervisor tool resolves target and includes run metadata", { concurrency: false }, async () => {
|
|
1710
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1711
|
+
const { orchestrator, cleanup } = await setupClients();
|
|
1712
|
+
|
|
1713
|
+
try {
|
|
1714
|
+
await withChildOrchestratorEnv({
|
|
1715
|
+
orchestratorTarget: "orchestrator",
|
|
1716
|
+
runId: "78f659a3",
|
|
1717
|
+
agent: "worker",
|
|
1718
|
+
index: "0",
|
|
1719
|
+
sessionName: "subagent-worker-78f659a3-1",
|
|
1720
|
+
}, async () => {
|
|
1721
|
+
const harness = createExtensionHarness("subagent-worker-78f659a3-1");
|
|
1722
|
+
piIntercomExtension(harness.pi as never);
|
|
1723
|
+
await harness.emitLifecycle("session_start");
|
|
1724
|
+
|
|
1725
|
+
const supervisorTool = harness.tools.find((tool) => tool.name === "contact_supervisor")!;
|
|
1726
|
+
|
|
1727
|
+
const askReceived = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
1728
|
+
const askResultPromise = supervisorTool.execute("ask-1", { reason: "need_decision", message: "Which API should I use?" }, new AbortController().signal, undefined, harness.ctx);
|
|
1729
|
+
const [askFrom, askMessage] = await askReceived;
|
|
1730
|
+
assert.equal(askMessage.expectsReply, true);
|
|
1731
|
+
assert.match(askMessage.content.text, /Subagent needs a supervisor decision/);
|
|
1732
|
+
assert.match(askMessage.content.text, /Run: 78f659a3/);
|
|
1733
|
+
assert.match(askMessage.content.text, /Agent: worker/);
|
|
1734
|
+
assert.match(askMessage.content.text, /Child index: 0/);
|
|
1735
|
+
assert.match(askMessage.content.text, /Which API should I use\?/);
|
|
1736
|
+
|
|
1737
|
+
const reply = await orchestrator.send(askFrom.id, { text: "Use the stable API.", replyTo: askMessage.id });
|
|
1738
|
+
assert.equal(reply.delivered, true);
|
|
1739
|
+
const askResult = await askResultPromise;
|
|
1740
|
+
assert.notEqual(askResult.details?.error, true);
|
|
1741
|
+
assert.match(askResult.content[0]?.text ?? "", /Use the stable API/);
|
|
1742
|
+
|
|
1743
|
+
const updateReceived = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
1744
|
+
const updateResult = await supervisorTool.execute("update-1", { reason: "progress_update", message: "Found a schema mismatch." }, new AbortController().signal, undefined, harness.ctx);
|
|
1745
|
+
const [_updateFrom, updateMessage] = await updateReceived;
|
|
1746
|
+
assert.equal(updateMessage.expectsReply, undefined);
|
|
1747
|
+
assert.match(updateMessage.content.text, /Subagent progress update/);
|
|
1748
|
+
assert.match(updateMessage.content.text, /Run: 78f659a3/);
|
|
1749
|
+
assert.match(updateMessage.content.text, /Agent: worker/);
|
|
1750
|
+
assert.match(updateMessage.content.text, /Found a schema mismatch/);
|
|
1751
|
+
assert.notEqual(updateResult.details?.error, true);
|
|
1752
|
+
|
|
1753
|
+
const interviewReceived = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
1754
|
+
const interview = {
|
|
1755
|
+
title: "API migration choices",
|
|
1756
|
+
description: "Choose the implementation path before edits continue.",
|
|
1757
|
+
questions: [
|
|
1758
|
+
{ id: "context", type: "info", question: "Migration context", context: "Use the existing auth boundary." },
|
|
1759
|
+
{ id: "api", type: "single", question: "Which API should I target?", options: [" Stable API ", "Experimental API"] },
|
|
1760
|
+
{ id: "notes", type: "text", question: "Any constraints to preserve?" },
|
|
1761
|
+
],
|
|
1762
|
+
};
|
|
1763
|
+
const interviewResultPromise = supervisorTool.execute("interview-1", {
|
|
1764
|
+
reason: "interview_request",
|
|
1765
|
+
message: "Please answer both so I can continue safely.",
|
|
1766
|
+
interview,
|
|
1767
|
+
}, new AbortController().signal, undefined, harness.ctx);
|
|
1768
|
+
const [interviewFrom, interviewMessage] = await interviewReceived;
|
|
1769
|
+
assert.equal(interviewMessage.expectsReply, true);
|
|
1770
|
+
assert.match(interviewMessage.content.text, /Subagent requests a structured supervisor interview/);
|
|
1771
|
+
assert.match(interviewMessage.content.text, /Interview: API migration choices/);
|
|
1772
|
+
assert.match(interviewMessage.content.text, /\[context\] \(info\) Migration context/);
|
|
1773
|
+
assert.match(interviewMessage.content.text, /Info questions are context-only/);
|
|
1774
|
+
assert.match(interviewMessage.content.text, /\[api\] \(single\) Which API should I target\?/);
|
|
1775
|
+
assert.match(interviewMessage.content.text, / - Stable API/);
|
|
1776
|
+
assert.match(interviewMessage.content.text, /\[notes\] \(text\) Any constraints to preserve\?/);
|
|
1777
|
+
assert.match(interviewMessage.content.text, /"responses"/);
|
|
1778
|
+
assert.doesNotMatch(interviewMessage.content.text, /"id": "context"/);
|
|
1779
|
+
|
|
1780
|
+
const structuredReply = {
|
|
1781
|
+
responses: [
|
|
1782
|
+
{ id: "api", value: "Stable API" },
|
|
1783
|
+
{ id: "notes", value: "Keep the public error shape unchanged." },
|
|
1784
|
+
],
|
|
1785
|
+
};
|
|
1786
|
+
const interviewReply = await orchestrator.send(interviewFrom.id, {
|
|
1787
|
+
text: `\`\`\`json\n${JSON.stringify(structuredReply, null, 2)}\n\`\`\``,
|
|
1788
|
+
replyTo: interviewMessage.id,
|
|
1789
|
+
});
|
|
1790
|
+
assert.equal(interviewReply.delivered, true);
|
|
1791
|
+
const interviewResult = await interviewResultPromise;
|
|
1792
|
+
assert.notEqual(interviewResult.details?.error, true);
|
|
1793
|
+
assert.match(interviewResult.content[0]?.text ?? "", /Stable API/);
|
|
1794
|
+
assert.deepEqual(interviewResult.details?.structuredReply, structuredReply);
|
|
1795
|
+
|
|
1796
|
+
const invalidReplyReceived = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
1797
|
+
const invalidReplyResultPromise = supervisorTool.execute("interview-invalid-reply", {
|
|
1798
|
+
reason: "interview_request",
|
|
1799
|
+
interview,
|
|
1800
|
+
}, new AbortController().signal, undefined, harness.ctx);
|
|
1801
|
+
const [invalidReplyFrom, invalidReplyMessage] = await invalidReplyReceived;
|
|
1802
|
+
const invalidReply = await orchestrator.send(invalidReplyFrom.id, {
|
|
1803
|
+
text: '{"responses":[{"id":"api","value":"Removed API"}]}',
|
|
1804
|
+
replyTo: invalidReplyMessage.id,
|
|
1805
|
+
});
|
|
1806
|
+
assert.equal(invalidReply.delivered, true);
|
|
1807
|
+
const invalidReplyResult = await invalidReplyResultPromise;
|
|
1808
|
+
assert.notEqual(invalidReplyResult.details?.error, true);
|
|
1809
|
+
assert.equal(invalidReplyResult.details?.structuredReply, undefined);
|
|
1810
|
+
assert.match(String(invalidReplyResult.details?.structuredReplyParseError), /must match one of the question options/);
|
|
1811
|
+
|
|
1812
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1813
|
+
});
|
|
1814
|
+
} finally {
|
|
1815
|
+
await cleanup();
|
|
1816
|
+
}
|
|
1817
|
+
});
|
|
1818
|
+
|
|
1819
|
+
test("child supervisor tool uses stable supervisor ID when names are duplicated", { concurrency: false }, async () => {
|
|
1820
|
+
const { orchestrator, cleanup } = await setupClients();
|
|
1821
|
+
const duplicate = new IntercomClient();
|
|
1822
|
+
|
|
1823
|
+
try {
|
|
1824
|
+
await duplicate.connect({
|
|
1825
|
+
name: "orchestrator",
|
|
1826
|
+
cwd: repoDir,
|
|
1827
|
+
model: "test-model",
|
|
1828
|
+
pid: process.pid,
|
|
1829
|
+
startedAt: Date.now(),
|
|
1830
|
+
lastActivity: Date.now(),
|
|
1831
|
+
}, "duplicate-orchestrator-id");
|
|
1832
|
+
|
|
1833
|
+
await withChildOrchestratorEnv({
|
|
1834
|
+
orchestratorTarget: "orchestrator",
|
|
1835
|
+
orchestratorSessionId: orchestrator.sessionId!,
|
|
1836
|
+
runId: "78f659a3",
|
|
1837
|
+
agent: "worker",
|
|
1838
|
+
index: "0",
|
|
1839
|
+
}, async () => {
|
|
1840
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1841
|
+
const harness = createExtensionHarness("duplicate-name-child");
|
|
1842
|
+
piIntercomExtension(harness.pi as never);
|
|
1843
|
+
await harness.emitLifecycle("session_start");
|
|
1844
|
+
const supervisorTool = harness.tools.find((tool) => tool.name === "contact_supervisor")!;
|
|
1845
|
+
|
|
1846
|
+
const received = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
1847
|
+
const result = await supervisorTool.execute("update-duplicate", { reason: "progress_update", message: "Stable ID route." }, new AbortController().signal, undefined, harness.ctx);
|
|
1848
|
+
const [, message] = await received;
|
|
1849
|
+
assert.notEqual(result.details?.error, true);
|
|
1850
|
+
assert.match(message.content.text, /Stable ID route/);
|
|
1851
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1852
|
+
});
|
|
1853
|
+
} finally {
|
|
1854
|
+
await duplicate.disconnect().catch(() => undefined);
|
|
1855
|
+
await cleanup();
|
|
1856
|
+
}
|
|
1857
|
+
});
|
|
1858
|
+
|
|
1859
|
+
test("child supervisor tool rejects invalid reasons and interview payloads", async () => {
|
|
1860
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1861
|
+
|
|
1862
|
+
await withChildOrchestratorEnv({
|
|
1863
|
+
orchestratorTarget: "orchestrator",
|
|
1864
|
+
runId: "78f659a3",
|
|
1865
|
+
agent: "worker",
|
|
1866
|
+
index: "0",
|
|
1867
|
+
}, async () => {
|
|
1868
|
+
const harness = createExtensionHarness();
|
|
1869
|
+
piIntercomExtension(harness.pi as never);
|
|
1870
|
+
const supervisorTool = harness.tools.find((tool) => tool.name === "contact_supervisor")!;
|
|
1871
|
+
const result = await supervisorTool.execute("invalid-1", { reason: "done", message: "Finished." }, new AbortController().signal, undefined, harness.ctx);
|
|
1872
|
+
assert.equal(result.details?.error, true);
|
|
1873
|
+
assert.match(result.content[0]?.text ?? "", /Invalid reason/);
|
|
1874
|
+
|
|
1875
|
+
const missingMessageResult = await supervisorTool.execute("invalid-message", { reason: "need_decision" }, new AbortController().signal, undefined, harness.ctx);
|
|
1876
|
+
assert.equal(missingMessageResult.details?.error, true);
|
|
1877
|
+
assert.match(missingMessageResult.content[0]?.text ?? "", /Missing 'message'/);
|
|
1878
|
+
|
|
1879
|
+
const invalidInterviewResult = await supervisorTool.execute("invalid-interview", { reason: "interview_request", interview: { title: "Bad" } }, new AbortController().signal, undefined, harness.ctx);
|
|
1880
|
+
assert.equal(invalidInterviewResult.details?.error, true);
|
|
1881
|
+
assert.match(invalidInterviewResult.content[0]?.text ?? "", /interview\.questions must be a non-empty array/);
|
|
1882
|
+
|
|
1883
|
+
const invalidInfoOptionsResult = await supervisorTool.execute("invalid-info-options", {
|
|
1884
|
+
reason: "interview_request",
|
|
1885
|
+
interview: {
|
|
1886
|
+
questions: [{ id: "context", type: "info", question: "Context", options: ["Not an answer"] }],
|
|
1887
|
+
},
|
|
1888
|
+
}, new AbortController().signal, undefined, harness.ctx);
|
|
1889
|
+
assert.equal(invalidInfoOptionsResult.details?.error, true);
|
|
1890
|
+
assert.match(invalidInfoOptionsResult.content[0]?.text ?? "", /options is only valid for single and multi questions/);
|
|
1891
|
+
});
|
|
1892
|
+
});
|
|
1893
|
+
|
|
1894
|
+
test("child supervisor tool preserves delivery failure reasons", { concurrency: false }, async () => {
|
|
1895
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1896
|
+
const { cleanup } = await setupClients();
|
|
1897
|
+
|
|
1898
|
+
try {
|
|
1899
|
+
await withChildOrchestratorEnv({
|
|
1900
|
+
orchestratorTarget: "missing-orchestrator",
|
|
1901
|
+
runId: "78f659a3",
|
|
1902
|
+
agent: "worker",
|
|
1903
|
+
index: "0",
|
|
1904
|
+
}, async () => {
|
|
1905
|
+
const harness = createExtensionHarness();
|
|
1906
|
+
piIntercomExtension(harness.pi as never);
|
|
1907
|
+
await harness.emitLifecycle("session_start");
|
|
1908
|
+
const supervisorTool = harness.tools.find((tool) => tool.name === "contact_supervisor")!;
|
|
1909
|
+
const updateResult = await supervisorTool.execute("update-1", { reason: "progress_update", message: "Blocked." }, new AbortController().signal, undefined, harness.ctx);
|
|
1910
|
+
assert.equal(updateResult.details?.delivered, false);
|
|
1911
|
+
assert.match(updateResult.content[0]?.text ?? "", /Session not found/);
|
|
1912
|
+
assert.equal(updateResult.details?.reason, "Session not found");
|
|
1913
|
+
|
|
1914
|
+
const askResult = await supervisorTool.execute("ask-1", { reason: "need_decision", message: "Which path?" }, new AbortController().signal, undefined, harness.ctx);
|
|
1915
|
+
assert.equal(askResult.details?.error, true);
|
|
1916
|
+
assert.match(askResult.content[0]?.text ?? "", /Session not found/);
|
|
1917
|
+
|
|
1918
|
+
const secondAskResult = await supervisorTool.execute("ask-2", { reason: "need_decision", message: "Still blocked." }, new AbortController().signal, undefined, harness.ctx);
|
|
1919
|
+
assert.equal(secondAskResult.details?.error, true);
|
|
1920
|
+
assert.match(secondAskResult.content[0]?.text ?? "", /Session not found/);
|
|
1921
|
+
assert.doesNotMatch(secondAskResult.content[0]?.text ?? "", /Already waiting/);
|
|
1922
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1923
|
+
});
|
|
1924
|
+
} finally {
|
|
1925
|
+
await cleanup();
|
|
1926
|
+
}
|
|
1927
|
+
});
|
|
1928
|
+
|
|
1929
|
+
test("regular intercom asks fail safely when started concurrently", { concurrency: false }, async () => {
|
|
1930
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
1931
|
+
const { orchestrator, cleanup } = await setupClients();
|
|
1932
|
+
|
|
1933
|
+
try {
|
|
1934
|
+
const harness = createExtensionHarness("regular-ask-worker");
|
|
1935
|
+
piIntercomExtension(harness.pi as never);
|
|
1936
|
+
await harness.emitLifecycle("session_start");
|
|
1937
|
+
await waitForSessionByName(orchestrator, "regular-ask-worker");
|
|
1938
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
1939
|
+
|
|
1940
|
+
const firstMessage = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
1941
|
+
const firstAsk = intercomTool.execute("ask-1", { action: "ask", to: "orchestrator", message: "First?" }, new AbortController().signal, undefined, harness.ctx);
|
|
1942
|
+
const secondAsk = intercomTool.execute("ask-2", { action: "ask", to: "orchestrator", message: "Second?" }, new AbortController().signal, undefined, harness.ctx);
|
|
1943
|
+
const [from, askMessage] = await firstMessage;
|
|
1944
|
+
assert.equal(askMessage.expectsReply, true);
|
|
1945
|
+
|
|
1946
|
+
const earlyResults = await Promise.race([
|
|
1947
|
+
Promise.all([firstAsk, secondAsk]),
|
|
1948
|
+
new Promise<null>((resolve) => setTimeout(() => resolve(null), 100)),
|
|
1949
|
+
]);
|
|
1950
|
+
assert.equal(earlyResults, null);
|
|
1951
|
+
|
|
1952
|
+
const pendingResult = await Promise.race([firstAsk, secondAsk]);
|
|
1953
|
+
assert.equal(pendingResult.details?.error, true);
|
|
1954
|
+
assert.match(pendingResult.content[0]?.text ?? "", /Already waiting/);
|
|
1955
|
+
|
|
1956
|
+
const reply = await orchestrator.send(from.id, { text: "First answer.", replyTo: askMessage.id });
|
|
1957
|
+
assert.equal(reply.delivered, true);
|
|
1958
|
+
|
|
1959
|
+
const results = await Promise.all([firstAsk, secondAsk]);
|
|
1960
|
+
assert.equal(results.filter((result) => result.details?.error === true).length, 1);
|
|
1961
|
+
assert.equal(results.filter((result) => /First answer/.test(result.content[0]?.text ?? "")).length, 1);
|
|
1962
|
+
await harness.emitLifecycle("session_shutdown");
|
|
1963
|
+
} finally {
|
|
1964
|
+
await cleanup();
|
|
1965
|
+
}
|
|
1966
|
+
});
|
|
1967
|
+
|
|
1968
|
+
test("broker refuses reverse mutual asks until the original ask is answered", { concurrency: false }, async () => {
|
|
1969
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
1970
|
+
|
|
1971
|
+
try {
|
|
1972
|
+
const askToOrchestrator = await planner.send(orchestrator.sessionId!, {
|
|
1973
|
+
messageId: "planner-to-orchestrator",
|
|
1974
|
+
text: "Can you decide?",
|
|
1975
|
+
expectsReply: true,
|
|
1976
|
+
});
|
|
1977
|
+
assert.equal(askToOrchestrator.delivered, true);
|
|
1978
|
+
|
|
1979
|
+
const reverseAsk = await orchestrator.send(planner.sessionId!, {
|
|
1980
|
+
messageId: "orchestrator-to-planner",
|
|
1981
|
+
text: "Can you decide instead?",
|
|
1982
|
+
expectsReply: true,
|
|
1983
|
+
});
|
|
1984
|
+
assert.equal(reverseAsk.delivered, false);
|
|
1985
|
+
assert.match(reverseAsk.reason ?? "", /Mutual ask refused/);
|
|
1986
|
+
|
|
1987
|
+
const plainSend = await orchestrator.send(planner.sessionId!, { text: "Plain update still works." });
|
|
1988
|
+
assert.equal(plainSend.delivered, true);
|
|
1989
|
+
|
|
1990
|
+
const reply = await orchestrator.send(planner.sessionId!, {
|
|
1991
|
+
text: "Answered.",
|
|
1992
|
+
replyTo: "planner-to-orchestrator",
|
|
1993
|
+
});
|
|
1994
|
+
assert.equal(reply.delivered, true);
|
|
1995
|
+
|
|
1996
|
+
const nextAsk = await orchestrator.send(planner.sessionId!, {
|
|
1997
|
+
messageId: "orchestrator-to-planner-after-reply",
|
|
1998
|
+
text: "Now can I ask?",
|
|
1999
|
+
expectsReply: true,
|
|
2000
|
+
});
|
|
2001
|
+
assert.equal(nextAsk.delivered, true);
|
|
2002
|
+
} finally {
|
|
2003
|
+
await cleanup();
|
|
2004
|
+
}
|
|
2005
|
+
});
|
|
2006
|
+
|
|
2007
|
+
test("a reply can start a new reverse ask", { concurrency: false }, async () => {
|
|
2008
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2009
|
+
|
|
2010
|
+
try {
|
|
2011
|
+
const askToOrchestrator = await planner.send(orchestrator.sessionId!, {
|
|
2012
|
+
messageId: "planner-to-orchestrator-transition",
|
|
2013
|
+
text: "Can you decide?",
|
|
2014
|
+
expectsReply: true,
|
|
2015
|
+
});
|
|
2016
|
+
assert.equal(askToOrchestrator.delivered, true);
|
|
2017
|
+
|
|
2018
|
+
const replyAndAsk = await orchestrator.send(planner.sessionId!, {
|
|
2019
|
+
messageId: "orchestrator-reply-and-ask",
|
|
2020
|
+
text: "I answered; can you decide the next thing?",
|
|
2021
|
+
replyTo: "planner-to-orchestrator-transition",
|
|
2022
|
+
expectsReply: true,
|
|
2023
|
+
});
|
|
2024
|
+
assert.equal(replyAndAsk.delivered, true);
|
|
2025
|
+
|
|
2026
|
+
const duplicateReverseAsk = await orchestrator.send(planner.sessionId!, {
|
|
2027
|
+
messageId: "orchestrator-duplicate-reverse-ask",
|
|
2028
|
+
text: "Can I ask another before the first is answered?",
|
|
2029
|
+
expectsReply: true,
|
|
2030
|
+
});
|
|
2031
|
+
assert.equal(duplicateReverseAsk.delivered, true);
|
|
2032
|
+
|
|
2033
|
+
const plannerReverseAsk = await planner.send(orchestrator.sessionId!, {
|
|
2034
|
+
messageId: "planner-reverse-while-orchestrator-waits",
|
|
2035
|
+
text: "Can I ask while you wait?",
|
|
2036
|
+
expectsReply: true,
|
|
2037
|
+
});
|
|
2038
|
+
assert.equal(plannerReverseAsk.delivered, false);
|
|
2039
|
+
assert.match(plannerReverseAsk.reason ?? "", /Mutual ask refused/);
|
|
2040
|
+
} finally {
|
|
2041
|
+
await cleanup();
|
|
2042
|
+
}
|
|
2043
|
+
});
|
|
2044
|
+
|
|
2045
|
+
test("failed replies do not clear broker mutual-ask edges", { concurrency: false }, async () => {
|
|
2046
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2047
|
+
|
|
2048
|
+
try {
|
|
2049
|
+
const askToOrchestrator = await planner.send(orchestrator.sessionId!, {
|
|
2050
|
+
messageId: "planner-to-orchestrator-missing-reply",
|
|
2051
|
+
text: "Can you decide?",
|
|
2052
|
+
expectsReply: true,
|
|
2053
|
+
});
|
|
2054
|
+
assert.equal(askToOrchestrator.delivered, true);
|
|
2055
|
+
|
|
2056
|
+
const missingReply = await orchestrator.send("missing-session", {
|
|
2057
|
+
messageId: "reply-to-missing-session",
|
|
2058
|
+
text: "Answered, maybe?",
|
|
2059
|
+
replyTo: "planner-to-orchestrator-missing-reply",
|
|
2060
|
+
});
|
|
2061
|
+
assert.equal(missingReply.delivered, false);
|
|
2062
|
+
assert.match(missingReply.reason ?? "", /Session not found/);
|
|
2063
|
+
|
|
2064
|
+
const reverseAsk = await orchestrator.send(planner.sessionId!, {
|
|
2065
|
+
messageId: "reverse-after-missing-reply",
|
|
2066
|
+
text: "Can I ask now?",
|
|
2067
|
+
expectsReply: true,
|
|
2068
|
+
});
|
|
2069
|
+
assert.equal(reverseAsk.delivered, false);
|
|
2070
|
+
assert.match(reverseAsk.reason ?? "", /Mutual ask refused/);
|
|
2071
|
+
|
|
2072
|
+
const deliveredReply = await orchestrator.send(planner.sessionId!, {
|
|
2073
|
+
messageId: "reply-to-planner",
|
|
2074
|
+
text: "Actually answered.",
|
|
2075
|
+
replyTo: "planner-to-orchestrator-missing-reply",
|
|
2076
|
+
});
|
|
2077
|
+
assert.equal(deliveredReply.delivered, true);
|
|
2078
|
+
|
|
2079
|
+
const nextAsk = await orchestrator.send(planner.sessionId!, {
|
|
2080
|
+
messageId: "reverse-after-delivered-reply",
|
|
2081
|
+
text: "Now can I ask?",
|
|
2082
|
+
expectsReply: true,
|
|
2083
|
+
});
|
|
2084
|
+
assert.equal(nextAsk.delivered, true);
|
|
2085
|
+
} finally {
|
|
2086
|
+
await cleanup();
|
|
2087
|
+
}
|
|
2088
|
+
});
|
|
2089
|
+
|
|
2090
|
+
test("regular intercom ask timeout reports message id and delivery state", { concurrency: false }, async () => {
|
|
2091
|
+
const previousTimeout = process.env.PI_INTERCOM_ASK_TIMEOUT_MS;
|
|
2092
|
+
process.env.PI_INTERCOM_ASK_TIMEOUT_MS = "50";
|
|
2093
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
2094
|
+
const { planner, cleanup } = await setupClients();
|
|
2095
|
+
const senderHarness = createExtensionHarness("timeout-worker", { sessionId: "session-timeout-worker" });
|
|
2096
|
+
const receiverHarness = createExtensionHarness("timeout-target", { sessionId: "session-timeout-target", hasUI: true });
|
|
2097
|
+
|
|
2098
|
+
try {
|
|
2099
|
+
piIntercomExtension(senderHarness.pi as never);
|
|
2100
|
+
piIntercomExtension(receiverHarness.pi as never);
|
|
2101
|
+
await senderHarness.emitLifecycle("session_start");
|
|
2102
|
+
await receiverHarness.emitLifecycle("session_start");
|
|
2103
|
+
await waitForSessionByName(planner, "timeout-target");
|
|
2104
|
+
const intercomTool = senderHarness.tools.find((tool) => tool.name === "intercom")!;
|
|
2105
|
+
|
|
2106
|
+
const result = await intercomTool.execute("ask-timeout", { action: "ask", to: "timeout-target", message: "Will this time out?" }, new AbortController().signal, undefined, senderHarness.ctx);
|
|
2107
|
+
|
|
2108
|
+
assert.equal(result.details?.error, true);
|
|
2109
|
+
assert.equal(result.details?.deliveryState, "injected");
|
|
2110
|
+
assert.match(result.content[0]?.text ?? "", new RegExp(String(result.details?.messageId)));
|
|
2111
|
+
assert.match(result.content[0]?.text ?? "", /Last known delivery state: injected/);
|
|
2112
|
+
assert.match(result.content[0]?.text ?? "", /not cancellation/);
|
|
2113
|
+
assert.equal(receiverHarness.sentMessages.length, 1);
|
|
2114
|
+
} finally {
|
|
2115
|
+
if (previousTimeout === undefined) {
|
|
2116
|
+
delete process.env.PI_INTERCOM_ASK_TIMEOUT_MS;
|
|
2117
|
+
} else {
|
|
2118
|
+
process.env.PI_INTERCOM_ASK_TIMEOUT_MS = previousTimeout;
|
|
2119
|
+
}
|
|
2120
|
+
await senderHarness.emitLifecycle("session_shutdown");
|
|
2121
|
+
await receiverHarness.emitLifecycle("session_shutdown");
|
|
2122
|
+
await cleanup();
|
|
2123
|
+
}
|
|
2124
|
+
});
|
|
2125
|
+
|
|
2126
|
+
test("regular intercom ask cancellation clears broker mutual-ask edge", { concurrency: false }, async () => {
|
|
2127
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
2128
|
+
const { orchestrator, cleanup } = await setupClients();
|
|
2129
|
+
|
|
2130
|
+
try {
|
|
2131
|
+
const harness = createExtensionHarness("cancel-cleanup-worker");
|
|
2132
|
+
piIntercomExtension(harness.pi as never);
|
|
2133
|
+
await harness.emitLifecycle("session_start");
|
|
2134
|
+
const worker = await waitForSessionByName(orchestrator, "cancel-cleanup-worker");
|
|
2135
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
2136
|
+
|
|
2137
|
+
const controller = new AbortController();
|
|
2138
|
+
const cancelledMessage = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2139
|
+
const cancelledResultPromise = intercomTool.execute("ask-cancelled", { action: "ask", to: "orchestrator", message: "Should I continue?" }, controller.signal, undefined, harness.ctx);
|
|
2140
|
+
await cancelledMessage;
|
|
2141
|
+
controller.abort();
|
|
2142
|
+
const cancelledResult = await cancelledResultPromise;
|
|
2143
|
+
assert.equal(cancelledResult.details?.error, true);
|
|
2144
|
+
assert.match(cancelledResult.content[0]?.text ?? "", /Cancelled/);
|
|
2145
|
+
|
|
2146
|
+
const reverseAsk = await orchestrator.send(worker.id, {
|
|
2147
|
+
messageId: "reverse-after-cancel",
|
|
2148
|
+
text: "Can I ask after your cancellation?",
|
|
2149
|
+
expectsReply: true,
|
|
2150
|
+
});
|
|
2151
|
+
assert.equal(reverseAsk.delivered, true);
|
|
2152
|
+
await harness.emitLifecycle("session_shutdown");
|
|
2153
|
+
} finally {
|
|
2154
|
+
await cleanup();
|
|
2155
|
+
}
|
|
2156
|
+
});
|
|
2157
|
+
|
|
2158
|
+
test("child supervisor tool clears reply waiter when cancelled", { concurrency: false }, async () => {
|
|
2159
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
2160
|
+
const { orchestrator, cleanup } = await setupClients();
|
|
2161
|
+
|
|
2162
|
+
try {
|
|
2163
|
+
await withChildOrchestratorEnv({
|
|
2164
|
+
orchestratorTarget: "orchestrator",
|
|
2165
|
+
runId: "78f659a3",
|
|
2166
|
+
agent: "worker",
|
|
2167
|
+
index: "0",
|
|
2168
|
+
sessionName: "subagent-worker-78f659a3-1",
|
|
2169
|
+
}, async () => {
|
|
2170
|
+
const harness = createExtensionHarness("subagent-worker-78f659a3-1");
|
|
2171
|
+
piIntercomExtension(harness.pi as never);
|
|
2172
|
+
await harness.emitLifecycle("session_start");
|
|
2173
|
+
const supervisorTool = harness.tools.find((tool) => tool.name === "contact_supervisor")!;
|
|
2174
|
+
|
|
2175
|
+
const controller = new AbortController();
|
|
2176
|
+
const cancelledMessage = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2177
|
+
const cancelledResultPromise = supervisorTool.execute("ask-cancelled", { reason: "need_decision", message: "Should I continue?" }, controller.signal, undefined, harness.ctx);
|
|
2178
|
+
await cancelledMessage;
|
|
2179
|
+
controller.abort();
|
|
2180
|
+
const cancelledResult = await cancelledResultPromise;
|
|
2181
|
+
assert.equal(cancelledResult.details?.error, true);
|
|
2182
|
+
assert.match(cancelledResult.content[0]?.text ?? "", /Cancelled/);
|
|
2183
|
+
|
|
2184
|
+
const nextMessage = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2185
|
+
const nextResultPromise = supervisorTool.execute("ask-next", { reason: "need_decision", message: "Can I ask again?" }, new AbortController().signal, undefined, harness.ctx);
|
|
2186
|
+
const [from, message] = await nextMessage;
|
|
2187
|
+
assert.match(message.content.text, /Can I ask again/);
|
|
2188
|
+
const reply = await orchestrator.send(from.id, { text: "Yes.", replyTo: message.id });
|
|
2189
|
+
assert.equal(reply.delivered, true);
|
|
2190
|
+
const nextResult = await nextResultPromise;
|
|
2191
|
+
assert.notEqual(nextResult.details?.error, true);
|
|
2192
|
+
assert.match(nextResult.content[0]?.text ?? "", /Yes\./);
|
|
2193
|
+
await harness.emitLifecycle("session_shutdown");
|
|
2194
|
+
});
|
|
2195
|
+
} finally {
|
|
2196
|
+
await cleanup();
|
|
2197
|
+
}
|
|
2198
|
+
});
|
|
2199
|
+
|
|
2200
|
+
test("full ask/reply round-trip works with reply target resolved from current turn context", { concurrency: false }, async () => {
|
|
2201
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2202
|
+
const replyTracker = new ReplyTracker();
|
|
2203
|
+
|
|
2204
|
+
try {
|
|
2205
|
+
const askId = "ask-current-turn";
|
|
2206
|
+
const askPromise = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2207
|
+
const replyPromise = waitForReply(planner, askId);
|
|
2208
|
+
|
|
2209
|
+
const delivered = await planner.send(orchestrator.sessionId!, {
|
|
2210
|
+
messageId: askId,
|
|
2211
|
+
text: "What should I do next?",
|
|
2212
|
+
expectsReply: true,
|
|
2213
|
+
});
|
|
2214
|
+
assert.equal(delivered.delivered, true);
|
|
2215
|
+
|
|
2216
|
+
const [from, message] = await askPromise;
|
|
2217
|
+
const context = replyTracker.recordIncomingMessage(from, message, Date.now());
|
|
2218
|
+
replyTracker.queueTurnContext(context);
|
|
2219
|
+
replyTracker.beginTurn(Date.now());
|
|
2220
|
+
|
|
2221
|
+
const target = replyTracker.resolveReplyTarget({}, Date.now());
|
|
2222
|
+
const sent = await orchestrator.send(target.from.id, {
|
|
2223
|
+
text: "Ship it.",
|
|
2224
|
+
replyTo: target.message.id,
|
|
2225
|
+
});
|
|
2226
|
+
assert.equal(sent.delivered, true);
|
|
2227
|
+
replyTracker.markReplied(target.message.id);
|
|
2228
|
+
|
|
2229
|
+
const reply = await replyPromise;
|
|
2230
|
+
assert.equal(reply.message.content.text, "Ship it.");
|
|
2231
|
+
assert.equal(reply.message.replyTo, askId);
|
|
2232
|
+
assert.deepEqual(replyTracker.listPending(Date.now()), []);
|
|
2233
|
+
} finally {
|
|
2234
|
+
await cleanup();
|
|
2235
|
+
}
|
|
2236
|
+
});
|
|
2237
|
+
|
|
2238
|
+
test("intercom reply targets exact replyTo when multiple asks are pending", { concurrency: false }, async () => {
|
|
2239
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2240
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
2241
|
+
const harness = createExtensionHarness("reply-target-worker");
|
|
2242
|
+
|
|
2243
|
+
try {
|
|
2244
|
+
piIntercomExtension(harness.pi as never);
|
|
2245
|
+
await harness.emitLifecycle("session_start");
|
|
2246
|
+
const worker = await waitForSessionByName(planner, "reply-target-worker");
|
|
2247
|
+
|
|
2248
|
+
assert.equal((await planner.send(worker.id, { messageId: "reply-target-1", text: "First?", expectsReply: true })).delivered, true);
|
|
2249
|
+
assert.equal((await orchestrator.send(worker.id, { messageId: "reply-target-2", text: "Second?", expectsReply: true })).delivered, true);
|
|
2250
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
2251
|
+
|
|
2252
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
2253
|
+
const replyReceived = waitForReply(orchestrator, "reply-target-2");
|
|
2254
|
+
const result = await intercomTool.execute("reply-exact", {
|
|
2255
|
+
action: "reply",
|
|
2256
|
+
message: "Second answer.",
|
|
2257
|
+
replyTo: "reply-target-2",
|
|
2258
|
+
}, new AbortController().signal, undefined, harness.ctx);
|
|
2259
|
+
assert.notEqual(result.details?.error, true);
|
|
2260
|
+
const reply = await replyReceived;
|
|
2261
|
+
assert.equal(reply.message.content.text, "Second answer.");
|
|
2262
|
+
|
|
2263
|
+
const pending = await intercomTool.execute("pending-after-exact", { action: "pending" }, new AbortController().signal, undefined, harness.ctx);
|
|
2264
|
+
assert.match(pending.content[0]?.text ?? "", /reply-target-1/);
|
|
2265
|
+
assert.doesNotMatch(pending.content[0]?.text ?? "", /reply-target-2/);
|
|
2266
|
+
} finally {
|
|
2267
|
+
await harness.emitLifecycle("session_shutdown");
|
|
2268
|
+
await cleanup();
|
|
2269
|
+
}
|
|
2270
|
+
});
|
|
2271
|
+
|
|
2272
|
+
test("broker queues replies to recently disconnected named senders", { concurrency: false }, async () => {
|
|
2273
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2274
|
+
const replacement = new IntercomClient();
|
|
2275
|
+
|
|
2276
|
+
try {
|
|
2277
|
+
const originalPlannerId = planner.sessionId!;
|
|
2278
|
+
const receivedAsk = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2279
|
+
assert.equal((await planner.send(orchestrator.sessionId!, { messageId: "ephemeral-cli-ask", text: "Can you answer later?", expectsReply: true })).delivered, true);
|
|
2280
|
+
await receivedAsk;
|
|
2281
|
+
await planner.disconnect();
|
|
2282
|
+
|
|
2283
|
+
const queuedReply = once(replacement, "message") as Promise<[SessionInfo, Message]>;
|
|
2284
|
+
const reply = await orchestrator.send(originalPlannerId, {
|
|
2285
|
+
messageId: "queued-reply-to-ephemeral",
|
|
2286
|
+
text: "Queued answer.",
|
|
2287
|
+
replyTo: "ephemeral-cli-ask",
|
|
2288
|
+
});
|
|
2289
|
+
assert.equal(reply.delivered, true);
|
|
2290
|
+
|
|
2291
|
+
await replacement.connect({
|
|
2292
|
+
name: "planner",
|
|
2293
|
+
cwd: repoDir,
|
|
2294
|
+
model: "test-model",
|
|
2295
|
+
pid: process.pid,
|
|
2296
|
+
startedAt: Date.now(),
|
|
2297
|
+
lastActivity: Date.now(),
|
|
2298
|
+
});
|
|
2299
|
+
const [from, message] = await queuedReply;
|
|
2300
|
+
assert.equal(from.id, orchestrator.sessionId);
|
|
2301
|
+
assert.equal(message.id, "queued-reply-to-ephemeral");
|
|
2302
|
+
assert.equal(message.replyTo, "ephemeral-cli-ask");
|
|
2303
|
+
assert.equal(message.content.text, "Queued answer.");
|
|
2304
|
+
assert.equal(typeof message.brokerReceivedAt, "number");
|
|
2305
|
+
assert.equal(typeof message.brokerDeliveredAt, "number");
|
|
2306
|
+
} finally {
|
|
2307
|
+
await replacement.disconnect().catch(() => undefined);
|
|
2308
|
+
await cleanup();
|
|
2309
|
+
}
|
|
2310
|
+
});
|
|
2311
|
+
|
|
2312
|
+
test("broker delivers old-id replies to an already reconnected same-name sender", { concurrency: false }, async () => {
|
|
2313
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2314
|
+
const replacement = new IntercomClient();
|
|
2315
|
+
|
|
2316
|
+
try {
|
|
2317
|
+
const originalPlannerId = planner.sessionId!;
|
|
2318
|
+
const receivedAsk = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2319
|
+
assert.equal((await planner.send(orchestrator.sessionId!, { messageId: "reconnected-cli-ask", text: "Can you answer after reconnect?", expectsReply: true })).delivered, true);
|
|
2320
|
+
await receivedAsk;
|
|
2321
|
+
await planner.disconnect();
|
|
2322
|
+
|
|
2323
|
+
await replacement.connect({
|
|
2324
|
+
name: "planner",
|
|
2325
|
+
cwd: repoDir,
|
|
2326
|
+
model: "test-model",
|
|
2327
|
+
pid: process.pid,
|
|
2328
|
+
startedAt: Date.now(),
|
|
2329
|
+
lastActivity: Date.now(),
|
|
2330
|
+
});
|
|
2331
|
+
const deliveredReply = once(replacement, "message") as Promise<[SessionInfo, Message]>;
|
|
2332
|
+
const reply = await orchestrator.send(originalPlannerId, {
|
|
2333
|
+
messageId: "reply-after-cli-reconnect",
|
|
2334
|
+
text: "Immediate answer after reconnect.",
|
|
2335
|
+
replyTo: "reconnected-cli-ask",
|
|
2336
|
+
});
|
|
2337
|
+
assert.equal(reply.delivered, true);
|
|
2338
|
+
const [, message] = await deliveredReply;
|
|
2339
|
+
assert.equal(message.id, "reply-after-cli-reconnect");
|
|
2340
|
+
assert.equal(message.replyTo, "reconnected-cli-ask");
|
|
2341
|
+
assert.equal(message.content.text, "Immediate answer after reconnect.");
|
|
2342
|
+
} finally {
|
|
2343
|
+
await replacement.disconnect().catch(() => undefined);
|
|
2344
|
+
await cleanup();
|
|
2345
|
+
}
|
|
2346
|
+
});
|
|
2347
|
+
|
|
2348
|
+
test("broker keeps queued mail away from a same-name session in another cwd", { concurrency: false }, async () => {
|
|
2349
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2350
|
+
const otherProject = new IntercomClient();
|
|
2351
|
+
|
|
2352
|
+
try {
|
|
2353
|
+
const originalPlannerId = planner.sessionId!;
|
|
2354
|
+
const receivedAsk = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2355
|
+
assert.equal((await planner.send(orchestrator.sessionId!, { messageId: "cross-cwd-ask", text: "Answer later?", expectsReply: true })).delivered, true);
|
|
2356
|
+
await receivedAsk;
|
|
2357
|
+
await planner.disconnect();
|
|
2358
|
+
|
|
2359
|
+
assert.equal((await orchestrator.send(originalPlannerId, {
|
|
2360
|
+
messageId: "cross-cwd-answer",
|
|
2361
|
+
text: "Answer for the original project.",
|
|
2362
|
+
replyTo: "cross-cwd-ask",
|
|
2363
|
+
})).delivered, true);
|
|
2364
|
+
|
|
2365
|
+
const received: Message[] = [];
|
|
2366
|
+
otherProject.on("message", (_from: SessionInfo, message: Message) => received.push(message));
|
|
2367
|
+
await otherProject.connect({
|
|
2368
|
+
name: "planner",
|
|
2369
|
+
cwd: path.join(repoDir, "other-project"),
|
|
2370
|
+
model: "test-model",
|
|
2371
|
+
pid: process.pid,
|
|
2372
|
+
startedAt: Date.now(),
|
|
2373
|
+
lastActivity: Date.now(),
|
|
2374
|
+
});
|
|
2375
|
+
await new Promise((resolve) => setTimeout(resolve, 200));
|
|
2376
|
+
|
|
2377
|
+
assert.deepEqual(received, []);
|
|
2378
|
+
} finally {
|
|
2379
|
+
await otherProject.disconnect().catch(() => undefined);
|
|
2380
|
+
await cleanup();
|
|
2381
|
+
}
|
|
2382
|
+
});
|
|
2383
|
+
|
|
2384
|
+
test("broker delivers queued mail to a relaunch reporting the same cwd differently", { concurrency: false }, async () => {
|
|
2385
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2386
|
+
const replacement = new IntercomClient();
|
|
2387
|
+
|
|
2388
|
+
try {
|
|
2389
|
+
const originalPlannerId = planner.sessionId!;
|
|
2390
|
+
const receivedAsk = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2391
|
+
assert.equal((await planner.send(orchestrator.sessionId!, { messageId: "cwd-variant-ask", text: "Answer later?", expectsReply: true })).delivered, true);
|
|
2392
|
+
await receivedAsk;
|
|
2393
|
+
await planner.disconnect();
|
|
2394
|
+
|
|
2395
|
+
assert.equal((await orchestrator.send(originalPlannerId, {
|
|
2396
|
+
messageId: "cwd-variant-answer",
|
|
2397
|
+
text: "Answer for the same project.",
|
|
2398
|
+
replyTo: "cwd-variant-ask",
|
|
2399
|
+
})).delivered, true);
|
|
2400
|
+
|
|
2401
|
+
const queuedReply = once(replacement, "message") as Promise<[SessionInfo, Message]>;
|
|
2402
|
+
await replacement.connect({
|
|
2403
|
+
name: "planner",
|
|
2404
|
+
// Same directory as setupClients(), spelled with a ".." segment and a
|
|
2405
|
+
// trailing separator. Built by concatenation because path.join would
|
|
2406
|
+
// collapse the ".." before the broker ever sees it.
|
|
2407
|
+
cwd: `${repoDir}${path.sep}ui${path.sep}..${path.sep}`,
|
|
2408
|
+
model: "test-model",
|
|
2409
|
+
pid: process.pid,
|
|
2410
|
+
startedAt: Date.now(),
|
|
2411
|
+
lastActivity: Date.now(),
|
|
2412
|
+
});
|
|
2413
|
+
|
|
2414
|
+
const [, message] = await queuedReply;
|
|
2415
|
+
assert.equal(message.id, "cwd-variant-answer");
|
|
2416
|
+
assert.equal(message.content.text, "Answer for the same project.");
|
|
2417
|
+
} finally {
|
|
2418
|
+
await replacement.disconnect().catch(() => undefined);
|
|
2419
|
+
await cleanup();
|
|
2420
|
+
}
|
|
2421
|
+
});
|
|
2422
|
+
|
|
2423
|
+
test("broker does not reroute an id-addressed message to a same-name session in another cwd", { concurrency: false }, async () => {
|
|
2424
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2425
|
+
const otherProject = new IntercomClient();
|
|
2426
|
+
|
|
2427
|
+
try {
|
|
2428
|
+
const originalPlannerId = planner.sessionId!;
|
|
2429
|
+
const receivedAsk = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2430
|
+
assert.equal((await planner.send(orchestrator.sessionId!, { messageId: "cross-cwd-live-ask", text: "Answer later?", expectsReply: true })).delivered, true);
|
|
2431
|
+
await receivedAsk;
|
|
2432
|
+
await planner.disconnect();
|
|
2433
|
+
|
|
2434
|
+
const received: Message[] = [];
|
|
2435
|
+
otherProject.on("message", (_from: SessionInfo, message: Message) => received.push(message));
|
|
2436
|
+
await otherProject.connect({
|
|
2437
|
+
name: "planner",
|
|
2438
|
+
cwd: path.join(repoDir, "other-project"),
|
|
2439
|
+
model: "test-model",
|
|
2440
|
+
pid: process.pid,
|
|
2441
|
+
startedAt: Date.now(),
|
|
2442
|
+
lastActivity: Date.now(),
|
|
2443
|
+
});
|
|
2444
|
+
|
|
2445
|
+
assert.equal((await orchestrator.send(originalPlannerId, {
|
|
2446
|
+
messageId: "cross-cwd-live-answer",
|
|
2447
|
+
text: "Answer for the original project.",
|
|
2448
|
+
replyTo: "cross-cwd-live-ask",
|
|
2449
|
+
})).delivered, true);
|
|
2450
|
+
await new Promise((resolve) => setTimeout(resolve, 200));
|
|
2451
|
+
|
|
2452
|
+
assert.deepEqual(received, []);
|
|
2453
|
+
} finally {
|
|
2454
|
+
await otherProject.disconnect().catch(() => undefined);
|
|
2455
|
+
await cleanup();
|
|
2456
|
+
}
|
|
2457
|
+
});
|
|
2458
|
+
|
|
2459
|
+
test("intercom reply queues mail for a disconnected named sender", { concurrency: false }, async () => {
|
|
2460
|
+
const { planner, cleanup } = await setupClients();
|
|
2461
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
2462
|
+
const harness = createExtensionHarness("stale-reply-worker");
|
|
2463
|
+
const replacement = new IntercomClient();
|
|
2464
|
+
|
|
2465
|
+
try {
|
|
2466
|
+
piIntercomExtension(harness.pi as never);
|
|
2467
|
+
await harness.emitLifecycle("session_start");
|
|
2468
|
+
const worker = await waitForSessionByName(planner, "stale-reply-worker");
|
|
2469
|
+
assert.equal((await planner.send(worker.id, { messageId: "stale-reply-ask", text: "Still there?", expectsReply: true })).delivered, true);
|
|
2470
|
+
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
2471
|
+
await planner.disconnect();
|
|
2472
|
+
|
|
2473
|
+
const intercomTool = harness.tools.find((tool) => tool.name === "intercom")!;
|
|
2474
|
+
const result = await intercomTool.execute("reply-stale", {
|
|
2475
|
+
action: "reply",
|
|
2476
|
+
message: "No sender remains.",
|
|
2477
|
+
replyTo: "stale-reply-ask",
|
|
2478
|
+
}, new AbortController().signal, undefined, harness.ctx);
|
|
2479
|
+
assert.equal(result.details?.delivered, true);
|
|
2480
|
+
|
|
2481
|
+
const pending = await intercomTool.execute("pending-after-stale", { action: "pending" }, new AbortController().signal, undefined, harness.ctx);
|
|
2482
|
+
assert.match(pending.content[0]?.text ?? "", /No unresolved inbound asks/);
|
|
2483
|
+
|
|
2484
|
+
const queuedReply = once(replacement, "message") as Promise<[SessionInfo, Message]>;
|
|
2485
|
+
await replacement.connect({
|
|
2486
|
+
name: "planner",
|
|
2487
|
+
cwd: repoDir,
|
|
2488
|
+
model: "test-model",
|
|
2489
|
+
pid: process.pid,
|
|
2490
|
+
startedAt: Date.now(),
|
|
2491
|
+
lastActivity: Date.now(),
|
|
2492
|
+
});
|
|
2493
|
+
const [, message] = await queuedReply;
|
|
2494
|
+
assert.equal(message.replyTo, "stale-reply-ask");
|
|
2495
|
+
assert.equal(message.content.text, "No sender remains.");
|
|
2496
|
+
} finally {
|
|
2497
|
+
await replacement.disconnect().catch(() => undefined);
|
|
2498
|
+
await harness.emitLifecycle("session_shutdown");
|
|
2499
|
+
await cleanup();
|
|
2500
|
+
}
|
|
2501
|
+
});
|
|
2502
|
+
|
|
2503
|
+
test("subagent control intercom events wake the current orchestrator session", async () => {
|
|
2504
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
2505
|
+
const events = new EventEmitter();
|
|
2506
|
+
const sentMessages: Array<{ message: { customType?: string; content?: string }; options?: { triggerTurn?: boolean } }> = [];
|
|
2507
|
+
const pi = {
|
|
2508
|
+
getSessionName: () => "orchestrator",
|
|
2509
|
+
events: {
|
|
2510
|
+
on: (channel: string, handler: (payload: unknown) => void) => {
|
|
2511
|
+
events.on(channel, handler);
|
|
2512
|
+
return () => events.off(channel, handler);
|
|
2513
|
+
},
|
|
2514
|
+
emit: (channel: string, payload: unknown) => events.emit(channel, payload),
|
|
2515
|
+
},
|
|
2516
|
+
on: () => undefined,
|
|
2517
|
+
registerMessageRenderer: () => undefined,
|
|
2518
|
+
registerTool: () => undefined,
|
|
2519
|
+
registerCommand: () => undefined,
|
|
2520
|
+
registerShortcut: () => undefined,
|
|
2521
|
+
sendMessage: (message: { customType?: string; content?: string }, options?: { triggerTurn?: boolean }) => {
|
|
2522
|
+
sentMessages.push({ message, options });
|
|
2523
|
+
},
|
|
2524
|
+
appendEntry: () => undefined,
|
|
2525
|
+
};
|
|
2526
|
+
|
|
2527
|
+
piIntercomExtension(pi as never);
|
|
2528
|
+
pi.events.emit("subagent:control-intercom", {
|
|
2529
|
+
to: "orchestrator",
|
|
2530
|
+
message: "subagent needs attention\n\nworker needs attention in run 78f659a3.",
|
|
2531
|
+
});
|
|
2532
|
+
await new Promise((resolve) => setImmediate(resolve));
|
|
2533
|
+
|
|
2534
|
+
assert.equal(sentMessages.length, 1);
|
|
2535
|
+
assert.equal(sentMessages[0]?.message.customType, "intercom_message");
|
|
2536
|
+
assert.match(sentMessages[0]?.message.content ?? "", /From subagent-control/);
|
|
2537
|
+
assert.match(sentMessages[0]?.message.content ?? "", /worker needs attention in run 78f659a3/);
|
|
2538
|
+
assert.equal(sentMessages[0]?.options?.triggerTurn, true);
|
|
2539
|
+
});
|
|
2540
|
+
|
|
2541
|
+
test("subagent result intercom events wake the current orchestrator session", async () => {
|
|
2542
|
+
const { default: piIntercomExtension } = await import("./index.ts");
|
|
2543
|
+
const events = new EventEmitter();
|
|
2544
|
+
const sentMessages: Array<{ message: { customType?: string; content?: string }; options?: { triggerTurn?: boolean } }> = [];
|
|
2545
|
+
const deliveryAcks: unknown[] = [];
|
|
2546
|
+
events.on("subagent:result-intercom-delivery", (payload) => deliveryAcks.push(payload));
|
|
2547
|
+
const pi = {
|
|
2548
|
+
getSessionName: () => "orchestrator",
|
|
2549
|
+
events: {
|
|
2550
|
+
on: (channel: string, handler: (payload: unknown) => void) => {
|
|
2551
|
+
events.on(channel, handler);
|
|
2552
|
+
return () => events.off(channel, handler);
|
|
2553
|
+
},
|
|
2554
|
+
emit: (channel: string, payload: unknown) => events.emit(channel, payload),
|
|
2555
|
+
},
|
|
2556
|
+
on: () => undefined,
|
|
2557
|
+
registerMessageRenderer: () => undefined,
|
|
2558
|
+
registerTool: () => undefined,
|
|
2559
|
+
registerCommand: () => undefined,
|
|
2560
|
+
registerShortcut: () => undefined,
|
|
2561
|
+
sendMessage: (message: { customType?: string; content?: string }, options?: { triggerTurn?: boolean }) => {
|
|
2562
|
+
sentMessages.push({ message, options });
|
|
2563
|
+
},
|
|
2564
|
+
appendEntry: () => undefined,
|
|
2565
|
+
};
|
|
2566
|
+
|
|
2567
|
+
piIntercomExtension(pi as never);
|
|
2568
|
+
pi.events.emit("subagent:result-intercom", {
|
|
2569
|
+
to: "orchestrator",
|
|
2570
|
+
requestId: "result-1",
|
|
2571
|
+
message: "subagent result\n\nRun: 78f659a3\nAgent: worker\nStatus: completed",
|
|
2572
|
+
});
|
|
2573
|
+
await new Promise((resolve) => setImmediate(resolve));
|
|
2574
|
+
|
|
2575
|
+
assert.equal(sentMessages.length, 1);
|
|
2576
|
+
assert.equal(sentMessages[0]?.message.customType, "intercom_message");
|
|
2577
|
+
assert.match(sentMessages[0]?.message.content ?? "", /From subagent-result/);
|
|
2578
|
+
assert.match(sentMessages[0]?.message.content ?? "", /Status: completed/);
|
|
2579
|
+
assert.equal(sentMessages[0]?.options?.triggerTurn, true);
|
|
2580
|
+
assert.deepEqual(deliveryAcks, [{ requestId: "result-1", delivered: true }]);
|
|
2581
|
+
});
|
|
2582
|
+
|
|
2583
|
+
test("async ask can be replied to later from the single pending ask fallback", { concurrency: false }, async () => {
|
|
2584
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2585
|
+
const replyTracker = new ReplyTracker();
|
|
2586
|
+
|
|
2587
|
+
try {
|
|
2588
|
+
const askId = "ask-later";
|
|
2589
|
+
const askPromise = once(orchestrator, "message") as Promise<[SessionInfo, Message]>;
|
|
2590
|
+
const replyPromise = waitForReply(planner, askId);
|
|
2591
|
+
|
|
2592
|
+
const delivered = await planner.send(orchestrator.sessionId!, {
|
|
2593
|
+
messageId: askId,
|
|
2594
|
+
text: "Need an answer later.",
|
|
2595
|
+
expectsReply: true,
|
|
2596
|
+
});
|
|
2597
|
+
assert.equal(delivered.delivered, true);
|
|
2598
|
+
|
|
2599
|
+
const [from, message] = await askPromise;
|
|
2600
|
+
replyTracker.recordIncomingMessage(from, message, Date.now());
|
|
2601
|
+
|
|
2602
|
+
const target = replyTracker.resolveReplyTarget({}, Date.now());
|
|
2603
|
+
const sent = await orchestrator.send(target.from.id, {
|
|
2604
|
+
text: "Answering later worked.",
|
|
2605
|
+
replyTo: target.message.id,
|
|
2606
|
+
});
|
|
2607
|
+
assert.equal(sent.delivered, true);
|
|
2608
|
+
replyTracker.markReplied(target.message.id);
|
|
2609
|
+
|
|
2610
|
+
const reply = await replyPromise;
|
|
2611
|
+
assert.equal(reply.message.content.text, "Answering later worked.");
|
|
2612
|
+
assert.equal(reply.message.replyTo, askId);
|
|
2613
|
+
} finally {
|
|
2614
|
+
await cleanup();
|
|
2615
|
+
}
|
|
2616
|
+
});
|
|
2617
|
+
|
|
2618
|
+
test("presence carries context usage to peers, and an explicit null clears a stale value", { concurrency: false }, async () => {
|
|
2619
|
+
// Peers should see each other's live context-window usage without a separate
|
|
2620
|
+
// query, and a post-compaction null must CLEAR the value rather than leave a
|
|
2621
|
+
// stale-high percentage frozen in the list.
|
|
2622
|
+
const { planner, orchestrator, cleanup } = await setupClients();
|
|
2623
|
+
try {
|
|
2624
|
+
planner.updatePresence({ contextPct: 50, contextTokens: 100000, contextWindow: 200000 });
|
|
2625
|
+
// Flush barrier: a round-trip on planner's OWN socket guarantees the broker
|
|
2626
|
+
// processed the presence (FIFO per socket) before the peer probes.
|
|
2627
|
+
await planner.send(orchestrator.sessionId!, { text: "flush" });
|
|
2628
|
+
let sessions = await orchestrator.listSessions();
|
|
2629
|
+
let p = sessions.find(s => s.id === planner.sessionId);
|
|
2630
|
+
assert.equal(p?.contextPct, 50);
|
|
2631
|
+
assert.equal(p?.contextTokens, 100000);
|
|
2632
|
+
assert.equal(p?.contextWindow, 200000);
|
|
2633
|
+
|
|
2634
|
+
// Post-compaction: null contextPct/tokens must CLEAR (not freeze the old %).
|
|
2635
|
+
planner.updatePresence({ contextPct: null, contextTokens: null });
|
|
2636
|
+
await planner.send(orchestrator.sessionId!, { text: "flush" });
|
|
2637
|
+
sessions = await orchestrator.listSessions();
|
|
2638
|
+
p = sessions.find(s => s.id === planner.sessionId);
|
|
2639
|
+
assert.equal(p?.contextPct, undefined, "null contextPct must CLEAR the field, not freeze the old value");
|
|
2640
|
+
assert.equal(p?.contextTokens, undefined);
|
|
2641
|
+
// contextWindow (the denominator, not nulled here) is retained.
|
|
2642
|
+
assert.equal(p?.contextWindow, 200000);
|
|
2643
|
+
} finally {
|
|
2644
|
+
await cleanup();
|
|
2645
|
+
}
|
|
2646
|
+
});
|