@selesai/code 0.5.25 → 0.5.27

package/dist/extensions/pi-powerline-footer/fixed-editor/terminal-split.ts

@@ -21,6 +21,7 @@ interface TerminalSplitCompositorOptions {
   getShowHardwareCursor?: () => boolean;
   mouseScroll?: boolean;
   keyboardScrollShortcuts?: KeyboardScrollShortcuts;
+  shouldCaptureKeyboardScroll?: () => boolean;
   onCopySelection?: (text: string) => void;
 }
 
@@ -318,6 +319,7 @@ export class TerminalSplitCompositor {
   private readonly getShowHardwareCursor: () => boolean;
   private readonly mouseScroll: boolean;
   private readonly keyboardScrollShortcuts: KeyboardScrollShortcuts;
+  private readonly shouldCaptureKeyboardScroll: () => boolean;
   private readonly onCopySelection: ((text: string) => void) | null;
   private extendedKeyboardMode: ExtendedKeyboardMode | null = null;
   private readonly rowsDescriptor: PropertyDescriptor | undefined;
@@ -360,6 +362,7 @@ export class TerminalSplitCompositor {
     this.getShowHardwareCursor = options.getShowHardwareCursor ?? (() => false);
     this.mouseScroll = options.mouseScroll !== false;
     this.keyboardScrollShortcuts = options.keyboardScrollShortcuts ?? DEFAULT_KEYBOARD_SCROLL_SHORTCUTS;
+    this.shouldCaptureKeyboardScroll = options.shouldCaptureKeyboardScroll ?? (() => true);
     this.onCopySelection = options.onCopySelection ?? null;
     this.rowsDescriptor = descriptorForRows(options.terminal);
     this.originalWrite = options.terminal.write.bind(options.terminal);
@@ -602,7 +605,7 @@ export class TerminalSplitCompositor {
   }
 
   private handleInput(data: string): { consume?: boolean; data?: string } | undefined {
-    if (this.disposed || this.hasVisibleOverlay()) return undefined;
+    if (this.disposed || this.hasVisibleOverlay() || !this.shouldCaptureKeyboardScroll()) return undefined;
 
     const mousePackets = this.mouseScroll ? parseSgrMousePackets(data) : null;
     if (mousePackets) {

package/dist/extensions/pi-powerline-footer/index.ts

@@ -2386,6 +2386,7 @@ export default function powerlineFooter(pi: ExtensionAPI) {
         up: resolvedShortcuts.scrollChatUp,
         down: resolvedShortcuts.scrollChatDown,
       },
+      shouldCaptureKeyboardScroll: () => Reflect.get(tui, "focusedComponent") === currentEditor,
       onCopySelection: (text) => copyTextToClipboard(ctx, text),
       getShowHardwareCursor: () => typeof tui.getShowHardwareCursor === "function" && tui.getShowHardwareCursor(),
       renderCluster: (width, terminalRows) => {

package/dist/extensions/pi-powerline-footer/tests/fixed-editor.test.ts

@@ -1144,6 +1144,42 @@ test("terminal split keyboard scroll supports Pi page aliases and preserves app
   compositor.dispose();
 });
 
+test("terminal split leaves PgUp/PgDn to a focused custom view", () => {
+  const terminal = new FakeTerminal();
+  let ownsKeyboardScroll = true;
+  let inputListener: ((data: string) => { consume?: boolean; data?: string } | undefined) | null = null;
+  const tui = {
+    terminal,
+    addInputListener(listener: (data: string) => { consume?: boolean; data?: string } | undefined) {
+      inputListener = listener;
+      return () => {
+        inputListener = null;
+      };
+    },
+    requestRender() {},
+    render() {
+      return Array.from({ length: 30 }, (_, index) => `line-${index}`);
+    },
+  };
+
+  const compositor = new TerminalSplitCompositor({
+    tui,
+    terminal,
+    shouldCaptureKeyboardScroll: () => ownsKeyboardScroll,
+    renderCluster: () => ({ lines: ["cluster-a", "cluster-b"], cursor: null }),
+  });
+
+  compositor.install();
+  tui.render();
+
+  assert.deepEqual(inputListener?.("\x1b[5~"), { consume: true });
+  ownsKeyboardScroll = false;
+  assert.equal(inputListener?.("\x1b[5~"), undefined);
+  assert.equal(inputListener?.("\x1b[6~"), undefined);
+
+  compositor.dispose();
+});
+
 test("terminal split keyboard scroll accepts configured shortcuts", () => {
   const terminal = new FakeTerminal();
   const renderRequests: Array<boolean | undefined> = [];

package/dist/extensions/workflow/adapter.ts

@@ -299,8 +299,8 @@ async function resumeController(
       }
       const ls = controller.loopState;
       continueAgent(pi, ctx, ls.stage === "reviewing"
-        ? `Resume the loop at review round ${ls.reviewRound + 1}: call the subagent tool now with { agent: "commentator", task: "..." } to review the builder's uncommitted diff against the original goal and parent conversation context. End the review with WORKFLOW_REVIEW_STATUS: clean or WORKFLOW_REVIEW_STATUS: blocking.`
-        : `Resume the loop at review round ${ls.reviewRound}: call the subagent tool now with { agent: "builder", task: "..." } to address the feedback in ${sm.snapshot.artifactDir}/${ls.reviewPath ?? "loop-review-<round>.md"}.`);
+        ? `Resume the loop at review round ${ls.reviewRound + 1}: call the subagent tool now with { agent: "commentator", task: "..." }. Have the commentator read ${sm.snapshot.artifactDir}/handoff.md and inspect the current uncommitted diff against the handoff acceptance criteria. End the review with WORKFLOW_REVIEW_STATUS: clean or WORKFLOW_REVIEW_STATUS: blocking.`
+        : `Resume the loop at review round ${ls.reviewRound}: call the subagent tool now with { agent: "builder", task: "..." } to address the feedback in ${sm.snapshot.artifactDir}/${ls.reviewPath ?? "loop-review-<round>.md"}, using ${sm.snapshot.artifactDir}/handoff.md as the source of truth for the goal and acceptance criteria.`);
     } else {
       applyControllerEffect(controller, ctx, current);
     }

package/dist/extensions/workflow/modes/loop.ts

@@ -4,24 +4,37 @@ import type {
   WorkflowConfig,
   WorkflowModeRegistration,
 } from "../state-machine.ts";
-import { loopCompleteValidator } from "../validators.ts";
+import { handoffValidator, loopCompleteValidator } from "../validators.ts";
 
-// Direct build↔review mode for work whose plan already exists in the parent
-// conversation. The engine persists reviewer feedback and completion; no
-// planning or handoff artifact is needed.
-const phases: Phase[] = ["loop"];
+// Direct build↔review mode with a parent-persisted handoff artifact. The handoff
+// lets fresh builder/commentator subagents work from a self-contained document
+// instead of relying on the parent conversation.
+const phases: Phase[] = ["handoff", "loop"];
 
 const prompts: Partial<Record<Phase, (ctx: PromptContext) => string>> = {
+  handoff: ({ artifactDir, userPrompt }) =>
+    `You are in the HANDOFF phase of a LOOP workflow.
+
+Original goal:
+${userPrompt}
+
+Compile a self-contained handoff document so loop-phase sub-agents understand the goal, constraints, acceptance criteria, and relevant workspace context without re-grilling or re-planning.
+
+Call the subagent tool with { agent: "recapper", task: "...", output: false } (do NOT pass a model parameter). Point it at the original goal above and instruct it to use the inherited conversation to produce a concise, self-contained handoff for fresh agents. It must return the complete handoff inline; do not tell it to write any artifact.
+
+Inspect that result, verify it ends with exactly one machine-readable line on its own:
+  WORKFLOW_HANDOFF_STATUS: ready
+Then immediately call write_workflow_artifact with the complete validated handoff as content. Only that parent tool call writes ${artifactDir}/handoff.md and advances the workflow.`,
   loop: ({ artifactDir, userPrompt, loopMaxIterations }) =>
-    `You are in the LOOP phase of a LOOP workflow. The user and parent already discussed the plan; do not grill, research, create a plan, or create a handoff artifact.
+    `You are in the LOOP phase of a LOOP workflow. The workflow ENGINE owns build→review rounds and persists review feedback.
 
 Original goal:
 ${userPrompt}
 
-The workflow ENGINE owns build→review rounds and persists review feedback. Fresh subagents cannot see this conversation, so synthesize the agreed plan, constraints, acceptance criteria, and relevant workspace context into EVERY delegation prompt.
+Use read to inspect ${artifactDir}/handoff.md. Using that handoff context — not the parent conversation — generate your own delegation prompt.
 
-1. Call the subagent tool with { agent: "builder", task: "...", output: false } (do NOT pass a model parameter). Direct it to implement the agreed work in the workspace only, run relevant checks, and return an inline completion summary with checks run.
-2. Call the subagent tool with { agent: "commentator", task: "...", output: false }. Give it the same agreed context. Require independent validation: inspect the uncommitted diff, verify agreed acceptance criteria and correctness, run relevant checks where feasible, and report evidence. Its review must end with exactly one machine-readable line:
+1. Call the subagent tool with { agent: "builder", task: "...", output: false } (do NOT pass a model parameter). Give it the handoff context. Instruct it to implement the agreed work in the workspace only, run relevant checks, and return an inline completion summary with checks run. If a previous blocking review exists (e.g. ${artifactDir}/loop-review-1.md), direct the builder to read the persisted review and address every issue before returning.
+2. Call the subagent tool with { agent: "commentator", task: "...", output: false }. Give it the handoff context. Require independent validation: inspect the current uncommitted diff, verify the handoff acceptance criteria and correctness, run relevant checks where feasible, and report evidence. Its review must end with exactly one machine-readable line:
    WORKFLOW_REVIEW_STATUS: clean
    OR
    WORKFLOW_REVIEW_STATUS: blocking
@@ -33,10 +46,16 @@ When review is clean, the engine writes ${artifactDir}/loop-complete.md and make
 const config: WorkflowConfig = {
   mode: "loop",
   phases,
-  phaseArtifacts: { loop: "loop-complete.md" },
+  phaseArtifacts: {
+    handoff: "handoff.md",
+    loop: "loop-complete.md",
+  },
   prompts,
   skipRules: [],
-  artifactValidators: { loop: loopCompleteValidator },
+  artifactValidators: {
+    handoff: handoffValidator,
+    loop: loopCompleteValidator,
+  },
   closeValidators: { "loop-complete.md": loopCompleteValidator },
   closeArtifacts: ["loop-complete.md"],
   loopMaxIterations: 3,

package/docs/workflows.md

@@ -133,11 +133,11 @@ Lifecycle: `plan → reuse → handoff → loop (build ↔ review) → terminal-
 
 ### `loop` — direct build/review loop
 
-Use this after the plan was already agreed in the current conversation. It has one engine-owned `loop` phase: builder changes workspace code, commentator independently validates the diff and relevant checks, then blocking feedback returns to the builder (max 3 blocking rounds). A clean review writes `loop-complete.md`, makes the run terminal-ready, and requires explicit completion.
+Use this after the plan was already agreed in the current conversation. It captures the agreed context into a parent-owned `handoff.md` artifact, then runs an engine-owned `loop` phase: builder changes workspace code, commentator independently validates the diff and relevant checks, then blocking feedback returns to the builder (max 3 blocking rounds). A clean review writes `loop-complete.md`, makes the run terminal-ready, and requires explicit completion.
 
-Fresh subagents do not inherit the parent conversation. Before each delegation, the parent synthesizes the agreed plan, constraints, acceptance criteria, and relevant workspace context into the builder and reviewer prompts.
+Fresh subagents do not inherit the parent conversation. The parent forks a `recapper` subagent once to synthesize a concise, self-contained handoff document directly from the inherited conversation. The parent validates the handoff marker and writes `handoff.md` via `write_workflow_artifact`. After that, every builder and commentator call reads `handoff.md` instead of relying on the parent conversation. Persisted `loop-review-N.md` files feed blocking fixes back to the builder.
 
-Lifecycle: `loop (build ↔ review) → terminal-ready → end_workflow({ mode: "loop" })`
+Lifecycle: `handoff → loop (build ↔ review) → terminal-ready → end_workflow({ mode: "loop" })`
 
 - `/workflow-loop <goal>` — start a direct build/review run
 - `/workflow-loop resume` / `/workflow-loop resume <id-or-artifact-dir-or-workflow.json>` — list or resume a run

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@selesai/code",
-	"version": "0.5.25",
+	"version": "0.5.27",
 	"description": "Maintained, extension-first Pi coding agent with built-in workflows, subagents, web research, questions, skills, and an enhanced terminal UI.",
 	"type": "module",
 	"repository": {