@selesai/code 0.13.40 → 0.14.3

package/dist/extensions/pi-subagents/test/integration/model-resolution-diagnostic.test.ts

@@ -0,0 +1,108 @@
+/**
+ * A child whose model comes from an extension-registered provider fails to
+ * start when that extension is not loaded into it, and Pi core reports only
+ * that the model is unknown. These tests drive the real failure paths for both
+ * hosts: a foreground child must be told that it inherits the parent's
+ * registered providers and how to load the extension itself, and a child that
+ * did load the ambient extensions must keep the plain core error.
+ */
+
+import assert from "node:assert/strict";
+import { afterEach, beforeEach, describe, it } from "node:test";
+import { createDefaultChildSessionFactory, type PiCodingAgentModule } from "../../src/runs/shared/child-session.ts";
+import { runSync } from "../../src/runs/foreground/execution.ts";
+import { buildRunnerChildLaunch } from "../../src/runs/background/runner-child-launch.ts";
+import { runChildSession } from "../../src/runs/background/run-child-session.ts";
+import { createTempDir, makeAgent, removeTempDir } from "../support/helpers.ts";
+
+const MODEL = "pengepul/commandcode/deepseek/deepseek-v4.1-flash";
+const MODEL_NOT_FOUND = `Model "${MODEL}" not found. Use --list-models to see available models.`;
+
+/** A pi module stub whose model resolver rejects the provider-extension model. */
+function unresolvedModelPi(): PiCodingAgentModule {
+	return {
+		ModelRuntime: { create: async () => ({}) },
+		SettingsManager: { create: () => ({}) },
+		DefaultResourceLoader: class { async reload() {} },
+		SessionManager: { inMemory: () => ({}), create: () => ({}) },
+		resolveCliModel: (({ cliModel }: { cliModel: string }) => ({
+			error: `Model "${cliModel}" not found. Use --list-models to see available models.`,
+		})) as unknown as PiCodingAgentModule["resolveCliModel"],
+		createAgentSession: (async () => { throw new Error("The child must not reach session creation."); }) as unknown as PiCodingAgentModule["createAgentSession"],
+	} as unknown as PiCodingAgentModule;
+}
+
+describe("child model resolution diagnostic", () => {
+	let tempDir: string;
+
+	beforeEach(() => {
+		tempDir = createTempDir();
+	});
+	afterEach(() => removeTempDir(tempDir));
+
+	it("explains a foreground model that no parent provider serves", async () => {
+		const factory = createDefaultChildSessionFactory({ loadPiCodingAgent: async () => unresolvedModelPi() });
+		const result = await runSync(tempDir, [makeAgent("provider-model-worker", { model: MODEL })], "provider-model-worker", "Task", {
+			runId: "foreground-model-resolution",
+			waitToolEnabled: false,
+			childSessionFactory: factory,
+		});
+
+		assert.equal(result.exitCode, 1);
+		assert.equal(result.usage.turns, 0);
+		assert.deepEqual(result.messages, []);
+		assert.ok(result.error?.startsWith(MODEL_NOT_FOUND), `core error must stay first, got: ${result.error}`);
+		assert.match(result.error ?? "", /Agent 'provider-model-worker' ran as a foreground child, which never loads the parent's ambient extensions but inherits the providers they registered/);
+		assert.match(result.error ?? "", /If 'pengepul\/commandcode\/deepseek\/deepseek-v4\.1-flash' is served by a provider extension, check the parent's `\/model` list and the child extension diagnostics/);
+		assert.doesNotMatch(result.error ?? "", /`async: true`/);
+		assert.match(result.error ?? "", /load the extension for this child with `subagentOnlyExtensions` or `extensions` in the agent frontmatter/);
+	});
+
+	it("tells a foreground child that the capability ceiling denied the extension, not the frontmatter", async () => {
+		const factory = createDefaultChildSessionFactory({ loadPiCodingAgent: async () => unresolvedModelPi() });
+		const result = await runSync(tempDir, [makeAgent("provider-model-worker", { model: MODEL })], "provider-model-worker", "Task", {
+			runId: "foreground-model-policy",
+			waitToolEnabled: false,
+			childSessionFactory: factory,
+			capabilityCeiling: { version: 1, denyExtensions: true, sources: ["policy-fixture"] },
+		});
+
+		assert.equal(result.exitCode, 1);
+		assert.ok(result.error?.startsWith(MODEL_NOT_FOUND), `core error must stay first, got: ${result.error}`);
+		assert.match(result.error ?? "", /Capability ceiling from policy-fixture denies extensions/);
+		assert.match(result.error ?? "", /`async: true` does not help either/);
+		assert.match(result.error ?? "", /Relax the capability ceiling to allow extensions/);
+		assert.doesNotMatch(result.error ?? "", /must run as background children/);
+	});
+
+	it("keeps the plain model-not-found error for a background child that loaded the ambient extensions", async () => {
+		const launch = buildRunnerChildLaunch(
+			{ agent: "provider-model-worker", task: "Task" },
+			{ cwd: tempDir, id: "runner-model-resolution", flatIndex: 0 },
+			{ model: MODEL, sessionEnabled: false, watchdogStatus: () => {} },
+		);
+		assert.equal(launch.session.ambientExtensions, true, "the guard must exercise the ambient-extensions branch");
+		const factory = createDefaultChildSessionFactory({ loadPiCodingAgent: async () => unresolvedModelPi() });
+		const run = await runChildSession({ factory, launch, prompt: "Task: Task", appendChildEvent: () => {}, writeOutputLine: () => {} });
+
+		assert.equal(run.exitCode, 1);
+		assert.equal(run.error, MODEL_NOT_FOUND);
+		assert.equal(run.messages.length, 0);
+	});
+
+	it("tells a background child that the capability ceiling denied the extension", async () => {
+		const launch = buildRunnerChildLaunch(
+			{ agent: "provider-model-worker", task: "Task" },
+			{ cwd: tempDir, id: "runner-model-policy", flatIndex: 0, capabilityCeiling: { version: 1, denyExtensions: true, sources: ["policy-fixture"] } },
+			{ model: MODEL, sessionEnabled: false, watchdogStatus: () => {} },
+		);
+		assert.equal(launch.session.ambientExtensions, false, "the ceiling must disable ambient extensions for this launch");
+		const factory = createDefaultChildSessionFactory({ loadPiCodingAgent: async () => unresolvedModelPi() });
+		const run = await runChildSession({ factory, launch, prompt: "Task: Task", appendChildEvent: () => {}, writeOutputLine: () => {} });
+
+		assert.equal(run.exitCode, 1);
+		assert.match(run.error ?? "", /Capability ceiling from policy-fixture denies extensions/);
+		assert.match(run.error ?? "", /does not enable ambient loading/);
+		assert.match(run.error ?? "", /Relax the capability ceiling to allow extensions/);
+	});
+});

package/dist/extensions/pi-subagents/test/integration/nested-async-wait.test.ts

@@ -0,0 +1,61 @@
+import assert from "node:assert/strict";
+import * as fs from "node:fs";
+import * as os from "node:os";
+import * as path from "node:path";
+import { fileURLToPath } from "node:url";
+import { it } from "node:test";
+import { runSync } from "../../src/runs/foreground/execution.ts";
+import { createDefaultChildSessionFactory, setChildSessionFactory } from "../../src/runs/shared/child-session.ts";
+import { DIRS } from "../../src/shared/types.ts";
+import { makeAgent } from "../support/helpers.ts";
+
+it("native reviewer consumes nested persona results via exact, prefix, and aggregate waits", {
+	skip: !process.env.SELESAI_SUBAGENTS_NATIVE_PI_ROOT && "Requires SELESAI_SUBAGENTS_NATIVE_PI_ROOT and native-peer-loader.mjs",
+	timeout: 60000,
+}, async () => {
+	const root = fs.mkdtempSync(path.join(os.tmpdir(), "pi-native-nested-wait-"));
+	const agentDir = path.join(root, "agent");
+	const auditPath = path.join(root, "audit.jsonl");
+	const savedEnv = { ...process.env };
+	process.env.SELESAI_CODING_AGENT_DIR = agentDir;
+	process.env.PI_OFFLINE = "1";
+	process.env.SELESAI_SUBAGENTS_NATIVE_WAIT_AUDIT = auditPath;
+	const extension = fileURLToPath(new URL("../fixtures/native-nested-wait-provider.ts", import.meta.url));
+	fs.mkdirSync(path.join(agentDir, "agents"), { recursive: true });
+	fs.writeFileSync(path.join(agentDir, "settings.json"), JSON.stringify({ compaction: { enabled: false }, retry: { enabled: false } }));
+	for (const name of ["arm-a", "arm-b", "persona"]) {
+		fs.writeFileSync(path.join(agentDir, "agents", `${name}.md`), [
+			"---", `name: ${name}`, "description: Native nested wait test", `model: nested-wait-fixture/${name}`,
+			`tools: ${name === "persona" ? "read" : "read, subagent, bg_wait"}`, `extensions: ${extension}`,
+			"inheritGlobalContext: false", "inheritProjectContext: false", "inheritSkills: false", "acceptanceRole: read-only", "---", "Complete only the fixture task.",
+		].join("\n"));
+	}
+	const factory = createDefaultChildSessionFactory();
+	setChildSessionFactory(factory);
+	try {
+		const reviewer = makeAgent("reviewer", { model: "nested-wait-fixture/reviewer", tools: ["read", "subagent", "bg_wait"], extensions: [extension], inheritGlobalContext: false, inheritProjectContext: false, inheritSkills: false });
+		const result = await runSync(root, [reviewer], "reviewer", "Review using the two assigned arms", {
+			runId: "native-nested-wait", sessionDir: path.join(root, "sessions"), share: true, maxSubagentDepth: 4,
+			timeoutMs: 45000, waitToolDefaultTimeoutMs: 25000, childSessionFactory: factory,
+		});
+		assert.equal(result.exitCode, 0, `${result.error}\nAudit: ${fs.readFileSync(auditPath, "utf8")}`);
+		assert.equal(result.finalOutput, "CONSUMED_reviewer: PERSONA_EVIDENCE");
+		const audit = fs.readFileSync(auditPath, "utf8").trim().split("\n").map((line) => JSON.parse(line));
+		for (const model of ["reviewer", "arm-a", "arm-b"]) {
+			assert.ok(audit.some((entry) => entry.model === model && entry.content.some((part: { text?: string }) => part.text === `CONSUMED_${model}: PERSONA_EVIDENCE`)), `${model} must actually read and consume its descendants' findings`);
+			const readPaths: string[] = audit.filter((entry) => entry.model === model).flatMap((entry) => entry.content.filter((part: { name?: string }) => part.name === "read").map((part: { arguments: { path: string } }) => part.arguments.path));
+			assert.equal(readPaths.length, model === "arm-a" ? 2 : 1);
+			for (const file of readPaths) {
+				assert.ok(fs.existsSync(file));
+				assert.equal(file.startsWith(path.join(DIRS.results, "nested") + path.sep), model !== "reviewer", "ordinary workflow and nested result namespaces are both exercised");
+			}
+		}
+	} finally {
+		await factory.dispose();
+		setChildSessionFactory(undefined);
+		for (const key of ["SELESAI_CODING_AGENT_DIR", "PI_OFFLINE", "SELESAI_SUBAGENTS_NATIVE_WAIT_AUDIT"]) {
+			if (savedEnv[key] === undefined) delete process.env[key]; else process.env[key] = savedEnv[key];
+		}
+		fs.rmSync(root, { recursive: true, force: true });
+	}
+});

package/dist/extensions/pi-subagents/test/integration/orca-progress-tabs.test.ts

@@ -95,6 +95,7 @@ describe("Orca progress-tab observer", () => {
 				systemPrompt: "Use native Pi",
 				systemPromptMode: "replace",
 				inheritProjectContext: false,
+				inheritGlobalContext: false,
 				inheritSkills: false,
 			}],
 			resultPath,
@@ -108,7 +109,7 @@ describe("Orca progress-tab observer", () => {
 		const repo = path.resolve(import.meta.dirname, "../..");
 		const exitCode = await runProcess(
 			process.execPath,
-			[path.join(repo, "node_modules/jiti/lib/jiti-cli.mjs"), path.join(repo, "src/runs/background/subagent-runner.ts"), configPath],
+			[path.join(repo, "node_modules/jiti/lib/jiti-cli.mjs"), path.join(repo, "src/runs/background/subagent-runner-bootstrap.ts"), configPath],
 			repo,
 			{
 				...process.env,
@@ -152,8 +153,8 @@ describe("Orca progress-tab observer", () => {
 			sessionId: "session-orca-parallel",
 			steps: [{
 				parallel: [
-					{ agent: "worker", task: "One", systemPrompt: "Use native Pi", systemPromptMode: "replace", inheritProjectContext: false, inheritSkills: false },
-					{ agent: "reviewer", task: "Two", systemPrompt: "Use native Pi", systemPromptMode: "replace", inheritProjectContext: false, inheritSkills: false },
+					{ agent: "worker", task: "One", systemPrompt: "Use native Pi", systemPromptMode: "replace", inheritProjectContext: false, inheritGlobalContext: false, inheritSkills: false },
+					{ agent: "reviewer", task: "Two", systemPrompt: "Use native Pi", systemPromptMode: "replace", inheritProjectContext: false, inheritGlobalContext: false, inheritSkills: false },
 				],
 				concurrency: 2,
 			}],
@@ -168,7 +169,7 @@ describe("Orca progress-tab observer", () => {
 		const repo = path.resolve(import.meta.dirname, "../..");
 		const exitCode = await runProcess(
 			process.execPath,
-			[path.join(repo, "node_modules/jiti/lib/jiti-cli.mjs"), path.join(repo, "src/runs/background/subagent-runner.ts"), configPath],
+			[path.join(repo, "node_modules/jiti/lib/jiti-cli.mjs"), path.join(repo, "src/runs/background/subagent-runner-bootstrap.ts"), configPath],
 			repo,
 			{
 				...process.env,

package/dist/extensions/pi-subagents/test/integration/recovered-assistant-error.test.ts

@@ -57,7 +57,7 @@ interface FixtureResult {
 
 async function runFixture(host: Host, response: MockPiResponse, withStructuredOutput = false): Promise<FixtureResult> {
 	mockPi.onCall(response);
-	const agent = makeAgent("recovery-fixture", { completionGuard: false });
+	const agent = makeAgent("recovery-fixture");
 	const runId = `recovered-assistant-error-${host}-${randomUUID()}`;
 
 	if (host === "foreground") {

package/dist/extensions/pi-subagents/test/integration/render-fork-badge.test.ts

@@ -5,6 +5,7 @@ import { keyText } from "@selesai/code";
 type RenderTheme = {
 	fg(name: string, text: string): string;
 	bold(text: string): string;
+	getThinkingBorderColor(level: string): (text: string) => string;
 };
 
 type RenderSubagentResult = (
@@ -41,9 +42,10 @@ let renderSubagentSummary: RenderSubagentSummary | undefined;
 const theme = {
 	fg: (_name: string, text: string) => text,
 	bold: (text: string) => text,
+	getThinkingBorderColor: (_level: string) => (text: string) => text,
 };
 const expandKey = keyText("app.tools.expand");
-const expandHint = `Press ${expandKey} for full output`;
+const expandHint = expandKey ? `Press ${expandKey} for full output` : "Configure the expand key for full output";
 
 const emptyUsage = { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, cost: 0, turns: 0 };
 
@@ -171,7 +173,7 @@ describe("renderSubagentResult fork indicator", () => {
 		const lines = widget.render(120).map((line) => line.trimEnd());
 		assert.match(lines[0]!, /^\[fork\] Managed agents:/);
 		assert.match(lines[0]!, /…$/);
-		const hintLineIndex = lines.findIndex((line) => line.includes(expandHint) || (expandKey === "" && line.includes("Press ") && line.includes(" for full output")));
+		const hintLineIndex = lines.findIndex((line) => line.includes(expandHint));
 		assert.ok(hintLineIndex > 0);
 		assert.doesNotMatch(lines[0]!, /reviewer/);
 	});
@@ -213,7 +215,7 @@ describe("renderSubagentResult fork indicator", () => {
 		const text = widget.render(120).join("\n");
 		assert.match(text, /^Run status:/);
 		assert.match(text, /3 lines/);
-		assert.ok(text.includes(expandHint) || (expandKey === "" && text.includes("Press ") && text.includes(" for full output")));
+		assert.ok(text.includes(expandHint));
 		assert.doesNotMatch(text, /State: running/);
 	});
 
@@ -845,7 +847,7 @@ describe("renderSubagentResult fork indicator", () => {
 		}, { expanded: false }, theme);
 
 		const text = widget.render(120).join("\n");
-		assert.match(text, /Press configured-expand-key for live detail/);
+		assert.match(text, /Configure the expand key for live detail/);
 		assert.match(text, /active 2s ago/);
 		assert.match(text, /⎿  read: package\.json \| 3\.0s/);
 		assert.match(text, /output: \/tmp\/reviewer_output\.md/);

package/dist/extensions/pi-subagents/test/integration/render-widget-mouse.test.ts

@@ -0,0 +1,84 @@
+import assert from "node:assert/strict";
+import { it } from "node:test";
+import { visibleWidth } from "@earendil-works/pi-tui";
+import { renderWidget, setInlineWorkflowCoverage } from "../../src/tui/render.ts";
+import type { AsyncJobState } from "../../src/shared/types.ts";
+
+it("toggles only the async header and retains live status without changing global expansion", () => {
+	const click = { type: "click", button: "left", y: 0, shift: false, alt: false, ctrl: false };
+	type Widget = { render(width: number): string[]; handleMouse(event: typeof click): { handled: boolean } | undefined; dispose(): void };
+	const theme = { fg: (_color: string, text: string) => text, bold: (text: string) => text };
+	type WidgetFactory = (tui: { requestRender(): void }, theme: { fg(color: string, text: string): string; bold(text: string): string }) => Widget;
+	let widget: Widget | undefined;
+	let registrations = 0;
+	let renderRequests = 0;
+	let expanded = false;
+	const ctx = {
+		hasUI: true, mode: "tui",
+		ui: {
+			getToolsExpanded: () => expanded,
+			setWidget: (_key: string, factory: WidgetFactory | undefined) => {
+				registrations++;
+				widget?.dispose();
+				widget = factory?.({ requestRender: () => renderRequests++ }, theme);
+			},
+		},
+	};
+	const job = (asyncId: string, status: AsyncJobState["status"] = "running"): AsyncJobState => ({
+		asyncId, asyncDir: "/tmp/widget-mouse", status, mode: "single", agents: ["worker"], description: "Mouse test", startedAt: 1_000,
+	});
+	// SAFETY: the TUI path only reads hasUI, mode, and the supplied widget/expansion methods.
+	const render = (jobs: AsyncJobState[], initiallyCollapsed = false) => renderWidget(ctx as never, jobs, initiallyCollapsed);
+	const lines = (width = 120) => widget!.render(width);
+	const rows = Object.getOwnPropertyDescriptor(process.stdout, "rows");
+	Object.defineProperty(process.stdout, "rows", { configurable: true, value: 60 });
+	const now = Date.now;
+	Date.now = () => 2_000;
+	try {
+		render([job("a")]);
+		assert.ok(lines().length > 1);
+		assert.deepEqual(widget!.handleMouse(click), { handled: true });
+		const first = lines();
+		assert.equal(first.length, 1);
+		assert.match(first[0]!, /1\/1 running/);
+		assert.strictEqual(lines(), first, "same-frame renders reuse the cache");
+		const beforeIgnored = renderRequests;
+		for (const change of [
+			{ y: 1 }, { y: 2 }, { button: "right" }, { button: "middle" },
+			{ type: "press" }, { type: "release" }, { type: "drag" }, { type: "wheel" }, { type: "move" },
+			{ shift: true }, { alt: true }, { ctrl: true },
+		]) assert.equal(widget!.handleMouse({ ...click, ...change }), undefined);
+		assert.equal(renderRequests, beforeIgnored);
+		expanded = true;
+		assert.equal(lines().length, 1, "global expansion does not override manual collapse");
+		const jobs = [job("a"), job("b", "failed"), job("c", "queued"), job("d", "paused"), job("e", "partial"), job("f", "rejected")];
+		jobs[0]!.mode = "workflow";
+		jobs[1]!.parentWorkflowRunId = "a";
+		const snapshot = JSON.stringify(jobs);
+		render(jobs);
+		assert.equal(registrations, 1, "progress updates retain the mounted widget");
+		for (const text of ["1/6 running", "1 failed", "1 queued", "1 paused", "1 partial", "1 rejected"]) assert.ok(lines()[0]!.includes(text));
+		assert.ok(visibleWidth(lines(15)[0]!) <= 15);
+		// SAFETY: coverage uses this UI object only as a WeakMap key and invokes its registered invalidator.
+		setInlineWorkflowCoverage(ctx.ui as never, new Map([["a", "changed"]]));
+		assert.equal(lines().length, 1);
+		widget!.handleMouse(click);
+		assert.ok(lines().length > 1);
+		assert.equal(expanded, true);
+		assert.equal(JSON.stringify(jobs), snapshot);
+		render([]);
+		assert.equal(widget, undefined);
+		render([job("new")]);
+		assert.ok(lines().length > 1, "a newly mounted widget starts unfolded");
+		render([]);
+		render([job("configured")], true);
+		assert.equal(lines().length, 1, "configured widgets start folded");
+		assert.deepEqual(widget!.handleMouse(click), { handled: true });
+		assert.ok(lines().length > 1, "a header click expands a configured folded widget");
+	} finally {
+		render([]);
+		Date.now = now;
+		if (rows) Object.defineProperty(process.stdout, "rows", rows);
+		else Reflect.deleteProperty(process.stdout, "rows");
+	}
+});