@selesai/code 0.13.3 → 0.13.5

package/dist/extensions/context-compaction-reminder.ts

@@ -1,28 +1,28 @@
-import type { ExtensionAPI } from "@selesai/code";
-
-export const CONTEXT_COMPACTION_REMINDER_THRESHOLD = 128_000;
-export const CONTEXT_COMPACTION_REMINDER_MESSAGE =
-	`Conversation context has reached ${CONTEXT_COMPACTION_REMINDER_THRESHOLD.toLocaleString()} tokens. Run /handoff-new to summarize into a new chat, or enable Auto Handoff in Settings to do this automatically. Bigger context windows eat up tokens quickly and degrade AI quality.`;
-
-export default function contextCompactionReminderExtension(pi: ExtensionAPI): void {
-	let reminderShown = false;
-
-	pi.on("session_compact", () => {
-		reminderShown = false;
-	});
-
-	pi.on("agent_settled", (_event, ctx) => {
-		const tokens = ctx.getContextUsage()?.tokens;
-		if (tokens === undefined || tokens === null) return;
-
-		if (tokens < CONTEXT_COMPACTION_REMINDER_THRESHOLD) {
-			reminderShown = false;
-			return;
-		}
-
-		if (!reminderShown) {
-			ctx.ui.notify(CONTEXT_COMPACTION_REMINDER_MESSAGE, "warning");
-			reminderShown = true;
-		}
-	});
-}
+import type { ExtensionAPI } from "@selesai/code";
+
+export const CONTEXT_COMPACTION_REMINDER_THRESHOLD = 128_000;
+export const CONTEXT_COMPACTION_REMINDER_MESSAGE =
+	`Conversation context has reached ${CONTEXT_COMPACTION_REMINDER_THRESHOLD.toLocaleString()} tokens. Run /handoff-new to summarize into a new chat, or enable Auto Handoff in Settings to do this automatically. Bigger context windows eat up tokens quickly and degrade AI quality.`;
+
+export default function contextCompactionReminderExtension(pi: ExtensionAPI): void {
+	let reminderShown = false;
+
+	pi.on("session_compact", () => {
+		reminderShown = false;
+	});
+
+	pi.on("agent_settled", (_event, ctx) => {
+		const tokens = ctx.getContextUsage()?.tokens;
+		if (tokens === undefined || tokens === null) return;
+
+		if (tokens < CONTEXT_COMPACTION_REMINDER_THRESHOLD) {
+			reminderShown = false;
+			return;
+		}
+
+		if (!reminderShown) {
+			ctx.ui.notify(CONTEXT_COMPACTION_REMINDER_MESSAGE, "warning");
+			reminderShown = true;
+		}
+	});
+}

package/dist/extensions/cost-reconcile.test.ts

@@ -180,17 +180,36 @@ describe("live assistant usage reconciliation", () => {
 		expect(result.message.usage.cost.total).toBe(0);
 	});
 
-	it("falls back when a captured body has multiple candidate response ids", async () => {
-		const responseId = "live-ambiguous-response-3";
-		installFetch(
-			`data: {"id":"${responseId}","usage":{"cost":0.0123},"tool_calls":[{"id":"tool-ambiguous-3"}]}\n\n`,
-		);
+	it("reconciles a tool-call stream: keys cost by every id, message_end consumes the matching one", async () => {
+		const responseId = "live-toolcall-3";
+		const body =
+			`data: {"id":"${responseId}","choices":[{"delta":{"tool_calls":[{"id":"call_abc123","function":{"name":"bash","arguments":""}}]}}]}\n\n` +
+			`data: {"id":"${responseId}","usage":{"cost":0.0123}}\n\n` +
+			"data: [DONE]\n\n";
+		installFetch(body);
 		const { appendEntry, handlers } = createHarness();
 		await startSession(handlers);
 
 		const response = await globalThis.fetch("https://gateway.example/v1/chat/completions");
 		await response.text();
 		const message = assistantMessage(responseId);
+		const result = await handlers.get("message_end")!({ message }, {});
+		expect(result.message.usage.cost.total).toBe(0.0123);
+		expect(appendEntry).toHaveBeenCalledWith(
+			"cost-reconcile",
+			expect.objectContaining({ provider: "openrouter", responseId, cost: 0.0123, source: "payload" }),
+		);
+	});
+
+	it("does not apply a captured cost to a message whose id was not in the body", async () => {
+		const body = `data: {"id":"other-response","usage":{"cost":0.0123}}\n\ndata: [DONE]\n\n`;
+		installFetch(body);
+		const { appendEntry, handlers } = createHarness();
+		await startSession(handlers);
+
+		const response = await globalThis.fetch("https://gateway.example/v1/chat/completions");
+		await response.text();
+		const message = assistantMessage("unrelated-message");
 		expect(await handlers.get("message_end")!({ message }, {})).toBeUndefined();
 		expect(message.usage.cost.total).toBe(0.75);
 		expect(appendEntry).not.toHaveBeenCalled();

package/dist/extensions/cost-reconcile.ts

@@ -16,8 +16,11 @@
  * finishes capture before the provider SDK finalizes its assistant message, so
  * `message_end` can replace `usage.cost.total` before session persistence.
  *
- * Providers whose payloads carry no cost retain their rate-card estimate.
- * Reconciled entries remain persisted for zentui and existing-session
+ * Streamed bodies repeat the response id across chunks and also carry
+ * tool-call ids (`call_*`), so the billed cost is keyed by every id found and
+ * `message_end` consumes only the one matching the finalized message's
+ * `responseId`. Providers whose payloads carry no cost retain their rate-card
+ * estimate. Reconciled entries remain persisted for zentui and existing-session
  * compatibility.
  */
 
@@ -146,11 +149,15 @@ export default function costReconcileExtension(pi: ExtensionAPI): void {
 		// LiteLLM's header is the amount the gateway billed; prefer it over any
 		// cost the upstream payload reports.
 		const effectiveCost = headerCost ?? cost;
-		// A cost must identify exactly one response. Applying it to every `id` in
-		// a body can mistake nested tool/message ids for the assistant response.
-		if (effectiveCost === undefined || ids.length !== 1) return;
-		const responseId = ids[0]!;
-		processCaptured.set(responseId, processCaptured.has(responseId) ? null : effectiveCost);
+		if (effectiveCost === undefined || ids.length === 0) return;
+		// A streamed response repeats its own id across chunks while tool-call
+		// ids (`call_*`) appear once, so a body legitimately carries several ids.
+		// Key the billed cost by every id; message_end consumes only the one
+		// matching the finalized message's responseId. A duplicate capture of the
+		// same id (retry) is marked ambiguous rather than assigning either bill.
+		for (const responseId of ids) {
+			processCaptured.set(responseId, processCaptured.has(responseId) ? null : effectiveCost);
+		}
 		if (processCaptured.size > 500) {
 			for (const key of [...processCaptured.keys()].slice(0, processCaptured.size - 500))
 				processCaptured.delete(key);

package/dist/extensions/pi-intercom/CHANGELOG.md

@@ -4,6 +4,19 @@ All notable changes to the `pi-intercom` extension will be documented in this fi
 
 ## [Unreleased]
 
+## [0.12.1] - 2026-08-29
+
+### Highlights
+- Replies to inbound asks are now harder to send to the wrong local session by mistake.
+- The `intercom` tool now stays in the active tool set, which avoids a late-session prompt-cache reset when intercom first becomes useful.
+- Existing configs that still mention `toolVisibility` keep loading; the old setting is simply ignored.
+
+### Fixed
+- Refuse non-reply `send` calls to a different target during a turn triggered by an inbound ask, preventing CWD hierarchy or roster guesses from misdirecting replies. Thanks to [@yceachan](https://github.com/yceachan) for issue #117.
+
+### Removed
+- Removed `toolVisibility` and the `after-first-use` reveal path. The generic `intercom` schema and prompt snippet now stay stable for provider prompt caches, and existing `toolVisibility` config keys are ignored. Thanks to [@XWIlluDelu](https://github.com/XWIlluDelu) for issue #118.
+
 ## [0.12.0] - 2026-08-22
 
 ### Highlights

package/dist/extensions/pi-intercom/LICENSE

@@ -1,21 +1,21 @@
-MIT License
-
-Copyright (c) 2026 Nico Bailon
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+MIT License
+
+Copyright (c) 2026 Nico Bailon
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/dist/extensions/pi-intercom/README.md

@@ -218,7 +218,7 @@ This matters because the agent receiving the message doesn't need to reconstruct
 
 ### `send` vs `ask`
 
-`send` is fire-and-forget — the tool returns immediately after delivery. When the destination has exactly one pending inbound ask, `send` infers that it is the answer, attaches the ask's `replyTo`, and reports `Reply sent to <target> (inferred from pending ask)`. With zero or multiple matching asks, it remains an ordinary unthreaded send. An inferred answer still uses the `confirmSend` dialog when configured; only a caller-supplied `replyTo` skips confirmation.
+`send` is fire-and-forget — the tool returns immediately after delivery. When the destination has exactly one pending inbound ask, `send` infers that it is the answer, attaches the ask's `replyTo`, and reports `Reply sent to <target> (inferred from pending ask)`. During a turn triggered by an inbound ask, `send` refuses a different non-reply target instead of treating CWD, roster position, or project hierarchy as reply authority. With zero or multiple matching asks, it remains an ordinary unthreaded send. An inferred answer still uses the `confirmSend` dialog when configured; only a caller-supplied `replyTo` skips confirmation.
 
 `ask` requires a currently connected recipient, then blocks until it responds (10-minute timeout by default; set `PI_INTERCOM_ASK_TIMEOUT_MS` to a positive millisecond value to change it). If the target is disconnected, `ask` fails immediately; use `send` when queued, non-blocking mailbox delivery is appropriate. The reply comes back as the tool result, so the agent continues in the same turn with full context. No confirmation dialog — if you're asking and waiting, the intent is clear.
 
@@ -366,7 +366,7 @@ Only registered in sessions where `pi-subagents` supplied the required child bri
 
 **`list`** — Returns the current session plus other active intercom-connected sessions with name, short ID, working directory, model, and live status. Status is derived automatically from Selesai lifecycle events: `idle`, `thinking`, or `tool:<name>`.
 
-**`send`** — Sends a message to the specified session and returns immediately after delivery. If the destination has exactly one pending inbound ask, `send` infers the message is its answer and returns `Reply sent to <target> (inferred from pending ask)`; zero or multiple matches remain unthreaded sends. Set `confirmSend: true` to confirm ordinary and inferred sends. A caller-supplied `replyTo` skips confirmation. `to` alone resolves globally across all live sessions. `cwd` alone targets the sole live peer in that directory. `to` plus `cwd` requires that peer to be in the directory. With `openProjectPaneIfMissing: true`, pi-intercom opens a visible Herdr project pane, starts Selesai there, waits for that session to register, then delivers the message through normal intercom routing.
+**`send`** — Sends a message to the specified session and returns immediately after delivery. If the destination has exactly one pending inbound ask, `send` infers the message is its answer and returns `Reply sent to <target> (inferred from pending ask)`. During a turn triggered by an inbound ask, a non-reply `send` to a different target is rejected so a guessed parent/root CWD cannot receive an accidental reply. Zero or multiple pending-ask matches remain unthreaded sends outside the active ask turn. Set `confirmSend: true` to confirm ordinary and inferred sends. A caller-supplied `replyTo` skips confirmation. `to` alone resolves globally across all live sessions. `cwd` alone targets the sole live peer in that directory. `to` plus `cwd` requires that peer to be in the directory. With `openProjectPaneIfMissing: true`, pi-intercom opens a visible Herdr project pane, starts Selesai there, waits for that session to register, then delivers the message through normal intercom routing.
 
 **`ask`** — Requires a currently connected recipient, sends a message, and waits for the recipient to reply (10-minute timeout by default; configurable with `PI_INTERCOM_ASK_TIMEOUT_MS`). A disconnected target fails immediately rather than queueing a blocking request. The reply is returned as the tool result. No confirmation dialog. Only one pending `ask` is allowed per session at a time. Use this when the agent needs the answer to continue working. The same `to`, `cwd`, and `openProjectPaneIfMissing` targeting rules apply.
 
@@ -397,7 +397,6 @@ Create `~/.selesai/agent/intercom/config.json`:
   "brokerArgs": ["--no-install", "tsx"],
   "confirmSend": false,
   "inboundTrigger": "always",
-  "toolVisibility": "always",
   "enabled": true,
   "replyHint": true,
   "status": "researching"
@@ -410,12 +409,12 @@ Create `~/.selesai/agent/intercom/config.json`:
 | `brokerArgs` | `["--no-install", "tsx"]` | Advanced trusted arguments passed to custom `brokerCommand` before the broker script path |
 | `confirmSend` | false | Show a confirmation dialog before ordinary or inferred sends from an interactive session with UI; caller-supplied `replyTo` skips it |
 | `inboundTrigger` | `"always"` | Auto-trigger policy for inbound broker messages: `"always"`, `"replies"`, or `"never"`. Local in-process subagent relay events still trigger the addressed session. |
-| `toolVisibility` | `"always"` | When the generic `intercom` tool enters the active model tool set: `"always"` or `"after-first-use"`. Lazy visibility reveals it after an inbound broker message, a successful overlay send, or loading the bundled skill. It does not hide the child-only `contact_supervisor` tool. |
 | `enabled` | true | Enable/disable intercom entirely |
 | `replyHint` | true | Include reply instruction in incoming messages |
 | `status` | — | Optional custom status suffix shown after the automatic lifecycle status, for example `thinking · researching` |
 
 If `config.json` cannot be parsed or contains an invalid value, pi-intercom logs the error and fails closed for inbound broker auto-triggering by using `inboundTrigger: "never"` until the config is fixed.
+Obsolete `toolVisibility` values are ignored; the generic `intercom` tool remains stable in the active tool set for prompt-cache friendliness.
 
 Custom broker commands are trusted local configuration: anyone who can edit this config can choose the executable used for future broker auto-spawns. For example, if you have Bun installed and want it to start the broker directly, use:
 
@@ -542,7 +541,7 @@ Runtime files live at `~/.selesai/agent/intercom/` by default, or `$SELESAI_CODI
 - `broker.port.json` — Dynamic localhost TCP endpoint, only when Windows TCP transport is explicitly enabled
 - `config.json` — User configuration
 
-Supported `config.json` keys include `stableId` for restart-stable addressing, `status` for a custom status suffix, `inboundTrigger` (`always`, `replies`, or `never`), `toolVisibility` (`always` or `after-first-use`), `replyHint`, `confirmSend`, and advanced broker launch overrides.
+Supported `config.json` keys include `stableId` for restart-stable addressing, `status` for a custom status suffix, `inboundTrigger` (`always`, `replies`, or `never`), `replyHint`, `confirmSend`, and advanced broker launch overrides.
 
 ## Design Decisions
 

package/dist/extensions/pi-intercom/broker/client.test.ts

@@ -1,83 +1,83 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { IntercomClient } from "./client.ts";
-
-test("validated session lifecycle messages reach broker-message subscribers", () => {
-  const client = new IntercomClient();
-  (client as any)._sessionId = "session-1";
-  const received: unknown[] = [];
-  client.onBrokerMessage((message) => received.push(message));
-  const session = {
-    id: "session-2",
-    cwd: "/test",
-    model: "test",
-    pid: 2,
-    startedAt: 1,
-    lastActivity: 1,
-  };
-
-  (client as any).handleBrokerMessage({ type: "session_joined", session });
-  (client as any).handleBrokerMessage({ type: "presence_update", session });
-  (client as any).handleBrokerMessage({ type: "session_left", sessionId: "session-2" });
-
-  assert.deepEqual(received, [
-    { type: "session_joined", session },
-    { type: "presence_update", session },
-    { type: "session_left", sessionId: "session-2" },
-  ]);
-});
-
-test("registered feature negotiation rejects non-string feature entries", () => {
-  const client = new IntercomClient();
-  assert.throws(
-    () => (client as any).handleBrokerMessage({ type: "registered", sessionId: "session-1", features: ["valid", 123] }),
-    /Invalid registered features/,
-  );
-});
-
-test("malformed extension broker messages are rejected", () => {
-  const client = new IntercomClient();
-  (client as any)._sessionId = "session-1";
-
-  assert.throws(
-    () => (client as any).handleBrokerMessage({ type: "extension_owner", namespace: "test/v1", ownerId: "owner" }),
-    /Invalid extension_owner/,
-  );
-  assert.throws(
-    () => (client as any).handleBrokerMessage({ type: "extension_owner", namespace: "test/v1", ownerEpoch: "epoch" }),
-    /Invalid extension_owner/,
-  );
-  assert.throws(
-    () => (client as any).handleBrokerMessage({ type: "extension_message", namespace: "test/v1" }),
-    /Invalid extension_message/,
-  );
-  assert.throws(
-    () => (client as any).handleBrokerMessage({ type: "extension_state", namespace: "test/v1", revision: -1 }),
-    /Invalid extension_state/,
-  );
-  assert.throws(
-    () => (client as any).handleBrokerMessage({ type: "extension_state_result", namespace: "test/v1", committed: "yes", revision: 1 }),
-    /Invalid extension_state_result/,
-  );
-  assert.doesNotThrow(() => (client as any).handleBrokerMessage({
-    type: "extension_message",
-    namespace: "test/v1",
-    fromSessionId: "session-2",
-    payload: { peerOnly: true },
-  }));
-});
-
-test("cancelAsk ignores synchronous socket write failures", () => {
-  const client = new IntercomClient();
-  (client as any)._sessionId = "session-1";
-  (client as any).socket = {
-    destroyed: false,
-    writableEnded: false,
-    writable: true,
-    write() {
-      throw new Error("write failed");
-    },
-  };
-
-  assert.doesNotThrow(() => client.cancelAsk("ask-1"));
-});
+import test from "node:test";
+import assert from "node:assert/strict";
+import { IntercomClient } from "./client.ts";
+
+test("validated session lifecycle messages reach broker-message subscribers", () => {
+  const client = new IntercomClient();
+  (client as any)._sessionId = "session-1";
+  const received: unknown[] = [];
+  client.onBrokerMessage((message) => received.push(message));
+  const session = {
+    id: "session-2",
+    cwd: "/test",
+    model: "test",
+    pid: 2,
+    startedAt: 1,
+    lastActivity: 1,
+  };
+
+  (client as any).handleBrokerMessage({ type: "session_joined", session });
+  (client as any).handleBrokerMessage({ type: "presence_update", session });
+  (client as any).handleBrokerMessage({ type: "session_left", sessionId: "session-2" });
+
+  assert.deepEqual(received, [
+    { type: "session_joined", session },
+    { type: "presence_update", session },
+    { type: "session_left", sessionId: "session-2" },
+  ]);
+});
+
+test("registered feature negotiation rejects non-string feature entries", () => {
+  const client = new IntercomClient();
+  assert.throws(
+    () => (client as any).handleBrokerMessage({ type: "registered", sessionId: "session-1", features: ["valid", 123] }),
+    /Invalid registered features/,
+  );
+});
+
+test("malformed extension broker messages are rejected", () => {
+  const client = new IntercomClient();
+  (client as any)._sessionId = "session-1";
+
+  assert.throws(
+    () => (client as any).handleBrokerMessage({ type: "extension_owner", namespace: "test/v1", ownerId: "owner" }),
+    /Invalid extension_owner/,
+  );
+  assert.throws(
+    () => (client as any).handleBrokerMessage({ type: "extension_owner", namespace: "test/v1", ownerEpoch: "epoch" }),
+    /Invalid extension_owner/,
+  );
+  assert.throws(
+    () => (client as any).handleBrokerMessage({ type: "extension_message", namespace: "test/v1" }),
+    /Invalid extension_message/,
+  );
+  assert.throws(
+    () => (client as any).handleBrokerMessage({ type: "extension_state", namespace: "test/v1", revision: -1 }),
+    /Invalid extension_state/,
+  );
+  assert.throws(
+    () => (client as any).handleBrokerMessage({ type: "extension_state_result", namespace: "test/v1", committed: "yes", revision: 1 }),
+    /Invalid extension_state_result/,
+  );
+  assert.doesNotThrow(() => (client as any).handleBrokerMessage({
+    type: "extension_message",
+    namespace: "test/v1",
+    fromSessionId: "session-2",
+    payload: { peerOnly: true },
+  }));
+});
+
+test("cancelAsk ignores synchronous socket write failures", () => {
+  const client = new IntercomClient();
+  (client as any)._sessionId = "session-1";
+  (client as any).socket = {
+    destroyed: false,
+    writableEnded: false,
+    writable: true,
+    write() {
+      throw new Error("write failed");
+    },
+  };
+
+  assert.doesNotThrow(() => client.cancelAsk("ask-1"));
+});