@selesai/code 0.13.16 → 0.13.19

package/dist/extensions/pi-subagents/test/unit/subagent-startup-retry.test.ts

@@ -1,104 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type { Usage } from "../../src/shared/types.ts";
-import {
-	MAX_SUBAGENT_STARTUP_FAILURE_DURATION_MS,
-	SUBAGENT_STARTUP_RETRY_DELAYS_MS,
-	formatSubagentExtensionConflictError,
-	formatSubagentStartupRetryExhaustedError,
-	formatSubagentStartupRetryNote,
-	isRetryableSubagentStartupFailure,
-	waitForSubagentStartupRetry,
-	type SubagentStartupFailureEvidence,
-} from "../../src/runs/shared/subagent-startup-retry.ts";
-
-function emptyUsage(): Usage {
-	return { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, cost: 0, turns: 0 };
-}
-
-function startupFailure(overrides: Partial<SubagentStartupFailureEvidence> = {}): SubagentStartupFailureEvidence {
-	return {
-		exitCode: 1,
-		messageCount: 0,
-		toolCount: 0,
-		usage: emptyUsage(),
-		durationMs: 20,
-		...overrides,
-	};
-}
-
-describe("subagent startup retry", () => {
-	it("uses a bounded retry schedule", () => {
-		assert.deepEqual(SUBAGENT_STARTUP_RETRY_DELAYS_MS, [250, 750, 1500]);
-	});
-
-	it("classifies a short non-zero exit with no child activity", () => {
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure()), true);
-	});
-
-	it("retries only the canonical zero-activity SIGKILL startup failure", () => {
-		assert.equal(
-			isRetryableSubagentStartupFailure(startupFailure({
-				processSignal: "SIGKILL",
-				error: "Subagent process terminated by signal SIGKILL.",
-			})),
-			true,
-		);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ processSignal: "SIGKILL" })), true);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ processSignal: "SIGTERM" })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ processSignal: "SIGKILL", error: "authentication failed" })), false);
-	});
-
-	it("rejects successful, long-running, and diagnosed exits", () => {
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ exitCode: 0 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ durationMs: MAX_SUBAGENT_STARTUP_FAILURE_DURATION_MS + 1 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ error: "authentication failed" })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ finalOutput: "partial response" })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ protocolError: { code: "protocol_output_limit" } })), false);
-	});
-
-	it("rejects any model, tool, usage, mutation, or lifecycle activity", () => {
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ messageCount: 1 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ toolCount: 1 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ usage: { ...emptyUsage(), input: 1 } })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ usage: { ...emptyUsage(), turns: 1 } })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ observedMutationAttempt: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ detached: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ interrupted: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ timedOut: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ stopped: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ turnBudgetExceeded: true })), false);
-	});
-
-	it("adds actionable guidance for ambient extension registration conflicts", () => {
-		const conflict = 'Error: Failed to load extension "/tmp/pi-mcp-adapter-clone/index.ts": Tool "mcpScript" conflicts with /tmp/pi-mcp-adapter/index.ts\nError: Failed to load extension "/tmp/pi-mcp-adapter-clone/index.ts": Flag "--mcp-config" conflicts with /tmp/pi-mcp-adapter/index.ts';
-		const formatted = formatSubagentExtensionConflictError(conflict, {
-			agent: "reviewer",
-			ambientExtensionsEnabled: true,
-		});
-
-		assert.match(formatted ?? "", /loaded conflicting ambient Pi extensions/);
-		assert.match(formatted ?? "", /\.selesai[\\/]settings\.json/);
-		assert.match(formatted ?? "", /\{"subagents":\{"agentOverrides":\{"reviewer":\{"extensions":\[\]\}\}\}\}/);
-		assert.equal(formatSubagentExtensionConflictError(conflict, { agent: "reviewer", ambientExtensionsEnabled: false }), conflict);
-		assert.equal(formatSubagentExtensionConflictError("authentication failed", { agent: "reviewer", ambientExtensionsEnabled: true }), "authentication failed");
-	});
-
-	it("formats retry and exhaustion diagnostics without task content", () => {
-		assert.equal(
-			formatSubagentStartupRetryNote({ model: "openai/test", attempt: 1, maxAttempts: 4, delayMs: 250 }),
-			"[startup-retry] openai/test exited before model or tool activity (attempt 1/4). Retrying the same model in 250ms.",
-		);
-		assert.match(
-			formatSubagentStartupRetryExhaustedError({ model: "openai/test", attempts: 4 }),
-			/failed to start after 4 attempts.*concurrent Pi startup race.*lower subagent concurrency/i,
-		);
-	});
-
-	it("cancels a pending retry delay", async () => {
-		const controller = new AbortController();
-		const wait = waitForSubagentStartupRetry(5000, [controller.signal]);
-		controller.abort();
-		assert.equal(await wait, false);
-	});
-});

package/dist/extensions/pi-subagents/test/unit/windows-hide-spawn.test.ts

@@ -1,49 +0,0 @@
-import assert from "node:assert/strict";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { fileURLToPath } from "node:url";
-import { describe, it } from "node:test";
-
-const projectRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..", "..");
-
-function assertNestedPiSpawnHidesWindows(sourcePath: string): void {
-	const source = fs.readFileSync(path.join(projectRoot, sourcePath), "utf-8");
-	assert.match(
-		source,
-		/spawn\(spawnSpec\.command,\s*spawnSpec\.args,\s*\{[^}]*windowsHide:\s*true/s,
-		`${sourcePath} nested Pi spawn should set windowsHide: true`,
-	);
-}
-
-describe("nested child Pi process visibility", () => {
-	it("publishes detached terminal results before terminal status", () => {
-		const sourcePath = "src/runs/background/subagent-runner.ts";
-		const source = fs.readFileSync(path.join(projectRoot, sourcePath), "utf-8");
-		const terminalBlockStart = source.indexOf("\tstatusPayload.endedAt = runEndedAt;");
-		const resultWrite = source.indexOf("\trunPersistence.write(resultPath, {", terminalBlockStart);
-		const terminalStatusWrite = source.indexOf("\twriteStatusPayload();", terminalBlockStart);
-
-		assert.ok(terminalBlockStart >= 0, `${sourcePath} terminal block should exist`);
-		assert.ok(resultWrite > terminalBlockStart, `${sourcePath} should publish the terminal result`);
-		assert.ok(terminalStatusWrite > resultWrite, `${sourcePath} must not expose terminal status before the terminal result`);
-	});
-
-	it("hides foreground child Pi process windows on Windows", () => {
-		assertNestedPiSpawnHidesWindows("src/runs/foreground/execution.ts");
-	});
-
-	it("hides background child Pi process windows on Windows", () => {
-		assertNestedPiSpawnHidesWindows("src/runs/background/subagent-runner.ts");
-	});
-
-	it("hides mutation-evidence Git process windows on Windows", () => {
-		const sourcePath = "src/runs/shared/mutation-evidence.ts";
-		const source = fs.readFileSync(path.join(projectRoot, sourcePath), "utf-8");
-		const gitExecCalls = source.match(/execFileSync\(\s*"git"[\s\S]*?\{[^}]*\}\s*\)/g) ?? [];
-
-		assert.equal(gitExecCalls.length, 2, `${sourcePath} should have exactly two Git execFileSync calls`);
-		for (const call of gitExecCalls) {
-			assert.match(call, /\bwindowsHide:\s*true\b/, `${sourcePath} Git execFileSync should set windowsHide: true`);
-		}
-	});
-});

package/dist/extensions/web-agent-onboarding.test.ts

@@ -1,415 +0,0 @@
-import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync, mkdirSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-
-vi.mock("@selesai/code", () => ({
-	getAgentDir: () => process.env.SELESAI_CODING_AGENT_DIR ?? join(require("node:os").homedir(), ".selesai", "agent"),
-	getSettingsPath: () => join(process.env.SELESAI_CODING_AGENT_DIR ?? join(require("node:os").homedir(), ".selesai", "agent"), "settings.json"),
-}));
-
-import {
-	BRAVE_KEYS_URL,
-	getBraveApiKey,
-	getWebAgentConfigPath,
-	isPlaceholderKey,
-	ONBOARDING_MARKER_NAME,
-	readSettingsJson,
-	setBraveApiKey,
-	validateBraveKey,
-	WEB_AGENT_CONFIG_SUBPATH,
-	writeSettingsJson,
-	writeWebAgentBraveBackendConfig,
-} from "./web-agent-onboarding.ts";
-import webAgentOnboardingExtension from "./web-agent-onboarding.ts";
-import type { ExtensionAPI, ExtensionCommandContext, ExtensionContext, SessionStartEvent } from "../core/extensions/types.ts";
-
-let agentDir: string;
-
-beforeEach(() => {
-	agentDir = mkdtempSync(join(tmpdir(), "web-agent-ob-"));
-	process.env.SELESAI_CODING_AGENT_DIR = agentDir;
-});
-
-afterEach(() => {
-	rmSync(agentDir, { recursive: true, force: true });
-	delete process.env.SELESAI_CODING_AGENT_DIR;
-});
-
-describe("web-agent-onboarding helpers", () => {
-	it("isPlaceholderKey returns true for missing/empty/non-string values", () => {
-		expect(isPlaceholderKey(undefined)).toBe(true);
-		expect(isPlaceholderKey(null)).toBe(true);
-		expect(isPlaceholderKey("")).toBe(true);
-		expect(isPlaceholderKey("   ")).toBe(true);
-		expect(isPlaceholderKey(42)).toBe(true);
-		expect(isPlaceholderKey("BSA123abc")).toBe(false);
-	});
-
-	it("getBraveApiKey reads the nested value safely", () => {
-		expect(getBraveApiKey({})).toBeUndefined();
-		expect(getBraveApiKey({ webAgent: "not-an-object" })).toBeUndefined();
-		expect(getBraveApiKey({ webAgent: [] })).toBeUndefined();
-		expect(getBraveApiKey({ webAgent: { braveApiKey: "key-1" } })).toBe("key-1");
-	});
-
-	it("setBraveApiKey clones and sets the nested value", () => {
-		const original = { other: 1, webAgent: { braveApiKey: "old" } };
-		const next = setBraveApiKey(original, "new-key");
-		expect(next.webAgent).toEqual({ braveApiKey: "new-key" });
-		expect(next.other).toBe(1);
-		// original is not mutated
-		expect(original.webAgent.braveApiKey).toBe("old");
-		// missing/non-object webAgent is replaced
-		expect(setBraveApiKey({}, "k").webAgent).toEqual({ braveApiKey: "k" });
-		expect(setBraveApiKey({ webAgent: "x" }, "k").webAgent).toEqual({ braveApiKey: "k" });
-		expect(setBraveApiKey({ webAgent: [] }, "k").webAgent).toEqual({ braveApiKey: "k" });
-	});
-
-	it("validateBraveKey trims and reports errors", () => {
-		expect(validateBraveKey("  BSA-key  ")).toEqual({ key: "BSA-key" });
-		expect(validateBraveKey("")).toEqual({ error: "Key cannot be empty." });
-		expect(validateBraveKey("   ")).toEqual({ error: "Key cannot be empty." });
-		expect(validateBraveKey(undefined)).toEqual({ error: "No key entered." });
-		expect(validateBraveKey(null as unknown as string)).toEqual({ error: "No key entered." });
-	});
-
-	it("readSettingsJson parses existing file, defaults to {} for missing/corrupt", () => {
-		const settingsPath = join(agentDir, "settings.json");
-		writeFileSync(settingsPath, '{"webAgent":{"braveApiKey":"k"}}', "utf-8");
-		expect(readSettingsJson(settingsPath)).toEqual({ webAgent: { braveApiKey: "k" } });
-		expect(readSettingsJson(join(agentDir, "missing.json"))).toEqual({});
-		writeFileSync(settingsPath, "{not json", "utf-8");
-		expect(readSettingsJson(settingsPath)).toEqual({});
-	});
-
-	it("writeSettingsJson creates dirs and writes pretty JSON with trailing newline", () => {
-		const deep = join(agentDir, "nested", "dir");
-		const settingsPath = join(deep, "settings.json");
-		writeSettingsJson({ a: 1 }, settingsPath);
-		expect(readFileSync(settingsPath, "utf-8")).toBe('{\n  "a": 1\n}\n');
-	});
-
-	it("getWebAgentConfigPath joins agentDir with the config subpath", () => {
-		expect(getWebAgentConfigPath(agentDir)).toBe(join(agentDir, "extensions", "pi-web-agent", "config.json"));
-		expect(WEB_AGENT_CONFIG_SUBPATH).toBe(join("extensions", "pi-web-agent", "config.json"));
-	});
-
-	it("writeWebAgentBraveBackendConfig writes brave with duckduckgo fallback, merging existing", () => {
-		const configPath = getWebAgentConfigPath(agentDir);
-		// Pre-seed an existing config to verify merge-not-clobber.
-		mkdirSync(join(agentDir, "extensions", "pi-web-agent"), { recursive: true });
-		writeFileSync(configPath, '{"presentation":{"theme":"dark"}}', "utf-8");
-		writeWebAgentBraveBackendConfig(agentDir);
-		const parsed = JSON.parse(readFileSync(configPath, "utf-8"));
-		expect(parsed.presentation).toEqual({ theme: "dark" });
-		expect(parsed.backends.search).toEqual({ provider: "brave", fallback: "duckduckgo" });
-	});
-
-	it("writeWebAgentBraveBackendConfig tolerates missing/corrupt existing config", () => {
-		const configPath = getWebAgentConfigPath(agentDir);
-		mkdirSync(join(agentDir, "extensions", "pi-web-agent"), { recursive: true });
-		writeFileSync(configPath, "{corrupt", "utf-8");
-		writeWebAgentBraveBackendConfig(agentDir);
-		const parsed = JSON.parse(readFileSync(configPath, "utf-8"));
-		expect(parsed.backends.search).toEqual({ provider: "brave", fallback: "duckduckgo" });
-
-		// Missing file entirely -> starts fresh.
-		const freshDir = mkdtempSync(join(tmpdir(), "web-agent-fresh-"));
-		writeWebAgentBraveBackendConfig(freshDir);
-		const freshParsed = JSON.parse(readFileSync(join(freshDir, WEB_AGENT_CONFIG_SUBPATH), "utf-8"));
-		expect(freshParsed.backends.search).toEqual({ provider: "brave", fallback: "duckduckgo" });
-		rmSync(freshDir, { recursive: true, force: true });
-	});
-});
-
-describe("web-agent-onboarding constants and markers", () => {
-	it("exports the Brave keys URL and marker name", () => {
-		expect(BRAVE_KEYS_URL).toContain("brave.com");
-		expect(ONBOARDING_MARKER_NAME).toBe(".webAgentOnboardingComplete");
-	});
-});
-
-describe("web-agent-onboarding extension lifecycle", () => {
-	function makePi(overrides: Partial<ExtensionAPI> = {}): { pi: ExtensionAPI; on: ReturnType<typeof vi.fn>; registerCommand: ReturnType<typeof vi.fn> } {
-		const on = vi.fn();
-		const registerCommand = vi.fn();
-		const pi = { on, registerCommand, ...overrides } as unknown as ExtensionAPI;
-		webAgentOnboardingExtension(pi);
-		return { pi, on, registerCommand };
-	}
-
-	function sessionStartHandler(pi: ExtensionAPI): (event: SessionStartEvent, ctx: ExtensionContext) => Promise<void> {
-		return (pi.on as ReturnType<typeof vi.fn>).mock.calls.find(([event]: [string]) => event === "session_start")![1];
-	}
-
-	it("registers session_start and setup-web-search command", () => {
-		const { on, registerCommand } = makePi();
-		expect(on).toHaveBeenCalledWith("session_start", expect.any(Function));
-		expect(registerCommand).toHaveBeenCalledWith("setup-web-search", expect.objectContaining({ description: expect.stringContaining("Brave") }));
-	});
-
-	it("session_start ignores non-startup reasons", async () => {
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const ctx = { hasUI: true } as unknown as ExtensionContext;
-		await handler({ reason: "reload" } as SessionStartEvent, ctx);
-		// No marker written, no prompt: marker missing proves no completion occurred.
-		expect(existsSync(join(agentDir, ONBOARDING_MARKER_NAME))).toBe(false);
-	});
-
-	it("session_start skips when onboarding is already complete", async () => {
-		writeFileSync(join(agentDir, ONBOARDING_MARKER_NAME), "1", "utf-8");
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const input = vi.fn();
-		const ctx = { hasUI: true, ui: { input } } as unknown as ExtensionContext;
-		await handler({ reason: "startup" } as SessionStartEvent, ctx);
-		expect(input).not.toHaveBeenCalled();
-	});
-
-	it("session_start defers when SELESAI_SKIP_WEB_AGENT_ONBOARDING=1", async () => {
-		process.env.SELESAI_SKIP_WEB_AGENT_ONBOARDING = "1";
-		try {
-			const { pi } = makePi();
-			const handler = sessionStartHandler(pi);
-			const input = vi.fn();
-			const ctx = { hasUI: true, ui: { input } } as unknown as ExtensionContext;
-			await handler({ reason: "startup" } as SessionStartEvent, ctx);
-			expect(input).not.toHaveBeenCalled();
-		} finally {
-			delete process.env.SELESAI_SKIP_WEB_AGENT_ONBOARDING;
-		}
-	});
-
-	it("session_start skips when no UI is available", async () => {
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const input = vi.fn();
-		const ctx = { hasUI: false, ui: { input } } as unknown as ExtensionContext;
-		await handler({ reason: "startup" } as SessionStartEvent, ctx);
-		expect(input).not.toHaveBeenCalled();
-	});
-
-	it("already-configured key defers and marks complete", async () => {
-		const settingsPath = join(agentDir, "settings.json");
-		writeFileSync(settingsPath, '{"webAgent":{"braveApiKey":"existing-key"}}', "utf-8");
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const confirm = vi.fn();
-		const ctx = { hasUI: true, ui: { confirm } } as unknown as ExtensionContext;
-		await handler({ reason: "startup" } as SessionStartEvent, ctx);
-		expect(confirm).not.toHaveBeenCalled();
-		expect(existsSync(join(agentDir, ONBOARDING_MARKER_NAME))).toBe(true);
-	});
-
-	it("declining Brave skips onboarding and notifies", async () => {
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const notify = vi.fn();
-		const ctx = { hasUI: true, ui: { confirm: async () => false, notify } } as unknown as ExtensionContext;
-		await handler({ reason: "startup" } as SessionStartEvent, ctx);
-		expect(notify).toHaveBeenCalledWith(expect.stringContaining("skipped"), "info");
-		expect(existsSync(join(agentDir, ONBOARDING_MARKER_NAME))).toBe(true);
-	});
-
-	it("accepting Brave saves the key and config", async () => {
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const notify = vi.fn();
-		const exec = vi.fn().mockResolvedValue({ code: 0, stdout: "", stderr: "" });
-		const ctx = {
-			hasUI: true,
-			ui: { confirm: async () => true, input: async () => "  BSA-my-key  ", notify },
-		} as unknown as ExtensionContext;
-		await handler({ reason: "startup" } as SessionStartEvent, ctx);
-		expect(notify).toHaveBeenCalledWith(expect.stringContaining("saved"), "info");
-		expect(exec).not.toHaveBeenCalled(); // openBraveKeysUrl uses pi.exec — not provided here
-		const settings = JSON.parse(readFileSync(join(agentDir, "settings.json"), "utf-8"));
-		expect(settings.webAgent.braveApiKey).toBe("BSA-my-key");
-		const config = JSON.parse(readFileSync(join(agentDir, WEB_AGENT_CONFIG_SUBPATH), "utf-8"));
-		expect(config.backends.search).toEqual({ provider: "brave", fallback: "duckduckgo" });
-		expect(existsSync(join(agentDir, ONBOARDING_MARKER_NAME))).toBe(true);
-	});
-
-	it("accepting Brave with browser open failure still saves", async () => {
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const notify = vi.fn();
-		const exec = vi.fn().mockResolvedValue({ code: 1, stdout: "", stderr: "no browser" });
-		const ctx = {
-			hasUI: true,
-			ui: { confirm: async () => true, input: async () => "BSA-key", notify },
-		} as unknown as ExtensionContext;
-		await handler({ reason: "startup" } as SessionStartEvent, ctx);
-		expect(notify).toHaveBeenCalledWith(expect.stringContaining("Could not open browser"), "warning");
-		expect(notify).toHaveBeenCalledWith(expect.stringContaining("manually"), "info");
-		const settings = JSON.parse(readFileSync(join(agentDir, "settings.json"), "utf-8"));
-		expect(settings.webAgent.braveApiKey).toBe("BSA-key");
-	});
-
-	describe("openBraveKeysUrl platform branches", () => {
-		it("uses win32 command and still saves on zero exit", async () => {
-			const original = process.platform;
-			const exec = vi.fn().mockResolvedValue({ code: 0, stdout: "", stderr: "" });
-			try {
-				Object.defineProperty(process, "platform", { value: "win32", configurable: true });
-				const { pi } = makePi({ exec } as unknown as ExtensionAPI);
-				const handler = sessionStartHandler(pi);
-				const notify = vi.fn();
-				const ctx = {
-					hasUI: true,
-					ui: { confirm: async () => true, input: async () => "BSA-win", notify },
-				} as unknown as ExtensionContext;
-				await handler({ reason: "startup" } as SessionStartEvent, ctx);
-				expect(exec).toHaveBeenCalledWith("cmd", ["/c", "start", "", BRAVE_KEYS_URL], { timeout: 10_000 });
-				expect(notify).toHaveBeenCalledWith(expect.stringContaining("Opened the Brave API key dashboard"), "info");
-			} finally {
-				Object.defineProperty(process, "platform", { value: original, configurable: true });
-			}
-		});
-
-		it("uses xdg-open on other platforms", async () => {
-			const original = process.platform;
-			const exec = vi.fn().mockResolvedValue({ code: 0, stdout: "", stderr: "" });
-			try {
-				Object.defineProperty(process, "platform", { value: "linux", configurable: true });
-				const { pi } = makePi({ exec } as unknown as ExtensionAPI);
-				const handler = sessionStartHandler(pi);
-				const notify = vi.fn();
-				const ctx = {
-					hasUI: true,
-					ui: { confirm: async () => true, input: async () => "BSA-lin", notify },
-				} as unknown as ExtensionContext;
-				await handler({ reason: "startup" } as SessionStartEvent, ctx);
-				expect(exec).toHaveBeenCalledWith("xdg-open", [BRAVE_KEYS_URL], { timeout: 10_000 });
-			} finally {
-				Object.defineProperty(process, "platform", { value: original, configurable: true });
-			}
-		});
-
-		it("non-zero exit warns and opens the manual URL even after a string error", async () => {
-			const original = process.platform;
-			const exec = vi.fn().mockResolvedValue({ code: 1, stdout: "", stderr: "browser failed" });
-			try {
-				Object.defineProperty(process, "platform", { value: "darwin", configurable: true });
-				const { pi } = makePi({ exec } as unknown as ExtensionAPI);
-				const handler = sessionStartHandler(pi);
-				const notify = vi.fn();
-				const ctx = {
-					hasUI: true,
-					ui: { confirm: async () => true, input: async () => "BSA-err", notify },
-				} as unknown as ExtensionContext;
-				await handler({ reason: "startup" } as SessionStartEvent, ctx);
-				expect(notify).toHaveBeenCalledWith(expect.stringContaining("Could not open browser: Failed to open"), "warning");
-				expect(notify).toHaveBeenCalledWith(expect.stringContaining("manually"), "info");
-				// Even though the browser failed, the key is still saved.
-				const settings = JSON.parse(readFileSync(join(agentDir, "settings.json"), "utf-8"));
-				expect(settings.webAgent.braveApiKey).toBe("BSA-err");
-			} finally {
-				Object.defineProperty(process, "platform", { value: original, configurable: true });
-			}
-		});
-
-		it("a rejecting exec (non-Error) still warns without crashing the flow", async () => {
-			const original = process.platform;
-			const exec = vi.fn().mockRejectedValue("plain string failure");
-			try {
-				Object.defineProperty(process, "platform", { value: "darwin", configurable: true });
-				const { pi } = makePi({ exec } as unknown as ExtensionAPI);
-				const handler = sessionStartHandler(pi);
-				const notify = vi.fn();
-				const ctx = {
-					hasUI: true,
-					ui: { confirm: async () => true, input: async () => "BSA-rej", notify },
-				} as unknown as ExtensionContext;
-				await handler({ reason: "startup" } as SessionStartEvent, ctx);
-				expect(notify).toHaveBeenCalledWith(expect.stringContaining("Could not open browser: plain string failure"), "warning");
-				const settings = JSON.parse(readFileSync(join(agentDir, "settings.json"), "utf-8"));
-				expect(settings.webAgent.braveApiKey).toBe("BSA-rej");
-			} finally {
-				Object.defineProperty(process, "platform", { value: original, configurable: true });
-			}
-		});
-		it("non-zero exit with both stderr and stdout empty falls back to unknown error", async () => {
-			const original = process.platform;
-			const exec = vi.fn().mockResolvedValue({ code: 1, stdout: "", stderr: "" });
-			try {
-				Object.defineProperty(process, "platform", { value: "darwin", configurable: true });
-				const { pi } = makePi({ exec } as unknown as ExtensionAPI);
-				const handler = sessionStartHandler(pi);
-				const notify = vi.fn();
-				const ctx = {
-					hasUI: true,
-					ui: { confirm: async () => true, input: async () => "BSA-un", notify },
-				} as unknown as ExtensionContext;
-				await handler({ reason: "startup" } as SessionStartEvent, ctx);
-				expect(notify).toHaveBeenCalledWith(expect.stringContaining("unknown error"), "warning");
-				const settings = JSON.parse(readFileSync(join(agentDir, "settings.json"), "utf-8"));
-				expect(settings.webAgent.braveApiKey).toBe("BSA-un");
-			} finally {
-				Object.defineProperty(process, "platform", { value: original, configurable: true });
-			}
-		});
-	});
-
-	it("empty pasted key defers without saving", async () => {
-		const { pi } = makePi();
-		const handler = sessionStartHandler(pi);
-		const notify = vi.fn();
-		const ctx = {
-			hasUI: true,
-			ui: { confirm: async () => true, input: async () => "  ", notify },
-		} as unknown as ExtensionContext;
-		await handler({ reason: "startup" } as SessionStartEvent, ctx);
-		expect(notify).toHaveBeenCalledWith("Key cannot be empty.", "warning");
-		expect(existsSync(join(agentDir, ONBOARDING_MARKER_NAME))).toBe(false);
-		expect(existsSync(join(agentDir, "settings.json"))).toBe(false);
-	});
-
-	it("setup-web-search command saves and reloads extensions", async () => {
-		const exec = vi.fn().mockResolvedValue({ code: 0, stdout: "", stderr: "" });
-		const { registerCommand } = makePi({ exec } as unknown as ExtensionAPI);
-		const { handler } = registerCommand.mock.calls.find(([name]: [string]) => name === "setup-web-search")![1] as { handler: (args: string, ctx: ExtensionCommandContext) => Promise<void> };
-		const reload = vi.fn().mockResolvedValue(undefined);
-		const notify = vi.fn();
-		const ctx = {
-			hasUI: true,
-			reload,
-			ui: { confirm: async () => true, input: async () => "BSA-key", notify },
-		} as unknown as ExtensionCommandContext;
-		await handler("", ctx);
-		expect(reload).toHaveBeenCalled();
-		expect(notify).toHaveBeenCalledWith(expect.stringContaining("reloading extensions"), "info");
-		const settings = JSON.parse(readFileSync(join(agentDir, "settings.json"), "utf-8"));
-		expect(settings.webAgent.braveApiKey).toBe("BSA-key");
-	});
-
-	it("setup-web-search command does not reload when skipped", async () => {
-		const { registerCommand } = makePi();
-		const { handler } = registerCommand.mock.calls.find(([name]: [string]) => name === "setup-web-search")![1] as { handler: (args: string, ctx: ExtensionCommandContext) => Promise<void> };
-		const reload = vi.fn();
-		const notify = vi.fn();
-		const ctx = {
-			hasUI: true,
-			reload,
-			ui: { confirm: async () => false, notify },
-		} as unknown as ExtensionCommandContext;
-		await handler("", ctx);
-		expect(reload).not.toHaveBeenCalled();
-	});
-
-	it("setup-web-search command defers (no reload) when key is invalid", async () => {
-		const { registerCommand } = makePi();
-		const { handler } = registerCommand.mock.calls.find(([name]: [string]) => name === "setup-web-search")![1] as { handler: (args: string, ctx: ExtensionCommandContext) => Promise<void> };
-		const reload = vi.fn();
-		const notify = vi.fn();
-		const ctx = {
-			hasUI: true,
-			reload,
-			ui: { confirm: async () => true, input: async () => "", notify },
-		} as unknown as ExtensionCommandContext;
-		await handler("", ctx);
-		expect(reload).not.toHaveBeenCalled();
-	});
-});