@selesai/code 0.13.0 → 0.13.1

package/dist/extensions/pi-hermes-memory/src/handlers/pi-child-process.ts

@@ -0,0 +1,485 @@
+import { existsSync, readFileSync, readdirSync } from "node:fs";
+import * as fs from "node:fs/promises";
+import * as os from "node:os";
+import { dirname, join, resolve } from "node:path";
+import { fileURLToPath } from "node:url";
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import type { MemoryConfig, ThinkingLevel } from "../types.js";
+import { AGENT_ROOT } from "../paths.js";
+
+type ChildLlmConfig = Pick<MemoryConfig, "llmModelOverride" | "llmThinkingOverride" | "childExtensionPaths">;
+
+interface PiExecResult {
+  code: number;
+  stdout?: string;
+  stderr?: string;
+  killed?: boolean;
+}
+
+export interface ChildPiModel {
+  provider: string;
+  id: string;
+}
+
+export function resolveChildPiModel(
+  model: { provider?: string; id?: string } | undefined,
+): ChildPiModel | undefined {
+  return model?.provider && model.id
+    ? { provider: model.provider, id: model.id }
+    : undefined;
+}
+
+interface ExecChildPromptOptions {
+  signal?: AbortSignal;
+  cwd?: string;
+  model?: ChildPiModel;
+  timeoutMs: number;
+  retryWithoutOverrides?: boolean;
+}
+
+interface ExecChildPromptDependencies {
+  removeTemporaryDirectory: (dir: string) => Promise<void>;
+}
+
+const DEFAULT_EXEC_CHILD_PROMPT_DEPENDENCIES: ExecChildPromptDependencies = {
+  removeTemporaryDirectory: async (dir) => {
+    await fs.rm(dir, { recursive: true, force: true });
+  },
+};
+
+const WATCHDOG_EXIT_GRACE_MS = 5000;
+const CHILD_PROCESS_WATCHDOG_PATH = fileURLToPath(
+  new URL("./child-process-watchdog.mjs", import.meta.url),
+);
+export interface ChildPiInvocation {
+  command: string;
+  args: string[];
+}
+
+interface ResolveChildPiInvocationOptions {
+  platform?: NodeJS.Platform;
+  execPath?: string;
+  argv?: string[];
+  piCliPath?: string | null;
+}
+
+const OVERRIDE_FAILURE_SUBJECT = /\b(model|provider|thinking)\b/i;
+const OVERRIDE_FAILURE_REASON = /\b(not found|unknown|invalid|unsupported|unavailable|unrecognized|no match|no matches|cannot resolve|failed to resolve)\b/i;
+
+// Resolve the path to pi-hermes-memory's own extension entry point.
+// Used to pass -e <path> to child subprocesses so they only load this
+// extension instead of all plugins from settings.json.
+const OWN_EXTENSION_PATH: string = (() => {
+  try {
+    return resolve(dirname(fileURLToPath(import.meta.url)), "../index.ts");
+  } catch {
+    return "";
+  }
+})();
+
+function normalizedModelOverride(config: ChildLlmConfig): string | undefined {
+  const trimmed = config.llmModelOverride?.trim();
+  return trimmed ? trimmed : undefined;
+}
+
+function effectiveThinkingOverride(config: ChildLlmConfig): ThinkingLevel | undefined {
+  return config.llmThinkingOverride ?? (normalizedModelOverride(config) ? "off" : undefined);
+}
+
+export function hasChildLlmOverrides(config: ChildLlmConfig): boolean {
+  return normalizedModelOverride(config) !== undefined || effectiveThinkingOverride(config) !== undefined;
+}
+
+/** @deprecated No longer called after PR #78 — kept for API backward compat. */
+export function inheritedExtensionArgs(argv: string[] = process.argv.slice(2)): string[] {
+  const args: string[] = [];
+
+  for (let i = 0; i < argv.length; i++) {
+    const current = argv[i];
+    if (current === "-e" || current === "--extension") {
+      const next = argv[i + 1];
+      if (typeof next === "string" && next.length > 0) {
+        args.push(current, next);
+        i++;
+      }
+      continue;
+    }
+
+    if (current.startsWith("--extension=")) {
+      args.push(current);
+    }
+  }
+
+  return args;
+}
+
+// Provider-auth-adapter packages (e.g. Anthropic/xAI/Codex OAuth) inject
+// subscription billing headers via pi.registerProvider(). --no-extensions
+// strips these from child `pi -p` subprocesses, which silently rebills
+// subscription usage as pay-as-you-go "extra usage" instead (see issue #94).
+//
+// pi has no runtime API to enumerate loaded extensions or map a registered
+// provider back to its extension file, so we can't ask pi "what adapter is
+// active" directly. Instead we mirror pi's OWN static package-discovery
+// convention (package.json -> "pi": { "extensions": [...] }, the same field
+// pi-hermes-memory's own package.json declares) and match sibling package
+// names against a naming convention, so a future xai-oauth-adapter or
+// pi-codex-oauth-adapter is picked up automatically without a code change
+// here — no code execution, just JSON reads of sibling package.json files.
+const AUTH_ADAPTER_NAME_PATTERNS: readonly RegExp[] = [
+  /(^|[-/])oauth-adapter$/,
+  /(^|[-/])auth-adapter$/,
+];
+
+// These provider adapters predate the *-auth-adapter convention. Keep this
+// list exact so an arbitrary suffixless *-auth package cannot access child
+// maintenance prompts.
+const AUTH_ADAPTER_PACKAGE_NAMES: ReadonlySet<string> = new Set([
+  "pi-claude-auth",
+  "@gotgenes/pi-anthropic-auth",
+]);
+
+function isAuthAdapterPackageName(name: string): boolean {
+  return (
+    AUTH_ADAPTER_PACKAGE_NAMES.has(name)
+    || AUTH_ADAPTER_NAME_PATTERNS.some((pattern) => pattern.test(name))
+  );
+}
+
+// Read a sibling package's "pi": { "extensions": [...] } manifest field —
+// the same field pi's own loader reads — and resolve declared paths
+// relative to that package's directory. Mirrors loader.js#resolveExtensionEntries.
+function readPackageExtensionEntries(packageDir: string): string[] {
+  const packageJsonPath = join(packageDir, "package.json");
+  if (!existsSync(packageJsonPath)) return [];
+
+  let manifest: unknown;
+  try {
+    manifest = JSON.parse(readFileSync(packageJsonPath, "utf-8"));
+  } catch {
+    return [];
+  }
+
+  const declaredExtensions = (manifest as { pi?: { extensions?: unknown } } | null)?.pi?.extensions;
+  if (!Array.isArray(declaredExtensions)) return [];
+
+  const entries: string[] = [];
+  for (const relativePath of declaredExtensions) {
+    if (typeof relativePath !== "string") continue;
+    const resolved = resolve(packageDir, relativePath);
+    if (existsSync(resolved)) entries.push(resolved);
+  }
+  return entries;
+}
+
+function scanRootForAuthAdapters(root: string): string[] {
+  let entries: string[];
+  try {
+    entries = readdirSync(root);
+  } catch {
+    return [];
+  }
+
+  const detected: string[] = [];
+  for (const entry of entries) {
+    if (entry.startsWith("@")) {
+      // Scoped org, e.g. @xai/pi-oauth-adapter — one extra level, no deeper.
+      const scopeDir = join(root, entry);
+      let scopedPackages: string[];
+      try {
+        scopedPackages = readdirSync(scopeDir);
+      } catch {
+        continue;
+      }
+      for (const scopedName of scopedPackages) {
+        if (!isAuthAdapterPackageName(`${entry}/${scopedName}`)) continue;
+        detected.push(...readPackageExtensionEntries(join(scopeDir, scopedName)));
+      }
+      continue;
+    }
+
+    if (!isAuthAdapterPackageName(entry)) continue;
+    detected.push(...readPackageExtensionEntries(join(root, entry)));
+  }
+  return detected;
+}
+
+// `roots` is overridable so tests can point this at fixture directories
+// instead of the real sibling-packages trees. Two roots are scanned by
+// default: packages installed alongside pi-hermes-memory's own package
+// (the common npm-managed-extensions layout), and AGENT_ROOT's npm
+// directory (covers pi-hermes-memory being loaded from elsewhere, e.g. a
+// local dev checkout via -e, while the adapter is still npm-managed).
+export function detectAuthAdapterExtensionPaths(roots?: string[]): string[] {
+  const searchRoots = roots ?? [
+    OWN_EXTENSION_PATH ? resolve(dirname(dirname(OWN_EXTENSION_PATH)), "..") : "",
+    join(AGENT_ROOT, "npm", "node_modules"),
+  ].filter((root) => root.length > 0);
+
+  const seenRoots: string[] = [];
+  const detected: string[] = [];
+  for (const root of searchRoots) {
+    if (seenRoots.includes(root)) continue;
+    seenRoots.push(root);
+    detected.push(...scanRootForAuthAdapters(root));
+  }
+  return detected;
+}
+
+function childExtensionSources(config: ChildLlmConfig): string[] {
+  const seen = new Set<string>();
+  const sources: string[] = [];
+  const append = (candidate: string | undefined): void => {
+    const trimmed = candidate?.trim();
+    if (!trimmed || seen.has(trimmed)) return;
+    seen.add(trimmed);
+    sources.push(trimmed);
+  };
+
+  // These paths are discovered by Hermes rather than explicitly trusted in
+  // configuration, so keep the local existence check before forwarding them.
+  if (OWN_EXTENSION_PATH && existsSync(OWN_EXTENSION_PATH)) append(OWN_EXTENSION_PATH);
+  for (const source of config.childExtensionPaths ?? []) append(source);
+  for (const adapterPath of detectAuthAdapterExtensionPaths()) {
+    const normalized = resolve(adapterPath);
+    if (existsSync(normalized)) append(normalized);
+  }
+  return sources;
+}
+
+function appendOwnExtensionArgs(args: string[], config: ChildLlmConfig): void {
+  // Skip all packages from settings.json (--no-extensions) — the subprocess
+  // loads only Hermes and explicitly trusted provider/auth sources. Leave
+  // configured sources untouched so Pi's -e resolver owns path expansion and
+  // package-source handling exactly as it does for normal CLI invocations.
+  args.push("--no-extensions");
+  for (const extensionSource of childExtensionSources(config)) {
+    args.push("-e", extensionSource);
+  }
+}
+
+export function buildChildPiPromptArgs(
+  prompt: string,
+  config: ChildLlmConfig,
+  _argv: string[] = process.argv.slice(2),
+  activeModel?: ChildPiModel,
+): string[] {
+  const args = ["-p", "--no-session"];
+  const model = normalizedModelOverride(config)
+    ?? (activeModel?.provider && activeModel.id ? `${activeModel.provider}/${activeModel.id}` : undefined);
+  const thinking = effectiveThinkingOverride(config);
+
+  if (model) args.push("--model", model);
+  if (thinking) args.push("--thinking", thinking);
+  appendOwnExtensionArgs(args, config);
+  args.push(prompt);
+
+  return args;
+}
+
+function basePromptArgs(prompt: string, config: ChildLlmConfig, activeModel?: ChildPiModel): string[] {
+  // Always use --no-extensions + own path so the retry also avoids loading
+  // all settings.json packages — matching the primary code path.
+  const args = ["-p", "--no-session"];
+  if (activeModel?.provider && activeModel.id) {
+    args.push("--model", `${activeModel.provider}/${activeModel.id}`);
+  }
+  appendOwnExtensionArgs(args, config);
+  args.push(prompt);
+  return args;
+}
+
+function isCliJsPath(value: string | undefined): value is string {
+  if (!value) return false;
+  return value.replace(/\\/g, "/").toLowerCase().endsWith("/cli.js");
+}
+
+function resolvedInstalledPiCliPath(): string | undefined {
+  try {
+    const packageEntry = import.meta.resolve("@selesai/code");
+    const entryPath = fileURLToPath(packageEntry);
+    const cliPath = join(dirname(entryPath), "cli.js");
+    return existsSync(cliPath) ? cliPath : undefined;
+  } catch {
+    return undefined;
+  }
+}
+
+function resolvedPiCliPath(options: ResolveChildPiInvocationOptions): string | undefined {
+  if (options.piCliPath !== undefined) {
+    return options.piCliPath ?? undefined;
+  }
+
+  const argv = options.argv ?? process.argv;
+  const currentCli = argv[1];
+  if (isCliJsPath(currentCli) && existsSync(currentCli)) {
+    return currentCli;
+  }
+
+  return resolvedInstalledPiCliPath();
+}
+
+function resolvedWindowsPiInvocation(
+  args: string[],
+  execPath: string,
+): ChildPiInvocation | undefined {
+  const pathEntries = (process.env.PATH ?? process.env.Path ?? "")
+    .split(";")
+    .map((entry) => entry.trim().replace(/^"|"$/g, ""))
+    .filter(Boolean);
+
+  for (const directory of pathEntries) {
+    for (const executableName of ["selesai.exe", "selesai.com"]) {
+      const executablePath = join(directory, executableName);
+      if (existsSync(executablePath)) {
+        return { command: executablePath, args };
+      }
+    }
+
+    if (!existsSync(join(directory, "selesai.cmd")) && !existsSync(join(directory, "selesai.bat"))) {
+      continue;
+    }
+
+    for (const cliPath of [
+      join(directory, "node_modules", "@selesai", "code", "dist", "cli.js"),
+      join(directory, "node_modules", "@selesai", "code", "cli.js"),
+    ]) {
+      if (existsSync(cliPath)) {
+        return { command: execPath, args: [cliPath, ...args] };
+      }
+    }
+  }
+
+  return undefined;
+}
+
+export function resolveChildPiInvocation(
+  args: string[],
+  options: ResolveChildPiInvocationOptions = {},
+): ChildPiInvocation {
+  const platform = options.platform ?? process.platform;
+  if (platform !== "win32") {
+    return { command: "selesai", args };
+  }
+
+  const piCliPath = resolvedPiCliPath(options);
+  if (piCliPath) {
+    return {
+      command: options.execPath ?? process.execPath,
+      args: [piCliPath, ...args],
+    };
+  }
+
+  const fallback = resolvedWindowsPiInvocation(args, options.execPath ?? process.execPath);
+  if (fallback) return fallback;
+
+  throw new Error("Unable to resolve a directly executable Pi CLI on Windows");
+}
+
+export function resolveWatchedChildPiInvocation(
+  invocation: ChildPiInvocation,
+  timeoutMs: number,
+  cancellationPath = "-",
+): ChildPiInvocation {
+  return {
+    command: process.execPath,
+    args: [
+      CHILD_PROCESS_WATCHDOG_PATH,
+      String(timeoutMs),
+      cancellationPath,
+      invocation.command,
+      ...invocation.args,
+    ],
+  };
+}
+
+function shouldRetryWithoutOverridesFromText(text: string | undefined): boolean {
+  if (!text) return false;
+  return OVERRIDE_FAILURE_SUBJECT.test(text) && OVERRIDE_FAILURE_REASON.test(text);
+}
+
+function shouldRetryWithoutOverrides(result: PiExecResult): boolean {
+  return shouldRetryWithoutOverridesFromText(result.stderr) || shouldRetryWithoutOverridesFromText(result.stdout);
+}
+
+function shouldRetryWithoutOverridesForError(error: unknown): boolean {
+  return shouldRetryWithoutOverridesFromText(String(error));
+}
+
+async function writePromptToTemporaryFile(prompt: string): Promise<{ dir: string; filePath: string }> {
+  const dir = await fs.mkdtemp(join(os.tmpdir(), "pi-hermes-prompt-"));
+  const filePath = join(dir, "prompt.md");
+  try {
+    await fs.writeFile(filePath, prompt, { encoding: "utf-8", mode: 0o600 });
+    return { dir, filePath };
+  } catch (error) {
+    try { await fs.rm(dir, { recursive: true, force: true }); } catch {}
+    throw error;
+  }
+}
+
+export async function execChildPrompt(
+  pi: Pick<ExtensionAPI, "exec">,
+  prompt: string,
+  config: ChildLlmConfig,
+  options: ExecChildPromptOptions,
+  dependencies: ExecChildPromptDependencies = DEFAULT_EXEC_CHILD_PROMPT_DEPENDENCIES,
+): Promise<PiExecResult> {
+  const execOptions = {
+    cwd: options.cwd,
+    timeout: options.timeoutMs + WATCHDOG_EXIT_GRACE_MS,
+  };
+  const temporaryPrompt = await writePromptToTemporaryFile(prompt);
+  const promptReference = `@${temporaryPrompt.filePath}`;
+  const cancellationPath = join(temporaryPrompt.dir, "cancel");
+  let cancellationRequest: Promise<void> | undefined;
+  const requestCancellation = () => {
+    cancellationRequest ??= fs.writeFile(cancellationPath, "", { mode: 0o600 }).catch(() => {});
+  };
+  options.signal?.addEventListener("abort", requestCancellation, { once: true });
+  if (options.signal?.aborted) {
+    requestCancellation();
+    await cancellationRequest;
+  }
+
+  try {
+    try {
+      const invocation = resolveWatchedChildPiInvocation(
+        resolveChildPiInvocation(buildChildPiPromptArgs(promptReference, config, process.argv.slice(2), options.model)),
+        options.timeoutMs,
+        cancellationPath,
+      );
+      const result = await pi.exec(invocation.command, invocation.args, execOptions) as PiExecResult;
+      if (
+        result.code === 0 ||
+        !options.retryWithoutOverrides ||
+        !hasChildLlmOverrides(config) ||
+        !shouldRetryWithoutOverrides(result)
+      ) {
+        return result;
+      }
+    } catch (error) {
+      if (
+        !options.retryWithoutOverrides ||
+        !hasChildLlmOverrides(config) ||
+        !shouldRetryWithoutOverridesForError(error)
+      ) {
+        throw error;
+      }
+    }
+
+    const retryInvocation = resolveWatchedChildPiInvocation(
+      resolveChildPiInvocation(basePromptArgs(promptReference, config, options.model)),
+      options.timeoutMs,
+      cancellationPath,
+    );
+    return await pi.exec(retryInvocation.command, retryInvocation.args, execOptions) as PiExecResult;
+  } finally {
+    options.signal?.removeEventListener("abort", requestCancellation);
+    try {
+      await dependencies.removeTemporaryDirectory(temporaryPrompt.dir);
+    } catch {
+      try { await fs.unlink(temporaryPrompt.filePath); } catch {}
+    }
+  }
+}

package/dist/extensions/pi-hermes-memory/src/handlers/preview-context.ts

@@ -0,0 +1,105 @@
+/**
+ * Preview context command — /memory-preview-context shows the policy-only prompt
+ * or legacy memory blocks appended to the system prompt.
+ */
+
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { MemoryStore } from "../store/memory-store.js";
+import type { StandingInstructions } from "../store/standing-instructions.js";
+import { resolveMemoryPolicyPrompt } from "../prompt-context.js";
+import type { MemoryConfig } from "../types.js";
+import { resolveProjectName, resolveProjectStore, type ProjectNameRef, type ProjectStoreRef } from "../project-context.js";
+
+function appendStandingBlock(lines: string[], standing: StandingInstructions | null): number {
+  const rendered = standing?.render();
+  if (!rendered?.block) return 0;
+  lines.push("  ── STANDING INSTRUCTIONS (always injected) ─────────────────");
+  lines.push(rendered.block);
+  if (rendered.omittedCount > 0) {
+    lines.push(`  ⚠️ ${rendered.omittedCount} pinned instruction(s) exceed the budget and are NOT injected.`);
+  }
+  lines.push("");
+  return 1;
+}
+
+export function registerPreviewContextCommand(
+  pi: ExtensionAPI,
+  store: MemoryStore,
+  projectStore: ProjectStoreRef,
+  projectName: ProjectNameRef,
+  config: Pick<MemoryConfig, "memoryMode" | "memoryPolicyStyle" | "memoryPolicyCustomText"> = { memoryMode: "policy-only" },
+  standing: StandingInstructions | null = null,
+): void {
+  pi.registerCommand("memory-preview-context", {
+    description: "Preview the memory policy or legacy memory context blocks",
+    handler: async (_args, ctx) => {
+      if (config.memoryMode === "policy-only") {
+        const policyPrompt = resolveMemoryPolicyPrompt(config);
+        const lines: string[] = [];
+        lines.push("");
+        lines.push("  ╔══════════════════════════════════════════════╗");
+        lines.push("  ║        Injected Context Preview             ║");
+        lines.push("  ╚══════════════════════════════════════════════╝");
+        lines.push("");
+        lines.push("  Mode: policy-only");
+        lines.push(`  Policy style: ${config.memoryPolicyStyle ?? "full"}`);
+        lines.push("  This is the memory policy appended to the system prompt.");
+        lines.push("  Full Markdown memories are NOT injected in this mode.");
+        lines.push("");
+        let blockCount = 0;
+        if (policyPrompt) {
+          blockCount++;
+          lines.push(policyPrompt);
+          lines.push("");
+        } else {
+          lines.push("  No memory policy context is injected for this policy style.");
+          lines.push("");
+        }
+        blockCount += appendStandingBlock(lines, standing);
+        lines.push(`  Blocks shown: ${blockCount}`);
+        ctx.ui.notify(lines.join("\n"), "info");
+        return;
+      }
+      const activeProjectStore = resolveProjectStore(projectStore);
+      const activeProjectName = resolveProjectName(projectName);
+      const memoryBlock = store.formatForSystemPrompt();
+      const projectBlock = activeProjectStore ? activeProjectStore.formatProjectBlock(activeProjectName ?? "") : "";
+
+      const lines: string[] = [];
+      lines.push("");
+      lines.push("  ╔══════════════════════════════════════════════╗");
+      lines.push("  ║        👀 Injected Context Preview          ║");
+      lines.push("  ╚══════════════════════════════════════════════╝");
+      lines.push("");
+      lines.push("  This is the memory context appended to the system prompt.");
+      lines.push("  (Core hidden system instructions are NOT shown.)");
+      lines.push("");
+
+      let blockCount = 0;
+
+      if (memoryBlock) {
+        blockCount++;
+        lines.push("  ── MEMORY + USER + RECENT FAILURES ─────────────────────────");
+        lines.push(memoryBlock);
+        lines.push("");
+      }
+      if (projectBlock) {
+        blockCount++;
+        lines.push(`  ── PROJECT MEMORY (${activeProjectName ?? ""}) ─────────────────────────`);
+        lines.push(projectBlock);
+        lines.push("");
+      }
+
+      blockCount += appendStandingBlock(lines, standing);
+
+      if (blockCount === 0) {
+        lines.push("  No memory context blocks are currently injected.");
+        lines.push("  Add memory entries, then run this command again.");
+        lines.push("");
+      }
+
+      lines.push(`  Blocks shown: ${blockCount}`);
+      ctx.ui.notify(lines.join("\n"), "info");
+    },
+  });
+}