@selesai/code 0.12.0 → 0.13.1

package/dist/extensions/pi-subagents/test/unit/workflow-preflight.test.ts

@@ -0,0 +1,155 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+import {
+	WORKFLOW_PREFLIGHT_MAX_BYTES,
+	WORKFLOW_PREFLIGHT_MAX_CLAIMS,
+	WORKFLOW_PREFLIGHT_MAX_LANES,
+	WORKFLOW_PREFLIGHT_MAX_STRING_LENGTH,
+	WORKFLOW_PREFLIGHT_MAX_WARNINGS,
+	annotateWorkflowPreflightTrace,
+	formatWorkflowPreflight,
+	formatWorkflowPreflightPlanSummary,
+	formatWorkflowPreflightSummary,
+	formatWorkflowPreflightWarningSummary,
+	normalizeWorkflowPreflight,
+	validateWorkflowPreflight,
+	workflowPreflightWarnings,
+} from "../../src/workflows/workflow-preflight.ts";
+
+const preflight = {
+	version: 1 as const,
+	coverage: "complete" as const,
+	lanes: [{
+		key: "issue1624-writer",
+		mode: "mutation" as const,
+		decision: "Implement bounded preflight",
+		claims: ["src/workflows/workflow-preflight.ts"],
+		expectedOutput: "writer and review report",
+		independence: "does not touch cleanup",
+	}],
+};
+
+describe("workflow preflight metadata", () => {
+	it("normalizes bounded display hints and renders the compact table", () => {
+		const normalized = normalizeWorkflowPreflight({
+			...preflight,
+			lanes: [{
+				...preflight.lanes[0],
+				key: " issue1624-writer ",
+				decision: "Implement\n bounded\tpreflight",
+			}],
+		});
+		assert.deepEqual(normalized, {
+			version: 1,
+			coverage: "complete",
+			lanes: [{
+				key: "issue1624-writer",
+				mode: "mutation",
+				decision: "Implement bounded preflight",
+				claims: ["src/workflows/workflow-preflight.ts"],
+				expectedOutput: "writer and review report",
+				independence: "does not touch cleanup",
+			}],
+		});
+		const table = formatWorkflowPreflight(normalized);
+		assert.match(table, /Preflight: v1 · complete · 1 lane/);
+		assert.match(table, /key \| mode \| decision \| claims \| expected output \| independence/);
+		assert.match(table, /issue1624-writer \| mutation \| Implement bounded preflight/);
+		assert.match(formatWorkflowPreflightSummary(normalized), /preflight · complete · 1 lane: issue1624-writer/);
+		assert.equal(formatWorkflowPreflightPlanSummary(normalized), "Plan: 1 lane · Implement bounded preflight");
+		assert.equal(formatWorkflowPreflightWarningSummary(["one", "two"], { indent: "  ", hint: "expand for debug" }), "  Plan note: 2 preflight mismatches · expand for debug.");
+	});
+
+	it("rejects unsupported, malformed, duplicate, and over-bound metadata", () => {
+		const invalidValues: Array<[unknown, RegExp]> = [
+			[{ version: 2, lanes: [] }, /preflight\.version/],
+			[{ version: 1, lanes: [], extra: true }, /unsupported field 'extra'/],
+			[{ version: 1, coverage: "strict", lanes: [] }, /coverage/],
+			[{ version: 1, lanes: [{ key: "bad key" }] }, /lanes\[0\]\.key/],
+			[{ version: 1, lanes: [{ key: "same" }, { key: "same" }] }, /duplicate key/],
+			[{ version: 1, lanes: [{ key: "same", mode: "owner" }] }, /mode/],
+			[{ version: 1, lanes: [{ key: "same", claims: ["claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim", "claim"] }] }, /at most/],
+			[{ version: 1, lanes: [{ key: "same", decision: "x".repeat(WORKFLOW_PREFLIGHT_MAX_STRING_LENGTH + 1) }] }, /maximum length/],
+		];
+		for (const [value, pattern] of invalidValues) assert.throws(() => normalizeWorkflowPreflight(value), pattern);
+		assert.throws(() => normalizeWorkflowPreflight({ version: 1, lanes: Array.from({ length: WORKFLOW_PREFLIGHT_MAX_LANES + 1 }, (_, index) => ({ key: `lane-${index}` })) }), /at most/);
+		const getter = { version: 1, lanes: [] } as Record<string, unknown>;
+		Object.defineProperty(getter, "lanes", { enumerable: true, get: () => [] });
+		assert.throws(() => normalizeWorkflowPreflight(getter), /must be an enumerable data property/);
+		const tooLarge = {
+			version: 1,
+			lanes: Array.from({ length: WORKFLOW_PREFLIGHT_MAX_LANES }, (_, index) => ({
+				key: `large-${index}`,
+				decision: "x".repeat(WORKFLOW_PREFLIGHT_MAX_STRING_LENGTH),
+			})),
+		};
+		assert.ok(Buffer.byteLength(JSON.stringify(tooLarge), "utf8") > WORKFLOW_PREFLIGHT_MAX_BYTES);
+		assert.throws(() => normalizeWorkflowPreflight(tooLarge), /canonical JSON/);
+		assert.equal(validateWorkflowPreflight(preflight).ok, true);
+		assert.equal(validateWorkflowPreflight({ version: 1, lanes: [{ key: "bad key" }] }).ok, false);
+	});
+
+	it("reports bounded advisory mismatches and ignores auto-resume launches", () => {
+		const trace = [
+			{ operation: "run", key: "issue1624-writer", state: "started" as const },
+			{ operation: "run", key: "undeclared", state: "started" as const },
+			{ operation: "run", key: "undeclared", state: "completed" as const },
+			{ operation: "run", key: "issue1624-writer", state: "started" as const, phase: "auto-resume" },
+		];
+		assert.deepEqual(workflowPreflightWarnings(preflight, trace), [
+			"Preflight advisory: workflow key 'undeclared' launched without a declared lane.",
+		]);
+		assert.deepEqual(workflowPreflightWarnings(preflight, trace, { settled: true }), [
+			"Preflight advisory: workflow key 'undeclared' launched without a declared lane.",
+		]);
+		const annotated = annotateWorkflowPreflightTrace(trace, preflight);
+		assert.match(annotated[1]?.warning ?? "", /undeclared/);
+		assert.equal(annotated[2]?.warning, undefined);
+		assert.equal(annotated[3]?.warning, undefined);
+	});
+
+	it("reports declared-but-never-launched lanes only at settlement and caps warnings", () => {
+		const manyLanes = normalizeWorkflowPreflight({
+			version: 1,
+			lanes: Array.from({ length: WORKFLOW_PREFLIGHT_MAX_LANES }, (_, index) => ({ key: `declared-${index}` })),
+		});
+		const warnings = workflowPreflightWarnings(manyLanes, Array.from({ length: WORKFLOW_PREFLIGHT_MAX_LANES }, (_, index) => ({ operation: "run", key: `extra-${index}`, state: "started" as const })), { settled: true });
+		assert.equal(warnings.length, WORKFLOW_PREFLIGHT_MAX_WARNINGS);
+		assert.match(warnings.at(-1) ?? "", /additional mismatch warning\(s\) omitted/);
+		assert.deepEqual(workflowPreflightWarnings(manyLanes, [], { settled: false }), []);
+		assert.ok(workflowPreflightWarnings(manyLanes, [], { settled: true }).some((warning) => warning.includes("declared lane 'declared-0' was not launched")));
+		assert.ok(WORKFLOW_PREFLIGHT_MAX_CLAIMS > 0);
+	});
+
+	it("treats exact and direct dotted keys as declared lane stages by convention", () => {
+		const lanes = normalizeWorkflowPreflight({
+			version: 1,
+			coverage: "complete",
+			lanes: [{ key: "audit" }],
+		});
+		const generatedStageTrace = [
+			{ operation: "run", key: "audit.writer", generatedLaneKey: "audit", state: "completed" as const },
+			{ operation: "run", key: "audit.review", generatedLaneKey: "audit", state: "completed" as const },
+		];
+		assert.deepEqual(workflowPreflightWarnings(lanes, generatedStageTrace, { settled: true }), []);
+		assert.equal(annotateWorkflowPreflightTrace(generatedStageTrace, lanes).some((entry) => entry.warning), false);
+
+		// Direct runs.run keys intentionally use the same lane.stage convention without provenance.
+		const directStageTrace = [
+			{ operation: "run", key: "audit.shadow", state: "started" as const },
+			{ operation: "run", key: "audit-other.writer", state: "started" as const },
+		];
+		assert.deepEqual(workflowPreflightWarnings(lanes, directStageTrace), [
+			"Preflight advisory: workflow key 'audit-other.writer' launched without a declared lane.",
+		]);
+		assert.deepEqual(workflowPreflightWarnings(lanes, directStageTrace, { settled: true }), [
+			"Preflight advisory: workflow key 'audit-other.writer' launched without a declared lane.",
+		]);
+		const directAnnotated = annotateWorkflowPreflightTrace(directStageTrace, lanes);
+		assert.equal(directAnnotated[0]?.warning, undefined);
+		assert.match(directAnnotated[1]?.warning ?? "", /without a declared lane/);
+
+		const exactTrace = [{ operation: "run", key: "audit", state: "completed" as const }];
+		assert.deepEqual(workflowPreflightWarnings(lanes, exactTrace, { settled: true }), []);
+	});
+});

package/dist/extensions/pi-subagents/test/unit/workflow-receipt.test.ts

@@ -4,7 +4,10 @@ import os from "node:os";
 import path from "node:path";
 import { afterEach, describe, it } from "node:test";
 import { buildWorkflowReceipt, readWorkflowReceipt, resolveWorkflowReceiptResume, workflowReceiptPath, writeWorkflowReceipt } from "../../src/workflows/workflow-receipt.ts";
+import { externalCliReceiptMetadata, resolveExternalCliRunnerStatus } from "../../src/runs/shared/external-cli-contract.ts";
 import type { WorkflowScriptChildResult } from "../../src/workflows/scripted-workflow.ts";
+import type { HostStepNodeV1 } from "../../src/shared/types.ts";
+import { parseWorkflowChildSummary, workflowChildSummary } from "../../src/workflows/workflow-child-summary.ts";
 
 const roots: string[] = [];
 
@@ -36,7 +39,89 @@ function child(key: string, overrides: Partial<WorkflowScriptChildResult> = {}):
 	};
 }
 
+function hostStep(overrides: Partial<HostStepNodeV1> = {}): HostStepNodeV1 {
+	return {
+		version: 1,
+		kind: "host-step",
+		monitorKind: "gate",
+		id: "gate-1",
+		label: "Review gate",
+		state: "done",
+		verdict: "pass",
+		updatedAt: 10,
+		...overrides,
+	};
+}
+
 describe("workflow receipts", () => {
+	it("reads old receipt-v1 files without external adapter metadata", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-old");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		fs.writeFileSync(path.join(asyncDir, "workflow-receipt.json"), JSON.stringify({
+			version: 1,
+			workflowRunId: "workflow-old",
+			state: "complete",
+			createdAt: 10,
+			entries: { advisor: { key: "advisor", latestRunId: "run-old", resumability: { state: "resumable" }, continuation: { runIds: ["run-old"] } } },
+		}));
+
+		assert.equal(readWorkflowReceipt(asyncRoot, "workflow-old").entries.advisor?.externalAdapter, undefined);
+	});
+
+	it("round-trips bounded host CI/gate state in terminal receipts", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-host");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		const receipt = buildWorkflowReceipt({
+			workflowRunId: "workflow-host",
+			state: "complete",
+			children: [],
+			hostSteps: [hostStep({ monitorKind: "ci", id: "ci-1", label: "CI checks", provider: "opaque-provider", state: "done", verdict: "inconclusive", reasonCode: "stale-head", freshness: { expectedRef: "old", observedRef: "new", stale: true }, reportPath: "/private/report.json" })],
+			createdAt: 10,
+		});
+		writeWorkflowReceipt(asyncDir, receipt);
+		assert.deepEqual(readWorkflowReceipt(asyncRoot, "workflow-host").hostSteps, receipt.hostSteps);
+		assert.equal(JSON.stringify(receipt).includes("/private/report.json"), true);
+	});
+
+	it("reads inconclusive host monitor receipt state without a verdict", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-host-inconclusive");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		const receipt = buildWorkflowReceipt({ workflowRunId: "workflow-host-inconclusive", state: "complete", children: [] });
+		fs.writeFileSync(workflowReceiptPath(asyncRoot, "workflow-host-inconclusive"), JSON.stringify({ ...receipt, hostSteps: [{ ...hostStep(), state: "done", verdict: undefined }] }));
+		assert.equal(readWorkflowReceipt(asyncRoot, "workflow-host-inconclusive").hostSteps?.[0]?.verdict, undefined);
+	});
+
+	it("reads legacy Grok receipt metadata after the active profile is removed", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-old-grok");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		const reason = "The legacy prompt-file adapter has no durable external session identity.";
+		fs.writeFileSync(path.join(asyncDir, "workflow-receipt.json"), JSON.stringify({
+			version: 1,
+			workflowRunId: "workflow-old-grok",
+			state: "complete",
+			createdAt: 10,
+			entries: { grok: {
+				key: "grok",
+				resumability: { state: "not-resumable", reason },
+				continuation: { runIds: [] },
+				externalAdapter: {
+					adapter: { id: "grok-build", version: 1, executionMode: "one-shot-prompt-file" },
+					capabilities: { stop: true, steer: false, resume: false, structuredOutput: false, toolEvents: false, supervisor: "unsupported", forkContext: false, extensionBindings: false },
+					safety: { access: "read-only", authentication: "xai-api-key-required", permissionMode: "plan", tools: "read_file,grep,list_dir", deniedTools: "run_terminal_cmd,search_replace,Agent,Bash,Edit,Write,MCPTool", sandbox: "read-only", webSearch: false, subagents: false, config: "temporary-home", updates: "disabled", sessionPersistence: false },
+					handoff: { mode: "fresh" },
+					supervisor: { mode: "unsupported", reason: "Legacy adapter has no supervisor transport." },
+					nonResumableReason: reason,
+				},
+			} },
+		}));
+
+		assert.equal(readWorkflowReceipt(asyncRoot, "workflow-old-grok").entries.grok?.externalAdapter?.adapter.id, "grok-build");
+	});
+
 	it("builds one metadata-only entry per workflow child", () => {
 		const children = Array.from({ length: 1_000 }, (_, index) => child(`child-${index}`));
 		const receipt = buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "complete", children, createdAt: 10 });
@@ -57,11 +142,173 @@ describe("workflow receipts", () => {
 		assert.ok(serialized.length < 400_000, `receipt metadata unexpectedly large: ${serialized.length}`);
 	});
 
+	it("persists structured partial outcomes for workflows and children", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-budget");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		const terminalOutcome = { state: "partial" as const, reason: "budget_exhausted" as const };
+		writeWorkflowReceipt(asyncDir, buildWorkflowReceipt({
+			workflowRunId: "workflow-budget",
+			state: "failed",
+			children: [child("first"), child("second", { ok: false, terminalOutcome })],
+			terminalOutcome,
+			createdAt: 10,
+		}));
+		const receipt = readWorkflowReceipt(asyncRoot, "workflow-budget");
+
+		assert.deepEqual(receipt.terminalOutcome, terminalOutcome);
+		assert.deepEqual(receipt.entries.second?.terminalOutcome, terminalOutcome);
+		assert.equal(receipt.entries.first?.terminalOutcome, undefined);
+	});
+
+	it("persists a bounded terminal workflow-child summary without payload data", () => {
+		const trace = Array.from({ length: 64 }, (_, index) => ({ operation: "run" as const, key: `child-${index}`, state: "started" as const }));
+		const started = performance.now();
+		let summary = workflowChildSummary({ parentToolCallId: "tool-call", workflowRunId: "workflow-1", workflowState: "failed", inventoryComplete: true, trace });
+		for (let index = 0; index < 999; index += 1) summary = workflowChildSummary({ parentToolCallId: "tool-call", workflowRunId: "workflow-1", workflowState: "failed", inventoryComplete: true, trace });
+		const elapsedMs = performance.now() - started;
+		assert.equal(summary.children.length, 64);
+		assert.equal(summary.children[0]?.childId, "child-0");
+		assert.equal(summary.children[0]?.state, "failed");
+		const serialized = JSON.stringify(summary);
+		assert.ok(Buffer.byteLength(serialized) < 8_000, `max-fanout summary too large: ${Buffer.byteLength(serialized)}`);
+		assert.ok(elapsedMs < 500, `1,000 max-fanout projections took ${elapsedMs.toFixed(1)}ms`);
+		assert.doesNotMatch(serialized, /task|prompt|output|artifact|transcript|secret/);
+
+		const receipt = buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "failed", children: [], workflowChildren: summary, createdAt: 10 });
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-1");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		writeWorkflowReceipt(asyncDir, receipt);
+		assert.deepEqual(readWorkflowReceipt(asyncRoot, "workflow-1").workflowChildren, summary);
+	});
+
+	it("round-trips long parent tool-call ids while rejecting ids over the summary bound", () => {
+		const parentToolCallId = `call_${"x".repeat(500)}`;
+		const summary = workflowChildSummary({ parentToolCallId, workflowRunId: "workflow-long-tool-call", workflowState: "completed", inventoryComplete: true });
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-long-tool-call");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		writeWorkflowReceipt(asyncDir, buildWorkflowReceipt({ workflowRunId: "workflow-long-tool-call", state: "complete", children: [], workflowChildren: summary, createdAt: 10 }));
+		assert.equal(readWorkflowReceipt(asyncRoot, "workflow-long-tool-call").workflowChildren?.parentToolCallId, parentToolCallId);
+
+		const overBoundParentToolCallId = `call_${"x".repeat(4_091)}`;
+		assert.equal(workflowChildSummary({ parentToolCallId: overBoundParentToolCallId, workflowRunId: "workflow-long-tool-call", workflowState: "completed", inventoryComplete: true }).parentToolCallId, overBoundParentToolCallId);
+		assert.throws(() => workflowChildSummary({ parentToolCallId: `${overBoundParentToolCallId}x`, workflowRunId: "workflow-long-tool-call", workflowState: "completed", inventoryComplete: true }), /at most 4096 UTF-8 bytes/);
+		assert.throws(() => parseWorkflowChildSummary({ ...summary, parentToolCallId: `${overBoundParentToolCallId}x` }), /at most 4096 UTF-8 bytes/);
+	});
+
+	it("uses workflow keys when flattened child indexes collide", () => {
+		const summary = workflowChildSummary({
+			parentToolCallId: "tool-call",
+			workflowRunId: "workflow-1",
+			workflowState: "completed",
+			inventoryComplete: true,
+			children: [
+				child("review", { results: [{ index: 0, model: "provider/reviewer", thinking: "high" }] }),
+				child("tests", { results: [{ index: 0, model: "provider/tester", thinking: "low" }] }),
+			],
+		});
+
+		assert.deepEqual(summary.children.map(({ childId, model }) => ({ childId, model })), [
+			{ childId: "review", model: "provider/reviewer" },
+			{ childId: "tests", model: "provider/tester" },
+		]);
+	});
+
+	it("rejects a summary bound to a different workflow", () => {
+		const summary = workflowChildSummary({ parentToolCallId: "tool", workflowRunId: "other", workflowState: "completed", inventoryComplete: true });
+		assert.throws(() => buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "complete", children: [], workflowChildren: summary }), /does not match its receipt/);
+	});
+
+	it("round-trips bounded lane metadata and rejects mismatched receipt identity", () => {
+		const lane = { version: 1 as const, key: "advisor", mode: "review" as const, sourceRef: "owner/repo#1621", claims: ["src/shared/types.ts"], outputPaths: ["reports/advisor.md"] };
+		const receipt = buildWorkflowReceipt({ workflowRunId: "workflow-lane", state: "complete", children: [child("advisor", { lane })], createdAt: 10 });
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-lane");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		writeWorkflowReceipt(asyncDir, receipt);
+		assert.deepEqual(readWorkflowReceipt(asyncRoot, "workflow-lane").entries.advisor?.lane, lane);
+		assert.throws(() => buildWorkflowReceipt({ workflowRunId: "workflow-lane", state: "complete", children: [child("advisor", { lane: { ...lane, key: "other" } })] }), /does not match workflow key/);
+
+		const receiptPath = workflowReceiptPath(asyncRoot, "workflow-lane");
+		const malformed = JSON.parse(fs.readFileSync(receiptPath, "utf-8")) as { entries: { advisor: { lane: { key: string } } } };
+		malformed.entries.advisor.lane.key = "other";
+		fs.writeFileSync(receiptPath, JSON.stringify(malformed), "utf-8");
+		assert.throws(() => readWorkflowReceipt(asyncRoot, "workflow-lane"), /does not match workflow key/);
+	});
+
+	it("rejects non-string workflow-child summary identifiers", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-1");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		writeWorkflowReceipt(asyncDir, {
+			...buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "complete", children: [] }),
+			workflowChildren: { version: 1, parentToolCallId: 123, workflowRunId: true, inventoryComplete: true, workflowState: "completed", children: [] } as never,
+		});
+
+		assert.throws(() => readWorkflowReceipt(asyncRoot, "workflow-1"), /workflowChildren\.parentToolCallId is invalid/);
+	});
+
+	it("adds bounded external adapter metadata without raw output or handoff content", () => {
+		const runner = resolveExternalCliRunnerStatus({ command: "review-cli" });
+		const externalAdapter = externalCliReceiptMetadata({
+			runner,
+			externalProcess: { startedAt: 1, stdoutPath: "/tmp/stdout.log", stderrPath: "/tmp/stderr.log" },
+			outputReference: "/tmp/final.md",
+		});
+		const receipt = buildWorkflowReceipt({
+			workflowRunId: "workflow-external",
+			state: "complete",
+			children: [child("advisor", { resumability: { state: "not-resumable", reason: externalAdapter.nonResumableReason }, externalAdapter })],
+		});
+		const serialized = JSON.stringify(receipt);
+
+		assert.equal(receipt.entries.advisor?.externalAdapter?.adapter.id, "external-cli");
+		assert.equal(receipt.entries.advisor?.externalAdapter?.capabilities.stop, true);
+		assert.equal(receipt.entries.advisor?.externalAdapter?.capabilities.supervisor, "unsupported");
+		assert.equal(receipt.entries.advisor?.externalAdapter?.handoff.mode, "fresh");
+		assert.match(receipt.entries.advisor?.resumability.state === "not-resumable" ? receipt.entries.advisor.resumability.reason : "", /no durable external session identity/);
+		assert.doesNotMatch(serialized, /artifactPaths|rawOutput|handoffText|contact_supervisor/);
+		assert.ok(Buffer.byteLength(serialized) < 2_000, `external receipt metadata unexpectedly large: ${Buffer.byteLength(serialized)}`);
+	});
+
+	it("fails closed for malformed external adapter receipt metadata", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-external-bad");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		const runner = resolveExternalCliRunnerStatus({ command: "review-cli" });
+		const externalAdapter = externalCliReceiptMetadata({ runner });
+		fs.writeFileSync(path.join(asyncDir, "workflow-receipt.json"), JSON.stringify({
+			version: 1,
+			workflowRunId: "workflow-external-bad",
+			state: "complete",
+			createdAt: 10,
+			entries: {
+				advisor: {
+					key: "advisor",
+					latestRunId: "run-advisor",
+					resumability: { state: "not-resumable", reason: externalAdapter.nonResumableReason },
+					continuation: { runIds: ["run-advisor"] },
+					externalAdapter: { ...externalAdapter, nonResumableReason: "" },
+				},
+			},
+		}));
+
+		assert.throws(() => readWorkflowReceipt(asyncRoot, "workflow-external-bad"), /externalAdapter\.nonResumableReason is missing/);
+		const badRaw = JSON.parse(fs.readFileSync(path.join(asyncDir, "workflow-receipt.json"), "utf-8"));
+		badRaw.entries.advisor.externalAdapter = { ...externalAdapter, rawOutput: "do not persist" };
+		fs.writeFileSync(path.join(asyncDir, "workflow-receipt.json"), JSON.stringify(badRaw));
+		assert.throws(() => readWorkflowReceipt(asyncRoot, "workflow-external-bad"), /externalAdapter has unsupported fields: rawOutput/);
+	});
+
 	it("writes and resolves one exact terminal receipt", () => {
 		const asyncRoot = tempRoot();
 		const asyncDir = path.join(asyncRoot, "workflow-1");
 		fs.mkdirSync(asyncDir, { recursive: true });
 		const receipt = buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "complete", children: [child("advisor")] });
+		receipt.workflowResolution = "settled-awaiting-resume";
+		receipt.recovery = [{ key: "advisor", call: "runs.run", resume: { workflowRunId: "workflow-1", key: "advisor", latest: true }, taskRequired: true }];
 		assert.equal(writeWorkflowReceipt(asyncDir, receipt), workflowReceiptPath(asyncRoot, "workflow-1"));
 		assert.deepEqual(readWorkflowReceipt(asyncRoot, "workflow-1"), receipt);
 		let validations = 0;
@@ -75,6 +322,23 @@ describe("workflow receipts", () => {
 		});
 		assert.equal(runId, "run-advisor");
 		assert.equal(validations, 1);
+		const invalid = { ...receipt, recovery: [{ ...receipt.recovery[0], resume: { workflowRunId: "other", key: "advisor", latest: true } }] };
+		fs.writeFileSync(workflowReceiptPath(asyncRoot, "workflow-1"), JSON.stringify(invalid));
+		assert.throws(() => readWorkflowReceipt(asyncRoot, "workflow-1"), /recovery\[0\] does not identify a resumable entry/);
+	});
+
+	it("explains a missing receipt when workflow status or events remain visible", () => {
+		const asyncRoot = tempRoot();
+		const workflowRunId = "workflow-active";
+		const asyncDir = path.join(asyncRoot, workflowRunId);
+		fs.mkdirSync(asyncDir, { recursive: true });
+		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: workflowRunId, state: "running" }));
+		fs.writeFileSync(path.join(asyncDir, "events.jsonl"), `${JSON.stringify({ type: "subagent.workflow.child.completed", runId: workflowRunId, childRunId: "run-advisor" })}\n`);
+
+		assert.throws(
+			() => resolveWorkflowReceiptResume({ reference: { workflowRunId, key: "advisor", latest: true }, asyncDirRoot: asyncRoot }),
+			/Workflow receipt 'workflow-active' is not available because the workflow may still be active or terminal receipt writing failed\. Use direct child run IDs from status\/events for direct resume after the normal retained-child checks\./,
+		);
 	});
 
 	it("fails closed for missing, non-resumable, and stale receipt references", () => {
@@ -110,4 +374,58 @@ describe("workflow receipts", () => {
 			/requires latest: true/,
 		);
 	});
+
+	it("refuses keyed resume for a one-shot external CLI with its adapter reason", () => {
+		const asyncRoot = tempRoot();
+		const asyncDir = path.join(asyncRoot, "workflow-external");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		const runner = resolveExternalCliRunnerStatus({ command: "review-cli" });
+		const externalAdapter = externalCliReceiptMetadata({ runner });
+		writeWorkflowReceipt(asyncDir, buildWorkflowReceipt({
+			workflowRunId: "workflow-external",
+			state: "complete",
+			children: [child("advisor", { externalAdapter, resumability: { state: "not-resumable", reason: externalAdapter.nonResumableReason } })],
+		}));
+
+		assert.throws(
+			() => resolveWorkflowReceiptResume({ reference: { workflowRunId: "workflow-external", key: "advisor", latest: true }, asyncDirRoot: asyncRoot }),
+			/not resumable: The one-shot stdin adapter has no durable external session identity/,
+		);
+	});
+});
+
+describe("workflow child session names", () => {
+	it("persists a bounded child session name from async status", () => {
+		const summary = workflowChildSummary({
+			parentToolCallId: "tool-call",
+			workflowRunId: "workflow-1",
+			workflowState: "completed",
+			inventoryComplete: true,
+			steps: [{
+				agent: "reviewer",
+				sessionName: "reviewer: Inspect the changed auth middleware",
+				workflowKey: "review",
+				status: "complete",
+			}],
+		});
+		assert.equal(summary.children[0]?.sessionName, "reviewer: Inspect the changed auth middleware");
+	});
+
+	it("rejects unbounded session names in persisted workflow summaries", () => {
+		const root = tempRoot();
+		const asyncDir = path.join(root, "workflow-1");
+		fs.mkdirSync(asyncDir, { recursive: true });
+		writeWorkflowReceipt(asyncDir, {
+			...buildWorkflowReceipt({ workflowRunId: "workflow-1", state: "complete", children: [] }),
+			workflowChildren: {
+				version: 1,
+				parentToolCallId: "tool",
+				workflowRunId: "workflow-1",
+				inventoryComplete: true,
+				workflowState: "completed",
+				children: [{ childId: "review", state: "completed", sessionName: "x".repeat(257) }],
+			},
+		});
+		assert.throws(() => readWorkflowReceipt(root, "workflow-1"), /sessionName is invalid/);
+	});
 });