@seed-ship/mcp-ui-solid 6.4.0 → 6.6.0

package/src/components/StreamingUIRenderer.tsx

@@ -1,8 +1,22 @@
 /**
- * StreamingUIRenderer Component - Phase 2
+ * StreamingUIRenderer Component
  *
- * Renders streaming dashboard components with skeleton states and progress indicators.
- * Uses the useStreamingUI hook for SSE connection and state management.
+ * Renders streaming dashboard components with skeleton states and progress
+ * indicators. Uses the `useStreamingUI` hook for SSE connection and state.
+ *
+ * ## Rendering parity (v6.6.0 — closes Gap 1 of ROADMAP-opendata-macro-mcpui)
+ *
+ * Each component received over SSE is delegated to the real
+ * `<UIResourceRenderer>`. Streamed `table` / `chart` / `map` / `action-group`
+ * therefore render with the SAME fidelity as a static layout — no more
+ * simplified "type + title" placeholder. Validation, telemetry, the error
+ * boundary and `errorMode` all come from `<UIResourceRenderer>`, so the two
+ * paths cannot drift.
+ *
+ * Delegation is a one-way value import (`UIResourceRenderer` never imports
+ * this file — no cycle). The streamed component's `position` is normalized
+ * to full-width before delegation : this component owns the 12-column grid,
+ * `<UIResourceRenderer>` only owns the component's own rendering.
  *
  * Features:
  * - Skeleton loading states while components stream
@@ -21,14 +35,11 @@
  * ```
  */
 
-import { Show, For, createSignal, onMount, onCleanup } from 'solid-js'
+import { Show, For, createSignal, onMount } from 'solid-js'
 import { useStreamingUI, type UseStreamingUIOptions } from '../hooks/useStreamingUI'
 import type { UIComponent, RendererError } from '../types'
-import { validateComponent } from '../services/validation'
-import { GenerativeUIErrorBoundary } from './GenerativeUIErrorBoundary'
-import { markRenderStart, markRenderEnd, PERF_PREFIX } from '../utils/perf'
-import { useTelemetry } from '../context/MCPUITelemetryContext'
-import type { ValidationErrorMode } from './UIResourceRenderer'
+import { UIResourceRenderer, type ValidationErrorMode } from './UIResourceRenderer'
+import { useMCPUIStrings } from '../context/MCPUIStringsContext'
 
 export interface StreamingUIRendererProps extends UseStreamingUIOptions {
   class?: string
@@ -38,164 +49,27 @@ export interface StreamingUIRendererProps extends UseStreamingUIOptions {
   /**
    * How to react when a streamed component fails `validateComponent()`
    * (v5.4.0). Defaults to `'block'` (full red error card — pre-v5.4.0
-   * behavior). See `ValidationErrorMode` in `UIResourceRenderer`.
+   * behavior). Forwarded to the delegated `<UIResourceRenderer>`.
    */
   errorMode?: ValidationErrorMode
+  /**
+   * Visibility behavior of the inline expand button on streamed components
+   * wrapped in `<ExpandableWrapper>` (v6.6.0 — parity with the static
+   * `<UIResourceRenderer toolbarVariant>` prop). Forwarded as-is.
+   */
+  toolbarVariant?: 'hover' | 'always-visible'
 }
 
 /**
- * Component Renderer - Inline lightweight version
- * (Full implementation in UIResourceRenderer)
+ * The 12-column placement of a streamed component is owned by this
+ * component's outer grid (the cell `<div>` below). Delegating the component
+ * verbatim to `<UIResourceRenderer>` would re-apply that placement inside a
+ * fresh nested 12-column grid and visually misplace it. We hand
+ * `<UIResourceRenderer>` a full-width copy so it only renders the component,
+ * not a competing layout.
  */
-function StreamingComponentRenderer(props: {
-  component: UIComponent
-  onError?: (error: RendererError) => void
-  errorMode?: ValidationErrorMode
-}) {
-  // Performance marks (v5.4.0) — see utils/perf.ts
-  markRenderStart(props.component.id)
-
-  // Telemetry sink (B.5 — v5.6.0). Same wiring as ComponentRenderer in
-  // UIResourceRenderer.tsx — null when no Provider, no-op everywhere then.
-  const telemetry = useTelemetry()
-
-  onMount(() => {
-    markRenderEnd(props.component.id)
-    if (telemetry) {
-      const ts = Date.now()
-      telemetry.dispatch({
-        type: 'component:mounted',
-        id: props.component.id,
-        componentType: props.component.type,
-        ts,
-      })
-      if (typeof performance !== 'undefined' && typeof performance.getEntriesByName === 'function') {
-        const entries = performance.getEntriesByName(`${PERF_PREFIX}${props.component.id}:render`, 'measure')
-        const last = entries[entries.length - 1]
-        if (last) {
-          telemetry.dispatch({
-            type: 'component:rendered',
-            id: props.component.id,
-            componentType: props.component.type,
-            durationMs: last.duration,
-            ts,
-          })
-        }
-      }
-    }
-  })
-
-  onCleanup(() => {
-    if (telemetry) {
-      telemetry.dispatch({
-        type: 'component:unmounted',
-        id: props.component.id,
-        componentType: props.component.type,
-        ts: Date.now(),
-      })
-    }
-  })
-
-  // Validate component before rendering
-  const validation = validateComponent(props.component)
-  if (!validation.valid) {
-    props.onError?.({
-      type: 'validation',
-      message: 'Component validation failed',
-      componentId: props.component.id,
-      details: validation.errors,
-    })
-
-    if (telemetry) {
-      telemetry.dispatch({
-        type: 'validation:failed',
-        id: props.component.id,
-        componentType: props.component.type,
-        errorCount: validation.errors?.length ?? 0,
-        firstErrorCode: validation.errors?.[0]?.code ?? null,
-        ts: Date.now(),
-      })
-    }
-
-    const mode: ValidationErrorMode = props.errorMode ?? 'block'
-    const firstError = validation.errors?.[0]?.message || 'Unknown validation error'
-
-    if (mode === 'silent') {
-      return null
-    }
-
-    if (mode === 'inline-warn') {
-      return (
-        <div
-          class="inline-flex items-center gap-1.5 px-2 py-1 rounded-md bg-yellow-50 dark:bg-yellow-900/20 border border-yellow-200 dark:border-yellow-800 text-xs text-yellow-800 dark:text-yellow-200"
-          role="alert"
-          aria-label="Component validation warning"
-          title={firstError}
-        >
-          <svg
-            xmlns="http://www.w3.org/2000/svg"
-            class="w-3.5 h-3.5"
-            viewBox="0 0 24 24"
-            fill="none"
-            stroke="currentColor"
-            stroke-width="2"
-            stroke-linecap="round"
-            stroke-linejoin="round"
-            aria-hidden="true"
-          >
-            <path d="M10.29 3.86 1.82 18a2 2 0 0 0 1.71 3h16.94a2 2 0 0 0 1.71-3L13.71 3.86a2 2 0 0 0-3.42 0z" />
-            <line x1="12" y1="9" x2="12" y2="13" />
-            <line x1="12" y1="17" x2="12.01" y2="17" />
-          </svg>
-          <span>Invalid {props.component.type}</span>
-        </div>
-      )
-    }
-
-    return (
-      <div class="w-full bg-error-subtle border border-border-error rounded-lg p-4">
-        <p class="text-sm font-medium text-error-primary">Validation Error</p>
-        <p class="text-xs text-text-secondary mt-1">
-          {firstError}
-        </p>
-      </div>
-    )
-  }
-
-  // Simplified renderer - just show component type and title
-  // Full rendering logic in UIResourceRenderer
-  const params = props.component.params as any
-
-  return (
-    <GenerativeUIErrorBoundary
-      componentId={props.component.id}
-      componentType={props.component.type}
-      onError={props.onError}
-      allowRetry={false}
-    >
-      <div class="w-full bg-surface-secondary border border-border-subtle rounded-lg p-4">
-        <div class="flex items-center gap-2 mb-2">
-          <span class="text-xs font-medium text-text-tertiary uppercase">
-            {props.component.type}
-          </span>
-        </div>
-        <Show when={params?.title}>
-          <h3 class="text-sm font-semibold text-text-primary">{params.title}</h3>
-        </Show>
-        <Show when={props.component.type === 'metric' && params?.value}>
-          <div class="mt-2">
-            <p class="text-2xl font-semibold text-text-primary">{params.value}</p>
-            <Show when={params.unit}>
-              <span class="text-sm text-text-secondary">{params.unit}</span>
-            </Show>
-          </div>
-        </Show>
-        <div class="mt-3 text-xs text-text-tertiary">
-          Component ID: {props.component.id.slice(0, 8)}...
-        </div>
-      </div>
-    </GenerativeUIErrorBoundary>
-  )
+function asFullWidth(component: UIComponent): UIComponent {
+  return { ...component, position: { colStart: 1, colSpan: 12 } }
 }
 
 export function StreamingUIRenderer(props: StreamingUIRendererProps) {
@@ -210,6 +84,7 @@ export function StreamingUIRenderer(props: StreamingUIRendererProps) {
       onComponentReceived: props.onComponentReceived,
     })
 
+  const strings = useMCPUIStrings()
   const [animatingComponents, setAnimatingComponents] = createSignal<Set<string>>(new Set())
 
   // Track new components for animation
@@ -292,7 +167,7 @@ export function StreamingUIRenderer(props: StreamingUIRendererProps) {
               class="mt-3 rounded-md bg-error-primary px-3 py-1.5 text-sm font-medium text-white hover:bg-error-hover"
               onClick={() => startStreaming()}
             >
-              Retry
+              {strings.retry}
             </button>
           </Show>
         </div>
@@ -300,7 +175,7 @@ export function StreamingUIRenderer(props: StreamingUIRendererProps) {
 
       {/* Components Grid */}
       <div class="grid grid-cols-12 gap-4">
-        {/* Render received components */}
+        {/* Render received components — delegated to the real UIResourceRenderer */}
         <For each={components()}>
           {(component) => {
             // Trigger animation on mount (SSR-safe, no 'use' directive needed)
@@ -314,10 +189,11 @@ export function StreamingUIRenderer(props: StreamingUIRendererProps) {
                 `}
                 style={`grid-column-start: ${component.position.colStart}; grid-column-end: ${component.position.colStart + component.position.colSpan}`}
               >
-                <StreamingComponentRenderer
-                  component={component}
-                  onError={props.onRenderError}
+                <UIResourceRenderer
+                  content={asFullWidth(component)}
                   errorMode={props.errorMode}
+                  onError={props.onRenderError}
+                  toolbarVariant={props.toolbarVariant}
                 />
               </div>
             )

package/src/components/UIResourceRenderer.identity.test.tsx

@@ -0,0 +1,161 @@
+/**
+ * v6.5.0 — Identity stability + opt-in observability for <UIResourceRenderer>.
+ *
+ * Coverage targets :
+ *   1. Layout content gets `data-mcp-ui-layout-id` from layout.id
+ *   2. Layout content without id falls back to a content hash
+ *   3. Single-component content gets `data-mcp-ui-component-id` (no layout id)
+ *   4. Each rendered child carries `data-mcp-ui-component-id`
+ *   5. `onMountDuplicate` callback fires on the 2nd concurrent mount
+ *   6. Module-level reporter (`setDuplicateMountReporter`) fires on duplicate
+ *   7. Single mount fires no duplicate notification
+ *   8. Cleanup on unmount allows the same key to be re-mounted without warn
+ */
+
+import { describe, it, expect, beforeEach, vi } from 'vitest'
+import { render, cleanup } from '@solidjs/testing-library'
+import { UIResourceRenderer } from './UIResourceRenderer'
+import {
+  setDuplicateMountReporter,
+  _resetRegistry,
+  _getMountCount,
+} from '../utils/duplicate-mount-registry'
+import { getUiResourceStableKey } from '../utils/stable-key'
+
+const SIMPLE_TEXT_COMPONENT = {
+  id: 'text-comp-1',
+  type: 'text' as const,
+  position: { colStart: 1, colSpan: 12 },
+  params: { content: 'Hello' },
+}
+
+const SIMPLE_LAYOUT = {
+  id: 'layout-1',
+  components: [SIMPLE_TEXT_COMPONENT],
+  grid: { columns: 12, gap: '1rem' },
+}
+
+describe('UIResourceRenderer identity (v6.5.0)', () => {
+  beforeEach(() => {
+    cleanup()
+    _resetRegistry()
+  })
+
+  it('layout content emits data-mcp-ui-layout-id from layout.id', () => {
+    const { container } = render(() => <UIResourceRenderer content={SIMPLE_LAYOUT} />)
+    const wrapper = container.querySelector('[data-mcp-ui-layout-id="layout-1"]')
+    expect(wrapper).toBeTruthy()
+  })
+
+  it('layout without id falls back to a content hash', () => {
+    const bareLayout = {
+      components: [SIMPLE_TEXT_COMPONENT],
+      grid: { columns: 12, gap: '1rem' },
+    } as any
+    const expectedKey = getUiResourceStableKey(bareLayout)
+    const { container } = render(() => <UIResourceRenderer content={bareLayout} />)
+    const wrapper = container.querySelector(`[data-mcp-ui-layout-id="${expectedKey}"]`)
+    expect(wrapper).toBeTruthy()
+    // Hash form (FNV-1a base36) is 7 chars
+    expect(expectedKey).toMatch(/^[a-z0-9]{7}$/)
+  })
+
+  it('single-component content emits data-mcp-ui-component-id (no layout id)', () => {
+    const { container } = render(() => <UIResourceRenderer content={SIMPLE_TEXT_COMPONENT} />)
+    expect(container.querySelector('[data-mcp-ui-layout-id]')).toBeNull()
+    const wrappers = container.querySelectorAll('[data-mcp-ui-component-id="text-comp-1"]')
+    // Outer wrapper + inner per-component wrapper both carry the id
+    expect(wrappers.length).toBeGreaterThanOrEqual(1)
+  })
+
+  it('each child component wrapper inside a layout carries data-mcp-ui-component-id', () => {
+    const layout = {
+      id: 'multi',
+      components: [
+        { id: 'comp-a', type: 'text', position: { colStart: 1, colSpan: 6 }, params: { content: 'A' } },
+        { id: 'comp-b', type: 'text', position: { colStart: 7, colSpan: 6 }, params: { content: 'B' } },
+      ],
+      grid: { columns: 12, gap: '1rem' },
+    } as any
+    const { container } = render(() => <UIResourceRenderer content={layout} />)
+    expect(container.querySelector('[data-mcp-ui-component-id="comp-a"]')).toBeTruthy()
+    expect(container.querySelector('[data-mcp-ui-component-id="comp-b"]')).toBeTruthy()
+  })
+
+  it('fires onMountDuplicate on the 2nd concurrent mount of the same key', () => {
+    const onDup = vi.fn()
+    render(() => (
+      <>
+        <UIResourceRenderer content={SIMPLE_LAYOUT} onMountDuplicate={onDup} />
+        <UIResourceRenderer content={SIMPLE_LAYOUT} onMountDuplicate={onDup} />
+      </>
+    ))
+    // Only the 2nd mount triggers the callback (count crosses 2)
+    expect(onDup).toHaveBeenCalledTimes(1)
+    expect(onDup).toHaveBeenCalledWith(
+      expect.objectContaining({ key: 'layout-1', count: 2 })
+    )
+  })
+
+  it('does NOT fire onMountDuplicate on a single mount', () => {
+    const onDup = vi.fn()
+    render(() => <UIResourceRenderer content={SIMPLE_LAYOUT} onMountDuplicate={onDup} />)
+    expect(onDup).not.toHaveBeenCalled()
+  })
+
+  it('module-level setDuplicateMountReporter fires on the 2nd mount', () => {
+    const reporter = vi.fn()
+    setDuplicateMountReporter(reporter)
+    render(() => (
+      <>
+        <UIResourceRenderer content={SIMPLE_LAYOUT} />
+        <UIResourceRenderer content={SIMPLE_LAYOUT} />
+      </>
+    ))
+    expect(reporter).toHaveBeenCalledTimes(1)
+    expect(reporter).toHaveBeenCalledWith(
+      expect.objectContaining({ key: 'layout-1', count: 2 })
+    )
+  })
+
+  it('mounts unique-key payloads independently (no false positives)', () => {
+    const onDup = vi.fn()
+    const reporter = vi.fn()
+    setDuplicateMountReporter(reporter)
+    const a = { ...SIMPLE_LAYOUT, id: 'layout-A' }
+    const b = { ...SIMPLE_LAYOUT, id: 'layout-B' }
+    render(() => (
+      <>
+        <UIResourceRenderer content={a} onMountDuplicate={onDup} />
+        <UIResourceRenderer content={b} onMountDuplicate={onDup} />
+      </>
+    ))
+    expect(onDup).not.toHaveBeenCalled()
+    expect(reporter).not.toHaveBeenCalled()
+  })
+
+  it('cleanup unregisters the mount so the registry never leaks', () => {
+    const { unmount } = render(() => <UIResourceRenderer content={SIMPLE_LAYOUT} />)
+    expect(_getMountCount('layout-1')).toBe(1)
+    unmount()
+    expect(_getMountCount('layout-1')).toBe(0)
+  })
+
+  it('debugDuplicateMounts prop forces a console.warn even when global debug off', () => {
+    const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
+    try {
+      render(() => (
+        <>
+          <UIResourceRenderer content={SIMPLE_LAYOUT} debugDuplicateMounts />
+          <UIResourceRenderer content={SIMPLE_LAYOUT} debugDuplicateMounts />
+        </>
+      ))
+      expect(warnSpy).toHaveBeenCalledWith(
+        '[mcp-ui] duplicate UIResourceRenderer mount',
+        expect.objectContaining({ key: 'layout-1', count: 2 })
+      )
+    } finally {
+      warnSpy.mockRestore()
+    }
+  })
+})

package/src/components/UIResourceRenderer.tsx

@@ -10,6 +10,14 @@ import type { UIComponent, UILayout, RendererError, TableVirtualizeOptions } fro
 import { validateComponent, DEFAULT_RESOURCE_LIMITS, getIframeSandbox } from '../services/validation'
 import { GenerativeUIErrorBoundary } from './GenerativeUIErrorBoundary'
 import { markRenderStart, markRenderEnd, PERF_PREFIX } from '../utils/perf'
+import { isDebugEnabled } from '../utils/logger'
+import { getUiResourceStableKey } from '../utils/stable-key'
+import {
+  _registerMount,
+  _unregisterMount,
+  getDuplicateMountReporter,
+  type DuplicateMountInfo,
+} from '../utils/duplicate-mount-registry'
 import { useTelemetry } from '../context/MCPUITelemetryContext'
 
 /**
@@ -135,6 +143,27 @@ export interface UIResourceRendererProps {
    * graph, map, video, carousel, image-gallery, code.
    */
   toolbarVariant?: 'hover' | 'always-visible'
+
+  /**
+   * Per-instance hook fired when this renderer mounts a content key that
+   * is already mounted elsewhere in the document (v6.5.0 — closes Demande 2
+   * of `BRIEF-MCPUI-2026-05-10.md`).
+   *
+   * The key comes from `getUiResourceStableKey(content)` — `content.id` if
+   * provided, else a content hash. The reporter fires every time the
+   * concurrent mount count crosses 2+ ; consumers decide what to do
+   * (`console.warn`, telemetry beacon, debug overlay, …). The renderer
+   * never deduplicates visually on its own.
+   */
+  onMountDuplicate?: (info: DuplicateMountInfo) => void
+
+  /**
+   * When `true`, log duplicate mounts to `console.warn` from this instance
+   * even when the global `isDebugEnabled()` flag is off. Use to opt-in to
+   * console noise on a single suspect surface without flipping the global
+   * debug switch (v6.5.0).
+   */
+  debugDuplicateMounts?: boolean
 }
 
 /**
@@ -1766,6 +1795,30 @@ export const UIResourceRenderer: Component<UIResourceRendererProps> = (props) =>
 
   const layoutData = layout()
 
+  // ── Identity + duplicate-mount detection (v6.5.0) ─────────────
+  // `isLayoutContent` distinguishes a real composite/layout payload from
+  // the synthetic single-component wrapping above. Drives whether the
+  // outer wrapper carries `data-mcp-ui-layout-id` or `data-mcp-ui-component-id`.
+  const isLayoutContent =
+    !('type' in props.content) || (props.content as { type?: string }).type === 'composite'
+  const outerKey = createMemo(() => getUiResourceStableKey(props.content))
+
+  onMount(() => {
+    const key = outerKey()
+    const info = _registerMount(key)
+    if (info.count > 1) {
+      props.onMountDuplicate?.(info)
+      getDuplicateMountReporter()?.(info)
+      if (isDebugEnabled() || props.debugDuplicateMounts) {
+        // eslint-disable-next-line no-console
+        console.warn('[mcp-ui] duplicate UIResourceRenderer mount', info)
+      }
+    }
+  })
+  onCleanup(() => {
+    _unregisterMount(outerKey())
+  })
+
   // Wrapper function for RenderContext (breaks circular dependency)
   const renderComponent = (component: UIComponent, onError?: (error: RendererError) => void) => (
     <ComponentRenderer component={component} onError={onError} errorMode={props.errorMode} toolbarVariant={props.toolbarVariant} />
@@ -1773,11 +1826,19 @@ export const UIResourceRenderer: Component<UIResourceRendererProps> = (props) =>
 
   return (
     <RenderProvider renderComponent={renderComponent}>
-      <div class={`w-full ${props.class || ''}`}>
+      <div
+        class={`w-full ${props.class || ''}`}
+        {...(isLayoutContent
+          ? { 'data-mcp-ui-layout-id': outerKey() }
+          : { 'data-mcp-ui-component-id': outerKey() })}
+      >
         <div class="grid gap-4" style={gridContainerStyle()}>
           <For each={layoutData.components}>
             {(component) => (
-              <div style={getGridStyleString(component)}>
+              <div
+                style={getGridStyleString(component)}
+                data-mcp-ui-component-id={getUiResourceStableKey(component)}
+              >
                 <ComponentRenderer component={component} onError={props.onError} errorMode={props.errorMode} toolbarVariant={props.toolbarVariant} />
               </div>
             )}

package/src/components/index.ts

@@ -10,6 +10,16 @@ export type { UIResourceRendererProps } from './UIResourceRenderer'
 export { StreamingUIRenderer } from './StreamingUIRenderer'
 export type { StreamingUIRendererProps } from './StreamingUIRenderer'
 
+// Presentation feedback (v6.6.0 — R3, distinct from FeedbackInline)
+export {
+  PresentationFeedback,
+  DEFAULT_PRESENTATION_FEEDBACK_LABELS,
+} from './PresentationFeedback'
+export type {
+  PresentationFeedbackProps,
+  PresentationFeedbackLabels,
+} from './PresentationFeedback'
+
 export { GenerativeUIErrorBoundary } from './GenerativeUIErrorBoundary'
 export type { GenerativeUIErrorBoundaryProps } from './GenerativeUIErrorBoundary'
 

package/src/context/MCPUIStringsContext.test.tsx

@@ -0,0 +1,116 @@
+/**
+ * v6.6.0 — MCPUIStringsProvider (D2 / R4 of ROADMAP-opendata-macro-mcpui).
+ *
+ * Coverage:
+ *   1. Defaults are English, available with no provider mounted
+ *   2. Provider does a partial merge over the EN defaults
+ *   3. FeedbackInline reads chrome strings from the provider
+ *   4. FeedbackInline `positiveAck` / `negativeAck` props still win over the provider
+ *   5. ExpandableWrapper reads the expand-button tooltip from the provider
+ */
+
+import { describe, it, expect, beforeEach } from 'vitest'
+import { render, cleanup, fireEvent } from '@solidjs/testing-library'
+import {
+  MCPUIStringsProvider,
+  useMCPUIStrings,
+  DEFAULT_MCPUI_STRINGS,
+} from './MCPUIStringsContext'
+import { FeedbackInline } from '../components/FeedbackInline'
+import { ExpandableWrapper } from '../components/ExpandableWrapper'
+
+describe('MCPUIStringsContext (v6.6.0)', () => {
+  beforeEach(() => cleanup())
+
+  it('defaults are English', () => {
+    expect(DEFAULT_MCPUI_STRINGS.expand).toBe('Expand')
+    expect(DEFAULT_MCPUI_STRINGS.feedbackUseful).toBe('Useful')
+    expect(DEFAULT_MCPUI_STRINGS.feedbackPositiveAck).toBe('Thanks!')
+    expect(DEFAULT_MCPUI_STRINGS.retry).toBe('Retry')
+  })
+
+  it('useMCPUIStrings returns the EN defaults with no provider mounted', () => {
+    let captured: ReturnType<typeof useMCPUIStrings> | undefined
+    const Probe = () => {
+      captured = useMCPUIStrings()
+      return <span>probe</span>
+    }
+    render(() => <Probe />)
+    expect(captured).toEqual(DEFAULT_MCPUI_STRINGS)
+  })
+
+  it('provider partial-merges over the EN defaults', () => {
+    let captured: ReturnType<typeof useMCPUIStrings> | undefined
+    const Probe = () => {
+      captured = useMCPUIStrings()
+      return <span>probe</span>
+    }
+    render(() => (
+      <MCPUIStringsProvider strings={{ expand: 'Agrandir', feedbackUseful: 'Utile' }}>
+        <Probe />
+      </MCPUIStringsProvider>
+    ))
+    // Overridden keys
+    expect(captured!.expand).toBe('Agrandir')
+    expect(captured!.feedbackUseful).toBe('Utile')
+    // Untouched keys fall back to EN
+    expect(captured!.retry).toBe('Retry')
+    expect(captured!.closeExpandedView).toBe('Close expanded view')
+  })
+
+  it('FeedbackInline reads its ack from the provider (FR override)', () => {
+    const { getByText, container } = render(() => (
+      <MCPUIStringsProvider
+        strings={{ feedbackPositiveAck: 'Merci !', feedbackUseful: 'Utile' }}
+      >
+        <FeedbackInline onSubmit={() => {}} />
+      </MCPUIStringsProvider>
+    ))
+    // Tooltip from provider
+    const upBtn = container.querySelector('[data-feedback-inline-rating="positive"]')
+    expect(upBtn?.getAttribute('title')).toBe('Utile')
+    // Ack from provider after click
+    fireEvent.click(upBtn!)
+    expect(getByText('Merci !')).toBeTruthy()
+  })
+
+  it('FeedbackInline defaults to EN ack when no provider is mounted', () => {
+    const { getByText, container } = render(() => <FeedbackInline onSubmit={() => {}} />)
+    const upBtn = container.querySelector('[data-feedback-inline-rating="positive"]')
+    fireEvent.click(upBtn!)
+    expect(getByText('Thanks!')).toBeTruthy()
+  })
+
+  it('FeedbackInline positiveAck prop still wins over the provider', () => {
+    const { getByText, container } = render(() => (
+      <MCPUIStringsProvider strings={{ feedbackPositiveAck: 'FromProvider' }}>
+        <FeedbackInline onSubmit={() => {}} positiveAck="FromProp" />
+      </MCPUIStringsProvider>
+    ))
+    const upBtn = container.querySelector('[data-feedback-inline-rating="positive"]')
+    fireEvent.click(upBtn!)
+    expect(getByText('FromProp')).toBeTruthy()
+  })
+
+  it('ExpandableWrapper reads the expand-button tooltip from the provider', () => {
+    const { container } = render(() => (
+      <MCPUIStringsProvider strings={{ expand: 'Plein écran' }}>
+        <ExpandableWrapper title="Données">
+          <div>content</div>
+        </ExpandableWrapper>
+      </MCPUIStringsProvider>
+    ))
+    const expandBtn = container.querySelector('button[aria-label="Expand to fullscreen"]')
+    expect(expandBtn?.getAttribute('title')).toBe('Plein écran')
+  })
+
+  it('ExpandableWrapper falls back to EN with no provider', () => {
+    const { container } = render(() => (
+      <ExpandableWrapper title="Data">
+        <div>content</div>
+      </ExpandableWrapper>
+    ))
+    const expandBtn = container.querySelector('button[aria-label="Expand to fullscreen"]')
+    expect(expandBtn?.getAttribute('title')).toBe('Expand')
+  })
+})