@seed-design/react 1.2.6 → 1.2.8

package/src/components/ImageFrame/ImageFrame.tsx

@@ -12,14 +12,19 @@ import {
 } from "@seed-design/css/recipes/image-frame-indicator";
 import { imageFrameReactionButton } from "@seed-design/css/recipes/image-frame-reaction-button";
 import { imageFrameFloater as floaterVars } from "@seed-design/css/vars/component";
+import { mergeProps } from "@seed-design/dom-utils";
 import { Image } from "@seed-design/react-image";
-import { Toggle as TogglePrimitive } from "@seed-design/react-toggle";
+import { Toggle as TogglePrimitive, useToggleContext } from "@seed-design/react-toggle";
 import clsx from "clsx";
 import * as React from "react";
+import { createSlotRecipeContext } from "../../utils/createSlotRecipeContext";
 import { AspectRatio, type AspectRatioProps } from "../AspectRatio/AspectRatio";
 import { Badge, type BadgeProps } from "../Badge/Badge";
 import { Float, type FloatProps } from "../Float/Float";
 import { Icon } from "../Icon/Icon";
+import { InternalIcon } from "../private/Icon";
+
+////////////////////////////////////////////////////////////////////////////////////
 
 export interface ImageFrameProps
   extends Omit<AspectRatioProps, "children">,
@@ -41,10 +46,6 @@ export interface ImageFrameProps
   srcSet?: string;
   onLoad?: React.ReactEventHandler<HTMLImageElement>;
   onError?: React.ReactEventHandler<HTMLImageElement>;
-  /**
-   * Overlay elements to be rendered on top of the image.
-   * Use ImageFrameFloater to position them.
-   */
   children?: React.ReactNode;
 }
 
@@ -52,8 +53,6 @@ export const ImageFrame = React.forwardRef<HTMLDivElement, ImageFrameProps>(
   (
     {
       ratio = 4 / 3,
-      stroke,
-      rounded,
       src,
       alt,
       fallback,
@@ -71,10 +70,14 @@ export const ImageFrame = React.forwardRef<HTMLDivElement, ImageFrameProps>(
     },
     ref,
   ) => {
+    const [variantProps, restProps] = imageFrameRecipe.splitVariantProps(rest);
+    const classNames = imageFrameRecipe(variantProps);
+
     return (
-      <AspectRatio ref={ref} ratio={ratio} className={className} {...rest}>
-        <Image.Root className={imageFrameRecipe({ stroke, rounded })}>
+      <AspectRatio ref={ref} ratio={ratio} className={className} {...restProps}>
+        <Image.Root className={classNames.root}>
           <Image.Content
+            className={classNames.content}
             src={src}
             alt={alt}
             loading={loading}
@@ -86,7 +89,7 @@ export const ImageFrame = React.forwardRef<HTMLDivElement, ImageFrameProps>(
             onLoad={onLoad}
             onError={onError}
           />
-          {fallback && <Image.Fallback>{fallback}</Image.Fallback>}
+          {fallback && <Image.Fallback className={classNames.fallback}>{fallback}</Image.Fallback>}
           {children}
         </Image.Root>
       </AspectRatio>
@@ -175,24 +178,33 @@ ImageFrameIndicator.displayName = "ImageFrameIndicator";
 
 ////////////////////////////////////////////////////////////////////////////////////
 
+const {
+  ClassNamesProvider: ImageFrameReactionButtonClassNamesProvider,
+  useClassNames: useImageFrameReactionButtonClassNames,
+} = createSlotRecipeContext(imageFrameReactionButton);
+
+////////////////////////////////////////////////////////////////////////////////////
+
 const HeartFillPath =
   "M15.5452 10C11.7873 10 9.25 12.9484 9.25 16.6267C9.25 19.8754 11.1219 22.0952 13.1877 23.969C13.7807 24.5069 14.4438 25.0617 15.095 25.6066C15.5434 25.9817 15.9862 26.3522 16.3967 26.7093C17.4501 27.6257 18.4191 28.557 19.1995 29.5994C19.3886 29.8518 19.6856 30.0003 20.001 30C20.3163 29.9997 20.6131 29.8507 20.8016 29.5979C21.5785 28.5562 22.5453 27.6253 23.598 26.7091C24.0105 26.35 24.4568 25.9766 24.9089 25.5984C25.5573 25.0559 26.2176 24.5035 26.807 23.9693C28.8739 22.096 30.75 19.8761 30.75 16.6267C30.75 12.9484 28.2127 10 24.4548 10C22.6365 10 21.1002 11.0545 20 12.4906C18.8998 11.0545 17.3635 10 15.5452 10Z";
 
 const HeartOutlineStrokePath =
   "M15.5452 12C13.0342 12 11.25 13.905 11.25 16.6267C11.25 18.9912 12.5659 20.7048 14.5314 22.4876C15.1157 23.0176 15.7038 23.5087 16.3148 24.019C16.7646 24.3946 17.2269 24.7807 17.7093 25.2003C18.4947 25.8835 19.2814 26.6141 19.9988 27.4215C20.7144 26.614 21.5001 25.8836 22.2849 25.2005C22.7714 24.7771 23.2368 24.3885 23.6895 24.0105C24.2967 23.5035 24.8813 23.0154 25.4639 22.4874C27.4317 20.704 28.75 18.9906 28.75 16.6267C28.75 13.905 26.9658 12 24.4548 12C23.069 12 21.747 12.8325 20.8919 14.5189C20.7215 14.8549 20.3768 15.0667 20 15.0667C19.6233 15.0667 19.2785 14.8549 19.1081 14.5189C18.2531 12.8325 16.931 12 15.5452 12ZM9.25 16.6267C9.25 12.9484 11.7873 10 15.5452 10C17.3146 10 18.8683 10.8364 20 12.2306C21.1317 10.8364 22.6854 10 24.4548 10C28.2127 10 30.75 12.9484 30.75 16.6267C30.75 19.8761 28.8739 22.096 26.807 23.9693C26.2176 24.5035 25.5573 25.0559 24.9089 25.5984C24.4568 25.9766 24.0105 26.35 23.598 26.7091C22.5453 27.6253 21.5785 28.5562 20.8016 29.5979C20.6131 29.8507 20.3163 29.9997 20.001 30C19.6856 30.0003 19.3886 29.8518 19.1995 29.5994C18.4191 28.557 17.4501 27.6257 16.3967 26.7093C15.9862 26.3522 15.5434 25.9817 15.095 25.6066C14.4438 25.0617 13.7807 24.5069 13.1877 23.969C11.1219 22.0952 9.25 19.8754 9.25 16.6267Z";
 
-const UnselectedHeartIcon = () => (
-  <svg viewBox="8 9 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" aria-hidden="true">
-    <path d={HeartFillPath} fill="black" fillOpacity="0.063" />
-    <path fillRule="evenodd" clipRule="evenodd" d={HeartOutlineStrokePath} fill="white" />
-  </svg>
-);
-
-const SelectedHeartIcon = () => {
+const HeartFillSvg = (props: React.SVGAttributes<SVGSVGElement>) => {
   const id = React.useId();
   const gradientId = `seed-heart-gradient${id.replace(/:/g, "")}`;
+
   return (
-    <svg viewBox="8 9 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" aria-hidden="true">
+    <svg
+      width="100%"
+      height="100%"
+      viewBox="8 9 24 24"
+      fill="none"
+      xmlns="http://www.w3.org/2000/svg"
+      aria-hidden="true"
+      {...props}
+    >
       <path d={HeartFillPath} fill={`url(#${gradientId})`} />
       <defs>
         <linearGradient
@@ -211,22 +223,45 @@ const SelectedHeartIcon = () => {
   );
 };
 
+const HeartLineSvg = (props: React.SVGAttributes<SVGSVGElement>) => (
+  <svg
+    width="100%"
+    height="100%"
+    viewBox="8 9 24 24"
+    fill="none"
+    xmlns="http://www.w3.org/2000/svg"
+    aria-hidden="true"
+    {...props}
+  >
+    <path fillRule="evenodd" clipRule="evenodd" d={HeartOutlineStrokePath} fill="currentColor" />
+  </svg>
+);
+
 export interface ImageFrameReactionButtonProps
   extends Omit<TogglePrimitive.RootProps, "children"> {}
 
+const ReactionButtonIcon = () => {
+  const { pressed, stateProps } = useToggleContext();
+  const classNames = useImageFrameReactionButtonClassNames();
+  const iconProps = mergeProps(stateProps, {
+    className: pressed ? classNames.fillIcon : classNames.lineIcon,
+  } as React.HTMLAttributes<HTMLElement>);
+
+  return <InternalIcon svg={pressed ? <HeartFillSvg /> : <HeartLineSvg />} {...iconProps} />;
+};
+
 export const ImageFrameReactionButton = React.forwardRef<
   HTMLButtonElement,
   ImageFrameReactionButtonProps
->(({ className, pressed, ...rest }, ref) => {
+>(({ className, ...rest }, ref) => {
+  const classNames = imageFrameReactionButton();
+
   return (
-    <TogglePrimitive.Root
-      ref={ref}
-      className={clsx(imageFrameReactionButton(), className)}
-      pressed={pressed}
-      {...rest}
-    >
-      <Icon svg={pressed ? <SelectedHeartIcon /> : <UnselectedHeartIcon />} />
-    </TogglePrimitive.Root>
+    <ImageFrameReactionButtonClassNamesProvider value={classNames}>
+      <TogglePrimitive.Root ref={ref} className={clsx(classNames.root, className)} {...rest}>
+        <ReactionButtonIcon />
+      </TogglePrimitive.Root>
+    </ImageFrameReactionButtonClassNamesProvider>
   );
 });
 

package/src/components/TagGroup/TagGroup.tsx

@@ -31,7 +31,10 @@ export const TagGroupRoot = forwardRef<HTMLSpanElement, TagGroupRootProps>(
       <PropsProvider value={tagGroupItemVariantProps}>
         <Primitive.span ref={ref} className={clsx(classNames.root, className)} {...otherProps}>
           {Children.toArray(children)
-            .filter((child) => child !== null && child !== undefined)
+            // putting something other than TagGroupItem in TagGroupRoot is not a good idea,
+            // but we shouldn't throw an error for it either
+            // thus .filter(React.isValidElement) is too strict here
+            .filter(Boolean)
             .map((child, index) => (
               // biome-ignore lint/suspicious/noArrayIndexKey: those fragments won't change order
               <Fragment key={index}>

package/src/components/index.ts

@@ -14,6 +14,7 @@ export * from "./Chip";
 export * from "./ChipTabs";
 export * from "./Columns";
 export * from "./ConsistentWidth";
+export * from "./ContentPlaceholder";
 export * from "./ContextualFloatingButton";
 export * from "./ControlChip";
 export * from "./Count";

package/src/utils/styled.tsx

@@ -671,7 +671,12 @@ export function useStyleProps<T extends UseStyleProps>(
       "--seed-box-background--active": handleColor(_active?.bg ?? _active?.background),
       ...style,
     } as React.CSSProperties,
-    restProps,
+    restProps: {
+      ...restProps,
+
+      // see global.ts to understand why we need this
+      ...((_active?.bg != null || _active?.background != null) && { "data-has-active-bg": "" }),
+    },
   };
 }