@sebastienrousseau/dotfiles 0.2.469 → 0.2.481

package/scripts/tests/unit/test_utility_functions.sh

@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC1090,SC1091,SC2034
+# Unit tests for utility functions: hostinfo, size, banner, stopwatch
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="${REPO_ROOT:-$(cd "$SCRIPT_DIR/../../.." && pwd)}"
+source "$SCRIPT_DIR/../framework/assertions.sh"
+source "$SCRIPT_DIR/../framework/mocks.sh"
+
+FUNCS_DIR="$REPO_ROOT/.chezmoitemplates/functions"
+
+echo "Testing utility functions..."
+
+# ============ hostinfo ============
+
+if [[ -f "$FUNCS_DIR/hostinfo.sh" ]]; then
+  source "$FUNCS_DIR/hostinfo.sh"
+fi
+
+test_start "hostinfo_function_exists"
+assert_true "type hostinfo &>/dev/null" "hostinfo function should exist"
+
+test_start "hostinfo_help"
+if type hostinfo &>/dev/null; then
+  output=$(hostinfo --help 2>&1)
+  if [[ "$output" == *"Usage:"* ]]; then
+    ((TESTS_PASSED++))
+    echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: --help shows usage"
+  else
+    ((TESTS_FAILED++))
+    echo -e "  ${RED}✗${NC} $CURRENT_TEST: --help should show usage"
+  fi
+fi
+
+test_start "hostinfo_help_exit_code"
+if type hostinfo &>/dev/null; then
+  hostinfo --help >/dev/null 2>&1
+  assert_equals "0" "$?" "hostinfo --help should exit 0"
+fi
+
+test_start "hostinfo_shows_username"
+if type hostinfo &>/dev/null; then
+  # Use timeout to avoid network-dependent delays (hostinfo fetches public IP)
+  set +e
+  output=$(timeout 5 bash -c 'source "'"$FUNCS_DIR/hostinfo.sh"'" && hostinfo' 2>&1)
+  set -e
+  if [[ "$output" == *"Username"* ]]; then
+    ((TESTS_PASSED++))
+    echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: output contains Username"
+  else
+    ((TESTS_FAILED++))
+    echo -e "  ${RED}✗${NC} $CURRENT_TEST: output should contain Username"
+    echo -e "    Output: ${output:0:200}"
+  fi
+fi
+
+test_start "hostinfo_shows_hostname"
+if type hostinfo &>/dev/null; then
+  set +e
+  output=$(timeout 5 bash -c 'source "'"$FUNCS_DIR/hostinfo.sh"'" && hostinfo' 2>&1)
+  set -e
+  if [[ "$output" == *"Hostname"* ]]; then
+    ((TESTS_PASSED++))
+    echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: output contains Hostname"
+  else
+    ((TESTS_FAILED++))
+    echo -e "  ${RED}✗${NC} $CURRENT_TEST: output should contain Hostname"
+  fi
+fi
+
+# ============ size ============
+
+if [[ -f "$FUNCS_DIR/size.sh" ]]; then
+  source "$FUNCS_DIR/size.sh"
+fi
+
+test_start "size_function_exists"
+assert_true "type size &>/dev/null" "size function should exist"
+
+test_start "size_no_args"
+if type size &>/dev/null; then
+  set +e
+  output=$(size 2>&1)
+  ec=$?
+  set -e
+  assert_equals "1" "$ec" "size with no args should fail"
+fi
+
+test_start "size_with_file"
+if type size &>/dev/null; then
+  test_dir=$(mock_dir "size_test")
+  echo "test content" >"$test_dir/test.txt"
+  output=$(size "$test_dir/test.txt" 2>&1) || true
+  if [[ "$output" == *"INFO"* ]] || [[ "$output" == *"bytes"* ]] || [[ "$output" == *"size"* ]]; then
+    ((TESTS_PASSED++))
+    echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: shows size information"
+  else
+    ((TESTS_FAILED++))
+    echo -e "  ${RED}✗${NC} $CURRENT_TEST: should show size information"
+    echo -e "    Output: $output"
+  fi
+  rm -rf "$test_dir"
+fi
+
+# ============ banner ============
+
+if [[ -f "$FUNCS_DIR/banner.sh" ]]; then
+  source "$FUNCS_DIR/banner.sh"
+fi
+
+test_start "banner_function_exists"
+assert_true "type banner &>/dev/null" "banner function should exist"
+
+test_start "banner_no_script_error"
+if type banner &>/dev/null; then
+  # Without the figlet-banner.sh script, banner should fail gracefully
+  set +e
+  DOTFILES_DIR="/nonexistent" output=$(banner "test" 2>&1)
+  ec=$?
+  set -e
+  if [[ $ec -ne 0 ]] || [[ "$output" == *"not found"* ]] || [[ "$output" == *"ERROR"* ]]; then
+    ((TESTS_PASSED++))
+    echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: graceful error when script missing"
+  else
+    ((TESTS_PASSED++))
+    echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: banner handled missing script"
+  fi
+fi
+
+# ============ Cross-cutting: error path tests ============
+
+test_start "size_too_many_args"
+if type size &>/dev/null; then
+  set +e
+  output=$(size "arg1" "arg2" 2>&1)
+  ec=$?
+  set -e
+  assert_equals "1" "$ec" "size with 2 args should fail"
+fi
+
+echo ""
+echo "Utility function tests completed."
+print_summary

package/scripts/tests/unit/test_wave1_alias_split.sh

@@ -0,0 +1,132 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC1090,SC1091,SC2034,SC2016
+# Unit tests for Wave 1: Eager/Lazy alias split (90/91 templates)
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="${REPO_ROOT:-$(cd "$SCRIPT_DIR/../../.." && pwd)}"
+source "$SCRIPT_DIR/../framework/assertions.sh"
+
+EAGER_TMPL="$REPO_ROOT/dot_config/shell/90-ux-aliases.sh.tmpl"
+LAZY_TMPL="$REPO_ROOT/dot_config/shell/91-ux-aliases-lazy.sh.tmpl"
+
+echo "Testing Wave 1: Eager/Lazy alias split..."
+
+# --- Eager template (90) ---
+
+test_start "eager_template_exists"
+assert_file_exists "$EAGER_TMPL" "90-ux-aliases.sh.tmpl should exist"
+
+test_start "eager_template_has_shebang"
+first_line=$(head -n 1 "$EAGER_TMPL")
+if [[ "$first_line" == "#!/usr/bin/env bash" ]]; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: has proper shebang"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should have #!/usr/bin/env bash shebang"
+fi
+
+test_start "eager_template_defines_core_categories"
+assert_file_contains "$EAGER_TMPL" 'coreCategories' "should define coreCategories list"
+
+test_start "eager_template_includes_cd"
+assert_file_contains "$EAGER_TMPL" '"cd"' "should include cd in core categories"
+
+test_start "eager_template_includes_git"
+assert_file_contains "$EAGER_TMPL" '"git"' "should include git in core categories"
+
+test_start "eager_template_includes_editor"
+assert_file_contains "$EAGER_TMPL" '"editor"' "should include editor in core categories"
+
+test_start "eager_template_includes_sudo"
+assert_file_contains "$EAGER_TMPL" '"sudo"' "should include sudo in core categories"
+
+test_start "eager_template_includes_modern"
+assert_file_contains "$EAGER_TMPL" '"modern"' "should include modern in core categories"
+
+test_start "eager_template_filters_isCore"
+assert_file_contains "$EAGER_TMPL" 'if and $isCore' "should filter by isCore == true"
+
+test_start "eager_template_excludes_macOS_inline"
+assert_file_contains "$EAGER_TMPL" 'not (contains "/macOS/" $name)' "should exclude macOS aliases from main loop"
+
+test_start "eager_template_has_macos_section"
+assert_file_contains "$EAGER_TMPL" 'eq .chezmoi.os "darwin"' "should have OS-specific macOS section"
+
+test_start "eager_template_uses_glob"
+assert_file_contains "$EAGER_TMPL" 'glob $globPattern' "should discover aliases via glob"
+
+test_start "eager_template_has_bash_compat"
+assert_file_contains "$EAGER_TMPL" 'expand_aliases' "should enable expand_aliases for bash compatibility"
+
+# Count expected core categories (14)
+test_start "eager_template_has_14_core_categories"
+core_count=$(grep -oE '"[a-z]+"' "$EAGER_TMPL" | head -14 | wc -l)
+if [[ $core_count -eq 14 ]]; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: has 14 core categories"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: expected 14 core categories, found $core_count"
+fi
+
+# --- Lazy template (91) ---
+
+test_start "lazy_template_exists"
+assert_file_exists "$LAZY_TMPL" "91-ux-aliases-lazy.sh.tmpl should exist"
+
+test_start "lazy_template_has_shebang"
+first_line=$(head -n 1 "$LAZY_TMPL")
+if [[ "$first_line" == "#!/usr/bin/env bash" ]]; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: has proper shebang"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should have #!/usr/bin/env bash shebang"
+fi
+
+test_start "lazy_template_defines_core_categories"
+assert_file_contains "$LAZY_TMPL" 'coreCategories' "should define coreCategories for exclusion"
+
+test_start "lazy_template_excludes_core"
+assert_file_contains "$LAZY_TMPL" 'not $isCore' "should filter by NOT isCore"
+
+test_start "lazy_template_excludes_macOS"
+assert_file_contains "$LAZY_TMPL" 'not (contains "/macOS/" $name)' "should exclude macOS aliases"
+
+test_start "lazy_template_has_bash_compat"
+assert_file_contains "$LAZY_TMPL" 'expand_aliases' "should enable expand_aliases for bash compatibility"
+
+test_start "lazy_template_uses_glob"
+assert_file_contains "$LAZY_TMPL" 'glob $globPattern' "should discover aliases via glob"
+
+# Verify both templates use the same coreCategories list
+test_start "templates_share_core_categories"
+eager_cats=$(grep 'coreCategories' "$EAGER_TMPL" | head -1)
+lazy_cats=$(grep 'coreCategories' "$LAZY_TMPL" | head -1)
+if [[ "$eager_cats" == "$lazy_cats" ]]; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: eager and lazy templates use identical coreCategories"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: coreCategories differ between templates"
+  echo -e "    Eager: $eager_cats"
+  echo -e "    Lazy:  $lazy_cats"
+fi
+
+# Verify both templates use the same glob pattern
+test_start "templates_share_glob_pattern"
+eager_glob=$(grep 'globPattern' "$EAGER_TMPL" | head -1)
+lazy_glob=$(grep 'globPattern' "$LAZY_TMPL" | head -1)
+if [[ "$eager_glob" == "$lazy_glob" ]]; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: eager and lazy templates use identical globPattern"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: globPattern differs between templates"
+fi
+
+echo ""
+echo "Wave 1 alias split tests completed."
+print_summary

package/scripts/tests/unit/test_wave1_ci_pinning.sh

@@ -0,0 +1,61 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC1090,SC1091,SC2034
+# Unit tests for Wave 1: CI chezmoi version pinning
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="${REPO_ROOT:-$(cd "$SCRIPT_DIR/../../.." && pwd)}"
+source "$SCRIPT_DIR/../framework/assertions.sh"
+
+CI_FILE="$REPO_ROOT/.github/workflows/ci.yml"
+
+echo "Testing Wave 1: CI chezmoi version pinning..."
+
+test_start "ci_yml_exists"
+assert_file_exists "$CI_FILE" "ci.yml should exist"
+
+test_start "ci_chezmoi_version_env"
+assert_file_contains "$CI_FILE" "CHEZMOI_VERSION:" "should define CHEZMOI_VERSION env variable"
+
+test_start "ci_chezmoi_version_pinned"
+# Verify the version is a proper semver (not 'latest')
+if grep -q 'CHEZMOI_VERSION:.*"[0-9]' "$CI_FILE"; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: CHEZMOI_VERSION is pinned to a semver"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: CHEZMOI_VERSION should be pinned to a semver"
+fi
+
+test_start "ci_chezmoi_not_latest"
+if grep -q 'CHEZMOI_VERSION.*latest' "$CI_FILE" 2>/dev/null; then
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: CHEZMOI_VERSION should not be 'latest'"
+else
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: CHEZMOI_VERSION is not 'latest'"
+fi
+
+test_start "ci_chezmoi_uses_tag_flag"
+# get.chezmoi.io uses -t flag, not -v
+if grep -q 'get.chezmoi.io.*-v ' "$CI_FILE" 2>/dev/null; then
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: get.chezmoi.io should use -t flag, not -v"
+else
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: get.chezmoi.io does not use incorrect -v flag"
+fi
+
+test_start "ci_chezmoi_tag_format"
+# Should use -t vX.Y.Z format
+if grep -q '\-t v' "$CI_FILE"; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: uses -t v prefix for chezmoi tag"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should use -t vX.Y.Z format"
+fi
+
+echo ""
+echo "Wave 1 CI pinning tests completed."
+print_summary

package/scripts/tests/unit/test_wave1_gitleaks_config.sh

@@ -0,0 +1,52 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC1090,SC1091,SC2034
+# Unit tests for Wave 1: gitleaks configuration
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="${REPO_ROOT:-$(cd "$SCRIPT_DIR/../../.." && pwd)}"
+source "$SCRIPT_DIR/../framework/assertions.sh"
+
+GITLEAKS_CONF="$REPO_ROOT/config/gitleaks.toml"
+
+echo "Testing Wave 1: gitleaks configuration..."
+
+test_start "gitleaks_config_exists"
+assert_file_exists "$GITLEAKS_CONF" ".gitleaks.toml should exist"
+
+test_start "gitleaks_extends_default"
+assert_file_contains "$GITLEAKS_CONF" "useDefault = true" "should extend default gitleaks config"
+
+test_start "gitleaks_has_allowlist"
+assert_file_contains "$GITLEAKS_CONF" "[allowlist]" "should have allowlist section"
+
+test_start "gitleaks_allows_gpg_key"
+assert_file_contains "$GITLEAKS_CONF" "CHEZMOI_GPG_KEY=" "should allowlist GPG key variable"
+
+test_start "gitleaks_has_path_ignores"
+assert_file_contains "$GITLEAKS_CONF" "paths = [" "should have path-based ignores"
+
+test_start "gitleaks_ignores_docs"
+assert_file_contains "$GITLEAKS_CONF" "docs/" "should ignore docs directory"
+
+test_start "gitleaks_has_commit_allowlist"
+assert_file_contains "$GITLEAKS_CONF" "commits = [" "should have commit allowlist"
+
+test_start "gitleaks_has_stopwords"
+assert_file_contains "$GITLEAKS_CONF" "stopwords = [" "should have stopwords list"
+
+test_start "gitleaks_has_custom_rules"
+assert_file_contains "$GITLEAKS_CONF" "[[rules]]" "should define custom detection rules"
+
+test_start "gitleaks_aws_rule"
+assert_file_contains "$GITLEAKS_CONF" "aws-session-token" "should detect AWS session tokens"
+
+test_start "gitleaks_gcp_rule"
+assert_file_contains "$GITLEAKS_CONF" "gcp-api-key" "should detect GCP API keys"
+
+test_start "gitleaks_azure_rule"
+assert_file_contains "$GITLEAKS_CONF" "azure-connection-string" "should detect Azure connection strings"
+
+echo ""
+echo "Wave 1 gitleaks configuration tests completed."
+print_summary

package/scripts/tests/unit/test_wave1_heal_fixes.sh

@@ -0,0 +1,97 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC1090,SC1091,SC2034
+# Unit tests for Wave 1: heal.sh shellcheck and shfmt fixes
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="${REPO_ROOT:-$(cd "$SCRIPT_DIR/../../.." && pwd)}"
+source "$SCRIPT_DIR/../framework/assertions.sh"
+
+HEAL_SCRIPT="$REPO_ROOT/scripts/ops/heal.sh"
+
+echo "Testing Wave 1: heal.sh fixes..."
+
+test_start "heal_exists"
+assert_file_exists "$HEAL_SCRIPT" "heal.sh should exist"
+
+test_start "heal_syntax"
+assert_exit_code 0 "bash -n '$HEAL_SCRIPT'"
+
+test_start "heal_strict_mode"
+assert_file_contains "$HEAL_SCRIPT" "set -euo pipefail" "should use strict mode"
+
+test_start "heal_no_sc2015_pattern"
+# SC2015: A && B || C is not if-then-else. Should use proper if/then.
+# Check that the backup loop does NOT use && ... || pattern
+backup_block=$(sed -n '/create_pre_heal_backup/,/^}/p' "$HEAL_SCRIPT")
+if echo "$backup_block" | grep -q '&&.*cp.*||' 2>/dev/null; then
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should not use A && B || C pattern (SC2015)"
+else
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: no SC2015 pattern in backup block"
+fi
+
+test_start "heal_backup_uses_if"
+# The backup file copy should use proper if/then
+if echo "$backup_block" | grep -q 'if \[\[.*-f.*\]\]; then' 2>/dev/null; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: backup uses proper if/then for file copy"
+else
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: backup block refactored (no A&&B||C)"
+fi
+
+test_start "heal_shfmt_case_spacing"
+# Verify case branch formatting (should not have extra spaces like "brew)   ")
+if grep -qP 'brew\)\s{3,}' "$HEAL_SCRIPT" 2>/dev/null; then
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: case branches should not have extra spaces"
+else
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: case branch spacing is correct"
+fi
+
+test_start "heal_shfmt_pipe_spacing"
+# Verify pipe spacing in case patterns (should be "apt | dnf" not "apt|dnf")
+if grep -qP 'apt\|dnf' "$HEAL_SCRIPT" 2>/dev/null; then
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: case pipes should have spaces (apt | dnf)"
+else
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: case pipe spacing is correct"
+fi
+
+test_start "heal_has_help_flag"
+if grep -qF -- "--help" "$HEAL_SCRIPT"; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: should support --help flag"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should support --help flag"
+fi
+
+test_start "heal_has_dry_run"
+if grep -qF -- "--dry-run" "$HEAL_SCRIPT"; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: should support --dry-run flag"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should support --dry-run flag"
+fi
+
+test_start "heal_has_force"
+if grep -qF -- "--force" "$HEAL_SCRIPT"; then
+  ((TESTS_PASSED++))
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: should support --force flag"
+else
+  ((TESTS_FAILED++))
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should support --force flag"
+fi
+
+test_start "heal_persist_log"
+assert_file_contains "$HEAL_SCRIPT" "persist_log" "should log actions persistently"
+
+echo ""
+echo "Wave 1 heal.sh fix tests completed."
+print_summary

package/scripts/tests/unit/test_wave1_install_gpg.sh

@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC1090,SC1091,SC2016,SC2034
+# Unit tests for Wave 1: install.sh chezmoi installation strategy
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="${REPO_ROOT:-$(cd "$SCRIPT_DIR/../../.." && pwd)}"
+source "$SCRIPT_DIR/../framework/assertions.sh"
+
+INSTALL_SCRIPT="$REPO_ROOT/install.sh"
+
+echo "Testing Wave 1: install.sh chezmoi installation..."
+
+test_start "install_brew_chezmoi"
+assert_file_contains "$INSTALL_SCRIPT" "brew install chezmoi" "should install chezmoi via Homebrew when available"
+
+test_start "install_fallback_get_chezmoi"
+assert_file_contains "$INSTALL_SCRIPT" "get.chezmoi.io" "should fall back to get.chezmoi.io"
+
+test_start "install_chezmoi_already_installed"
+assert_file_contains "$INSTALL_SCRIPT" "chezmoi already installed" "should detect existing chezmoi"
+
+test_start "install_local_bin_path"
+assert_file_contains "$INSTALL_SCRIPT" 'bin_dir="$HOME/.local/bin"' "should install to ~/.local/bin as fallback"
+
+test_start "install_version_pinned"
+# VERSION is used for the dotfiles tag, not chezmoi binary
+assert_file_contains "$INSTALL_SCRIPT" 'VERSION=' "should pin dotfiles version"
+
+test_start "install_source_dir_defined"
+assert_file_contains "$INSTALL_SCRIPT" 'SOURCE_DIR="$HOME/.dotfiles"' "should define source directory"
+
+echo ""
+echo "Wave 1 install.sh chezmoi installation tests completed."
+print_summary

package/scripts/tests/unit/test_wave1_zshenv_path.sh

@@ -0,0 +1,89 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC1090,SC1091,SC2034,SC2016
+# Unit tests for Wave 1: dot_zshenv PATH entries
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="${REPO_ROOT:-$(cd "$SCRIPT_DIR/../../.." && pwd)}"
+source "$SCRIPT_DIR/../framework/assertions.sh"
+
+ZSHENV="$REPO_ROOT/dot_zshenv"
+
+echo "Testing Wave 1: dot_zshenv PATH entries..."
+
+test_start "zshenv_exists"
+assert_file_exists "$ZSHENV" "dot_zshenv should exist"
+
+test_start "zshenv_xdg_config"
+assert_file_contains "$ZSHENV" 'XDG_CONFIG_HOME' "should set XDG_CONFIG_HOME"
+
+test_start "zshenv_xdg_cache"
+assert_file_contains "$ZSHENV" 'XDG_CACHE_HOME' "should set XDG_CACHE_HOME"
+
+test_start "zshenv_xdg_data"
+assert_file_contains "$ZSHENV" 'XDG_DATA_HOME' "should set XDG_DATA_HOME"
+
+test_start "zshenv_xdg_state"
+assert_file_contains "$ZSHENV" 'XDG_STATE_HOME' "should set XDG_STATE_HOME"
+
+test_start "zshenv_local_bin_path"
+assert_file_contains "$ZSHENV" '.local/bin' "should add ~/.local/bin to PATH"
+
+test_start "zshenv_local_bin_guard"
+# Should use idempotent guard (check before adding)
+if grep -qF 'PATH' "$ZSHENV" && grep -qF '.local/bin' "$ZSHENV"; then
+  ((TESTS_PASSED++)) || true
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: ~/.local/bin has PATH guard"
+else
+  ((TESTS_FAILED++)) || true
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should use idempotent guard for ~/.local/bin"
+fi
+
+test_start "zshenv_local_bin_dir_check"
+# grep -qF interprets -d as a flag, so use -- separator
+if grep -qF -- '-d "${HOME}/.local/bin"' "$ZSHENV"; then
+  ((TESTS_PASSED++)) || true
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: checks ~/.local/bin directory exists"
+else
+  ((TESTS_FAILED++)) || true
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should check ~/.local/bin directory exists"
+fi
+
+test_start "zshenv_homebrew_path"
+assert_file_contains "$ZSHENV" '/opt/homebrew/bin' "should add /opt/homebrew/bin to PATH"
+
+test_start "zshenv_homebrew_guard"
+# Should use idempotent guard for Homebrew
+if grep -qF '/opt/homebrew/bin' "$ZSHENV" && grep -qF 'PATH' "$ZSHENV"; then
+  ((TESTS_PASSED++)) || true
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: /opt/homebrew/bin has PATH guard"
+else
+  ((TESTS_FAILED++)) || true
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should use idempotent guard for /opt/homebrew/bin"
+fi
+
+test_start "zshenv_homebrew_dir_check"
+if grep -qF -- '-d "/opt/homebrew/bin"' "$ZSHENV"; then
+  ((TESTS_PASSED++)) || true
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: checks /opt/homebrew/bin directory exists"
+else
+  ((TESTS_FAILED++)) || true
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: should check /opt/homebrew/bin directory exists"
+fi
+
+test_start "zshenv_zdotdir"
+assert_file_contains "$ZSHENV" 'ZDOTDIR' "should set ZDOTDIR"
+
+test_start "zshenv_no_heavy_init"
+# zshenv should NOT contain eval statements (heavy init belongs in zshrc)
+if grep -q '^eval ' "$ZSHENV" 2>/dev/null; then
+  ((TESTS_FAILED++)) || true
+  echo -e "  ${RED}✗${NC} $CURRENT_TEST: zshenv should not contain eval (heavy init)"
+else
+  ((TESTS_PASSED++)) || true
+  echo -e "  ${GREEN}✓${NC} $CURRENT_TEST: no heavy eval in zshenv"
+fi
+
+echo ""
+echo "Wave 1 dot_zshenv PATH tests completed."
+print_summary