@seaverse/data-service-sdk 0.10.0 → 0.10.2

package/dist/browser.umd.js

@@ -3945,9 +3945,9 @@
    * ---------------------------
    * Your Firestore data is organized in three permission levels:
    *
-   * 1. publicRead/   - System configs, announcements (Read: Everyone, Write: Admin only)
-   * 2. publicData/   - User posts, shared content (Read: Everyone, Write: Everyone)
-   * 3. userData/{userId}/ - Private user data (Read/Write: Owner only)
+   * 1. publicRead/_data/   - System configs, announcements (Read: Everyone, Write: Admin only)
+   * 2. publicData/_data/   - User posts, shared content (Read: Everyone, Write: Everyone)
+   * 3. userData/{userId}/_data/ - Private user data (Read/Write: Owner only)
    *
    * QUICK START FOR LLM:
    * -------------------
@@ -3999,7 +3999,7 @@
    * const snapshot = await getDocs(collection(db, `appData/${appId}/publicData/posts`));
    *
    * // Write to userData (only owner can write)
-   * await addDoc(collection(db, `appData/${appId}/userData/${userId}/notes`), {
+   * await addDoc(collection(db, `appData/${appId}/userData/${userId}/_data/notes`), {
    *   _appId: appId,              // REQUIRED
    *   _createdAt: serverTimestamp(), // REQUIRED
    *   _createdBy: userId,         // REQUIRED
@@ -4252,7 +4252,7 @@
    * ```typescript
    * // Write private user notes
    * const path = getUserDataPath('my-app', 'user-123', 'notes');
-   * // Returns: 'appData/my-app/userData/user-123/notes'
+   * // Returns: 'appData/my-app/userData/user-123/_data/notes'
    *
    * await addDoc(collection(db, path), {
    *   _appId: appId,
@@ -4266,7 +4266,7 @@
       validateSegment('appId', appId);
       validateSegment('userId', userId);
       validateSegment('collectionName', collectionName);
-      return `appData/${appId}/userData/${userId}/${collectionName}`;
+      return `appData/${appId}/userData/${userId}/_data/${collectionName}`;
   }
   /**
    * Generate path for a specific document in publicRead
@@ -4324,7 +4324,7 @@
    * @example
    * ```typescript
    * const path = getUserDataDocPath('my-app', 'user-123', 'notes', 'note-456');
-   * // Returns: 'appData/my-app/userData/user-123/notes/note-456'
+   * // Returns: 'appData/my-app/userData/user-123/_data/notes/note-456'
    *
    * const docSnap = await getDoc(doc(db, path));
    * ```
@@ -4334,7 +4334,7 @@
       validateSegment('userId', userId);
       validateSegment('collectionName', collectionName);
       validateSegment('docId', docId);
-      return `appData/${appId}/userData/${userId}/${collectionName}/${docId}`;
+      return `appData/${appId}/userData/${userId}/_data/${collectionName}/${docId}`;
   }
   /**
    * Validate a path segment to ensure it doesn't contain invalid characters
@@ -4399,7 +4399,7 @@
       userData(userId, collectionName) {
           validateSegment('userId', userId);
           validateSegment('collectionName', collectionName);
-          this.segments.push('userData', userId, collectionName);
+          this.segments.push('userData', userId, '_data', collectionName);
           return this;
       }
       /**
@@ -5018,7 +5018,9 @@
           }
           else {
               // Filter out soft-deleted documents
-              const q = query(colRef, where('_deleted', '==', false));
+              // Use '!=' to include documents without _deleted field (new documents)
+              // This will return documents where _deleted is missing, null, undefined, or false
+              const q = query(colRef, where('_deleted', '!=', true));
               return getDocs(q);
           }
       }
@@ -5151,7 +5153,7 @@
    *
    * This is a convenience function that automatically:
    * 1. Creates Firebase config from token response
-   * 2. Initializes Firebase app
+   * 2. Initializes Firebase app (or reuses existing one)
    * 3. Signs in with the custom token
    * 4. Creates FirestoreHelper for LLM-friendly operations
    * 5. Returns authenticated Firebase instances
@@ -5159,11 +5161,20 @@
    * IMPORTANT: This function requires Firebase SDK to be installed separately:
    * npm install firebase
    *
+   * ⚠️ IMPORTANT: This function can be called multiple times safely. It will:
+   * - Reuse existing Firebase app if already initialized
+   * - Re-authenticate with new token if needed
+   * - Handle token refresh scenarios
+   *
    * 🎯 LLM RECOMMENDED: Use the `helper` object for simplified operations
    *
    * @param tokenResponse - The Firestore token response from SDK
    * @returns Object containing initialized Firebase instances and LLM-friendly helper
    *
+   * @throws {Error} If app_id is missing from token response
+   * @throws {Error} If Firebase SDK is not installed
+   * @throws {Error} If authentication fails
+   *
    * @example
    * ```typescript
    * import { initializeWithToken } from '@seaverse/data-service-sdk';
@@ -5182,17 +5193,25 @@
    * ```
    */
   async function initializeWithToken(tokenResponse) {
+      // ✅ FIX #3: Validate appId FIRST before any initialization
+      const appId = tokenResponse.app_id;
+      if (!appId) {
+          throw new Error('app_id is required in token response. ' +
+              'Make sure your token response includes a valid app_id field.');
+      }
       // Check if Firebase SDK is available
       let initializeApp;
       let getAuth;
       let signInWithCustomToken;
       let getFirestore;
+      let getApps;
       try {
           // Try to import Firebase modules
           const firebaseApp = await import('firebase/app');
           const firebaseAuth = await import('firebase/auth');
           const firebaseFirestore = await import('firebase/firestore');
           initializeApp = firebaseApp.initializeApp;
+          getApps = firebaseApp.getApps;
           getAuth = firebaseAuth.getAuth;
           signInWithCustomToken = firebaseAuth.signInWithCustomToken;
           getFirestore = firebaseFirestore.getFirestore;
@@ -5201,17 +5220,57 @@
           throw new Error('Firebase SDK not found. Please install it: npm install firebase\n' +
               'Or import manually and use getFirebaseConfig() helper instead.');
       }
-      // Initialize Firebase
-      const config = getFirebaseConfig(tokenResponse);
-      const app = initializeApp(config);
-      // Sign in with custom token
-      const auth = getAuth(app);
-      await signInWithCustomToken(auth, tokenResponse.custom_token);
-      // Get Firestore instance with correct database ID
-      // IMPORTANT: Must specify database_id, not just use default!
-      const db = getFirestore(app, tokenResponse.database_id);
+      // ✅ FIX #1: Check if Firebase app already exists
+      const existingApps = getApps();
+      const existingApp = existingApps.find((app) => app.name === '[DEFAULT]');
+      let app;
+      let auth;
+      let db;
+      if (existingApp) {
+          // ✅ FIX #2: Reuse existing app instead of creating new one
+          console.log('[SeaVerse SDK] Reusing existing Firebase app');
+          app = existingApp;
+          auth = getAuth(app);
+          db = getFirestore(app, tokenResponse.database_id);
+          // ✅ FIX #4: Re-authenticate with new token (for token refresh scenarios)
+          try {
+              await signInWithCustomToken(auth, tokenResponse.custom_token);
+              console.log('[SeaVerse SDK] Re-authenticated with new token');
+          }
+          catch (error) {
+              // If already signed in with same token, ignore error
+              // Only throw if it's a real authentication failure
+              if (error?.code !== 'auth/invalid-credential' && error?.code !== 'auth/network-request-failed') {
+                  console.warn('[SeaVerse SDK] Re-authentication warning:', error?.message || error);
+              }
+          }
+      }
+      else {
+          // ✅ FIX #4: First-time initialization with proper error handling
+          console.log('[SeaVerse SDK] Initializing new Firebase app');
+          try {
+              const config = getFirebaseConfig(tokenResponse);
+              app = initializeApp(config);
+              auth = getAuth(app);
+              await signInWithCustomToken(auth, tokenResponse.custom_token);
+              // IMPORTANT: Must specify database_id, not just use default!
+              db = getFirestore(app, tokenResponse.database_id);
+          }
+          catch (error) {
+              // ✅ FIX #4: Cleanup on failure to prevent half-initialized state
+              if (app) {
+                  try {
+                      await app.delete();
+                      console.log('[SeaVerse SDK] Cleaned up failed Firebase app initialization');
+                  }
+                  catch (cleanupError) {
+                      console.warn('[SeaVerse SDK] Failed to cleanup app:', cleanupError);
+                  }
+              }
+              throw new Error(`Failed to initialize Firebase: ${error instanceof Error ? error.message : String(error)}`);
+          }
+      }
       const userId = tokenResponse.user_id;
-      const appId = tokenResponse.app_id || '';
       // Create LLM-friendly helper
       const helper = new FirestoreHelper(db, appId, userId);
       return {