@seanyao/roll 3.624.2 → 3.624.3

package/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## v3.624.3 — 2026-06-24
+
+- **验收报告内容判定与视觉证据闸分离**：`attest:gate` 不再把“报告有 AC/ac-map/E2E 证据但声明的截图面未真实捕获”误报成 empty-shell；这类情况现在按视觉证据缺口给出可操作 reason，避免 correction loop 反复走错修复方向。(FIX-400 follow-up) `[acceptance-evidence]`
+
 ## v3.624.2 — 2026-06-24
 
 ### 稳定性

package/dist/roll.mjs

@@ -249476,6 +249476,22 @@ function hasRealTerminalCapture(worktreeCwd, storyId) {
     return false;
   return takenCaptureCount(worktreeCwd, storyId, "terminal") >= need;
 }
+function declaredSurfaceCaptureFloor(worktreeCwd, storyId) {
+  const owesWeb = owesRealWebCapture(worktreeCwd, storyId);
+  const owesTerm = owesTerminalCapture(worktreeCwd, storyId);
+  if (!owesWeb && !owesTerm)
+    return { ok: true };
+  const gaps = [];
+  if (owesWeb && !hasRealWebCapture(worktreeCwd, storyId)) {
+    gaps.push(`declared deliverable_url(s) not all really captured (need ${webCaptureNeed(worktreeCwd, storyId)} taken web shots)`);
+  }
+  if (owesTerm && !hasRealTerminalCapture(worktreeCwd, storyId)) {
+    gaps.push(`declared deliverable_cmd(s) not all really captured (need ${deliverableCmdsForStory(worktreeCwd, storyId).length} taken terminal shots)`);
+  }
+  if (gaps.length === 0)
+    return { ok: true, reason: "all declared surfaces really captured" };
+  return { ok: false, reason: `declared surface capture missing: ${gaps.join("; ")}` };
+}
 function passAcVisualFloor(worktreeCwd, storyId) {
   if (violatesMustDeclareSurface(worktreeCwd, storyId)) {
     return { ok: false, reason: MUST_DECLARE_FAIL_REASON };
@@ -249491,26 +249507,35 @@ function passAcVisualFloor(worktreeCwd, storyId) {
   const missing = pass.filter((e) => !(e.evidence ?? []).some((ev) => ev.kind === "screenshot" && typeof ev.href === "string" && ev.href !== ""));
   if (missing.length === 0)
     return { ok: true };
-  const owesWeb = owesRealWebCapture(worktreeCwd, storyId);
-  const owesTerm = owesTerminalCapture(worktreeCwd, storyId);
-  if (owesWeb || owesTerm) {
-    const gaps = [];
-    if (owesWeb && !hasRealWebCapture(worktreeCwd, storyId)) {
-      gaps.push(`declared deliverable_url(s) not all really captured (need ${webCaptureNeed(worktreeCwd, storyId)} taken web shots)`);
-    }
-    if (owesTerm && !hasRealTerminalCapture(worktreeCwd, storyId)) {
-      gaps.push(`declared deliverable_cmd(s) not all really captured (need ${deliverableCmdsForStory(worktreeCwd, storyId).length} taken terminal shots)`);
-    }
-    if (gaps.length === 0)
-      return { ok: true, reason: "all declared surfaces really captured" };
+  const declared = declaredSurfaceCaptureFloor(worktreeCwd, storyId);
+  if (declared.reason !== void 0) {
+    if (declared.ok)
+      return declared;
     const ids2 = missing.map((e) => e.ac ?? "?").join(", ");
-    return { ok: false, reason: `pass AC(s) lack screenshot evidence and a declared surface was never really captured (honest-skip does not satisfy a declared surface): ${gaps.join("; ")} [${ids2}]` };
+    return { ok: false, reason: `pass AC(s) lack screenshot evidence and a declared surface was never really captured (honest-skip does not satisfy a declared surface): ${declared.reason} [${ids2}]` };
   }
   if (hasMachineCaptureSkip(worktreeCwd, storyId))
     return { ok: true, reason: "machine capture skip present" };
   const ids = missing.map((e) => e.ac ?? "?").join(", ");
   return { ok: false, reason: `pass AC(s) lack screenshot evidence or machine capture skip: ${ids}` };
 }
+function visualEvidenceFloor(worktreeCwd, storyId, html) {
+  const passAc = passAcVisualFloor(worktreeCwd, storyId);
+  if (!passAc.ok)
+    return passAc;
+  if (!storyRequiresScreenshot(worktreeCwd, storyId))
+    return passAc;
+  const declared = declaredSurfaceCaptureFloor(worktreeCwd, storyId);
+  if (!declared.ok)
+    return declared;
+  if (declared.reason !== void 0)
+    return declared;
+  if (/<figure class="shot\b|href="screenshots\/|src="screenshots\//i.test(html))
+    return { ok: true };
+  if (hasMachineCaptureSkip(worktreeCwd, storyId))
+    return { ok: true, reason: "machine capture skip present" };
+  return { ok: false, reason: "visual evidence missing: no screenshot reference or machine capture skip" };
+}
 function redAcFailures(worktreeCwd, storyId) {
   const entries = readAcMapEntries(worktreeCwd, storyId);
   if (entries === null)
@@ -249549,6 +249574,19 @@ function verificationReportFresh(worktreeCwd, storyId, sinceSec) {
   }
 }
 function verificationReportHasContent(worktreeCwd, storyId) {
+  if (storyId === "")
+    return false;
+  const p = existingReport(worktreeCwd, storyId);
+  if (p === null)
+    return false;
+  try {
+    const html = readFileSync61(p, "utf8");
+    return verificationReportHasAcceptanceContent(worktreeCwd, storyId) && visualEvidenceFloor(worktreeCwd, storyId, html).ok;
+  } catch {
+    return false;
+  }
+}
+function verificationReportHasAcceptanceContent(worktreeCwd, storyId) {
   if (storyId === "")
     return false;
   const p = existingReport(worktreeCwd, storyId);
@@ -249572,23 +249610,7 @@ function verificationReportHasContent(worktreeCwd, storyId) {
         return false;
       positiveWithEvidence += 1;
     }
-    if (positiveWithEvidence === 0)
-      return false;
-    if (!passAcVisualFloor(worktreeCwd, storyId).ok)
-      return false;
-    if (storyRequiresScreenshot(worktreeCwd, storyId)) {
-      const owesWeb = owesRealWebCapture(worktreeCwd, storyId);
-      const owesTerm = owesTerminalCapture(worktreeCwd, storyId);
-      if (owesWeb || owesTerm) {
-        if (owesWeb && !hasRealWebCapture(worktreeCwd, storyId))
-          return false;
-        if (owesTerm && !hasRealTerminalCapture(worktreeCwd, storyId))
-          return false;
-        return true;
-      }
-      return /<figure class="shot\b|href="screenshots\/|src="screenshots\//i.test(html) || hasMachineCaptureSkip(worktreeCwd, storyId);
-    }
-    return true;
+    return positiveWithEvidence > 0;
   } catch {
     return false;
   }
@@ -249638,10 +249660,19 @@ function runAttestGate(worktreeCwd, storyId, cycleId, mode, sinceSec, sinks, sco
       return { verdict: "skipped", mode, reasons: reasons2, blocked: blocked2 };
     }
     const fresh = verificationReportFresh(worktreeCwd, storyId, sinceSec);
-    if (fresh && verificationReportHasContent(worktreeCwd, storyId)) {
+    if (fresh && verificationReportHasAcceptanceContent(worktreeCwd, storyId)) {
       const score = evaluateReviewScoreGate(scoreRepoCwd, storyId, builderSessionId, cycleId);
       if (score.status === "pass") {
-        const visual = passAcVisualFloor(worktreeCwd, storyId);
+        const report = existingReport(worktreeCwd, storyId);
+        const html = report === null ? "" : readFileSync61(report, "utf8");
+        const visual = visualEvidenceFloor(worktreeCwd, storyId, html);
+        if (!visual.ok) {
+          const reasons4 = [visual.reason ?? "visual evidence gate failed"];
+          const blocked3 = mode === "hard";
+          sinks.alert(`attest gate (${mode}): visual evidence gate failed (${storyId}) \u2014 ${reasons4[0]} \u2014 cycle ${cycleId}` + (blocked3 ? " \u2014 BLOCKED (hard mode); story not marked Done" : ""));
+          sinks.event({ cycleId, verdict: "skipped", reasons: reasons4 });
+          return { verdict: "skipped", mode, reasons: reasons4, blocked: blocked3 };
+        }
         const reasons3 = ["fresh acceptance report present", score.reason, ...visual.reason !== void 0 ? [visual.reason] : []];
         sinks.event({ cycleId, verdict: "produced", reasons: reasons3 });
         return { verdict: "produced", mode, reasons: reasons3, blocked: false };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@seanyao/roll",
-  "version": "3.624.2",
+  "version": "3.624.3",
   "description": "Roll — Roll out features with AI agents",
   "packageManager": "pnpm@11.1.3",
   "scripts": {