@seanyao/roll 2026.529.2 → 2026.529.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## v2026.529.3
+
+### Fixed
+
+- loop 用 kimi 跑不再必崩 `[loop]`
+- 切 agent 后 loop 不再用旧的 `[loop]`
+- loop 不再因提交卡住整轮白做 `[loop]`
+
 ## v2026.529.2
 
 ### Added

package/bin/roll

@@ -4,7 +4,7 @@ set -euo pipefail
 # Roll — AI Agent Convention Manager
 # Single source of truth for how all AI coding agents behave.
 
-VERSION="2026.529.2"
+VERSION="2026.529.3"
 ROLL_HOME="${ROLL_HOME:-${HOME}/.roll}"
 ROLL_CONFIG="${ROLL_HOME}/config.yaml"
 ROLL_GLOBAL="${ROLL_HOME}/conventions/global"
@@ -3389,7 +3389,7 @@ _agent_argv() {
       fi
       case "$mode" in
         interactive) _AGENT_ARGV=("$_kimi_bin" "$prompt") ;;
-        *)           _AGENT_ARGV=("$_kimi_bin" --quiet -p "$prompt") ;;
+        *)           _AGENT_ARGV=("$_kimi_bin" -p "$prompt") ;;  # FIX-133: kimi-code 无 --quiet,-p 自带 auto 审批
       esac ;;
     deepseek)
       # deepseek has the same argv shape in both modes (positional prompt).
@@ -5954,6 +5954,10 @@ _write_runner_script() {
 _write_loop_runner_script() {
   local script_path="$1" project_path="$2" cmd="$3" log_path="$4"
   local active_start="${5:-10}" active_end="${6:-18}"
+  # FIX-134: skill md path. When set, the inner script rebuilds the agent
+  # command at runtime from the routed cycle agent; when empty it falls back to
+  # the baked command (backwards compatible with callers that omit it).
+  local skill_path="${7:-}"
   # FIX-054: terminal preference detection removed. Popup is hard-coded to
   # macOS Terminal.app; the 7th positional arg, if any, is ignored for
   # backwards compatibility with existing callers.
@@ -5985,6 +5989,15 @@ _write_loop_runner_script() {
     agent_cmd="${agent_cmd/--output-format stream-json/--output-format stream-json --add-dir \"\$WT\"}"
   fi
   local slug; slug=$(_project_slug "$project_path")
+  # FIX-134: emit a runtime command-builder line when skill_path is known, so
+  # the cycle agent is resolved live (routing-aware). Otherwise leave _CYCLE_CMD
+  # empty and the inner script uses the baked fallback command below.
+  local cycle_cmd_line
+  if [[ -n "$skill_path" ]]; then
+    cycle_cmd_line="_CYCLE_CMD=\$(_loop_cycle_agent_cmd \"${skill_path}\" \"\$CYCLE_AGENT\" \"\$WT\" 2>/dev/null || true)"
+  else
+    cycle_cmd_line="_CYCLE_CMD="
+  fi
   cat > "$inner_path" << INNER
 #!/bin/bash -l
 set -o pipefail
@@ -6476,10 +6489,15 @@ for _attempt in 1 2 3; do
       pkill -KILL -f "\$WT" 2>/dev/null
     } ) &
   _WATCHDOG_PID=\$!
+  ${cycle_cmd_line}
+  # FIX-134: prefer the runtime-rebuilt command (routing-aware); fall back to
+  # the baked command (project agent at \`roll loop on\` time) when empty.
   if [ -f "\$FMT" ]; then
-    ( cd "\$WT" && ${agent_cmd} ) | python3 "\$FMT"
+    if [ -n "\$_CYCLE_CMD" ]; then ( cd "\$WT" && eval "\$_CYCLE_CMD" ) | python3 "\$FMT"
+    else ( cd "\$WT" && ${agent_cmd} ) | python3 "\$FMT"; fi
   else
-    ( cd "\$WT" && ${agent_cmd} )
+    if [ -n "\$_CYCLE_CMD" ]; then ( cd "\$WT" && eval "\$_CYCLE_CMD" )
+    else ( cd "\$WT" && ${agent_cmd} ); fi
   fi
   _exit=\$?
   kill "\$_WATCHDOG_PID" 2>/dev/null
@@ -6939,7 +6957,7 @@ _install_launchd_plists() {
     local cmd; cmd=$(_agent_skill_cmd "${sd}/${skill}/SKILL.md" 2>/dev/null || echo "roll loop now")
 
     if [[ "$svc" == "loop" ]]; then
-      _write_loop_runner_script "$runner" "$project_path" "cd \"${project_path}\" && ${cmd}" "$log" "$active_start" "$active_end"
+      _write_loop_runner_script "$runner" "$project_path" "cd \"${project_path}\" && ${cmd}" "$log" "$active_start" "$active_end" "${sd}/${skill}/SKILL.md"
     else
       _write_runner_script "$runner" "$project_path" "cd \"${project_path}\" && ${cmd}" "$log"
     fi
@@ -6984,7 +7002,9 @@ _install_launchd_plists() {
 
 _agent_skill_cmd() {
   local skill_path="$1"
-  local agent; agent=$(_project_agent)
+  # FIX-134: accept an explicit agent (loop routing passes the resolved cycle
+  # agent); default to the project agent for non-routed callers.
+  local agent="${2:-$(_project_agent)}"
   local strip="awk 'NR==1 && /^---$/{skip=1;next} skip && /^---$/{skip=0;next} !skip{print}' '${skill_path}'"
   _agent_argv "$agent" plain "__PROMPT__" || {
     err "Unknown agent '${agent}'. Run: roll agent use <claude|kimi|deepseek|pi|openai|codex|opencode|qwen|gemini>"
@@ -7005,6 +7025,23 @@ _agent_skill_cmd() {
   echo "${out} \"\$(${strip})\""
 }
 
+# FIX-134: build the full per-cycle agent command at RUNTIME, routing-aware.
+# The loop inner script calls this with the resolved cycle agent (CYCLE_AGENT =
+# ROLL_LOOP_ROUTED_AGENT or project agent) so routing actually switches the
+# executed binary — instead of running a constant baked at `roll loop on` time.
+# Reproduces the claude-only verbose / stream-json / add-dir enhancements that
+# _write_loop_runner_script previously baked into the runner.
+_loop_cycle_agent_cmd() {
+  local skill_path="$1" agent="${2:-$(_project_agent)}" wt="${3:-$WT}"
+  [ -n "$skill_path" ] || return 1
+  local cmd; cmd=$(_agent_skill_cmd "$skill_path" "$agent") || return 1
+  cmd="${cmd/claude -p/claude -p --verbose --dangerously-skip-permissions --output-format stream-json}"
+  if [[ "$cmd" == *"--output-format stream-json"* ]]; then
+    cmd="${cmd/--output-format stream-json/--output-format stream-json --add-dir \"$wt\"}"
+  fi
+  printf '%s' "$cmd"
+}
+
 cmd_loop() {
   local subcmd="${1:-status}"; shift || true
   case "$subcmd" in

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@seanyao/roll",
-  "version": "2026.529.2",
+  "version": "2026.529.3",
   "description": "Roll — Roll out features with AI agents",
   "scripts": {
     "test": "bash tests/run.sh"

package/skills/roll-doc/SKILL.md

@@ -7,7 +7,7 @@ description: "Legacy project documentation automation. Scans all docs, builds/up
 
 # roll-doc
 
-Four-phase legacy documentation automation: scan → index → gap analysis → fill.
+Four-phase legacy documentation automation (plus deep-read Phase 3b): scan → index → gap analysis → fill (directory-level) → deep read (cross-directory topics).
 
 Works on any project root. No manual mode switching — reads the project state and decides what to do.
 
@@ -162,6 +162,70 @@ Only include lines for directories that already exist in the project.
 
 Do not fabricate details — infer only from source files actually read.
 
+## Phase 3b — Deep Read
+
+Deep-read phase that builds a full project symbol table (without truncation) and auto-detects
+cross-directory topics that directory-level Phase 3 alone cannot discover.
+
+**Trigger conditions** — Phase 3b runs when either is true:
+- Phase 2 found any gap (module or special gap)
+- The project exhibits code characteristics that Phase 3a cannot capture:
+  cross-directory import chains spanning ≥ 3 directories, state enums referenced by
+  multiple files, external URL/endpoint calls, or CI pipeline configuration files
+
+Pure documentation-only projects (no source code gaps, no code characteristics) skip Phase 3b.
+
+### Step 1 — Build Symbol Table
+
+Read every source file **in full** (no truncation). The existing Phase 3 "up to 20 source files"
+limit does not apply — Phase 3b builds a complete project symbol table for downstream topic
+detection to reason across files without missing logic.
+
+**Exclusion directories** (same as Phase 1):
+
+```
+node_modules/   .git/   dist/   build/   .shared/   .roll/dream/   .roll/briefs/
+```
+
+**Symbol table fields:**
+
+| Field | Content |
+|-------|---------|
+| `exports` | class / interface / type / function / const declarations, per file |
+| `imports` | source file → target file mapping (dependency graph edges) |
+| `enums` | enum declarations with enumerated values, per file |
+| `external_urls` | `fetch(...)` / `axios` / `http.*` calls, `API_ENDPOINT` / `*_URL` / `*_HOST` constants, hardcoded `https?://` strings (exclude comments and test fixtures) |
+| `configs` | CI workflow YAML files, build config paths, test framework config file paths |
+
+**`--dry-run` behavior:** print symbol table summary counts per category (e.g. "exports: 42, imports: 156, enums: 7, external_urls: 4, configs: 3") plus top-N examples per category. Write nothing to disk.
+
+**`--force` behavior:** unchanged — `--force` only affects draft generation (Phase 3/3b output files).
+The symbol table itself is rebuilt from scratch on every run regardless of flags.
+
+### Step 2 — Topic Detection
+
+Using the symbol table from Step 1, detect cross-directory topics. Each topic type has a
+detection rule and a target output file. Skip any topic whose target file already exists
+(unless `--force`). Skip any topic whose detection rule finds no matches.
+
+| Topic | Detection Rule | Output |
+|-------|---------------|--------|
+| 数据流 / 调用链 | Entry files (`bin/`, `cmd/`, `main.*`, `index.*`) → trace import chain to leaf nodes; require ≥ 1 chain spanning ≥ 3 directories | `docs/data-flows.md` |
+| 状态机 | Enums matching `*State` / `*Status` referenced by ≥ 2 source files | `docs/state-machines.md` |
+| 外部集成 | `external_urls` entries from symbol table (exclude comment/test-fixture matches) | `docs/integrations.md` |
+| 部署管线 | `.github/workflows/*.yml` / `.gitlab-ci.yml` / `circle.yml` / `Jenkinsfile` present, with deploy URL patterns detected | `docs/deployment.md` |
+| Agent 入口 (AGENTS.md) | Project root has no `AGENTS.md` AND `src/` (or equivalent source root) has ≥ 3 subdirectories | `AGENTS.md` |
+| 高引用目录 | Directory imported by ≥ 5 other source files, even if directory itself has < 3 source files | `<dir>/README.md` |
+
+### Step 3 — Source Annotations
+
+Every topic document generated in Step 2 must cite `file:line` for each claim (function call,
+endpoint URL, state transition, CI job, import path). Annotations must come from actual
+symbol table records — do not fabricate line numbers. Follows the same "Do not fabricate"
+rule as Phase 3.
+
+---
+
 ## Phase 4 — Report
 
 After all phases complete, output a summary:
@@ -181,6 +245,12 @@ Phase 3 — Fill
   N drafts generated: [list of paths]
   N skipped (already exist; use --force to regenerate)
 
+Phase 3b — Deep Read
+  Symbol table: exports(N) imports(N) enums(N) external_urls(N) configs(N)
+  N topic documents generated: [list of paths and types]
+  N topics skipped (no matches or already exist; use --force to regenerate)
+  (if no topics generated: "no subject-level drafts generated")
+
 📋 Review priority (largest / most active modules first):
   1. src/commands/README.md — 8 source files
   2. docs/CONVENTIONS.md — 6 patterns detected