@sealcode/sealgen 0.15.2 → 0.15.4

package/{dist → lib}/forms/multiform.test.js

@@ -72,7 +72,7 @@ function multiform_factory(canAccessFun1, canAccessFun2) {
 }
 async function tests(js_enabled) {
   let page;
-  beforeAll(async () => {
+  before(async () => {
     const browser = await getBrowser();
     const context = await browser.newContext({
       javaScriptEnabled: js_enabled
@@ -116,7 +116,7 @@ async function general_form_validation_e2e_tests(js_enabled) {
 async function individual_field_validation_e2e_tests(javaScriptEnabled) {
   let browser;
   let page;
-  beforeAll(async () => {
+  before(async () => {
     browser = await getBrowser();
     const context = await browser.newContext({
       javaScriptEnabled
@@ -142,7 +142,7 @@ async function individual_field_validation_e2e_tests(javaScriptEnabled) {
 describe("multiform test", () => {
   describe("basic tests", async () => {
     let server;
-    beforeAll(async () => {
+    before(async () => {
       const app = new Koa();
       const router = new Router();
       mount(
@@ -179,7 +179,7 @@ describe("multiform test", () => {
       app.use(router.routes()).use(router.allowedMethods());
       server = app.listen(port);
     });
-    afterAll(() => {
+    after(() => {
       server.close();
     });
     describe("turbolinks + js enabled", async () => tests(true));
@@ -189,7 +189,7 @@ describe("multiform test", () => {
     let page;
     let server;
     describe("allow access to both forms when both canAccess return true", async () => {
-      beforeAll(async () => {
+      before(async () => {
         const app = new Koa();
         const router = new Router();
         mount(
@@ -211,7 +211,7 @@ describe("multiform test", () => {
         const context = await browser.newContext();
         page = await context.newPage();
       });
-      afterAll(async () => {
+      after(async () => {
         server.close();
       });
       it("check wether it renders", async () => {
@@ -241,7 +241,7 @@ describe("multiform test", () => {
       });
     });
     describe("deny access to both forms", async () => {
-      beforeAll(async () => {
+      before(async () => {
         const app = new Koa();
         const router = new Router();
         mount(
@@ -263,7 +263,7 @@ describe("multiform test", () => {
         const context = await browser.newContext();
         page = await context.newPage();
       });
-      afterAll(async () => {
+      after(async () => {
         server.close();
       });
       it("check wether forms didnt render", async () => {
@@ -289,7 +289,7 @@ describe("multiform test", () => {
       });
     });
     describe("allow access to one form, deny to the other", async () => {
-      beforeAll(async () => {
+      before(async () => {
         const app = new Koa();
         const router = new Router();
         mount(
@@ -311,7 +311,7 @@ describe("multiform test", () => {
         const context = await browser.newContext({});
         page = await context.newPage();
       });
-      afterAll(async () => {
+      after(async () => {
         server.close();
       });
       it("check wether form1 renders", async () => {
@@ -359,7 +359,7 @@ describe("multiform test", () => {
   describe("validation e2e", async () => {
     describe("basic tests", async () => {
       let server;
-      beforeAll(async () => {
+      before(async () => {
         const app = new Koa();
         const router = new Router();
         mount(
@@ -417,7 +417,7 @@ describe("multiform test", () => {
         app.use(router.routes()).use(router.allowedMethods());
         server = app.listen(port);
       });
-      afterAll(async () => {
+      after(async () => {
         server.close();
       });
       it("js enabled", async () => general_form_validation_e2e_tests(true));
@@ -425,7 +425,7 @@ describe("multiform test", () => {
     });
     describe("field specific validation", async () => {
       let server;
-      beforeAll(async () => {
+      before(async () => {
         const app = new Koa();
         const router = new Router();
         const fields = {
@@ -478,7 +478,7 @@ describe("multiform test", () => {
         app.use(router.routes()).use(router.allowedMethods());
         server = app.listen(port);
       });
-      afterAll(async () => {
+      after(async () => {
         server.close();
       });
       describe("js enabled", async () => individual_field_validation_e2e_tests(true));

package/{dist → lib}/generate-components.js

@@ -14,7 +14,7 @@ async function generateComponents() {
   const component_data = component_names.map(
     (p) => "./" + path.relative(components_dir, p).replace(/\.[tj]sx?$/, ".js")
   ).map((relative_path) => {
-    const name = relative_path.match(/\/([^\/]+).jdd/)?.[1];
+    const name = relative_path.match(/\/([^/]+).jdd/)?.[1];
     return { name, relative_path };
   });
   const content = `// DO NOT EDIT! This file is generated automaticaly with 'npm run generate-components'

package/{dist → lib}/generate-routes.test.js

@@ -1,6 +1,7 @@
 import { generateURL } from "./generate-routes.js";
 import * as prettier from "prettier";
 import { getPrettierConfig } from "./utils/prettier.js";
+import assert from "node:assert";
 describe("generate routes", () => {
   it("handles a url with params", async () => {
     assert.strictEqual(

package/{dist → lib}/generate-stimulus.js

@@ -13,7 +13,7 @@ async function generateStimulusControllers() {
   const controller_data = controller_names.map(
     (p) => "./" + path.relative(target_locreq.resolve(dirname(output_file)), p).replace(/\.[tj]sx?$/, ".js")
   ).map((relative_path) => {
-    const name = relative_path.match(/\/([^\/]+).stimulus/)?.[1];
+    const name = relative_path.match(/\/([^/]+).stimulus/)?.[1];
     return { name, relative_path };
   });
   const content = `// DO NOT EDIT! This file is generated automaticaly with 'npm run generate-stimulus'

package/{dist → lib}/mount.js

@@ -1,3 +1,4 @@
+import { FileManager } from "@sealcode/file-manager";
 import { Middlewares as SealiousMiddlewares } from "sealious";
 async function handleHtmlPromise(ctx, next) {
   await next();
@@ -6,7 +7,7 @@ async function handleHtmlPromise(ctx, next) {
   }
   ctx.set("content-type", "text/html;charset=utf-8");
 }
-function mount(router, url, mountable, use_dummy_app = false) {
+function mount(router, url, mountable, use_dummy_app = false, file_manager = use_dummy_app ? new FileManager("/tmp", "/uploaded_files") : void 0) {
   const raw_url = typeof url === "string" ? url : url.rawURL;
   const args = use_dummy_app ? [
     async (ctx, next) => {
@@ -31,11 +32,11 @@ function mount(router, url, mountable, use_dummy_app = false) {
       };
       await next();
     },
-    SealiousMiddlewares.parseBody(),
+    SealiousMiddlewares.parseBody(file_manager),
     handleHtmlPromise
   ] : [
     SealiousMiddlewares.extractContext(),
-    SealiousMiddlewares.parseBody(),
+    SealiousMiddlewares.parseBody(file_manager),
     handleHtmlPromise
   ];
   router.use(raw_url, ...args);

package/{dist → lib}/notifier.js

@@ -10,7 +10,9 @@ function make_notifier(port) {
       sockets = sockets.filter((s) => s !== socket);
     });
   });
-  console.log("build notifier listening on websocket at port " + port);
+  console.log(
+    "build notifier listening on websocket at port " + port.toString()
+  );
   return function notify(message) {
     sockets.forEach((s) => s.send(message));
   };

package/{dist → lib}/page/list.js

@@ -40,7 +40,7 @@ class ListPage extends Page {
   init() {
     super.init();
     for (const [fieldname, field] of Object.entries(this.filterFields)) {
-      field.init(fieldname);
+      void field.init(fieldname);
     }
   }
   renderListContainer(_, content) {

package/{dist → lib}/page/mountable-with-fields.js

@@ -14,7 +14,7 @@ class MountableWithFields extends Mountable {
   }
   init() {
     for (const [name, field] of Object.entries(this.fields)) {
-      field.init(name);
+      void field.init(name);
     }
   }
   makeFormControlContext(ctx, data, validate, field_name_prefix = this.field_names_prefix, form_id = this.form_id) {

package/{dist → lib}/page/sealious-list.js

@@ -45,13 +45,13 @@ class SealiousItemListPage extends ListPage {
   async getFilterValues(ctx) {
     const query_params = qs.parse(ctx.search.slice(1));
     const _filter_values = query_params?.filter || {};
-    let filter_values = is(
+    const filter_values = is(
       _filter_values,
       predicates.record(predicates.string, predicates.string)
     ) ? _filter_values : {};
     return filter_values;
   }
-  async renderItem(_, item, index) {
+  async renderItem(_, item, _index) {
     return `<div>${item.id}</div>`;
   }
 }

package/{dist → lib}/page/stateful-page.js

@@ -3,6 +3,7 @@ import deepmerge from "deepmerge";
 import { tempstream } from "tempstream";
 import { from_base64, to_base64 } from "../utils/base64.js";
 import { Mountable } from "./mountable.js";
+import { isPlainObject } from "is-what";
 class StatefulPage extends Mountable {
   async canAccess() {
     return { canAccess: true, message: "" };
@@ -13,7 +14,8 @@ class StatefulPage extends Mountable {
     this.render = async (ctx, state, inputs) => {
       return this.wrapInLayout(
         ctx,
-        this.wrapInForm(
+        await this.wrapInForm(
+          ctx,
           state,
           await original_render(ctx, state, inputs)
         ),
@@ -21,12 +23,16 @@ class StatefulPage extends Mountable {
       );
     };
   }
-  wrapInForm(state, content) {
-    return tempstream`<form action="./" method="POST">
+  async wrapInForm(context, state, content) {
+    return tempstream`<form
+			action="./"
+			method="POST"
+			enctype="multipart/form-data"
+		>
 			<input
 				name="state"
 				type="hidden"
-				value="${to_base64(JSON.stringify(state))}"
+				value="${to_base64(await this.serializeState(context, state))}"
 			/>
 			${content}
 		</form>`;
@@ -52,7 +58,7 @@ class StatefulPage extends Mountable {
     )}`;
   }
   makeActionButton(_state, action_description, ...args) {
-    let { label, content } = this.extractActionAndLabel(action_description);
+    const { label, content } = this.extractActionAndLabel(action_description);
     return (
       /* HTML */
       `
@@ -78,10 +84,20 @@ class StatefulPage extends Mountable {
   async preprocessState(values) {
     return values;
   }
-  async preprocessOverrides(state, values) {
+  async preprocessOverrides(_state, values) {
     return values;
   }
+  async serializeState(_context, state) {
+    return JSON.stringify(state);
+  }
+  async deserializeState(_context, s) {
+    const deserialized = JSON.parse(s);
+    console.log("stateful-page.ts:183", "deserialized:");
+    console.dir(deserialized, { depth: 10 });
+    return deserialized;
+  }
   async extractState(ctx) {
+    console.log("stateful-page.ts:188", "EXTRACT STATE");
     if (!hasShape(
       {
         action: predicates.maybe(predicates.string),
@@ -100,7 +116,8 @@ class StatefulPage extends Mountable {
       )
     );
     const original_state_string = ctx.$body.state;
-    const original_state = JSON.parse(
+    const original_state = await this.deserializeState(
+      ctx,
       typeof original_state_string == "string" ? from_base64(original_state_string) : "{}"
     );
     const $body = ctx.$body;
@@ -110,6 +127,7 @@ class StatefulPage extends Mountable {
       state_overrides
     );
     let modified_state = deepmerge(original_state, state_overrides, {
+      isMergeableObject: isPlainObject,
       arrayMerge: (target, source, options) => {
         const destination = target.slice();
         source.forEach((item, index) => {
@@ -156,17 +174,16 @@ class StatefulPage extends Mountable {
     router.post(path, async (ctx) => {
       const { action, state, inputs, action_args } = await this.extractState(ctx);
       if (action) {
-        ctx.body = this.render(
-          ctx,
-          await this.actions[action](
-            state,
-            inputs,
-            ...JSON.parse(
-              from_base64(action_args)
-            )
-          ),
-          inputs
+        const new_state = await this.actions[action](
+          state,
+          inputs,
+          ...JSON.parse(
+            from_base64(action_args)
+          )
         );
+        console.log("stateful-page.ts:291", "new_state:");
+        console.dir(new_state, { depth: 10 });
+        ctx.body = this.render(ctx, new_state, inputs);
       } else {
         ctx.body = this.render(ctx, state, inputs);
       }

package/{dist → lib}/templates/jdd-component.js

@@ -3,7 +3,7 @@ function jddComponentTemplate(component_name) {
   return `import type { FlatTemplatable } from "tempstream";
 import { TempstreamJSX } from "tempstream";
 import type {
-	ExtractStructuredComponentArgumentsValues,
+	ExtractStructuredComponentArgumentsParsed,
 	JDDContext,
 } from "@sealcode/jdd";
 import { Component, ComponentArguments } from "@sealcode/jdd";
@@ -24,7 +24,7 @@ export class ${toPascalCase(
 		{
 			title,
 			content,
-		}: ExtractStructuredComponentArgumentsValues<typeof component_arguments>,
+		}: ExtractStructuredComponentArgumentsParsed<typeof component_arguments>,
 		{ render_markdown }: JDDContext
 	): FlatTemplatable {
 		return (

package/{dist → lib}/utils/extract-fields-from-collection.js

@@ -2,6 +2,7 @@ import _locreq from "locreq";
 import { exec } from "./utils.js";
 const target_locreq = _locreq(process.cwd());
 import { promises as fs } from "fs";
+import { is, predicates } from "@sealcode/ts-predicates";
 async function extract_fields_from_collection(collection_name) {
   const extractor_code = `import {default as the_app} from "./app.js";
 const c = new the_app().collections["${collection_name}"];
@@ -22,7 +23,21 @@ console.log(JSON.stringify(fields));
   await fs.writeFile(extractor_code_path, extractor_code);
   const { stdout } = await exec("node", [extractor_code_path]);
   await fs.unlink(extractor_code_path);
-  return JSON.parse(stdout);
+  const ret = JSON.parse(stdout);
+  if (!is(
+    ret,
+    predicates.array(
+      predicates.shape({
+        name: predicates.string,
+        type: predicates.string
+      })
+    )
+  )) {
+    throw new Error(
+      "Encountered a problem while extracting the names of fields from collection. Got: " + stdout
+    );
+  }
+  return ret;
 }
 export {
   extract_fields_from_collection as default

package/package.json

@@ -1,20 +1,23 @@
 {
 	"name": "@sealcode/sealgen",
-	"version": "0.15.2",
+	"version": "0.15.4",
 	"description": "Module to automate adding routes and collections to a sealious application",
-	"main": "dist/index.js",
+	"main": "lib/index.js",
 	"type": "module",
 	"scripts": {
+		"prebuild": "npm run lint && rm -rf lib",
 		"build": "node ./build.js",
+		"pretest": "npm run build",
+		"test": "node test.cjs",
 		"typecheck": "tsc --noemit",
-		"prepare": "rm -rf @types && npm run typecheck && tsc --emitDeclarationOnly && npm run build",
-		"watch": "npm run build -- --watch",
-		"test-cmd": "vitest --config ./src/vitest.config.ts",
-		"test-cmd-once": "vitest run --config ./src/vitest.config.ts",
-		"test": "npm run test-cmd -- --ui",
-		"coverage": "npm run test --coverage",
-		"test-reports": "rm -f .xunit && npm run test-cmd-once -- --coverage --reporter=junit --outputFile=.xunit",
-		"show-coverage": "npm run test-reports;  xdg-open coverage/index.html"
+		"prepare": "npm run build",
+		"lint": "eslint src",
+		"preinstrument": "npm run build && rm -fr .xunit coverage lib-instrumented",
+		"instrument": "npx nyc instrument --exclude \"\" lib lib-instrumented",
+		"pretest-reports": "npm run instrument",
+		"test-reports": "npx nyc  --exclude \"\" ./node_modules/.bin/mocha --recursive --timeout=10000 --require source-map-support/register  --reporter xunit --reporter-option output=.xunit 'lib-instrumented/**/*.test.js' --exit && nyc report --reporter clover --exclude \"\"",
+		"precover-html": "rm -rf coverate/lcov-report",
+		"cover-html": "npm run test-reports && nyc report --reporter lcov --exclude \"\"  && xdg-open coverage/lcov-report/index.html"
 	},
 	"bin": {
 		"sealgen": "./dist/cli.js"
@@ -25,15 +28,15 @@
 		"@playwright/test": "^1.30.0",
 		"@types/koa__router": "^12.0.4",
 		"@types/md5": "^2.3.5",
+		"@types/mocha": "^10.0.6",
 		"@types/node": "^20.8.4",
 		"@types/prettier": "^2.7.0",
 		"@types/prompts": "^2.0.14",
 		"@types/recursive-readdir": "^2.2.4",
 		"@types/ws": "^8.5.10",
 		"@types/yargs": "^17.0.32",
-		"@vitest/coverage-istanbul": "^1.1.0",
-		"@vitest/coverage-v8": "^1.1.0",
-		"@vitest/ui": "^1.1.0",
+		"@typescript-eslint/eslint-plugin": "^5.58.0",
+		"@typescript-eslint/parser": "^5.58.0",
 		"axios": "^1.6.7",
 		"eslint": "^7.32.0",
 		"eslint-config-prettier": "^8.3.0",
@@ -41,12 +44,13 @@
 		"eslint-plugin-with-tsc-error": "^0.0.7",
 		"get-port": "^5.1.1",
 		"koa-body": "^5.0.0",
+		"mocha": "^10.4.0",
+		"mri": "^1.2.0",
 		"nyc": "^15.1.0",
 		"playwright": "^1.29.2",
 		"source-map-support": "^0.5.21",
 		"ts-node": "^10.9.1",
 		"typescript": "^4.7",
-		"vitest": "^1.1.0",
 		"wait-port": "^1.0.4"
 	},
 	"types": "./@types/src/index.d.ts",
@@ -58,6 +62,7 @@
 		"esbuild": "^0.20.0",
 		"escape-goat": "^4.0.0",
 		"google-fonts-helper": "^3.4.1",
+		"is-what": "^4.1.16",
 		"js-convert-case": "^4.2.0",
 		"locreq": "^3.0.0",
 		"md5": "^2.3.0",
@@ -73,6 +78,6 @@
 	"peerDependencies": {
 		"koa": "^2.13.0",
 		"koa-responsive-image-router": "^0.2.24",
-		"sealious": "^0.19.6"
+		"sealious": "^0.19.7"
 	}
 }

package/src/add-route.test.ts

@@ -54,7 +54,7 @@ describe("add route test", () => {
 	it("creates minimal sealious app", async function () {
 		console.log("\tcloning sealious-minimal...");
 		await execAsync(
-			`git clone https://hub.sealcode.org/source/sealious-minimal.git ${app_path} && cd ${app_path} && git checkout 710b873`
+			`git clone https://hub.sealcode.org/source/sealious-minimal.git ${app_path} && cd ${app_path} && git checkout 5b33aac`
 		);
 		console.log("\tinstalling dependencies and sealgen...");
 		await execAsync(
@@ -102,5 +102,5 @@ describe("add route test", () => {
 		if (res.status != 200) {
 			throw new Error("url generated by add-route exists but doesnt return 200");
 		}
-	}, 250000);
+	});
 });

package/src/add-route.ts

@@ -21,7 +21,7 @@ export async function addRoute(
 			message: 'What\'s the name of the action (e.g. "AddUser"): ',
 			validate: (s: string) =>
 				s.length > 3 ? true : "Should be at least 3 characters long",
-			format: function (action) {
+			format: function (action: string) {
 				return toPascalCase(action);
 			},
 		},
@@ -32,7 +32,7 @@ export async function addRoute(
 				"Enter a full absolute path for the new route (for example: /admin/users/:id/edit): ",
 			validate: (s: string) =>
 				s.trim()[0] == "/" ? true : "Should start with a '/'",
-			initial: function (_, { action }) {
+			initial: function (_, { action }: { action: string }) {
 				return "/" + toKebabCase(action);
 			},
 		},

package/src/build.ts

@@ -45,19 +45,19 @@ async function build(watch: boolean): Promise<void> {
 		const port = await get_notifier_port();
 		const notifier = make_notifier(port);
 		await write_notifier_config(watch, port);
-		watcher.on("all", async (_, file_path) => {
+		watcher.on("all", (_, file_path) => {
 			console.log("Detected a change!", file_path);
 			builders.forEach((builder) => {
 				const owns_a_file = builder.ownsFile(file_path);
 				if (owns_a_file) {
-					builder.build(notifier);
+					void builder.build(notifier);
 				}
 			});
 		});
 	} else {
 		await write_notifier_config(watch);
 		builders.forEach((builder) => {
-			builder.dispose();
+			void builder.dispose();
 		});
 	}
 }

package/src/builder.ts

@@ -16,8 +16,6 @@ export abstract class Builder {
 	abstract _build(): Promise<void>;
 	abstract dispose(): Promise<void>;
 
-	constructor() {}
-
 	public ongoing_build: Promise<void> | null = null;
 
 	public build(notifier?: (message: string) => void) {
@@ -92,6 +90,7 @@ export class FontsBuilder extends Builder {
 		return file_path == FONTS_CONFIG_PATH;
 	}
 
+	// eslint-disable-next-line @typescript-eslint/no-empty-function
 	async dispose(): Promise<void> {}
 
 	async _build() {
@@ -115,6 +114,7 @@ export class BackendTSBuilder extends Builder {
 		);
 	}
 
+	// eslint-disable-next-line @typescript-eslint/no-empty-function
 	async dispose(): Promise<void> {}
 
 	async _build(): Promise<void> {
@@ -160,6 +160,7 @@ export class FrontendTSBuilder extends Builder {
 		);
 	}
 
+	// eslint-disable-next-line @typescript-eslint/no-empty-function
 	async dispose(): Promise<void> {}
 
 	async _build(): Promise<void> {

package/src/esbuild-plugins/load-assets.ts

@@ -5,6 +5,7 @@ import path, { basename } from "node:path";
 
 import _locreq from "locreq";
 import { embeddable_file_extensions } from "../embeddable-file-extensions.js";
+import { PluginBuild } from "esbuild";
 const target_locreq = _locreq(process.cwd());
 
 function addSuffix(filename: string, suffix: string) {
@@ -12,7 +13,7 @@ function addSuffix(filename: string, suffix: string) {
 }
 
 async function makeResourceURL(file_path: string) {
-	const hash_base = file_path + (await fs.stat(file_path)).mtimeMs;
+	const hash_base = file_path + (await fs.stat(file_path)).mtimeMs.toString();
 	const hash = md5(hash_base);
 	const public_url =
 		"dist/" + addSuffix(basename(file_path), "-" + hash.slice(0, 8));
@@ -26,15 +27,15 @@ async function makeResourceURL(file_path: string) {
 
 export const load_assets_plugin = {
 	name: "sealgen-load-assets",
-	setup(build: any) {
+	setup(build: PluginBuild) {
 		build.onLoad(
 			{
 				filter: new RegExp(
 					`\\.(${embeddable_file_extensions.join("|")})$`
 				),
 			},
-			async (args: any) => {
-				let contents = `export const url =  "${await makeResourceURL(
+			async (args) => {
+				const contents = `export const url =  "${await makeResourceURL(
 					args.path
 				)}";
 

package/src/esbuild-plugins/rewrite-asset-imports.ts

@@ -2,11 +2,12 @@ import { promises as fs } from "fs";
 import { extname } from "node:path";
 import { embeddable_file_extensions } from "../embeddable-file-extensions.js";
 import { removeNamedImports } from "../../remove-named-imports.js";
+import { PluginBuild } from "esbuild";
 
 export const rewrite_asset_imports_plugin = {
 	name: "sealgen-rewrite-asset-imports",
-	setup(build: any) {
-		build.onLoad({ filter: /\.tsx?$/ }, async (args: any) => {
+	setup(build: PluginBuild) {
+		build.onLoad({ filter: /\.tsx?$/ }, async (args) => {
 			let contents = await fs.readFile(args.path, "utf8");
 			for (const ext of embeddable_file_extensions) {
 				const regex_assets = new RegExp(
@@ -18,7 +19,7 @@ export const rewrite_asset_imports_plugin = {
 				});
 			}
 
-			contents = removeNamedImports(contents);
+			contents = removeNamedImports(contents) as string;
 
 			return {
 				contents,

package/src/forms/controls/array.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import Router from "@koa/router";
 import { hasShape, predicates } from "@sealcode/ts-predicates";
 import { Context } from "koa";
@@ -57,7 +58,6 @@ export class StructuredArray<
 	}
 
 	makeSubfield(_field_name: string): FormField {
-		const fields = this;
 		return new SimpleFormField(false);
 	}
 
@@ -77,6 +77,7 @@ export class StructuredArray<
 			validate: false,
 		};
 		if (Array.isArray(control)) {
+			// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 			const [constructor, field_name, params] = control;
 			const field = this.makeSubfield(field_name);
 			if (!field) {
@@ -173,13 +174,14 @@ export class StructuredArray<
 	}
 
 	async getTargetItemID(ctx: Context): Promise<string> {
-		return ctx.params.id;
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+		return ctx.params.id as string;
 	}
 
 	mount(router: Router) {
 		console.log("mounting!", this.getActionURL());
 		router.post(this.getActionURL(), async (ctx) => {
-			let form_id = ctx.query.form_id;
+			const form_id = ctx.query.form_id;
 			if (typeof form_id != "string") {
 				throw new Error("Missing form_id query param");
 			}