@sealcode/sealgen 0.15.19 → 0.15.21

package/@types/src/forms/controls/checkbox.d.ts

@@ -3,7 +3,9 @@ import { FormDataValue } from "../form-types.js";
 import { Tickable, TickableOptions } from "./tickable.js";
 import { FormField } from "../fields/field.js";
 export declare class Checkbox extends Tickable<boolean> {
+    field: FormField<boolean, boolean>;
     type: "checkbox";
+    constructor(field: FormField<boolean, boolean>, options?: Partial<TickableOptions<boolean>>);
     isChecked(_ctx: Context, _data: Record<string, FormDataValue>, value: boolean): boolean;
     getValueAttribute(): string;
 }

package/@types/src/forms/fields/collection-field.test.d.ts

@@ -0,0 +1 @@
+export {};

package/lib/forms/controls/checkbox.js

@@ -1,7 +1,11 @@
 import { Tickable } from "./tickable.js";
 class Checkbox extends Tickable {
-  constructor() {
-    super(...arguments);
+  constructor(field, options = {}) {
+    super(field, {
+      ...options,
+      default_value: options.default_value == void 0 ? false : options.default_value
+    });
+    this.field = field;
     this.type = "checkbox";
   }
   isChecked(_ctx, _data, value) {

package/lib/forms/fields/field.js

@@ -40,7 +40,7 @@ class FormField {
     if (raw == void 0 || raw == null || raw == "") {
       return {
         parsed: null,
-        message: "empty value",
+        message: this.required ? "empty value" : "",
         raw,
         ...validate ? { valid: !this.required } : {}
       };

package/lib/forms/fields/field.test.js

@@ -7,6 +7,8 @@ import { getBrowser } from "../../utils/browser-creator.js";
 import assert from "assert";
 import { SimpleFormField } from "./simple-form-field.js";
 import { SimpleInput } from "../controls/simple-input.js";
+import { Boolean } from "./boolean.js";
+import { Checkbox } from "../controls/checkbox.js";
 describe("basic field", () => {
   describe("basic tests", async () => {
     let server;
@@ -100,6 +102,44 @@ describe("basic field", () => {
       assert(is_value_valid_called == false);
       assert(parse_called == false);
     });
+    it("Accepts a form where non-required values are empty", async () => {
+      const port = await getPort();
+      console.log(`Using port ${port} form checkboxed-list-input.test.ts`);
+      const app = new Koa();
+      const router = new Router();
+      let submit_called = false;
+      const fields = {
+        text: new SimpleFormField(false),
+        checkbox: new Boolean(false)
+      };
+      mount(
+        router,
+        "/",
+        new class extends Form {
+          constructor() {
+            super(...arguments);
+            this.fields = fields;
+            this.controls = [new SimpleInput(fields.text), new Checkbox(fields.checkbox)];
+          }
+          async onSubmit() {
+            submit_called = true;
+          }
+          async canAccess(_) {
+            return { canAccess: true, message: "" };
+          }
+        }(),
+        true
+      );
+      app.use(router.routes()).use(router.allowedMethods());
+      server = app.listen(port);
+      browser = await getBrowser();
+      const context = await browser.newContext();
+      page = await context.newPage();
+      await page.goto(`http://localhost:${port}`);
+      await page.getByRole("button", { name: "Wy\u015Blij" }).click();
+      assert(submit_called, "onSubmit()  triggered");
+      await page.getByText("Done").click();
+    });
   });
 });
 //# sourceMappingURL=field.test.js.map

package/lib/forms/form.js

@@ -119,6 +119,7 @@ class Form extends MountableWithFields {
       raw_values
     );
     if (!valid) {
+      console.debug("Form values invalid: ", form_messages);
       return this.onValuesInvalid(ctx, form_messages, field_errors);
     }
     try {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@sealcode/sealgen",
-	"version": "0.15.19",
+	"version": "0.15.21",
 	"description": "Module to automate adding routes and collections to a sealious application",
 	"main": "lib/index.js",
 	"type": "module",

package/src/forms/controls/checkbox.ts

@@ -6,6 +6,19 @@ import { FormField } from "../fields/field.js";
 export class Checkbox extends Tickable<boolean> {
 	type = <const>"checkbox";
 
+	constructor(
+		public field: FormField<boolean, boolean>,
+		options: Partial<TickableOptions<boolean>> = {}
+	) {
+		super(field, {
+			...options,
+			default_value:
+				options.default_value == undefined
+					? false
+					: options.default_value,
+		});
+	}
+
 	isChecked(
 		_ctx: Context,
 		_data: Record<string, FormDataValue>,

package/src/forms/fields/field.test.ts

@@ -10,7 +10,8 @@ import assert from "assert";
 import { SimpleFormField } from "./simple-form-field.js";
 import { SimpleInput } from "../controls/simple-input.js";
 import { FormData } from "../form-types.js";
-import { Field } from "sealious";
+import { Boolean } from "./boolean.js";
+import { Checkbox } from "../controls/checkbox.js";
 
 describe("basic field", () => {
 	describe("basic tests", async () => {
@@ -116,5 +117,49 @@ describe("basic field", () => {
 			assert(is_value_valid_called == false);
 			assert(parse_called == false);
 		});
+
+		it("Accepts a form where non-required values are empty", async () => {
+			const port = await getPort();
+			console.log(`Using port ${port} form checkboxed-list-input.test.ts`);
+			const app = new Koa();
+			const router = new Router();
+
+			let submit_called = false;
+
+			const fields = {
+				text: new SimpleFormField(false),
+				checkbox: new Boolean(false),
+			};
+
+			mount(
+				router,
+				"/",
+				new (class extends Form<typeof fields, unknown> {
+					fields = fields;
+					controls = [new SimpleInput(fields.text), new Checkbox(fields.checkbox)];
+
+					async onSubmit() {
+						submit_called = true;
+						//noop
+					}
+
+					async canAccess(_: Context) {
+						return { canAccess: true, message: "" };
+					}
+				})(),
+				true
+			);
+			app.use(router.routes()).use(router.allowedMethods());
+			server = app.listen(port);
+
+			browser = await getBrowser();
+			const context = await browser.newContext();
+			page = await context.newPage();
+			await page.goto(`http://localhost:${port}`);
+			await page.getByRole("button", { name: "Wyślij" }).click();
+
+			assert(submit_called, "onSubmit()  triggered");
+			await page.getByText("Done").click();
+		});
 	});
 });

package/src/forms/fields/field.ts

@@ -130,7 +130,7 @@ export abstract class FormField<
 		if (raw == undefined || raw == null || raw == "") {
 			return {
 				parsed: null,
-				message: "empty value",
+				message: this.required ? "empty value" : "",
 				raw,
 				...(validate ? { valid: !this.required } : {}),
 			};

package/src/forms/form.ts

@@ -181,6 +181,7 @@ export abstract class Form<
 			raw_values
 		);
 		if (!valid) {
+			console.debug("Form values invalid: ", form_messages);
 			return this.onValuesInvalid(ctx, form_messages, field_errors);
 		}
 		try {