@se-studio/skills 1.9.16 → 1.9.18

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @se-studio/skills
 
+## 1.9.18
+
+### Patch Changes
+
+- 023c171: Shorten the customer code-review prompt to the diff under review. Agent rules live in `AGENTS.md` and `.cursor/rules`. Do not add a `.cursorrules` file.
+
+## 1.9.17
+
+### Patch Changes
+
+- d645ee4: Document both person URL shapes. The legacy generator uses `/peopleType/[peopleType]/[person]`. The section generator uses a static `/{peopleSlug}/{type}/[person]`.
+
 ## 1.9.16
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@se-studio/skills",
-  "version": "1.9.16",
+  "version": "1.9.18",
   "description": "SE Studio agent skills for marketing site development with Contentful CMS",
   "repository": {
     "type": "git",

package/references/agent-session/customer-agents-block.md

@@ -60,14 +60,14 @@ Never hand-edit `package.json` dependency versions.
 For visual/UI changes:
 
 1. **Early:** draft PR → Vercel preview → mobile (~390) + laptop (~1280) screenshots → **stop** for Nick’s visual review (iterate on feedback).
-2. **Full (after Nick is happy):** re-check tablet (~768), laptop (~1280), **oversize (~1920+)**, and mobile. Then multi-lens **code review** (`CODE_REVIEW.md`).
+2. **Full (after Nick is happy):** re-check tablet (~768), laptop (~1280), **oversize (~1920+)**, and mobile. Then follow `CODE_REVIEW.md` and stop.
 3. Do not chase pixel-perfect polish before the early gate.
 
 Non-UI changes skip visual gates and go to code review.
 
 ### Code review
 
-Before asking to merge to `develop`, run the multi-lens review in `CODE_REVIEW.md` (architecture, Next/React/Vercel, performance/size, docs consistency, general quality). Findings: **BLOCKER** / **NIT**.
+Before asking to merge to `develop`, run the review in `CODE_REVIEW.md` and stop. Findings: **BLOCKER** / **NIT**. Do not keep a second checklist in `AGENTS.md`. That file only points at `CODE_REVIEW.md`.
 
 ### Parallel features
 

package/references/agent-session/customer-architecture.mdc

@@ -54,5 +54,5 @@ Source of truth: `se-core-product` `docs/PHILOSOPHY.md`. Code review: `CODE_REVI
 
 - Keep smoke cases and discovery intact; fix `@se-studio/site-check` in core if smoke is wrong.
 - New behaviour needs a test. Failing typecheck/lint/tests blocks merge.
-- Agent multi-lens code review (`CODE_REVIEW.md`) before asking to merge to `develop`.
+- Follow `CODE_REVIEW.md` and stop. Do not run a second checklist from this file.
 - Production merges need human ask + confirm. Agents do not push production.

package/references/agent-session/customer-code-review.md

@@ -2,15 +2,22 @@
 
 Use this prompt when reviewing a **customer marketing site** PR (or when the user asks for a code review). Label every finding **BLOCKER** or **NIT**. Blockers first. Unclear judgement calls → flag to Nick in chat.
 
-Do **not** use Bugbot or a `nick-go` GitHub label. Merge to `develop` only when Nick says so in chat. Production still needs ask + confirm (`production-merge.md`).
+Do **not** use Bugbot or a `nick-go` GitHub label. Merge to `develop` only when Nick says so in chat, a review covers the current head SHA, and the PR has a `## Merge approval` comment. Production still needs ask + confirm (`production-merge.md`).
 
 Canonical architecture: `se-core-product` `docs/PHILOSOPHY.md`. Placement and handoffs: skill `site-workflows-agent-session`.
 
+## Scope
+
+- Review added and modified lines, plus call sites broken by a deleted or renamed symbol. Do not audit the rest of the repo.
+- A lens the diff cannot touch is one line: N/A.
+- Do not re-check Biome style or TypeScript strictness. The repo validate script already does.
+- A later review of the same PR reads only the diff since the SHA already reviewed.
+
 ---
 
 ## Multi-lens checklist
 
-Run all five lenses. Skip a lens only when the diff clearly cannot touch it (say so).
+Run a lens only when the diff can touch it.
 
 ### 1. Architecture / placement
 
@@ -38,7 +45,7 @@ Run all five lenses. Skip a lens only when the diff clearly cannot touch it (say
 
 ### 4. Docs consistency
 
-- [ ] AGENTS.md, `.cursorrules`, `src/project/*` docs, cms-edit packs, and READMEs match the behaviour change.
+- [ ] AGENTS.md, `src/project/*` docs, cms-edit packs, and READMEs match the behaviour change.
 - [ ] No leftover Bugbot / `nick-go` instructions contradicting chat-gated merge.
 - [ ] Site `docs/AGENT_PROCESS_NOTES.md` updated only for site-local process learnings (promote to core via “promote process note”).
 
@@ -96,3 +103,7 @@ Do not treat “pixel-perfect vs Figma” as a merge blocker before the early vi
 4. Open questions for Nick
 
 Out of scope: inventing product/design/copy changes; Netlify/Storybook check noise.
+
+## Design review
+
+When the diff is a new mechanism, analytics, a Contentful fetch or cache change, schema, or placement: post `## Design review` on the PR (PASS / BLOCKERS / N/A), separate from type-check and tests. Otherwise write N/A. The procedure is `docs/design-review.md` in se-core-product.

package/skills/coding-discipline/SKILL.md

@@ -224,7 +224,7 @@ For **app-level** components that render CMS content (Hero, CTA, etc.):
 
 ### Heading hierarchy
 
-Use `Element` from `getSizingInformation(index)` for the main heading of each component/collection; use `ChildElement` for headings of items inside a collection. Render **preHeading** and **postHeading** as `<p>` with a typography class, never as heading tags. See `.cursorrules` (Heading and pre/post rules) and the create-component skill.
+Use `Element` from `getSizingInformation(index)` for the main heading of each component/collection; use `ChildElement` for headings of items inside a collection. Render **preHeading** and **postHeading** as `<p>` with a typography class, never as heading tags. See the create-component skill.
 
 ### Fetching Contentful Data
 
@@ -375,7 +375,7 @@ When making changes, update the relevant documentation:
 - `specs/` - Content model and component specifications
 - `packages/*/README.md` - Package-specific docs (human-facing)
 - `packages/*/docs/llms.md` - LLM-optimised quick-reference per package (also published to npm)
-- `.cursorrules` - AI conventions (update if patterns change)
+- `AGENTS.md` - Agent operating rules (update if the workflow changes)
 
 ## Links
 

package/skills/se-marketing-sites-cms-routes-and-appshared/SKILL.md

@@ -31,10 +31,14 @@ export default function CmsRoutesLayout({ children }: { children: React.ReactNod
 | `/{slug1}/{slug2}/...` | `[level1]/[...slugs]/page.ts` | Multi-level pages |
 | `/articles/` | `articles/page.ts` | Articles index (uses ARTICLES_BASE) |
 | `/articles/{type}/` | `articles/[articleType]/page.ts` | Article type index |
-| `/articles/{type}/{tag}/` | `articles/[articleType]/[tag]/page.ts` | Article type + tag index. Only when that base sets `tagInPath: true`. Hand-written `generateArticleTypeTag*` page. |
+| `/articles/{type}/{tag}/` | `articles/[articleType]/[tag]/page.ts` | Article type + tag index. Generated when that base sets `tagInPath: true`. |
 | `/articles/{type}/{tag}/{article}/` | `articles/[articleType]/[tag]/[...slugs]/page.ts` | Individual article with a tag segment. Same `tagInPath` rule. |
 | `/tags/`, `/tags/{tag}/` | `tags/` | Tag index when `tags: true` |
-| `/people/`, `/people/{person}/` | `people/` | People (if enabled) |
+| `/people/` | `people/page.ts` | People index when `personBases[].index` is on |
+| `/people/{person}/` | `people/[person]/page.ts` | Legacy person with no person type. No redirect to the typed URL |
+| `/peopleType/{peopleType}/{person}/` | `peopleType/[peopleType]/[person]/page.ts` | Legacy person with a person type. The type segment is dynamic so it does not sit beside `people/[person]` |
+| `/{peopleSlug}/{type}/`, `/{peopleSlug}/{type}/{person}/` | `{peopleSlug}/{type}/page.ts`, `{peopleSlug}/{type}/[person]/page.ts` | Section generator. The type segment is the person type slug, not `[peopleType]`. With no person prefix the folders are `/{type}/` and `/{type}/[person]/` |
+| `/people/{type}/`, `/people/{type}/{person}/` | `people/{type}/` | Extra folders for each name in `personBases[].types` |
 
 Base paths come from `@/lib/constants` (e.g. ARTICLES_BASE = `/learning-hub` or `/articles`).
 
@@ -99,7 +103,7 @@ export default async function (props: PageProps<'/[level1]'>) {
 }
 ```
 
-A dynamic `articles` route uses `converterContext.urlCalculators` (`article`, `articleType`, `articleTypeTag`). Import `converterContext` from `@/lib/converter-context` when that module exists (so route files don't pull in cms-server); otherwise from `@/lib/cms-server`. A fixed article folder, and a dynamic base whose path is not `articles`, passes the path of that file (`/work/`, `/work/${articleSlug}/`). `article()` prefixes `ARTICLES_BASE` and, when primary tags are on, inserts `other`. That is a different URL from the file that was written. The generator does this. Hand-written `[tag]` pages still use `articleTypeTag`.
+A dynamic `articles` route uses `converterContext.urlCalculators` (`article`, `articleType`, `articleTypeTag`). Import `converterContext` from `@/lib/converter-context` when that module exists (so route files don't pull in cms-server); otherwise from `@/lib/cms-server`. A fixed article folder, and a dynamic base whose path is not `articles`, passes the path of the file that was written (`/work/`, `/work/${articleSlug}/`). `article()` prefixes `ARTICLES_BASE` and, when primary tags are on, inserts `other`. That is a different URL from the file that was written. The generator writes `[tag]` pages with `articleTypeTag` when `tagInPath` is true. Feature flags live in `marketing-routes.json` and `src/generated/marketing-flags.ts`. The legacy generator writes a typed person at `/peopleType/${peopleType}/${slug}/`. The section generator writes a static `/${peopleSlug}/${type}/${slug}/`, or `/${type}/${slug}/` when there is no person prefix. A person with no type is `/${peopleSlug}/${slug}/`. Neither route redirects to the other. `[level1]` stays a generic page.
 
 ## See Also
 

package/skills/se-marketing-sites-lib-cms-structure/SKILL.md

@@ -41,12 +41,10 @@ export const customerName = '...';
 export const applicationName = '...';
 export const siteTitle = '...';
 export const siteDescription = '...';
-export const enablePerson = false;
-export const enablePeopleIndex = false;
-export const enableTag = false;
-export const enableTagsIndex = false;
 ```
 
+`enablePerson`, `enablePeopleIndex`, `enableTag`, `enableTagsIndex`, `enableArticleTypeIndex`, `enableArticleTypeTagIndex`, and `enablePrimaryTagPartOfSlug` live in `src/lib/marketing-routes.json`. `scripts/generate-marketing-routes.mjs` writes `src/generated/marketing-flags.ts`.
+
 ## Data Flow
 
 ```

package/skills/site-workflows-agent-session/SKILL.md

@@ -272,7 +272,7 @@ Re-check the same Vercel preview at least at:
 | Laptop | ~1280 |
 | **Oversize / wide desktop** | **~1920+** |
 
-Flag layout blowouts, overflow, sparse/stretched heroes, broken grids, and type that does not scale. Attach screenshots to chat/PR, then proceed to **multi-lens code review**.
+Flag layout blowouts, overflow, sparse/stretched heroes, broken grids, and type that does not scale. Attach screenshots to chat/PR, then follow the review file and stop (`CODE_REVIEW_PROMPT.md` on core, `CODE_REVIEW.md` on a customer site).
 
 Non-UI changes skip visual phases and go to code review.
 
@@ -284,12 +284,12 @@ When placement says **core** (or the site is blocked on package behaviour): emit
 
 ### Code review (replaces Bugbot)
 
-Before asking to merge to `dev` / `develop`:
+Before asking to merge to `dev` / `develop`, follow the review file and stop. Do not restate its checklist here.
 
-- **Core:** follow root [`CODE_REVIEW_PROMPT.md`](../../../../CODE_REVIEW_PROMPT.md)
-- **Customer:** follow [`customer-code-review.md`](../../references/agent-session/customer-code-review.md) (copied into the site as `CODE_REVIEW.md`)
+- **Core:** [`CODE_REVIEW_PROMPT.md`](../../../../CODE_REVIEW_PROMPT.md)
+- **Customer:** [`customer-code-review.md`](../../references/agent-session/customer-code-review.md) (copied into the site as `CODE_REVIEW.md`)
 
-Lenses: architecture/placement, Next/React/Vercel, performance/size, docs consistency, general quality. Findings: **BLOCKER** / **NIT**. No Bugbot; no `nick-go` label — Nick approves merges to integration branches **in chat**.
+Findings: **BLOCKER** / **NIT**. No Bugbot; no `nick-go` label — Nick approves merges to integration branches **in chat**.
 
 ### Process feedback
 
@@ -331,7 +331,7 @@ Agents must **never** ship from a registry `productionPath` (e.g. HSD `~/source/
 gh pr create --base <integration-branch> --head <branch> --draft --title "<feature>: <summary>"
 ```
 
-Before asking to merge the draft: complete visual gates (if UI) and multi-lens code review.
+Before asking to merge the draft: complete visual gates (if UI) and the review in that file.
 
 If `gh` is unavailable or user prefers direct push, push `feature/*` and note the remote URL in handoff.
 

package/skills/site-workflows-contentful-vercel-setup/SKILL.md

@@ -390,7 +390,7 @@ Expected: `200 OK`. A `401` means the secret in the header doesn't match the dep
 
 ## What to do next
 
-- **If inspector mode doesn't highlight fields**: check that `getPreviewFieldProps` is applied to field containers in the components. See `.cursorrules` for the pattern.
+- **If inspector mode doesn't highlight fields**: check that `getPreviewFieldProps` is applied to field containers in the components. See the create-component skill.
 - **For draft content visibility**: set `DRAFT_ONLY=true` in Vercel on a preview/staging environment (not production) so editors can see unpublished content without affecting live users.
 
 ## (Optional) Redirects via the rebuild pattern

package/skills/site-workflows-new-project/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: site-workflows-new-project
-description: "Bootstrap a new SE Studio customer project from the SE Studio template. Runs full project cleanup (black/white colors, system font, minimal registrations), then sets up CLAUDE.md, AGENTS.md, README files, STYLING.md, ANIMATION.md, and updates project identity (site title, description, .cursorrules). Use this immediately after cloning the template for a new client."
+description: "Bootstrap a new SE Studio customer project from the SE Studio template. Runs full project cleanup (black/white colors, system font, minimal registrations), then sets up CLAUDE.md, AGENTS.md, README files, STYLING.md, ANIMATION.md, and updates project identity (site title, description). Use this immediately after cloning the template for a new client."
 ---
 
 # SE New Project Bootstrap
@@ -92,8 +92,6 @@ In `src/project/components/Footer/index.tsx`, replace `"Site Name"` with the cus
 Write `CLAUDE.md` at the project root:
 
 ```markdown
-@.cursorrules
-
 @AGENTS.md
 ```
 
@@ -113,9 +111,7 @@ Also copy:
 | [`customer-code-review.md`](../../references/agent-session/customer-code-review.md) | `CODE_REVIEW.md` (repo root) |
 | Starter notes | `docs/AGENT_PROCESS_NOTES.md` (see [`process-feedback.md`](../../references/agent-session/process-feedback.md)) |
 
-Do **not** create `.cursor/BUGBOT.md`. Do **not** require a `nick-go` label.
-
-Wire `.cursorrules` so “when the user asks for a code review” points at `CODE_REVIEW.md`.
+Do **not** create `.cursor/BUGBOT.md`. Do **not** create `.cursorrules`. Do **not** require a `nick-go` label.
 
 Skeleton:
 
@@ -161,15 +157,9 @@ Before any Contentful content edit:
 
 ---
 
-## Step 7 — Update `.cursorrules`
-
-Read `.cursorrules` and update the **Project Overview** section at the top:
-- Replace the previous project name with the new customer/project name
-- Update the "Key technologies" list if anything changed
-- Remove any project-specific notes about the previous customer
-- Ensure code-review instructions point to `CODE_REVIEW.md` (not Bugbot)
+## Step 7 — Do not add `.cursorrules`
 
-Do not change the Code Style, Component Architecture, or other generic sections — those apply to all SE Studio projects.
+Operating rules are `AGENTS.md`. Architecture gates are `.cursor/rules/architecture.mdc`. Code review is `CODE_REVIEW.md`. If the template still has a `.cursorrules` file, delete it.
 
 ---