@sdsrs/code-graph 0.45.3 → 0.46.0

package/claude-plugin/.claude-plugin/plugin.json

@@ -4,7 +4,7 @@
   "author": {
     "name": "sdsrs"
   },
-  "version": "0.45.3",
+  "version": "0.46.0",
   "keywords": [
     "code-graph",
     "ast",

package/claude-plugin/scripts/doctor.js

@@ -206,19 +206,28 @@ function runDiagnostics() {
   try {
     const settings = readJson(settingsPath()) || {};
     const cov = surveyHookCoverage(settings);
-    if (cov.missing.length === 0) {
+    if (cov.missing.length === 0 && cov.stale.length === 0) {
       results.push({
         name: 'Hook coverage',
         status: 'ok',
         detail: `settings.json has all ${cov.expected.length} expected entries`,
       });
-    } else {
+    } else if (cov.missing.length > 0) {
       results.push({
         name: 'Hook coverage',
         status: 'warn',
         detail: `missing ${cov.missing.length}/${cov.expected.length} settings.json entries: ${cov.missing.join(', ')}`,
         fixId: 'missing-hooks-in-settings',
       });
+    } else {
+      // Present but stale path(s) — re-register rewrites them to the current
+      // version. A stale PreToolUse hook can keep the conversion metric dark.
+      results.push({
+        name: 'Hook coverage',
+        status: 'warn',
+        detail: `${cov.stale.length}/${cov.expected.length} settings.json entries point at a stale path (re-register to current version): ${cov.stale.join(', ')}`,
+        fixId: 'missing-hooks-in-settings',
+      });
     }
   } catch { /* probe failed — skip */ }
 
@@ -230,26 +239,42 @@ function runDiagnostics() {
 function surveyHookCoverage(settings) {
   const desired = buildSettingsHookEntries();
   const expected = [];
+  const desiredCmd = {}; // key -> command string we would write now
   for (const [event, entries] of Object.entries(desired)) {
     for (const e of entries) {
-      expected.push(`${event}:${e.matcher || '*'}`);
+      const key = `${event}:${e.matcher || '*'}`;
+      expected.push(key);
+      desiredCmd[key] = e.hooks && e.hooks[0] && e.hooks[0].command;
     }
   }
 
   const present = new Set();
+  const presentCmd = {}; // key -> command currently registered
   if (settings && settings.hooks) {
     for (const [event, entries] of Object.entries(settings.hooks)) {
       if (!Array.isArray(entries)) continue;
       for (const entry of entries) {
         if (isOurHookEntry(entry)) {
-          present.add(`${event}:${entry.matcher || '*'}`);
+          const key = `${event}:${entry.matcher || '*'}`;
+          present.add(key);
+          if (entry.hooks && entry.hooks[0] && entry.hooks[0].command) {
+            presentCmd[key] = entry.hooks[0].command;
+          }
         }
       }
     }
   }
 
   const missing = expected.filter(k => !present.has(k));
-  return { expected, present: [...present], missing };
+  // Stale = present but the registered command no longer matches what we'd write
+  // now (points at an old plugin-cache version dir / moved path). A stale path can
+  // run pre-recordRecommendation hook code, so the hook fires but the conversion
+  // metric stays dark — invisible to a present/absent check. This is the
+  // 0.45.1-registered-while-0.45.4-active case the RCA surfaced.
+  const stale = expected.filter(k =>
+    present.has(k) && desiredCmd[k] && presentCmd[k] && presentCmd[k] !== desiredCmd[k]
+  );
+  return { expected, present: [...present], missing, stale };
 }
 
 // ── Report Formatting ─────────────────────────────────────
@@ -449,7 +474,7 @@ function runDoctor(opts = {}) {
   return { results, issueCount: issues.length };
 }
 
-module.exports = { runDiagnostics, formatReport, runRepairs, runDoctor };
+module.exports = { runDiagnostics, formatReport, runRepairs, runDoctor, surveyHookCoverage };
 
 if (require.main === module) {
   const args = process.argv.slice(2);

package/claude-plugin/scripts/doctor.test.js

@@ -2,7 +2,18 @@
 const test = require('node:test');
 const assert = require('node:assert/strict');
 
-const { runDiagnostics, formatReport } = require('./doctor');
+const { runDiagnostics, formatReport, surveyHookCoverage } = require('./doctor');
+const { buildSettingsHookEntries } = require('./lifecycle');
+
+// Build a settings.json whose hooks exactly mirror what we'd register now.
+function settingsWithCurrentHooks() {
+  const desired = buildSettingsHookEntries();
+  const hooks = {};
+  for (const [event, entries] of Object.entries(desired)) {
+    hooks[event] = entries.map(e => JSON.parse(JSON.stringify(e)));
+  }
+  return { hooks };
+}
 
 test('runDiagnostics returns an array of check results', () => {
   const results = runDiagnostics();
@@ -45,3 +56,27 @@ test('formatReport shows all-clear when no problems', () => {
   const output = formatReport(results);
   assert.ok(output.includes('All checks passed') || output.includes('0 issues'));
 });
+
+test('surveyHookCoverage reports clean when all entries are current', () => {
+  const cov = surveyHookCoverage(settingsWithCurrentHooks());
+  assert.equal(cov.missing.length, 0, 'no missing entries');
+  assert.equal(cov.stale.length, 0, 'no stale entries');
+});
+
+test('surveyHookCoverage flags a present-but-stale hook path', () => {
+  const settings = settingsWithCurrentHooks();
+  // Repoint one PreToolUse entry at an old plugin-cache version dir — present,
+  // recognized as ours (description unchanged), but command no longer current.
+  const bash = settings.hooks.PreToolUse.find(e => e.matcher === 'Bash');
+  bash.hooks[0].command = bash.hooks[0].command.replace('/scripts/', '/0.0.1-old/scripts/');
+  const cov = surveyHookCoverage(settings);
+  assert.equal(cov.missing.length, 0, 'entry is present, not missing');
+  assert.ok(cov.stale.includes('PreToolUse:Bash'),
+    `stale Bash path should be flagged; got stale=${JSON.stringify(cov.stale)}`);
+});
+
+test('surveyHookCoverage flags missing entries when settings empty', () => {
+  const cov = surveyHookCoverage({});
+  assert.ok(cov.missing.length === cov.expected.length, 'all expected entries missing');
+  assert.equal(cov.stale.length, 0, 'nothing present to be stale');
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sdsrs/code-graph",
-  "version": "0.45.3",
+  "version": "0.46.0",
   "description": "MCP server that indexes codebases into an AST knowledge graph with semantic search, call graph traversal, and HTTP route tracing",
   "license": "MIT",
   "repository": {
@@ -35,10 +35,10 @@
     "node": ">=16"
   },
   "optionalDependencies": {
-    "@sdsrs/code-graph-linux-x64": "0.45.3",
-    "@sdsrs/code-graph-linux-arm64": "0.45.3",
-    "@sdsrs/code-graph-darwin-x64": "0.45.3",
-    "@sdsrs/code-graph-darwin-arm64": "0.45.3",
-    "@sdsrs/code-graph-win32-x64": "0.45.3"
+    "@sdsrs/code-graph-linux-x64": "0.46.0",
+    "@sdsrs/code-graph-linux-arm64": "0.46.0",
+    "@sdsrs/code-graph-darwin-x64": "0.46.0",
+    "@sdsrs/code-graph-darwin-arm64": "0.46.0",
+    "@sdsrs/code-graph-win32-x64": "0.46.0"
   }
 }