@sdsrs/code-graph 0.139.0 → 0.140.0

package/claude-plugin/.claude-plugin/plugin.json

@@ -4,7 +4,7 @@
   "author": {
     "name": "sdsrs"
   },
-  "version": "0.139.0",
+  "version": "0.140.0",
   "keywords": [
     "code-graph",
     "ast",

package/claude-plugin/scripts/find-binary.js

@@ -33,6 +33,34 @@ function pathProbeTimeoutMs(remaining = require('./hook-fail-open').remainingMs)
   const ms = left === null ? PATH_PROBE_MIN_MS : Math.floor(left);
   return Math.max(ms, PATH_PROBE_MIN_MS);
 }
+
+// `readBinaryVersion`'s own default. Kept here as the number this module asks
+// for so the clamp below is expressed against the same figure the callee would
+// have used on its own.
+const VERSION_PROBE_TIMEOUT_MS = 5000;
+
+/**
+ * How long ONE `--version` probe in the discovery chain may run (JS-23, audit
+ * 2026-09-07).
+ *
+ * The version gate execs the candidate binary, and `findBinary()` walks up to
+ * six candidates — so a chain of default 5 s probes is 30 s of children on the
+ * first thing every hook does, all of it BEFORE the hook has consulted its
+ * budget even once. Cold cache (first install, a version bump,
+ * `auto-update.clearCache()`) is exactly when the chain is longest and every
+ * candidate is a cold page-in.
+ *
+ * Same shape and the same two edges as `pathProbeTimeoutMs`: never 0 (node
+ * reads `timeout: 0` as no timeout), never fractional (ERR_OUT_OF_RANGE, which
+ * `readBinaryVersion`'s catch would report as "no version" → a good binary
+ * judged stale). With no deadline armed — doctor, statusline, the launcher —
+ * it returns the unchanged 5 s default.
+ */
+function versionProbeTimeoutMs(remaining = require('./hook-fail-open').remainingMs) {
+  const left = remaining(VERSION_PROBE_TIMEOUT_MS);
+  const ms = left === null ? PATH_PROBE_MIN_MS : Math.floor(left);
+  return Math.max(ms, PATH_PROBE_MIN_MS);
+}
 const PLATFORM_PKG = `@sdsrs/code-graph-${PLATFORM}-${ARCH}`;
 
 /**
@@ -129,9 +157,13 @@ function globalNodeModulesCandidates() {
 
   // 4. Last resort: ask npm directly. Slow (~50-200ms) but most accurate when
   //    user has a non-standard prefix. Cached at the disk-cache layer above.
+  // Budget-aware like the sibling probes in this file (JS-23 / pre-ship review
+  // 2026-09-07): this runs on the same `findBinaryUncached()` chain, and every
+  // hook calls `findBinary()` before it consults its own budget. `remainingMs`
+  // returns the default unchanged when nothing armed a deadline.
   try {
     const npm = npmInvocation(['root', '-g'], {
-      timeout: 2000,
+      timeout: pathProbeTimeoutMs(),
       stdio: ['pipe', 'pipe', 'pipe'],
       encoding: 'utf8',
     });
@@ -186,7 +218,9 @@ function isCachedBinaryFresh(cachedPath, pkgVersion, knownVersion) {
   // `knownVersion` lets the caller skip the `--version` spawn when the cache
   // entry already recorded it AND the file has not changed since — see
   // `readCacheEntry`. Absent, behaviour is exactly as before.
-  const cacheVer = knownVersion || readBinaryVersion(cachedPath);
+  // Clamped: this fires whenever the cache stamp mismatches — i.e. right after
+  // an auto-update, on the hook path (JS-23 / pre-ship review 2026-09-07).
+  const cacheVer = knownVersion || readBinaryVersion(cachedPath, { timeoutMs: versionProbeTimeoutMs() });
   if (!cacheVer) return true;
   return compareVersions(cacheVer, pkgVersion) >= 0;
 }
@@ -243,7 +277,9 @@ function writeCacheEntry(binPath) {
       CACHE_FILE,
       JSON.stringify({
         path: binPath,
-        version: readBinaryVersion(binPath) || null,
+        // Clamped: this is on the COLD-CACHE path, which is exactly the case
+        // JS-23 is about (pre-ship review 2026-09-07).
+        version: readBinaryVersion(binPath, { timeoutMs: versionProbeTimeoutMs() }) || null,
         stamp: binaryStamp(binPath),
       })
     );
@@ -396,13 +432,19 @@ function findPlatformBinary() {
  * gracefully on a slightly-old binary than on "offline", and the stale-binary
  * self-heal in auto-update.js re-downloads shortly anyway.
  */
-function createVersionGate(pkgVersion, { readVersion = readBinaryVersion } = {}) {
+function createVersionGate(
+  pkgVersion,
+  { readVersion = readBinaryVersion, probeTimeoutMs = versionProbeTimeoutMs } = {},
+) {
   let bestStale = null;
   return {
     consider(bin) {
       if (!isNativeBinary(bin)) return null;
       if (!pkgVersion) return bin;
-      const ver = readVersion(bin);
+      // Re-read per candidate, not once for the gate: the budget shrinks as the
+      // chain walks, and the point is that candidate six cannot still ask for a
+      // fresh 5 s (JS-23).
+      const ver = readVersion(bin, { timeoutMs: probeTimeoutMs() });
       if (!ver || compareVersions(ver, pkgVersion) >= 0) return bin;
       if (!bestStale || compareVersions(ver, bestStale.ver) > 0) bestStale = { bin, ver };
       return null;
@@ -554,6 +596,7 @@ module.exports = {
   detectLibc, unsupportedPlatformHint,
   CACHE_FILE, BINARY_NAME, PLATFORM_PKG,
   pathProbeTimeoutMs, PATH_PROBE_TIMEOUT_MS, PATH_PROBE_MIN_MS,
+  versionProbeTimeoutMs, VERSION_PROBE_TIMEOUT_MS,
 };
 
 // Allow direct invocation for testing

package/claude-plugin/scripts/lifecycle.js

@@ -1616,8 +1616,18 @@ function uninstall({ purgeGlobal = false, unadoptAll = false, runNpm = defaultRu
     }
   }
 
-  // 6. Remove cache directory
-  try { fs.rmSync(CACHE_DIR, { recursive: true, force: true }); } catch { /* ok */ }
+  // 6. Remove cache directory — through `removeCacheResidue()`, not a bare
+  // rmSync (JS-17, audit 2026-09-07). Without `--unadopt-all` the sweep above
+  // does not run, so the registry is still NON-EMPTY here and a wholesale wipe
+  // strands every managed block — while step 8's own guidance, and `cli.js`,
+  // tell the user their next move is `--unadopt-all`, which then reads an
+  // absent registry and reports nothing to clean. `adoptedProjects` was
+  // captured at 5.5 for the RETURN value; that capture never protected the
+  // file. With `--unadopt-all` the sweep leaves the registry empty (or holding
+  // only projects whose CLAUDE.md could not be rewritten, which is exactly what
+  // must survive), and `removeCacheResidue` preserves only a non-empty one, so
+  // the clean case still leaves nothing behind.
+  try { removeCacheResidue(); } catch { /* ok */ }
 
   // 6.5. The shared tmp dir (cooldown flags, read-fanout state, interrupted
   // `update-*` staging). Nothing in it outlives an uninstall, and the periodic
@@ -1954,12 +1964,14 @@ function isPluginUninstalled(settings = readJson(settingsPath()) || {}) {
 // of which repos carry a managed CLAUDE.md block. Wiping it strands every block
 // — `uninstall({unadoptAll:true})` afterwards reads an empty registry, reports
 // `unadopted: []`, and the blocks stay in the user's repos with nothing left
-// that knows where they are. `uninstall()` captures the list before calling
-// here; `cleanupDisabledStatusline` does not, and by this function's own comment
-// that is the ONE path guaranteed to run after `/plugin uninstall`. So the
-// preservation belongs here, at the wipe, rather than at each caller — the same
-// "fix it at the shared layer, not per surface" the <external> query filter
-// needed.
+// that knows where they are. No caller can be trusted to protect it first:
+// `cleanupDisabledStatusline` cannot (it is the ONE path guaranteed to run after
+// a CC `/plugin uninstall`, and it has no list), and `uninstall()` did not —
+// it captured the list for its RETURN value and then wiped the file with a bare
+// rmSync, which is the JS-17 data loss (audit 2026-09-07); it routes through
+// here now. So the preservation belongs here, at the wipe, rather than at each
+// caller — the same "fix it at the shared layer, not per surface" the
+// <external> query filter needed.
 function removeCacheResidue() {
   // Path comes from adopt.js rather than a second spelling of the basename —
   // a literal here would silently stop matching the day adopt.js renames it,

package/claude-plugin/scripts/user-prompt-context.js

@@ -8,6 +8,21 @@
 // would swallow the test's own failures.
 if (require.main === module) require('./hook-fail-open').installHookFailOpen('UserPromptSubmit');
 
+// Default per-child allowance, spent through the hook budget below.
+const CHILD_TIMEOUT_MS = 3000;
+
+/**
+ * How long ONE child of this hook may run: the default when nothing armed a
+ * deadline (a test importing this module), or whatever is LEFT of the
+ * UserPromptSubmit budget. `null` means the budget is exhausted — do not run.
+ *
+ * Exported so the three states are testable; `run()` below is a closure over
+ * the resolved binary and cannot be reached from a test (JS-18).
+ */
+function childBudgetMs() {
+  return require('./hook-fail-open').remainingMs(CHILD_TIMEOUT_MS);
+}
+
 // UserPromptSubmit hook: inject relevant code-graph RESULTS based on user's intent.
 // Strategy: PUSH structural context (not suggestions) that Grep/Read cannot provide.
 // This is a CODE INDEX — only inject structural code context (impact, overview, callgraph).
@@ -518,9 +533,18 @@ function runMain() {
   if (!binary) return;
 
   function run(args) {
+    // JS-18 (audit 2026-09-07): spend the UserPromptSubmit budget, don't ask
+    // for a fresh 3 s. This file armed a deadline at line 1 and then never
+    // consulted it — the literal here plus the `findBinary()` chain above ran
+    // outside it, so a cold cache had the hook killed by Claude Code and the
+    // user saw a hook error on THEIR prompt. `null` means the budget is gone:
+    // do not run (node reads `timeout: 0` as no timeout at all). Returning ''
+    // lands on the same "nothing to say" path as an empty result.
+    const budget = childBudgetMs();
+    if (budget === null) return '';
     return execFileSync(binary, args, hidden({
       cwd,
-      timeout: 3000,
+      timeout: budget,
       encoding: 'utf8',
       stdio: ['pipe', 'pipe', 'pipe'],
       env: buildRunEnv(),
@@ -553,4 +577,4 @@ if (require.main === module) {
   runMain();
 }
 
-module.exports = { COOLDOWNS, shouldSkip, extractFilePaths, extractSymbols, detectIntents, scoreIntent, INTENT_PATTERNS, INTENT_THRESHOLD, determineQueryType, computeQuietHooks, STOP_WORDS, PLAIN_WORD_EXCLUDE, hasSymptom, SYMPTOM_PATTERNS, buildRunEnv };
+module.exports = { COOLDOWNS, shouldSkip, extractFilePaths, extractSymbols, detectIntents, scoreIntent, INTENT_PATTERNS, INTENT_THRESHOLD, determineQueryType, computeQuietHooks, STOP_WORDS, PLAIN_WORD_EXCLUDE, hasSymptom, SYMPTOM_PATTERNS, buildRunEnv, childBudgetMs, CHILD_TIMEOUT_MS };

package/claude-plugin/templates/code-graph-snapshot.yml

@@ -35,7 +35,7 @@ jobs:
           node-version: '20'
       - name: Build snapshot
         run: |
-          npx -y -p @sdsrs/code-graph@0.139.0 code-graph-mcp snapshot create --out snapshot.db
+          npx -y -p @sdsrs/code-graph@0.140.0 code-graph-mcp snapshot create --out snapshot.db
           zstd -9 snapshot.db -o snapshot.db.zst
           mv snapshot.db.zst "code-graph-snapshot-${GITHUB_SHA:0:7}.db.zst"
       - name: Upload to release

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sdsrs/code-graph",
-  "version": "0.139.0",
+  "version": "0.140.0",
   "description": "MCP server that indexes codebases into an AST knowledge graph with semantic search, call graph traversal, and HTTP route tracing",
   "license": "MIT",
   "repository": {
@@ -35,10 +35,10 @@
     "node": ">=16"
   },
   "optionalDependencies": {
-    "@sdsrs/code-graph-linux-x64": "0.139.0",
-    "@sdsrs/code-graph-linux-arm64": "0.139.0",
-    "@sdsrs/code-graph-darwin-x64": "0.139.0",
-    "@sdsrs/code-graph-darwin-arm64": "0.139.0",
-    "@sdsrs/code-graph-win32-x64": "0.139.0"
+    "@sdsrs/code-graph-linux-x64": "0.140.0",
+    "@sdsrs/code-graph-linux-arm64": "0.140.0",
+    "@sdsrs/code-graph-darwin-x64": "0.140.0",
+    "@sdsrs/code-graph-darwin-arm64": "0.140.0",
+    "@sdsrs/code-graph-win32-x64": "0.140.0"
   }
 }