@sdsrs/code-graph 0.130.0 → 0.131.0

package/claude-plugin/.claude-plugin/plugin.json

@@ -4,7 +4,7 @@
   "author": {
     "name": "sdsrs"
   },
-  "version": "0.130.0",
+  "version": "0.131.0",
   "keywords": [
     "code-graph",
     "ast",

package/claude-plugin/scripts/recommendation-log.js

@@ -27,6 +27,105 @@ const NO_METRICS_FILE = '.no-metrics';
 const ROTATE_MAX_BYTES = 1048576; // 1 MB
 const ROTATE_KEEP_BYTES = 524288; // 512 KB
 
+// Unix-only, atomic: refuse to traverse a final-component symlink on the open
+// itself. Undefined on Windows, where the `lstat` / `fstat` checks below are the
+// only layer — same split as the Rust `utils::owned`. Each layer is pinned by
+// its own test (`refuses … with O_NOFOLLOW unavailable` covers the Windows
+// shape); a suite that only pins the pair lets either half be deleted green.
+const O_NOFOLLOW = fs.constants.O_NOFOLLOW || 0;
+
+// Keyed by path, not a bare boolean: every hook is a one-shot process today, but
+// a module-global flag would silence the diagnostic for the SECOND project if
+// this is ever required from something long-lived.
+const warnedPaths = new Set();
+
+function warnNotOwned(p, why) {
+  if (warnedPaths.has(p)) return;
+  warnedPaths.add(p);
+  try {
+    process.stderr.write(`[code-graph] skipping adoption metrics: ${p} ${why}\n`);
+  } catch {
+    /* stderr closed → nothing to do */
+  }
+}
+
+/**
+ * Reject anything at `p` that is not the ordinary file/directory this module
+ * expects to own. JS twin of Rust `utils::owned::refuse_non_regular` /
+ * `reject_symlinked_dir`: `.code-graph/` is ordinary repo content, so one
+ * `git clone` can carry a symlink where this module expects its own file, and
+ * `writeFileSync` / `appendFileSync` both follow it out of the project (audit
+ * 2026-09-02 P1-1: a 1.2 MB file outside the tree truncated by the rotator).
+ *
+ * Symlink is tested FIRST so each rejection gets its own diagnostic, matching
+ * `reject_symlinked_dir`. The first cut tested `isDirectory()` first, which is
+ * false for a symlink-to-directory — so the symlink arm never ran, the distinct
+ * message was dead, and deleting the whole call changed nothing (pre-tag review,
+ * P3-1).
+ *
+ * Absent is fine — the open will create it.
+ * @param {string} p    absolute path
+ * @param {'file'|'dir'} kind
+ * @param {fs.Stats} [known]  an lstat the caller already took, to avoid a second
+ * @returns {boolean} true if `p` is safe to write
+ */
+function isOwnedPath(p, kind, known) {
+  let st = known;
+  if (!st) {
+    try {
+      st = fs.lstatSync(p);
+    } catch {
+      return true; // absent (or unreadable) → leave it to the real syscall
+    }
+  }
+  if (st.isSymbolicLink()) {
+    warnNotOwned(p, 'is a symlink (following it would write outside the project)');
+    return false;
+  }
+  if (kind === 'dir' ? st.isDirectory() : st.isFile()) return true;
+  warnNotOwned(p, 'is not a regular file');
+  return false;
+}
+
+/**
+ * Open `file` for writing only if the thing actually opened is a file this
+ * module owns. `fstat` on the returned descriptor — not `lstat` on the path —
+ * because that is the only check that describes the object the subsequent write
+ * lands on, closing the lstat→open window on the platforms where `O_NOFOLLOW`
+ * is 0.
+ *
+ * `nlink > 1` refuses a HARDLINK. `lstat` reports a hardlinked victim as a
+ * plain regular file and `O_NOFOLLOW` says nothing about one, so the symlink
+ * guard alone left the identical damage reachable — measured by the pre-tag
+ * review at 1,200,020 → 67 bytes, same as the symlink case. `git` cannot
+ * deliver a hardlink (its index stores no such mode) but `tar x` can.
+ *
+ * Callers must NOT pass `O_TRUNC`: truncation would happen on the open, before
+ * any of this could look. Truncate through the returned descriptor instead.
+ * @returns {number|null} an open fd the caller must close, or null if refused
+ */
+function openOwned(file, flags) {
+  const fd = fs.openSync(file, flags | O_NOFOLLOW);
+  let st;
+  try {
+    st = fs.fstatSync(fd);
+  } catch (e) {
+    fs.closeSync(fd);
+    throw e;
+  }
+  if (!st.isFile()) {
+    warnNotOwned(file, 'is not a regular file');
+    fs.closeSync(fd);
+    return null;
+  }
+  if (st.nlink > 1) {
+    warnNotOwned(file, 'has more than one hard link (the write would reach another path)');
+    fs.closeSync(fd);
+    return null;
+  }
+  return fd;
+}
+
 /**
  * Best-effort size-based rotation: if `file` exceeds ROTATE_MAX_BYTES, rewrite
  * it keeping ~the last ROTATE_KEEP_BYTES, trimmed *forward* to the next line
@@ -42,7 +141,16 @@ function rotateIfNeeded(file) {
     const start = Math.max(0, buf.length - ROTATE_KEEP_BYTES);
     const nl = buf.indexOf(0x0a, start); // first newline at/after start
     const trimStart = nl >= 0 ? nl + 1 : start;
-    fs.writeFileSync(file, buf.subarray(trimStart));
+    // No O_TRUNC: it would empty the target on the open, before `openOwned`
+    // could refuse it. Truncate through the descriptor once it is vouched for.
+    const fd = openOwned(file, fs.constants.O_WRONLY);
+    if (fd === null) return;
+    try {
+      fs.ftruncateSync(fd, 0);
+      fs.writeSync(fd, buf.subarray(trimStart));
+    } finally {
+      fs.closeSync(fd);
+    }
   } catch {
     /* missing file or IO error → skip; the append below still runs */
   }
@@ -58,17 +166,36 @@ function recordRecommendation(cwd, event = {}) {
   try {
     const dir = path.join(cwd, '.code-graph');
     // Append-only: do NOT create .code-graph. Its absence means "not an indexed
-    // project" — recording there would pollute non-project cwds.
-    if (!fs.existsSync(dir)) return false;
+    // project" — recording there would pollute non-project cwds. `lstat`, not
+    // `existsSync`: a symlinked `.code-graph` holding perfectly ordinary files
+    // defeats the per-file guard below, because the write then lands on a real
+    // regular file that simply is not where this hook thinks it is.
+    let dirStat;
+    try {
+      dirStat = fs.lstatSync(dir);
+    } catch {
+      return false; // absent → not an indexed project
+    }
+    if (!isOwnedPath(dir, 'dir', dirStat)) return false;
     // Opt-in metrics silence for dev/dogfood checkouts: when the project marks
     // itself with `.code-graph/.no-metrics`, the tool's own hook/CLI runs (sims,
     // functionality testing) must not self-pollute its adoption metrics. Mirrors
     // the Rust cli::record_cli_use guard. Reversible: delete the file to re-enable.
     if (fs.existsSync(path.join(dir, NO_METRICS_FILE))) return false;
     const file = path.join(dir, REC_FILE);
+    if (!isOwnedPath(file, 'file')) return false;
     rotateIfNeeded(file); // rotate-before-append so the file never exceeds ~max + one line
     const line = JSON.stringify({ ts: new Date().toISOString(), ...event }) + '\n';
-    fs.appendFileSync(file, line);
+    const fd = openOwned(
+      file,
+      fs.constants.O_WRONLY | fs.constants.O_CREAT | fs.constants.O_APPEND
+    );
+    if (fd === null) return false;
+    try {
+      fs.writeSync(fd, line);
+    } finally {
+      fs.closeSync(fd);
+    }
     return true;
   } catch {
     return false;

package/claude-plugin/templates/code-graph-snapshot.yml

@@ -35,7 +35,7 @@ jobs:
           node-version: '20'
       - name: Build snapshot
         run: |
-          npx -y -p @sdsrs/code-graph@0.130.0 code-graph-mcp snapshot create --out snapshot.db
+          npx -y -p @sdsrs/code-graph@0.131.0 code-graph-mcp snapshot create --out snapshot.db
           zstd -9 snapshot.db -o snapshot.db.zst
           mv snapshot.db.zst "code-graph-snapshot-${GITHUB_SHA:0:7}.db.zst"
       - name: Upload to release

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sdsrs/code-graph",
-  "version": "0.130.0",
+  "version": "0.131.0",
   "description": "MCP server that indexes codebases into an AST knowledge graph with semantic search, call graph traversal, and HTTP route tracing",
   "license": "MIT",
   "repository": {
@@ -35,10 +35,10 @@
     "node": ">=16"
   },
   "optionalDependencies": {
-    "@sdsrs/code-graph-linux-x64": "0.130.0",
-    "@sdsrs/code-graph-linux-arm64": "0.130.0",
-    "@sdsrs/code-graph-darwin-x64": "0.130.0",
-    "@sdsrs/code-graph-darwin-arm64": "0.130.0",
-    "@sdsrs/code-graph-win32-x64": "0.130.0"
+    "@sdsrs/code-graph-linux-x64": "0.131.0",
+    "@sdsrs/code-graph-linux-arm64": "0.131.0",
+    "@sdsrs/code-graph-darwin-x64": "0.131.0",
+    "@sdsrs/code-graph-darwin-arm64": "0.131.0",
+    "@sdsrs/code-graph-win32-x64": "0.131.0"
   }
 }