@sdd-method/sdd-cli 1.44.0 → 1.46.0

package/dist/lib/catalogue/aggregate.js

@@ -161,8 +161,7 @@ export async function runCatalogueAggregate(inputs, write) {
     // capability_service.service_id, emitting one row per resolved
     // (consuming-product, platform-capability) pair. Per-SDD builders
     // emit nothing for this catalogue; the aggregator owns it entirely.
-    // See content/plans/v0-9-0-cohort-sweep-derived-bundle.md
-    // §"Cross-SDD platform-capability-edge" + ADR 0134.
+    // See ADR 0134.
     const crossSddRows = deriveCrossSddPlatformCapability(rowsByCatalogue.get("product_platform_dependencies") ?? [], rowsByCatalogue.get("capability_service") ?? [], findings, rowsByCatalogue.get("capabilities") ?? []);
     rowsByCatalogue.set("cross_sdd_platform_capability", crossSddRows);
     // @rule aggregate-feature-integration-support
@@ -184,8 +183,8 @@ export async function runCatalogueAggregate(inputs, write) {
     // The same roots, additionally reachable by DIRECTORY BASENAME. An author who
     // writes a `platform/<name>/...` contract path is reading that name off the
     // filesystem, so it is the directory — which is routinely not the sdd_id (one
-    // estate declares `customer-platform` in a directory named
-    // `sdd-customer-platform`). Kept separate from sddRootsById on purpose: the
+    // estate declares `loyalty-platform` in a directory named
+    // `sdd-loyalty-platform`). Kept separate from sddRootsById on purpose: the
     // try-every-root pass must iterate each root ONCE, or a root reachable under two
     // names would count as two hits and report a false ambiguity.
     const sddRootAliases = new Map(sddRootsById);
@@ -714,7 +713,7 @@ export function dedupExternalSystems(rowsByCatalogue, findings) {
 // adopter-AUTHORED platform/domain ADRs untouched — a collision there is a genuine
 // error and MUST still fail the duplicate-PK check. Mirrors dedupExternalSystems.
 //
-// WHAT COUNTS AS METHOD-DISTRIBUTED (M-ADR 0208 / gov F-E): a row whose doc_path is
+// WHAT COUNTS AS METHOD-DISTRIBUTED (M-ADR 0208): a row whose doc_path is
 // BUNDLE-MANAGED in the contributing SDD's method-baseline.lock. Provenance, not
 // path prefix. The earlier test `startsWith("docs/method/adr/")` was a proxy for
 // the same property and it failed the first time two platform-roots aggregated:
@@ -1384,7 +1383,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
     const exts = rowsByCatalogue.get("c4_external_systems") ?? [];
     const containers = rowsByCatalogue.get("c4_containers") ?? [];
     const deps = rowsByCatalogue.get("system_external_dependency") ?? [];
-    // Camel humps split BEFORE lowercasing (F11a): most SDD ids are
+    // Camel humps split BEFORE lowercasing: most SDD ids are
     // hyphenated, and `posGatewayFramework` must be able to declare
     // `pos-gateway-framework`.
     const norm = (s) => s
@@ -1400,7 +1399,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
         .filter((s) => String(s["product_id"] ?? "") !== "")
         .map((s) => [String(s["product_id"]), String(s["id"])]));
     // Name index — names ambiguous across systems are excluded from matching
-    // (post-F7 duplicates are themselves a finding).
+    // (duplicate system names are themselves a finding).
     const systemsByName = new Map();
     for (const s of systems) {
         const key = compact(String(s["name"] ?? ""));
@@ -1412,7 +1411,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
         else
             systemsByName.set(key, [String(s["id"])]);
     }
-    // Container indexes (F11b): keys (names + slug aliases) are confident
+    // Container indexes: keys (names + slug aliases) are confident
     // only within the DECLARING SDD's own system; across the estate, only a
     // full display-name match counts, and only when it is unique — a
     // diagram-local alias like `emailService` must never bind to an
@@ -1497,7 +1496,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
     }
     const containerNameById = new Map(containers.map((c) => [String(c["id"]), String(c["name"] ?? "")]));
     const containerSystemById = new Map(containers.map((c) => [String(c["id"]), String(c["system_id"] ?? "")]));
-    // F12: containers follow the SAME precedence as systems — declared id
+    // Containers follow the SAME precedence as systems — declared id
     // first, corroborated by the display name; the name alone only as a
     // unique fallback. 0.73.0 inverted this (name-equality only, declared id
     // discarded) and traded two false positives for five silent true
@@ -1552,11 +1551,11 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
         }
         return null;
     };
-    // F11a/F12 corroboration: a declared-id hit converts (or binds) only when
+    // Corroboration: a declared-id hit converts (or binds) only when
     // the display name agrees with the target — diagram entry ids are
     // conventionally local, and an old mnemonic that happens to equal an
     // estate id must not convert silently. Comparison is TOKEN-level, not
-    // substring (F12): "Stockroom Service" must not corroborate `stock`
+    // substring: "Stockroom Service" must not corroborate `stock`
     // (shared prefix, different entity), while "Engine (telematics
     // processor)" must corroborate a container named "Engine" (a richer
     // label must not defeat the match) and three-letter names like "OMS"
@@ -1593,7 +1592,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
     const corroborates = (ext, sysId) => corroboratesLabel(String(ext["name"] ?? ""), nameBysystem.get(sysId) ?? "", sddById.get(sysId) ?? "");
     // A bracketed qualifier ("Email Service [unknown]") is the author
     // declaring uncertainty — it must never be rendered as a confident
-    // referent (F11b/F12): held, with the uncertainty as the stated reason.
+    // referent: held, with the uncertainty as the stated reason.
     const isUncertainLabel = (name) => /\[[^\]]*\]/.test(name);
     const keptExts = [];
     const dropExtIds = new Map();
@@ -1609,7 +1608,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
     let containerConverted = 0;
     let containerEdgesRewritten = 0;
     let systemFallbackEdges = 0;
-    // (F17) edges per candidate, split by whether the member build resolved
+    // Edges per candidate, split by whether the member build resolved
     // the Rel's non-external endpoint to a local container — the datum that
     // decides whether a container-bound candidate can convert without
     // destroying an edge.
@@ -1650,24 +1649,24 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
                 continue;
             }
             if (sys.method === "declared" && !corroborates(ext, sys.id)) {
-                // F11a: declared-id hit without name corroboration — a collision
+                // Declared-id hit without name corroboration — a collision
                 // between a diagram-local mnemonic and an estate id, not a
                 // reference. Kept external, loudly.
                 uncorroboratedKept++;
                 outcomeByExtId.set(extId, "uncorroborated hold");
                 keptExts.push(ext);
                 findings.add("convention", `c4_external_systems: "${extId}" declared_id resolves to internal system "${sys.id}" ` +
-                    `but the display name does not corroborate — kept external; align the entry id or name to convert (M-ADR 0189 §4.2 / F11a)`);
+                    `but the display name does not corroborate — kept external; align the entry id or name to convert (M-ADR 0189 §4.2)`);
                 continue;
             }
             if (isUncertainLabel(String(ext["name"] ?? ""))) {
-                // Declared uncertainty never converts (F12) — held with the
+                // Declared uncertainty never converts — held with the
                 // uncertainty as the stated reason.
                 uncertainHolds++;
                 outcomeByExtId.set(extId, "uncertain hold");
                 keptExts.push(ext);
                 findings.add("coverage", `c4_external_systems: "${extId}" resolves to internal system "${sys.id}" but the label declares uncertainty — ` +
-                    `held, not converted; resolve the uncertainty to convert (M-ADR 0189 §4.4 / F12)`);
+                    `held, not converted; resolve the uncertainty to convert (M-ADR 0189 §4.4)`);
                 continue;
             }
             // Internal reference — convert.
@@ -1692,7 +1691,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
                 uncorroboratedKept++;
                 findings.add("convention", `c4_external_systems: "${extId}"${declaredBy !== "" ? ` (declared by ${declaredBy})` : ""} ` +
                     `declared_id matches internal container "${containerRes.containerId}" but the display name does not corroborate — ` +
-                    `no referent asserted; align the entry id or name to bind (M-ADR 0189 §4.2 / F12)`);
+                    `no referent asserted; align the entry id or name to bind (M-ADR 0189 §4.2)`);
                 keptExts.push(ext);
                 continue;
             }
@@ -1701,7 +1700,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
                 // (already marked as an outcome above)
                 findings.add("coverage", `c4_external_systems: "${extId}"${declaredBy !== "" ? ` (declared by ${declaredBy})` : ""} ` +
                     `matches internal container "${containerRes.containerId}" but the label declares uncertainty — ` +
-                    `held, not asserted; resolve the uncertainty to bind (M-ADR 0189 §4.4 / F12)`);
+                    `held, not asserted; resolve the uncertainty to bind (M-ADR 0189 §4.4)`);
                 keptExts.push(ext);
                 continue;
             }
@@ -1709,17 +1708,17 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
                 ambiguousHolds++;
                 findings.add("coverage", `c4_external_systems: "${extId}"${declaredBy !== "" ? ` (declared by ${declaredBy})` : ""} ` +
                     `name-matches ${containerRes.candidates.length} internal containers [${containerRes.candidates.join(", ")}] — ` +
-                    `ambiguous tier contradiction, no referent asserted, row kept (M-ADR 0189 §4.4 / F11b)`);
+                    `ambiguous tier contradiction, no referent asserted, row kept (M-ADR 0189 §4.4)`);
             }
             else {
-                // F17: a bound candidate CONVERTS — its edges rewrite onto
+                // A bound candidate CONVERTS — its edges rewrite onto
                 // container_dependency where the from-endpoint is known. Only a
                 // candidate with unconvertible edges is kept, with the
                 // contradiction finding stating exactly what blocks it. No edge
                 // is ever destroyed to make a build quieter.
                 containerTargetByExtId.set(extId, containerRes.containerId);
                 const bucket = edgesByExtId.get(extId);
-                // F24 (F17's residue): a stuck edge whose from-SYSTEM differs from
+                // A stuck edge whose from-SYSTEM differs from
                 // the target container's owning system is a correct C4 L1 edge —
                 // it rewrites onto system_system_dependency (from-system → owning
                 // system). Only a stuck edge WITHIN the owning system truly blocks
@@ -1736,13 +1735,13 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
                 tierContradictions++;
                 findings.add("coverage", `c4_external_systems: "${extId}"${declaredBy !== "" ? ` (declared by ${declaredBy})` : ""} ` +
                     `resolves to ${containerRes.kind === "own" ? "its declarer's own" : "an"} internal container "${containerRes.containerId}" — ` +
-                    `tier contradiction, row kept: ${trulyStuck} same-system dependency edge(s) have no member-resolved from-container and would be L1 self-edges (M-ADR 0189 §4.4 / F17/F24)`);
+                    `tier contradiction, row kept: ${trulyStuck} same-system dependency edge(s) have no member-resolved from-container and would be L1 self-edges (M-ADR 0189 §4.4)`);
             }
         }
         keptExts.push(ext);
     }
     // Rewrite dependency edges whose external endpoint converted — to a
-    // system (§4.4) or, one tier down, to a container (F17).
+    // system (§4.4) or, one tier down, to a container.
     const keptDeps = [];
     const newEdges = new Map();
     const newContainerEdges = new Map();
@@ -1753,7 +1752,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
         if (containerTarget !== undefined) {
             const fromContainer = String(dep["from_container_id"] ?? "");
             if (fromContainer === "") {
-                // F24: no member-resolved from-container. Across systems this is a
+                // No member-resolved from-container. Across systems this is a
                 // correct C4 L1 edge — from-system → the container's owning system.
                 // Within the owning system it would be an L1 self-edge: kept, and
                 // its candidate row was kept for it.
@@ -1782,7 +1781,7 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
             }
             if (fromContainer === containerTarget) {
                 findings.add("coverage", `container_dependency: refused self-edge ${fromContainer} → ${containerTarget} ` +
-                    `(external declaration resolved to the declaring container itself; M-ADR 0189 §4.4 / F17)`);
+                    `(external declaration resolved to the declaring container itself; M-ADR 0189 §4.4)`);
                 continue;
             }
             const cid = `${fromContainer}__${containerTarget}`;
@@ -1829,13 +1828,13 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
         }
         edgesRewritten++;
     }
-    // §4.6 (WS15): exemptions vs outcomes, then the coverage predicate.
+    // §4.6: exemptions vs outcomes, then the coverage predicate.
     // An exemption on a CONVERTED candidate contradicts the adjudication —
     // reported and dropped (it would also dangle). A kept candidate with no
-    // outcome and no exemption is the silent bucket L4 lived in: reported
+    // outcome and no exemption is a silent bucket: reported
     // unverified, one finding per candidate, retired by declared identity
     // or by an asserted exemption.
-    // F15: the builder docstring — "each row retires exactly one unverified
+    // The builder docstring — "each row retires exactly one unverified
     // finding, and nothing else" — is enforced here, not assumed. A kept
     // exemption MUST retire exactly one unverified finding; one that retires
     // nothing (its candidate converted, or already has an adjudication
@@ -1857,17 +1856,17 @@ export function adjudicateExternalSystems(rowsByCatalogue, findings) {
         const containerDrop = containerDroppedByExtId.get(target);
         if (containerDrop !== undefined) {
             findings.add("convention", `external_system_exemption: "${target}" is asserted genuinely external but adjudication resolved it to ` +
-                `internal container "${containerDrop}" — contradiction; exemption dropped (M-ADR 0189 §4.6 / F17)`);
+                `internal container "${containerDrop}" — contradiction; exemption dropped (M-ADR 0189 §4.6)`);
             continue;
         }
         const outcome = outcomeByExtId.get(target);
         if (outcome !== undefined) {
             findings.add("convention", `external_system_exemption: "${target}" retires nothing — the candidate already has an adjudication ` +
-                `outcome (${outcome}); exemption dropped (M-ADR 0189 §4.6 / F15)`);
+                `outcome (${outcome}); exemption dropped (M-ADR 0189 §4.6)`);
             continue;
         }
         if (!keptExtIds.has(target)) {
-            findings.add("convention", `external_system_exemption: "${target}" names no kept external-system candidate — exemption dropped (M-ADR 0189 §4.6 / F15)`);
+            findings.add("convention", `external_system_exemption: "${target}" names no kept external-system candidate — exemption dropped (M-ADR 0189 §4.6)`);
             continue;
         }
         keptExemptions.push(ex);
@@ -2221,7 +2220,7 @@ async function fileExists(absPath) {
  *
  * ASYNC shared-stream dependencies (M-ADR 0192) — a dependency whose
  * `contract_type` is in the async set (`event`/`event-stream`/`stream`) — have
- * no single realiser service and carry an empty `target_service_id`. The F18
+ * no single realiser service and carry an empty `target_service_id`. The
  * synchronous realiser-join does not apply to them: instead they resolve via
  * the capability leg (`target_capability_id` against any `capability_service`
  * row for that capability) and emit the (consuming-product, platform-capability)
@@ -2309,7 +2308,7 @@ export function deriveCrossSddPlatformCapability(productPlatformDeps, capability
         if (consumingProductId === "")
             continue;
         // M-ADR 0192: an async shared-stream dependency has no realiser service.
-        // The F18 pair-join cannot apply — resolve via the capability leg and emit
+        // The pair-join cannot apply — resolve via the capability leg and emit
         // the (consuming-product, platform-capability) edge with an empty service.
         if (isAsyncContractType(contractType)) {
             if (targetCapabilityId === "")
@@ -2351,7 +2350,7 @@ export function deriveCrossSddPlatformCapability(productPlatformDeps, capability
             findings.add("orphan", `cross_sdd_platform_capability: ${consumingSddId}/${consumingProductId} declares target_service_id="${targetServiceId}" but no capability_service row resolves it ecosystem-wide`);
             continue;
         }
-        // F18: validate the declared PAIR, not each column alone. Both columns
+        // Validate the declared PAIR, not each column alone. Both columns
         // resolving independently while no capability_service row binds them
         // is a false pairing accepted in silence — the evidence table for the
         // pair exists and was never consulted.
@@ -2364,7 +2363,7 @@ export function deriveCrossSddPlatformCapability(productPlatformDeps, capability
                     .join(", ");
                 findings.add("divergence", `product_platform_dependencies: ${consumingSddId}/${consumingProductId} declares the pair ` +
                     `(target_capability_id="${declaredCapability}", target_service_id="${targetServiceId}") but no ` +
-                    `capability_service row binds them — the service resolves to [${actual}] (F18)`);
+                    `capability_service row binds them — the service resolves to [${actual}]`);
             }
         }
         for (const match of matches) {