@sdd-method/maintain-cli 0.5.0 → 0.7.0

package/scripts/validate-app-dependencies.sh

@@ -11,23 +11,23 @@
 #
 # Checks (for each entry in app-platform-dependencies.yaml), split by whether they
 # need a platform surface at all — LOCAL checks run wherever the app repo is:
-#   1.  (local)    required_stability is a valid value (provisional | locked | unknown)
+#   1.  (local)    required_stability is a valid value (provisional | stable | unknown)
 #   2a. (local)    service_id is declared and non-empty
 #   2b. (platform) service_id resolves against the platform source of truth:
 #                  catalogues/services.csv (exact id match) when the catalogue exists,
 #                  else docs/platform/service-architecture.md (word-anchored match)
-#   3a. (local)    a `locked` dependency declares a contract_path at all
+#   3a. (local)    a `stable` dependency declares a contract_path at all
 #   3b. (platform) that contract_path resolves to a file under the platform root
 #
 # Outputs a dependency status table.
-# Used as the Stage 6 agreement gate in the App Exploration Workflow.
+# Used as the Stage 9 agreement gate in the App Exploration Workflow.
 #
 # THE STABILITY VOCABULARY, AND WHY IT IS WHAT IT IS
 #   `required_stability` states the CONSUMING app's expectation of contract
 #   stability. Three values express that:
 #
 #     provisional  the contract may still change; the app tolerates it
-#     locked       the contract is fixed; a contract_path must exist (check 3)
+#     stable       the contract is fixed; a contract_path must exist (check 3)
 #     unknown      the expectation is not determined
 #
 #   `unknown` is accepted because the canonical schema's
@@ -158,7 +158,7 @@ APP_DEPS_FILE="$APP_ROOT/app-platform-dependencies.yaml"
 #   This gate read only the forward file, so an entire equal-status source went
 #   ungated. Measured in one reverse estate: 15 evidence files declaring 65
 #   further dependencies, 38 of them `locked` — precisely the population
-#   a Stage 6 agreement gate exists to check — none of which this gate could see.
+#   a Stage 9 agreement gate exists to check — none of which this gate could see.
 #
 #   A source that the catalogue reads and the gate does not is a coverage gap by
 #   construction, so the gate now reads both.
@@ -180,7 +180,7 @@ PLATFORM_SERVICES_CSV="$PLATFORM_ROOT/catalogues/services.csv"
 # offer (instances app-dependency-stability-vocabulary-forward and -reverse).
 VALID_STABILITY_VALUES=(
     "provisional"  # contract may still change; the app tolerates it
-    "locked"       # contract is fixed; check 3 requires a resolvable contract_path
+    "stable"       # contract is fixed; check 3 requires a resolvable contract_path
     "unknown"      # expectation not determined; no contract_path required
 )
 
@@ -353,6 +353,13 @@ validate_dependency() {
     service_id="$(yq e ".platform_dependencies[$index].service_id // \"\"" "$source_file")"
     contract_type="$(yq e ".platform_dependencies[$index].contract_type // \"\"" "$source_file")"
     required_stability="$(yq e ".platform_dependencies[$index].required_stability // \"\"" "$source_file")"
+    # vocabulary-alias: locked -> stable
+    # The fixed-contract stability class was `locked` (M-ADR 0222 §4.1; docs/method/foundations/vocabulary-renames.yaml).
+    # Read as `stable` for one major release and reported; from sdd-cli 3.0.0 it is invalid.
+    if [[ "$required_stability" == "locked" ]]; then
+        log_warn "$source_file: platform_dependencies[$index] uses the former required_stability 'locked', read as 'stable' (M-ADR 0222 §4.1). Run 'sdd-cli migrate vocabulary'; from sdd-cli 3.0.0 the former value is invalid."
+        required_stability="stable"
+    fi
     contract_path="$(yq e ".platform_dependencies[$index].contract_path // \"\"" "$source_file")"
 
     local dep_label="${service_id:-dep[$index]}"
@@ -403,7 +410,7 @@ validate_dependency() {
         done
 
         if [[ "$stability_deprecated" -eq 1 ]]; then
-            log_fail "$dep_label: required_stability '$required_stability' is not a stability value (M-ADR 0204 §4.4). Declare target_locus: '$required_stability' on the entry and give required_stability a real value (${VALID_STABILITY_VALUES[*]}) — a third-party contract can be locked."
+            log_fail "$dep_label: required_stability '$required_stability' is not a stability value (M-ADR 0204 §4.4). Declare target_locus: '$required_stability' on the entry and give required_stability a real value (${VALID_STABILITY_VALUES[*]}) — a third-party contract can be stable."
             ((dep_errors++))
         else
             log_fail "$dep_label: invalid required_stability '$required_stability' (allowed: ${VALID_STABILITY_VALUES[*]})"
@@ -490,26 +497,26 @@ validate_dependency() {
         ((WARNINGS++))
     fi
 
-    # Check 3: a locked dependency declares a contract_path (3a, local) and that path
-    # resolves to a file (3b, needs the platform). Same split, same reason: "locked
+    # Check 3: a stable dependency declares a contract_path (3a, local) and that path
+    # resolves to a file (3b, needs the platform). Same split, same reason: "stable
     # with no path at all" is an app-repo defect that needs nothing external to catch.
-    if [[ "$required_stability" == "locked" ]]; then
+    if [[ "$required_stability" == "stable" ]]; then
         if [[ -z "$contract_path" || "$contract_path" == "null" ]]; then
-            log_fail "$dep_label: required_stability is 'locked' but contract_path is empty"
+            log_fail "$dep_label: required_stability is 'stable' but contract_path is empty"
             ((dep_errors++))
         elif [[ "$PLATFORM_AVAILABLE" -eq 0 ]]; then
             ((UNRESOLVED_CONTRACT_PATHS++))
         else
             local full_contract_path="$PLATFORM_ROOT/$contract_path"
             if [[ ! -f "$full_contract_path" ]]; then
-                log_fail "$dep_label: locked contract_path '$contract_path' does not exist in platform repo"
+                log_fail "$dep_label: stable contract_path '$contract_path' does not exist in platform repo"
                 ((dep_errors++))
             fi
         fi
     elif [[ "$required_stability" == "provisional" || "$required_stability" == "unknown" ]]; then
         # Neither requires a contract_path. If one is declared it is still worth
         # reporting when it does not resolve — silently accepting a path that
-        # points at nothing is how a locked dependency later inherits a dead path.
+        # points at nothing is how a stable dependency later inherits a dead path.
         if [[ -n "$contract_path" && "$contract_path" != "null" && "$PLATFORM_AVAILABLE" -eq 1 ]]; then
             local full_contract_path="$PLATFORM_ROOT/$contract_path"
             if [[ ! -f "$full_contract_path" ]]; then
@@ -552,21 +559,22 @@ print_status_table() {
         local service_id required_stability contract_type contract_path dep_status
         service_id="$(yq e ".platform_dependencies[$i].service_id // \"(missing)\"" "$source_file")"
         required_stability="$(yq e ".platform_dependencies[$i].required_stability // \"(missing)\"" "$source_file")"
+        if [[ "$required_stability" == "locked" ]]; then required_stability="stable"; fi   # the former name, reported above
         contract_type="$(yq e ".platform_dependencies[$i].contract_type // \"(missing)\"" "$source_file")"
         contract_path="$(yq e ".platform_dependencies[$i].contract_path // \"\"" "$source_file")"
 
         # Determine display status
-        if [[ "$required_stability" == "locked" ]]; then
+        if [[ "$required_stability" == "stable" ]]; then
             if [[ -z "$contract_path" || "$contract_path" == "null" ]]; then
-                dep_status="${RED}LOCKED UNMET${NC}"
+                dep_status="${RED}STABLE UNMET${NC}"
             elif [[ "$PLATFORM_AVAILABLE" -eq 0 ]]; then
                 # A declared path that was never resolved is not "OK" and not "UNMET".
                 # Reporting either would be a claim the run cannot support.
-                dep_status="${YELLOW}LOCKED UNRESOLVED${NC}"
+                dep_status="${YELLOW}STABLE UNRESOLVED${NC}"
             elif [[ -f "$PLATFORM_ROOT/$contract_path" ]]; then
-                dep_status="${GREEN}LOCKED OK${NC}"
+                dep_status="${GREEN}STABLE OK${NC}"
             else
-                dep_status="${RED}LOCKED UNMET${NC}"
+                dep_status="${RED}STABLE UNMET${NC}"
             fi
         elif [[ "$required_stability" == "provisional" ]]; then
             dep_status="${YELLOW}PROVISIONAL${NC}"
@@ -637,7 +645,7 @@ main() {
     fi
 
     if [[ "$FAILURES" -gt 0 ]]; then
-        log_fail "$FAILURES dependency check(s) failed. Stage 6 agreement gate NOT met."
+        log_fail "$FAILURES dependency check(s) failed. Stage 9 agreement gate NOT met."
         exit 1
     fi
 
@@ -648,7 +656,7 @@ main() {
     # while never executing (M-ADR 0200 §4.3).
     if [[ "$PLATFORM_AVAILABLE" -eq 0 ]]; then
         log_warn "Ran check 1 (stability vocabulary) and the local halves of checks 2-3 over $TOTAL_DEPS dependency(ies): $FAILURES failure(s), $WARNINGS warning(s)."
-        log_warn "NOT RUN, for want of --platform-root: $UNRESOLVED_SERVICE_IDS service_id resolution(s) and $UNRESOLVED_CONTRACT_PATHS locked contract_path resolution(s)."
+        log_warn "NOT RUN, for want of --platform-root: $UNRESOLVED_SERVICE_IDS service_id resolution(s) and $UNRESOLVED_CONTRACT_PATHS stable contract_path resolution(s)."
         log_info "This is a partial run, not a met gate — pass --platform-root to complete it."
         exit 0
     fi
@@ -656,7 +664,7 @@ main() {
     if [[ "$WARNINGS" -gt 0 ]]; then
         log_warn "All required checks passed with $WARNINGS warning(s)."
     else
-        log_pass "All dependency checks passed. Stage 6 agreement gate met."
+        log_pass "All dependency checks passed. Stage 9 agreement gate met."
     fi
     exit 0
 }