@sd-jwt/core 0.9.3-next.3 → 0.10.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [0.10.0](https://github.com/openwallet-foundation-labs/sd-jwt-js/compare/v0.9.2...v0.10.0) (2025-03-24)
+
+
+### Features
+
+* fix encoding bug for flattenJSON and generalJSON ([#277](https://github.com/openwallet-foundation-labs/sd-jwt-js/issues/277)) ([cc455a6](https://github.com/openwallet-foundation-labs/sd-jwt-js/commit/cc455a6f3d431fa59cca1d21dad49daac135d3bc))
+
+
+
+
+
 ## [0.9.2](https://github.com/openwallet-foundation-labs/sd-jwt-js/compare/v0.9.1...v0.9.2) (2025-01-29)
 
 **Note:** Version bump only for package @sd-jwt/core

package/dist/index.js

@@ -489,10 +489,16 @@ var FlattenJSON = class _FlattenJSON {
   }
   toEncoded() {
     var _a;
+    const data = [];
     const jwt = `${this.protected}.${this.payload}.${this.signature}`;
-    const disclosures = this.disclosures.join(import_types3.SD_SEPARATOR);
+    data.push(jwt);
+    if (this.disclosures && this.disclosures.length > 0) {
+      const disclosures = this.disclosures.join(import_types3.SD_SEPARATOR);
+      data.push(disclosures);
+    }
     const kb_jwt = (_a = this.kb_jwt) != null ? _a : "";
-    return [jwt, disclosures, kb_jwt].join(import_types3.SD_SEPARATOR);
+    data.push(kb_jwt);
+    return data.join(import_types3.SD_SEPARATOR);
   }
 };
 
@@ -576,11 +582,17 @@ var GeneralJSON = class _GeneralJSON {
     if (index < 0 || index >= this.signatures.length) {
       throw new import_utils6.SDJWTException("Index out of bounds");
     }
+    const data = [];
     const { protected: protectedHeader, signature } = this.signatures[index];
-    const disclosures = this.disclosures.join(import_types4.SD_SEPARATOR);
-    const kb_jwt = (_a = this.kb_jwt) != null ? _a : "";
     const jwt = `${protectedHeader}.${this.payload}.${signature}`;
-    return [jwt, disclosures, kb_jwt].join(import_types4.SD_SEPARATOR);
+    data.push(jwt);
+    if (this.disclosures && this.disclosures.length > 0) {
+      const disclosures = this.disclosures.join(import_types4.SD_SEPARATOR);
+      data.push(disclosures);
+    }
+    const kb = (_a = this.kb_jwt) != null ? _a : "";
+    data.push(kb);
+    return data.join(import_types4.SD_SEPARATOR);
   }
   addSignature(protectedHeader, signer, kid) {
     return __async(this, null, function* () {

package/dist/index.mjs

@@ -474,10 +474,16 @@ var FlattenJSON = class _FlattenJSON {
   }
   toEncoded() {
     var _a;
+    const data = [];
     const jwt = `${this.protected}.${this.payload}.${this.signature}`;
-    const disclosures = this.disclosures.join(SD_SEPARATOR2);
+    data.push(jwt);
+    if (this.disclosures && this.disclosures.length > 0) {
+      const disclosures = this.disclosures.join(SD_SEPARATOR2);
+      data.push(disclosures);
+    }
     const kb_jwt = (_a = this.kb_jwt) != null ? _a : "";
-    return [jwt, disclosures, kb_jwt].join(SD_SEPARATOR2);
+    data.push(kb_jwt);
+    return data.join(SD_SEPARATOR2);
   }
 };
 
@@ -561,11 +567,17 @@ var GeneralJSON = class _GeneralJSON {
     if (index < 0 || index >= this.signatures.length) {
       throw new SDJWTException5("Index out of bounds");
     }
+    const data = [];
     const { protected: protectedHeader, signature } = this.signatures[index];
-    const disclosures = this.disclosures.join(SD_SEPARATOR3);
-    const kb_jwt = (_a = this.kb_jwt) != null ? _a : "";
     const jwt = `${protectedHeader}.${this.payload}.${signature}`;
-    return [jwt, disclosures, kb_jwt].join(SD_SEPARATOR3);
+    data.push(jwt);
+    if (this.disclosures && this.disclosures.length > 0) {
+      const disclosures = this.disclosures.join(SD_SEPARATOR3);
+      data.push(disclosures);
+    }
+    const kb = (_a = this.kb_jwt) != null ? _a : "";
+    data.push(kb);
+    return data.join(SD_SEPARATOR3);
   }
   addSignature(protectedHeader, signer, kid) {
     return __async(this, null, function* () {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sd-jwt/core",
-  "version": "0.9.3-next.3+b1a1a48",
+  "version": "0.10.0",
   "description": "sd-jwt draft 7 implementation in typescript",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -38,13 +38,13 @@
   },
   "license": "Apache-2.0",
   "devDependencies": {
-    "@sd-jwt/crypto-nodejs": "0.9.3-next.3+b1a1a48"
+    "@sd-jwt/crypto-nodejs": "0.10.0"
   },
   "dependencies": {
-    "@sd-jwt/decode": "0.9.3-next.3+b1a1a48",
-    "@sd-jwt/present": "0.9.3-next.3+b1a1a48",
-    "@sd-jwt/types": "0.9.3-next.3+b1a1a48",
-    "@sd-jwt/utils": "0.9.3-next.3+b1a1a48"
+    "@sd-jwt/decode": "0.10.0",
+    "@sd-jwt/present": "0.10.0",
+    "@sd-jwt/types": "0.10.0",
+    "@sd-jwt/utils": "0.10.0"
   },
   "publishConfig": {
     "access": "public"
@@ -62,5 +62,5 @@
       "esm"
     ]
   },
-  "gitHead": "b1a1a481270e3ad720fc17bd24345a11575f00d6"
+  "gitHead": "afd604d1f15a3b59bcbc43589a13815f657b89fd"
 }

package/src/flattenJSON.ts

@@ -82,9 +82,18 @@ export class FlattenJSON {
   }
 
   public toEncoded() {
+    const data: string[] = [];
+
     const jwt = `${this.protected}.${this.payload}.${this.signature}`;
-    const disclosures = this.disclosures.join(SD_SEPARATOR);
+    data.push(jwt);
+
+    if (this.disclosures && this.disclosures.length > 0) {
+      const disclosures = this.disclosures.join(SD_SEPARATOR);
+      data.push(disclosures);
+    }
+
     const kb_jwt = this.kb_jwt ?? '';
-    return [jwt, disclosures, kb_jwt].join(SD_SEPARATOR);
+    data.push(kb_jwt);
+    return data.join(SD_SEPARATOR);
   }
 }

package/src/generalJSON.ts

@@ -116,12 +116,20 @@ export class GeneralJSON {
     if (index < 0 || index >= this.signatures.length) {
       throw new SDJWTException('Index out of bounds');
     }
+    const data: string[] = [];
 
     const { protected: protectedHeader, signature } = this.signatures[index];
-    const disclosures = this.disclosures.join(SD_SEPARATOR);
-    const kb_jwt = this.kb_jwt ?? '';
     const jwt = `${protectedHeader}.${this.payload}.${signature}`;
-    return [jwt, disclosures, kb_jwt].join(SD_SEPARATOR);
+    data.push(jwt);
+
+    if (this.disclosures && this.disclosures.length > 0) {
+      const disclosures = this.disclosures.join(SD_SEPARATOR);
+      data.push(disclosures);
+    }
+
+    const kb = this.kb_jwt ?? '';
+    data.push(kb);
+    return data.join(SD_SEPARATOR);
   }
 
   public async addSignature(

package/src/index.ts

@@ -18,7 +18,6 @@ import {
   type JwtPayload,
   type Signer,
   IANA_HASH_ALGORITHMS,
-  type HashAlgorithm,
 } from '@sd-jwt/types';
 import { getSDAlgAndPayload } from '@sd-jwt/decode';
 import { FlattenJSON } from './flattenJSON';

package/src/test/flattenJSON.spec.ts

@@ -53,4 +53,70 @@ describe('FlattenJSON', () => {
 
     expect(result.toEncoded()).toEqual(compact);
   });
+
+  test('fromSerialized without disclosures and KB JWT', () => {
+    const flattenJSON = {
+      payload:
+        'eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0',
+      signature:
+        'n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg',
+      protected: 'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9',
+      header: {
+        disclosures: [],
+      },
+    };
+
+    const result = FlattenJSON.fromSerialized(flattenJSON);
+    expect(result).toBeDefined();
+    const compact =
+      'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0.n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg~';
+
+    expect(result.toEncoded()).toEqual(compact);
+  });
+
+  test('fromSerialized without KB JWT', () => {
+    const flattenJSON = {
+      payload:
+        'eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0',
+      signature:
+        'n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg',
+      protected: 'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9',
+      header: {
+        disclosures: [
+          'WyI1ZWI4Yzg2MjM0MDJjZjJlIiwiZmlyc3RuYW1lIiwiSm9obiJd',
+          'WyJjNWMzMWY2ZWYzNTg4MWJjIiwibGFzdG5hbWUiLCJEb2UiXQ',
+          'WyJmYTlkYTUzZWJjOTk3OThlIiwic3NuIiwiMTIzLTQ1LTY3ODkiXQ',
+        ],
+      },
+    };
+
+    const result = FlattenJSON.fromSerialized(flattenJSON);
+    expect(result).toBeDefined();
+    const compact =
+      'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0.n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg~WyI1ZWI4Yzg2MjM0MDJjZjJlIiwiZmlyc3RuYW1lIiwiSm9obiJd~WyJjNWMzMWY2ZWYzNTg4MWJjIiwibGFzdG5hbWUiLCJEb2UiXQ~WyJmYTlkYTUzZWJjOTk3OThlIiwic3NuIiwiMTIzLTQ1LTY3ODkiXQ~';
+
+    expect(result.toEncoded()).toEqual(compact);
+  });
+
+  test('fromSerialized without disclosures', () => {
+    const flattenJSON = {
+      payload:
+        'eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0',
+      signature:
+        'n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg',
+      protected: 'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9',
+      header: {
+        disclosures: [],
+        kb_jwt:
+          'eyJ0eXAiOiJrYitqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpYXQiOjE3MTAwNjk3MjIsImF1ZCI6ImRpZDpleGFtcGxlOjEyMyIsIm5vbmNlIjoiazh2ZGYwbmQ2Iiwic2RfaGFzaCI6Il8tTmJWSzNmczl3VzNHaDNOUktSNEt1NmZDMUwzN0R2MFFfalBXd0ppRkUifQ.pqw2OB5IA5ya9Mxf60hE3nr2gsJEIoIlnuCa4qIisijHbwg3WzTDFmW2SuNvK_ORN0WU6RoGbJx5uYZh8k4EbA',
+      },
+    };
+
+    const result = FlattenJSON.fromSerialized(flattenJSON);
+    expect(result).toBeDefined();
+    const compact =
+      'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0.n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg~eyJ0eXAiOiJrYitqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpYXQiOjE3MTAwNjk3MjIsImF1ZCI6ImRpZDpleGFtcGxlOjEyMyIsIm5vbmNlIjoiazh2ZGYwbmQ2Iiwic2RfaGFzaCI6Il8tTmJWSzNmczl3VzNHaDNOUktSNEt1NmZDMUwzN0R2MFFfalBXd0ppRkUifQ.pqw2OB5IA5ya9Mxf60hE3nr2gsJEIoIlnuCa4qIisijHbwg3WzTDFmW2SuNvK_ORN0WU6RoGbJx5uYZh8k4EbA';
+
+    expect(result.toEncoded()).toEqual(compact);
+  });
 });

package/src/test/generalJSON.spec.ts

@@ -20,7 +20,7 @@ const createSignerVerifier = () => {
   return { signer, verifier };
 };
 
-describe('FlattenJSON', () => {
+describe('GeneralJSON', () => {
   test('fromEncode', () => {
     const compact =
       'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0.n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg~WyI1ZWI4Yzg2MjM0MDJjZjJlIiwiZmlyc3RuYW1lIiwiSm9obiJd~WyJjNWMzMWY2ZWYzNTg4MWJjIiwibGFzdG5hbWUiLCJEb2UiXQ~WyJmYTlkYTUzZWJjOTk3OThlIiwic3NuIiwiMTIzLTQ1LTY3ODkiXQ~eyJ0eXAiOiJrYitqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpYXQiOjE3MTAwNjk3MjIsImF1ZCI6ImRpZDpleGFtcGxlOjEyMyIsIm5vbmNlIjoiazh2ZGYwbmQ2Iiwic2RfaGFzaCI6Il8tTmJWSzNmczl3VzNHaDNOUktSNEt1NmZDMUwzN0R2MFFfalBXd0ppRkUifQ.pqw2OB5IA5ya9Mxf60hE3nr2gsJEIoIlnuCa4qIisijHbwg3WzTDFmW2SuNvK_ORN0WU6RoGbJx5uYZh8k4EbA';
@@ -79,6 +79,81 @@ describe('FlattenJSON', () => {
     expect(result.toEncoded(0)).toEqual(compact);
   });
 
+  test('fromSerialized without disclosures, KB JWT', () => {
+    const generalJSON = {
+      payload:
+        'eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0',
+      signatures: [
+        {
+          protected: 'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9',
+          signature:
+            'n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg',
+          header: {
+            disclosures: [],
+          },
+        },
+      ],
+    };
+
+    const compact =
+      'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0.n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg~';
+    const result = GeneralJSON.fromSerialized(generalJSON);
+    expect(result).toBeDefined();
+    expect(result.toEncoded(0)).toEqual(compact);
+  });
+
+  test('fromSerialized without KB JWT', () => {
+    const generalJSON = {
+      payload:
+        'eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0',
+      signatures: [
+        {
+          protected: 'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9',
+          signature:
+            'n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg',
+          header: {
+            disclosures: [
+              'WyI1ZWI4Yzg2MjM0MDJjZjJlIiwiZmlyc3RuYW1lIiwiSm9obiJd',
+              'WyJjNWMzMWY2ZWYzNTg4MWJjIiwibGFzdG5hbWUiLCJEb2UiXQ',
+              'WyJmYTlkYTUzZWJjOTk3OThlIiwic3NuIiwiMTIzLTQ1LTY3ODkiXQ',
+            ],
+          },
+        },
+      ],
+    };
+
+    const compact =
+      'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0.n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg~WyI1ZWI4Yzg2MjM0MDJjZjJlIiwiZmlyc3RuYW1lIiwiSm9obiJd~WyJjNWMzMWY2ZWYzNTg4MWJjIiwibGFzdG5hbWUiLCJEb2UiXQ~WyJmYTlkYTUzZWJjOTk3OThlIiwic3NuIiwiMTIzLTQ1LTY3ODkiXQ~';
+    const result = GeneralJSON.fromSerialized(generalJSON);
+    expect(result).toBeDefined();
+    expect(result.toEncoded(0)).toEqual(compact);
+  });
+
+  test('fromSerialized without disclosures', () => {
+    const generalJSON = {
+      payload:
+        'eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0',
+      signatures: [
+        {
+          protected: 'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9',
+          signature:
+            'n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg',
+          header: {
+            disclosures: [],
+            kb_jwt:
+              'eyJ0eXAiOiJrYitqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpYXQiOjE3MTAwNjk3MjIsImF1ZCI6ImRpZDpleGFtcGxlOjEyMyIsIm5vbmNlIjoiazh2ZGYwbmQ2Iiwic2RfaGFzaCI6Il8tTmJWSzNmczl3VzNHaDNOUktSNEt1NmZDMUwzN0R2MFFfalBXd0ppRkUifQ.pqw2OB5IA5ya9Mxf60hE3nr2gsJEIoIlnuCa4qIisijHbwg3WzTDFmW2SuNvK_ORN0WU6RoGbJx5uYZh8k4EbA',
+          },
+        },
+      ],
+    };
+
+    const compact =
+      'eyJ0eXAiOiJzZCtqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpZCI6IjEyMzQiLCJfc2QiOlsiYkRUUnZtNS1Zbi1IRzdjcXBWUjVPVlJJWHNTYUJrNTdKZ2lPcV9qMVZJNCIsImV0M1VmUnlsd1ZyZlhkUEt6Zzc5aGNqRDFJdHpvUTlvQm9YUkd0TW9zRmsiLCJ6V2ZaTlMxOUF0YlJTVGJvN3NKUm4wQlpRdldSZGNob0M3VVphYkZyalk4Il0sIl9zZF9hbGciOiJzaGEtMjU2In0.n27NCtnuwytlBYtUNjgkesDP_7gN7bhaLhWNL4SWT6MaHsOjZ2ZMp987GgQRL6ZkLbJ7Cd3hlePHS84GBXPuvg~eyJ0eXAiOiJrYitqd3QiLCJhbGciOiJFUzI1NiJ9.eyJpYXQiOjE3MTAwNjk3MjIsImF1ZCI6ImRpZDpleGFtcGxlOjEyMyIsIm5vbmNlIjoiazh2ZGYwbmQ2Iiwic2RfaGFzaCI6Il8tTmJWSzNmczl3VzNHaDNOUktSNEt1NmZDMUwzN0R2MFFfalBXd0ppRkUifQ.pqw2OB5IA5ya9Mxf60hE3nr2gsJEIoIlnuCa4qIisijHbwg3WzTDFmW2SuNvK_ORN0WU6RoGbJx5uYZh8k4EbA';
+    const result = GeneralJSON.fromSerialized(generalJSON);
+    expect(result).toBeDefined();
+    expect(result.toEncoded(0)).toEqual(compact);
+  });
+
   test('add signature', async () => {
     const { signer } = createSignerVerifier();
 
@@ -112,7 +187,6 @@ describe('FlattenJSON', () => {
       'key-1',
     );
     const resultJson = result.toJson();
-    console.log(resultJson);
 
     expect(resultJson.signatures.length).toEqual(2);
     expect(resultJson.signatures[1].header.kid).toEqual('key-1');