@scrypted/server 0.0.131 → 0.0.135

package/src/runtime.ts

@@ -1,6 +1,6 @@
 import { Level } from './level';
 import { PluginHost } from './plugin/plugin-host';
-import { ScryptedNativeId, Device, EngineIOHandler, HttpRequest, HttpRequestHandler, OauthClient, PushHandler, ScryptedDevice, ScryptedInterface, ScryptedInterfaceProperty } from '@scrypted/sdk/types';
+import { ScryptedNativeId, Device, EngineIOHandler, HttpRequest, HttpRequestHandler, OauthClient, PushHandler, ScryptedDevice, ScryptedInterface, ScryptedInterfaceProperty } from '@scrypted/types';
 import { PluginDeviceProxyHandler } from './plugin/plugin-device';
 import { Plugin, PluginDevice, ScryptedAlert } from './db-types';
 import { getState, ScryptedStateManager, setState } from './state';
@@ -313,6 +313,18 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
         }
     }
 
+    async getPackageJson(pluginId: string) {
+        let packageJson;
+        if (this.plugins[pluginId]) {
+            packageJson = this.plugins[pluginId].packageJson;
+        }
+        else {
+            const plugin = await this.datastore.tryGet(Plugin, pluginId);
+            packageJson = plugin.packageJson;
+        }
+        return packageJson;
+    }
+
     handleEngineIOEndpoint(req: Request, res: ServerResponse, endpointRequest: HttpRequest, pluginData: HttpPluginData) {
         const { pluginHost, pluginDevice } = pluginData;
 
@@ -341,6 +353,11 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
         const existing = this.plugins[pluginId];
         if (existing) {
             delete this.plugins[pluginId];
+
+            if (existing.worker === PluginHost.sharedWorker) {
+                PluginHost.sharedWorkerImmediateRestart = true;
+                setTimeout(() => PluginHost.sharedWorkerImmediateRestart = false, 10000);
+            }
             existing.kill();
         }
     }
@@ -479,11 +496,14 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
     }
 
     setupPluginHostAutoRestart(pluginHost: PluginHost) {
+        const usingSharedWorker = pluginHost.worker === PluginHost.sharedWorker;
+
         pluginHost.worker.once('exit', () => {
             if (pluginHost.killed)
                 return;
             pluginHost.kill();
-            console.error('plugin unexpectedly exited, restarting in 1 minute', pluginHost.pluginId);
+            const timeout = usingSharedWorker && PluginHost.sharedWorkerImmediateRestart ? 0 : 60000;
+            console.error(`plugin unexpectedly exited, restarting in ${timeout}ms`, pluginHost.pluginId);
             setTimeout(async () => {
                 const existing = this.plugins[pluginHost.pluginId];
                 if (existing !== pluginHost) {
@@ -503,7 +523,7 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
                 catch (e) {
                     console.error('error restarting plugin', plugin._id, e);
                 }
-            }, 60000);
+            }, timeout);
         });
     }
 
@@ -621,7 +641,12 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
         const providedRoom = device.room;
         const isUsingDefaultRoom = getDisplayRoom(pluginDevice) === getProvidedRoomOrDefault(pluginDevice);
 
-        const providedInterfaces = PluginDeviceProxyHandler.sortInterfaces(device.interfaces);
+        let providedInterfaces = device.interfaces.slice();
+        if (!device.nativeId)
+            providedInterfaces.push(ScryptedInterface.ScryptedPlugin);
+        else
+            providedInterfaces = providedInterfaces.filter(iface => iface !== ScryptedInterface.ScryptedPlugin);
+        providedInterfaces = PluginDeviceProxyHandler.sortInterfaces(providedInterfaces);
         // assure final mixin resolved interface list has at least all the
         // interfaces from the provided. the actual list will resolve lazily.
         let mixinInterfaces: string[] = [];
@@ -671,10 +696,6 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
         return ret;
     }
 
-    async migrate(pluginDevice: PluginDevice) {
-        // nothing right now.
-    }
-
     killall() {
         for (const host of Object.values(this.plugins)) {
             host?.kill();
@@ -689,8 +710,6 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
         process.on('SIGTERM', () => this.killall());
 
         for await (const pluginDevice of this.datastore.getAll(PluginDevice)) {
-            this.migrate(pluginDevice);
-
             // this may happen due to race condition around deletion/update. investigate.
             if (!pluginDevice.state) {
                 this.datastore.remove(pluginDevice);
@@ -699,8 +718,21 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> {
 
             this.pluginDevices[pluginDevice._id] = pluginDevice;
             let mixins: string[] = getState(pluginDevice, ScryptedInterfaceProperty.mixins) || [];
+
+            let dirty = false;
             if (mixins.includes(null) || mixins.includes(undefined)) {
+                dirty = true;
                 setState(pluginDevice, ScryptedInterfaceProperty.mixins, mixins.filter(e => !!e));
+            }
+
+            const interfaces: string[] = getState(pluginDevice, ScryptedInterfaceProperty.providedInterfaces);
+            if (!pluginDevice.nativeId && !interfaces.includes(ScryptedInterface.ScryptedPlugin)) {
+                dirty = true;
+                interfaces.push(ScryptedInterface.ScryptedPlugin);
+                setState(pluginDevice, ScryptedInterfaceProperty.providedInterfaces, PluginDeviceProxyHandler.sortInterfaces(interfaces));
+            }
+
+            if (dirty) {
                 this.datastore.upsert(pluginDevice);
             }
         }

package/src/services/plugin.ts

@@ -1,4 +1,4 @@
-import { ScryptedInterfaceProperty, ScryptedNativeId } from "@scrypted/sdk/types";
+import { ScryptedInterfaceProperty, ScryptedNativeId } from "@scrypted/types";
 import { ScryptedRuntime } from "../runtime";
 import { Plugin } from '../db-types';
 import { getState } from "../state";
@@ -62,15 +62,7 @@ export class PluginComponent {
         return this.scrypted.plugins[pluginId]?.kill();
     }
     async getPackageJson(pluginId: string) {
-        let packageJson;
-        if (this.scrypted.plugins[pluginId]) {
-            packageJson = this.scrypted.plugins[pluginId].packageJson;
-        }
-        else {
-            const plugin = await this.scrypted.datastore.tryGet(Plugin, pluginId);
-            packageJson = plugin.packageJson;
-        }
-        return packageJson;
+        return this.scrypted.getPackageJson(pluginId);
     }
     async getDeviceInfo(id: string) {
         const pluginDevice = this.scrypted.findPluginDeviceById(id);
@@ -82,7 +74,7 @@ export class PluginComponent {
         }
     }
     async getPluginInfo(pluginId: string) {
-        const packageJson = this.getPackageJson(pluginId);
+        const packageJson = await this.getPackageJson(pluginId);
         const host = this.scrypted.plugins[pluginId];
         let rpcObjects = 0;
         if (host.peer) {

package/src/state.ts

@@ -1,5 +1,5 @@
 import { ScryptedRuntime } from "./runtime";
-import { ScryptedNativeId, EventDetails, EventListenerOptions, EventListenerRegister, Refresh, ScryptedInterface, ScryptedInterfaceProperty, SystemDeviceState } from "@scrypted/sdk/types";
+import { ScryptedNativeId, EventDetails, EventListenerOptions, EventListenerRegister, Refresh, ScryptedInterface, ScryptedInterfaceProperty, SystemDeviceState } from "@scrypted/types";
 import { RefreshSymbol } from "./plugin/plugin-device";
 import throttle from 'lodash/throttle';
 import { sleep } from "./sleep";

package/dist/convert.js

@@ -1,117 +0,0 @@
-"use strict";
-var __importDefault = (this && this.__importDefault) || function (mod) {
-    return (mod && mod.__esModule) ? mod : { "default": mod };
-};
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.convert = exports.ensureBuffer = void 0;
-const types_1 = require("@scrypted/sdk/types");
-const node_dijkstra_1 = __importDefault(require("node-dijkstra"));
-const whatwg_mimetype_1 = __importDefault(require("whatwg-mimetype"));
-const axios_1 = __importDefault(require("axios"));
-const https_1 = __importDefault(require("https"));
-function typeMatches(target, candidate) {
-    // candidate will accept anything
-    if (candidate === '*')
-        return true;
-    return target === candidate;
-}
-function mimeMatches(target, candidate) {
-    return typeMatches(target.type, candidate.type) && typeMatches(target.subtype, candidate.subtype);
-}
-const httpsAgent = new https_1.default.Agent({
-    rejectUnauthorized: false
-});
-async function ensureBuffer(data) {
-    if (typeof data === 'string') {
-        const ab = await axios_1.default.get(data, {
-            responseType: 'arraybuffer',
-            httpsAgent,
-        });
-        return Buffer.from(ab.data);
-    }
-    return Buffer.from(data);
-}
-exports.ensureBuffer = ensureBuffer;
-async function convert(converters, mediaObject, toMimeType) {
-    // console.log('converting', mediaObject.mimeType, toMimeType);
-    const mediaMime = new whatwg_mimetype_1.default(mediaObject.mimeType);
-    const outputMime = new whatwg_mimetype_1.default(toMimeType);
-    if (mimeMatches(mediaMime, outputMime)) {
-        return {
-            mimeType: outputMime.essence,
-            data: await mediaObject.getData(),
-        };
-    }
-    const converterIds = new Map();
-    const converterReverseids = new Map();
-    let id = 0;
-    for (const converter of converters) {
-        const cid = (id++).toString();
-        converterIds.set(converter, cid);
-        converterReverseids.set(cid, converter);
-    }
-    const nodes = {};
-    const mediaNode = {};
-    nodes['mediaObject'] = mediaNode;
-    nodes['output'] = {};
-    for (const converter of converters) {
-        try {
-            const inputMime = new whatwg_mimetype_1.default(converter.fromMimeType);
-            const convertedMime = new whatwg_mimetype_1.default(converter.toMimeType);
-            const targetId = converterIds.get(converter);
-            const node = nodes[targetId] = {};
-            for (const candidate of converters) {
-                try {
-                    const candidateMime = new whatwg_mimetype_1.default(candidate.fromMimeType);
-                    if (!mimeMatches(convertedMime, candidateMime))
-                        continue;
-                    const candidateId = converterIds.get(candidate);
-                    node[candidateId] = 1;
-                }
-                catch (e) {
-                    console.warn('skipping converter due to error', e);
-                }
-            }
-            if (mimeMatches(mediaMime, inputMime)) {
-                mediaNode[targetId] = 1;
-            }
-            if (mimeMatches(convertedMime, outputMime)) {
-                node['output'] = 1;
-            }
-        }
-        catch (e) {
-            console.warn('skipping converter due to error', e);
-        }
-    }
-    const graph = new node_dijkstra_1.default();
-    for (const id of Object.keys(nodes)) {
-        graph.addNode(id, nodes[id]);
-    }
-    const route = graph.path('mediaObject', 'output');
-    if (!route || !route.length)
-        throw new Error('no converter found');
-    // pop off the mediaObject start node, no conversion necessary.
-    route.shift();
-    // also remove the output node.
-    route.splice(route.length - 1);
-    let value = await mediaObject.getData();
-    let valueMime = new whatwg_mimetype_1.default(mediaObject.mimeType);
-    for (const node of route) {
-        const converter = converterReverseids.get(node);
-        const targetMime = new whatwg_mimetype_1.default(converter.toMimeType);
-        const inputMime = new whatwg_mimetype_1.default(converter.fromMimeType);
-        if (typeof value === 'string' && !inputMime.parameters.has(types_1.ScryptedMimeTypes.AcceptUrlParameter)) {
-            value = await ensureBuffer(value);
-        }
-        value = await converter.convert(value, valueMime.essence);
-        const type = targetMime.type === '*' ? valueMime.type : targetMime.type;
-        const subtype = targetMime.subtype === '*' ? valueMime.subtype : targetMime.subtype;
-        valueMime = new whatwg_mimetype_1.default(`${type}/${subtype}`);
-    }
-    return {
-        data: value,
-        mimeType: valueMime.essence,
-    };
-}
-exports.convert = convert;
-//# sourceMappingURL=convert.js.map

package/dist/convert.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"convert.js","sourceRoot":"","sources":["../src/convert.ts"],"names":[],"mappings":";;;;;;AAAA,+CAAyE;AACzE,kEAAkC;AAClC,sEAAuC;AAEvC,kDAA0B;AAC1B,kDAA0B;AAE1B,SAAS,WAAW,CAAC,MAAc,EAAE,SAAiB;IAClD,iCAAiC;IACjC,IAAI,SAAS,KAAK,GAAG;QACjB,OAAO,IAAI,CAAC;IAChB,OAAO,MAAM,KAAK,SAAS,CAAC;AAChC,CAAC;AAED,SAAS,WAAW,CAAC,MAAgB,EAAE,SAAmB;IACtD,OAAO,WAAW,CAAC,MAAM,CAAC,IAAI,EAAE,SAAS,CAAC,IAAI,CAAC,IAAI,WAAW,CAAC,MAAM,CAAC,OAAO,EAAE,SAAS,CAAC,OAAO,CAAC,CAAC;AACtG,CAAC;AAED,MAAM,UAAU,GAAG,IAAI,eAAK,CAAC,KAAK,CAAC;IAC/B,kBAAkB,EAAE,KAAK;CAC5B,CAAC,CAAA;AAEK,KAAK,UAAU,YAAY,CAAC,IAAqB;IACpD,IAAI,OAAO,IAAI,KAAK,QAAQ,EAAE;QAC1B,MAAM,EAAE,GAAG,MAAM,eAAK,CAAC,GAAG,CAAC,IAAc,EAAE;YACvC,YAAY,EAAE,aAAa;YAC3B,UAAU;SACb,CAAC,CAAC;QACH,OAAO,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC;KAC/B;IACD,OAAO,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC7B,CAAC;AATD,oCASC;AAEM,KAAK,UAAU,OAAO,CAAC,UAA6B,EAAE,WAA8B,EAAE,UAAkB;IAC3G,+DAA+D;IAC/D,MAAM,SAAS,GAAG,IAAI,yBAAQ,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;IACrD,MAAM,UAAU,GAAG,IAAI,yBAAQ,CAAC,UAAU,CAAC,CAAC;IAE5C,IAAI,WAAW,CAAC,SAAS,EAAE,UAAU,CAAC,EAAE;QACpC,OAAO;YACH,QAAQ,EAAE,UAAU,CAAC,OAAO;YAC5B,IAAI,EAAE,MAAM,WAAW,CAAC,OAAO,EAAE;SACpC,CAAA;KACJ;IAED,MAAM,YAAY,GAAG,IAAI,GAAG,EAA2B,CAAC;IACxD,MAAM,mBAAmB,GAAG,IAAI,GAAG,EAA2B,CAAC;IAC/D,IAAI,EAAE,GAAG,CAAC,CAAC;IACX,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE;QAChC,MAAM,GAAG,GAAG,CAAC,EAAE,EAAE,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC9B,YAAY,CAAC,GAAG,CAAC,SAAS,EAAE,GAAG,CAAC,CAAC;QACjC,mBAAmB,CAAC,GAAG,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;KAC3C;IAED,MAAM,KAAK,GAAQ,EAAE,CAAC;IACtB,MAAM,SAAS,GAAQ,EAAE,CAAC;IAC1B,KAAK,CAAC,aAAa,CAAC,GAAG,SAAS,CAAC;IACjC,KAAK,CAAC,QAAQ,CAAC,GAAG,EAAE,CAAC;IACrB,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE;QAChC,IAAI;YACA,MAAM,SAAS,GAAG,IAAI,yBAAQ,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;YACvD,MAAM,aAAa,GAAG,IAAI,yBAAQ,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC;YACzD,MAAM,QAAQ,GAAG,YAAY,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;YAC7C,MAAM,IAAI,GAAQ,KAAK,CAAC,QAAQ,CAAC,GAAG,EAAE,CAAC;YACvC,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE;gBAChC,IAAI;oBACA,MAAM,aAAa,GAAG,IAAI,yBAAQ,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;oBAC3D,IAAI,CAAC,WAAW,CAAC,aAAa,EAAE,aAAa,CAAC;wBAC1C,SAAS;oBACb,MAAM,WAAW,GAAG,YAAY,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;oBAChD,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC;iBACzB;gBACD,OAAO,CAAC,EAAE;oBACN,OAAO,CAAC,IAAI,CAAC,iCAAiC,EAAE,CAAC,CAAC,CAAA;iBACrD;aACJ;YAED,IAAI,WAAW,CAAC,SAAS,EAAE,SAAS,CAAC,EAAE;gBACnC,SAAS,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC;aAC3B;YACD,IAAI,WAAW,CAAC,aAAa,EAAE,UAAU,CAAC,EAAE;gBACxC,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC;aACtB;SACJ;QACD,OAAO,CAAC,EAAE;YACN,OAAO,CAAC,IAAI,CAAC,iCAAiC,EAAE,CAAC,CAAC,CAAA;SACrD;KACJ;IAED,MAAM,KAAK,GAAG,IAAI,uBAAK,EAAE,CAAC;IAC1B,KAAK,MAAM,EAAE,IAAI,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE;QACjC,KAAK,CAAC,OAAO,CAAC,EAAE,EAAE,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC;KAChC;IAED,MAAM,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAkB,CAAC;IACnE,IAAI,CAAC,KAAK,IAAI,CAAC,KAAK,CAAC,MAAM;QACvB,MAAM,IAAI,KAAK,CAAC,oBAAoB,CAAC,CAAC;IAC1C,+DAA+D;IAC/D,KAAK,CAAC,KAAK,EAAE,CAAC;IACd,+BAA+B;IAC/B,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAC/B,IAAI,KAAK,GAAG,MAAM,WAAW,CAAC,OAAO,EAAE,CAAC;IACxC,IAAI,SAAS,GAAG,IAAI,yBAAQ,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;IACnD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE;QACtB,MAAM,SAAS,GAAG,mBAAmB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAChD,MAAM,UAAU,GAAG,IAAI,yBAAQ,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC;QACtD,MAAM,SAAS,GAAG,IAAI,yBAAQ,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAEvD,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,CAAC,SAAS,CAAC,UAAU,CAAC,GAAG,CAAC,yBAAiB,CAAC,kBAAkB,CAAC,EAAE;YAC9F,KAAK,GAAG,MAAM,YAAY,CAAC,KAAK,CAAC,CAAC;SACrC;QACD,KAAK,GAAG,MAAM,SAAS,CAAC,OAAO,CAAC,KAAK,EAAE,SAAS,CAAC,OAAO,CAAC,CAAC;QAC1D,MAAM,IAAI,GAAG,UAAU,CAAC,IAAI,KAAK,GAAG,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC;QACxE,MAAM,OAAO,GAAG,UAAU,CAAC,OAAO,KAAK,GAAG,CAAC,CAAC,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC;QACpF,SAAS,GAAG,IAAI,yBAAQ,CAAC,GAAG,IAAI,IAAI,OAAO,EAAE,CAAC,CAAC;KAClD;IAED,OAAO;QACH,IAAI,EAAE,KAAK;QACX,QAAQ,EAAE,SAAS,CAAC,OAAO;KAC9B,CAAC;AACN,CAAC;AAxFD,0BAwFC"}

package/src/convert.ts

@@ -1,122 +0,0 @@
-import { BufferConverter, ScryptedMimeTypes } from '@scrypted/sdk/types';
-import Graph from 'node-dijkstra';
-import MimeType from 'whatwg-mimetype';
-import { MediaObjectRemote } from './plugin/plugin-api';
-import axios from 'axios';
-import https from 'https';
-
-function typeMatches(target: string, candidate: string): boolean {
-    // candidate will accept anything
-    if (candidate === '*')
-        return true;
-    return target === candidate;
-}
-
-function mimeMatches(target: MimeType, candidate: MimeType) {
-    return typeMatches(target.type, candidate.type) && typeMatches(target.subtype, candidate.subtype);
-}
-
-const httpsAgent = new https.Agent({
-    rejectUnauthorized: false
-})
-
-export async function ensureBuffer(data: Buffer | string): Promise<Buffer> {
-    if (typeof data === 'string') {
-        const ab = await axios.get(data as string, {
-            responseType: 'arraybuffer',
-            httpsAgent,
-        });
-        return Buffer.from(ab.data);
-    }
-    return Buffer.from(data);
-}
-
-export async function convert(converters: BufferConverter[], mediaObject: MediaObjectRemote, toMimeType: string): Promise<{ data: Buffer | string, mimeType: string }> {
-    // console.log('converting', mediaObject.mimeType, toMimeType);
-    const mediaMime = new MimeType(mediaObject.mimeType);
-    const outputMime = new MimeType(toMimeType);
-
-    if (mimeMatches(mediaMime, outputMime)) {
-        return {
-            mimeType: outputMime.essence,
-            data: await mediaObject.getData(),
-        }
-    }
-
-    const converterIds = new Map<BufferConverter, string>();
-    const converterReverseids = new Map<string, BufferConverter>();
-    let id = 0;
-    for (const converter of converters) {
-        const cid = (id++).toString();
-        converterIds.set(converter, cid);
-        converterReverseids.set(cid, converter);
-    }
-
-    const nodes: any = {};
-    const mediaNode: any = {};
-    nodes['mediaObject'] = mediaNode;
-    nodes['output'] = {};
-    for (const converter of converters) {
-        try {
-            const inputMime = new MimeType(converter.fromMimeType);
-            const convertedMime = new MimeType(converter.toMimeType);
-            const targetId = converterIds.get(converter);
-            const node: any = nodes[targetId] = {};
-            for (const candidate of converters) {
-                try {
-                    const candidateMime = new MimeType(candidate.fromMimeType);
-                    if (!mimeMatches(convertedMime, candidateMime))
-                        continue;
-                    const candidateId = converterIds.get(candidate);
-                    node[candidateId] = 1;
-                }
-                catch (e) {
-                    console.warn('skipping converter due to error', e)
-                }
-            }
-
-            if (mimeMatches(mediaMime, inputMime)) {
-                mediaNode[targetId] = 1;
-            }
-            if (mimeMatches(convertedMime, outputMime)) {
-                node['output'] = 1;
-            }
-        }
-        catch (e) {
-            console.warn('skipping converter due to error', e)
-        }
-    }
-
-    const graph = new Graph();
-    for (const id of Object.keys(nodes)) {
-        graph.addNode(id, nodes[id]);
-    }
-
-    const route = graph.path('mediaObject', 'output') as Array<string>;
-    if (!route || !route.length)
-        throw new Error('no converter found');
-    // pop off the mediaObject start node, no conversion necessary.
-    route.shift();
-    // also remove the output node.
-    route.splice(route.length - 1);
-    let value = await mediaObject.getData();
-    let valueMime = new MimeType(mediaObject.mimeType);
-    for (const node of route) {
-        const converter = converterReverseids.get(node);
-        const targetMime = new MimeType(converter.toMimeType);
-        const inputMime = new MimeType(converter.fromMimeType);
-
-        if (typeof value === 'string' && !inputMime.parameters.has(ScryptedMimeTypes.AcceptUrlParameter)) {
-            value = await ensureBuffer(value);
-        }
-        value = await converter.convert(value, valueMime.essence);
-        const type = targetMime.type === '*' ? valueMime.type : targetMime.type;
-        const subtype = targetMime.subtype === '*' ? valueMime.subtype : targetMime.subtype;
-        valueMime = new MimeType(`${type}/${subtype}`);
-    }
-
-    return {
-        data: value,
-        mimeType: valueMime.essence,
-    };
-}