@scrypted/libav 1.0.3 → 1.0.4

package/lib/index.d.ts

@@ -5,7 +5,11 @@ export interface AVFrame {
     height: number;
     format: string;
     toBuffer(): Buffer;
-    toJpeg(): Buffer;
+    /**
+     *
+     * @param quality 1-31. Lower is better quality.
+     */
+    toJpeg(quality: number): Buffer;
 }
 export interface AVFilter {
     destroy(): void;

package/lib/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;AAOA,kCAEC;AAwBD,4CAEC;AAED,sDAEC;AAvCD,IAAI,KAAU,CAAC;AACf,IAAI,CAAC;IACD,KAAK,GAAG,OAAO,CAAC,wBAAwB,CAAC,CAAC;AAC9C,CAAC;AACD,OAAO,CAAC,EAAE,CAAC;AACX,CAAC;AAED,SAAgB,WAAW;IACvB,OAAO,CAAC,CAAC,KAAK,CAAC;AACnB,CAAC;AAwBD,SAAgB,gBAAgB,CAAC,QAA+B;IAC5D,KAAK,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;AACzC,CAAC;AAED,SAAgB,qBAAqB;IACjC,OAAO,IAAI,KAAK,CAAC,eAAe,EAAE,CAAC;AACvC,CAAC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;AAOA,kCAEC;AA4BD,4CAEC;AAED,sDAEC;AA3CD,IAAI,KAAU,CAAC;AACf,IAAI,CAAC;IACD,KAAK,GAAG,OAAO,CAAC,wBAAwB,CAAC,CAAC;AAC9C,CAAC;AACD,OAAO,CAAC,EAAE,CAAC;AACX,CAAC;AAED,SAAgB,WAAW;IACvB,OAAO,CAAC,CAAC,KAAK,CAAC;AACnB,CAAC;AA4BD,SAAgB,gBAAgB,CAAC,QAA+B;IAC5D,KAAK,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;AACzC,CAAC;AAED,SAAgB,qBAAqB;IACjC,OAAO,IAAI,KAAK,CAAC,eAAe,EAAE,CAAC;AACvC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scrypted/libav",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "dependencies": {
     "node-addon-api": "^8.1.0",
     "prebuild-install": "npm:@scrypted/prebuild-install@^7.1.8"

package/src/frame.cpp

@@ -92,6 +92,13 @@ AVFrameObject::~AVFrameObject()
 Napi::Value AVFrameObject::ToJPEG(const Napi::CallbackInfo &info)
 {
     Napi::Env env = info.Env();
+
+    if (info.Length() < 1 || !info[0].IsNumber())
+    {
+        Napi::TypeError::New(env, "String expected").ThrowAsJavaScriptException();
+        return env.Null();
+    }
+
     if (!frame_)
     {
         Napi::Error::New(env, "Frame object is null").ThrowAsJavaScriptException();
@@ -112,14 +119,14 @@ Napi::Value AVFrameObject::ToJPEG(const Napi::CallbackInfo &info)
         return env.Null();
     }
 
-    c->bit_rate = 400000; // This is generally less relevant for single images
+    c->bit_rate = 2000000; // This is generally less relevant for single images
     c->width = frame_->width;
     c->height = frame_->height;
     c->pix_fmt = (enum AVPixelFormat)frame_->format;
     c->time_base = (AVRational){1, 25};
 
     // Set the JPEG quality
-    int quality = 2; // 1-31, lower is better quality
+    int quality = info[0].As<Napi::Number>().Int32Value(); // 1-31, lower is better quality
     av_opt_set_int(c, "qscale", quality, 0); // Set the quality scale (1-31, lower is better quality)
     av_opt_set_int(c, "qmin", quality, 0);   // Set the minimum quality
     av_opt_set_int(c, "qmax", quality, 0);   // Set the maximum quality
@@ -177,7 +184,7 @@ Napi::Value AVFrameObject::ToBuffer(const Napi::CallbackInfo &info)
     uint8_t *byte_array = (uint8_t *)malloc(buffer_size);
     if (!byte_array)
     {
-        fprintf(stderr, "Failed to allocate memory for byte array\n");
+        Napi::Error::New(env, "Failed to allocate memory for byte array").ThrowAsJavaScriptException();
         return env.Null();
     }
 

package/src/index.ts

@@ -15,7 +15,11 @@ export interface AVFrame {
     height: number;
     format: string;
     toBuffer(): Buffer;
-    toJpeg(): Buffer;
+    /**
+     *
+     * @param quality 1-31. Lower is better quality.
+     */
+    toJpeg(quality: number): Buffer;
 }
 
 export interface AVFilter {