@scrymore/scry-deployer 0.4.1 → 0.5.1

package/bin/cli.js

@@ -147,6 +147,30 @@ async function runDeployment(argv) {
                 '\n⚠️  Metadata was uploaded but not queued for processing.\n' +
                 '   The Storybook is hosted, but its components are NOT being indexed.'
             );
+        } else if (argv.withAnalysis) {
+            // The gap between the two branches above, and the most damaging
+            // state of the three: analysis was asked for, produced nothing, and
+            // this command used to say "Upload successful" and stop. Nothing is
+            // ever indexed, no error is printed, and CI stays green — so the
+            // first sign of trouble is a customer reporting that search is empty
+            // days later (ISSUES.md #24).
+            //
+            // Exit non-zero. The Storybook is hosted, so "failure" overstates it
+            // slightly, but the job asked for was to make components searchable
+            // and that did not happen. A red build is the only signal that gets
+            // acted on.
+            process.exitCode = 1;
+            logger.error(
+                '\n❌ Analysis produced no metadata, so NOTHING WILL BE INDEXED.\n' +
+                '   The Storybook is hosted and browsable, but no component will be\n' +
+                '   searchable from this build.\n\n' +
+                '   You asked for --with-analysis and it did not complete. The cause is\n' +
+                '   in the coverage output above — commonly a missing Playwright browser\n' +
+                '   (run: npx playwright install chromium-headless-shell) or a TypeScript\n' +
+                '   resolution error in the analyzer.\n\n' +
+                '   Exiting non-zero deliberately: a green build here would mean search\n' +
+                '   silently returns nothing.'
+            );
         }
 
     } finally {

package/lib/apiClient.js

@@ -427,12 +427,26 @@ async function uploadBuild(apiClient, target, options) {
     logger.info(`Waiting ${COVERAGE_UPLOAD_DELAY_MS / 1000}s before uploading coverage report...`);
     await sleep(COVERAGE_UPLOAD_DELAY_MS);
 
+    // The retry used to be unguarded, so a second failure threw out of
+    // uploadBuild and the metadata upload below never ran. Coverage is a
+    // report; the metadata archive is what makes components searchable — so a
+    // failure in the optional artifact was silently taking down the essential
+    // one. Observed on a 467-story library: every story captured, nothing
+    // indexed, twice.
     try {
       coverageUpload = await uploadCoverageReportDirectly(apiClient, target, options.coverageReport);
     } catch (error) {
       logger.info('Coverage upload failed; retrying in 60s...');
       await sleep(COVERAGE_RETRY_DELAY_MS);
-      coverageUpload = await uploadCoverageReportDirectly(apiClient, target, options.coverageReport);
+      try {
+        coverageUpload = await uploadCoverageReportDirectly(apiClient, target, options.coverageReport);
+      } catch (retryError) {
+        logger.warn(
+          `⚠️  Coverage report upload failed: ${retryError.message}\n` +
+          '   Continuing — this affects the coverage report only. Screenshots and\n' +
+          '   metadata still upload, so components will still be indexed.'
+        );
+      }
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scrymore/scry-deployer",
-  "version": "0.4.1",
+  "version": "0.5.1",
   "description": "A CLI to automate the deployment of Storybook static builds.",
   "main": "index.js",
   "bin": {