@scriptc/compiler 0.4.3 → 0.4.4

package/dist/frontend/lowering/lower-classes.js

@@ -1,3 +1,4 @@
+import { lowerAsyncLocalStorageOptions } from "./builtins/async-context.js";
 import { DATE_TIME_FIELD, dateRootOf, dateSuperCall, isDatePrototypeMethod, lowerDateSuperMethodCall, } from "./builtins/date-classes.js";
 import { predeclareForwardClass } from "./lower-stmts.js";
 import { lowerDateStaticCall } from "./builtins/dates.js";
@@ -25,7 +26,7 @@ import { lowerZlibStreamNew, zlibClassName, zlibStreamModeOf } from "./builtins/
 import { everyStmtList } from "../../ir/traverse.js";
 import { builtinClassAliasOf, builtinClassRefOf, } from "./builtins/class-values.js";
 import { inlineNamespaceRequireOf, lowerWithInlineRequireInit } from "./cjs-inline-require.js";
-import { BOOL, canDynCheckTo, DATE_T, DYN, F64, bytesOf, RUNTIME_EMITTER_CLASS, RUNTIME_ERROR_CLASSES, RUNTIME_STREAM_CLASSES, STRING, classValueConstructor, UNDEFINED_T, VOID, arrayOf, isSupportedMapKey, isSupportedMapValue, isSupportedSetElem, isUnitType, typeEquals, } from "../../ir/ir.js";
+import { BOOL, canDynCheckTo, DATE_T, DYN, F64, RUNTIME_EMITTER_CLASS, RUNTIME_ERROR_CLASSES, RUNTIME_STREAM_CLASSES, STRING, classValueConstructor, UNDEFINED_T, VOID, arrayOf, isSupportedMapKey, isSupportedMapValue, isSupportedSetElem, isUnitType, typeEquals, } from "../../ir/ir.js";
 import { genericCallInstance, implicitAnyParamSymbolsOf, implicitCallInstance, implicitMonoFile, genericLocalClassResult, } from "./generic-functions.js";
 import { extendInstantiationPath, MAX_INSTANTIATION_RECURSION, } from "./instantiation-path.js";
 import { appendImplicitUndefinedReturn, hasExplicitJsDocReturn } from "./function-returns.js";
@@ -41,8 +42,7 @@ import { isCjsRequireGlobal } from "./lower-node-module.js";
 import { lowerArrayConstructor } from "./containers/array-construction.js";
 import { lowerMapSeedNew, lowerSetSeedNew } from "./containers/collection-methods.js";
 import { lowerObjectConstructor } from "./containers/indexed-objects.js";
-import { knownBufEncoding, lowerNodeModulesBufferConstruct } from "./containers/bytes.js";
-import { isSafeToRepeat } from "./expressions/evaluation-safety.js";
+import { knownBufEncoding, lowerBufferConstruct } from "./containers/bytes.js";
 import { lowerSearchParamsNew } from "./builtins/url.js";
 import { lowerTextCodecNew } from "./builtins/text-codecs.js";
 import { lowerBroadcastChannelNew, lowerMessageChannelNew, lowerWorkerNew, } from "./builtins/workers.js";
@@ -891,7 +891,7 @@ function undefArmedFieldType(lowerer, p) {
     const byKey = new Map();
     const arms = mapped.kind === "union" ? (lowerer.unions.get(mapped.unionId)?.arms ?? []) : [mapped];
     for (const a of arms) {
-        if (a.kind === "map" || a.kind === "regex" || a.kind === "date" || a.kind === "generator") {
+        if (a.kind === "map" || a.kind === "regex" || a.kind === "generator") {
             return null;
         }
         byKey.set(typeKey(a), a);
@@ -3042,7 +3042,6 @@ mixin) {
                     declared.kind !== "union" &&
                     declared.kind !== "dyn" &&
                     declared.kind !== "map" &&
-                    declared.kind !== "date" &&
                     declared.kind !== "generator" &&
                     declared.kind !== "void" &&
                     declared.kind !== "caught";
@@ -8247,9 +8246,9 @@ function isCollectionOrErrorClass(ref) {
 }
 export function lowerNew(lowerer, expr) {
     const loc = locOf(expr);
-    // A dependency's deprecated `new Buffer(...)` fallback (containers/bytes.ts).
+    // The deprecated `new Buffer(...)` (containers/bytes.ts).
     {
-        const buffer = lowerNodeModulesBufferConstruct(lowerer, expr);
+        const buffer = lowerBufferConstruct(lowerer, expr);
         if (buffer)
             return buffer;
     }
@@ -8825,8 +8824,10 @@ export function lowerNew(lowerer, expr) {
             if (arg.type.kind === "string") {
                 return { kind: "libCall", fn: "date.newString", args: [arg], type: DATE_T, loc };
             }
+            // new Date(date): a new Date object with the same time value.
             if (arg.type.kind === "date") {
-                return arg;
+                const time = { kind: "libCall", fn: "date.getTime", args: [arg], type: F64, loc };
+                return { kind: "libCall", fn: "date.newMs", args: [time], type: DATE_T, loc };
             }
             lowerer.noLowering(`new Date of '${lowerer.fmt(arg.type)}' values`, args[0], "pass milliseconds, a date string, or another Date value", symbol);
         }
@@ -9005,7 +9006,7 @@ export function lowerNew(lowerer, expr) {
             if (targs[1]) {
                 lowerer.unsupported("SC1090", expr, `Map values of type '${lowerer.checker.typeToString(targs[1])}' ` +
                     `(Map values must be number, string, boolean, records, class instances, functions, ` +
-                    `typed arrays, arrays, promises, Maps, Sets, or supported unions and checked values)`);
+                    `typed arrays, arrays, promises, Dates, Maps, Sets, or supported unions and checked values)`);
             }
             lowerer.badType(expr, tsType);
         }
@@ -9123,15 +9124,21 @@ export function lowerNew(lowerer, expr) {
             lowerer.badType(expr, tsType);
         }
         // `new AsyncLocalStorage()` (node:async_hooks): a fresh store id —
-        // an f64 handle (type-mapper.ts), the Channel story. Construction options
-        // ({ defaultValue, name }) have no lowering yet.
+        // an f64 handle (type-mapper.ts), the Channel story. The options form
+        // ({ defaultValue, name }) passes the options object as a dyn value.
         if (symbol !== null &&
             ts.symbolName(symbol) === "AsyncLocalStorage" &&
             lowerer.isStdlibSymbol(symbol)) {
-            if ((expr.arguments?.nodes.length ?? 0) > 0) {
-                lowerer.noLowering("new AsyncLocalStorage(options)", expr, "the zero-argument constructor is the supported form (defaultValue/name options have no lowering yet)");
-            }
-            return { kind: "libCall", fn: "als.new", args: [], type: F64, loc };
+            const options = expr.arguments?.nodes[0];
+            if (options === undefined)
+                return { kind: "libCall", fn: "als.new", args: [], type: F64, loc };
+            return {
+                kind: "libCall",
+                fn: "als.newOptions",
+                args: [lowerAsyncLocalStorageOptions(lowerer, options)],
+                type: F64,
+                loc,
+            };
         }
         // `new Promise<T>((resolve) => ...)`: the ambient Promise constructor.
         if (symbol !== null && ts.symbolName(symbol) === "Promise" && lowerer.isStdlibSymbol(symbol)) {
@@ -9201,38 +9208,6 @@ export function lowerNew(lowerer, expr) {
         // families carry pointed hints: each states WHY no honest static
         // lowering exists (or what to use instead).
         if (lowerer.isStdlibSymbol(symbol ?? undefined)) {
-            // The deprecated `new Buffer(string, encoding?)` ctor's string arm
-            // with a NON-STRING first argument and a string second: Node
-            // throws ERR_INVALID_ARG_TYPE synchronously (and DEP0005 never
-            // fires on this throwing path, so the compiled silence matches).
-            // Every other new Buffer form keeps the fence below — the
-            // constructing forms would owe the deprecation warning.
-            if (expr.expression.text === "Buffer" &&
-                expr.arguments?.nodes.length === 2 &&
-                !expr.arguments.nodes.some(ts.isSpreadElement) &&
-                lowerer.mapTypeOf(lowerer.typeOf(expr.arguments.nodes[0]))?.kind !== "string" &&
-                lowerer.mapTypeOf(lowerer.typeOf(expr.arguments.nodes[1]))?.kind === "string") {
-                const first = lowerer.lowerExpr(expr.arguments.nodes[0]);
-                if (first.kind === "unitLit" ||
-                    first.type.kind === "dyn" ||
-                    lowerer.dynConvertible(first.type)) {
-                    const got = first.type.kind === "dyn" ? first : { kind: "dynFrom", value: first, type: DYN, loc };
-                    // The encoding argument still evaluates in Node before the
-                    // throw only via the ctor body's later reads — it does NOT
-                    // observe it before throwing, so dropping it is exact for
-                    // effect-free operands; effectful ones keep the fence.
-                    const enc = lowerer.lowerExpr(expr.arguments.nodes[1]);
-                    if (enc.kind === "strLit" || isSafeToRepeat(enc)) {
-                        return {
-                            kind: "libCall",
-                            fn: "buffer.newStringFail",
-                            args: [got],
-                            type: bytesOf("u8"),
-                            loc,
-                        };
-                    }
-                }
-            }
             const ctorHints = {
                 RegExp: "use a regex literal (/pattern/flags) — constructed regexes have no lowering",
                 String: "boxed wrapper objects have no lowering — use the string primitive (the box is only distinguishable via typeof/identity, which nothing here can honor)",