@scriptc/compiler 0.2.10 → 0.3.0

package/dist/frontend/lowering/lower-classes.js

@@ -7,7 +7,7 @@ import { InternalCompilerError } from "../../errors.js";
  * accessor access, upcasts, `new` expressions, and the builtin Error
  * hierarchy registration. */
 import * as ts from "../ts7/adapter.js";
-import { BOOL, DATE_T, DYN, F64, bytesOf, JSVAL, RUNTIME_EMITTER_CLASS, RUNTIME_ERROR_CLASSES, RUNTIME_STREAM_CLASSES, STRING, UNDEFINED_T, VOID, arrayOf, isSupportedMapKey, isSupportedMapValue, isSupportedSetElem, isUnitType, typeEquals, } from "../../ir/ir.js";
+import { BOOL, DATE_T, DYN, F64, bytesOf, RUNTIME_EMITTER_CLASS, RUNTIME_ERROR_CLASSES, RUNTIME_STREAM_CLASSES, STRING, UNDEFINED_T, VOID, arrayOf, isSupportedMapKey, isSupportedMapValue, isSupportedSetElem, isUnitType, typeEquals, } from "../../ir/ir.js";
 import { genericCallInstance, implicitAnyParamSymbolsOf, implicitCallInstance, implicitMonoFile, } from "./generic-functions.js";
 import { extendInstantiationPath, MAX_INSTANTIATION_RECURSION, } from "./instantiation-path.js";
 import { appendImplicitUndefinedReturn, hasExplicitJsDocReturn } from "./function-returns.js";
@@ -25,7 +25,7 @@ import { isSafeToRepeat } from "./expressions/evaluation-safety.js";
 import { lowerSearchParamsNew } from "./builtins/url.js";
 import { lowerTextCodecNew } from "./builtins/text-codecs.js";
 import { lowerWorkerNew } from "./builtins/workers.js";
-import { requiresDynamicPackageDiag, unsupportedDiag, } from "../../diagnostics/diagnostic.js";
+import { unsupportedPackageValueDiag, unsupportedDiag, } from "../../diagnostics/diagnostic.js";
 import { STREAM_API_MEMBERS, STREAM_PROP_MEMBERS, UNDERSCORE_METHODS, lowerStreamNew, lowerStreamSuperCall, streamCtorShape, } from "./lower-stream.js";
 import { emitOverrideShapeReason, emitSpecSuperForward, emitterRooted, lowerEmitterSuperCall, } from "./lower-event-emitter.js";
 import { declSymbolOf } from "./lower-modules.js";
@@ -779,11 +779,7 @@ function undefArmedFieldType(lowerer, p) {
     const byKey = new Map();
     const arms = mapped.kind === "union" ? (lowerer.unions.get(mapped.unionId)?.arms ?? []) : [mapped];
     for (const a of arms) {
-        if (a.kind === "map" ||
-            a.kind === "regex" ||
-            a.kind === "date" ||
-            a.kind === "jsval" ||
-            a.kind === "generator") {
+        if (a.kind === "map" || a.kind === "regex" || a.kind === "date" || a.kind === "generator") {
             return null;
         }
         byKey.set(typeKey(a), a);
@@ -1039,11 +1035,7 @@ function inferredEmptyCollectionFieldType(lowerer, decl, field, initializer) {
     const mappedArgument = (argument) => {
         const type = lowerer.checker.getBaseTypeOfLiteralType(lowerer.typeOf(argument));
         const mapped = lowerer.mapTypeOf(type);
-        if (!mapped ||
-            mapped.kind === "dyn" ||
-            mapped.kind === "jsval" ||
-            mapped.kind === "void" ||
-            isUnitType(mapped))
+        if (!mapped || mapped.kind === "dyn" || mapped.kind === "void" || isUnitType(mapped))
             return null;
         return mapped;
     };
@@ -2095,7 +2087,6 @@ mixin) {
                 const admitsUndefined = (type.kind === "union" &&
                     (lowerer.unions.get(type.unionId)?.arms.some((a) => a.kind === "undefinedT") ??
                         false)) ||
-                    type.kind === "jsval" ||
                     type.kind === "dyn";
                 if (!member.initializer && !admitsUndefined) {
                     const opts = lowerer.program.getCompilerOptions();
@@ -2692,7 +2683,6 @@ mixin) {
                 const armable = declared !== undefined &&
                     !isUnitType(declared) &&
                     declared.kind !== "union" &&
-                    declared.kind !== "jsval" &&
                     declared.kind !== "dyn" &&
                     declared.kind !== "map" &&
                     declared.kind !== "date" &&
@@ -3047,7 +3037,7 @@ mixin) {
         if (ctor &&
             !mixinForwarding &&
             isJsSourceFile(ctor.getSourceFile()) &&
-            !ctorParams.some((shape) => shape.mode === "rest" || shape.mode === "dynRest" || shape.mode === "islandRest") &&
+            !ctorParams.some((shape) => shape.mode === "rest" || shape.mode === "dynRest") &&
             bodyReadsArguments(ctor)) {
             ctorParams.push({ type: DYN, mode: "arguments" });
         }
@@ -6207,7 +6197,7 @@ export function lowerDerivedCtorBody(lowerer, info, thisLocal, forward) {
                 const surplus = forward === undefined &&
                     !base.builtinError &&
                     !base.builtinEmitter &&
-                    !base.ctorParams.some((param) => param.mode === "rest" || param.mode === "dynRest" || param.mode === "islandRest") &&
+                    !base.ctorParams.some((param) => param.mode === "rest" || param.mode === "dynRest") &&
                     !superCall.arguments.some(ts.isSpreadElement) &&
                     superCall.arguments.length > base.ctorParams.length;
                 let args = surplusSpread
@@ -6818,28 +6808,17 @@ export function lowerNew(lowerer, expr) {
     if (consoleCtor?.module === "console" && consoleCtor.member === "Console") {
         lowerer.noLowering("new console.Console", expr, builtinFenceHintOf("console", "Console"));
     }
-    // `new X(...)` where X is a package-declared class, in a static build:
-    // the per-package requires-dynamic diagnostic (the constructor runs in
-    // the embedded engine). Under --dynamic, X is jsval-typed and lowers
-    // to the construct op below.
-    if (!lowerer.dynamic) {
+    // A package declaration without a compiled constructor cannot provide
+    // a runtime value. Report the package at the construction site.
+    {
         const pkg = ts.isIdentifier(expr.expression)
             ? lowerer.npmPackageOfSymbol(lowerer.resolveValueSymbol(expr.expression) ?? undefined)
             : null;
         if (pkg) {
-            lowerer.pushDiag(requiresDynamicPackageDiag(pkg, loc));
+            lowerer.pushDiag(unsupportedPackageValueDiag(pkg, loc));
             throw new PoisonError();
         }
     }
-    // Island construction: a jsval-typed callee (a package-declared class,
-    // or any 'any'-typed constructor value) runs JS_CallConstructor —
-    // `new Command()` is the npm entry point. Arguments marshal in; the
-    // instance stays an island handle.
-    if (lowerer.isIslandExpr(expr.expression)) {
-        const callee = lowerer.lowerExpr(expr.expression);
-        const args = (expr.arguments ?? []).map((a) => lowerer.jsvalIn(lowerer.lowerExpr(a), a));
-        return { kind: "jsOp", op: "construct", args: [callee, ...args], type: JSVAL, loc };
-    }
     // `new events.EventEmitter()` — the namespace-member (and CJS
     // `require('events').EventEmitter`) construction form: the property's
     // symbol resolves to the same ambient class as the named import.
@@ -7011,7 +6990,7 @@ export function lowerNew(lowerer, expr) {
                 const v = lowerer.lowerExpr(a);
                 if (v.type.kind === "dyn")
                     return v;
-                if (v.kind === "unitLit" || (v.type.kind !== "jsval" && lowerer.dynConvertible(v.type))) {
+                if (v.kind === "unitLit" || lowerer.dynConvertible(v.type)) {
                     return { kind: "dynFrom", value: v, type: DYN, loc };
                 }
                 lowerer.noLowering(`new DOMException with a '${lowerer.fmt(v.type)}' argument`, a, "message strings and string/options-object names lower (Node ToStrings other values — convert explicitly)");
@@ -7336,23 +7315,6 @@ export function lowerNew(lowerer, expr) {
             if (args.length > 1 || args.some(ts.isSpreadElement)) {
                 lowerer.unsupported("SC1090", expr, `${symbol.name} construction with surplus or spread arguments`);
             }
-            if (lowerer.dynamic) {
-                const ctor = {
-                    kind: "jsOp",
-                    op: "globalGet",
-                    name: symbol.name,
-                    args: [],
-                    type: JSVAL,
-                    loc,
-                };
-                return {
-                    kind: "jsOp",
-                    op: "construct",
-                    args: [ctor, ...args.map((arg) => lowerer.jsvalIn(lowerer.lowerExpr(arg), arg))],
-                    type: JSVAL,
-                    loc,
-                };
-            }
             return {
                 kind: "libCall",
                 fn: symbol.name === "WeakMap" ? "weakMap.new" : "weakSet.new",