@scriptc/compiler 0.0.13 → 0.0.14

package/ambient/scriptc-node-fallback.d.ts

@@ -2117,12 +2117,25 @@ declare module "http" {
     options: ServerOptions,
     requestListener?: (req: IncomingMessage, res: ServerResponse) => void,
   ): Server;
+  /* One signature with a UNION first parameter rather than Node's two
+   * overloads: `const requestFn = tls ? https.request : http.request`
+   * (the portless isProxyRunning shape) unions two function types, and
+   * resolving a call on that union collapses each constituent to a
+   * single signature — with an overload SET on both sides the options
+   * literal ends up checked against URL, in either declaration order.
+   * A union parameter has nothing to collapse. The lowering dispatches
+   * on the argument's own type, so it reads the same either way.
+   *
+   * `target` is a URL string or URL object (the spelling a from-scratch
+   * client reaches for first — dialed directly, with a non-http scheme
+   * an ERR_INVALID_PROTOCOL at runtime rather than a type error), or
+   * the options record. */
   export function request(
-    options: RequestOptions,
+    target: RequestOptions | string | URL,
     callback?: (res: IncomingMessage) => void,
   ): ClientRequest;
   export function get(
-    options: RequestOptions,
+    target: RequestOptions | string | URL,
     callback?: (res: IncomingMessage) => void,
   ): ClientRequest;
 }
@@ -2237,12 +2250,16 @@ declare module "https" {
     options: ServerOptions,
     requestListener: (req: IncomingMessage, res: ServerResponse) => void,
   ): Server;
+  /* One signature with a union first parameter, for the request-fn
+   * ternary's sake (see the http block). A URL target takes no options,
+   * which means Node's defaults — the certificate is verified against
+   * the default trust anchors. */
   export function request(
-    options: RequestOptions,
+    target: RequestOptions | string | URL,
     callback?: (res: IncomingMessage) => void,
   ): ClientRequest;
   export function get(
-    options: RequestOptions,
+    target: RequestOptions | string | URL,
     callback?: (res: IncomingMessage) => void,
   ): ClientRequest;
 }

package/dist/backend/emission/emit-exprs.js

@@ -3782,20 +3782,24 @@ export function emitExpr(E, e) {
                     return finish(`scr_http_request_agent(${arg(0)}, ${arg(1)}, ${arg(2)}, ${arg(3)}, ${arg(4)}, ${arg(5)}, ${arg(6)}, ${arg(7)}, ${cbExpr}, ${adapter})`);
                 }
                 case "http.requestUrl":
-                case "http.requestUrlCb": {
+                case "http.requestUrlCb":
+                case "https.requestUrl":
+                case "https.requestUrlCb": {
                     E.usesTimers = true; // an in-flight request holds the loop open
+                    const tls = e.fn.startsWith("https.");
                     let cbExpr = "NULL";
                     let adapter = "NULL";
-                    if (e.fn === "http.requestUrlCb") {
+                    if (e.fn.endsWith("Cb")) {
                         const cbT = e.args[3].type;
                         if (cbT.kind !== "func")
-                            throw new Error("emitter bug: http.requestUrlCb callback not a func");
+                            throw new Error(`emitter bug: ${e.fn} callback not a func`);
                         const cb = args[3];
                         E.moveTemp(cb);
                         cbExpr = cb.name;
                         adapter = cbT.params.length === 0 ? "&scr_http_resp_thunk0" : "&scr_http_resp_thunk_res";
                     }
-                    return finish(`scr_http_request_url(${arg(0)}, ${arg(1)}, ${arg(2)}, ${cbExpr}, ${adapter})`);
+                    const entry = tls ? "scr_https_request_url" : "scr_http_request_url";
+                    return finish(`${entry}(${arg(0)}, ${arg(1)}, ${arg(2)}, ${cbExpr}, ${adapter})`);
                 }
                 case "http.requestConn":
                 case "http.requestConnCb": {