@scientific-method/standard-checker 0.5.1 → 0.6.0

package/dist/load/builds.js

@@ -4,6 +4,20 @@ import { dirname, join } from "node:path";
 import { readText } from "../markdown.js";
 import { locationRule, unlistedFormat } from "../standard.js";
 import { parseYaml } from "../yaml.js";
+/**
+ * Returns a manifest or other-files path as text, or reports it and returns undefined when it is
+ * missing or is a map or list. The YAML reader turns a bare name such as 1990 or 0 into a number,
+ * so a number or boolean is a path written without quotes and is read as its text.
+ */
+function pathText(value, file, missing, problem) {
+    if (value === null || value === undefined || value === "")
+        problem(file, missing);
+    else if (typeof value === "object")
+        problem(file, "a path is text, not a map or list");
+    else
+        return String(value);
+    return undefined;
+}
 /**
  * Reads and checks the manifest of every build entry, and reports a manifest or list of other files
  * that belongs to no build. Returns build ID -> the items of its files list that are maps.
@@ -40,9 +54,16 @@ export function loadBuildFiles({ config, problem }, entries) {
             problem(path, "every item of files is a map of path, format, size and xxh3");
         const files = manifest.files.filter((f) => f && typeof f === "object");
         buildFiles.set(id, files);
+        // A manifest gives one format, size and hash per file, so a path it lists twice is reported
+        // even when the two items agree. Paths compare as text, as in the list of other files.
+        const seen = new Set();
         for (const f of files) {
-            if (!f.path)
-                problem(path, "every file has a path");
+            const p = pathText(f.path, path, "every file has a path", problem);
+            if (p !== undefined) {
+                if (seen.has(p))
+                    problem(path, `${p} is listed twice`);
+                seen.add(p);
+            }
             if (f.format === undefined || f.format === null || f.format === "")
                 problem(path, `${f.path}: every file has a format`);
             else if (!locationRule(f.format))
@@ -105,11 +126,9 @@ export function checkOtherFiles({ problem }, entries, buildFiles) {
                 problem(path, "every item of other_files is a map of path and reason");
                 continue;
             }
-            if (item.path === null || item.path === undefined || item.path === "") {
-                problem(path, "every other file has a path");
+            const other = pathText(item.path, path, "every other file has a path", problem);
+            if (other === undefined)
                 continue;
-            }
-            const other = String(item.path);
             if (item.reason === null || String(item.reason).trim() === "")
                 problem(path, `${other}: every other file gives the reason the manifest leaves it out`);
             if (other.includes("\\"))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scientific-method/standard-checker",
-  "version": "0.5.1",
+  "version": "0.6.0",
   "description": "Checks a restoration's spec/, parity/ and deviations/ against version 1 of the dinorefurb documentation standard.",
   "type": "module",
   "license": "MIT",